[PATCH] D121517: Incorrectly accepts overload of (T&, int) vs. (T const&, U) #54347

2023-01-11 Thread Ed Catmur via Phabricator via cfe-commits
ecatmur added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121517/new/ https://reviews.llvm.org/D121517 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D134231: [clang][C++20] p0960 Allow initializing aggregates from a parenthesized list of values

2022-11-06 Thread Ed Catmur via Phabricator via cfe-commits
ecatmur added a comment. In D134231#3803380 , @shafik wrote: > Hello Ed, thank you for picking up this work. > > I liked the approach in the first PR, did you consider reaching out to the > author is asking if it was ok to commandeer the work to allow it

[PATCH] D134231: [clang][C++20] p0960 Allow initializing aggregates from a parenthesized list of values

2022-09-19 Thread Ed Catmur via Phabricator via cfe-commits
ecatmur created this revision. ecatmur added a reviewer: clang-language-wg. Herald added subscribers: ChuanqiXu, JDevlieghere. Herald added a project: All. ecatmur requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - p0960 Allow initializing a

[PATCH] D121517: Incorrectly accepts overload of (T&, int) vs. (T const&, U) #54347

2022-03-12 Thread Ed Catmur via Phabricator via cfe-commits
ecatmur updated this revision to Diff 414848. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121517/new/ https://reviews.llvm.org/D121517 Files: clang/lib/Sema/SemaTemplateDeduction.cpp clang/test/SemaCXX/overload-call.cpp Index: clang/test/SemaCXX/overload-call.cpp

[PATCH] D121517: Incorrectly accepts overload of (T&, int) vs. (T const&, U) #54347

2022-03-12 Thread Ed Catmur via Phabricator via cfe-commits
ecatmur updated this revision to Diff 414826. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121517/new/ https://reviews.llvm.org/D121517 Files: clang/lib/Sema/SemaTemplateDeduction.cpp clang/test/SemaCXX/overload-call.cpp Index: clang/test/SemaCXX/overload-call.cpp

[PATCH] D121517: Incorrectly accepts overload of (T&, int) vs. (T const&, U) #54347

2022-03-12 Thread Ed Catmur via Phabricator via cfe-commits
ecatmur updated this revision to Diff 414825. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121517/new/ https://reviews.llvm.org/D121517 Files: clang/lib/Sema/SemaTemplateDeduction.cpp clang/test/SemaCXX/overload-call.cpp Index: clang/test/SemaCXX/overload-call.cpp

[PATCH] D121517: Incorrectly accepts overload of (T&, int) vs. (T const&, U) #54347

2022-03-12 Thread Ed Catmur via Phabricator via cfe-commits
ecatmur updated this revision to Diff 414824. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121517/new/ https://reviews.llvm.org/D121517 Files: clang/lib/Sema/SemaTemplateDeduction.cpp clang/test/SemaCXX/overload-call.cpp Index: clang/test/SemaCXX/overload-call.cpp

[PATCH] D121517: Incorrectly accepts overload of (T&, int) vs. (T const&, U) #54347

2022-03-12 Thread Ed Catmur via Phabricator via cfe-commits
ecatmur added a comment. https://github.com/llvm/llvm-project/issues/54347 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121517/new/ https://reviews.llvm.org/D121517 ___ cfe-commits mailing list cfe-comm

[PATCH] D121517: Incorrectly accepts overload of (T&, int) vs. (T const&, U) #54347

2022-03-12 Thread Ed Catmur via Phabricator via cfe-commits
ecatmur created this revision. Herald added a project: All. ecatmur requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. clang correctly rejects as ambiguous: template int f(T&, int); // 1 template int f(T const&, U); // 2 int g(int const& i) {