[clang-tools-extra] [clangd] support the zig c++ compiler wrapper (PR #100759)

2024-12-03 Thread Duncan Ogilvie via cfe-commits
mrexodia wrote: Worked around this by creating a wrapper script `zig-c++`: https://github.com/mrexodia/zig-cross/commit/56b384c96675660554a5d87fe5e5a95bf0bfbe7a https://github.com/llvm/llvm-project/pull/100759 ___ cfe-commits mailing list cfe-commits@

[clang-tools-extra] [clangd] support the zig c++ compiler wrapper (PR #100759)

2024-12-03 Thread Duncan Ogilvie via cfe-commits
https://github.com/mrexodia closed https://github.com/llvm/llvm-project/pull/100759 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] support the zig c++ compiler wrapper (PR #100759)

2024-10-03 Thread Duncan Ogilvie via cfe-commits
mrexodia wrote: Ping! https://github.com/llvm/llvm-project/pull/100759 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lld] [llvm] Embed the command line arguments during LTO (PR #79390)

2024-08-09 Thread Duncan Ogilvie via cfe-commits
https://github.com/mrexodia updated https://github.com/llvm/llvm-project/pull/79390 >From e6737b6e65669160868a85b8a870fe6fd70b94b0 Mon Sep 17 00:00:00 2001 From: Duncan Ogilvie Date: Thu, 25 Jan 2024 00:08:49 +0100 Subject: [PATCH] Embed the command line arguments during LTO --- clang/lib/Cod

[clang-tools-extra] [clangd] support the zig c++ compiler wrapper (PR #100759)

2024-08-09 Thread Duncan Ogilvie via cfe-commits
mrexodia wrote: @kazutakahirata @kadircet @sam-mccall it looks like you were recently touching this file, any chance for a review? https://github.com/llvm/llvm-project/pull/100759 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[clang-tools-extra] [clangd] support the zig c++ compiler wrapper (PR #100759)

2024-07-29 Thread Duncan Ogilvie via cfe-commits
https://github.com/mrexodia edited https://github.com/llvm/llvm-project/pull/100759 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] support the zig c++ compiler wrapper (PR #100759)

2024-07-29 Thread Duncan Ogilvie via cfe-commits
https://github.com/mrexodia edited https://github.com/llvm/llvm-project/pull/100759 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] support the zig c++ compiler wrapper (PR #100759)

2024-07-26 Thread Duncan Ogilvie via cfe-commits
https://github.com/mrexodia edited https://github.com/llvm/llvm-project/pull/100759 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] support the zig c++ compiler wrapper (PR #100759)

2024-07-26 Thread Duncan Ogilvie via cfe-commits
https://github.com/mrexodia edited https://github.com/llvm/llvm-project/pull/100759 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] support the zig c++ compiler wrapper (PR #100759)

2024-07-26 Thread Duncan Ogilvie via cfe-commits
https://github.com/mrexodia created https://github.com/llvm/llvm-project/pull/100759 When using `zig c++` for cross-compiling `clangd` removes the zig command from the command line. Because of this the system include extraction fails. This change detects that the driver executable is named `zi

[lld] [llvm] [clang] Embed the command line arguments during LTO (PR #79390)

2024-01-25 Thread Duncan Ogilvie via cfe-commits
mrexodia wrote: > I haven't checked closely yet, but it seems like you need to add tests. Could you provide some guidance on what kind of tests to add and how to actually run them locally? First I wanted to get the builtkite job to be green, but it seems to be failing on some unrelated test wh

[lld] [llvm] [clang] Embed the command line arguments during LTO (PR #79390)

2024-01-25 Thread Duncan Ogilvie via cfe-commits
@@ -40,6 +41,7 @@ using namespace llvm; namespace lld::wasm { static std::unique_ptr createLTO() { lto::Config c; + c.EmbedCmdArgs = commonContext().cmdArgs; mrexodia wrote: I changed all the `commonContext()` to `context()` (or the `ctx` variable directly

[lld] [llvm] [clang] Embed the command line arguments during LTO (PR #79390)

2024-01-25 Thread Duncan Ogilvie via cfe-commits
https://github.com/mrexodia updated https://github.com/llvm/llvm-project/pull/79390 >From 67280cb8a77931271e685f7c92718d45cfea69a8 Mon Sep 17 00:00:00 2001 From: Duncan Ogilvie Date: Thu, 25 Jan 2024 00:08:49 +0100 Subject: [PATCH] Embed the command line arguments during LTO --- clang/lib/Cod

[llvm] [lld] [clang] Embed the command line arguments during LTO (PR #79390)

2024-01-24 Thread Duncan Ogilvie via cfe-commits
@@ -40,6 +41,7 @@ using namespace llvm; namespace lld::wasm { static std::unique_ptr createLTO() { lto::Config c; + c.EmbedCmdArgs = commonContext().cmdArgs; mrexodia wrote: For most drivers (except ELF) I can access the specialized context directly. But w

[lld] [clang] [llvm] Embed the command line arguments during LTO (PR #79390)

2024-01-24 Thread Duncan Ogilvie via cfe-commits
https://github.com/mrexodia edited https://github.com/llvm/llvm-project/pull/79390 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [lld] [clang] Embed the command line arguments during LTO (PR #79390)

2024-01-24 Thread Duncan Ogilvie via cfe-commits
https://github.com/mrexodia updated https://github.com/llvm/llvm-project/pull/79390 >From 9ca7af3aa2401daeecc50772ebbd58f14d2fa3e9 Mon Sep 17 00:00:00 2001 From: Duncan Ogilvie Date: Thu, 25 Jan 2024 00:08:49 +0100 Subject: [PATCH] Embed the command line arguments during LTO --- clang/lib/Cod

[lld] [clang] [llvm] Embed the command line arguments during LTO (PR #79390)

2024-01-24 Thread Duncan Ogilvie via cfe-commits
@@ -40,6 +41,7 @@ using namespace llvm; namespace lld::wasm { static std::unique_ptr createLTO() { lto::Config c; + c.EmbedCmdArgs = commonContext().cmdArgs; mrexodia wrote: Thanks for the comment! I don't think it makes a difference, except that `context(

[lld] [clang] [llvm] Embed the command line arguments during LTO (PR #79390)

2024-01-24 Thread Duncan Ogilvie via cfe-commits
https://github.com/mrexodia updated https://github.com/llvm/llvm-project/pull/79390 >From d60c2ad5bc88d6b64d7b3d6b179e303e3eeb936c Mon Sep 17 00:00:00 2001 From: Duncan Ogilvie Date: Thu, 25 Jan 2024 00:08:49 +0100 Subject: [PATCH] Embed the command line arguments during LTO --- clang/lib/Cod

[lld] [clang] [llvm] Embed the command line arguments during LTO (PR #79390)

2024-01-24 Thread Duncan Ogilvie via cfe-commits
https://github.com/mrexodia edited https://github.com/llvm/llvm-project/pull/79390 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lld] [clang] [llvm] Embed the command line arguments during LTO (PR #79390)

2024-01-24 Thread Duncan Ogilvie via cfe-commits
https://github.com/mrexodia created https://github.com/llvm/llvm-project/pull/79390 This was previously marked as `FIXME` in `LTOBackend.cpp`. List of changes: - Removed the unused `lto::Config.MllvmArgs` field - Add a new `lto::Config.EmbedCmdArgs` field (`\0`-separated list, since that's how