[PATCH] D26454: Implement no_sanitize_address for global vars

2016-11-14 Thread Douglas Katzman via cfe-commits
dougk updated this revision to Diff 77815. dougk marked an inline comment as done. dougk added a comment. add a sentence about the change in AddressSanitizer.rst https://reviews.llvm.org/D26454 Files: docs/AddressSanitizer.rst lib/CodeGen/SanitizerMetadata.cpp lib/Sema/SemaDeclAttr.cpp

[PATCH] D26454: Implement no_sanitize_address for global vars

2016-11-11 Thread Douglas Katzman via cfe-commits
dougk updated this revision to Diff 77658. dougk marked 2 inline comments as done. dougk added a comment. changes per Aaron Ballman https://reviews.llvm.org/D26454 Files: lib/CodeGen/SanitizerMetadata.cpp lib/Sema/SemaDeclAttr.cpp test/CodeGen/asan-globals.cpp test/SemaCXX/attr-no-sanit

[PATCH] D26459: Fix mismatched enum value name and diagnostic text.

2016-11-11 Thread Douglas Katzman via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL286599: Fix mismatched enum value name and diagnostic text. (authored by dougk). Changed prior to commit: https://reviews.llvm.org/D26459?vs=77367&id=77624#toc Repository: rL LLVM https://reviews.ll

r286599 - Fix mismatched enum value name and diagnostic text.

2016-11-11 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Fri Nov 11 10:51:40 2016 New Revision: 286599 URL: http://llvm.org/viewvc/llvm-project?rev=286599&view=rev Log: Fix mismatched enum value name and diagnostic text. ExpectedFunctionGlobalVarMethodOrProperty would previously say "functions and global variables" instead of "funct

[PATCH] D26454: Implement no_sanitize_address for global vars

2016-11-09 Thread Douglas Katzman via cfe-commits
dougk added a comment. Also note: In this change, the diagnostic messages are correct; it's the enum name that's bad. The diagnostic message is wrong for the 'section' attribute, which is fixed by https://reviews.llvm.org/D26459 https://reviews.llvm.org/D26454 __

[PATCH] D26459: Fix mismatched enum value name and diagnostic text.

2016-11-09 Thread Douglas Katzman via cfe-commits
dougk updated this revision to Diff 77367. dougk added a comment. inadvertent omission of attr-section.c test https://reviews.llvm.org/D26459 Files: include/clang/Basic/Attr.td include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/AttributeList.h test/Sema/attr-section.c Index

[PATCH] D26459: Fix mismatched enum value name and diagnostic text.

2016-11-09 Thread Douglas Katzman via cfe-commits
dougk created this revision. dougk added a reviewer: aaron.ballman. dougk added a subscriber: cfe-commits. Herald added a subscriber: aemerson. ExpectedFunctionGlobalVarMethodOrProperty would previously say "functions and global variables" instead of "functions, methods, properties, and global v

r286380 - [Sparc] Unbreak test

2016-11-09 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Wed Nov 9 11:02:07 2016 New Revision: 286380 URL: http://llvm.org/viewvc/llvm-project?rev=286380&view=rev Log: [Sparc] Unbreak test Modified: cfe/trunk/test/CodeGen/atomics-inlining.c Modified: cfe/trunk/test/CodeGen/atomics-inlining.c URL: http://llvm.org/viewvc/llvm-p

[PATCH] D26454: Implement no_sanitize_address for global vars

2016-11-09 Thread Douglas Katzman via cfe-commits
dougk created this revision. dougk added a reviewer: aaron.ballman. dougk added a subscriber: cfe-commits. This was already submitted as r284272. Regarding the use of Attr as a local variable name, I would prefer to remain consistent with the existing code in CodeGenFunction.cpp which was not to

Re: r284272 - Implement no_sanitize_address for global vars

2016-11-09 Thread Douglas Katzman via cfe-commits
will do. I'll initiate a review for the original change and a new one for the suggestions. The ExpectedFunctionGlobalVarMethodOrProperty diagnostic was essentially a copy-and-paste from here: def Alias : Attr { let Spellings = [GCC<"alias">]; let Args = [StringArgument<"Aliasee">]; let Sub

r286376 - [Sparc] LLONG is not lock-free atomic on v8

2016-11-09 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Wed Nov 9 09:43:51 2016 New Revision: 286376 URL: http://llvm.org/viewvc/llvm-project?rev=286376&view=rev Log: [Sparc] LLONG is not lock-free atomic on v8 Differential Revision: https://reviews.llvm.org/D26286 Modified: cfe/trunk/lib/Basic/Targets.cpp cfe/trunk/test/

[PATCH] D26286: [Sparc]: correct the ATOMIC_LLONG_LOCK_FREE macro

2016-11-09 Thread Douglas Katzman via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL286376: [Sparc] LLONG is not lock-free atomic on v8 (authored by dougk). Changed prior to commit: https://reviews.llvm.org/D26286?vs=76879&id=77353#toc Repository: rL LLVM https://reviews.llvm.org/D

Re: r284272 - Implement no_sanitize_address for global vars

2016-11-08 Thread Douglas Katzman via cfe-commits
25, 2016 at 7:19 PM, Kostya Serebryany wrote: > ping > > On Mon, Oct 17, 2016 at 5:57 PM, Kostya Serebryany wrote: > >> Did you code-review this? >> (sorry if I missed it) >> >> On Fri, Oct 14, 2016 at 12:55 PM, Douglas Katzman via cfe-commits < >> cfe-

[PATCH] D26286: [Sparc]: correct the ATOMIC_LLONG_LOCK_FREE macro

2016-11-03 Thread Douglas Katzman via cfe-commits
dougk updated this revision to Diff 76879. dougk added a comment. fix atomics-inlining test https://reviews.llvm.org/D26286 Files: lib/Basic/Targets.cpp test/CodeGen/atomics-inlining.c test/Preprocessor/init.c Index: test/Preprocessor/init.c =

[PATCH] D26286: [Sparc]: correct the ATOMIC_LLONG_LOCK_FREE macro

2016-11-03 Thread Douglas Katzman via cfe-commits
dougk created this revision. dougk added a reviewer: jyknight. dougk added a subscriber: cfe-commits. https://reviews.llvm.org/D26286 Files: lib/Basic/Targets.cpp test/Preprocessor/init.c Index: test/Preprocessor/init.c === ---

r285144 - [Myriad] add empty file to simulated bin dir

2016-10-25 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Tue Oct 25 18:59:11 2016 New Revision: 285144 URL: http://llvm.org/viewvc/llvm-project?rev=285144&view=rev Log: [Myriad] add empty file to simulated bin dir Added: cfe/trunk/test/Driver/Inputs/basic_myriad_tree/bin/ cfe/trunk/test/Driver/Inputs/basic_myriad_tree/bin/.k

r285140 - [Myriad] Find libc++ adjacent to libstdc++

2016-10-25 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Tue Oct 25 18:02:30 2016 New Revision: 285140 URL: http://llvm.org/viewvc/llvm-project?rev=285140&view=rev Log: [Myriad] Find libc++ adjacent to libstdc++ Modified: cfe/trunk/lib/Driver/ToolChains.cpp cfe/trunk/lib/Driver/Tools.cpp cfe/trunk/test/Driver/myriad-tool

r284617 - [Myriad] Find libc++ headers next to clang binary

2016-10-19 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Wed Oct 19 12:30:40 2016 New Revision: 284617 URL: http://llvm.org/viewvc/llvm-project?rev=284617&view=rev Log: [Myriad] Find libc++ headers next to clang binary Modified: cfe/trunk/lib/Driver/ToolChains.cpp cfe/trunk/test/Driver/myriad-toolchain.c Modified: cfe/trunk

r284272 - Implement no_sanitize_address for global vars

2016-10-14 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Fri Oct 14 14:55:09 2016 New Revision: 284272 URL: http://llvm.org/viewvc/llvm-project?rev=284272&view=rev Log: Implement no_sanitize_address for global vars Modified: cfe/trunk/include/clang/Basic/Attr.td cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td cfe/tr

r283601 - Visually align table def with respective enum. NFC

2016-10-07 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Fri Oct 7 16:02:38 2016 New Revision: 283601 URL: http://llvm.org/viewvc/llvm-project?rev=283601&view=rev Log: Visually align table def with respective enum. NFC 'warn_attribute_wrong_decl_type' has to stay in sync with 'enum AttributeDeclKind' which is much easier when they

r282757 - [Myriad] Silently ignore -fno-split-dwarf-inlining

2016-09-29 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Thu Sep 29 14:59:12 2016 New Revision: 282757 URL: http://llvm.org/viewvc/llvm-project?rev=282757&view=rev Log: [Myriad] Silently ignore -fno-split-dwarf-inlining Modified: cfe/trunk/lib/Driver/Tools.cpp cfe/trunk/test/Driver/myriad-toolchain.c Modified: cfe/trunk/lib

r281071 - Myriad: nominally "support" ASAN.

2016-09-09 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Fri Sep 9 13:20:49 2016 New Revision: 281071 URL: http://llvm.org/viewvc/llvm-project?rev=281071&view=rev Log: Myriad: nominally "support" ASAN. Doesn't work, but needs to be enabled in order to get there. Modified: cfe/trunk/lib/Driver/ToolChains.cpp cfe/trunk/lib/D

r276646 - [Myriad]: better compatibility with vendor source

2016-07-25 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Mon Jul 25 11:36:02 2016 New Revision: 276646 URL: http://llvm.org/viewvc/llvm-project?rev=276646&view=rev Log: [Myriad]: better compatibility with vendor source - Accept ma{2100,2150,2150} for -mcpu - Define more preprocessor macros - Don't append "le/" to little-endian lib d

r268956 - [Myriad] Use Generic_ELF::addClangTargetOptions()

2016-05-09 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Mon May 9 14:09:59 2016 New Revision: 268956 URL: http://llvm.org/viewvc/llvm-project?rev=268956&view=rev Log: [Myriad] Use Generic_ELF::addClangTargetOptions() Modified: cfe/trunk/lib/Driver/ToolChains.cpp cfe/trunk/lib/Driver/ToolChains.h cfe/trunk/test/Driver/m

r266797 - Fix PR26999 better- RenderDebugEnablingArgs() once only

2016-04-19 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Tue Apr 19 13:55:53 2016 New Revision: 266797 URL: http://llvm.org/viewvc/llvm-project?rev=266797&view=rev Log: Fix PR26999 better- RenderDebugEnablingArgs() once only Modified: cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/lib/Driver/Tools.cpp URL: http://llvm.org/

r266775 - Pass dwarf-version to cc1as.

2016-04-19 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Tue Apr 19 12:43:54 2016 New Revision: 266775 URL: http://llvm.org/viewvc/llvm-project?rev=266775&view=rev Log: Pass dwarf-version to cc1as. Fix PR26999 - crashing in cc1as with any '*bsd' target. Modified: cfe/trunk/lib/Driver/Tools.cpp cfe/trunk/test/Driver/save-tem

r263596 - Myriad: define __myriad2 macro automatically

2016-03-15 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Tue Mar 15 17:34:02 2016 New Revision: 263596 URL: http://llvm.org/viewvc/llvm-project?rev=263596&view=rev Log: Myriad: define __myriad2 macro automatically Modified: cfe/trunk/lib/Basic/Targets.cpp cfe/trunk/test/Driver/myriad-toolchain.c cfe/trunk/test/Preprocess

Re: [PATCH] D18186: Myriad: pass -mcpu flag to moviCompile, no default

2016-03-15 Thread Douglas Katzman via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL263556: Myriad: Pass -mcpu to movi{Compile,Asm} (authored by dougk). Changed prior to commit: http://reviews.llvm.org/D18186?vs=50739&id=50748#toc Repository: rL LLVM http://reviews.llvm.org/D18186

r263556 - Myriad: Pass -mcpu to movi{Compile,Asm}

2016-03-15 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Tue Mar 15 11:41:31 2016 New Revision: 263556 URL: http://llvm.org/viewvc/llvm-project?rev=263556&view=rev Log: Myriad: Pass -mcpu to movi{Compile,Asm} Differential Revision: http://reviews.llvm.org/D18186 Modified: cfe/trunk/lib/Driver/Tools.cpp cfe/trunk/test/Driver

Re: [PATCH] D18186: Myriad: pass -mcpu flag to moviCompile, no default

2016-03-15 Thread Douglas Katzman via cfe-commits
dougk updated this revision to Diff 50739. dougk added a comment. also moviAsm http://reviews.llvm.org/D18186 Files: lib/Driver/Tools.cpp test/Driver/myriad-toolchain.c Index: test/Driver/myriad-toolchain.c === --- test/Driver

[PATCH] D18186: Myriad: pass -mcpu flag to moviCompile, no default

2016-03-15 Thread Douglas Katzman via cfe-commits
dougk created this revision. dougk added a reviewer: jyknight. dougk added a subscriber: cfe-commits. http://reviews.llvm.org/D18186 Files: lib/Driver/Tools.cpp test/Driver/myriad-toolchain.c Index: test/Driver/myriad-toolchain.c ==

Re: [PATCH] D15882: Avoid assert failure on some invalid cc1 options.

2016-01-05 Thread Douglas Katzman via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL256897: Avoid assert failure on some invalid cc1 options. (authored by dougk). Changed prior to commit: http://reviews.llvm.org/D15882?vs=43958&id=44074#toc Repository: rL LLVM http://reviews.llvm.o

r256897 - Avoid assert failure on some invalid cc1 options.

2016-01-05 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Tue Jan 5 19:37:57 2016 New Revision: 256897 URL: http://llvm.org/viewvc/llvm-project?rev=256897&view=rev Log: Avoid assert failure on some invalid cc1 options. Addressing review comment in D13221. Differential Revision: http://reviews.llvm.org/D15882 Modified: cfe/trun

[PATCH] D15882: Avoid assert failure on some invalid cc1 options.

2016-01-04 Thread Douglas Katzman via cfe-commits
dougk created this revision. dougk added reviewers: thakis, probinson. dougk added a subscriber: cfe-commits. Something like this was suggested in http://reviews.llvm.org/D13221 http://reviews.llvm.org/D15882 Files: lib/Frontend/CompilerInvocation.cpp test/Driver/debug-options.c Index: tes

r253647 - [Myriad]: handle Preprocess job action (-E)

2015-11-19 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Thu Nov 19 22:58:12 2015 New Revision: 253647 URL: http://llvm.org/viewvc/llvm-project?rev=253647&view=rev Log: [Myriad]: handle Preprocess job action (-E) Modified: cfe/trunk/lib/Driver/ToolChains.cpp cfe/trunk/lib/Driver/Tools.cpp cfe/trunk/test/Driver/myriad-too

r253476 - [Myriad]: fix test for Windows

2015-11-18 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Wed Nov 18 11:19:47 2015 New Revision: 253476 URL: http://llvm.org/viewvc/llvm-project?rev=253476&view=rev Log: [Myriad]: fix test for Windows Modified: cfe/trunk/test/Driver/myriad-toolchain.c Modified: cfe/trunk/test/Driver/myriad-toolchain.c URL: http://llvm.org/viewv

Re: [PATCH] D14754: [Myriad]: insert -L paths into linker cmd only when they exist.

2015-11-18 Thread Douglas Katzman via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL253467: [Myriad]: insert -L paths into linker cmd only when they exist. (authored by dougk). Changed prior to commit: http://reviews.llvm.org/D14754?vs=40442&id=40516#toc Repository: rL LLVM http://

r253467 - [Myriad]: insert -L paths into linker cmd only when they exist.

2015-11-18 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Wed Nov 18 10:24:46 2015 New Revision: 253467 URL: http://llvm.org/viewvc/llvm-project?rev=253467&view=rev Log: [Myriad]: insert -L paths into linker cmd only when they exist. Differential Revision: http://reviews.llvm.org/D14754 Added: cfe/trunk/test/Driver/Inputs/basic

Re: [PATCH] D14754: [Myriad]: insert -L paths into linker cmd only when they exist.

2015-11-17 Thread Douglas Katzman via cfe-commits
dougk updated this revision to Diff 40442. dougk marked 2 inline comments as done. dougk added a comment. changes per jyknight http://reviews.llvm.org/D14754 Files: lib/Driver/ToolChains.cpp lib/Driver/ToolChains.h lib/Driver/Tools.cpp test/Driver/Inputs/basic_myriad_tree/lib/gcc/sparc-

r253390 - [Myriad]: -nostdlib implies -nostartfiles

2015-11-17 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Tue Nov 17 16:33:34 2015 New Revision: 253390 URL: http://llvm.org/viewvc/llvm-project?rev=253390&view=rev Log: [Myriad]: -nostdlib implies -nostartfiles Modified: cfe/trunk/lib/Driver/Tools.cpp cfe/trunk/test/Driver/myriad-toolchain.c Modified: cfe/trunk/lib/Driver/T

[PATCH] D14754: [Myriad]: insert -L paths into linker cmd only when they exist.

2015-11-17 Thread Douglas Katzman via cfe-commits
dougk created this revision. dougk added a reviewer: jyknight. dougk added a subscriber: cfe-commits. Herald added a subscriber: jyknight. http://reviews.llvm.org/D14754 Files: lib/Driver/ToolChains.cpp lib/Driver/ToolChains.h lib/Driver/Tools.cpp test/Driver/Inputs/basic_myriad_tree/lib/

r253372 - Use !hasArg with two options instead of !hasArg && !hasArg.

2015-11-17 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Tue Nov 17 14:28:07 2015 New Revision: 253372 URL: http://llvm.org/viewvc/llvm-project?rev=253372&view=rev Log: Use !hasArg with two options instead of !hasArg && !hasArg. Thereby fixing a warning about failure to claim all args. Modified: cfe/trunk/lib/Driver/Tools.cpp

r253350 - Add trivial utility to append -L arguments to linker step. NFC

2015-11-17 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Tue Nov 17 11:41:23 2015 New Revision: 253350 URL: http://llvm.org/viewvc/llvm-project?rev=253350&view=rev Log: Add trivial utility to append -L arguments to linker step. NFC Modified: cfe/trunk/include/clang/Driver/ToolChain.h cfe/trunk/lib/Driver/ToolChain.cpp cf

r253213 - [Myriad]: pass the 'std=' option to moviCompile

2015-11-16 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Mon Nov 16 09:38:40 2015 New Revision: 253213 URL: http://llvm.org/viewvc/llvm-project?rev=253213&view=rev Log: [Myriad]: pass the 'std=' option to moviCompile Modified: cfe/trunk/lib/Driver/Tools.cpp cfe/trunk/test/Driver/myriad-toolchain.c Modified: cfe/trunk/lib/Dr

r250932 - [Myriad]: Always add -L paths even if -nostdlib is set.

2015-10-21 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Wed Oct 21 14:33:54 2015 New Revision: 250932 URL: http://llvm.org/viewvc/llvm-project?rev=250932&view=rev Log: [Myriad]: Always add -L paths even if -nostdlib is set. Modified: cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/lib/Driver/Tools.cpp URL: http://llvm.org/

Re: [PATCH] D13813: Teach MyriadToolchain how to find its C++ header paths.

2015-10-16 Thread Douglas Katzman via cfe-commits
dougk accepted this revision. dougk added a comment. This revision is now accepted and ready to land. I'd have titled the CL such that emphasis on what people might find generally useful: "Move addLibStdCXXIncludePaths method from Linux to Generic_GCC .. and incidentally make MyriadToolchain use

r250363 - Remove unnecessary braces in single-line 'if'.

2015-10-14 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Wed Oct 14 23:10:40 2015 New Revision: 250363 URL: http://llvm.org/viewvc/llvm-project?rev=250363&view=rev Log: Remove unnecessary braces in single-line 'if'. Modified: cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/lib/Driver/Tools.cpp URL: http://llvm.org/viewvc/ll

r250173 - Always pass a -dwarf-version argument to integrated as.

2015-10-13 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Tue Oct 13 11:22:51 2015 New Revision: 250173 URL: http://llvm.org/viewvc/llvm-project?rev=250173&view=rev Log: Always pass a -dwarf-version argument to integrated as. This removes the default of 3 hidden in the assembler previously. Fixes breakage caused by r249655, reported

r249893 - [Myriad]: put libstdc++ and libc in the right order

2015-10-09 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Fri Oct 9 15:26:20 2015 New Revision: 249893 URL: http://llvm.org/viewvc/llvm-project?rev=249893&view=rev Log: [Myriad]: put libstdc++ and libc in the right order Modified: cfe/trunk/lib/Driver/Tools.cpp cfe/trunk/test/Driver/myriad-toolchain.c Modified: cfe/trunk/li

r249692 - [Myriad]: default the Dwarf version to 2

2015-10-08 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Thu Oct 8 09:18:02 2015 New Revision: 249692 URL: http://llvm.org/viewvc/llvm-project?rev=249692&view=rev Log: [Myriad]: default the Dwarf version to 2 Modified: cfe/trunk/lib/Driver/ToolChains.h cfe/trunk/test/Driver/myriad-toolchain.c Modified: cfe/trunk/lib/Driver

r249658 - Use itostr(), not std::to_string() because of Android.

2015-10-07 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Thu Oct 8 00:25:03 2015 New Revision: 249658 URL: http://llvm.org/viewvc/llvm-project?rev=249658&view=rev Log: Use itostr(), not std::to_string() because of Android. Modified: cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/lib/Driver/Tools.cpp URL: http://llvm.org/v

r249657 - Unbreak 'debug-options' test when builder is Darwin

2015-10-07 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Thu Oct 8 00:02:24 2015 New Revision: 249657 URL: http://llvm.org/viewvc/llvm-project?rev=249657&view=rev Log: Unbreak 'debug-options' test when builder is Darwin Modified: cfe/trunk/test/Driver/debug-options.c Modified: cfe/trunk/test/Driver/debug-options.c URL: http:/

Re: [PATCH] D13221: Make CompilerInvocation's use of the debug options more understandable.

2015-10-07 Thread Douglas Katzman via cfe-commits
dougk marked an inline comment as done. dougk added a comment. http://reviews.llvm.org/D13221 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D13221: Make CompilerInvocation's use of the debug options more understandable.

2015-10-07 Thread Douglas Katzman via cfe-commits
dougk marked an inline comment as done. dougk added a comment. James, you're right, 'gdwarf-2' followed by 'line-tables-only' works, but the opposite order doesn't. So it halfway works, which is better than not working at all. Comment at: lib/Driver/Tools.cpp:2353 @@ +2352,3 @@

Re: [PATCH] D13221: Make CompilerInvocation's use of the debug options more understandable.

2015-10-02 Thread Douglas Katzman via cfe-commits
dougk added a comment. A few more remarks: - The code which emits line-tables-only seems to understand dwarf2 versus dwarf4, but due solely to the way that arguments were parsed, the dwarf version did not propagate through to the compiler invocation if you also specified line-tables-only. The

r249166 - [Myriad]: Accept '-nostdlib' option

2015-10-02 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Fri Oct 2 13:39:08 2015 New Revision: 249166 URL: http://llvm.org/viewvc/llvm-project?rev=249166&view=rev Log: [Myriad]: Accept '-nostdlib' option Modified: cfe/trunk/lib/Driver/Tools.cpp cfe/trunk/test/Driver/myriad-toolchain.c Modified: cfe/trunk/lib/Driver/Tools.c

r249138 - Fix bogus comment.

2015-10-02 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Fri Oct 2 09:41:38 2015 New Revision: 249138 URL: http://llvm.org/viewvc/llvm-project?rev=249138&view=rev Log: Fix bogus comment. Modified: cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/lib/Driver/Tools.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Dri

r248912 - Alias "-ggdbN" to "-gN" options, fixing some incompatibilities.

2015-09-30 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Wed Sep 30 10:55:59 2015 New Revision: 248912 URL: http://llvm.org/viewvc/llvm-project?rev=248912&view=rev Log: Alias "-ggdbN" to "-gN" options, fixing some incompatibilities. * assembling from a .s file mistook -ggdb0 for -g * -ggdb1 is supposed to mean basically -g1, not -gN

Re: [PATCH] D13221: Make CompilerInvocation's use of the debug options more understandable.

2015-09-28 Thread Douglas Katzman via cfe-commits
dougk added a comment. I think the best thing to do is introduce new cc1 arguments that control the Opts explicitly, and cease accepting the equivalent driver arguments in cc1. I would propose '-gdwarf-version={2|3|4}' and '-gdebug-info-kind={line-tables|limited|full}' http://reviews.llvm.org/

[PATCH] D13221: Make CompilerInvocation's use of the debug options more understandable.

2015-09-28 Thread Douglas Katzman via cfe-commits
dougk created this revision. dougk added reviewers: chandlerc, jyknight. dougk added a subscriber: cfe-commits. Both the Driver and the cc1 frontend play games with various combinations of 'g' group options. It would be nice if at least the frontend could be sane, leaving the decision of what OS

r247995 - Use None instead of an explicit constructor.

2015-09-18 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Fri Sep 18 10:23:16 2015 New Revision: 247995 URL: http://llvm.org/viewvc/llvm-project?rev=247995&view=rev Log: Use None instead of an explicit constructor. And remove a needless 'const' since ArrayRef is immutable. Both as suggested by dblaikie on cfe-commits. Modified:

Re: [PATCH] D10841: [Shave]: allow Clang to run the target linker.

2015-09-18 Thread Douglas Katzman via cfe-commits
dougk abandoned this revision. Comment at: lib/Driver/Tools.cpp:9110 @@ +9109,3 @@ + + const char *ToolsRoot = ::getenv("MV_TOOLS_DIR"); + // The version is numbered 'n.n.n.n' for arbitrary values that are opaque jyknight wrote: > Perhaps this should be a defaul

r247948 - [Myriad]: add "/include" to standard search path

2015-09-17 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Thu Sep 17 16:20:16 2015 New Revision: 247948 URL: http://llvm.org/viewvc/llvm-project?rev=247948&view=rev Log: [Myriad]: add "/include" to standard search path Modified: cfe/trunk/lib/Driver/ToolChains.cpp cfe/trunk/lib/Driver/ToolChains.h cfe/trunk/test/Driver/my

r247932 - Try to unbreak windows compiler after r247926.

2015-09-17 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Thu Sep 17 15:25:09 2015 New Revision: 247932 URL: http://llvm.org/viewvc/llvm-project?rev=247932&view=rev Log: Try to unbreak windows compiler after r247926. It might not like {} implicitly cast to an Arrayref. That's the theory, since I can't test it. Modified: cfe/trun

r247926 - [Shave]: Rename test file from 'shave-' to 'myriad-'

2015-09-17 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Thu Sep 17 15:00:09 2015 New Revision: 247926 URL: http://llvm.org/viewvc/llvm-project?rev=247926&view=rev Log: [Shave]: Rename test file from 'shave-' to 'myriad-' Added: cfe/trunk/test/Driver/myriad-toolchain.c - copied, changed from r247924, cfe/trunk/test/Driver/

Re: [PATCH] D12541: [Sparc][Shave]: Empower the toolchain formerly known as SHAVE to do more.

2015-09-17 Thread Douglas Katzman via cfe-commits
This revision was automatically updated to reflect the committed changes. dougk marked 2 inline comments as done. Closed by commit rL247924: [Shave]: Drive sparc-myriad-elf-ld directly rather than via gcc. (authored by dougk). Changed prior to commit: http://reviews.llvm.org/D12541?vs=34998&id=

r247924 - [Shave]: Drive sparc-myriad-elf-ld directly rather than via gcc.

2015-09-17 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Thu Sep 17 14:56:40 2015 New Revision: 247924 URL: http://llvm.org/viewvc/llvm-project?rev=247924&view=rev Log: [Shave]: Drive sparc-myriad-elf-ld directly rather than via gcc. Differential Revision: http://reviews.llvm.org/D12541 Added: cfe/trunk/test/Driver/Inputs/basic

r247900 - createOutputFile should set Error to something if it returns null.

2015-09-17 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Thu Sep 17 11:45:12 2015 New Revision: 247900 URL: http://llvm.org/viewvc/llvm-project?rev=247900&view=rev Log: createOutputFile should set Error to something if it returns null. This is not portably unit-testable because the only visible effect is a change from one random mes

Re: [PATCH] D12541: [Sparc][Shave]: Empower the toolchain formerly known as SHAVE to do more.

2015-09-17 Thread Douglas Katzman via cfe-commits
dougk updated this revision to Diff 34998. dougk marked 3 inline comments as done. dougk added a comment. Use the same logic as Solaris::Solaris to die in the toolchain constructor if getArch() is unexpected. Also don't hardcode -EL in linker. http://reviews.llvm.org/D12541 Files: lib/Driver

Re: [PATCH] D12541: [Sparc][Shave]: Empower the toolchain formerly known as SHAVE to do more.

2015-09-14 Thread Douglas Katzman via cfe-commits
dougk updated this revision to Diff 34729. dougk added a comment. Delete the overrides of getTool() and buildAssembler() in MyriadToolChain. http://reviews.llvm.org/D12541 Files: lib/Driver/Driver.cpp lib/Driver/ToolChains.cpp lib/Driver/ToolChains.h lib/Driver/Tools.cpp lib/Driver/To

r247611 - Driver should forward at most one gdwarf-N flag to cc1as.

2015-09-14 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Mon Sep 14 15:31:28 2015 New Revision: 247611 URL: http://llvm.org/viewvc/llvm-project?rev=247611&view=rev Log: Driver should forward at most one gdwarf-N flag to cc1as. Modified: cfe/trunk/lib/Driver/Tools.cpp cfe/trunk/test/Driver/integrated-as.s Modified: cfe/trunk

Re: [PATCH] D12845: [Sparc]: Myriad toolchain should assume -gdwarf-3 in cc1 invocation

2015-09-14 Thread Douglas Katzman via cfe-commits
dougk added a comment. This patch is wrong. Fixes are pending. http://reviews.llvm.org/D12845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D12845: [Sparc]: Myriad toolchain should assume -gdwarf-3 in cc1 invocation

2015-09-14 Thread Douglas Katzman via cfe-commits
dougk created this revision. dougk added reviewers: jyknight, chandlerc. dougk added a subscriber: cfe-commits. Herald added a subscriber: jyknight. Avoid generating spurious complaints from moviDebug. Incidental change: rename 'test/Driver/shave-toolchain.c' to 'myriad-toolchain.c' http://revi

Re: [PATCH] D12541: [Sparc][Shave]: Empower the toolchain formerly known as SHAVE to do more.

2015-09-14 Thread Douglas Katzman via cfe-commits
dougk updated the summary for this revision. dougk updated this revision to Diff 34682. dougk added a comment. Changes per review - but only a minimally correct change to finding the libraries. Using multilibs remains as a future task. Also renamed SHAVE::Linker to Myriad::Linker. http://review

r247474 - [Shave]: pass -isystem dirs and "-Wa," args to moviAsm

2015-09-11 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Fri Sep 11 16:13:46 2015 New Revision: 247474 URL: http://llvm.org/viewvc/llvm-project?rev=247474&view=rev Log: [Shave]: pass -isystem dirs and "-Wa," args to moviAsm Modified: cfe/trunk/lib/Driver/Tools.cpp cfe/trunk/test/Driver/shave-toolchain.c Modified: cfe/trunk/

Re: [PATCH] D12622: [Shave]: add a -MT option to moviCompile if there wasn't one

2015-09-08 Thread Douglas Katzman via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL247052: [Shave]: add a -MT option to moviCompile if there wasn't one (authored by dougk). Changed prior to commit: http://reviews.llvm.org/D12622?vs=34006&id=34239#toc Repository: rL LLVM http://rev

r247052 - [Shave]: add a -MT option to moviCompile if there wasn't one

2015-09-08 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Tue Sep 8 14:29:55 2015 New Revision: 247052 URL: http://llvm.org/viewvc/llvm-project?rev=247052&view=rev Log: [Shave]: add a -MT option to moviCompile if there wasn't one Differential Revision: http://reviews.llvm.org/D12622 Modified: cfe/trunk/lib/Driver/Tools.cpp

[PATCH] D12622: [Shave]: add a -MT option to moviCompile if there wasn't one

2015-09-03 Thread Douglas Katzman via cfe-commits
dougk created this revision. dougk added a reviewer: chandlerc. dougk added a subscriber: cfe-commits. http://reviews.llvm.org/D12622 Files: lib/Driver/Tools.cpp test/Driver/shave-toolchain.c Index: test/Driver/shave-toolchain.c ===

r246715 - Remove inadvertent debug output from prior change.

2015-09-02 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Wed Sep 2 16:18:10 2015 New Revision: 246715 URL: http://llvm.org/viewvc/llvm-project?rev=246715&view=rev Log: Remove inadvertent debug output from prior change. Modified: cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/lib/Driver/Tools.cpp URL: http://llvm.org/viewv

r246714 - Use new utility function to clean leading junk from pathnames. NFC

2015-09-02 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Wed Sep 2 16:14:53 2015 New Revision: 246714 URL: http://llvm.org/viewvc/llvm-project?rev=246714&view=rev Log: Use new utility function to clean leading junk from pathnames. NFC Modified: cfe/trunk/lib/Driver/Tools.cpp cfe/trunk/lib/Frontend/DependencyFile.cpp Modifi

r246652 - [Shave]: pass through more clang options to moviCompile

2015-09-02 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Wed Sep 2 08:42:43 2015 New Revision: 246652 URL: http://llvm.org/viewvc/llvm-project?rev=246652&view=rev Log: [Shave]: pass through more clang options to moviCompile Modified: cfe/trunk/lib/Driver/Tools.cpp cfe/trunk/test/Driver/shave-toolchain.c Modified: cfe/trunk

r246650 - [Sparc]: GCCInstallationDetector should not care if little-endian

2015-09-02 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Wed Sep 2 08:33:42 2015 New Revision: 246650 URL: http://llvm.org/viewvc/llvm-project?rev=246650&view=rev Log: [Sparc]: GCCInstallationDetector should not care if little-endian Modified: cfe/trunk/lib/Driver/ToolChains.cpp Modified: cfe/trunk/lib/Driver/ToolChains.cpp UR

Re: [PATCH] D12541: [Sparc][Shave]: Empower the toolchain formerly known as SHAVE to do more.

2015-09-01 Thread Douglas Katzman via cfe-commits
dougk updated the summary for this revision. dougk updated this revision to Diff 33778. dougk added a comment. Revised tests. http://reviews.llvm.org/D12541 Files: lib/Driver/Driver.cpp lib/Driver/ToolChains.cpp lib/Driver/ToolChains.h lib/Driver/Tools.cpp lib/Driver/Tools.h test/Dr

[PATCH] D12541: [Sparc][Shave]: Empower the toolchain formerly known as SHAVE to do more.

2015-09-01 Thread Douglas Katzman via cfe-commits
dougk created this revision. dougk added reviewers: jyknight, chandlerc. dougk added a subscriber: cfe-commits. Herald added a subscriber: jyknight. Rename SHAVE toolchain to Myriad toolchain. Run the Myriad linker whenever the vendor [sic] is Myriad. Also recognize RTEMS as the OS, and do someth

Re: [PATCH] D12201: [Sparc] Add '-EL' when invoking gcc to link little-endian binaries.

2015-08-20 Thread Douglas Katzman via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL245595: [Sparc] Add '-EL' when invoking gcc to link little-endian binaries. (authored by dougk). Changed prior to commit: http://reviews.llvm.org/D12201?vs=32715&id=32716#toc Repository: rL LLVM htt

r245595 - [Sparc] Add '-EL' when invoking gcc to link little-endian binaries.

2015-08-20 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Thu Aug 20 13:32:26 2015 New Revision: 245595 URL: http://llvm.org/viewvc/llvm-project?rev=245595&view=rev Log: [Sparc] Add '-EL' when invoking gcc to link little-endian binaries. Differential Revision: http://reviews.llvm.org/D12201 Modified: cfe/trunk/lib/Driver/Tools.c

[PATCH] D12201: [Sparc] Add '-EL' when invoking gcc to link little-endian binaries.

2015-08-20 Thread Douglas Katzman via cfe-commits
dougk created this revision. dougk added a reviewer: jyknight. dougk added a subscriber: cfe-commits. http://reviews.llvm.org/D12201 Files: lib/Driver/Tools.cpp test/Driver/biarch.c Index: test/Driver/biarch.c === --- test/Drive

r245063 - Represent 2 parallel string arrays as one string[][2] array.

2015-08-14 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Fri Aug 14 10:52:12 2015 New Revision: 245063 URL: http://llvm.org/viewvc/llvm-project?rev=245063&view=rev Log: Represent 2 parallel string arrays as one string[][2] array. Differential Revision: http://reviews.llvm.org/D11991 Modified: cfe/trunk/lib/Driver/ToolChains.cpp

Re: [PATCH] D11991: Represent 2 parallel string arrays as one string[][2] array.

2015-08-14 Thread Douglas Katzman via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL245063: Represent 2 parallel string arrays as one string[][2] array. (authored by dougk). Changed prior to commit: http://reviews.llvm.org/D11991?vs=31977&id=32157#toc Repository: rL LLVM http://rev

[PATCH] D11991: Represent 2 parallel string arrays as one string[][2] array.

2015-08-12 Thread Douglas Katzman via cfe-commits
dougk created this revision. dougk added a reviewer: chandlerc. dougk added a subscriber: cfe-commits. I think this conveys the intent better. Alternatively, since it's effectively trying to take llvm::sys::path::parent_path() for a number of times determined by the occurrences of '/' in one str

r244791 - Don't compare getArchName() to "tce" as a string. NFC.

2015-08-12 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Wed Aug 12 13:36:12 2015 New Revision: 244791 URL: http://llvm.org/viewvc/llvm-project?rev=244791&view=rev Log: Don't compare getArchName() to "tce" as a string. NFC. Modified: cfe/trunk/lib/Driver/Driver.cpp Modified: cfe/trunk/lib/Driver/Driver.cpp URL: http://llvm.org

[PATCH] D11983: Make getToolChain actually cache its result, as documented in Driver.h

2015-08-12 Thread Douglas Katzman via cfe-commits
dougk created this revision. dougk added a reviewer: chandlerc. dougk added a subscriber: cfe-commits. http://reviews.llvm.org/D11983 Files: lib/Driver/Driver.cpp Index: lib/Driver/Driver.cpp === --- lib/Driver/Driver.cpp +++ lib/

r244290 - Range-forify a loop, delete trailing whitespace. NFC

2015-08-06 Thread Douglas Katzman via cfe-commits
Author: dougk Date: Thu Aug 6 17:36:24 2015 New Revision: 244290 URL: http://llvm.org/viewvc/llvm-project?rev=244290&view=rev Log: Range-forify a loop, delete trailing whitespace. NFC Modified: cfe/trunk/lib/Driver/ToolChain.cpp Modified: cfe/trunk/lib/Driver/ToolChain.cpp URL: http://llvm