[clang] ac77b3f - [clang][ARM][NFC] Clean up signed conversion and undefined macros in builtin header

2022-09-08 Thread Dominic Chen via cfe-commits
Author: Dominic Chen Date: 2022-09-08T12:46:08-07:00 New Revision: ac77b3fde120d1c871b770fade67a413c418b94e URL: https://github.com/llvm/llvm-project/commit/ac77b3fde120d1c871b770fade67a413c418b94e DIFF: https://github.com/llvm/llvm-project/commit/ac77b3fde120d1c871b770fade67a413c418b94e.diff

[clang] bbf1900 - [clang][Headers] Avoid compiler warnings in builtin headers

2022-08-03 Thread Dominic Chen via cfe-commits
Author: Dominic Chen Date: 2022-08-03T17:56:17-07:00 New Revision: bbf19005714b2f6f957cac25e44d381167843732 URL: https://github.com/llvm/llvm-project/commit/bbf19005714b2f6f957cac25e44d381167843732 DIFF: https://github.com/llvm/llvm-project/commit/bbf19005714b2f6f957cac25e44d381167843732.diff

[clang] c102488 - Add test for disabling Dead Virtual Function Elimination

2020-10-07 Thread Dominic Chen via cfe-commits
Author: Dominic Chen Date: 2020-10-07T19:20:16-04:00 New Revision: c10248829357fd90030ba091e01b6c253e5848f1 URL: https://github.com/llvm/llvm-project/commit/c10248829357fd90030ba091e01b6c253e5848f1 DIFF: https://github.com/llvm/llvm-project/commit/c10248829357fd90030ba091e01b6c253e5848f1.diff

r333704 - [analyzer] fix bug with 1-bit APSInt types in Z3ConstraintManager

2018-05-31 Thread Dominic Chen via cfe-commits
Author: ddcc Date: Thu May 31 15:23:07 2018 New Revision: 333704 URL: http://llvm.org/viewvc/llvm-project?rev=333704&view=rev Log: [analyzer] fix bug with 1-bit APSInt types in Z3ConstraintManager Summary: Clang does not have a corresponding QualType for a 1-bit APSInt, so use the BoolTy and ext

r307853 - Revert "[analyzer] Support generating and reasoning over more symbolic constraint types"

2017-07-12 Thread Dominic Chen via cfe-commits
Author: ddcc Date: Wed Jul 12 14:43:42 2017 New Revision: 307853 URL: http://llvm.org/viewvc/llvm-project?rev=307853&view=rev Log: Revert "[analyzer] Support generating and reasoning over more symbolic constraint types" Assertion `Loc::isLocType(SSE->getLHS()->getType())' failed in Analysis/PR39

r307833 - [analyzer] Support generating and reasoning over more symbolic constraint types

2017-07-12 Thread Dominic Chen via cfe-commits
Author: ddcc Date: Wed Jul 12 12:37:57 2017 New Revision: 307833 URL: http://llvm.org/viewvc/llvm-project?rev=307833&view=rev Log: [analyzer] Support generating and reasoning over more symbolic constraint types Summary: Generate more IntSymExpr constraints, perform SVal simplification for IntSym

r305480 - [analyzer]: Improve test handling with multiple constraint managers

2017-06-15 Thread Dominic Chen via cfe-commits
Author: ddcc Date: Thu Jun 15 12:05:07 2017 New Revision: 305480 URL: http://llvm.org/viewvc/llvm-project?rev=305480&view=rev Log: [analyzer]: Improve test handling with multiple constraint managers Summary: Modify the test infrastructure to properly handle tests that require z3, and merge toget

r299463 - [analyzer] Add new Z3 constraint manager backend

2017-04-04 Thread Dominic Chen via cfe-commits
Author: ddcc Date: Tue Apr 4 14:52:25 2017 New Revision: 299463 URL: http://llvm.org/viewvc/llvm-project?rev=299463&view=rev Log: [analyzer] Add new Z3 constraint manager backend Summary: Implement new Z3 constraint manager backend. Reviewers: zaks.anna, dcoughlin, NoQ, xazax.hun Subscribers:

r296242 - [analyzer] Refactor and simplify SimpleConstraintManager

2017-02-24 Thread Dominic Chen via cfe-commits
Author: ddcc Date: Fri Feb 24 22:51:31 2017 New Revision: 296242 URL: http://llvm.org/viewvc/llvm-project?rev=296242&view=rev Log: [analyzer] Refactor and simplify SimpleConstraintManager Summary: SimpleConstraintManager is difficult to use, and makes assumptions about capabilities of the constr

r289511 - [analyzer] Run clang-format and fix style

2016-12-12 Thread Dominic Chen via cfe-commits
Author: ddcc Date: Mon Dec 12 19:40:41 2016 New Revision: 289511 URL: http://llvm.org/viewvc/llvm-project?rev=289511&view=rev Log: [analyzer] Run clang-format and fix style Summary: Split out formatting and style changes from D26061 Reviewers: zaks.anna, dcoughlin Subscribers: cfe-commits Diff

r288696 - [analyzer] Print type for SymbolRegionValues when dumping to stream

2016-12-05 Thread Dominic Chen via cfe-commits
Author: ddcc Date: Mon Dec 5 14:30:11 2016 New Revision: 288696 URL: http://llvm.org/viewvc/llvm-project?rev=288696&view=rev Log: [analyzer] Print type for SymbolRegionValues when dumping to stream Reviewers: NoQ, dcoughlin, zaks.anna Subscribers: cfe-commits Differential Revision: https://rev

r288372 - [analyzer] Drop explicit mention of range constraint solver

2016-12-01 Thread Dominic Chen via cfe-commits
Author: ddcc Date: Thu Dec 1 11:06:39 2016 New Revision: 288372 URL: http://llvm.org/viewvc/llvm-project?rev=288372&view=rev Log: [analyzer] Drop explicit mention of range constraint solver Summary: The basic constraint solver was dropped in rL162384, leaving the range constraint solver as the

[PATCH] D26955: Fix bitwidth for x87 extended-precision floating-point type

2016-11-21 Thread Dominic Chen via cfe-commits
ddcc added a comment. I could be completely mistaken here, but currently `Ctx.getRealTypeForBitwidth(llvm::APFloat::getSizeInBits(llvm::APFloat::x87DoubleExtended))` with a `ASTContext Ctx` does not round-trip correctly. https://reviews.llvm.org/D26955 __

[PATCH] D26955: Fix bitwidth for x87 extended-precision floating-point type

2016-11-21 Thread Dominic Chen via cfe-commits
ddcc created this revision. ddcc added a reviewer: rsmith. ddcc added a subscriber: cfe-commits. llvm::APFloat::x87DoubleExtended is defined as having 80 bits of size https://reviews.llvm.org/D26955 Files: lib/Basic/TargetInfo.cpp Index: lib/Basic/TargetInfo.cpp

r287380 - [analyzer] Refactor recursive symbol reachability check to use symbol_iterator

2016-11-18 Thread Dominic Chen via cfe-commits
Author: ddcc Date: Fri Nov 18 15:07:03 2016 New Revision: 287380 URL: http://llvm.org/viewvc/llvm-project?rev=287380&view=rev Log: [analyzer] Refactor recursive symbol reachability check to use symbol_iterator Reviewers: zaks.anna, dcoughlin Subscribers: cfe-commits Differential Revision: https

[PATCH] D26773: [analyzer] Refactor recursive symbol reachability check to use symbol_iterator

2016-11-18 Thread Dominic Chen via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL287380: [analyzer] Refactor recursive symbol reachability check to use symbol_iterator (authored by ddcc). Changed prior to commit: https://reviews.llvm.org/D26773?vs=78392&id=78575#toc Repository: r

[PATCH] D26773: [analyzer] Refactor recursive symbol reachability check to use symbol_iterator

2016-11-17 Thread Dominic Chen via cfe-commits
ddcc added a comment. I believe you're correct, the original code terminates early because of the short circuit evaluation on line 553, and visits all reachable nodes but doesn't recurse on non-SymbolData. https://reviews.llvm.org/D26773 ___ cfe-c

[PATCH] D26773: [analyzer] Refactor recursive symbol reachability check to use symbol_iterator

2016-11-17 Thread Dominic Chen via cfe-commits
ddcc updated this revision to Diff 78392. ddcc added a comment. Fix visitation, add early termination, add comments https://reviews.llvm.org/D26773 Files: include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h lib/StaticAnalyzer/Core/ProgramState.cpp Index: lib/StaticAnalyzer/Core

[PATCH] D26773: [analyzer] Refactor recursive symbol reachability check to use symbol_iterator

2016-11-16 Thread Dominic Chen via cfe-commits
ddcc created this revision. ddcc added reviewers: zaks.anna, dcoughlin. ddcc added a subscriber: cfe-commits. https://reviews.llvm.org/D26773 Files: lib/StaticAnalyzer/Core/ProgramState.cpp Index: lib/StaticAnalyzer/Core/ProgramState.cpp ===

[PATCH] D26694: [analyzer] Drop explicit mention of range constraint solver

2016-11-15 Thread Dominic Chen via cfe-commits
ddcc created this revision. ddcc added reviewers: zaks.anna, dcoughlin. ddcc added a subscriber: cfe-commits. The basic constraint solver was dropped in https://reviews.llvm.org/rL162384, leaving the range constraint solver as the default and only constraint solver. Explicitly specifying it is u

[PATCH] D26691: [analyzer] Run clang-format and fix style

2016-11-15 Thread Dominic Chen via cfe-commits
ddcc created this revision. ddcc added reviewers: zaks.anna, dcoughlin. ddcc added a subscriber: cfe-commits. Split out formatting and style changes from https://reviews.llvm.org/D26061 https://reviews.llvm.org/D26691 Files: lib/StaticAnalyzer/Core/RangeConstraintManager.cpp lib/StaticAnaly

[PATCH] D26061: [analyzer] Refactor and simplify SimpleConstraintManager

2016-11-15 Thread Dominic Chen via cfe-commits
ddcc updated this revision to Diff 78049. ddcc added a comment. Rebase on recent changes https://reviews.llvm.org/D26061 Files: include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h include/clang/StaticAnalyzer/Core/PathSensitive/SimpleConstraintManager.h lib/StaticAnalyzer/

r286927 - [analyzer] Rename assumeWithinInclusiveRange*()

2016-11-14 Thread Dominic Chen via cfe-commits
Author: ddcc Date: Mon Nov 14 19:54:41 2016 New Revision: 286927 URL: http://llvm.org/viewvc/llvm-project?rev=286927&view=rev Log: [analyzer] Rename assumeWithinInclusiveRange*() Summary: The name is slightly confusing, since the constraint is not necessarily within the range unless `Assumption`

[PATCH] D26644: [analyzer] Rename assumeWithinInclusiveRange*()

2016-11-14 Thread Dominic Chen via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL286927: [analyzer] Rename assumeWithinInclusiveRange*() (authored by ddcc). Changed prior to commit: https://reviews.llvm.org/D26644?vs=77930&id=77933#toc Repository: rL LLVM https://reviews.llvm.or

[PATCH] D26644: [analyzer] Rename assumeWithinInclusiveRange*()

2016-11-14 Thread Dominic Chen via cfe-commits
ddcc updated this revision to Diff 77930. ddcc added a comment. Fix formatting https://reviews.llvm.org/D26644 Files: include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h lib/StaticAnalyzer/Checkers/StdLibraryFu

[PATCH] D26642: [analyzer] Minor optimization: avoid setting state if unchanged

2016-11-14 Thread Dominic Chen via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL286925: [analyzer] Minor optimization: avoid setting state if unchanged (authored by ddcc). Changed prior to commit: https://reviews.llvm.org/D26642?vs=77897&id=77929#toc Repository: rL LLVM https:/

r286925 - [analyzer] Minor optimization: avoid setting state if unchanged

2016-11-14 Thread Dominic Chen via cfe-commits
Author: ddcc Date: Mon Nov 14 19:40:58 2016 New Revision: 286925 URL: http://llvm.org/viewvc/llvm-project?rev=286925&view=rev Log: [analyzer] Minor optimization: avoid setting state if unchanged Summary: Split out optimization from D26061 Reviewers: zaks.anna, dcoughlin Subscribers: cfe-commits

[PATCH] D26644: [analyzer] Rename assumeWithinInclusiveRange*()

2016-11-14 Thread Dominic Chen via cfe-commits
ddcc created this revision. ddcc added reviewers: zaks.anna, dcoughlin. ddcc added a subscriber: cfe-commits. The name is slightly confusing, since the constraint is not necessarily within the range unless `Assumption` is true. Split out renaming for ConstraintManager.h from https://reviews.llvm

[PATCH] D26642: [analyzer] Minor optimizaiton: avoid setting state if unchanged

2016-11-14 Thread Dominic Chen via cfe-commits
ddcc created this revision. ddcc added reviewers: zaks.anna, dcoughlin. ddcc added a subscriber: cfe-commits. Split out optimization from https://reviews.llvm.org/D26061 https://reviews.llvm.org/D26642 Files: lib/StaticAnalyzer/Core/RangeConstraintManager.cpp Index: lib/StaticAnalyzer/Core/

[PATCH] D26373: [analyzer] Provide Contains() on ImmutableMap program state partial trait.

2016-11-08 Thread Dominic Chen via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL286306: [analyzer] Provide Contains() on ImmutableMap program state partial trait. (authored by ddcc). Changed prior to commit: https://reviews.llvm.org/D26373?vs=77109&id=77269#toc Repository: rL LL

r286306 - [analyzer] Provide Contains() on ImmutableMap program state partial trait.

2016-11-08 Thread Dominic Chen via cfe-commits
Author: ddcc Date: Tue Nov 8 16:39:14 2016 New Revision: 286306 URL: http://llvm.org/viewvc/llvm-project?rev=286306&view=rev Log: [analyzer] Provide Contains() on ImmutableMap program state partial trait. Reviewers: zaks.anna, dcoughlin Subscribers: cfe-commits Differential Revision: https://r

[PATCH] D26373: [analyzer] Provide Contains() on ImmutableMap program state partial trait.

2016-11-08 Thread Dominic Chen via cfe-commits
ddcc added a comment. Even though there isn't a performance difference, I think it is semantically clearer since it is explicit that the value is unneeded. The interface of ProgramState provides a `contains()` function that calls into `Contains()` of the underlying partial traits as part of its

[PATCH] D26373: [analyzer] Provide Contains() on ImmutableMap program state partial trait.

2016-11-07 Thread Dominic Chen via cfe-commits
ddcc created this revision. ddcc added reviewers: zaks.anna, dcoughlin. ddcc added a subscriber: cfe-commits. https://reviews.llvm.org/D26373 Files: include/clang/StaticAnalyzer/Core/PathSensitive/ProgramStateTrait.h Index: include/clang/StaticAnalyzer/Core/PathSensitive/ProgramStateTrait.h =

[PATCH] D26061: [analyzer] Refactor and simplify SimpleConstraintManager

2016-11-01 Thread Dominic Chen via cfe-commits
ddcc added a comment. Yes, I've been writing a Z3 solver interface, which motivated this patch. However, this patch has snowballed into something that it's a little too convoluted, so I'll split it up. I'm not sure whether the RangedConstraintManager interface is useful or not; I preserved it

[PATCH] D26061: [analyzer] Refactor and simplify SimpleConstraintManager

2016-10-27 Thread Dominic Chen via cfe-commits
ddcc added a comment. To summarize, here is a list of changes: - General - Fixed some issues with formatting (`clang-format`) - Fixed inconsistent capitalization following camel case style guidelines - `ConstraintManager.h` - Renamed `assumeWithinInclusiveRange*()` to `assumeInclusiveRange

[PATCH] D26061: [analyzer] Refactor and simplify SimpleConstraintManager

2016-10-27 Thread Dominic Chen via cfe-commits
ddcc created this revision. ddcc added reviewers: zaks.anna, dcoughlin. ddcc added subscribers: cfe-commits, rgov, NoQ, xazax.hun. Herald added a subscriber: mgorny. SimpleConstraintManager is difficult to use, and makes assumptions about capabilities of the constraint manager. This patch refacto

r284445 - [analyzer] Update alpha and potential checker documentation, esp. alpha.valist

2016-10-18 Thread Dominic Chen via cfe-commits
Author: ddcc Date: Mon Oct 17 20:15:19 2016 New Revision: 284445 URL: http://llvm.org/viewvc/llvm-project?rev=284445&view=rev Log: [analyzer] Update alpha and potential checker documentation, esp. alpha.valist Summary: Move alpha.valist from potential to alpha since it was implemented in D15227

[PATCH] D25663: [analyzer] Update alpha and potential checker documentation, esp. alpha.valist

2016-10-18 Thread Dominic Chen via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL284445: [analyzer] Update alpha and potential checker documentation, esp. alpha.valist (authored by ddcc). Changed prior to commit: https://reviews.llvm.org/D25663?vs=74807&id=74941#toc Repository: r

Re: [PATCH] D23244: [Driver] Enable CFI for WebAssembly

2016-08-08 Thread Dominic Chen via cfe-commits
ddcc added a comment. Can you land it? I don't have commit access. https://reviews.llvm.org/D23244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits