[clang] [Clang][Driver] Warn about `-c/-S` with `-fsyntax-only` (PR #98607)

@@ -0,0 +1,9 @@ +// RUN: %clang -fsyntax-only -S %s 2>&1 | FileCheck %s --check-prefix=CHECK-ASM +// RUN: %clang -fsyntax-only -c %s 2>&1 | FileCheck %s --check-prefix=CHECK-OBJ +// RUN: %clang -fsyntax-only -S -c %s 2>&1 | FileCheck %s --check-prefix=CHECK-BOTH + +// CHECK-ASM:

[clang] [Clang][Driver] Warn about `-c/-S` with `-fsyntax-only` (PR #98607)

@@ -0,0 +1,9 @@ +// RUN: %clang -fsyntax-only -S %s 2>&1 | FileCheck %s --check-prefix=CHECK-ASM chestnykh wrote: Renamed https://github.com/llvm/llvm-project/pull/98607 ___ cfe-commits mailing list cfe-commits@lists.l

[clang] [Clang][Driver] Warn about `-c/-S` with `-fsyntax-only` (PR #98607)

https://github.com/chestnykh updated https://github.com/llvm/llvm-project/pull/98607 >From ae43fc67b7d9db848ec8c4ecbcab1db6af7fcb01 Mon Sep 17 00:00:00 2001 From: Dmitry Chestnykh Date: Fri, 12 Jul 2024 12:25:16 +0300 Subject: [PATCH 1/3] [Clang][Driver] Warn about `-c/-S` with `-fsyntax-only`

[clang] [Clang][Driver] Warn about `-c/-S` with `-fsyntax-only` (PR #98607)

https://github.com/chestnykh updated https://github.com/llvm/llvm-project/pull/98607 >From ae43fc67b7d9db848ec8c4ecbcab1db6af7fcb01 Mon Sep 17 00:00:00 2001 From: Dmitry Chestnykh Date: Fri, 12 Jul 2024 12:25:16 +0300 Subject: [PATCH 1/2] [Clang][Driver] Warn about `-c/-S` with `-fsyntax-only`

[clang] [Clang][Driver] Warn about `-c/-S` with `-fsyntax-only` (PR #98607)

chestnykh wrote: CC: @shafik @ChuanqiXu9 https://github.com/llvm/llvm-project/pull/98607 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Driver] Warn about `-c/-S` with `-fsyntax-only` (PR #98607)

https://github.com/chestnykh created https://github.com/llvm/llvm-project/pull/98607 Emit warning that `-S` and/or `-c` arguments are not used if `-fsyntax-only` is also passed to clang `addPGOAndCoverageFlags` is not the right place to produce this warning Now `-fsyntax-only -c/-S` combination

[clang] [Clang] Don't crash if input file is not a module. (PR #98439)

@@ -226,6 +226,7 @@ def err_module_map_not_found : Error<"module map file '%0' not found">, def err_missing_module_name : Error< "no module name provided; specify one with -fmodule-name=">, DefaultFatal; +def err_file_is_not_module : Error<"file '%0' is not a module">, Def

[clang] [Clang] Don't crash if input file is not a module. (PR #98439)

@@ -226,6 +226,7 @@ def err_module_map_not_found : Error<"module map file '%0' not found">, def err_missing_module_name : Error< "no module name provided; specify one with -fmodule-name=">, DefaultFatal; +def err_file_is_not_module : Error<"file '%0' is not a module">, Def

[clang] [Clang] Don't crash if input file is not a module. (PR #98439)

https://github.com/chestnykh updated https://github.com/llvm/llvm-project/pull/98439 >From 716e8b7b71422b5850d2f9c3710a28bcf18ffccb Mon Sep 17 00:00:00 2001 From: Dmitry Chestnykh Date: Thu, 11 Jul 2024 09:55:55 +0300 Subject: [PATCH 1/3] [Clang] Don't crash if input file is not a module. Curr

[clang] [Clang] Don't crash if input file is not a module. (PR #98439)

https://github.com/chestnykh updated https://github.com/llvm/llvm-project/pull/98439 >From 716e8b7b71422b5850d2f9c3710a28bcf18ffccb Mon Sep 17 00:00:00 2001 From: Dmitry Chestnykh Date: Thu, 11 Jul 2024 09:55:55 +0300 Subject: [PATCH 1/2] [Clang] Don't crash if input file is not a module. Curr

[clang] [Clang] Don't crash if input file is not a module. (PR #98439)

chestnykh wrote: CC: @ChuanqiXu9 @shafik https://github.com/llvm/llvm-project/pull/98439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Don't crash if input file is not a module. (PR #98439)

https://github.com/chestnykh created https://github.com/llvm/llvm-project/pull/98439 Currently clang crashes with `-module-file-info` and input file which is not a module Emit error instead of segfaulting. Fix #98365 >From 716e8b7b71422b5850d2f9c3710a28bcf18ffccb Mon Sep 17 00:00:00 2001 From:

[clang] [clang] Use internal linkage for c23 constexpr vars. (PR #97846)

chestnykh wrote: > > > > > LGTM but please add a release note to clang/docs/ReleaseNotes.rst so > > > > > users know about the fix as well. > > > > > > > > > > > > Note that only clang 19 has `constexpr` support in C23. > > > > https://godbolt.org/z/4bThdsqK5 Release note saying that support

[clang] [clang] Use internal linkage for c23 constexpr vars. (PR #97846)

https://github.com/chestnykh updated https://github.com/llvm/llvm-project/pull/97846 >From 0619f787112c18c559959eb50086b412ebad5839 Mon Sep 17 00:00:00 2001 From: Dmitry Chestnykh Date: Fri, 5 Jul 2024 20:40:32 +0300 Subject: [PATCH] [clang][C23] Use internal linkage for C23 constexpr vars. Se

[clang] [clang] Use internal linkage for c23 constexpr vars. (PR #97846)

chestnykh wrote: > > > LGTM but please add a release note to clang/docs/ReleaseNotes.rst so > > > users know about the fix as well. > > > > > > Note that only clang 19 has `constexpr` support in C23. > > https://godbolt.org/z/4bThdsqK5 Release note saying that support has been > > implemente

[clang] [clang] Use internal linkage for c23 constexpr vars. (PR #97846)

https://github.com/chestnykh updated https://github.com/llvm/llvm-project/pull/97846 >From 7a3f28574377bb6139971039ca6da5d299c2228d Mon Sep 17 00:00:00 2001 From: Dmitry Chestnykh Date: Fri, 5 Jul 2024 20:40:32 +0300 Subject: [PATCH 1/2] [clang] Use internal linkage for c23 constexpr vars. See

[clang] [clang] Use internal linkage for c23 constexpr vars. (PR #97846)

https://github.com/chestnykh updated https://github.com/llvm/llvm-project/pull/97846 >From 7a3f28574377bb6139971039ca6da5d299c2228d Mon Sep 17 00:00:00 2001 From: Dmitry Chestnykh Date: Fri, 5 Jul 2024 20:40:32 +0300 Subject: [PATCH 1/2] [clang] Use internal linkage for c23 constexpr vars. See

[clang] [clang] Use internal linkage for c23 constexpr vars. (PR #97846)

chestnykh wrote: Release notes added https://github.com/llvm/llvm-project/pull/97846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Use internal linkage for c23 constexpr vars. (PR #97846)

https://github.com/chestnykh updated https://github.com/llvm/llvm-project/pull/97846 >From 7a3f28574377bb6139971039ca6da5d299c2228d Mon Sep 17 00:00:00 2001 From: Dmitry Chestnykh Date: Fri, 5 Jul 2024 20:40:32 +0300 Subject: [PATCH 1/2] [clang] Use internal linkage for c23 constexpr vars. See

[clang] [clang] Use internal linkage for c23 constexpr vars. (PR #97846)

chestnykh wrote: > LGTM but please add a release note to clang/docs/ReleaseNotes.rst so users > know about the fix as well. > > Once that's added, will you need someone to land the changes on your behalf? @AaronBallman , yes, i will need this. I'm going to add release notes right now. https:/

[clang] [clang] Use internal linkage for c23 constexpr vars. (PR #97846)

https://github.com/chestnykh updated https://github.com/llvm/llvm-project/pull/97846 >From 7a3f28574377bb6139971039ca6da5d299c2228d Mon Sep 17 00:00:00 2001 From: Dmitry Chestnykh Date: Fri, 5 Jul 2024 20:40:32 +0300 Subject: [PATCH] [clang] Use internal linkage for c23 constexpr vars. See C23

[clang] [clang] Use internal linkage for c23 constexpr vars. (PR #97846)

@@ -4428,10 +4428,14 @@ void Parser::ParseDeclarationSpecifiers( // constexpr, consteval, constinit specifiers case tok::kw_constexpr: - if (getLangOpts().C23) + if (getLangOpts().C23) { Diag(Tok, diag::warn_c23_compat_keyword) << Tok.getName(); -

[clang] [clang] Use internal linkage for c23 constexpr vars. (PR #97846)

https://github.com/chestnykh edited https://github.com/llvm/llvm-project/pull/97846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Use internal linkage for c23 constexpr vars. (PR #97846)

https://github.com/chestnykh updated https://github.com/llvm/llvm-project/pull/97846 >From b8252ed88a15cda147b2f62329a9369130a8d694 Mon Sep 17 00:00:00 2001 From: Dmitry Chestnykh Date: Fri, 5 Jul 2024 20:40:32 +0300 Subject: [PATCH] [clang] Use internal linkage for c23 constexpr vars. See C23

[clang] [clang] Use internal linkage for c23 constexpr vars. (PR #97846)

https://github.com/chestnykh ready_for_review https://github.com/llvm/llvm-project/pull/97846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Use internal linkage for c23 constexpr vars. (PR #97846)

https://github.com/chestnykh updated https://github.com/llvm/llvm-project/pull/97846 >From 70a5e96c9489ef46c5c17106178bf703eab8f8ad Mon Sep 17 00:00:00 2001 From: Dmitry Chestnykh Date: Fri, 5 Jul 2024 20:40:32 +0300 Subject: [PATCH] [clang] Use internal linkage for c23 constexpr vars. Set `st

[clang] [clang] Use internal linkage for c23 constexpr vars. (PR #97846)

@@ -4428,10 +4428,14 @@ void Parser::ParseDeclarationSpecifiers( // constexpr, consteval, constinit specifiers case tok::kw_constexpr: - if (getLangOpts().C23) + if (getLangOpts().C23) { Diag(Tok, diag::warn_c23_compat_keyword) << Tok.getName(); -

[clang] [clang] Use internal linkage for c23 constexpr vars. (PR #97846)

https://github.com/chestnykh converted_to_draft https://github.com/llvm/llvm-project/pull/97846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Use internal linkage for c23 constexpr vars. (PR #97846)

https://github.com/chestnykh updated https://github.com/llvm/llvm-project/pull/97846 >From ecf8360b1ca201eeb8887214477eb8ffeb5f088f Mon Sep 17 00:00:00 2001 From: Dmitry Chestnykh Date: Fri, 5 Jul 2024 20:40:32 +0300 Subject: [PATCH] [clang] Use internal linkage for c23 constexpr vars. Set `st

[clang] [clang] Use internal linkage for c23 constexpr vars. (PR #97846)

https://github.com/chestnykh updated https://github.com/llvm/llvm-project/pull/97846 >From 20adb1c05dc59cc0a4b3969824f75c2d9c612755 Mon Sep 17 00:00:00 2001 From: Dmitry Chestnykh Date: Fri, 5 Jul 2024 20:40:32 +0300 Subject: [PATCH] [clang] Use internal linkage for c23 constexpr vars. Set `st

[clang] [clang] Use internal linkage for c23 constexpr vars. (PR #97846)

https://github.com/chestnykh updated https://github.com/llvm/llvm-project/pull/97846 >From 20adb1c05dc59cc0a4b3969824f75c2d9c612755 Mon Sep 17 00:00:00 2001 From: Dmitry Chestnykh Date: Fri, 5 Jul 2024 20:40:32 +0300 Subject: [PATCH] [clang] Use internal linkage for c23 constexpr vars. Set `st

[clang] [clang] Use internal linkage for c23 constexpr vars. (PR #97846)

https://github.com/chestnykh updated https://github.com/llvm/llvm-project/pull/97846 >From ec1f0f0fe626db9da1437ed414f8d080c750cb45 Mon Sep 17 00:00:00 2001 From: Dmitry Chestnykh Date: Fri, 5 Jul 2024 20:40:32 +0300 Subject: [PATCH] [clang] Use internal linkage for c23 constexpr vars. Set `st

[clang] [clang] Use internal linkage for c23 constexpr vars. (PR #97846)

https://github.com/chestnykh created https://github.com/llvm/llvm-project/pull/97846 Set `static` storage class specifier for such decls to have `internal` linkage in produced IR and then in the object file. Fix #97830 >From ec1f0f0fe626db9da1437ed414f8d080c750cb45 Mon Sep 17 00:00:00 2001 Fro