@@ -6440,7 +6440,8 @@ const ToolChain &Driver::getToolChain(const ArgList &Args,
TC = std::make_unique(*this, Target, Args);
break;
case llvm::Triple::AMDHSA:
- TC = std::make_unique(*this, Target, Args);
+ TC = std::make_unique(*this, Target, Args,
+
@@ -6440,7 +6440,8 @@ const ToolChain &Driver::getToolChain(const ArgList &Args,
TC = std::make_unique(*this, Target, Args);
break;
case llvm::Triple::AMDHSA:
- TC = std::make_unique(*this, Target, Args);
+ TC = std::make_unique(*this, Target, Args,
+
david-salinas wrote:
> Is there an issue with simply using the `HostTC` for everything? I feel like
> that's the solution to this mess, since the `HostTC` would always know
> whether or not the target is Windows without us needing to forward a bunch of
> stuff.
Yes, that would work too. But
https://github.com/david-salinas updated
https://github.com/llvm/llvm-project/pull/113628
>From c86922536a3ef02967efbaeccd522ff8a34bafc0 Mon Sep 17 00:00:00 2001
From: David Salinas
Date: Tue, 22 Oct 2024 18:58:47 +
Subject: [PATCH] Remove Linux search paths on Windows
Change-Id: Ia0b44eb1
@@ -6440,7 +6440,8 @@ const ToolChain &Driver::getToolChain(const ArgList &Args,
TC = std::make_unique(*this, Target, Args);
break;
case llvm::Triple::AMDHSA:
- TC = std::make_unique(*this, Target, Args);
+ TC = std::make_unique(*this, Target, Args,
+
@@ -6440,7 +6440,8 @@ const ToolChain &Driver::getToolChain(const ArgList &Args,
TC = std::make_unique(*this, Target, Args);
break;
case llvm::Triple::AMDHSA:
- TC = std::make_unique(*this, Target, Args);
+ TC = std::make_unique(*this, Target, Args,
+
@@ -6440,7 +6440,8 @@ const ToolChain &Driver::getToolChain(const ArgList &Args,
TC = std::make_unique(*this, Target, Args);
break;
case llvm::Triple::AMDHSA:
- TC = std::make_unique(*this, Target, Args);
+ TC = std::make_unique(*this, Target, Args,
+
@@ -0,0 +1,9 @@
+// REQUIRES: system-windows
david-salinas wrote:
ah ok. :-)
https://github.com/llvm/llvm-project/pull/113628
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
@@ -272,6 +277,13 @@ class RocmInstallationDetector {
return Loc->second;
}
+ void init(bool DetectHIPRuntime = true, bool DetectDeviceLib = false) {
david-salinas wrote:
Yes. We are basically just trying to avoid adding "linux like paths" on
Windows.
@@ -0,0 +1,9 @@
+// REQUIRES: system-windows
david-salinas wrote:
ok, I was just basing this off of existing tests. But I see that recently
there has been support for targets in the REQUIRES statements. I'll change
these for both the Windows and Linux tests.
@@ -0,0 +1,9 @@
+// REQUIRES: system-linux
david-salinas wrote:
agreed. Will change to use target.
https://github.com/llvm/llvm-project/pull/113628
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists
https://github.com/david-salinas ready_for_review
https://github.com/llvm/llvm-project/pull/113628
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/david-salinas updated
https://github.com/llvm/llvm-project/pull/113628
>From a5a84991fd605630e4c37cc92518fb8dee42ab61 Mon Sep 17 00:00:00 2001
From: David Salinas
Date: Tue, 22 Oct 2024 18:58:47 +
Subject: [PATCH] Remove Linux search paths on Windows
Change-Id: Ia0b44eb1
https://github.com/david-salinas updated
https://github.com/llvm/llvm-project/pull/113628
>From 4fad2d64582471816adc18f78294288bcaee0d63 Mon Sep 17 00:00:00 2001
From: David Salinas
Date: Tue, 22 Oct 2024 18:58:47 +
Subject: [PATCH] Remove Linux search paths on Windows
Change-Id: Ia0b44eb1
https://github.com/david-salinas closed
https://github.com/llvm/llvm-project/pull/97668
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/david-salinas updated
https://github.com/llvm/llvm-project/pull/113628
>From 2ab5bea395fce329be6bbcd8c04f9a9bd9da05df Mon Sep 17 00:00:00 2001
From: David Salinas
Date: Tue, 22 Oct 2024 18:58:47 +
Subject: [PATCH] Remove Linux search paths on Windows
Change-Id: Ia0b44eb1
https://github.com/david-salinas updated
https://github.com/llvm/llvm-project/pull/113628
>From 307e0abed8387b0bffa4b7e24e995ad7ec402749 Mon Sep 17 00:00:00 2001
From: David Salinas
Date: Tue, 22 Oct 2024 18:58:47 +
Subject: [PATCH] Remove Linux search paths on Windows
Change-Id: Ia0b44eb1
https://github.com/david-salinas updated
https://github.com/llvm/llvm-project/pull/113628
>From ee17fe072310a55e004134bb793a18b8089b4020 Mon Sep 17 00:00:00 2001
From: David Salinas
Date: Tue, 22 Oct 2024 18:58:47 +
Subject: [PATCH] Remove Linux search paths on Windows
Change-Id: Ia0b44eb1
https://github.com/david-salinas updated
https://github.com/llvm/llvm-project/pull/113628
>From 44f610ead0ec6e497f16771234067e7d96460666 Mon Sep 17 00:00:00 2001
From: David Salinas
Date: Tue, 22 Oct 2024 18:58:47 +
Subject: [PATCH] Remove Linux search paths on Windows
Change-Id: Ia0b44eb1
https://github.com/david-salinas updated
https://github.com/llvm/llvm-project/pull/113628
>From 80d3a80534482d9cc13b6a50e5c8026b1a9c0d11 Mon Sep 17 00:00:00 2001
From: David Salinas
Date: Tue, 22 Oct 2024 18:58:47 +
Subject: [PATCH] Remove Linux search paths on Windows
Change-Id: Ia0b44eb1
https://github.com/david-salinas updated
https://github.com/llvm/llvm-project/pull/113628
>From dd7037436d90e51927fd0b7cb6f822980393a867 Mon Sep 17 00:00:00 2001
From: David Salinas
Date: Tue, 22 Oct 2024 18:58:47 +
Subject: [PATCH] Remove Linux search paths on Windows
Change-Id: Ia0b44eb1
https://github.com/david-salinas updated
https://github.com/llvm/llvm-project/pull/97668
>From 803e3939a726bed2f1c43a3199850d580251c6d2 Mon Sep 17 00:00:00 2001
From: David Salinas
Date: Thu, 4 Jul 2024 03:32:13 +
Subject: [PATCH] Remove Linux path names in ROCm search paths on Windows
https://github.com/david-salinas created
https://github.com/llvm/llvm-project/pull/113628
Change-Id: Ia0b44eb1069fa631a6d5156cf5881c978e23b62d
>From 2bcd8608ca1e00893692f1d1f8b1734204abbd15 Mon Sep 17 00:00:00 2001
From: David Salinas
Date: Tue, 22 Oct 2024 18:58:47 +
Subject: [PATCH] Remo
https://github.com/david-salinas closed
https://github.com/llvm/llvm-project/pull/113225
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/david-salinas created
https://github.com/llvm/llvm-project/pull/113225
None
>From 803e3939a726bed2f1c43a3199850d580251c6d2 Mon Sep 17 00:00:00 2001
From: David Salinas
Date: Thu, 4 Jul 2024 03:32:13 +
Subject: [PATCH 1/3] Remove Linux path names in ROCm search paths on W
https://github.com/david-salinas updated
https://github.com/llvm/llvm-project/pull/97668
>From 803e3939a726bed2f1c43a3199850d580251c6d2 Mon Sep 17 00:00:00 2001
From: David Salinas
Date: Thu, 4 Jul 2024 03:32:13 +
Subject: [PATCH] Remove Linux path names in ROCm search paths on Windows
david-salinas wrote:
> > Compiler messages on HIP SDK for Windows
>
> Please rewrite this to say what the patch does or what problem it fixes.
Changed the PR (and commit) subject to something more meaningful/accurate.
https://github.com/llvm/llvm-project/pull/97668
@@ -0,0 +1,7 @@
+// UNSUPPORTED: system-linux
david-salinas wrote:
changed to REQUIRES: system-windows in latest patch
https://github.com/llvm/llvm-project/pull/97668
___
cfe-commits mailing list
cfe-commits@lists.llvm
https://github.com/david-salinas edited
https://github.com/llvm/llvm-project/pull/97668
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/david-salinas updated
https://github.com/llvm/llvm-project/pull/97668
>From 838ea93f30e9e421ad9948618cfcb61703d94029 Mon Sep 17 00:00:00 2001
From: David Salinas
Date: Thu, 4 Jul 2024 03:32:13 +
Subject: [PATCH] Remove Linux path names in ROCm search paths on Windows
https://github.com/david-salinas updated
https://github.com/llvm/llvm-project/pull/97668
>From 970b1e696b77216f326fb7d8dcad5b55a82db489 Mon Sep 17 00:00:00 2001
From: David Salinas
Date: Thu, 4 Jul 2024 03:32:13 +
Subject: [PATCH] Compiler messages on HIP SDK for Windows
When target
https://github.com/david-salinas updated
https://github.com/llvm/llvm-project/pull/97668
>From e9722655b4fd32b3128ba10b69b1b498e507d437 Mon Sep 17 00:00:00 2001
From: David Salinas
Date: Thu, 4 Jul 2024 03:32:13 +
Subject: [PATCH] Compiler messages on HIP SDK for Windows
When target
https://github.com/david-salinas created
https://github.com/llvm/llvm-project/pull/97668
When target triple indicates we are on Windows, do not add linux
paths to search path in ROCm Installation Detection.
Change-Id: I18effb8c20252de3d84ea37ef562124695c5a570
>From eb83f777e5e15f26
33 matches
Mail list logo
