[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

dmaclach updated this revision to Diff 502474. dmaclach added a comment. Moved to `REQUIRES: asan-static-runtime` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144672/new/ https://reviews.llvm.org/D144672 Files: clang/include/clang/Basic/Diagnos

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

dmaclach added a comment. Went with unsupported. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144672/new/ https://reviews.llvm.org/D144672 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

dmaclach updated this revision to Diff 502138. dmaclach marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144672/new/ https://reviews.llvm.org/D144672 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

dmaclach added inline comments. Comment at: compiler-rt/test/asan/TestCases/replaceable_new_delete_static.cpp:10-11 + +// darwin only supports shared-libsan, so this should fail. +// XFAIL: darwin + yln wrote: > This should work, right? No.. darwin should fail

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

dmaclach updated this revision to Diff 501899. dmaclach added a comment. Herald added subscribers: Sanitizers, Enna1. Updated with fixed tests for `replaceable_new_delete.cpp`. Split `replaceable_new_delete.cpp` into `replaceable_new_delete_shared.cpp` and `replaceable_new_delete_static.cpp`. St

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

dmaclach added a comment. Yep. Apologies. Been a long time since I committed anything to LLVM. I'll try and take a look tonight/first thing tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144672/new/ https://reviews.llvm.org/D144672 _

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

dmaclach added a comment. @usama54321 or @yln are you able to commit for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144672/new/ https://reviews.llvm.org/D144672 ___ cfe-commits mailing list cfe-co

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

dmaclach added a comment. Updated with buildable patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144672/new/ https://reviews.llvm.org/D144672 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D144926: darwin platforms do not support static-lsan with TSan or ASan but were "silently failing" in that they would just ignore the flag and link in the dynamic runtimes instead.

dmaclach abandoned this revision. dmaclach added a comment. Accidentally uploaded Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144926/new/ https://reviews.llvm.org/D144926 ___ cfe-commits mailing list c

[PATCH] D144672: [Sanitizers] Error when attempting to use `static-lsan` with `TSan` or `Asan` on darwin

dmaclach updated this revision to Diff 500942. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144672/new/ https://reviews.llvm.org/D144672 Files: clang/include/clang/Basic/Diagn

[PATCH] D144926: darwin platforms do not support static-lsan with TSan or ASan but were "silently failing" in that they would just ignore the flag and link in the dynamic runtimes instead.

dmaclach created this revision. Herald added a project: All. dmaclach requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This matches the pre-existing UBSan failure path. Repository: rG LLVM Github Monorepo https://reviews.llvm.or

[PATCH] D128031: Don't emit `-Wnullability-completeness` warnings on `weak` Objective-C properties.

dmaclach accepted this revision. dmaclach added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128031/new/ https://reviews.llvm.org/D128031 ___ cfe-commits mailing list cfe-commi

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

dmaclach added a comment. Thanks Puyan! Awesome to see this moving forward. Comment at: clang/test/CodeGenObjC/objc-direct-wrapper.m:30 +#if ENABLE_VISIBLE_OBJC_DIRECT +#define OBJC_DIRECT __attribute((objc_direct)) __attribute__((objc_direct_visible)) +#else

[PATCH] D120372: [clang] 'unused-but-set-variable' warning should not apply to __attribute__((objc_precise_lifetime) Objective-C pointers

dmaclach accepted this revision. dmaclach added inline comments. Comment at: clang/test/SemaObjC/objc-precise-lifetime-unused-variable.m:7 + // no diagnostics for objects with precise lifetime semantics. + __attribute__((objc_precise_lifetime)) id x; + x = getFoo(); --

[PATCH] D86049: RFC: Implement optional exportable wrapper function generation for objc_direct methods.

dmaclach added a comment. Has anything happened with this at all or did it get dropped? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86049/new/ https://reviews.llvm.org/D86049 ___ cfe-commits mailing li

[PATCH] D72876: Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class category.

dmaclach requested changes to this revision. dmaclach added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/docs/clang-tidy/checks/objc-dealloc-in-categories.rst:10 + +Classes implement ``-dealloc` to perform important actions just b

[PATCH] D67865: [clang-tidy] Finds uses of OSRead* calls on macOS that may mask unexpected behavior due to unaligned reads

dmaclach added a comment. Any other comments on this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67865/new/ https://reviews.llvm.org/D67865 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D67865: [clang-tidy] Finds uses of OSRead* calls on macOS that may mask unexpected behavior due to unaligned reads

dmaclach updated this revision to Diff 221433. dmaclach added a comment. Updated based on review CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67865/new/ https://reviews.llvm.org/D67865 Files: clang-tidy/objc/AvoidOSReadCheck.cpp clang-tidy/objc/AvoidOSReadCheck.h clang-tidy/objc

[PATCH] D67865: [clang-tidy] Finds uses of OSRead* calls on macOS that may mask unexpected behavior due to unaligned reads

dmaclach marked 5 inline comments as done. dmaclach added inline comments. Comment at: clang-tidy/objc/AvoidOSReadCheck.cpp:21 +void AvoidOSReadCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher( + callExpr(callee((functionDecl(hasAnyName(

[PATCH] D67865: [clang-tidy] Finds uses of OSRead* calls on macOS that may mask unexpected behavior due to unaligned reads

dmaclach updated this revision to Diff 221420. dmaclach added a comment. Fixed up review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67865/new/ https://reviews.llvm.org/D67865 Files: clang-tidy/objc/AvoidOSReadCheck.cpp clang-tidy/objc/AvoidOSReadCheck.h clang-tidy/ob

[PATCH] D67865: [clang-tidy] Finds uses of OSRead* calls on macOS that may mask unexpected behavior due to unaligned reads

dmaclach created this revision. dmaclach added a reviewer: alexfh. Herald added subscribers: cfe-commits, kristof.beyls, xazax.hun, mgorny. Herald added a project: clang. We ran into a problem in protocol buffers recently when compiling with Xcode 11 that caused crashes on 32 bit ARM architecture

[PATCH] D55544: Warning: objc-encodings-larger-than=

dmaclach added a comment. Akira/John/Erik - any thoughts? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55544/new/ https://reviews.llvm.org/D55544 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

[PATCH] D55640: [clang-tidy] Implement a check for large Objective-C type encodings 🔍

dmaclach added inline comments. Comment at: clang-tidy/objc/TypeEncodingSizeCheck.cpp:53 +diag(Block->getCaretLocation(), + "Objective-C type encoding for block expression exceeds %0 " + "characters") I found it very useful in my diagnostics t

[PATCH] D55544: Warning: objc-encodings-larger-than=

dmaclach updated this revision to Diff 177746. dmaclach added a comment. Updated to fix Stephane's good catch of Objective C vs Objective-C Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55544/new/ https://reviews.llvm.org/D55544 Files: docs/ReleaseNotes.rst

[PATCH] D55544: Warning: objc-encodings-larger-than=

dmaclach updated this revision to Diff 177744. dmaclach marked an inline comment as done. dmaclach added a comment. Full Diffs as requested. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55544/new/ https://reviews.llvm.org/D55544 Files: docs/ReleaseNotes.rst

[PATCH] D55544: Warning: objc-encodings-larger-than=

dmaclach added a comment. In D55544#1326956 , @theraven wrote: > It would probably be a good idea to have a similar check on properties, as > property encoding strings contain the type encoding (plus extra stuff). Properties are already picked up based

[PATCH] D55544: Warning: objc-encodings-larger-than=

dmaclach updated this revision to Diff 177732. dmaclach added a comment. Added some spacing around early exit as requested by theraven. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55544/new/ https://reviews.llvm.org/D55544 Files: docs/ReleaseNotes.rst incl

[PATCH] D55544: Warning: objc-encodings-larger-than=

dmaclach created this revision. dmaclach added a project: clang. Herald added a subscriber: cfe-commits. Issue a warning when the Objective C runtime encoding generated for an iVar, method, or block exceeds a user configurable value. Off by default. Note that handling iVars and methods will als