[PATCH] D137340: [clang-tidy] Add misc-use-anonymous-namespace check

2022-11-30 Thread Dave Brown via Phabricator via cfe-commits
bigdavedev accepted this revision. bigdavedev added a comment. This revision is now accepted and ready to land. Looks good to me. All comments/suggestions/concerns addressed. Comment at: clang-tools-extra/docs/clang-tidy/checks/misc/use-anonymous-namespace.rst:7-9 +that could

[PATCH] D137340: [clang-tidy] Add misc-use-anonymous-namespace check

2022-11-29 Thread Dave Brown via Phabricator via cfe-commits
bigdavedev added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/misc/use-anonymous-namespace.rst:7-9 +that could instead be moved into an anonymous namespace. It also detects +instances moved to an anonymous namespace that still keep the redundant +``stati

[PATCH] D132461: [clang-tidy] Add cppcoreguidelines-avoid-do-while check

2022-10-09 Thread Dave Brown via Phabricator via cfe-commits
bigdavedev accepted this revision. bigdavedev added a comment. This revision is now accepted and ready to land. LGTM. All comments addressed and the check world as intended. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132461/new/ https://reviews.

[PATCH] D126880: [clang-tidy] Add cppcoreguidelines-avoid-const-or-ref-data-members check

2022-08-11 Thread Dave Brown via Phabricator via cfe-commits
bigdavedev accepted this revision. bigdavedev added a comment. LGTM. All comments have been addressed. Any improvements to the diagnostics can be made down the line depending on how users feel about them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or