[clang] [clang-tools-extra] [lld] [lldb] [llvm] [mlir] [polly] [NFC] Add explicit #include llvm-config.h where its macros are used. (PR #106810)

2024-09-16 Thread Daniil Fukalov via cfe-commits
dfukalov wrote: Gentle ping... https://github.com/llvm/llvm-project/pull/106810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [NFC] Add explicit #include llvm-config.h where its macros are used, clang part. (PR #107301)

2024-09-06 Thread Daniil Fukalov via cfe-commits
https://github.com/dfukalov closed https://github.com/llvm/llvm-project/pull/107301 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [NFC] Add explicit #include llvm-config.h where its macros are used, clang part. (PR #107301)

2024-09-06 Thread Daniil Fukalov via cfe-commits
@@ -15,6 +15,7 @@ #include "clang/Driver/InputInfo.h" #include "clang/Driver/Options.h" #include "clang/Driver/SanitizerArgs.h" +#include "llvm/Config/llvm-config.h" // for LLVM_HOST_TRIPLE dfukalov wrote: Well, I guess such files (with configuration defines o

[clang] [clang-tools-extra] [lld] [lldb] [llvm] [mlir] [polly] [NFC] Add explicit #include llvm-config.h where its macros are used. (PR #106810)

2024-09-06 Thread Daniil Fukalov via cfe-commits
https://github.com/dfukalov updated https://github.com/llvm/llvm-project/pull/106810 >From 8232271806ea605fb4f7212d842a328307070003 Mon Sep 17 00:00:00 2001 From: dfukalov Date: Sat, 31 Aug 2024 01:45:27 +0200 Subject: [PATCH 1/3] [NFC] Add explicit #include llvm-config.h where its macros are

[clang] [clang-tools-extra] [NFC] Add explicit #include llvm-config.h where its macros are used, clang part. (PR #107301)

2024-09-04 Thread Daniil Fukalov via cfe-commits
https://github.com/dfukalov updated https://github.com/llvm/llvm-project/pull/107301 >From f955f992b39bfcbdd7d200664678d4c1884c2fd4 Mon Sep 17 00:00:00 2001 From: dfukalov Date: Wed, 4 Sep 2024 22:11:24 +0200 Subject: [PATCH] [NFC] Add explicit #include llvm-config.h where its macros are used,

[clang] [clang-tools-extra] [NFC] Add explicit #include llvm-config.h where its macros are used, clang part. (PR #107301)

2024-09-04 Thread Daniil Fukalov via cfe-commits
https://github.com/dfukalov ready_for_review https://github.com/llvm/llvm-project/pull/107301 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [lld] [lldb] [llvm] [mlir] [polly] [NFC] Add explicit #include llvm-config.h where its macros are used. (PR #106810)

2024-09-04 Thread Daniil Fukalov via cfe-commits
https://github.com/dfukalov updated https://github.com/llvm/llvm-project/pull/106810 >From 7e9c4b1d0da02cf923a790c8025ac1e1a333094e Mon Sep 17 00:00:00 2001 From: dfukalov Date: Sat, 31 Aug 2024 01:45:27 +0200 Subject: [PATCH 1/3] [NFC] Add explicit #include llvm-config.h where its macros are

[clang] [clang-tools-extra] [lld] [lldb] [llvm] [mlir] [polly] [NFC] Add explicit #include llvm-config.h where its macros are used. (PR #106810)

2024-09-04 Thread Daniil Fukalov via cfe-commits
https://github.com/dfukalov ready_for_review https://github.com/llvm/llvm-project/pull/106810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [NFC] Add explicit #include llvm-config.h where its macros are used, clang part. (PR #107301)

2024-09-04 Thread Daniil Fukalov via cfe-commits
https://github.com/dfukalov created https://github.com/llvm/llvm-project/pull/107301 (this is clang related part) Without these explicit includes, removing other headers, who implicitly include llvm-config.h, may have non-trivial side effects. For example, `clagd` may report even `llvm-config

[clang] [clang-tools-extra] [lld] [lldb] [llvm] [mlir] [polly] [NFC] Add explicit #include llvm-config.h where its macros are used. (PR #106810)

2024-09-04 Thread Daniil Fukalov via cfe-commits
https://github.com/dfukalov updated https://github.com/llvm/llvm-project/pull/106810 >From 0221e97459534f0f7396e7970663e1a4f1f98cca Mon Sep 17 00:00:00 2001 From: dfukalov Date: Sat, 31 Aug 2024 01:45:27 +0200 Subject: [PATCH 1/3] [NFC] Add explicit #include llvm-config.h where its macros are

[clang] [clang-tools-extra] [lld] [lldb] [llvm] [mlir] [polly] [NFC] Add explicit #include llvm-config.h where its macros are used. (PR #106810)

2024-09-03 Thread Daniil Fukalov via cfe-commits
https://github.com/dfukalov updated https://github.com/llvm/llvm-project/pull/106810 >From 0221e97459534f0f7396e7970663e1a4f1f98cca Mon Sep 17 00:00:00 2001 From: dfukalov Date: Sat, 31 Aug 2024 01:45:27 +0200 Subject: [PATCH 1/2] [NFC] Add explicit #include llvm-config.h where its macros are

[clang] [clang-tools-extra] [lld] [lldb] [llvm] [mlir] [polly] [NFC] Add explicit #include llvm-config.h where its macros are used. (PR #106810)

2024-08-31 Thread Daniil Fukalov via cfe-commits
https://github.com/dfukalov edited https://github.com/llvm/llvm-project/pull/106810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [lld] [lldb] [llvm] [mlir] [polly] [NFC] Add explicit #include llvm-config.h where its macros are used. (PR #106810)

2024-08-30 Thread Daniil Fukalov via cfe-commits
https://github.com/dfukalov created https://github.com/llvm/llvm-project/pull/106810 This is the second part. Without these explicit includes, removing other headers, who implicitly include llvm-config.h, may have non-trivial side effects. For example, `clagd` may report even `llvm-config.h`

[clang] [lld] [llvm] [NFC] Cleanup in Support headers. (PR #104825)

2024-08-20 Thread Daniil Fukalov via cfe-commits
https://github.com/dfukalov updated https://github.com/llvm/llvm-project/pull/104825 >From cce13227c78d3d1831fb8773fc52005fabd412c6 Mon Sep 17 00:00:00 2001 From: dfukalov Date: Mon, 19 Aug 2024 20:02:52 +0200 Subject: [PATCH 1/5] [NFC] Cleanup in Support headers. Remove unused directly includ

[clang] [lld] [llvm] [NFC] Cleanup in Support headers. (PR #104825)

2024-08-20 Thread Daniil Fukalov via cfe-commits
https://github.com/dfukalov updated https://github.com/llvm/llvm-project/pull/104825 >From cce13227c78d3d1831fb8773fc52005fabd412c6 Mon Sep 17 00:00:00 2001 From: dfukalov Date: Mon, 19 Aug 2024 20:02:52 +0200 Subject: [PATCH 1/4] [NFC] Cleanup in Support headers. Remove unused directly includ

[clang] [lld] [llvm] [NFC] Cleanup in Support headers. (PR #104825)

2024-08-19 Thread Daniil Fukalov via cfe-commits
https://github.com/dfukalov updated https://github.com/llvm/llvm-project/pull/104825 >From cce13227c78d3d1831fb8773fc52005fabd412c6 Mon Sep 17 00:00:00 2001 From: dfukalov Date: Mon, 19 Aug 2024 20:02:52 +0200 Subject: [PATCH 1/2] [NFC] Cleanup in Support headers. Remove unused directly includ

[clang] [lld] [llvm] [NFC] Cleanup in Support headers. (PR #104825)

2024-08-19 Thread Daniil Fukalov via cfe-commits
dfukalov wrote: For reference: [compile-time-tracker run](https://llvm-compile-time-tracker.com/compare.php?from=82fdfd4aa7f60b1f8e715211b925a7f2bfe57ea9&to=70b88a21f2c8bc26a0178c6ae9aa2b0834e8&stat=instructions%3Au) with the change (please check the instructions:u for "clang build" at the

[clang] [lld] [llvm] [NFC] Cleanup in Support headers. (PR #104825)

2024-08-19 Thread Daniil Fukalov via cfe-commits
https://github.com/dfukalov created https://github.com/llvm/llvm-project/pull/104825 Remove unused directly includes and forward declarations in Support headers. >From cce13227c78d3d1831fb8773fc52005fabd412c6 Mon Sep 17 00:00:00 2001 From: dfukalov Date: Mon, 19 Aug 2024 20:02:52 +0200 Subject

[clang] [lld] [llvm] [mlir] [NFC][IWYU] Update Support library with IWYU. (PR #102707)

2024-08-15 Thread Daniil Fukalov via cfe-commits
https://github.com/dfukalov closed https://github.com/llvm/llvm-project/pull/102707 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lld] [llvm] [mlir] [NFC][IWYU] Update Support library with IWYU. (PR #102707)

2024-08-15 Thread Daniil Fukalov via cfe-commits
dfukalov wrote: Created other [PR 104484](https://github.com/llvm/llvm-project/pull/104484) with reworked/reduced cleanup. https://github.com/llvm/llvm-project/pull/102707 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang] [lld] [llvm] [mlir] [NFC][IWYU] Update Support library with IWYU. (PR #102707)

2024-08-12 Thread Daniil Fukalov via cfe-commits
dfukalov wrote: > Could you try preprocessing each affected source file (i.e. compile it with > -E) and see whether the total number of included source lines goes up or > down? I think that would help to demonstrate whether this patch violates the > "include as little as possible" philosophy.

[clang] [lld] [llvm] [mlir] [NFC][IWYU] Update Support library with IWYU. (PR #102707)

2024-08-12 Thread Daniil Fukalov via cfe-commits
dfukalov wrote: > Can you provide more context on the motivation / what you're trying to > achieve here? The motivation is as usual IWYU and similar refactoring - to reduce build time and probablility of non-related source(s) recompile. > Did you know that LLVM intentionally does not follow I

[clang] [lld] [llvm] [mlir] [NFC][IWYU] Update includes in Support lib with IWYU. (PR #102306)

2024-08-09 Thread Daniil Fukalov via cfe-commits
https://github.com/dfukalov closed https://github.com/llvm/llvm-project/pull/102306 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r332848 - [AMDGPU] fixes for lds f32 builtins

2018-05-21 Thread Daniil Fukalov via cfe-commits
Author: dfukalov Date: Mon May 21 09:18:07 2018 New Revision: 332848 URL: http://llvm.org/viewvc/llvm-project?rev=332848&view=rev Log: [AMDGPU] fixes for lds f32 builtins 1. added restrictions to memory scope, order and volatile parameters 2. added custom processing for these builtins - currently

r324201 - Recommit rL323890: [AMDGPU] Add ds_fadd, ds_fmin, ds_fmax builtins functions

2018-02-06 Thread Daniil Fukalov via cfe-commits
Author: dfukalov Date: Sun Feb 4 14:32:07 2018 New Revision: 324201 URL: http://llvm.org/viewvc/llvm-project?rev=324201&view=rev Log: Recommit rL323890: [AMDGPU] Add ds_fadd, ds_fmin, ds_fmax builtins functions Fixed asserts in tests. Modified: cfe/trunk/include/clang/Basic/BuiltinsAMDGPU.d

r323896 - Revert "[AMDGPU] Add ds_fadd, ds_fmin, ds_fmax builtins functions"

2018-02-01 Thread Daniil Fukalov via cfe-commits
Author: dfukalov Date: Wed Jan 31 10:49:49 2018 New Revision: 323896 URL: http://llvm.org/viewvc/llvm-project?rev=323896&view=rev Log: Revert "[AMDGPU] Add ds_fadd, ds_fmin, ds_fmax builtins functions" This reverts https://reviews.llvm.org/rL323890 This reverts commit 251524ebd8c346a936f0e74b09d

r323890 - [AMDGPU] Add ds_fadd, ds_fmin, ds_fmax builtins functions

2018-01-31 Thread Daniil Fukalov via cfe-commits
Author: dfukalov Date: Wed Jan 31 08:55:09 2018 New Revision: 323890 URL: http://llvm.org/viewvc/llvm-project?rev=323890&view=rev Log: [AMDGPU] Add ds_fadd, ds_fmin, ds_fmax builtins functions Reviewed by arsenm Differential Revision: https://reviews.llvm.org/D42578 Modified: cfe/trunk/incl