https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/160141
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cor3ntin wrote:
I thought the plan was to get rid of Builtins.def entirely? Maybe it's not
worth spending time on it. migrating to td files seems like a better use of
time!
https://github.com/llvm/llvm-project/pull/160080
___
cfe-commits mailing list
cor3ntin wrote:
@Sirraide
https://github.com/llvm/llvm-project/pull/160065
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cor3ntin wrote:
Can you add a test, a release note, and a longer PR description? Thanks
https://github.com/llvm/llvm-project/pull/160047
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/159976
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -222,7 +222,6 @@ RegistryMaps::RegistryMaps() {
REGISTER_MATCHER(declRefExpr);
REGISTER_MATCHER(dependentNameType);
REGISTER_MATCHER(dependentScopeDeclRefExpr);
- REGISTER_MATCHER(dependentTemplateSpecializationType);
cor3ntin wrote:
I'm happy with t
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/158629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/158109
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/159280
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/159712
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/141776
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/159928
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/158093
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/122265
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/159463
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/122265
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/159712
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cor3ntin wrote:
This is now https://cplusplus.github.io/CWG/issues/3068.html
https://github.com/llvm/llvm-project/pull/141340
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/159275
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2544,6 +2544,19 @@ Stmt *BlockExpr::getBody() {
//===--===//
// Generic Expression Routines
//===--===//
+namespace {
+/// Helper to det
@@ -2544,6 +2544,19 @@ Stmt *BlockExpr::getBody() {
//===--===//
// Generic Expression Routines
//===--===//
+namespace {
+/// Helper to det
https://github.com/cor3ntin commented:
Just as few nits (sorry for the delay and thanks for the pings!)
https://github.com/llvm/llvm-project/pull/122265
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
@@ -2544,6 +2544,19 @@ Stmt *BlockExpr::getBody() {
//===--===//
// Generic Expression Routines
//===--===//
+namespace {
+/// Helper to det
@@ -2544,6 +2544,19 @@ Stmt *BlockExpr::getBody() {
//===--===//
// Generic Expression Routines
//===--===//
+namespace {
+/// Helper to det
@@ -2544,6 +2544,19 @@ Stmt *BlockExpr::getBody() {
//===--===//
// Generic Expression Routines
//===--===//
+namespace {
+/// Helper to det
@@ -10,11 +10,68 @@
//
//===--===//
+/*
+ * A note on implementation:
+ *
+ * As per the C++ standard, constraints are normalized [temp.constr.normal]
cor3ntin wrote:
Yes!
https://github.co
@@ -28,10 +28,19 @@ namespace clang {
class ConceptDecl;
class TemplateDecl;
+class ConceptReference;
class Expr;
class NamedDecl;
struct PrintingPolicy;
+/// Pairs of unsatisfied atomic constraint expressions along with the
+/// substituted constraint expr, if the templa
@@ -16,130 +16,385 @@
#include "clang/AST/ASTContext.h"
#include "clang/AST/DeclTemplate.h"
#include "clang/AST/Expr.h"
+#include "clang/AST/ExprConcepts.h"
#include "clang/Basic/SourceLocation.h"
+#include "clang/Sema/Ownership.h"
#include "llvm/ADT/FoldingSet.h"
-#include "
@@ -28,10 +28,19 @@ namespace clang {
class ConceptDecl;
class TemplateDecl;
+class ConceptReference;
class Expr;
class NamedDecl;
struct PrintingPolicy;
+/// Pairs of unsatisfied atomic constraint expressions along with the
+/// substituted constraint expr, if the templa
@@ -16,130 +16,385 @@
#include "clang/AST/ASTContext.h"
#include "clang/AST/DeclTemplate.h"
#include "clang/AST/Expr.h"
+#include "clang/AST/ExprConcepts.h"
#include "clang/Basic/SourceLocation.h"
+#include "clang/Sema/Ownership.h"
#include "llvm/ADT/FoldingSet.h"
-#include "
@@ -51,6 +51,27 @@ class FixedPointSemantics;
struct fltSemantics;
template class SmallPtrSet;
+template <> struct DenseMapInfo {
+ static FoldingSetNodeID getEmptyKey() { return FoldingSetNodeID{}; }
+
+ static FoldingSetNodeID getTombstoneKey() {
+FoldingSetNodeID id;
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/159718
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cor3ntin wrote:
@tbaederr @mizvekov Is the plan for Tim's patch to be backported and for this
one to be in 22? This would make sense.
I reported a core issue here https://cplusplus.github.io/CWG/issues/3071.html
https://github.com/llvm/llvm-project/pull/159677
__
@@ -116,6 +122,19 @@ void ConceptReference::print(llvm::raw_ostream &OS,
}
}
+const StreamingDiagnostic &clang::operator<<(const StreamingDiagnostic &DB,
+ const ConceptReference *C) {
+ std::string NameStr;
+ llvm::raw_string_os
https://github.com/cor3ntin auto_merge_enabled
https://github.com/llvm/llvm-project/pull/159593
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin updated
https://github.com/llvm/llvm-project/pull/159718
>From 13e53f843c32d93dd898cc6965e272d077783467 Mon Sep 17 00:00:00 2001
From: Corentin Jabot
Date: Fri, 19 Sep 2025 10:12:17 +0200
Subject: [PATCH] [Clang][NFC] Remove duplicated specialization of
`llvm::Dense
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/159712
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2028,7 +2028,9 @@ void StmtPrinter::VisitAtomicExpr(AtomicExpr *Node) {
Node->getOp() != AtomicExpr::AO__atomic_load_n &&
Node->getOp() != AtomicExpr::AO__scoped_atomic_load_n &&
Node->getOp() != AtomicExpr::AO__opencl_atomic_load &&
- Node->getOp() !
@@ -176,6 +176,17 @@ float test15() {
return __builtin_asinf(1.0F);
}
+// CHECK: void test16() {
+// CHECK: char *ptr;
+// CHECK: __atomic_test_and_set(ptr, 0);
+// CHECK: __atomic_clear(ptr, 0);
+// CHECK: }
+void test16() {
+ char *ptr;
+ __atomic_test_and_set(ptr,
https://github.com/cor3ntin commented:
This change needs a release note.
Please add an entry to `clang/docs/ReleaseNotes.rst` in the section the most
adapted to the change, and referencing any Github issue this change fixes.
Thanks!
https://github.com/llvm/llvm-project/pull/159712
https://github.com/cor3ntin created
https://github.com/llvm/llvm-project/pull/159718
In preparation of #141776
>From de3b12cc09c5d5302e0785c1431ff11650a9c9b6 Mon Sep 17 00:00:00 2001
From: Corentin Jabot
Date: Fri, 19 Sep 2025 10:12:17 +0200
Subject: [PATCH] [Clang][NFC] Remove duplicated spec
cor3ntin wrote:
> https://releases.llvm.org/21.1.0/tools/clang/docs/UsersManual.html#cmdoption-f-no-rounding-math.
> @AaronBallman, do you know if the design decision has been made and whether
> we have documented it? Relevant prior discussion here:
> https://discourse.llvm.org/t/rfc-calling-f
cor3ntin wrote:
I agree with @shafik here, this needs more motivation.
I'm not sure we want to follow GCC's behavior here.
In general `__builtin_constant_p` is pretty confusing and I would prefer to be
conservative - or at least changing it might warrant a wider discussion / rfc
https://github
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/141776
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -116,6 +122,19 @@ void ConceptReference::print(llvm::raw_ostream &OS,
}
}
+const StreamingDiagnostic &clang::operator<<(const StreamingDiagnostic &DB,
+ const ConceptReference *C) {
cor3ntin wrote:
Yup, this is
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/159593
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cor3ntin wrote:
We should backport that
https://github.com/llvm/llvm-project/pull/159579
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/159579
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -27,13 +27,23 @@
namespace clang {
class ConceptDecl;
+class ConceptReference;
class Expr;
class NamedDecl;
struct PrintingPolicy;
+/// Pairs of unsatisfied atomic constraint expressions along with the
+/// substituted constraint expr, if the template arguments could b
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/159512
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cor3ntin wrote:
This seems large enough that it might warrant an RFC with a more detailed
motivation
https://clang.llvm.org/get_involved.html#:~:text=The%20Clang%20community%20uses,will%20proceed%20or%20not.
@erichkeane @rnk
https://github.com/llvm/llvm-project/pull/152372
_
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/159504
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/159314
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/154134
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cor3ntin wrote:
@brunodf-snps @mstorsjo Please synchronize to avoid duplicates
Duplicate of #159338
https://github.com/llvm/llvm-project/pull/159316
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
@@ -543,30 +661,328 @@ static ExprResult calculateConstraintSatisfaction(
return ExprError();
}
- assert(EvalResult.Val.isInt() &&
- "evaluating bool expression didn't produce int");
- Satisfaction.IsSatisfied = EvalResult.Val.getInt().getBoolValue();
- if (!S
cor3ntin wrote:
@philnik777
https://github.com/llvm/llvm-project/pull/158048
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/159316
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/159330
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/159334
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/159349
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1778,10 +1778,20 @@ def ext_bit_int : Extension<
} // end of Parse Issue category.
let CategoryName = "Modules Issue" in {
-def err_unexpected_module_decl : Error<
- "module declaration can only appear at the top level">;
+def err_invalid_module_or_import_directive : Erro
@@ -945,6 +945,7 @@ namespace {
}
ASTContext &getASTContext() const override { return Ctx; }
+const LangOptions &getLangOpts() const { return Ctx.getLangOpts(); }
cor3ntin wrote:
Hum, okay i missed that `EvalInfo` inherits from `interp::State` - t
cor3ntin wrote:
I'm not opposed to this change but we might want to report that to GCC, it is a
false positive
https://github.com/llvm/llvm-project/pull/159330
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
cor3ntin wrote:
I think it might be cleaner in that case to have two different if statements
(one for isRegularKeywordAttribute and one for isDeclspecAttribute)
https://github.com/llvm/llvm-project/pull/159338
___
cfe-commits mailing list
cfe-commits@
cor3ntin wrote:
Duplicate of #159275
https://github.com/llvm/llvm-project/pull/159334
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin created
https://github.com/llvm/llvm-project/pull/159314
Not all non-type template arguments are modeled as NonTypeTemplateParmDecl.
Fixes #151531
>From 7959f5ef8d3efb7bf742443454255420fa6b5a53 Mon Sep 17 00:00:00 2001
From: Corentin Jabot
Date: Wed, 17 Sep 2025 12
@@ -945,6 +945,7 @@ namespace {
}
ASTContext &getASTContext() const override { return Ctx; }
+const LangOptions &getLangOpts() const { return Ctx.getLangOpts(); }
cor3ntin wrote:
Is that used?
https://github.com/llvm/llvm-project/pull/159280
cor3ntin wrote:
Thank you for this PR! Will you need us to land it for you?
https://github.com/llvm/llvm-project/pull/158688
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/158688
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/158541
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cor3ntin wrote:
LGTM but can you add a description to the PR and a release note? thanks
https://github.com/llvm/llvm-project/pull/158688
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -16,130 +16,385 @@
#include "clang/AST/ASTContext.h"
#include "clang/AST/DeclTemplate.h"
#include "clang/AST/Expr.h"
+#include "clang/AST/ExprConcepts.h"
#include "clang/Basic/SourceLocation.h"
+#include "clang/Sema/Ownership.h"
#include "llvm/ADT/FoldingSet.h"
-#include "
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/158615
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cor3ntin wrote:
While I personally favors your approach, I don't think we ever came to a
conclusion in https://github.com/llvm/llvm-project/issues/88896
@Sirraide @jansvoboda11 @nishithshah2211 @Bigcheese
(Regardless, please update the description of the PR so people understand what
we are
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/158515
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
LGTM, but we need a changelog entry
https://github.com/llvm/llvm-project/pull/158414
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
cor3ntin wrote:
Younan did a solid half of that patch.
We tested the changes with std::exec, ranges v3 and libc++.
There may be performance regressions in some cases in concept-heavy code bases,
although we do not have definitive benchmarks. We tried to mitigate that with
multiple level of cac
@@ -543,30 +661,328 @@ static ExprResult calculateConstraintSatisfaction(
return ExprError();
}
- assert(EvalResult.Val.isInt() &&
- "evaluating bool expression didn't produce int");
- Satisfaction.IsSatisfied = EvalResult.Val.getInt().getBoolValue();
- if (!S
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/158109
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -543,30 +672,330 @@ static ExprResult calculateConstraintSatisfaction(
return ExprError();
}
- assert(EvalResult.Val.isInt() &&
- "evaluating bool expression didn't produce int");
- Satisfaction.IsSatisfied = EvalResult.Val.getInt().getBoolValue();
- if (!S
cor3ntin wrote:
@erichkeane any objection merging that ?
https://github.com/llvm/llvm-project/pull/142936
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -222,7 +222,6 @@ RegistryMaps::RegistryMaps() {
REGISTER_MATCHER(declRefExpr);
REGISTER_MATCHER(dependentNameType);
REGISTER_MATCHER(dependentScopeDeclRefExpr);
- REGISTER_MATCHER(dependentTemplateSpecializationType);
cor3ntin wrote:
I was not able t
https://github.com/cor3ntin commented:
This is a neat change. I only did a cursory review for now but I like the
direct and did not spot anything jaring. We do need to be a bit more careful
about the AST matcher changes though
https://github.com/llvm/llvm-project/pull/158109
__
cor3ntin wrote:
@Bigcheese
https://github.com/llvm/llvm-project/pull/107168
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -164,52 +171,290 @@ struct SatisfactionStackRAII {
SatisfactionStackRAII(Sema &SemaRef, const NamedDecl *ND,
const llvm::FoldingSetNodeID &FSNID)
: SemaRef(SemaRef) {
- if (ND) {
+if (ND) {
SemaRef.PushSatisfactionStackEntry(ND
@@ -1658,31 +2158,61 @@ NormalizedConstraint::fromConstraintExpr(Sema &S, const
NamedDecl *D,
: FoldExpandedConstraint::FoldOperatorKind::Or;
if (FE->getInit()) {
- auto LHS = fromConstraintExpr(S, D, FE->getLHS());
- auto RHS = fromConstraintExpr(S,
@@ -543,30 +672,330 @@ static ExprResult calculateConstraintSatisfaction(
return ExprError();
}
- assert(EvalResult.Val.isInt() &&
- "evaluating bool expression didn't produce int");
- Satisfaction.IsSatisfied = EvalResult.Val.getInt().getBoolValue();
- if (!S
@@ -543,30 +672,330 @@ static ExprResult calculateConstraintSatisfaction(
return ExprError();
}
- assert(EvalResult.Val.isInt() &&
- "evaluating bool expression didn't produce int");
- Satisfaction.IsSatisfied = EvalResult.Val.getInt().getBoolValue();
- if (!S
cor3ntin wrote:
Can you add a test? Thanks
https://github.com/llvm/llvm-project/pull/157585
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/157662
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -6313,30 +6313,38 @@ static FunctionDecl *rewriteBuiltinFunctionDecl(Sema
*Sema, ASTContext &Context,
unsigned i = 0;
SmallVector OverloadParams;
- for (QualType ParamType : FT->param_types()) {
+ {
+// The lvalue conversions in this loop are only for type resolu
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/157364
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/157501
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/154034
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/154034
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
LGTM but let's see if other people have opinions in the next few days.
That GCC did it first and did not get pushback is reassuring
@erichkeane
https://github.com/llvm/llvm-project/pull/157364
__
@@ -223,6 +223,7 @@ Deprecated Compiler Flags
Modified Compiler Flags
---
- The `-gkey-instructions` compiler flag is now enabled by default when DWARF
is emitted for plain C/C++ and optimizations are enabled. (#GH149509)
+- The `-Wnrvo` compiler flag will
cor3ntin wrote:
Thanks for working on this.
I have some concerns that we do that transformation even in non template
contexts, it seems a fairly big hammer. Can you try to find ways to limit how
often the cloning is done? id you explore the other suggestion made by
@zygoloid at all ? (to do
cor3ntin wrote:
> Is an RFC required? CC @cor3ntin
I this so, yes, this is sufficiently weird and novel that it needs an RFC - I
am a bit surprised by the motivation, especially in light of MSVC successfully
deploying expected with `nodiscard` - Is this a solution in search of a problem?
http
1 - 100 of 775 matches
Mail list logo
