Re: r260742 - [CMake] Improve the clang order-file generation workflow

2016-02-16 Thread ChrisBieneman via cfe-commits
Ugh... That is most scary. Do you happen to know if this occurred with Gold, GNU ld or both? I had tested this patch on Darwin, FreeBSD and Linux with GNU ld. For that error to happen it means that the linker isn't handling -order_file as an invalid argument instead it is treating it as a "-o" a

Re: r260707 - [CMake] Pass stage1 tools through to stage2 when building with LTO

2016-02-12 Thread ChrisBieneman via cfe-commits
It is needed if you're doing LTO. If you're not doing an LTO build using the host AR will work, and it is faster to not have to build extra targets. It is really just a build-time optimization. -Chris > On Feb 12, 2016, at 11:52 AM, Rafael EspĂ­ndola > wrote: > > Any reason it is lto specific