CaseyCarter wrote:
You really should backport this. A 19.1.x release will probably happen before
we release 17.13, so you can claim compatibility with future MSVC. 🔮
https://github.com/llvm/llvm-project/pull/112378
___
cfe-commits mailing list
cfe-co
https://github.com/CaseyCarter approved this pull request.
https://github.com/llvm/llvm-project/pull/112378
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/CaseyCarter edited
https://github.com/llvm/llvm-project/pull/112378
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/CaseyCarter edited
https://github.com/llvm/llvm-project/pull/112378
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -215,8 +215,7 @@ static void addVisualCDefines(const LangOptions &Opts,
MacroBuilder &Builder) {
if (Opts.isCompatibleWithMSVC(LangOptions::MSVC2015)) {
if (Opts.CPlusPlus23)
-// TODO update to the proper value.
-Builder.defineMacro("_MSVC_LANG",
CaseyCarter wrote:
> @CaseyCarter It feels like we are missing an arm64ec check here,
> https://github.com/microsoft/STL/blob/be81252ed1f5e5fc6d77faca0b5dbbbdae8143a2/stl/inc/type_traits#L398
> unless this was intentional and just not documented?
I have absolutely no idea what's going on here
https://github.com/CaseyCarter approved this pull request.
Thanks for devising this clever way to improve MSVCSTL throughput!
https://github.com/llvm/llvm-project/pull/75711
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org
https://github.com/CaseyCarter closed
https://github.com/llvm/llvm-project/pull/68419
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
CaseyCarter wrote:
The test failure _cannot possibly_ be related to this nearly non-functional
change. Shall I merge anyway, or rerun?
```
TEST 'BOLT :: RISCV/reloc-tls.s' FAILED
 | Exit Code: 1
 | Â
 | Command Output (stderr):
 | --
 | RUN: at lin
https://github.com/CaseyCarter created
https://github.com/llvm/llvm-project/pull/68419
Apparently great minds think alike: I noticed these while correcting the same
typo in MSVC's sources.
>From 2c4ce58cb944774bcfc404ebbeed167c320fbb28 Mon Sep 17 00:00:00 2001
From: Casey Carter
Date: Fri, 6
Author: Casey Carter
Date: 2020-04-28T14:51:37-07:00
New Revision: 68b30bc02b3a7e84d03f43a82cc08e5df76a28dd
URL:
https://github.com/llvm/llvm-project/commit/68b30bc02b3a7e84d03f43a82cc08e5df76a28dd
DIFF:
https://github.com/llvm/llvm-project/commit/68b30bc02b3a7e84d03f43a82cc08e5df76a28dd.diff
Author: caseycarter
Date: Mon Jul 9 16:45:09 2018
New Revision: 336618
URL: http://llvm.org/viewvc/llvm-project?rev=336618&view=rev
Log:
[test] two small cleanups:
* Remove unused type from is_assignable.pass.cpp
* Don't specialize `common_type<::X>` in common_type.pass.cpp, which
violates the
Author: caseycarter
Date: Sat Jul 7 17:06:27 2018
New Revision: 336502
URL: http://llvm.org/viewvc/llvm-project?rev=336502&view=rev
Log:
type_traits: aligned_union is NOT the same as __uncvref [NFC]
Modified:
libcxx/trunk/include/type_traits
Modified: libcxx/trunk/include/type_traits
URL:
Author: caseycarter
Date: Mon Apr 9 13:41:45 2018
New Revision: 329618
URL: http://llvm.org/viewvc/llvm-project?rev=329618&view=rev
Log:
[test] [NFC] cleanup aligned_storage test
* `s/"" )/"")/g`
* Don't redundantly test triviality for `TEST_STD_VER > 17`
Modified:
libcxx/trunk/test/std/ut
Author: caseycarter
Date: Tue Dec 12 09:22:24 2017
New Revision: 320500
URL: http://llvm.org/viewvc/llvm-project?rev=320500&view=rev
Log:
workaround PR 28385 in __find_exactly_one_checked
Fixes #35578.
Differential Revision: D41048
Modified:
libcxx/trunk/include/tuple
Modified: libcxx/trun
Author: caseycarter
Date: Wed Nov 15 11:14:45 2017
New Revision: 318325
URL: http://llvm.org/viewvc/llvm-project?rev=318325&view=rev
Log:
[test] Alignment must be > __STDCPP_DEFAULT_NEW_ALIGNMENT__ to call aligned new
Differential Revision: D39221
Modified:
libcxx/trunk/test/std/language.su
Author: caseycarter
Date: Sat Sep 30 16:15:22 2017
New Revision: 314608
URL: http://llvm.org/viewvc/llvm-project?rev=314608&view=rev
Log:
[test] Allow other implementations to strengthen noexcept on deque's move
constructor
Modified:
libcxx/trunk/test/std/containers/sequences/deque/deque.co
Author: caseycarter
Date: Thu Sep 28 13:23:43 2017
New Revision: 314459
URL: http://llvm.org/viewvc/llvm-project?rev=314459&view=rev
Log:
[test] forwardlist.cons/move_noexcept.pass.cpp
* Don't forbid non-libc++ implementations from strengthening noexcept on
forward_list's move constructor.
Modi
Author: caseycarter
Date: Thu Aug 31 10:56:31 2017
New Revision: 312256
URL: http://llvm.org/viewvc/llvm-project?rev=312256&view=rev
Log:
[test] Cleanup nullopt_t tests
* Update specification text from N4387
* Delete not_brace_initializable.fail.cpp: it's redundant with
nullopt_t.fail.cpp
* is
Author: caseycarter
Date: Sun Jul 9 10:15:49 2017
New Revision: 307505
URL: http://llvm.org/viewvc/llvm-project?rev=307505&view=rev
Log:
optional: Implement LWG 2900 and P0602
Differential Revision: https://reviews.llvm.org/D32385
Removed:
libcxx/trunk/test/libcxx/utilities/optional/option
Author: caseycarter
Date: Tue Jun 6 19:06:04 2017
New Revision: 304847
URL: http://llvm.org/viewvc/llvm-project?rev=304847&view=rev
Log:
[test] Test changes to accommodate LWG 2904 "Make variant move-assignment more
exception safe"
Also: Move constexpr / triviality extension tests into the std
Author: caseycarter
Date: Tue Jun 6 13:47:26 2017
New Revision: 304813
URL: http://llvm.org/viewvc/llvm-project?rev=304813&view=rev
Log:
add missing constexpr to optional::value_or
[Credit to cpplearner]
Differential Revision: https://reviews.llvm.org/D27850
Modified:
libcxx/trunk/include/
Author: caseycarter
Date: Mon Jun 5 14:59:17 2017
New Revision: 304730
URL: http://llvm.org/viewvc/llvm-project?rev=304730&view=rev
Log:
[test] Remove workaround for C1XX empty parameter pack bug
Was VSO#109062. This bug was filed *4 years ago*. I submitted a workaround to
enable the scoped_all
Author: caseycarter
Date: Thu Jun 1 17:40:16 2017
New Revision: 304487
URL: http://llvm.org/viewvc/llvm-project?rev=304487&view=rev
Log:
[test] Allow non-libc++ coroutine_handle::done to strengthen noexcept
Modified:
libcxx/trunk/test/std/experimental/language.support/support.coroutines/cor
Author: caseycarter
Date: Tue May 30 15:12:55 2017
New Revision: 304236
URL: http://llvm.org/viewvc/llvm-project?rev=304236&view=rev
Log:
[test] s/uexpectedly/unexpectedly/
Modified:
libcxx/trunk/test/support/test_macros.h
Modified: libcxx/trunk/test/support/test_macros.h
URL:
http://llvm.o
Author: caseycarter
Date: Thu May 25 20:00:56 2017
New Revision: 303951
URL: http://llvm.org/viewvc/llvm-project?rev=303951&view=rev
Log:
[test] Fix breakage from r303947 =(
Modified:
libcxx/trunk/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.create/make_s
Author: caseycarter
Date: Thu May 25 19:37:33 2017
New Revision: 303947
URL: http://llvm.org/viewvc/llvm-project?rev=303947&view=rev
Log:
[test] make_shared(...) is, uh, libc++-specific
Modified:
libcxx/trunk/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.c
Author: caseycarter
Date: Thu May 25 12:42:21 2017
New Revision: 303889
URL: http://llvm.org/viewvc/llvm-project?rev=303889&view=rev
Log:
[test] Remove workaround for C1XX conversion-to-nullptr bug
VSO#391542 "Types can't be convertible to nullptr_t"
Also put internal bug numbers on the workarou
Author: caseycarter
Date: Thu May 25 12:42:17 2017
New Revision: 303888
URL: http://llvm.org/viewvc/llvm-project?rev=303888&view=rev
Log:
[test] Workaround C1XX bug in uses_allocator_types.hpp
VSO#109062 "Explicit template argument specification with empty template
parameter pack expansion does
Author: caseycarter
Date: Fri May 12 15:33:32 2017
New Revision: 302944
URL: http://llvm.org/viewvc/llvm-project?rev=302944&view=rev
Log:
[test] Avoid P0138R2, direct-list-init of fixed enums from integers, part 1/3.
This C++17 Core Language feature isn't necessary when testing std::byte.
It's a
Author: caseycarter
Date: Fri May 12 15:33:46 2017
New Revision: 302946
URL: http://llvm.org/viewvc/llvm-project?rev=302946&view=rev
Log:
[test] Add specific test for P0138R2, direct-list-init of fixed enums from
integers, part 3/3.
Test the C++17 Core Language feature independently from other s
Author: caseycarter
Date: Fri May 12 15:33:41 2017
New Revision: 302945
URL: http://llvm.org/viewvc/llvm-project?rev=302945&view=rev
Log:
[test] Avoid P0138R2, direct-list-init of fixed enums from integers, part 2/3.
This C++17 Core Language feature isn't necessary when testing std::byte.
It's a
Author: caseycarter
Date: Wed May 10 14:10:49 2017
New Revision: 302707
URL: http://llvm.org/viewvc/llvm-project?rev=302707&view=rev
Log:
[test] support machinery changes for EDG & C1XX /Za
This change works around a couple of bugs:
1. EDG doesn't like explicit constexpr in a derived class. This
Author: caseycarter
Date: Thu May 4 10:54:09 2017
New Revision: 302162
URL: http://llvm.org/viewvc/llvm-project?rev=302162&view=rev
Log:
[test] Name the local variable in the C1XX implementation of DoNotOptmize
Differential Revision: https://reviews.llvm.org/D32510
Modified:
libcxx/trunk/te
Author: caseycarter
Date: Thu May 4 10:32:54 2017
New Revision: 302158
URL: http://llvm.org/viewvc/llvm-project?rev=302158&view=rev
Log:
[test] variant: enable constexpr construction tests on MSVC STL
* Add a new macro _MSVC_STL_VER to detect when the MSVC STL is being tested
* Workaround C1XX _
Author: caseycarter
Date: Fri Apr 21 17:38:59 2017
New Revision: 301055
URL: http://llvm.org/viewvc/llvm-project?rev=301055&view=rev
Log:
Expand test coverage for LWG2857
* Cover optional's emplace-from-initializer_list overload
* Verify that any::emplace and optional::emplace return a reference
Author: caseycarter
Date: Tue Apr 18 15:04:39 2017
New Revision: 300581
URL: http://llvm.org/viewvc/llvm-project?rev=300581&view=rev
Log:
[test] Silence another unused-typedef warning
Modified:
libcxx/trunk/test/std/utilities/smartptr/unique.ptr/unique.ptr.class/unique.ptr.asgn/move_convert.
Author: caseycarter
Date: Tue Apr 18 13:44:33 2017
New Revision: 300575
URL: http://llvm.org/viewvc/llvm-project?rev=300575&view=rev
Log:
[test] Silence unused parameter/typedef warnings
Modified:
libcxx/trunk/test/std/language.support/support.exception/except.nested/throw_with_nested.pass.c
Author: caseycarter
Date: Mon Apr 17 15:15:16 2017
New Revision: 300488
URL: http://llvm.org/viewvc/llvm-project?rev=300488&view=rev
Log:
[optional] Update synopsis for LWG2934
(comment-only change)
Modified:
libcxx/trunk/include/optional
libcxx/trunk/test/std/utilities/optional/optional
Author: caseycarter
Date: Mon Dec 5 20:28:19 2016
New Revision: 288760
URL: http://llvm.org/viewvc/llvm-project?rev=288760&view=rev
Log:
std::get<0>([std::variant constant expression]) *is* noexcept.
Differential review: http://reviews.llvm.org/D27436
Modified:
libcxx/trunk/test/std/utiliti
Author: caseycarter
Date: Tue Nov 22 19:44:53 2016
New Revision: 287732
URL: http://llvm.org/viewvc/llvm-project?rev=287732&view=rev
Log:
Don't "LIBCPP_ONLY(stuff;)" at namespace scope.
Differential review: https://reviews.llvm.org/D27029
Modified:
libcxx/trunk/test/std/utilities/variant/va
CaseyCarter created this revision.
CaseyCarter added reviewers: EricWF, mclow.lists.
CaseyCarter added a subscriber: cfe-commits.
`LIBCPP_ONLY(foo;)` at namespace scope is bad, and it should feel bad.
https://reviews.llvm.org/D27029
Files:
test/std/utilities/variant/variant.variant/variant.sw
CaseyCarter added inline comments.
Comment at:
test/std/utilities/variant/variant.helpers/variant_alternative.pass.cpp:33
+void test() {
+static_assert(std::is_same_v<
+typename std::variant_alternative::type, E>, "");
STL_MSFT wrote:
> EricWF wrote:
CaseyCarter added a comment.
Other than the note in variant.variant\variant.swap\swap.pass.cpp, all passes
pass and all fails fail with out implementation.
Comment at:
test/std/utilities/variant/variant.variant/variant.swap/swap.pass.cpp:487
+// This is why variant should SFI
CaseyCarter added inline comments.
Comment at: test/std/utilities/variant/variant.hash/hash.pass.cpp:34
+
+void test_hash_variant()
+{
This is non-portable. The fact that both your implementation and mine pass this
test suggests they both have poor QoI: There's
CaseyCarter added inline comments.
Comment at: test/std/utilities/variant/variant.relops/relops.pass.cpp:60
+inline bool operator>(MakeEmptyT const&, MakeEmptyT const&) { assert(false); }
+inline bool operator>=(MakeEmptyT const&, MakeEmptyT const&) { assert(false); }
+
CaseyCarter added a comment.
I'll take a look at these tomorrow; I don't have easy access to my
implementation with the changes from P0510 and P0504 from home (it's waiting on
a compiler bugfix to checkin).
Comment at: test/std/utilities/variant/variant.get/get_type.pass.cpp:
CaseyCarter updated this revision to Diff 78379.
CaseyCarter marked an inline comment as done.
CaseyCarter added a comment.
Don't `STATIC_ASSERT`; `static_assert`.
https://reviews.llvm.org/D26782
Files:
test/std/utilities/any/any.class/any.cons/in_place_type.pass.cpp
test/std/utilities/any/
CaseyCarter marked an inline comment as done.
CaseyCarter added a comment.
> Do these tests pass with the current `` implementation, or will they
> have to wait?
These tests **do not pass** without making the changes required in P0504R0 to
`` and ``. (Interestingly is unaffected; its use of
CaseyCarter updated this revision to Diff 78311.
CaseyCarter added a comment.
Remove unused reference variable in any_cast_reference.pass.cpp.
https://reviews.llvm.org/D26782
Files:
test/std/utilities/any/any.class/any.cons/in_place_type.pass.cpp
test/std/utilities/any/any.class/any.cons/va
CaseyCarter created this revision.
CaseyCarter added reviewers: mclow.lists, EricWF.
CaseyCarter added a subscriber: cfe-commits.
Note that this does not implement the product code changes to and
, this is only the necessary changes to accompanying test code.
https://reviews.llvm.org/D26782
F
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285234: Cleanup nonportable behavior in tests for std::any
(authored by CaseyCarter).
Changed prior to commit:
https://reviews.llvm.org/D26007?vs=75936&id=75938#toc
Repository:
rL LLVM
https://revie
Author: caseycarter
Date: Wed Oct 26 15:18:13 2016
New Revision: 285234
URL: http://llvm.org/viewvc/llvm-project?rev=285234&view=rev
Log:
Cleanup nonportable behavior in tests for std::any
Fixes MS issues 63, 64, and 65.
test/std/utilities/any/any.class/any.cons/move.pass.cpp:
* "Moves are alway
CaseyCarter marked 2 inline comments as done.
CaseyCarter added a comment.
DecayTag destroyed.
https://reviews.llvm.org/D26007
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
CaseyCarter removed rL LLVM as the repository for this revision.
CaseyCarter updated this revision to Diff 75936.
CaseyCarter added a comment.
Cleanup nonportable behavior in tests for `std::any`
Fixes MS issues 63, 64, and 65.
test/std/utilities/any/any.class/any.cons/move.pass.cpp:
- "Moves a
CaseyCarter added inline comments.
Comment at: test/libcxx/utilities/any/any.class/any.cons/value.pass.cpp:36
+using DecayTag = std::decay_t;
+static_assert(!std::is_constructible::value, "");
+}
I'm generously calling this a "libc++ extension." From my i
CaseyCarter created this revision.
CaseyCarter added reviewers: EricWF, mclow.lists.
CaseyCarter added a subscriber: cfe-commits.
CaseyCarter set the repository for this revision to rL LLVM.
Cleanup nonportable behavior in tests for `std::any`
Fixes MS issues 63, 64, and 65.
test/std/utilities/a
CaseyCarter closed this revision.
CaseyCarter added a comment.
Committed as r285213.
https://reviews.llvm.org/D25958
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: caseycarter
Date: Wed Oct 26 12:22:25 2016
New Revision: 285213
URL: http://llvm.org/viewvc/llvm-project?rev=285213&view=rev
Log:
Silence unused parameter warnings in archetypes.hpp
Reviewed at: https://reviews.llvm.org/D25958
Modified:
libcxx/trunk/test/support/archetypes.hpp
Modif
CaseyCarter created this revision.
CaseyCarter added reviewers: EricWF, mclow.lists.
CaseyCarter added a subscriber: cfe-commits.
Fairly straightforward: simply removes the parameter names from the unused
parameters.
https://reviews.llvm.org/D25958
Files:
test/support/archetypes.hpp
Index:
CaseyCarter abandoned this revision.
CaseyCarter added a comment.
Ignoring the assignment from in_place_t issue for now, r283606 is good modulo a
couple of tiny things that I'll just email you directly.
https://reviews.llvm.org/D25249
___
cfe-commi
CaseyCarter added a comment.
I'll push a revision with the whitespace changes reverted soon.
> .gitignore:59
> keep.lst
> +.vscode/
This is an editor byproduct, I suppose, not "MSVC libraries test harness". Let
me know if anyone cares and I'll add a comment.
> any:553
> +__tmp._
CaseyCarter updated this revision to Diff 73538.
CaseyCarter added a comment.
Fix inadvertent whitespace changes.
https://reviews.llvm.org/D25249
Files:
.gitignore
include/any
test/libcxx/utilities/any/any.class/any.assign/value.pass.cpp
test/libcxx/utilities/any/any.class/any.cons/valu
CaseyCarter created this revision.
CaseyCarter added reviewers: EricWF, mclow.lists.
CaseyCarter added a subscriber: cfe-commits.
Changes to non-portable behavior in tests. Inline detailed description of
each change is forthcoming. Changes are almost entirely in test code, with one
behavioral c
64 matches
Mail list logo
