https://github.com/ideasman42 commented:
Works well on Linux, generally seems fine although I still think it's worth
considering splitting out "getting-changes" into a separate shared code-base to
avoid dealing with details of calling diff for different version control system
here.
https://gi
@@ -146,18 +146,125 @@ is a zero-based file offset, assuming ‘utf-8-unix’
coding."
(lambda (byte &optional _quality _coding-system)
(byte-to-position (1+ byte)
-;;;###autoload
-(defun clang-format-region (start end &optional style assume-file-name)
- "Use clang
https://github.com/ideasman42 edited
https://github.com/llvm/llvm-project/pull/112792
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ideasman42 edited
https://github.com/llvm/llvm-project/pull/112792
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -146,18 +146,125 @@ is a zero-based file offset, assuming ‘utf-8-unix’
coding."
(lambda (byte &optional _quality _coding-system)
(byte-to-position (1+ byte)
-;;;###autoload
-(defun clang-format-region (start end &optional style assume-file-name)
- "Use clang
@@ -216,17 +327,72 @@ uses the function `buffer-file-name'."
(if incomplete-format
(message "(clang-format: incomplete (syntax errors)%s)" stderr)
(message "(clang-format: success%s)" stderr
- (delete-file temp-file)
+ (ig
ideasman42 wrote:
Checking again and am still considering this patch too spesific/incomplete,
checking vc's diff calls to git - they are considerably more involved than in
this PR, meaning this PR will likely require follow up commits to fix problems
_(see `vc-diff-internal`, inlined below for
ideasman42 wrote:
> All things considered, I think requiring `vc` is a lot less intrusive than
> essentially our own `vc` wrapper
Not sure what you mean exactly by a wrapper, if git/diff logic can be
abstracted away - that seems a net gain.
If ugly/fragile logic is required to do that - OK
ideasman42 wrote:
> I don't disagree these are all potential pitfalls (and there are certainly
> more), I just don't see how having the diff code in a separate project
> ameliorates any of them. And as stated earlier, I think it in fact
> complicates them.
>From a user perspective it likely j
ideasman42 wrote:
> So IIUC, you are proposing a create an entirely seperate project for
> "vc-diff-lines" or something like that then making that a dependency for for
> `clang-format`? Is that correct?
I would not depend on it - instead, it would be loosely coupled - if
`clang-format-vc-diff
ideasman42 wrote:
_Suggesting a fairly large change to this PR, although it's quite opinionated._
If I were maintaining `clang-format.el` I'd split out the logic for generating
a list of changes into it's own package.
Exactly how this is done is not be so important... it could for example supp
https://github.com/ideasman42 edited
https://github.com/llvm/llvm-project/pull/112792
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ideasman42 edited
https://github.com/llvm/llvm-project/pull/112792
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -146,18 +146,124 @@ is a zero-based file offset, assuming ‘utf-8-unix’
coding."
(lambda (byte &optional _quality _coding-system)
(byte-to-position (1+ byte)
-;;;###autoload
-(defun clang-format-region (start end &optional style assume-file-name)
- "Use clang
https://github.com/ideasman42 edited
https://github.com/llvm/llvm-project/pull/112792
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -146,18 +146,124 @@ is a zero-based file offset, assuming ‘utf-8-unix’
coding."
(lambda (byte &optional _quality _coding-system)
(byte-to-position (1+ byte)
-;;;###autoload
-(defun clang-format-region (start end &optional style assume-file-name)
- "Use clang
https://github.com/ideasman42 edited
https://github.com/llvm/llvm-project/pull/112792
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -206,20 +191,30 @@ which can be passed directly to ‘clang-format’."
((= status 0) nil)
;; Return of 1 indicates found diffs and no error.
((= status 1)
-;; Iterate through all lines in diff buffer and collect all
-;; lines in current buff
@@ -146,18 +146,104 @@ is a zero-based file offset, assuming ‘utf-8-unix’
coding."
(lambda (byte &optional _quality _coding-system)
(byte-to-position (1+ byte)
-;;;###autoload
-(defun clang-format-region (start end &optional style assume-file-name)
- "Use clang
https://github.com/ideasman42 edited
https://github.com/llvm/llvm-project/pull/112792
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -312,15 +335,35 @@ diffs from HEAD in the buffer. If no STYLE is given uses
file. If no ASSUME-FILE-NAME is given uses the function
‘buffer-file-name’."
(interactive)
- (let ((diff-lines (clang-format--vc-diff-get-diff-lines)))
-;; If we have any diffs, format them.
-
https://github.com/ideasman42 edited
https://github.com/llvm/llvm-project/pull/112792
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ideasman42 edited
https://github.com/llvm/llvm-project/pull/112792
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ideasman42 edited
https://github.com/llvm/llvm-project/pull/112792
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ideasman42 edited
https://github.com/llvm/llvm-project/pull/112792
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ideasman42 edited
https://github.com/llvm/llvm-project/pull/112792
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ideasman42 edited
https://github.com/llvm/llvm-project/pull/112792
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -146,18 +146,115 @@ is a zero-based file offset, assuming ‘utf-8-unix’
coding."
(lambda (byte &optional _quality _coding-system)
(byte-to-position (1+ byte)
-;;;###autoload
-(defun clang-format-region (start end &optional style assume-file-name)
- "Use clang
https://github.com/ideasman42 edited
https://github.com/llvm/llvm-project/pull/112792
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ideasman42 edited
https://github.com/llvm/llvm-project/pull/112792
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ideasman42 edited
https://github.com/llvm/llvm-project/pull/112792
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ideasman42 edited
https://github.com/llvm/llvm-project/pull/112792
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ideasman42 edited
https://github.com/llvm/llvm-project/pull/112792
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -146,18 +146,118 @@ is a zero-based file offset, assuming ‘utf-8-unix’
coding."
(lambda (byte &optional _quality _coding-system)
(byte-to-position (1+ byte)
-;;;###autoload
-(defun clang-format-region (start end &optional style assume-file-name)
- "Use clang
@@ -146,18 +146,115 @@ is a zero-based file offset, assuming ‘utf-8-unix’
coding."
(lambda (byte &optional _quality _coding-system)
(byte-to-position (1+ byte)
-;;;###autoload
-(defun clang-format-region (start end &optional style assume-file-name)
- "Use clang
https://github.com/ideasman42 edited
https://github.com/llvm/llvm-project/pull/112792
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -146,18 +146,115 @@ is a zero-based file offset, assuming ‘utf-8-unix’
coding."
(lambda (byte &optional _quality _coding-system)
(byte-to-position (1+ byte)
-;;;###autoload
-(defun clang-format-region (start end &optional style assume-file-name)
- "Use clang
@@ -146,18 +146,115 @@ is a zero-based file offset, assuming ‘utf-8-unix’
coding."
(lambda (byte &optional _quality _coding-system)
(byte-to-position (1+ byte)
-;;;###autoload
-(defun clang-format-region (start end &optional style assume-file-name)
- "Use clang
https://github.com/ideasman42 requested changes to this pull request.
This seems more ore less OK, although
https://github.com/llvm/llvm-project/pull/112792
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman
@@ -146,18 +146,115 @@ is a zero-based file offset, assuming ‘utf-8-unix’
coding."
(lambda (byte &optional _quality _coding-system)
(byte-to-position (1+ byte)
-;;;###autoload
-(defun clang-format-region (start end &optional style assume-file-name)
- "Use clang
https://github.com/ideasman42 edited
https://github.com/llvm/llvm-project/pull/112792
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -146,18 +146,115 @@ is a zero-based file offset, assuming ‘utf-8-unix’
coding."
(lambda (byte &optional _quality _coding-system)
(byte-to-position (1+ byte)
-;;;###autoload
-(defun clang-format-region (start end &optional style assume-file-name)
- "Use clang
https://github.com/ideasman42 edited
https://github.com/llvm/llvm-project/pull/112792
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ideasman42 edited
https://github.com/llvm/llvm-project/pull/112792
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -205,14 +288,60 @@ uses the function `buffer-file-name'."
(delete-file temp-file)
(when (buffer-name temp-buffer) (kill-buffer temp-buffer)
+;;;###autoload
+(defun clang-format-git-diffs (&optional style assume-file-name)
ideasman42 wrote:
@@ -205,14 +288,60 @@ uses the function `buffer-file-name'."
(delete-file temp-file)
(when (buffer-name temp-buffer) (kill-buffer temp-buffer)
+;;;###autoload
+(defun clang-format-git-diffs (&optional style assume-file-name)
+ "The same as 'clang-format-buffer
https://github.com/ideasman42 edited
https://github.com/llvm/llvm-project/pull/112792
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ideasman42 edited
https://github.com/llvm/llvm-project/pull/112792
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ideasman42 edited
https://github.com/llvm/llvm-project/pull/112792
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ideasman42 edited
https://github.com/llvm/llvm-project/pull/112792
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ideasman42 requested changes to this pull request.
Note that I'm not a regular clang contributor, I just submitted a small
improvement to clang-format, and maintain some emacs packages in elpa & melpa.
Overall the PR looks like it needs more attention to detail, as far
@@ -132,18 +132,97 @@ is a zero-based file offset, assuming ‘utf-8-unix’
coding."
(lambda (byte &optional _quality _coding-system)
(byte-to-position (1+ byte)
-;;;###autoload
-(defun clang-format-region (start end &optional style assume-file-name)
- "Use clang-
@@ -132,18 +132,97 @@ is a zero-based file offset, assuming ‘utf-8-unix’
coding."
(lambda (byte &optional _quality _coding-system)
(byte-to-position (1+ byte)
-;;;###autoload
-(defun clang-format-region (start end &optional style assume-file-name)
- "Use clang-
@@ -132,18 +132,97 @@ is a zero-based file offset, assuming ‘utf-8-unix’
coding."
(lambda (byte &optional _quality _coding-system)
(byte-to-position (1+ byte)
-;;;###autoload
-(defun clang-format-region (start end &optional style assume-file-name)
- "Use clang-
@@ -132,18 +132,97 @@ is a zero-based file offset, assuming ‘utf-8-unix’
coding."
(lambda (byte &optional _quality _coding-system)
(byte-to-position (1+ byte)
-;;;###autoload
-(defun clang-format-region (start end &optional style assume-file-name)
- "Use clang-
@@ -132,18 +132,97 @@ is a zero-based file offset, assuming ‘utf-8-unix’
coding."
(lambda (byte &optional _quality _coding-system)
(byte-to-position (1+ byte)
-;;;###autoload
-(defun clang-format-region (start end &optional style assume-file-name)
- "Use clang-
ideasman42 wrote:
@mydeveloperday bump, it'd be nice to get this merged if there are no problems
with the PR.
https://github.com/llvm/llvm-project/pull/104533
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
ideasman42 wrote:
Is there any action needed on my side? (the PR was approved over a week ago).
https://github.com/llvm/llvm-project/pull/104533
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
https://github.com/ideasman42 updated
https://github.com/llvm/llvm-project/pull/104533
>From d53cf4f059cacadbbb6e32349a26580e7ea1a55b Mon Sep 17 00:00:00 2001
From: Campbell Barton
Date: Fri, 16 Aug 2024 11:28:19 +1000
Subject: [PATCH 1/3] Add "clang-format-on-save-mode" minor mode to
clang-fo
ideasman42 wrote:
> I'm not an emacs user and I'm unsure if the other maintainers are. If you are
> happy to address any issues that might arise I'd be happy for this to land.
Yes, I'm happy to resolve any issues - for some context, I've been using a
version of this for some years.
Originally
https://github.com/ideasman42 updated
https://github.com/llvm/llvm-project/pull/104533
>From d53cf4f059cacadbbb6e32349a26580e7ea1a55b Mon Sep 17 00:00:00 2001
From: Campbell Barton
Date: Fri, 16 Aug 2024 11:28:19 +1000
Subject: [PATCH 1/2] Add "clang-format-on-save-mode" minor mode to
clang-fo
https://github.com/ideasman42 edited
https://github.com/llvm/llvm-project/pull/104533
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ideasman42 created
https://github.com/llvm/llvm-project/pull/104533
Add a minor mode to run clang-format on save.
Formatting before saving works well and is convenient to avoid having to
remember to manually run clang format.
I've written this as it's own package but it's p
63 matches
Mail list logo
