[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

csmulhern added a comment. In D109557#3247167 , @HazardyKnusperkeks wrote: > Could you please rebase the patch? I promise I will commit it **very** > shortly afterwards. Done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

csmulhern updated this revision to Diff 400435. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst clang/include/clang/Format/For

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

csmulhern added a comment. Is there anything outstanding you'd like me to address, or can we move ahead with committing this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557 _

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

csmulhern marked an inline comment as done. csmulhern added a comment. I don't have commit access, so please submit this change on my behalf. Thanks for all your help on landing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

csmulhern marked 4 inline comments as done. csmulhern added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:951 + if (PreviousNonComment && PreviousNonComment->is(tok::l_paren)) { +State.Stack.back().BreakBeforeClosingParen = owenpan

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

csmulhern updated this revision to Diff 387025. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst clang/include/clang/Format/For

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

csmulhern added a comment. Any further feedback on the latest iteration? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557 ___ cfe-commits mailing list cfe-commit

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

csmulhern updated this revision to Diff 381974. csmulhern marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/Relea

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

csmulhern updated this revision to Diff 381765. csmulhern added a comment. Absent feedback, I have gone ahead and added a BlockIndent option to AlignAfterOpenBracket. Please take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ h

[PATCH] D109557: Adds a BreakBeforeClosingParen option

csmulhern added a comment. In D109557#3063679 , @MyDeveloperDay wrote: > Do you think this is going to need some other capability to put the break > after the opening paren? e.g. `BreakAfterOpeningParen` > > if ( > ^ I don't think so. This is

[PATCH] D109557: Adds a BreakBeforeClosingParen option

csmulhern added a comment. In D109557#3063563 , @MyDeveloperDay wrote: >> The you quoted would, in my mind, be formatted like this: >> >> void foo() { >> if ( >> quitelongarg != (alsolongarg - 1) >> ) { // ABC is a very longgg

[PATCH] D109557: Adds a BreakBeforeClosingParen option

csmulhern added a comment. In D109557#3019847 , @MyDeveloperDay wrote: > We would need your name and email address to commit this for you in the form > git commit --amend --author="John Doe " > > See https://llvm.org/docs/DeveloperPolicy.html Sure, it'

[PATCH] D109557: Adds a BreakBeforeClosingParen option

csmulhern added a comment. In D109557#3011516 , @MyDeveloperDay wrote: > This seems ok, might be worth adding a release note Done. I don't have commit access, so please submit this change on my behalf. Thanks for all the help! Repository: rG LLVM

[PATCH] D109557: Adds a BreakBeforeClosingParen option

csmulhern updated this revision to Diff 373877. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst clang/include/clang/Format/For

[PATCH] D109557: Adds a BreakBeforeClosingParen option

csmulhern marked an inline comment as done. csmulhern added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:22414 + + EXPECT_EQ("int a = (int)b;", format("int a = (\n" + "int\n" csmulhern wrote: > MyDev

[PATCH] D109557: Adds a BreakBeforeClosingParen option

csmulhern updated this revision to Diff 373711. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/Format/Conti

[PATCH] D109557: Adds a BreakBeforeClosingParen option

csmulhern marked an inline comment as done. csmulhern added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:22414 + + EXPECT_EQ("int a = (int)b;", format("int a = (\n" + "int\n" MyDeveloperDay wrote: >

[PATCH] D109557: Adds a BreakBeforeClosingParen option

csmulhern marked an inline comment as done. csmulhern added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:22410 + ");", + Style); +} MyDeveloperDay wrote: > Can you assert the cases it won't do (given your descript

[PATCH] D109557: Adds a BreakBeforeClosingParen option

csmulhern updated this revision to Diff 372979. csmulhern marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/cl

[PATCH] D109557: Adds a BreakBeforeClosingParen option

csmulhern marked an inline comment as done. csmulhern added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:22301 + auto Style = getLLVMStyle(); + Style.BreakBeforeClosingParen = true; + HazardyKnusperkeks wrote: > Could you also add tests fo

[PATCH] D109557: Adds a BreakBeforeClosingParen option

csmulhern updated this revision to Diff 372829. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/Format/Conti

[PATCH] D109557: Adds a BreakBeforeClosingParen option

csmulhern added a comment. In D109557#3000152 , @HazardyKnusperkeks wrote: > I haven't looked too much into it, my main point is that there should be > tests for both variants of that option for braces, parenthesis, and angular > braces, if they are ha

[PATCH] D109557: Adds a BreakBeforeClosingParen option

csmulhern updated this revision to Diff 372748. csmulhern retitled this revision from "Adds an AlignCloseBracket option" to "Adds a BreakBeforeClosingParen option". csmulhern edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D109557: Adds an AlignCloseBracket option

csmulhern added a comment. In D109557#2998213 , @HazardyKnusperkeks wrote: > With context he meant the diff context. > https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface Ah sorry about that. Done. In D109557#2998226

[PATCH] D109557: Adds an AlignCloseBracket option

csmulhern updated this revision to Diff 372364. csmulhern added a comment. Adds more context to the diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D109557: Adds an AlignCloseBracket option

csmulhern added a comment. I've added more information to my original message. Please let me know if further context is desired. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557 __

[PATCH] D109557: Adds an AlignCloseBracket option

csmulhern created this revision. csmulhern added a reviewer: MyDeveloperDay. csmulhern requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This style can be used to control the alignment of closing brackets. For prior work on a similar feature