[PATCH] D94950: [clang][lex] Speculative fix for buffer overrun on raw string parse

2021-02-23 Thread Brent Royal-Gordon via Phabricator via cfe-commits
brentdax added inline comments. Comment at: clang/lib/Lex/LiteralSupport.cpp:1639 const char *Prefix = ThisTokBuf; - while (ThisTokBuf[0] != '(') + while (ThisTokBuf - Prefix < 16 && ThisTokBuf[0] != '(') ++ThisTokBuf; Nit: "16" is a mag

[PATCH] D94950: [clang][lex] Speculative fix for buffer overrun on raw string parse

2021-02-23 Thread Brent Royal-Gordon via Phabricator via cfe-commits
brentdax accepted this revision. brentdax added a comment. This revision is now accepted and ready to land. Looks good. Thanks for implementing this! Comment at: clang/lib/Lex/LiteralSupport.cpp:1647 ThisTokEnd -= ThisTokBuf - Prefix; assert(ThisTokEnd >= ThisTokB