RE: [clang] 722c39f - [HIP] Tighten checks in hip-include-path.hip test case

2021-05-26 Thread Björn Pettersson A via cfe-commits
Having some problems to reproduce this (my build fails for some unknown reason when trying to use -DLLVM_LIBDIR_SUFFIX=64). But I made a "speculative" fix here: https://reviews.llvm.org/rGa3b3f7e631981bd861d5fe5e20f33b11a0dac978 Tom: Can you try again with an updated main branch? Or maybe let

RE: [clang] 722c39f - [HIP] Tighten checks in hip-include-path.hip test case

2021-05-26 Thread Björn Pettersson A via cfe-commits
Ok. Thanks for noticing. It was probably a bit too optimistic to match on "lib/clang" in those checks. Probably need to relax that part a bit again, while still matching on the [[ROOT]] to avoid that the test case depends on how users name their build directories. I'll have a look, and will try t

FW: [Diffusion] rC330802: Fix buildbot problems after rC330794

2018-04-25 Thread Björn Pettersson A via cfe-commits
Hello Faisal. Lots of buildbots have failed after your commit "[c++2a] [concepts] Add rudimentary parsing support for template concept declarations" (rC330794) Here is an example from http://lab.llvm.org:8011/builders/clang-x86_64-linux-abi-test/builds/25483/steps/build-unified-tree/logs/stdio

Re: r292562 - clang-format: fix fallback style set to "none" not always formatting

2017-01-21 Thread Björn Pettersson A via cfe-commits
Hello Antonio and Mikael. I've tried reproducing this also after removal of the redundant test (D28943), and I still see the fail for CHECK10. The problem is that we (both me an Mikael) are running this test from inside our llvm repo (with build&test artifacts ending up in a "build-all" direct

RE: [PATCH] D24397: Target Power9 bit counting and vector comparison instructions through builtins (front end portion)

2016-10-06 Thread Björn Pettersson A via cfe-commits
Thanks! Now I’ve been able to commit D24955. /Björn On Wed, Oct 5, 2016 at 9:18 PM, Nemanja Ivanovic mailto:nemanja.i@gmail.com>> wrote: OK, will remove optimization and the selects and commit this now. Sorry about the delay. On Wed, Oct 5, 2016 at 9:16 PM, Sanjay Patel mailto:spa...@rotate