Re: [PATCH] D16139: [MIPS] initFeatureMap() to handle empty string argument

2016-02-22 Thread Bhushan Attarde via cfe-commits
bhushan added a comment. > I'm guessing it's something to do with the 'Features[CPU] = true' line. Yes. `Features[CPU] = true` enables a feature given by CPU string. (This gets translated into "+CPU"). When CPU string is empty, this gets translated into "+" (i.e. with empty feature name). Thi

Re: [PATCH] D16139: [MIPS] initFeatureMap() to handle empty string argument

2016-02-18 Thread Bhushan Attarde via cfe-commits
bhushan added a comment. This was observed during expression evaluation in LLDB, where LLDB does not explicitly set `clang::TargetOptions::CPU` hence it remains empty. Repository: rL LLVM http://reviews.llvm.org/D16139 ___ cfe-commits mailing li

[PATCH] D16139: [MIPS] initFeatureMap() to handle empty string argument

2016-01-13 Thread Bhushan Attarde via cfe-commits
bhushan created this revision. bhushan added a reviewer: dsanders. bhushan added subscribers: cfe-commits, jaydeep, mohit.bhakkad, nitesh.jain, sagar. bhushan set the repository for this revision to rL LLVM. Herald added a reviewer: vkalintiris. This patch sets CPU string to its default value whe