betulb added a comment.
Committed as r265037.
Repository:
rL LLVM
http://reviews.llvm.org/D18636
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: betulb
Date: Thu Mar 31 13:41:34 2016
New Revision: 265037
URL: http://llvm.org/viewvc/llvm-project?rev=265037&view=rev
Log:
[PGO] Avoid instrumenting constants at value sites
Value profiling should not profile constants and/or constant
expressions when they appear as callees in call inst
betulb removed rL LLVM as the repository for this revision.
betulb updated this revision to Diff 52249.
betulb added a comment.
Addressed review comments.
http://reviews.llvm.org/D18636
Files:
lib/CodeGen/CodeGenPGO.cpp
test/Profile/c-avoid-direct-call.c
Index: test/Profile/c-avoid-direct-
betulb added inline comments.
Comment at: lib/CodeGen/CodeGenPGO.cpp:758
@@ -757,1 +757,3 @@
+ if (dyn_cast(ValuePtr))
+return;
davidxl wrote:
> Is it the bitcast guaranteed to be already stripped here?
No. ConstantExpr is derived from the Constant class. A
betulb created this revision.
betulb added reviewers: davidxl, bogner.
betulb added subscribers: llvm-commits, cfe-commits.
betulb set the repository for this revision to rL LLVM.
betulb changed the visibility of this Differential Revision from "Public (No
Login Required)" to "All Users".
Value p
--
On Tue, Mar 29, 2016 at 1:44 PM, Betul Buyukkurt via cfe-commits
mailto:cfe-commits@lists.llvm.org> > wrote:
Author: betulb
Date: Tue Mar 29 15:44:09 2016
New Revision: 264783
URL: http://llvm.org/viewvc/llvm-project?rev=264783
<http://llvm.org/viewvc/llvm-project?rev=264783&
Author: betulb
Date: Tue Mar 29 17:17:52 2016
New Revision: 264795
URL: http://llvm.org/viewvc/llvm-project?rev=264795&view=rev
Log:
[PGO] Test case fix for r264783
Modified:
cfe/trunk/test/Profile/cxx-indirect-call.cpp
Modified: cfe/trunk/test/Profile/cxx-indirect-call.cpp
URL:
http://ll
Author: betulb
Date: Tue Mar 29 15:44:09 2016
New Revision: 264783
URL: http://llvm.org/viewvc/llvm-project?rev=264783&view=rev
Log:
[PGO] Move the instrumentation point closer to the value site.
For terminator instructions, the value profiling instrumentation
happens in a basic block other than
http://reviews.llvm.org/rL258652 should fix the issue. Please let me know if
you continue to see failures.
-Betul
-Original Message-
From: Oleksiy Vyalov [mailto:ovya...@google.com]
Sent: Saturday, January 23, 2016 5:10 PM
To: bet...@codeaurora.org; m...@justinbogner.com; dnovi...@googl
Author: betulb
Date: Sat Jan 23 18:56:19 2016
New Revision: 258652
URL: http://llvm.org/viewvc/llvm-project?rev=258652&view=rev
Log:
[PGO] Windows buildbot failure fix. [NFC]
Modified:
cfe/trunk/lib/CodeGen/CodeGenPGO.h
Modified: cfe/trunk/lib/CodeGen/CodeGenPGO.h
URL:
http://llvm.org/view
betulb added a comment.
Committed in revision 258650.
Repository:
rL LLVM
http://reviews.llvm.org/D8940
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258650: Clang changes for value profiling (authored by
betulb).
Changed prior to commit:
http://reviews.llvm.org/D8940?vs=45550&id=45813#toc
Repository:
rL LLVM
http://reviews.llvm.org/D8940
Files:
Author: betulb
Date: Sat Jan 23 16:50:44 2016
New Revision: 258650
URL: http://llvm.org/viewvc/llvm-project?rev=258650&view=rev
Log:
Clang changes for value profiling
Differential Revision: http://reviews.llvm.org/D8940
Added:
cfe/trunk/test/Profile/c-indirect-call.c
Modified:
cfe/trunk
betulb marked 3 inline comments as done.
Comment at: lib/CodeGen/CodeGenPGO.cpp:768
@@ +767,3 @@
+};
+Builder.CreateCall(
+CGM.getIntrinsic(llvm::Intrinsic::instrprof_value_profile), Args);
I removed the if check instead. It was not needed since th
betulb updated this revision to Diff 45550.
betulb added a comment.
In this revision:
- Clang no longer attaches function names as metadata.
- Bug fixed in checking the getNumValueSites return value.
- Addressed review comments.
http://reviews.llvm.org/D8940
Files:
lib/CodeGen/CGCall.cpp
l
betulb added a comment.
ping?
http://reviews.llvm.org/D8940
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
betulb updated this revision to Diff 44657.
betulb added a comment.
Addressed vsk's comment on CallSite API use.
http://reviews.llvm.org/D8940
Files:
lib/CodeGen/CGCall.cpp
lib/CodeGen/CodeGenPGO.cpp
lib/CodeGen/CodeGenPGO.h
test/Profile/c-indirect-call.c
Index: test/Profile/c-indirect
betulb updated the summary for this revision.
betulb edited reviewers, added: xur; removed: dsule, bob.wilson.
betulb updated this revision to Diff 44386.
betulb added a comment.
This CL adds in the changes necessary for instrumenting and profile
metadata-attaching at clang level for value profi
betulb added a comment.
No it's not. I need to replace the API's w/ the recent ones for retrieving the
value profile data and add the flag definition for -fprofile-values.
This was off the radar due to other commitments. I'll get back to this
beginning of this week.
-Betul
http://reviews.llvm
Author: betulb
Date: Wed Nov 18 12:15:55 2015
New Revision: 253485
URL: http://llvm.org/viewvc/llvm-project?rev=253485&view=rev
Log:
[PGO] Test update for revision 253484.
Modified:
cfe/trunk/test/Profile/c-linkage-available_externally.c
Modified: cfe/trunk/test/Profile/c-linkage-available_
Author: betulb
Date: Tue Nov 17 18:14:08 2015
New Revision: 253404
URL: http://llvm.org/viewvc/llvm-project?rev=253404&view=rev
Log:
[PGO] Removed unused code. [NFC]
Modified:
cfe/trunk/lib/CodeGen/CodeGenPGO.h
Modified: cfe/trunk/lib/CodeGen/CodeGenPGO.h
URL:
http://llvm.org/viewvc/llvm-p
21 matches
Mail list logo
