https://github.com/bnbarham closed
https://github.com/llvm/llvm-project/pull/126151
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bnbarham updated
https://github.com/llvm/llvm-project/pull/126151
>From 322959db3c22fd4053c31f4f4c2008bd726f89ce Mon Sep 17 00:00:00 2001
From: Ben Barham
Date: Thu, 6 Feb 2025 15:17:56 -0800
Subject: [PATCH] [Index] Skip adding call relations to deduction guides
Deduction g
https://github.com/bnbarham created
https://github.com/llvm/llvm-project/pull/126151
Deduction guides have no name and we already skip adding occurrences to them
for that reason. Also skip adding any relations to them.
>From 9c81463e356483a33df5b898e277649bf0a521c3 Mon Sep 17 00:00:00 2001
Fro
https://github.com/bnbarham edited
https://github.com/llvm/llvm-project/pull/97274
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2123,17 +2123,18 @@ class Preprocessor {
char
getSpellingOfSingleCharacterNumericConstant(const Token &Tok,
bnbarham wrote:
Thanks @AaronBallman!
https://github.com/llvm/llvm-project/pull/97274
___
cfe-commit
@@ -2123,17 +2123,18 @@ class Preprocessor {
char
getSpellingOfSingleCharacterNumericConstant(const Token &Tok,
bnbarham wrote:
Both the documentation and name of this function is incorrect now that the
underlying functionality has changed - would you mind
@@ -13,6 +13,7 @@ add_clang_library(clangToolingRefactoring
Rename/USRFinder.cpp
Rename/USRFindingAction.cpp
Rename/USRLocFinder.cpp
+ SymbolName.cpp
bnbarham wrote:
Should `SymbolName.cpp` live in `Rename` to match its header?
https://github.com/llvm/
https://github.com/bnbarham approved this pull request.
https://github.com/llvm/llvm-project/pull/82061
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bnbarham edited
https://github.com/llvm/llvm-project/pull/82061
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bnbarham commented:
Cool stuff @DavidGoldman! Nice to see ObjC getting some love. It's a bummer we
duplicated here, but seems like both you and @ahoppen took fairly similar
approaches. The main difference looks to be the use of `SymbolName` in the
other PR.
https://github.c
@@ -1004,6 +1004,17 @@ struct CodeActionParams {
};
bool fromJSON(const llvm::json::Value &, CodeActionParams &, llvm::json::Path);
+struct PrepareRenameResult {
+ /// The range of the string to rename.
+ Range range;
+ /// A placeholder text of the string content to be ren
https://github.com/bnbarham approved this pull request.
Nice 🥳! @sam-mccall / @HighCommander4 any thoughts/concerns?
https://github.com/llvm/llvm-project/pull/78872
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/
https://github.com/bnbarham edited
https://github.com/llvm/llvm-project/pull/78872
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bnbarham wrote:
🎉 thanks @jansvoboda11 for slogging through all these!
https://github.com/llvm/llvm-project/pull/68157
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bnbarham closed
https://github.com/llvm/llvm-project/pull/66446
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bnbarham wrote:
Friendly ping @cor3ntin / @vgvassilev 🙏
https://github.com/llvm/llvm-project/pull/66446
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bnbarham wrote:
> I have no objections to this if that makes your workflow work. However I
> think this cures the symptom and not the real cause. It might be worth
> investigating how to adapt lldb to the incremental processing change more
> deeply.
To be clear, this is re-applying
https://g
bnbarham wrote:
Any objections to this @vgvassilev?
https://github.com/llvm/llvm-project/pull/66446
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bnbarham review_requested
https://github.com/llvm/llvm-project/pull/66446
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bnbarham created
https://github.com/llvm/llvm-project/pull/66446:
Re-applies #65683 with a fix to always run
`Actions.ActOnEndOfTranslationUnit` regardless of incremental processing.
>From 9063bb14660836507ccf1b5c36256bd5f9d1d21c Mon Sep 17 00:00:00 2001
From: Ben Barham
Dat
https://github.com/bnbarham closed
https://github.com/llvm/llvm-project/pull/66281
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bnbarham wrote:
Reverting pending discussion in
https://github.com/llvm/llvm-project/pull/66271. We can add it back in there.
https://github.com/llvm/llvm-project/pull/66281
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.or
https://github.com/bnbarham review_requested
https://github.com/llvm/llvm-project/pull/66281
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bnbarham review_requested
https://github.com/llvm/llvm-project/pull/66281
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bnbarham review_requested
https://github.com/llvm/llvm-project/pull/66281
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bnbarham created
https://github.com/llvm/llvm-project/pull/66281:
This reverts commit c2fb112021529c635cccd8bb9d846b2c64fc291d, which breaks:
```
lldb-api.commands/expression/diagnostics.TestExprDiagnostics.py
lldb-api.lang/objc/modules.TestObjCModules.py
lldb-api.lang/objc/mo
https://github.com/bnbarham closed
https://github.com/llvm/llvm-project/pull/65683
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -56,7 +56,6 @@ void functionFromMacro(void) { \
typedef struct Struct_notdoxy Struct_notdoxy; \
}
-/// IS_DOXYGEN_NOT_ATTACHED
bnbarham wrote:
I think it would be worth adding another test case where we have this one and
check that it uses this
@@ -374,11 +374,10 @@ TEST(SourceCodeTest, getAssociatedRangeWithComments) {
// Does not include comments when only the decl or the comment come from a
// macro.
bnbarham wrote:
Comment isn't true any more. The comment on line 370 is also confusing to me,
@@ -167,115 +167,41 @@ static SourceLocation getDeclLocForCommentSearch(const
Decl *D,
isa(D))
return {};
+ SmallVector Locations;
// Find declaration location.
// For Objective-C declarations we generally don't expect to have multiple
// declarators, thus
@@ -592,19 +524,22 @@ void
ASTContext::attachCommentsToJustParsedDecls(ArrayRef Decls,
D = &adjustDeclToTemplate(*D);
-const SourceLocation DeclLoc = getDeclLocForCommentSearch(D, SourceMgr);
+const auto DeclLocs = getDeclLocsForCommentSearch(D, SourceMgr);
-
https://github.com/bnbarham edited
https://github.com/llvm/llvm-project/pull/65481
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bnbarham approved this pull request.
Thanks for looking into this @daniel-grumberg! LGTM except for the few small
comments.
https://github.com/llvm/llvm-project/pull/65481
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
bnbarham wrote:
> LGTM! Maybe we can cherry pick it for the patch release 17.0.1. If that’s a
> critical patch for swift we can try for the 17.0.0 release.
It's in the appropriate branches in our fork, so it's fine for us either way. I
suggested it more because of https://github.com/llvm/llvm-
bnbarham wrote:
Seems Swift wasn't the only project to run into this, eg.
https://github.com/llvm/llvm-project/issues/62413#issuecomment-1526499543.
https://github.com/llvm/llvm-project/pull/65683
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
https://github.com/bnbarham created
https://github.com/llvm/llvm-project/pull/65683:
The preprocessor `IncrementalProcessing` option was being used to control
whether or not to teardown the lexer or run the end of translation unit action.
In D127284 this was merged with `-fincremental-extensio
https://github.com/bnbarham review_requested
https://github.com/llvm/llvm-project/pull/65683
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bnbarham review_requested
https://github.com/llvm/llvm-project/pull/65683
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bnbarham review_requested
https://github.com/llvm/llvm-project/pull/65683
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bnbarham wrote:
FWIW @gribozavr the issue here is the hardcoding of the `NS_ENUM`/`NS_OPTIONS`
logic, so the idea here is to make that more generic and still handle the
comment inside macro case.
https://github.com/llvm/llvm-project/pull/65481
___
cf
bnbarham wrote:
Thanks for looking into this @daniel-grumberg!
https://github.com/llvm/llvm-project/pull/65481
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -179,103 +179,38 @@ static SourceLocation getDeclLocForCommentSearch(const
Decl *D,
isa(D) ||
// Allow association with Y across {} in `typedef struct X {} Y`.
isa(D))
-return D->getBeginLoc();
+return {D->getBeginLoc()};
bnbarham
Author: Hamish Knight
Date: 2023-06-30T16:02:12-07:00
New Revision: a57bdc8fe68753c341cac0fcecabcd4d35e45466
URL:
https://github.com/llvm/llvm-project/commit/a57bdc8fe68753c341cac0fcecabcd4d35e45466
DIFF:
https://github.com/llvm/llvm-project/commit/a57bdc8fe68753c341cac0fcecabcd4d35e45466.diff
Author: Hamish Knight
Date: 2023-06-30T09:56:42-07:00
New Revision: 62e4c22c95a9c5fbbebded43388006d5fed3b613
URL:
https://github.com/llvm/llvm-project/commit/62e4c22c95a9c5fbbebded43388006d5fed3b613
DIFF:
https://github.com/llvm/llvm-project/commit/62e4c22c95a9c5fbbebded43388006d5fed3b613.diff
Author: Ben Barham
Date: 2022-11-28T11:51:08-08:00
New Revision: 699ae92f045331b555394b8b9757d7e0fbf97100
URL:
https://github.com/llvm/llvm-project/commit/699ae92f045331b555394b8b9757d7e0fbf97100
DIFF:
https://github.com/llvm/llvm-project/commit/699ae92f045331b555394b8b9757d7e0fbf97100.diff
LO
Author: Ben Barham
Date: 2022-04-22T17:19:33-07:00
New Revision: 089b6efefc3dbfc88e8fa92673eeb63ee78e4adf
URL:
https://github.com/llvm/llvm-project/commit/089b6efefc3dbfc88e8fa92673eeb63ee78e4adf
DIFF:
https://github.com/llvm/llvm-project/commit/089b6efefc3dbfc88e8fa92673eeb63ee78e4adf.diff
LO
Author: Ben Barham
Date: 2022-04-11T14:52:48-07:00
New Revision: fe2478d44e4f7f191c43fef629ac7a23d0251e72
URL:
https://github.com/llvm/llvm-project/commit/fe2478d44e4f7f191c43fef629ac7a23d0251e72
DIFF:
https://github.com/llvm/llvm-project/commit/fe2478d44e4f7f191c43fef629ac7a23d0251e72.diff
LO
Author: Ben Barham
Date: 2022-04-05T14:24:40-07:00
New Revision: f65b0b5dcfeb04e9e6794b32a075432ce3de1ccd
URL:
https://github.com/llvm/llvm-project/commit/f65b0b5dcfeb04e9e6794b32a075432ce3de1ccd
DIFF:
https://github.com/llvm/llvm-project/commit/f65b0b5dcfeb04e9e6794b32a075432ce3de1ccd.diff
LO
Author: Ben Barham
Date: 2022-03-30T11:52:41-07:00
New Revision: 3fda0edc51fd68192a30e302d45db081bb02d7f9
URL:
https://github.com/llvm/llvm-project/commit/3fda0edc51fd68192a30e302d45db081bb02d7f9
DIFF:
https://github.com/llvm/llvm-project/commit/3fda0edc51fd68192a30e302d45db081bb02d7f9.diff
LO
49 matches
Mail list logo
