steakhal wrote:
My current stance is that we should have the memoryspace trait only for
memregions that have an UnknownSpace memspace, becuase that would be the least
amount of work. So it would be a hybrid solution.
We have the memspaces as we have today, but for UnknownSpace you would need to
steakhal wrote:
> I agree that it would make more sense to generalize this beyond loop
> widening. However, I'm having a hard time understanding how your proposal
> would fit in to the augmentation of the assignment message like I do in this
> PR.
>
> The part I'm most confused about is how w
steakhal wrote:
I agree that it's important to augment the bug reports with information about
the source of the symbols. Especially for conjured and derived symbols that are
produced widely because of invalidations.
Loop widening is just one source of invalidation, and we could generalize it
s
@@ -0,0 +1,48 @@
+// RUN: %clang_analyze_cc1 -triple=x86_64-pc-linux-gnu
-analyzer-checker=core,unix.Stream,debug.ExprInspection \
+// RUN: -analyzer-config eagerly-assume=false,unix.Stream:Pedantic=true
-verify %s
+// RUN: %clang_analyze_cc1 -triple=armv8-none-linux-eabi
-an
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/122404
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -952,6 +952,12 @@ SVal SimpleSValBuilder::evalBinOpLL(ProgramStateRef state,
const MemSpaceRegion *RightMS = RightBase->getMemorySpace();
const MemSpaceRegion *UnknownMS = MemMgr.getUnknownRegion();
+if (LeftMS != RightMS &&
+((isa(LeftMS) && isa(RightMS
@@ -0,0 +1,48 @@
+// RUN: %clang_analyze_cc1 -triple=x86_64-pc-linux-gnu
-analyzer-checker=core,unix.Stream,debug.ExprInspection \
+// RUN: -analyzer-config eagerly-assume=false,unix.Stream:Pedantic=true
-verify %s
+// RUN: %clang_analyze_cc1 -triple=armv8-none-linux-eabi
-an
@@ -0,0 +1,48 @@
+// RUN: %clang_analyze_cc1 -triple=x86_64-pc-linux-gnu
-analyzer-checker=core,unix.Stream,debug.ExprInspection \
+// RUN: -analyzer-config eagerly-assume=false,unix.Stream:Pedantic=true
-verify %s
+// RUN: %clang_analyze_cc1 -triple=armv8-none-linux-eabi
-an
https://github.com/steakhal requested changes to this pull request.
In general, the concept of having the memory space directly embedded into a
memory region is flawed. And that is the root cause of the problem.
Ideally, the property of "in what memory space does this region live in" is a
trai
=?utf-8?q?Balázs_Kéri?=
Message-ID:
In-Reply-To:
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/122139
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
steakhal wrote:
Now that I looked at that PR, it was merged without approval, while having open
comments.
https://github.com/llvm/llvm-project/pull/122249
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
https://github.com/steakhal created
https://github.com/llvm/llvm-project/pull/122272
In my patch there, I left a test expectation stale. Tests with `REQUIRES: Z3`
never run because no bots check such configurations.
Here I'm adjusting the test expectations to meet reality.
>From 70d29e2ed8a98
steakhal wrote:
Its usually good practice to refer to the last commit where the dead resources
become dead.
You can use the git log -S to find out about the commits the thing is mentioned.
Example: `git log -Sexample_custom_assert -- clang/www/analyzer/`, will mention:
```
61a76f58ebf161c739fb1
=?utf-8?q?Balázs_Kéri?=
Message-ID:
In-Reply-To:
@@ -351,12 +356,30 @@ void DereferenceChecker::checkBind(SVal L, SVal V, const
Stmt *S,
C.addTransition(State, this);
}
-void ento::registerDereferenceChecker(CheckerManager &mgr) {
- auto *Chk = mgr.registerChecker();
-
=?utf-8?q?Balázs_Kéri?=
Message-ID:
In-Reply-To:
@@ -351,12 +356,30 @@ void DereferenceChecker::checkBind(SVal L, SVal V, const
Stmt *S,
C.addTransition(State, this);
}
-void ento::registerDereferenceChecker(CheckerManager &mgr) {
- auto *Chk = mgr.registerChecker();
-
=?utf-8?q?Balázs_Kéri?=
Message-ID:
In-Reply-To:
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/122139
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
=?utf-8?q?Bal=C3=A1zs_K=C3=A9ri?=
Message-ID:
In-Reply-To:
@@ -155,22 +155,27 @@ static bool isDeclRefExprToReference(const Expr *E) {
void DereferenceChecker::reportBug(DerefKind K, ProgramStateRef State,
const Stmt *S, CheckerContext &C)
=?utf-8?q?Bal=C3=A1zs_K=C3=A9ri?=
Message-ID:
In-Reply-To:
https://github.com/steakhal approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/122139
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/
https://github.com/steakhal approved this pull request.
LGTM. Please check if the generated docs look as intended before merging.
https://github.com/llvm/llvm-project/pull/121939
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llv
https://github.com/steakhal closed
https://github.com/llvm/llvm-project/pull/121910
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/121910
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
steakhal wrote:
FYI @necto
https://github.com/llvm/llvm-project/pull/121910
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/121910
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal created
https://github.com/llvm/llvm-project/pull/121910
This simplifies #120239
Addresses my comment at:
https://github.com/llvm/llvm-project/pull/120239#issuecomment-2574600543
>From 49bac3d08faee3fe962326b69ac4cb49a07643af Mon Sep 17 00:00:00 2001
From: Balazs Ben
steakhal wrote:
I find this really unfortunate that I had to patch the other places where we
initialize the AnalyzerOptions table.
Just because the we can't assign the default value to the given option. This
makes me reconsider my approach because it WILL break all downstream users.
Any suggest
=?utf-8?q?Kristóf?= Umann ,
=?utf-8?q?Kristóf?= Umann ,
=?utf-8?q?Kristóf?= Umann
Message-ID:
In-Reply-To:
steakhal wrote:
Could you please check the generated html prior merging this, just to be on the
safe side it looks as intended.
https://github.com/llvm/llvm-project/pull/121759
=?utf-8?q?Kristóf?= Umann ,
=?utf-8?q?Kristóf?= Umann ,
=?utf-8?q?Kristóf?= Umann
Message-ID:
In-Reply-To:
@@ -1407,8 +1407,17 @@ These attributes are used by the Clang Static Analyzer's
dynamic memory modeling
facilities to mark custom allocating/deallocating functions.
A
=?utf-8?q?Krist=C3=B3f?= Umann ,
=?utf-8?q?Krist=C3=B3f?= Umann ,
=?utf-8?q?Krist=C3=B3f?= Umann
Message-ID:
In-Reply-To:
https://github.com/steakhal approved this pull request.
Looks truly awesome
https://github.com/llvm/llvm-project/pull/121759
__
=?utf-8?q?Kristóf?= Umann ,
=?utf-8?q?Kristóf?= Umann ,
=?utf-8?q?Kristóf?= Umann
Message-ID:
In-Reply-To:
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/121759
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
https://github.com/steakhal closed
https://github.com/llvm/llvm-project/pull/120239
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
=?utf-8?q?Kristóf?= Umann
Message-ID:
In-Reply-To:
@@ -1389,6 +1389,68 @@ Query for this attribute with
``__has_attribute(overloadable)``.
}];
}
+def OwnershipDocs : Documentation {
+ let Heading = "ownership_holds, ownership_returns, ownership_takes (Clang "
+
=?utf-8?q?Kristóf?= Umann
Message-ID:
In-Reply-To:
steakhal wrote:
You have a build error:
https://github.com/llvm/llvm-project/actions/runs/12634515572/job/35202412861#step:10:773
https://github.com/llvm/llvm-project/pull/121759
___
cfe-commits mai
=?utf-8?q?Kristóf?= Umann
Message-ID:
In-Reply-To:
@@ -1389,6 +1389,68 @@ Query for this attribute with
``__has_attribute(overloadable)``.
}];
}
+def OwnershipDocs : Documentation {
+ let Heading = "ownership_holds, ownership_returns, ownership_takes (Clang "
+
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/120239
>From f7041f5f6f0127f335bedf081f648e769007a827 Mon Sep 17 00:00:00 2001
From: Balazs Benics
Date: Tue, 17 Dec 2024 15:35:27 +0100
Subject: [PATCH 1/7] [analyzer] Retry UNDEF Z3 queries at most
"crosscheck-with
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/120239
>From f7041f5f6f0127f335bedf081f648e769007a827 Mon Sep 17 00:00:00 2001
From: Balazs Benics
Date: Tue, 17 Dec 2024 15:35:27 +0100
Subject: [PATCH 1/6] [analyzer] Retry UNDEF Z3 queries at most
"crosscheck-with
@@ -77,16 +80,32 @@ void
Z3CrosscheckVisitor::finalizeVisitor(BugReporterContext &BRC,
RefutationSolver->addConstraint(SMTConstraints);
}
- // And check for satisfiability
- llvm::TimeRecord Start = llvm::TimeRecord::getCurrentTime(/*Start=*/true);
- std::optional Is
steakhal wrote:
> LGTM, thanks for the updates!
>
> If the updated test passes, feel free to merge it.
The uploaded tests never run in the CI due to the `REQUIRES: Z3`. I double
checked locally and everything passes.
Thanks for the review.
https://github.com/llvm/llvm-project/pull/120239
___
@@ -213,6 +215,15 @@ ANALYZER_OPTION(
"400'000 should on average make Z3 queries run for up to 100ms on modern "
"hardware. Set 0 for unlimited.", 0)
+ANALYZER_OPTION(
+unsigned, Z3CrosscheckRetriesOnTimeout,
+"crosscheck-with-z3-retries-on-timeout",
+"Set
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/120239
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/120239
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/120239
>From f7041f5f6f0127f335bedf081f648e769007a827 Mon Sep 17 00:00:00 2001
From: Balazs Benics
Date: Tue, 17 Dec 2024 15:35:27 +0100
Subject: [PATCH 1/5] [analyzer] Retry UNDEF Z3 queries at most
"crosscheck-with
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/120239
>From f7041f5f6f0127f335bedf081f648e769007a827 Mon Sep 17 00:00:00 2001
From: Balazs Benics
Date: Tue, 17 Dec 2024 15:35:27 +0100
Subject: [PATCH 1/3] [analyzer] Retry UNDEF Z3 queries at most
"crosscheck-with
@@ -1389,6 +1389,68 @@ Query for this attribute with
``__has_attribute(overloadable)``.
}];
}
+def OwnershipDocs : Documentation {
+ let Heading = "ownership_holds, ownership_returns, ownership_takes (Clang "
+"Static Analyzer)";
+ let Category = DocCatFun
https://github.com/steakhal approved this pull request.
Looks pretty good. Thanks for the docs. That's always a nice way to start a
year.
https://github.com/llvm/llvm-project/pull/121759
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://
@@ -1389,6 +1389,68 @@ Query for this attribute with
``__has_attribute(overloadable)``.
}];
}
+def OwnershipDocs : Documentation {
+ let Heading = "ownership_holds, ownership_returns, ownership_takes (Clang "
+"Static Analyzer)";
+ let Category = DocCatFun
@@ -1389,6 +1389,68 @@ Query for this attribute with
``__has_attribute(overloadable)``.
}];
}
+def OwnershipDocs : Documentation {
+ let Heading = "ownership_holds, ownership_returns, ownership_takes (Clang "
+"Static Analyzer)";
+ let Category = DocCatFun
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/121759
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal closed
https://github.com/llvm/llvm-project/pull/121749
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal approved this pull request.
Once the premerge bots are happy, we can merge this. Thanks!
https://github.com/llvm/llvm-project/pull/121749
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/121749
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/121749
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
steakhal wrote:
> I'm a bit surprised by the idea of using multiple attempts instead of a
> single run with a larger timeout -- intuitively we're wasting the already
> performed calculations if we are impatient and abort+restart the calculations
> after each short timeout (instead of allocatin
@@ -213,6 +215,15 @@ ANALYZER_OPTION(
"400'000 should on average make Z3 queries run for up to 100ms on modern "
"hardware. Set 0 for unlimited.", 0)
+ANALYZER_OPTION(
+unsigned, Z3CrosscheckRetriesOnTimeout,
+"crosscheck-with-z3-retries-on-timeout",
+"Set
@@ -77,16 +80,33 @@ void
Z3CrosscheckVisitor::finalizeVisitor(BugReporterContext &BRC,
RefutationSolver->addConstraint(SMTConstraints);
}
- // And check for satisfiability
- llvm::TimeRecord Start = llvm::TimeRecord::getCurrentTime(/*Start=*/true);
- std::optional Is
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/120239
>From f7041f5f6f0127f335bedf081f648e769007a827 Mon Sep 17 00:00:00 2001
From: Balazs Benics
Date: Tue, 17 Dec 2024 15:35:27 +0100
Subject: [PATCH 1/2] [analyzer] Retry UNDEF Z3 queries at most
"crosscheck-with
steakhal wrote:
@necto Please have a look at the build failures. There are plenty.
For the time being, I reverted this PR.
https://github.com/llvm/llvm-project/pull/121551
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/c
https://github.com/steakhal closed
https://github.com/llvm/llvm-project/pull/121592
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal created
https://github.com/llvm/llvm-project/pull/121592
Reverts llvm/llvm-project#121551
We had a bunch of build errors caused by this PR.
https://lab.llvm.org/buildbot/#/builders/144/builds/14875
>From 81d2afb2991e636de374eb1d1b550786618ed036 Mon Sep 17 00:00:00
https://github.com/steakhal closed
https://github.com/llvm/llvm-project/pull/121551
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal approved this pull request.
LGTM, thanks.
https://github.com/llvm/llvm-project/pull/121551
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -687,4 +711,35 @@ class SymbolVisitor {
} // namespace clang
+// Override the default definition that would use pointer values of SymbolRefs
+// to order them, which is unstable due to ASLR.
+// Use the SymbolID instead which reflect the order in which the symbols were
+//
@@ -687,4 +711,35 @@ class SymbolVisitor {
} // namespace clang
+// Override the default definition that would use pointer values of SymbolRefs
+// to order them, which is unstable due to ASLR.
+// Use the SymbolID instead which reflect the order in which the symbols were
+//
@@ -687,4 +711,35 @@ class SymbolVisitor {
} // namespace clang
+// Override the default definition that would use pointer values of SymbolRefs
+// to order them, which is unstable due to ASLR.
+// Use the SymbolID instead which reflect the order in which the symbols were
+//
@@ -56,6 +68,8 @@ class SymExpr : public llvm::FoldingSetNode {
Kind getKind() const { return K; }
+ SymbolID getSymbolID() const { return Sym; }
steakhal wrote:
This is expected to be a fairly infrequently used API. I think this deserves to
be highlight
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/121551
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal commented:
@Xazax-hun I'm pretty happy with this PR, but I'm curious about your opinion on
adding the `SymbolID Sym` member to the SymExprs.
https://github.com/llvm/llvm-project/pull/121551
___
cfe-commits mailing list
cfe-
=?utf-8?q?Don=C3=A1t?= Nagy ,
=?utf-8?q?Don=C3=A1t?= Nagy ,
=?utf-8?q?Don=C3=A1t?= Nagy ,
=?utf-8?q?Don=C3=A1t?= Nagy ,
=?utf-8?q?Don=C3=A1t?= Nagy ,
=?utf-8?q?Don=C3=A1t?= Nagy ,
=?utf-8?q?Don=C3=A1t?= Nagy ,
=?utf-8?q?Don=C3=A1t?= Nagy
Message-ID:
In-Reply-To:
https://github.com/steakhal appr
=?utf-8?q?Don=C3=A1t?= Nagy ,
=?utf-8?q?Don=C3=A1t?= Nagy ,
=?utf-8?q?Don=C3=A1t?= Nagy ,
=?utf-8?q?Don=C3=A1t?= Nagy ,
=?utf-8?q?Don=C3=A1t?= Nagy ,
=?utf-8?q?Don=C3=A1t?= Nagy
Message-ID:
In-Reply-To:
steakhal wrote:
One more thing. Please mention this in the release notes.
https://github.c
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
https://github.com/steakhal approved this pull request.
> If I understand correctly, I handled every review suggestion.
>
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/119388
_
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy ,
=?utf-8?q?Donát?= Nagy
Message-ID:
In-Reply-To:
@@ -910,38 +910,51 @@ void pr6302(id x, Class y) {
//===-
@@ -427,8 +434,8 @@ class BinarySymExprImpl : public BinarySymExpr {
public:
BinarySymExprImpl(LHSTYPE lhs, BinaryOperator::Opcode op, RHSTYPE rhs,
-QualType t)
- : BinarySymExpr(ClassKind, op, t), LHS(lhs), RHS(rhs) {
+QualType t
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/121347
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal commented:
The content look narrow and precise.
It raises me questions why is the only user of this new field the Constraint
manager?
And if the constraint manager is the only user, why is the SMT-based solver not
using this? Should all the other immutableSet/Map ben
@@ -401,7 +401,22 @@ class RangeSet {
friend class Factory;
};
-using ConstraintMap = llvm::ImmutableMap;
+struct ConstraintKVInfo : llvm::ImutKeyValueInfo {
+ static inline bool isEqual(key_type_ref L, key_type_ref R) {
+return L->getAllocID() == R->getAllocID();
+ }
@@ -427,8 +434,8 @@ class BinarySymExprImpl : public BinarySymExpr {
public:
BinarySymExprImpl(LHSTYPE lhs, BinaryOperator::Opcode op, RHSTYPE rhs,
-QualType t)
- : BinarySymExpr(ClassKind, op, t), LHS(lhs), RHS(rhs) {
+QualType t
steakhal wrote:
Disclaimer: I haven't checked the actual patch, but I'll come back to it :D
Maybe next year.
I think I've seen already a variant of this downstream and I generally agreed
with the vision. I don't expect much friction on this front, but I'll have a
deeper look.
---
> This patc
https://github.com/steakhal closed
https://github.com/llvm/llvm-project/pull/121203
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -283,10 +283,12 @@ static bool shouldCompletelyUnroll(const Stmt *LoopStmt,
ASTContext &ASTCtx,
llvm::APInt InitNum =
Matches[0].getNodeAs("initNum")->getValue();
auto CondOp = Matches[0].getNodeAs("conditionOperator");
- if (InitNum.getBitWidth() != BoundNum.get
@@ -283,10 +283,12 @@ static bool shouldCompletelyUnroll(const Stmt *LoopStmt,
ASTContext &ASTCtx,
llvm::APInt InitNum =
Matches[0].getNodeAs("initNum")->getValue();
auto CondOp = Matches[0].getNodeAs("conditionOperator");
- if (InitNum.getBitWidth() != BoundNum.get
https://github.com/steakhal approved this pull request.
Looks wonderful now.
I had recommended one simplification, but other than that we can merge this.
Thanks again!
https://github.com/llvm/llvm-project/pull/121203
___
cfe-commits mailing list
cfe-c
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/121203
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -283,10 +283,12 @@ static bool shouldCompletelyUnroll(const Stmt *LoopStmt,
ASTContext &ASTCtx,
llvm::APInt InitNum =
Matches[0].getNodeAs("initNum")->getValue();
auto CondOp = Matches[0].getNodeAs("conditionOperator");
- if (InitNum.getBitWidth() != BoundNum.get
https://github.com/steakhal commented:
Thanks for the nice reproducer!
The test looks a bit verbose to my taste, but it's okay as-is.
I had some deeper thoughts of the fix inline to settle before we could merge
this.
Thanks again for working on this issue!
https://github.com/llvm/llvm-project/
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/121203
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
steakhal wrote:
Could you please add a RUN line to the test, and a `// no-crash` comment at the
line where previously crashed during interpretation?
I'd also prefer a `clang-formated` test file if possible.
Are you sure the test case is minimal and couldn't be minimized further now
that you kno
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/121203
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
steakhal wrote:
Hey, could you add a test for this PR that would crash on main, but wouldn't
with this patch?
https://github.com/llvm/llvm-project/pull/121203
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
steakhal wrote:
So we had the following assertion failure:
```
clang/lib/Analysis/ThreadSafety.cpp:529: LocalVariableMap::addDefinition:
Assertion `!Ctx.contains(D)' failed.
```
On
`libcxx/test/std/algorithms/alg.modifying.operations/alg.fill/pstl.fill_n.pass.cpp`.
I wish I could come back to
https://github.com/steakhal closed
https://github.com/llvm/llvm-project/pull/120981
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal created
https://github.com/llvm/llvm-project/pull/120981
I noticed recently that this code (that I wrote xD) uses the
`getRuntimeDefinition()` which isn't quite necessary for the simple task this
function was designed for.
Why would it be better not using this API
steakhal wrote:
How did you notice this? If its from a real case then we could add a regression
test for this too.
https://github.com/llvm/llvm-project/pull/120597
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/
steakhal wrote:
> I've reverted it in
> https://github.com/llvm/llvm-project/commit/2b9abf0db2d106c7208b4372e662ef5df869e6f1
> to clear up some buildbots
Thanks! Ill have a look later.
https://github.com/llvm/llvm-project/pull/116462
___
cfe-commits
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/120572
>From 097d7feb474e7eca884730dc8eebbb8b1bdef2e1 Mon Sep 17 00:00:00 2001
From: Balazs Benics
Date: Thu, 19 Dec 2024 13:45:58 +0100
Subject: [PATCH 1/2] [analyzer] Model [[assume]] attributes without
side-ffects
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/120572
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
steakhal wrote:
I made the followup for this one in #120572
https://github.com/llvm/llvm-project/pull/116462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal created
https://github.com/llvm/llvm-project/pull/120572
This PR splits the existing modeling of builtin assume from the
BuiltinFunctionChecker.
We just sink the execution path if we are about to leave the assume expression
with a false assumption.
Assumptions with
https://github.com/steakhal closed
https://github.com/llvm/llvm-project/pull/116462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
steakhal wrote:
### Merge activity
* **Dec 19, 7:01 AM EST**: A user merged this pull request with
[Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/120438).
https://github.com/llvm/llvm-project/pull/120438
___
cfe-commits mailing list
https://github.com/steakhal closed
https://github.com/llvm/llvm-project/pull/120438
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 1634 matches
Mail list logo
