Re: [PATCH] D19084: [scan-build] fix warnings emitted on Clang AST code base

apelete updated this revision to Diff 57571. apelete retitled this revision from "[scan-build] fix warnings emitted on Clang AST code base " to "[scan-build] fix warnings emitted on Clang AST code base". apelete added a comment. [scan-build] fix warnings emitted on Clang AST code base Changes si

Re: [PATCH] D19829: [scan-build] fix dead store warnings emitted on clang code base

apelete updated this revision to Diff 57560. apelete added a comment. [scan-build] fix dead store warnings emitted on clang code base Changes since last revision: - lib/Sema/SemaLookup.cpp: remove changes since they were already applied upstream, - lib/Sema/SemaExpr.cpp: move 'IsDereference' an

Re: [PATCH] D19084: [scan-build] fix warnings emitted on Clang AST code base

apelete added inline comments. Comment at: lib/AST/ASTDiagnostic.cpp:1686 @@ -1685,3 +1685,3 @@ -if (Same) { +if (Same && FromTD) { OS << "template " << FromTD->getNameAsString(); rtrieu wrote: > dblaikie wrote: > > Should this be a condition, or

Re: [PATCH] D19962: [scan-build] fix warnings emitted on Clang StaticAnalyzer code base

apelete updated this revision to Diff 56556. apelete added a comment. [scan-build] fix warnings emitted on Clang StaticAnalyzer code base - lib/StaticAnalyzer/Core/PlistDiagnostics.cpp: factorize assert and check on '!Diags.empty' condition. http://reviews.llvm.org/D19962 Files: lib/StaticA

Re: [PATCH] D19962: [scan-build] fix warnings emitted on Clang StaticAnalyzer code base

apelete added inline comments. Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:300 @@ -299,2 +299,3 @@ + assert(SM && "SourceManager is NULL, cannot iterate through the diagnostics"); dblaikie wrote: > This assertion seems to be equivalent to replac

Re: [PATCH] D19960: [scan-build] fix warnings emitted on Clang CodeGen code base

apelete added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:1317 @@ -1316,2 +1316,3 @@ } + assert(V && "constant must be not NULL at this point"); TemplateParams.push_back(DBuilder.createTemplateValueParameter( dblaikie wrote: > It lo

[PATCH] D19963: [scan-build] fix warnings emitted on Clang Frontend code baseFix "Logic error" warnings of the type "Called C++ object pointer isnull" reported by Clang Static Analyzer on the followin

apelete created this revision. apelete added reviewers: akyrtzi, rsmith. apelete added a subscriber: cfe-commits. Signed-off-by: Apelete Seketeli http://reviews.llvm.org/D19963 Files: lib/Frontend/CompilerInstance.cpp Index: lib/Frontend/CompilerInstance.cpp =

Re: [PATCH] D19385: [scan-build] fix logic error warnings emitted on clang code base

apelete updated this revision to Diff 56259. apelete added a comment. [scan-build] fix warnings emitted on Clang Format code base Changes since last revision: - split patch into Format unit to ease review process. http://reviews.llvm.org/D19385 Files: lib/Format/AffectedRangeManager.cpp l

[PATCH] D19962: [scan-build] fix warnings emitted on Clang StaticAnalyzer code base

apelete created this revision. apelete added a reviewer: zaks.anna. apelete added a subscriber: cfe-commits. This patch fixes a few "Logic error" warnings of the type "Called c++ object pointer is null" reported by Clang Static Analyzer on the following files: - lib/StaticAnalyzer/Checkers/Nullab

[PATCH] D19960: [scan-build] fix warnings emitted on Clang CodeGen code base

apelete created this revision. apelete added reviewers: dblaikie, pcc. apelete added a subscriber: cfe-commits. Fix "Logic error" warnings of the type "Called c++ object pointer is null" reported by Clang Static Analyzer on the following files: - lib/CodeGen/CGDebugInfo.cpp, - lib/CodeGen/CodeGen

Re: [PATCH] D19278: [scan-build] fix logic error warnings emitted on clang code base

apelete updated this revision to Diff 56253. apelete added a comment. [scan-build] fix warnings emitted on Clang Sema code base Changes since last revision: - split patch into Sema changes unit to ease review process, - cherry-pick Sema changes from http://reviews.llvm.org/D19084, - cherry-pick

[PATCH] D19959: [scan-build] fix warning emitted on Clang Driver code baseFix a "logic error" warning of the type Called c++ object pointer isnull" reported by Clang Static Analyzer on the file:- lib/

apelete created this revision. apelete added reviewers: kevin.qin, rsmith. apelete added a subscriber: cfe-commits. Signed-off-by: Apelete Seketeli http://reviews.llvm.org/D19959 Files: lib/Driver/Tools.cpp Index: lib/Driver/Tools.cpp =

Re: [PATCH] D19084: [clang-analyzer] fix warnings emitted on clang code base

apelete updated this revision to Diff 56248. apelete added a comment. [scan-build] fix warnings emitted on Clang AST code base Changes since last revision: - split patch into AST changes unit to ease review process. http://reviews.llvm.org/D19084 Files: lib/AST/ASTDiagnostic.cpp lib/AST/D

Re: [PATCH] D19831: [scan-build] fix dead store warnings emitted on clang code base

apelete added a comment. In http://reviews.llvm.org/D19831#420410, @dblaikie wrote: > Thanks - do you need someone (me) to commit this, or do you have commit > access? I would appreciate if you could commit this for me since I don't have commit access. Thanks. http://reviews.llvm.org/D19831

Re: [PATCH] D19831: [scan-build] fix dead store warnings emitted on clang code base

apelete updated this revision to Diff 56059. apelete added a comment. [scan-build] fix dead store warnings emitted on clang code base Changes since last revision: - Move 'Record' and 'Parent' variables into if() {} scope where they are actually used. http://reviews.llvm.org/D19831 Files: t

Re: [PATCH] D19831: [scan-build] fix dead store warnings emitted on clang code base

apelete added a comment. In http://reviews.llvm.org/D19831#420115, @dblaikie wrote: > Looks good to me - go ahead & commit whenever you're ready. If this last revision is good for you, please go ahead and commit this for me (I don't have commit access). Thanks. http://reviews.llvm.org/D1983

Re: [PATCH] D19831: [scan-build] fix dead store warnings emitted on clang code base

apelete updated this revision to Diff 56042. apelete added a comment. [scan-build] fix dead store warnings emitted on clang code base Changes since last revision: - Initialize 'CXCursor Parent' variable to avoid passing 'Record' variable as an un-initialized argument thereafter. http://review

Re: [PATCH] D19831: [scan-build] fix dead store warnings emitted on clang code base

apelete added inline comments. Comment at: tools/c-index-test/c-index-test.c:1440 @@ -1440,3 +1439,3 @@ Record = Parent; Parent = clang_getCursorSemanticParent(Record); RecordIsAnonymous = clang_Cursor_isAnonymous(Record); This line now

Re: [PATCH] D19831: [scan-build] fix dead store warnings emitted on clang code base

apelete updated this revision to Diff 55952. apelete added a comment. [scan-build] fix dead store warnings emitted on clang code base Changes since last revision: - remove dead store since the do {} while() loop overwrite it immediatly anyway. http://reviews.llvm.org/D19831 Files: tools/c-i

Re: [PATCH] D19831: [scan-build] fix dead store warnings emitted on clang code base

apelete added a comment. In http://reviews.llvm.org/D19831#419456, @dblaikie wrote: > Sorry, I meant remove the /store/, if it's dead. The do/while loop > overwrites the store immediately, so just remove the assignment to Record? Makes sense, I overlooked that. Will fix in next revision. htt

Re: [PATCH] D19831: [scan-build] fix dead store warnings emitted on clang code base

apelete added a comment. In http://reviews.llvm.org/D19831#419140, @dblaikie wrote: > Any reason not to remove the story instead? What do you mean by "remove the story" ? http://reviews.llvm.org/D19831 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D19831: [scan-build] fix dead store warnings emitted on clang code base

apelete created this revision. apelete added a reviewer: akyrtzi. apelete added a subscriber: cfe-commits. This fixes dead store warnings of the type "dead assignment" reported by CLang Static Analyzer on the following file: - tools/c-index-test/c-index-test.c. Signed-off-by: Apelete Seketeli

[PATCH] D19830: [scan-build] fix dead store warnings emitted on clang code base

apelete created this revision. apelete added a reviewer: doug.gregor. apelete added a subscriber: cfe-commits. This fixes dead store warnings of the type "dead assignment" reported by CLang Static Analyzer on the following files: - lib/Lex/Lexer.cpp, - lib/Lex/ModuleMap.cpp. Signed-off-by: Apele

[PATCH] D19829: [scan-build] fix dead store warnings emitted on clang code base

apelete created this revision. apelete added reviewers: rjmccall, rtrieu, rsmith. apelete added a subscriber: cfe-commits. This fixes dead store warnings of the type "dead assignment" reported by CLang Static Analyzer on the following files: - lib/Sema/SemaDeclCXX.cpp, - lib/Sema/SemaExpr.cpp, -

Re: [PATCH] D19385: [scan-build] fix logic error warnings emitted on clang code base

apelete updated this revision to Diff 55757. apelete added a comment. [scan-build] fix logic error warnings emitted on clang code base Changes since last revision: - lib/Format/AffectedRangeManager.cpp: fix typo in class name. http://reviews.llvm.org/D19385 Files: lib/AST/DeclObjC.cpp lib

Re: [PATCH] D19385: [scan-build] fix logic error warnings emitted on clang code base

apelete added a comment. Waiting for review, could someone please have a look at this one ? http://reviews.llvm.org/D19385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19278: [scan-build] fix logic error warnings emitted on clang code base

apelete added a reviewer: pcc. apelete added a comment. Waiting for review, could someone please have a look at this one ? http://reviews.llvm.org/D19278 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

Re: [PATCH] D19084: [clang-analyzer] fix warnings emitted on clang code base

apelete added a reviewer: rjmccall. apelete added a comment. Waiting for review, could someone please have a look at this one ? http://reviews.llvm.org/D19084 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

Re: [PATCH] D19385: [scan-build] fix logic error warnings emitted on clang code base

apelete updated this revision to Diff 55748. apelete added a comment. [scan-build] fix logic error warnings emitted on clang code base Changes since last revision: - fast forward rebase on git master branch. http://reviews.llvm.org/D19385 Files: lib/AST/DeclObjC.cpp lib/Format/AffectedRan

Re: [PATCH] D19278: [scan-build] fix logic error warnings emitted on clang code base

apelete updated this revision to Diff 55747. apelete added a comment. [scan-build] fix logic error warnings emitted on clang code base Changes since last revision: - fast forward rebase on git master branch. http://reviews.llvm.org/D19278 Files: lib/AST/ExprConstant.cpp lib/CodeGen/CGDebu

Re: [PATCH] D19084: [clang-analyzer] fix warnings emitted on clang code base

apelete updated this revision to Diff 55746. apelete added a comment. [clang-analyzer] fix warnings emitted on clang code base Changes since last revision: - fast forward rebase on git master branch. http://reviews.llvm.org/D19084 Files: lib/AST/ASTDiagnostic.cpp lib/AST/NestedNameSpecifi

Re: [PATCH] D19385: [scan-build] fix logic error warnings emitted on clang code base

apelete added a comment. Thanks for your reviews. http://reviews.llvm.org/D19385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19385: [scan-build] fix logic error warnings emitted on clang code base

apelete updated this revision to Diff 55487. apelete marked 3 inline comments as done. apelete added a comment. [scan-build] fix logic error warnings emitted on clang code base Changes since last revision: - lib/Format/AffectedRangeManager.cpp: fix the call to AffectedRangeManager::nonPPLineAff

Re: [PATCH] D19385: [scan-build] fix logic error warnings emitted on clang code base

apelete updated this revision to Diff 55483. apelete added a comment. [scan-build] fix logic error warnings emitted on clang code base Changes since last revison: - lib/Format/AffectedRangeManager.h: fix declaration of nonPPLineAffected() to pass a reference to AnnotatedLine as first parameter.

Re: [PATCH] D19385: [scan-build] fix logic error warnings emitted on clang code base

apelete updated this revision to Diff 55327. apelete added a comment. [scan-build] fix logic error warnings emitted on clang code base Changes since last revision: - lib/Format/AffectedRangeManager.cpp: moved the fixes from lib/Format/Format.cpp:AffectedRangeManager::nonPPLineAffected() here si

Re: [PATCH] D19385: [scan-build] fix logic error warnings emitted on clang code base

apelete updated this revision to Diff 55103. apelete added a comment. [scan-build] fix logic error warnings emitted on clang code base Chnages since last revision: - lib/Format/Format.cpp: removed all changes, redenderd obsolete by upstream. http://reviews.llvm.org/D19385 Files: lib/AST/Dec

Re: [PATCH] D19385: [scan-build] fix logic error warnings emitted on clang code base

apelete added inline comments. Comment at: lib/Frontend/CompilerInstance.cpp:763 @@ -762,8 +762,3 @@ Includers.push_back(std::make_pair(FindFile, FindFile->getDir())); - File = HS->LookupFile(InputFile, SourceLocation(), /*isAngled=*/false, -

[PATCH] D19385: [scan-build] fix logic error warnings emitted on clang code base

apelete created this revision. apelete added reviewers: rjmccall, zaks.anna, rsmith. apelete added a subscriber: cfe-commits. Herald added a subscriber: klimek. Fixing another set of "Logic error" warnings of the type "Called c++ object pointer is null" reported by Clang Static Analyzer on the fol

Re: [PATCH] D19278: [scan-build] fix logic error warnings emitted on clang code base

apelete marked an inline comment as done. apelete added a comment. http://reviews.llvm.org/D19278 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19278: [scan-build] fix logic error warnings emitted on clang code base

apelete updated this revision to Diff 54269. apelete added a comment. [scan-build] fix logic error warnings emitted on clang code base Following changes were done since last revision: - lib/Sema/SemaOverload.cpp: avoid interleaving (FromExpr) and (!FromExpr->isLValue()) conditions in if() state

Re: [PATCH] D19278: [scan-build] fix logic error warnings emitted on clang code base

apelete marked an inline comment as done. apelete added a comment. http://reviews.llvm.org/D19278 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19278: [scan-build] fix logic error warnings emitted on clang code base

apelete updated this revision to Diff 54246. apelete added a comment. [scan-build] fix logic error warnings emitted on clang code base Following changes were done since last revision: - fix a typo in lib/Sema/SemaDeclCXX.cpp: decalration ==> declaration. http://reviews.llvm.org/D19278 Files:

Re: [PATCH] D19084: [clang-analyzer] fix warnings emitted on clang code base

apelete added a comment. Ping :). Can someone help this one find its way into he main repo ? http://reviews.llvm.org/D19084 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D19278: [scan-build] fix logic error warnings emitted on clang code base

apelete created this revision. apelete added a subscriber: cfe-commits. This partch fixes a few "Logic error" warnings of the type "Called c++ object pointer is null" reported by Clang Static Analyzer on the following files: - lib/AST/ExprConstant.cpp, - lib/CodeGen/CGDebugInfo.cpp, - lib/CodeGen

[PATCH] D19084: [clang-analyzer] fix warnings emitted on clang code base

apelete created this revision. apelete added a subscriber: cfe-commits. The following warnings were reported while running clang analyzer on Clang code base: API: argument with 'nonnull' attribute passed null, on file: - lib/AST/NestedNameSpecifier.cpp. Logic error: called C++ object pointer is

[scan-build] Fix reported logic error and api bugs

Hello, Here are a few changes that try to address some logic error bugs reported by running scan-build over the Clang code base. I have no background in compiler technology and I may have been trying to fix false positives; here is a quick overview of what scan-build reported, let me know if the