amaiorano wrote:
> Please also make the unused "operator delete" in CGFunctionInfo.h deleted,
> since it shouldn't have any callers.
>
> I think this never actually led to a real issue because of that operator
> delete... it calls the right deallocation function even if it's technically
> und
Author: amaiorano
Date: Wed Apr 5 09:13:45 2017
New Revision: 299543
URL: http://llvm.org/viewvc/llvm-project?rev=299543&view=rev
Log:
clang-format-vsix: Add "Format on Save" feature
This change adds a feature to the clang-format VS extension that optionally
enables the automatic formatting of d
Author: amaiorano
Date: Mon Jan 23 07:20:23 2017
New Revision: 292787
URL: http://llvm.org/viewvc/llvm-project?rev=292787&view=rev
Log:
clang-format: remove tests that assume no config file will be found as this is
not always the case
These tests fail for developers who place their build directo
On Fri, 20 Jan 2017 at 11:26 Eric Liu via Phabricator <
revi...@reviews.llvm.org> wrote:
ioeric added a comment.
In https://reviews.llvm.org/D28943#651536, @amaiorano wrote:
> In https://reviews.llvm.org/D28943#651489, @ioeric wrote:
>
> > In https://reviews.llvm.org/D28943#651488, @amaiorano wr
lang-format -style="{BasedOnStyle: Google, IndentWidth: 8}"
> > %s |
> >
> > ^
> >
> > :61:16: note: possible intended match here
> >
> >// CHECK10: {{^int\* i;$}}
> >
> > ^
> >
> >
> >
&g
You mean you build a modified version of clang-format where Style is
initialized to getGoogleStyle()?
I had wondered whether adding a -defaultStyle argument might be useful,
specifically in the case where you want to pass in yaml that simply tweaks
the default style, but I figured it's not much ha
suppose it works for you... Any idea what the problem can be?
>
>
>
> Regards,
>
> Mikael
>
>
> On 01/20/2017 02:22 AM, Antonio Maiorano via cfe-commits wrote:
>
> > Author: amaiorano
>
> > Date: Thu Jan 19 19:22:42 2017
>
> > New Revision: 292562
Author: amaiorano
Date: Thu Jan 19 19:22:42 2017
New Revision: 292562
URL: http://llvm.org/viewvc/llvm-project?rev=292562&view=rev
Log:
clang-format: fix fallback style set to "none" not always formatting
This fixes clang-format not formatting if fallback-style is explicitly set to
"none", and ei
Author: amaiorano
Date: Mon Jan 16 18:13:32 2017
New Revision: 292175
URL: http://llvm.org/viewvc/llvm-project?rev=292175&view=rev
Log:
Update tools to use new getStyle API
Depends on https://reviews.llvm.org/D28081
Differential Revision: https://reviews.llvm.org/D28315
Modified:
clang-tool
Author: amaiorano
Date: Mon Jan 16 18:12:27 2017
New Revision: 292174
URL: http://llvm.org/viewvc/llvm-project?rev=292174&view=rev
Log:
clang-format: Make GetStyle return Expected instead of FormatStyle
Change the contract of GetStyle so that it returns an error when an error occurs
(i.e. when it
Author: amaiorano
Date: Wed Dec 21 23:10:07 2016
New Revision: 290319
URL: http://llvm.org/viewvc/llvm-project?rev=290319&view=rev
Log:
Make FormatStyle.GetStyleOfFile test work on MSVC
Modify getStyle to use vfs::FileSystem::makeAbsolute just like FS.addFile does,
rather than sys::fs::make_absol
Author: amaiorano
Date: Thu Dec 15 19:51:43 2016
New Revision: 289910
URL: http://llvm.org/viewvc/llvm-project?rev=289910&view=rev
Log:
clang-format-vsix: add command to format document
Bound to Ctrl+R, Ctrl+D by default. Also added section on how to debug the
extension to the Readme.
Different
Author: amaiorano
Date: Thu Dec 15 19:37:01 2016
New Revision: 289909
URL: http://llvm.org/viewvc/llvm-project?rev=289909&view=rev
Log:
clang-format-vsix: add a date stamp to the VSIX version number to ensure
upgradability
Presently, the version number of the VSIX matches the LLVM version number
es via
> phabricator (http://llvm.org/docs/Phabricator.html) I'll get to it faster
> :) Feel free to directly add me as reviewer, btw (add 'klimek').
>
> On Sat, Dec 3, 2016 at 6:53 AM Antonio Maiorano via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
&g
to it faster
:) Feel free to directly add me as reviewer, btw (add 'klimek').
On Sat, Dec 3, 2016 at 6:53 AM Antonio Maiorano via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
Hello,
I have two patches for clang-format-vsix to offer up for review:
0001-clang-format-vsix-versi
Hello,
I have two patches for clang-format-vsix to offer up for review:
0001-clang-format-vsix-versioning.patch
clang-format-vsix: add a date stamp to the VSIX version number to ensure
upgradability
Presently, the version number of the VSIX matches the LLVM version number.
However, as this numbe
gt;> >> >>>>>> building
> >> >>> >> >> >>>>>> from
> >> >>> >> >> >>>>>> the CLI
> >> >>> >> >> >>>>>> doesn't work out of the b
> >>> >> >> >>>>>> custom build step in this CMakeLists.txt that runs devenv
> >>> >> >> >>>>>> doesn't
> >>> >> >> >>>>>> fail:
> >>> >> >> >&g
there are
> >> >> >>>>>> security annoyances to deal with.
> >> >> >>>>>>
> >> >> >>>>>> That's all I can come up with so far. Would love to hear from
> >> >> >>>>>> you
> >> >> >>>>&
t;> >>>>>> guys
> >> >> >>>>>> if you have any ideas or opinions on this. If you want I can
> >> >> >>>>>> send
> >> >> >>>>>> you a
> >> >> >>>>>>
;>>>> On Thu, Sep 15, 2016 at 4:17 PM, Zachary Turner
> >>>>>>>>> wrote:
> >>>>>>>>> > You may need to install the Visual Studio SDK. Did you do that
> >>>>>>>>> > when you
> >>>>>>>>>
rote:
> >> >>>>>>>>
> >> >>>>>>>> Strange. FWIW you can dump all the variables that are present
> in
> >> >>>>>>>> your environment. You need to go to Tools -> Options ->
> Projects
> >> >>>>>&g
t;> >> Llvm doesn't support vs2012 anymore, as long as it supports vs2013
> it's
> >> >> fine
> >> >> On Thu, Aug 18, 2016 at 7:07 PM Antonio Maiorano <
> amaior...@gmail.com>
> >> >> wrote:
> >> >>>
> >> >
.@gmail.com>
> >> >> wrote:
> >> >>>
> >> >>> Hi,
> >> >>>
> >> >>> What I meant by upgrade was simply making it build in VS 2015.
> >> >>> However,
> >> >>> you bring up a
t;>> from
>> >>> 10 to 14 that point out; I wonder if instead I should be able to
bring
>> >>> in
>> >>> those version 10 assemblies via NuGet. I'll take a closer look.
>> >>>
>> >>> Part of my change, however, seems to
ing it build in VS 2015.
> >> >>> However,
> >> >>> you bring up a valid point about making sure the extension will
> >> >>> continue to
> >> >>> work in VS 2012. I will look into that. Like those references that
> go
> >> >&g
>> What I meant by upgrade was simply making it build in VS 2015.
> >> >>> However,
> >> >>> you bring up a valid point about making sure the extension will
> >> >>> continue to
> >> >>> work in VS 2012. I will look int
;> you bring up a valid point about making sure the extension will
>> >> >>> continue to
>> >> >>> work in VS 2012. I will look into that. Like those references that
>> go
>> >> >>> from
>> >> >>> 10 to 14 that point
t validate.
Thanks,
Antonio
On Thu, 18 Aug 2016 at 19:38 Hans Wennborg wrote:
> Hi Antonio,
>
> On Wed, Aug 17, 2016 at 8:15 AM, Antonio Maiorano via cfe-commits
> wrote:
> > This patch for clang-format-vs includes the following:
> >
> > - Upgrade to VS 2015, incl
Hello,
This patch for clang-format-vs includes the following:
- Upgrade to VS 2015, including .NET framework upgrade from 4.0 to 4.5, and
upgrading Microsoft.VisualStudio references to v14 versions
- Fix build by removing dependency on "Key.snk" file which was never
checked in (and not really req
30 matches
Mail list logo
