Re: [PATCH] D23375: Add kfree( ) to MallocChecker.cpp

2016-08-27 Thread Andrew Wells via cfe-commits
andrewmw94 added a comment. One more thing, obviously it should mimic malloc/free's behavior in complaining about delete/new being used. Should it also complain about free/malloc being used? I can't imagine that would be something people would usually intend to do, but I don't think it's rea

Re: [PATCH] D23375: Add kfree( ) to MallocChecker.cpp

2016-08-15 Thread Andrew Wells via cfe-commits
andrewmw94 added a comment. I agree that more tests would be good. Where should I put them? Should it be in a separate file or should I just have kmalloc/kfree tests next to the malloc/free ones? https://reviews.llvm.org/D23375 ___ cfe-commits ma

Re: [PATCH] D23375: Add kfree( ) to MallocChecker.cpp

2016-08-10 Thread Andrew Wells via cfe-commits
andrewmw94 updated this revision to Diff 67610. andrewmw94 added a comment. Change the test file kmalloc-linux.c to use kfree( ). Sorry if there was a way to put both patch files together; I wasn't able to find one. Repository: rL LLVM https://reviews.llvm.org/D23375 Files: kmalloc-linux

[PATCH] D23375: Add kfree( ) to MallocChecker.cpp

2016-08-10 Thread Andrew Wells via cfe-commits
andrewmw94 created this revision. andrewmw94 added reviewers: zaks.anna, dcoughlin, dergachev.a. andrewmw94 added a subscriber: cfe-commits. andrewmw94 set the repository for this revision to rL LLVM. andrewmw94 added a project: clang-c. Adds the kfree( ) function to MallocChecker.cpp Repository:

Modify MallocChecker.cpp to recognize kfree( )

2016-08-09 Thread Andrew Wells via cfe-commits
This is my first commit, so my apologies if I did anything wrong. It adds kfree( ) to MallocChecker.cpp and changes the kmalloc-linuxs.c to test this change appropriately. Index: MallocChecker.cpp === --- MallocChecker.cpp (revision 2