[clang] [clang] Check null TypeSourceInfo in CreateUnaryExprOrTypeTraitExpr (PR #112111)

2024-10-15 Thread Andrew Sukach via cfe-commits
https://github.com/sookach updated https://github.com/llvm/llvm-project/pull/112111 >From d3b9b6ed8ffa8bad473a415ae4cc9f8748d7c2c2 Mon Sep 17 00:00:00 2001 From: Andrew Sukach Date: Sat, 12 Oct 2024 19:47:30 -0400 Subject: [PATCH] [clang] Check for null TypeSourceInfo in Sema::CreateUnaryExprO

[clang] [clang] Check null TypeSourceInfo in CreateUnaryExprOrTypeTraitExpr (PR #112111)

2024-10-15 Thread Andrew Sukach via cfe-commits
https://github.com/sookach updated https://github.com/llvm/llvm-project/pull/112111 >From 384e4eba4c3a587f0645e5f037b81acff786e39e Mon Sep 17 00:00:00 2001 From: Andrew Sukach Date: Sat, 12 Oct 2024 19:47:30 -0400 Subject: [PATCH] [clang] Check for null TypeSourceInfo in Sema::CreateUnaryExprO

[clang] [clang] Check null TypeSourceInfo in CreateUnaryExprOrTypeTraitExpr (PR #112111)

2024-10-15 Thread Andrew Sukach via cfe-commits
https://github.com/sookach updated https://github.com/llvm/llvm-project/pull/112111 >From a478b5e0d91b7246ed145af0febd86daf1e2 Mon Sep 17 00:00:00 2001 From: Andrew Sukach Date: Sat, 12 Oct 2024 19:47:30 -0400 Subject: [PATCH] [clang] Check for null TypeSourceInfo in Sema::CreateUnaryExprO

[clang] [clang] Check null TypeSourceInfo in CreateUnaryExprOrTypeTraitExpr (PR #112111)

2024-10-15 Thread Andrew Sukach via cfe-commits
@@ -0,0 +1,26 @@ +// RUN: %clang_cc1 -fsyntax-only -verify %s + +a() {struct b c (sizeof(b * [({ {tree->d* next)} 0 + +// expected-error@3 {{a type specifier is required for all declarations}} +// expected-error@3 {{use of undeclared identifier 'tree'; did you mean 'true'?}} +//

[clang] [clang] Check null TypeSourceInfo in CreateUnaryExprOrTypeTraitExpr (PR #112111)

2024-10-15 Thread Andrew Sukach via cfe-commits
https://github.com/sookach updated https://github.com/llvm/llvm-project/pull/112111 >From 64bde2ed7a39d5e270a7d1daca3a30a2cde6e0db Mon Sep 17 00:00:00 2001 From: Andrew Sukach Date: Sat, 12 Oct 2024 19:47:30 -0400 Subject: [PATCH] [clang] Check for null TypeSourceInfo in Sema::CreateUnaryExprO

[clang] [clang] Check null TypeSourceInfo in CreateUnaryExprOrTypeTraitExpr (PR #112111)

2024-10-15 Thread Andrew Sukach via cfe-commits
https://github.com/sookach updated https://github.com/llvm/llvm-project/pull/112111 >From 59537c2005e30d2ac8410822cb2804c63f2ae73b Mon Sep 17 00:00:00 2001 From: Andrew Sukach Date: Sat, 12 Oct 2024 19:47:30 -0400 Subject: [PATCH] [clang] Check for null TypeSourceInfo in Sema::CreateUnaryExprO

[clang] [clang] Check null TypeSourceInfo in CreateUnaryExprOrTypeTraitExpr (PR #112111)

2024-10-14 Thread Andrew Sukach via cfe-commits
https://github.com/sookach updated https://github.com/llvm/llvm-project/pull/112111 >From d7a37cb7805d5ba982b8073c2485f16dec8a1eac Mon Sep 17 00:00:00 2001 From: Andrew Sukach Date: Sat, 12 Oct 2024 19:47:30 -0400 Subject: [PATCH] [clang] Check for null TypeSourceInfo in Sema::CreateUnaryExprO

[clang] [clang] Check null TypeSourceInfo in CreateUnaryExprOrTypeTraitExpr (PR #112111)

2024-10-14 Thread Andrew Sukach via cfe-commits
https://github.com/sookach updated https://github.com/llvm/llvm-project/pull/112111 >From 8c0527aae4542c7065c14e8f21d6ca37010a29a6 Mon Sep 17 00:00:00 2001 From: Andrew Sukach Date: Sat, 12 Oct 2024 19:47:30 -0400 Subject: [PATCH 1/2] [clang] Check for null TypeSourceInfo in Sema::CreateUnaryE

[clang] [clang] Check null TypeSourceInfo in CreateUnaryExprOrTypeTraitExpr (PR #112111)

2024-10-14 Thread Andrew Sukach via cfe-commits
https://github.com/sookach updated https://github.com/llvm/llvm-project/pull/112111 >From 8c0527aae4542c7065c14e8f21d6ca37010a29a6 Mon Sep 17 00:00:00 2001 From: Andrew Sukach Date: Sat, 12 Oct 2024 19:47:30 -0400 Subject: [PATCH] [clang] Check for null TypeSourceInfo in Sema::CreateUnaryExprO

[clang] [clang] Check null TypeSourceInfo in CreateUnaryExprOrTypeTraitExpr (PR #112111)

2024-10-12 Thread Andrew Sukach via cfe-commits
https://github.com/sookach created https://github.com/llvm/llvm-project/pull/112111 Fixes #111594. The crash is caused by the following call https://github.com/llvm/llvm-project/blob/main/clang/lib/AST/ComputeDependence.cpp#L81-L82 We already check for a null TypeInfo when creating a UnaryExprO

[clang] [clang] Improve diagnostics with incompatible VLA types (PR #101261)

2024-09-12 Thread Andrew Sukach via cfe-commits
https://github.com/sookach updated https://github.com/llvm/llvm-project/pull/101261 >From 1b598a5f3b158ec231b96281e4e0edc6fa819389 Mon Sep 17 00:00:00 2001 From: Andrew Sukach Date: Tue, 30 Jul 2024 19:31:41 -0400 Subject: [PATCH] [clang] Improve diagnostics with incompatible VLA types --- cl

[clang] [clang] Improve diagnostics with incompatible VLA types (PR #101261)

2024-09-09 Thread Andrew Sukach via cfe-commits
https://github.com/sookach updated https://github.com/llvm/llvm-project/pull/101261 >From 54e4912ebcee4a54b05367f52a0e83b36a792c81 Mon Sep 17 00:00:00 2001 From: Andrew Sukach Date: Tue, 30 Jul 2024 19:31:41 -0400 Subject: [PATCH] [clang] Improve diagnostics with incompatible VLA types --- cl

[clang] [clang] Improve diagnostics with incompatible VLA types (PR #101261)

2024-09-08 Thread Andrew Sukach via cfe-commits
https://github.com/sookach updated https://github.com/llvm/llvm-project/pull/101261 >From 7c6109ea5133941baf32ec57e48c770ad015b883 Mon Sep 17 00:00:00 2001 From: Andrew Sukach Date: Tue, 30 Jul 2024 19:31:41 -0400 Subject: [PATCH] [clang] Improve diagnostics with incompatible VLA types --- cl

[clang] [clang] Improve diagnostics with incompatible VLA types (PR #101261)

2024-08-20 Thread Andrew Sukach via cfe-commits
https://github.com/sookach updated https://github.com/llvm/llvm-project/pull/101261 >From 1de106f82720ea6c470ce6c974c19f966599b9cc Mon Sep 17 00:00:00 2001 From: Andrew Sukach Date: Tue, 30 Jul 2024 19:31:41 -0400 Subject: [PATCH] [clang] Improve diagnostics with incompatible VLA types --- cl

[clang] [clang] Improve diagnostics with incompatible VLA types (PR #101261)

2024-08-20 Thread Andrew Sukach via cfe-commits
@@ -0,0 +1,9 @@ +// RUN: %clang_cc1 -fsyntax-only -verify %s + +void func(int n) { +int grp[n][n]; +int (*ptr)[n]; + +for (int i = 0; i < n; i++) +ptr = &grp[i]; // expected-error {{incompatible assignment of pointers of variable-length array type 'int (*)[n]'

[clang] [clang] Improve diagnostics with incompatible VLA types (PR #101261)

2024-08-20 Thread Andrew Sukach via cfe-commits
sookach wrote: Sorry for taking so long, but the new commit handles the diagnostic a little differently. I store the text types in temporary strings and then append a message to the diagnostic if the texts are identical. https://github.com/llvm/llvm-project/pull/101261

[clang] [clang] Improve diagnostics with incompatible VLA types (PR #101261)

2024-08-20 Thread Andrew Sukach via cfe-commits
https://github.com/sookach updated https://github.com/llvm/llvm-project/pull/101261 >From 6f1868ec7aebf24cfd61472a1a33f6bd65ebeeb5 Mon Sep 17 00:00:00 2001 From: Andrew Sukach Date: Tue, 30 Jul 2024 19:31:41 -0400 Subject: [PATCH] [clang] Improve diagnostics with incompatible VLA types --- cl

[clang] [clang] Improve diagnostics with incompatible VLA types (PR #101261)

2024-08-20 Thread Andrew Sukach via cfe-commits
https://github.com/sookach updated https://github.com/llvm/llvm-project/pull/101261 >From 5df72d9e8e89079b2c5312583e66756c048e5abe Mon Sep 17 00:00:00 2001 From: Andrew Sukach Date: Tue, 30 Jul 2024 19:31:41 -0400 Subject: [PATCH] [clang] Improve diagnostics with incompatible VLA types --- cl

[clang] [clang] Improve diagnostics with incompatible VLA types (PR #101261)

2024-08-20 Thread Andrew Sukach via cfe-commits
https://github.com/sookach updated https://github.com/llvm/llvm-project/pull/101261 >From 2666871e019dee2314933cc60bcb4ca27d7555ba Mon Sep 17 00:00:00 2001 From: Andrew Sukach Date: Tue, 30 Jul 2024 19:31:41 -0400 Subject: [PATCH] [clang] Improve diagnostics with incompatible VLA types --- ..

[clang] [clang] Improve diagnostics with incompatible VLA types (PR #101261)

2024-07-30 Thread Andrew Sukach via cfe-commits
https://github.com/sookach updated https://github.com/llvm/llvm-project/pull/101261 >From e7d15a3d29715e4922eb542d46cdc6d081ad740e Mon Sep 17 00:00:00 2001 From: Andrew Sukach Date: Tue, 30 Jul 2024 19:31:41 -0400 Subject: [PATCH] [clang] Improve diagnostics with incompatible VLA types --- ..

[clang] [clang] Improve diagnostics with incompatible VLA types (PR #101261)

2024-07-30 Thread Andrew Sukach via cfe-commits
https://github.com/sookach created https://github.com/llvm/llvm-project/pull/101261 This PR addresses #99914, by emitting a separate diagnostic for VLA's with the same bounds. @AaronBallman Let me know what you think. Thanks >From 667894f8e4e334e7fc32418bee95803138dfad40 Mon Sep 17 00:00:00

[clang] [clang][analyzer] Ignore try-statements in UnreachableCode checker (PR #91675)

2024-05-14 Thread Andrew Sukach via cfe-commits
soukatch wrote: Thanks for the review! https://github.com/llvm/llvm-project/pull/91675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Ignore try-statements in dead code checker (PR #91675)

2024-05-13 Thread Andrew Sukach via cfe-commits
https://github.com/soukatch updated https://github.com/llvm/llvm-project/pull/91675 >From 846be0552bd2da608fc1729e5928d85650e1ce06 Mon Sep 17 00:00:00 2001 From: Andrew Sukach Date: Thu, 9 May 2024 18:49:41 -0400 Subject: [PATCH] [clang][static analyzer] ignore try statements in dead code chec

[clang] [clang][analyzer] Ignore try-statements in dead code checker (PR #91675)

2024-05-13 Thread Andrew Sukach via cfe-commits
soukatch wrote: > To find which file you need to add your test, I created a new file altogether since I don't think any of the current one would fit the test. https://github.com/llvm/llvm-project/pull/91675 ___ cfe-commits mailing list cfe-commits@li

[clang] [clang][analyzer] Ignore try-statements in dead code checker (PR #91675)

2024-05-13 Thread Andrew Sukach via cfe-commits
https://github.com/soukatch updated https://github.com/llvm/llvm-project/pull/91675 >From 4ed555c81ae5b773361da22c0736f82fbf14c90d Mon Sep 17 00:00:00 2001 From: Andrew Sukach Date: Thu, 9 May 2024 18:49:41 -0400 Subject: [PATCH] [clang][static analyzer] ignore try statements in dead code chec

[clang] [clang][static analyzer] ignore try statements in dead code checker (PR #91675)

2024-05-10 Thread Andrew Sukach via cfe-commits
https://github.com/soukatch deleted https://github.com/llvm/llvm-project/pull/91675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][static analyzer] ignore try statements in dead code checker (PR #91675)

2024-05-09 Thread Andrew Sukach via cfe-commits
@@ -159,8 +159,10 @@ void UnreachableCodeChecker::checkEndAnalysis(ExplodedGraph &G, SL = DL.asLocation(); if (SR.isInvalid() || !SL.isValid()) continue; -} -else + + if (isa(S)) soukatch wrote: everything besides this if stat

[clang] [clang][static analyzer] ignore try statements in dead code checker (PR #91675)

2024-05-09 Thread Andrew Sukach via cfe-commits
https://github.com/soukatch deleted https://github.com/llvm/llvm-project/pull/91675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][static analyzer] ignore try statements in dead code checker (PR #91675)

2024-05-09 Thread Andrew Sukach via cfe-commits
soukatch wrote: @steakhal I believe you're the best person to tag :). https://github.com/llvm/llvm-project/pull/91675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][static analyzer] ignore try statements in dead code checker (PR #91675)

2024-05-09 Thread Andrew Sukach via cfe-commits
@@ -159,8 +159,10 @@ void UnreachableCodeChecker::checkEndAnalysis(ExplodedGraph &G, SL = DL.asLocation(); if (SR.isInvalid() || !SL.isValid()) continue; -} -else + + if (isa(S)) soukatch wrote: everything above this point is

[clang] [clang][static analyzer] ignore try statements in dead code checker (PR #91675)

2024-05-09 Thread Andrew Sukach via cfe-commits
https://github.com/soukatch created https://github.com/llvm/llvm-project/pull/91675 Fixes #90162. Simplest approach I could come up with was to skip cxxtry statements. Let me know if you have any suggestions. Thanks! >From e1fcdc37e52189abcdf8ce84ada463491d8b6c04 Mon Sep 17 00:00:00 2001 From:

[clang] [clang] MangledSymbol: remove pointless copy of vector (PR #90012)

2024-05-07 Thread Andrew Sukach via cfe-commits
soukatch wrote: Thank you everyone for the reviews! https://github.com/llvm/llvm-project/pull/90012 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [flang] [libc] [libclc] [libcxx] [libcxxabi] [lld] [lldb] [llvm] [mlir] [libc++] implement ranges::find_last (PR #91081)

2024-05-04 Thread Andrew Sukach via cfe-commits
https://github.com/soukatch closed https://github.com/llvm/llvm-project/pull/91081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] MangledSymbol: remove pointless copy of vector (PR #90012)

2024-05-03 Thread Andrew Sukach via cfe-commits
soukatch wrote: @AaronBallman would it be possible to get an approval while all the checks are green? Thanks! https://github.com/llvm/llvm-project/pull/90012 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[clang] [clang] MangledSymbol: remove pointless copy of vector (PR #90012)

2024-05-02 Thread Andrew Sukach via cfe-commits
https://github.com/soukatch updated https://github.com/llvm/llvm-project/pull/90012 >From 9007597af4f138d2744405bb7980fce4555d7508 Mon Sep 17 00:00:00 2001 From: Andrew Sukach Date: Wed, 24 Apr 2024 22:50:50 -0400 Subject: [PATCH 1/3] [clang] MangledSymbol: remove pointless copy of vector ---

[clang] [clang] MangledSymbol: remove pointless copy of vector (PR #90012)

2024-05-01 Thread Andrew Sukach via cfe-commits
https://github.com/soukatch updated https://github.com/llvm/llvm-project/pull/90012 >From 9007597af4f138d2744405bb7980fce4555d7508 Mon Sep 17 00:00:00 2001 From: Andrew Sukach Date: Wed, 24 Apr 2024 22:50:50 -0400 Subject: [PATCH 1/3] [clang] MangledSymbol: remove pointless copy of vector ---

[clang] [clang] MangledSymbol: remove pointless copy of vector (PR #90012)

2024-04-25 Thread Andrew Sukach via cfe-commits
https://github.com/soukatch updated https://github.com/llvm/llvm-project/pull/90012 >From 9007597af4f138d2744405bb7980fce4555d7508 Mon Sep 17 00:00:00 2001 From: Andrew Sukach Date: Wed, 24 Apr 2024 22:50:50 -0400 Subject: [PATCH 1/2] [clang] MangledSymbol: remove pointless copy of vector ---

[clang] [clang] MangledSymbol: remove pointless copy of vector (PR #90012)

2024-04-25 Thread Andrew Sukach via cfe-commits
https://github.com/soukatch updated https://github.com/llvm/llvm-project/pull/90012 >From 9007597af4f138d2744405bb7980fce4555d7508 Mon Sep 17 00:00:00 2001 From: Andrew Sukach Date: Wed, 24 Apr 2024 22:50:50 -0400 Subject: [PATCH] [clang] MangledSymbol: remove pointless copy of vector --- cla

[clang] [clang] MangledSymbol: remove pointless copy of vector (PR #90012)

2024-04-25 Thread Andrew Sukach via cfe-commits
https://github.com/soukatch updated https://github.com/llvm/llvm-project/pull/90012 >From b8e20a5a3e37ab9a657ac640b848f638387215fa Mon Sep 17 00:00:00 2001 From: Andrew Sukach Date: Wed, 24 Apr 2024 22:50:50 -0400 Subject: [PATCH 1/2] [clang] MangledSymbol: remove pointless copy of vector ---

[clang] [clang] MangledSymbol: remove pointless copy of vector (PR #90012)

2024-04-25 Thread Andrew Sukach via cfe-commits
soukatch wrote: Looking at the logs, and the error seems to be unrelated to the changes made https://buildkite.com/llvm-project/clang-ci/builds/16430#018f132d-506e-440c-b18b-fed98237def9/54-5446 https://github.com/llvm/llvm-project/pull/90012 ___ cfe-c

[clang] [clang] MangledSymbol: remove pointless copy of vector (PR #90012)

2024-04-24 Thread Andrew Sukach via cfe-commits
soukatch wrote: @dcb314 @shafik @EugeneZelenko Please let me know if this change looks good. Thanks! https://github.com/llvm/llvm-project/pull/90012 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[clang] [clang] MangledSymbol: remove pointless copy of vector (PR #90012)

2024-04-24 Thread Andrew Sukach via cfe-commits
https://github.com/soukatch created https://github.com/llvm/llvm-project/pull/90012 This pr addresses #87255 adds a std::move call to the names in MangledSymbol's constructor. >From b8e20a5a3e37ab9a657ac640b848f638387215fa Mon Sep 17 00:00:00 2001 From: Andrew Sukach Date: Wed, 24 Apr 2024 22