[PATCH] D22045: [X86] Support of no_caller_saved_registers attribute (Clang part)

aaboud abandoned this revision. aaboud marked an inline comment as not done. aaboud added a comment. Changes in this patch are being reviewed in a new patch https://reviews.llvm.org/D31871. https://reviews.llvm.org/D22045 ___ cfe-commits mailing li

[PATCH] D16135: Macro Debug Info support in Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rL294637: [DebugInfo] Added support to Clang FE for generating debug info for… (authored by aaboud). Changed prior to commit: https://reviews.llvm.org/D16135?vs=87819&id=87881#toc Repository: rL LLVM

[PATCH] D16135: Macro Debug Info support in Clang

aaboud updated this revision to Diff 87819. aaboud marked 2 inline comments as done. aaboud added a comment. Added test cases for driver debug info macro flags in test/Driver/debug-options.c Applied some changes to the documentation suggested by Ardian. https://reviews.llvm.org/D16135 Files:

[PATCH] D16135: Macro Debug Info support in Clang

aaboud added a comment. > How are you measuring the build time? Total time for, say "ninja clang" with > full parallelism? That'd be hard to measure the actual impact (since it could > be the link time or other things are dominating, etc). If you have a reliable > way to time (I'm assuming Inte

[PATCH] D16135: Macro Debug Info support in Clang

aaboud updated this revision to Diff 87796. aaboud added a comment. Added flag to control macro debug info generation: 1. -fdebug-macro (-fno-debug-macro) for Clang driver 2. -debug-info-macro for Clang compiler (-cc1) Also, made sure FE will discard this flag when debug info is not required, i.

[PATCH] D16135: Macro Debug Info support in Clang

aaboud added a comment. > How much does the build directory grow? > Is there any noticeable compile time regression? I build clang in release mode using GCC, then used that build to build clang in debug mode with "-fstandalone-debug" flag, one time with my changes and another time without my c

[PATCH] D16135: Macro Debug Info support in Clang

aaboud added a comment. In https://reviews.llvm.org/D16135#669416, @aprantl wrote: > In https://reviews.llvm.org/D16135#669045, @aaboud wrote: > > > Addressed Adrian last comments. > > Added a LIT tests that covers all the macro kinds: > > > > 1. built-in (define) > > 2. command-line (define, in

[PATCH] D16135: Macro Debug Info support in Clang

aaboud updated this revision to Diff 87408. aaboud marked 2 inline comments as done. aaboud added a comment. Addressed Adrian last comments. Added a LIT tests that covers all the macro kinds: 1. built-in (define) 2. command-line (define, include, undef) 3. main source (define, include, undef) Ch

[PATCH] D16135: Macro Debug Info support in Clang

aaboud updated this revision to Diff 87020. aaboud marked 4 inline comments as done. aaboud added a comment. Addressed Adrian's comments. Please, let me know if I missed any. Also, I improved the code and added explanation about the file inclusion structure that is being handled in the macro cal

[PATCH] D16135: Macro Debug Info support in Clang

aaboud added a comment. Thanks Adrian for the fast response. See some answers below. I will update the code and upload a new patch soon. Comment at: lib/CodeGen/MacroPPCallbacks.cpp:154 +StringRef SearchPath, StringRef RelativePath, const Module *Imported) { + // Only car

[PATCH] D16135: Macro Debug Info support in Clang

aaboud updated this revision to Diff 86669. aaboud marked an inline comment as done. aaboud added a comment. Address Adrian and Richard comments. Please, review the new patch and let me know if I need to change anything else. Thanks, Amjad https://reviews.llvm.org/D16135 Files: include/clan

[PATCH] D16135: Macro Debug Info support in Clang

aaboud marked 7 inline comments as done. aaboud added a comment. Thanks Adrian and Richard for the comments, I appreciate that. I am uploading a new patch that address most of the comments. Adrian, I answered some of your comments below. Thanks, Amjad Comment at: lib/CodeGen/

[PATCH] D16135: Macro Debug Info support in Clang

aaboud added a comment. Kindly reminder, I am still waiting for a review on this new patch. Thanks https://reviews.llvm.org/D16135 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D16135: Macro Debug Info support in Clang

aaboud added a comment. Richard, can you please review the new patch? https://reviews.llvm.org/D16135 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D16135: Macro Debug Info support in Clang

aaboud updated this revision to Diff 82696. aaboud added a comment. Herald added subscribers: mgorny, nemanjai. Improved code based on Richard's comments. Removed the change to ASTConsumer, now it does not need to know anything about PP consumer. However, I still needed to change the CodeGenerato

[PATCH] D27641: DebugInfo: Added support for Checksum debug info feature (Clang part)

This revision was automatically updated to reflect the committed changes. aaboud marked an inline comment as done. Closed by commit rL290515: [DebugInfo] Added support for Checksum debug info feature. (authored by aaboud). Changed prior to commit: https://reviews.llvm.org/D27641?vs=81953&id=824

[PATCH] D27641: DebugInfo: Added support for Checksum debug info feature (Clang part)

aaboud updated this revision to Diff 81953. aaboud marked 3 inline comments as done. aaboud added a comment. Addressed comments by Reid and David. https://reviews.llvm.org/D27641 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h test/CodeGen/Inputs/debug-info-file-checksum.c

[PATCH] D27641: DebugInfo: Added support for Checksum debug info feature (Clang part)

aaboud added a subscriber: bwyma. aaboud updated this revision to Diff 81640. aaboud added a comment. Moved getChecksum from SourceManager to CGDebugInfo. Also, now checksum is emitted only for CodeView. https://reviews.llvm.org/D27641 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugI

[PATCH] D27763: Debug Info: Modified DIBuilder::createCompileUnit() to take DIFile instead of FileName and Directory. (Clang part)

This revision was automatically updated to reflect the committed changes. Closed by commit rL289701: [DebugInfo] Changed DIBuilder::createCompileUnit() to take DIFile instead of… (authored by aaboud). Changed prior to commit: https://reviews.llvm.org/D27763?vs=81397&id=81438#toc Repository:

[PATCH] D27763: Debug Info: Modified DIBuilder::createCompileUnit() to take DIFile instead of FileName and Directory. (Clang part)

aaboud created this revision. aaboud added a reviewer: rnk. aaboud added a subscriber: cfe-commits. Changed DIBuilder::createCompileUnit() to take DIFile instead of FileName and Directory. This way it will be easier to expand DIFile (e.g., to contain checksum) without the need to modify the crea

[PATCH] D27641: DebugInfo: Added support for Checksum debug info feature (Clang part)

aaboud created this revision. aaboud added reviewers: rnk, probinson, rsmith. aaboud added a subscriber: cfe-commits. Resolve Bug 30978 . This patch contains changes in Clang to support Checksum debug info feature. https://reviews.llvm.org/D27641 Fi