[clang] [clang][cmake] Apply bolt optimizations as part of the clang target (PR #119896)

https://github.com/aaupov approved this pull request. Thank you, looks good overall. When you land, please monitor clang-bolt builder which exercises this logic. https://github.com/llvm/llvm-project/pull/119896 ___ cfe-commits mailing list cfe-commits

[clang] [clang][cmake] Apply bolt optimizations as part of the clang target (PR #119896)

https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/119896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][perf-training] Fix profiling with -DCLANG_BOLT=perf (PR #119117)

@@ -20,9 +21,13 @@ elif clang_bolt_mode == "perf": else: assert 0, "Unsupported CLANG_BOLT_MODE variable" -config.clang = perf_wrapper + os.path.realpath( +clang_nowrapper = os.path.realpath( lit.util.which(clang_binary, config.clang_tools_dir) ).replace("\\", "/") +

[clang] [clang][perf-training] Fix profiling with -DCLANG_BOLT=perf (PR #119117)

aaupov wrote: > @aaupov When we build llvm-support there is one perf.data file generate for > each cpp file compiled, so we end up without about 150 files. Is there some > way to merge those together before running perf2bolt? I see. The best way would be to run perf once so that all clang inv

[clang] [clang][perf-training] Fix profiling with -DCLANG_BOLT=perf (PR #119117)

aaupov wrote: > However, I'm wondering if maybe we should disable llvm-suppot and only run > hello-world with -DCLANG_BOLT=perf. Existing perf training is inadequate for collecting sampled profile – we simply don't get enough samples, and no-LBR mode further drops the performance. If we want

[clang] [clang][perf-training] Fix profiling with -DCLANG_BOLT=perf (PR #119117)

https://github.com/aaupov approved this pull request. LG https://github.com/llvm/llvm-project/pull/119117 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][perf-training] Fix clean command in perf-helper.py (PR #118978)

https://github.com/aaupov approved this pull request. https://github.com/llvm/llvm-project/pull/118978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [libc] [lld] [lldb] [llvm] [mlir] [BOLT] Match blocks with pseudo probes (PR #99891)

https://github.com/aaupov closed https://github.com/llvm/llvm-project/pull/99891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [libc] [lld] [lldb] [llvm] [mlir] [BOLT] Match blocks with pseudo probes (PR #99891)

aaupov wrote: > > > > > Ping @wlei-llvm > > > > > > > > > > > > Sorry for the delay. The new version addressed my last comment (with > > > > just minor nits). However, I didn't fully follow the new features > > > > related to `ProbeMatchSpecs` stuffs. Could you add more descriptions to > > >

[clang] [compiler-rt] [libc] [lld] [lldb] [llvm] [mlir] [BOLT] Match blocks with pseudo probes (PR #99891)

https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/99891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [libc] [lld] [lldb] [llvm] [mlir] [BOLT] Match blocks with pseudo probes (PR #99891)

https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/99891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED (PR #79942)

aaupov wrote: Ping @wlei-llvm @WenleiHe https://github.com/llvm/llvm-project/pull/79942 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED (PR #79942)

aaupov wrote: Ping @boomanaiden154, @WenleiHe, @wlei-llvm. I've updated the diff to use external training set (CLANG_PGO_TRAINING_DATA_SOURCE_DIR), and included performance testing results. https://github.com/llvm/llvm-project/pull/79942 ___ cfe-comm

[clang] [llvm] [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED (PR #79942)

https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/79942 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED (PR #79942)

https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/79942 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED (PR #79942)

https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/79942 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED (PR #79942)

https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/79942 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED (PR #79942)

https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/79942 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED (PR #79942)

https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/79942 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED (PR #79942)

https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/79942 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED (PR #79942)

https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/79942 >From a3a8054675f295c15e7a7e45f7aebd2223072964 Mon Sep 17 00:00:00 2001 From: Amir Ayupov Date: Wed, 19 Jul 2023 20:30:29 -0700 Subject: [PATCH 1/2] [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED B

[clang] [llvm] [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED (PR #79942)

https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/79942 >From a3a8054675f295c15e7a7e45f7aebd2223072964 Mon Sep 17 00:00:00 2001 From: Amir Ayupov Date: Wed, 19 Jul 2023 20:30:29 -0700 Subject: [PATCH] [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED Build

[clang] d61b259 - [Clang-BOLT] Drop CDSplit flag

Author: Amir Ayupov Date: 2024-09-23T08:15:05-07:00 New Revision: d61b2590f8e360695a5298311855c8649337969f URL: https://github.com/llvm/llvm-project/commit/d61b2590f8e360695a5298311855c8649337969f DIFF: https://github.com/llvm/llvm-project/commit/d61b2590f8e360695a5298311855c8649337969f.diff L

[clang] [llvm] [CMake] Preserve clang-prebolt (PR #109351)

aaupov wrote: > @aaupov this happens on AArch64 target, and only with -split-strategy=cdsplit > enabled. Changing it to profile2, for example, fixes the issue Thanks for clarification. I'll drop cdsplit as we never tested it on AArch64. ARM clang-bolt buildbot hasn't picked this change up yet

[clang] [llvm] [CMake] Preserve clang-prebolt (PR #109351)

aaupov wrote: > This commit is breaking LTO-PGO-BOLT build while optimizing clang with BOLT. > > > > ``` > > [3064/3065] Merging BOLT fdata > > Using legacy profile format. > > Profile from 2 files merged. > > [3064/3065] Optimizing Clang with BOLT > > BOLT-INFO: shared object or positio

[clang] [llvm] [CMake] Preserve clang-prebolt (PR #109351)

https://github.com/aaupov closed https://github.com/llvm/llvm-project/pull/109351 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [CMake] Preserve clang-prebolt (PR #109351)

https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/109351 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED (PR #79942)

https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/79942 >From 2a5a3f2f55bd2b7479278fa72f6f05e54033532c Mon Sep 17 00:00:00 2001 From: Amir Ayupov Date: Wed, 19 Jul 2023 20:30:29 -0700 Subject: [PATCH] [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED Build

[clang] [llvm] [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED (PR #79942)

https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/79942 >From efac76027bd9294d734c3eee77ad582ad0fa9ebe Mon Sep 17 00:00:00 2001 From: Amir Ayupov Date: Wed, 19 Jul 2023 20:30:29 -0700 Subject: [PATCH] [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED Build

[clang] [lldb] [llvm] [BOLT] Drop blocks without profile in BAT YAML (PR #107970)

https://github.com/aaupov closed https://github.com/llvm/llvm-project/pull/107970 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [llvm] [BOLT] Drop blocks without profile in BAT YAML (PR #107970)

https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/107970 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [llvm] [BOLT] Drop blocks without profile in BAT YAML (PR #107970)

https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/107970 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [libc] [libcxx] [lld] [lldb] [llvm] [mlir] [BOLT] Add profile-use-pseudo-probes option (PR #100299)

https://github.com/aaupov closed https://github.com/llvm/llvm-project/pull/100299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [libc] [libcxx] [lld] [lldb] [llvm] [mlir] [BOLT] Add profile-use-pseudo-probes option (PR #100299)

https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/100299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [libc] [libcxx] [lld] [lldb] [llvm] [mlir] [BOLT] Support more than two jump table parents (PR #99988)

https://github.com/aaupov closed https://github.com/llvm/llvm-project/pull/99988 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [libc] [libcxx] [lld] [lldb] [llvm] [mlir] [BOLT] Support more than two jump table parents (PR #99988)

https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/99988 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [libc] [libcxx] [lld] [lldb] [llvm] [mlir] [BOLT][NFC] Track fragment relationships using EquivalenceClasses (PR #99979)

https://github.com/aaupov closed https://github.com/llvm/llvm-project/pull/99979 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [libc] [libcxx] [lld] [lldb] [llvm] [mlir] [BOLT][NFC] Track fragment relationships using EquivalenceClasses (PR #99979)

https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/99979 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [compiler-rt] [flang] [llvm] [BOLT][BAT] Add support for three-way split functions (PR #93760)

https://github.com/aaupov closed https://github.com/llvm/llvm-project/pull/93760 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [compiler-rt] [flang] [llvm] [BOLT][BAT] Add support for three-way split functions (PR #93760)

https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/93760 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [compiler-rt] [flang] [llvm] [BOLT][BAT] Add support for three-way split functions (PR #93760)

https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/93760 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [lldb] [llvm] [mlir] [BOLT][BAT] Add entries for deleted basic blocks (PR #91906)

aaupov wrote: The entries for deleted basic blocks won't participate in `BAT::getFallthroughsInTrace` because trace boundary is looked up by output offsets: https://github.com/llvm/llvm-project/blob/098c6dfa8157681699a71fce9e3d94515e66311f/bolt/lib/Profile/BoltAddressTranslation.cpp#L529-L540

[clang] [libcxx] [lldb] [llvm] [mlir] [BOLT][BAT] Add entries for deleted basic blocks (PR #91906)

https://github.com/aaupov closed https://github.com/llvm/llvm-project/pull/91906 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [lldb] [llvm] [mlir] [BOLT][BAT] Add entries for deleted basic blocks (PR #91906)

aaupov wrote: > Could you elaborate a bit better on why do we need a deleted block to be > present in the table? My memory fails me, aren't we using the translation > table just to map samples collected on the bolted binary? Where do the > deleted blocks become a problem? > > Other than the m

[clang] [clang-tools-extra] [compiler-rt] [flang] [libcxx] [libcxxabi] [lld] [lldb] [llvm] [mlir] [BOLT] Ignore special symbols as function aliases in updateELFSymbolTable (PR #92713)

https://github.com/aaupov closed https://github.com/llvm/llvm-project/pull/92713 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [compiler-rt] [flang] [libcxx] [libcxxabi] [lld] [lldb] [llvm] [mlir] [BOLT] Ignore special symbols as function aliases in updateELFSymbolTable (PR #92713)

https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/92713 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [lldb] [llvm] [mlir] [BOLT][BAT] Add entries for deleted basic blocks (PR #91906)

https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/91906 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [llvm] [BOLT][NFC] Rename DataAggregator::BranchInfo to TakenBranchInfo (PR #92017)

https://github.com/aaupov closed https://github.com/llvm/llvm-project/pull/92017 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [llvm] [BOLT][NFC] Rename DataAggregator::BranchInfo to TakenBranchInfo (PR #92017)

https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/92017 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [flang] [lld] [llvm] Use StringRef::operator== instead of StringRef::equals (NFC) (PR #91864)

https://github.com/aaupov approved this pull request. BOLT changes LGTM https://github.com/llvm/llvm-project/pull/91864 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [llvm] [BOLT] Set entry counts in BAT YAML profile (PR #91775)

https://github.com/aaupov closed https://github.com/llvm/llvm-project/pull/91775 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [llvm] [BOLT] Set entry counts in BAT YAML profile (PR #91775)

https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/91775 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [llvm] [BOLT] Use disambiguated local names in BAT YAML (PR #91773)

https://github.com/aaupov closed https://github.com/llvm/llvm-project/pull/91773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [llvm] [BOLT] Use disambiguated local names in BAT YAML (PR #91773)

https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/91773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED (PR #79942)

https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/79942 >From cb724ca7d7740e828934c6527ca188cfbbb78c0c Mon Sep 17 00:00:00 2001 From: Amir Ayupov Date: Wed, 19 Jul 2023 20:30:29 -0700 Subject: [PATCH] [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED Build

[llvm] [clang] [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED (PR #79942)

https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/79942 >From 63904124dc6c6cd9b855046fac3ad1a5e72d60b7 Mon Sep 17 00:00:00 2001 From: Amir Ayupov Date: Wed, 19 Jul 2023 20:30:29 -0700 Subject: [PATCH 1/4] [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED B

[llvm] [clang] [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED (PR #79942)

https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/79942 >From 63904124dc6c6cd9b855046fac3ad1a5e72d60b7 Mon Sep 17 00:00:00 2001 From: Amir Ayupov Date: Wed, 19 Jul 2023 20:30:29 -0700 Subject: [PATCH 1/3] [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED B

[clang] [clang-tools-extra] [llvm] [CMake][PGO] Add option for using an external project to generate profile data (PR #78879)

https://github.com/aaupov approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/78879 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [CMake][PGO] Add option for using an external project to generate profile data (PR #78879)

@@ -11,11 +15,11 @@ if(LLVM_BUILD_INSTRUMENTED) add_lit_testsuite(generate-profraw "Generating clang PGO data" ${CMAKE_CURRENT_BINARY_DIR}/pgo-data/ EXCLUDE_FROM_CHECK_ALL -DEPENDS clang clear-profraw ${CLANG_PERF_TRAINING_DEPS} +DEPENDS clang clear-profraw ${

[llvm] [clang] [CMake][PGO] Add option for using an external project to generate profile data (PR #78879)

@@ -2,7 +2,7 @@ set(CMAKE_BUILD_TYPE RELEASE CACHE STRING "") set(CLANG_ENABLE_BOOTSTRAP ON CACHE BOOL "") set(LLVM_ENABLE_PROJECTS "clang;lld" CACHE STRING "") -set(LLVM_ENABLE_RUNTIMES "compiler-rt;libcxx;libcxxabi" CACHE STRING "") +set(LLVM_ENABLE_RUNTIMES "compiler-rt;lib

[llvm] [clang] [CMake][PGO] Add option for using an external project to generate profile data (PR #78879)

aaupov wrote: I'm in favor of this change especially in context of CSSPGO profiling (https://github.com/llvm/llvm-project/pull/79942) and BOLT LBR profiling (https://github.com/llvm/llvm-project/pull/69133). https://github.com/llvm/llvm-project/pull/78879 __

[llvm] [clang] [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED (PR #79942)

https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/79942 >From 90686f2cd5e210f9ca974c10f8c1224a825c1315 Mon Sep 17 00:00:00 2001 From: Amir Ayupov Date: Wed, 19 Jul 2023 20:30:29 -0700 Subject: [PATCH 1/3] [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED B

[llvm] [clang] [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED (PR #79942)

aaupov wrote: Linking the preprint of the paper accepted to CGO'24 which has a CSSPGO performance comparison with AutoFDO and Instr PGO (Fig. 6): https://htyu.github.io/paper/Revamping_Sampling_based_PGO_with_Context_sensitivity_and_Pseudo_instrumentation_preprint.pdf https://github.com/llvm/l

[llvm] [clang] [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED (PR #79942)

aaupov wrote: > Do you have benchmarks on how well this performs relative to standard IRPGO > (or on top of it)? Couple of things to untangle here: 1. In general, CSSPGO is meant as a more practical alternative for IRPGO thanks to i) the use of sampled profile, ii) context-sensitivity. However

[llvm] [clang] [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED (PR #79942)

https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/79942 >From 90686f2cd5e210f9ca974c10f8c1224a825c1315 Mon Sep 17 00:00:00 2001 From: Amir Ayupov Date: Wed, 19 Jul 2023 20:30:29 -0700 Subject: [PATCH 1/2] [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED B

[llvm] [clang] [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED (PR #79942)

https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/79942 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED (PR #79942)

https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/79942 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED (PR #79942)

https://github.com/aaupov created https://github.com/llvm/llvm-project/pull/79942 Build on Clang-BOLT infrastructure to collect sample profiles for CSSPGO. Add clang/cmake/caches/CSSPGO.cmake to automate CSSPGO Clang build. Differential Revision: https://reviews.llvm.org/D155419 Test Plan: Add

[clang] [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options (PR #69133)

aaupov wrote: Final update: - [clang-hip-vega20](https://lab.llvm.org/buildbot/#/builders/165): green https://lab.llvm.org/buildbot/#/builders/165/builds/48052 https://github.com/llvm/llvm-project/pull/69133 ___ cfe-commits mailing list cfe-commits@li

[clang] [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options (PR #69133)

aaupov wrote: Status update: - [sanitizer-windows](https://lab.llvm.org/buildbot/#/builders/127): back to green starting with https://lab.llvm.org/buildbot/#/builders/127/builds/61505 - [libc-aarch64-ubuntu-fullbuild-dbg](https://lab.llvm.org/buildbot/#/builders/223): green https://lab.llvm.or

[clang] [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options (PR #69133)

aaupov wrote: This issue with incremental builds is explicitly mentioned in [HowToAddABuilder](https://llvm.org/docs/HowToAddABuilder.html): > Use CCache and NOT incremental builds Using ccache materially improves average build times. Incremental builds can be slightly faster, but introduce th

[clang] [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options (PR #69133)

aaupov wrote: Status of the builders that reported breakage: - [reverse-iteration](https://lab.llvm.org/buildbot/#/builders/54): https://lab.llvm.org/buildbot/#/builders/54/builds/8671 broken, https://lab.llvm.org/buildbot/#/builders/54/builds/8672 green, breakage was unrelated (unresolved tes

[clang] [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options (PR #69133)

aaupov wrote: These are all annotated builders. I tried triggering rebuilds with clean build dir through buildbot UI but it didn't have an effect. I don't think it's a reasonable expectation that every change must configure cleanly from an existing build directory. https://github.com/llvm/llv

[clang] 5a5ce01 - Reland [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options (#69133)

Author: Amir Ayupov Date: 2024-01-27T19:01:40-08:00 New Revision: 5a5ce012e4de627c52efa1638993fd23c5e74afa URL: https://github.com/llvm/llvm-project/commit/5a5ce012e4de627c52efa1638993fd23c5e74afa DIFF: https://github.com/llvm/llvm-project/commit/5a5ce012e4de627c52efa1638993fd23c5e74afa.diff L

[libcxx] [llvm] [clang-tools-extra] [clang] [lldb] [flang] [openmp] [libc] [mlir] [BOLT] Deduplicate equal offsets in BAT (PR #76905)

https://github.com/aaupov closed https://github.com/llvm/llvm-project/pull/76905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [llvm] [clang-tools-extra] [clang] [lldb] [flang] [openmp] [libc] [mlir] [BOLT] Deduplicate equal offsets in BAT (PR #76905)

https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/76905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options (PR #69133)

aaupov wrote: Reverted. Strangely I couldn't repro from https://lab.llvm.org/buildbot/#/builders/225/builds/29950/ the failure locally. But will get to the bottom of it. https://github.com/llvm/llvm-project/pull/69133 ___ cfe-commits mailing list cfe

[clang] 6953b36 - Revert "Reland [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options (#69133)"

Author: Amir Ayupov Date: 2024-01-22T14:56:43-08:00 New Revision: 6953b367027e4234607a6718a0a1d57eb52ef57e URL: https://github.com/llvm/llvm-project/commit/6953b367027e4234607a6718a0a1d57eb52ef57e DIFF: https://github.com/llvm/llvm-project/commit/6953b367027e4234607a6718a0a1d57eb52ef57e.diff L

[clang] b83b8d3 - Reland [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options (#69133)

Author: Amir Ayupov Date: 2024-01-22T14:47:42-08:00 New Revision: b83b8d3fd17885438b0ea154e07088d877d293a8 URL: https://github.com/llvm/llvm-project/commit/b83b8d3fd17885438b0ea154e07088d877d293a8 DIFF: https://github.com/llvm/llvm-project/commit/b83b8d3fd17885438b0ea154e07088d877d293a8.diff L

[clang] [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options (PR #69133)

https://github.com/aaupov closed https://github.com/llvm/llvm-project/pull/69133 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9fec33a - Revert "[BOLT] Fix unconditional output of boltedcollection in merge-fdata (#78653)"

Author: Amir Ayupov Date: 2024-01-18T19:59:09-08:00 New Revision: 9fec33aadc56c8c4ad3778a92dc0aaa3201a63ae URL: https://github.com/llvm/llvm-project/commit/9fec33aadc56c8c4ad3778a92dc0aaa3201a63ae DIFF: https://github.com/llvm/llvm-project/commit/9fec33aadc56c8c4ad3778a92dc0aaa3201a63ae.diff L

[lldb] [clang] [llvm] [BOLT] Fix unconditional output of boltedcollection in merge-fdata (PR #78653)

https://github.com/aaupov closed https://github.com/llvm/llvm-project/pull/78653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lldb] [clang] [llvm] [BOLT] Fix unconditional output of boltedcollection in merge-fdata (PR #78653)

https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/78653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [flang] [clang] [libcxx] [mlir] [llvm] [openmp] [libc] [lldb] [BOLT] Use continuous output addresses in delta encoding in BAT (PR #76904)

https://github.com/aaupov closed https://github.com/llvm/llvm-project/pull/76904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [flang] [clang] [libcxx] [mlir] [llvm] [openmp] [libc] [lldb] [BOLT] Use continuous output addresses in delta encoding in BAT (PR #76904)

https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/76904 >From 2027bc7dc00395884c3bd4da21bbb79d079293fc Mon Sep 17 00:00:00 2001 From: Amir Ayupov Date: Wed, 3 Jan 2024 21:25:27 -0800 Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20ch?= =?UTF-8?

[clang] [lldb] [libcxx] [mlir] [openmp] [clang-tools-extra] [flang] [libc] [llvm] [BOLT] Use continuous output addresses in delta encoding in BAT (PR #76904)

https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/76904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[openmp] [clang-tools-extra] [libc] [flang] [llvm] [libcxx] [clang] [mlir] [lldb] [BOLT] Use continuous output addresses in delta encoding in BAT (PR #76904)

https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/76904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lldb] [clang-tools-extra] [flang] [openmp] [libcxx] [clang] [libc] [llvm] [mlir] [BOLT] Embed cold mapping info into function entry in BAT (PR #76903)

https://github.com/aaupov closed https://github.com/llvm/llvm-project/pull/76903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lldb] [clang-tools-extra] [flang] [openmp] [libcxx] [clang] [libc] [llvm] [mlir] [BOLT] Embed cold mapping info into function entry in BAT (PR #76903)

https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/76903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang-tools-extra] [lldb] [clang] [libc] [libcxx] [mlir] [openmp] [flang] [BOLT] Delta-encode function start addresses in BAT (PR #76902)

https://github.com/aaupov closed https://github.com/llvm/llvm-project/pull/76902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang-tools-extra] [lldb] [clang] [libc] [libcxx] [mlir] [openmp] [flang] [BOLT] Delta-encode function start addresses in BAT (PR #76902)

https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/76902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[lldb] [libc] [flang] [llvm] [libcxx] [mlir] [clang] [clang-tools-extra] [BOLT] Delta-encode function start addresses in BAT (PR #76902)

https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/76902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[mlir] [lldb] [clang] [flang] [libc] [llvm] [clang-tools-extra] [libcxx] [BOLT] Delta-encode offsets in BAT (PR #76900)

https://github.com/aaupov closed https://github.com/llvm/llvm-project/pull/76900 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[mlir] [lldb] [clang] [flang] [libc] [llvm] [clang-tools-extra] [libcxx] [BOLT] Delta-encode offsets in BAT (PR #76900)

https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/76900 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [libc] [clang-tools-extra] [llvm] [lldb] [clang] [mlir] [BOLT][NFC] Print BAT section size (PR #76897)

https://github.com/aaupov closed https://github.com/llvm/llvm-project/pull/76897 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [libcxx] [clang-tools-extra] [mlir] [lldb] [libc] [BOLT][NFC] Print BAT section size (PR #76897)

https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/76897 >From 5106f9e921aa426cf3272277c4aee4bdf76215e8 Mon Sep 17 00:00:00 2001 From: Amir Ayupov Date: Wed, 3 Jan 2024 21:25:02 -0800 Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?= =?UTF-8?

[llvm] [clang] [libcxx] [clang-tools-extra] [mlir] [lldb] [libc] [BOLT][NFC] Print BAT section size (PR #76897)

https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/76897 >From 5106f9e921aa426cf3272277c4aee4bdf76215e8 Mon Sep 17 00:00:00 2001 From: Amir Ayupov Date: Wed, 3 Jan 2024 21:25:02 -0800 Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?= =?UTF-8?

[clang] [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options (PR #69133)

https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/69133 >From 1ca9ce9ef3e90e3d24aea3945ae2d5129682621d Mon Sep 17 00:00:00 2001 From: Amir Aupov Date: Mon, 16 Oct 2023 01:08:28 +0200 Subject: [PATCH 1/3] [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT opti

[clang] [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options (PR #69133)

https://github.com/aaupov updated https://github.com/llvm/llvm-project/pull/69133 >From 96e644279ccec1970c42cca89c05aac186b872e6 Mon Sep 17 00:00:00 2001 From: Amir Aupov Date: Mon, 16 Oct 2023 01:08:28 +0200 Subject: [PATCH 1/3] [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT opti

[clang] [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options (PR #69133)

aaupov wrote: @petrhosek – thank you for a review! https://github.com/llvm/llvm-project/pull/69133 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >