Author: Alexey Sotkin
Date: 2020-02-05T14:55:32+03:00
New Revision: f780e15caf1bed0a9fbc87fde70bd5ab3d80a439
URL:
https://github.com/llvm/llvm-project/commit/f780e15caf1bed0a9fbc87fde70bd5ab3d80a439
DIFF:
https://github.com/llvm/llvm-project/commit/f780e15caf1bed0a9fbc87fde70bd5ab3d80a439.diff
Author: alexeysotkin
Date: Wed Apr 10 23:18:17 2019
New Revision: 358151
URL: http://llvm.org/viewvc/llvm-project?rev=358151&view=rev
Log:
[OpenCL] Re-fix invalid address space generation for clk_event_t arguments of
enqueue_kernel builtin function
Summary:
https://reviews.llvm.org/D53809 fixed
AlexeySotkin added inline comments.
Comment at: lib/CodeGen/CGDecl.cpp:1272
+if (getLangOpts().OpenCL) {
+ UA = llvm::GlobalValue::UnnamedAddr::None;
+ AS = CGM.getContext().getTargetAddressSpace(LangAS::opencl_constant);
Anastasia wrote:
> AlexeySo
AlexeySotkin updated this revision to Diff 75893.
AlexeySotkin added a comment.
Setting UnnamedAddr to Global
https://reviews.llvm.org/D25305
Files:
lib/CodeGen/CGDecl.cpp
test/CodeGenOpenCL/private-array-initialization.cl
Index: test/CodeGenOpenCL/private-array-initialization.cl
AlexeySotkin added inline comments.
Comment at: lib/CodeGen/CGDecl.cpp:1272
+if (getLangOpts().OpenCL) {
+ UA = llvm::GlobalValue::UnnamedAddr::None;
+ AS = CGM.getContext().getTargetAddressSpace(LangAS::opencl_constant);
bader wrote:
> Anastasia wr
AlexeySotkin added inline comments.
Comment at: lib/CodeGen/CGDecl.cpp:1272
+if (getLangOpts().OpenCL) {
+ UA = llvm::GlobalValue::UnnamedAddr::None;
+ AS = CGM.getContext().getTargetAddressSpace(LangAS::opencl_constant);
Anastasia wrote:
> Why this
AlexeySotkin added a comment.
Now there should be both :)
https://reviews.llvm.org/D25305
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AlexeySotkin updated this revision to Diff 74693.
AlexeySotkin added a comment.
Squashing commits
https://reviews.llvm.org/D25305
Files:
lib/CodeGen/CGDecl.cpp
test/CodeGenOpenCL/private-array-initialization.cl
Index: test/CodeGenOpenCL/private-array-initialization.cl
AlexeySotkin removed rL LLVM as the repository for this revision.
AlexeySotkin updated this revision to Diff 74482.
AlexeySotkin added a comment.
Adding test checking address space of array initializer
https://reviews.llvm.org/D25305
Files:
test/CodeGenOpenCL/private-array-initialization.cl