>>}
>> };
>>
>>
>>
>> ___
>> cfe-commits mailing list
>> cfe-commits@lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>>
>
>
> _
; I added this assertion...I am trying to figure out why we are hitting it.
>
>
>
> I am not convinced that we should do a total revert.
>
>
>
> Regards,
>
> Amjad
>
>
>
> *From:* Alexey Samsonov [mailto:vonos...@gmail.com]
> *Sent:* Thursday, March 24, 2016
union-vars.cpp",
> +// CHECK: !DIDerivedType(tag: DW_TAG_member, name: "i", scope: ![[UNION]],
> +// CHECK: !DIDerivedType(tag: DW_TAG_member, name: "c", scope: ![[UNION]],
> // CHECK: !DIGlobalVariable(name: "c",
samsonov added a comment.
Cool, great to see this coming. I'll let Kuba sign this off.
Comment at: test/Driver/fsanitize.c:220
@@ -219,1 +219,3 @@
+// RUN: %clang -target x86_64-apple-darwin10 -fsanitize=thread %s -### 2>&1 |
FileCheck %s --check-prefix=CHECK-TSAN-X86-64-DARW
t;>>}
> >>>> +
> >>>> + // FIXME: Override value name discarding when sanitizers are used
> >>>> because the
> >>>> + // backend passes depend on the name of the alloca in order to
> print
> >>>> out
> >>>> + // names.
> >>>> + Res.getCodeGenOpts().DiscardValueNames &=
> >>>> Res.getLangOpts()->Sanitize.empty();
> >>>> +
> >>>>// FIXME: ParsePreprocessorArgs uses the FileManager to read the
> >>>> contents of
> >>>>// PCH file and find the original header name. Remove the need to
> do
> >>>> that in
> >>>>// ParsePreprocessorArgs and remove the FileManager
> >>>>
> >>>>
> >>>> ___
> >>>> cfe-commits mailing list
> >>>> cfe-commits@lists.llvm.org
> >>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
> >>>
> >>>
> >>> ___
> >>> cfe-commits mailing list
> >>> cfe-commits@lists.llvm.org
> >>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
> >>>
> >>
> ___
> cfe-commits mailing list
> cfe-commits@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
--
Alexey Samsonov
vonos...@gmail.com
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
he
> contents of
> >// PCH file and find the original header name. Remove the need to do
> that in
> >// ParsePreprocessorArgs and remove the FileManager
> >
> >
> > ___
> > cfe-commits mailing list
> > cfe-commits@lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
> ___
> cfe-commits mailing list
> cfe-commits@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
>
--
Alexey Samsonov
vonos...@gmail.com
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: samsonov
Date: Wed Mar 9 18:20:37 2016
New Revision: 263081
URL: http://llvm.org/viewvc/llvm-project?rev=263081&view=rev
Log:
EmitCXXStructorCall -> EmitCXXDestructorCall. NFC.
This function is only used in Microsoft ABI and only to emit
destructors. Rename/simplify it accordingly.
Modi
Author: samsonov
Date: Wed Mar 9 18:20:33 2016
New Revision: 263080
URL: http://llvm.org/viewvc/llvm-project?rev=263080&view=rev
Log:
Remove unused function arguments. NFC.
Modified:
cfe/trunk/lib/CodeGen/CGExprCXX.cpp
Modified: cfe/trunk/lib/CodeGen/CGExprCXX.cpp
URL:
http://llvm.org/view
Author: samsonov
Date: Fri Feb 12 19:02:59 2016
New Revision: 260779
URL: http://llvm.org/viewvc/llvm-project?rev=260779&view=rev
Log:
Disable two tests that use a lot of stack under ASan.
Modified:
cfe/trunk/test/Index/index-many-call-ops.cpp
cfe/trunk/test/Index/index-many-logical-ops.c
; +#define __CORRECT_ISO_CPP_STRING_H_PROTO
> +#endif
> +
> #include_next
>
> // MSVCRT, GNU libc and its derivates already have the correct prototype
> in
>
>
> ___
> cfe-commits mailing list
> cfe-commits@lists.l
samsonov accepted this revision.
samsonov added a reviewer: samsonov.
samsonov added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/CodeGen/CGClass.cpp:2608
@@ -2607,3 +2607,3 @@
auto TypeId = CGM.CreateCfiIdForTypeMetadata(MD);
if (CGM.ge
samsonov added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:2642
@@ +2641,3 @@
+ llvm::MDString::get(CGM.getLLVMContext(), "all-vtables"));
+ llvm::Value *ValidVtable = Builder.CreateZExt(
+ Builder.CreateCall(CGM.getIntrinsic(llvm::Intrinsic::bitset_test),
-
samsonov added a subscriber: samsonov.
Comment at: lib/CodeGen/CGExpr.cpp:2494
@@ +2493,3 @@
+ llvm::Value *ValidVtable = nullptr;
+ if (CheckAndAppendValidVtable) {
+llvm::Value *AllVtables = llvm::MetadataAsValue::get(
This is really ugly. Why are you not
Author: samsonov
Date: Fri Jan 29 19:11:42 2016
New Revision: 259281
URL: http://llvm.org/viewvc/llvm-project?rev=259281&view=rev
Log:
[docs] Remove references to autoconf build.
Modified:
libcxx/trunk/docs/BuildingLibcxx.rst
Modified: libcxx/trunk/docs/BuildingLibcxx.rst
URL:
http://llvm.o
Author: samsonov
Date: Fri Jan 29 18:54:42 2016
New Revision: 259278
URL: http://llvm.org/viewvc/llvm-project?rev=259278&view=rev
Log:
Remove references to autotools build.
Modified:
cfe/trunk/CODE_OWNERS.TXT
cfe/trunk/www/get_started.html
Modified: cfe/trunk/CODE_OWNERS.TXT
URL:
http:/
On Fri, Jan 29, 2016 at 3:16 PM, Hans Wennborg wrote:
> Yes, that seems like a good idea. Go ahead and merge (or let me know
> if you'd prefer me to do it).
>
I'd appreciate if you could do it. Thanks!
>
> On Fri, Jan 29, 2016 at 3:14 PM, Alexey Samsonov
> wrot
Hans, do you think it makes sense to merge this patch into 3.8?
On Fri, Jan 29, 2016 at 3:07 PM, Alexey Samsonov via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: samsonov
> Date: Fri Jan 29 17:07:14 2016
> New Revision: 259260
>
> URL: http://llvm.org/viewvc/ll
Author: samsonov
Date: Fri Jan 29 17:07:14 2016
New Revision: 259260
URL: http://llvm.org/viewvc/llvm-project?rev=259260&view=rev
Log:
[UBSan] Add documentation for runtime issue suppression.
Modified:
cfe/trunk/docs/UndefinedBehaviorSanitizer.rst
Modified: cfe/trunk/docs/UndefinedBehaviorSa
n Thu, Jan 21, 2016 at 2:09 PM, Alexey Samsonov
> wrote:
>
>> On Thu, Jan 21, 2016 at 10:58 AM, Reid Kleckner wrote:
>>
>>> On Thu, Jan 21, 2016 at 10:47 AM, Nico Weber
>>> wrote:
>>>
>>>> Oh, ok, let's not depend on lld then. So, we ne
samsonov accepted this revision.
samsonov added a reviewer: samsonov.
samsonov added a comment.
LGTM
Comment at: lib/Driver/ToolChains.cpp:339
@@ +338,3 @@
+ }
+}
+
You might need `llvm_unreachable` at the very end to suppress GCC warnings
(http://llvm.org/doc
Author: samsonov
Date: Thu Jan 21 19:35:45 2016
New Revision: 258476
URL: http://llvm.org/viewvc/llvm-project?rev=258476&view=rev
Log:
[Docs] Slightly update LSan documentation.
Modified:
cfe/trunk/docs/AddressSanitizer.rst
cfe/trunk/docs/LeakSanitizer.rst
Modified: cfe/trunk/docs/Addres
f llvm-symbolizer we expect
to work explicitly.
> This will cause the sanitizers to try calling into dbghelp, which will
> probably work. It doesn't return PDB column info or work with dwarf, which
> is why we try llvm-symbolizer first. I think I made thi
samsonov added a comment.
In http://reviews.llvm.org/D15225#328218, @zaks.anna wrote:
> > I see, so essentially you want to use a different approach for determining
> > sanitizer availability (on OS X for now): if the library is present, then
> > we support
>
> > sanitizer, otherwise we don't
On Thu, Jan 21, 2016 at 10:20 AM, Nico Weber wrote:
> On Thu, Jan 21, 2016 at 1:19 PM, Alexey Samsonov
> wrote:
>
>>
>> On Wed, Jan 20, 2016 at 12:42 PM, Nico Weber wrote:
>>
>>> thakis added a comment.
>>>
>>> After some more debugging, t
samsonov added a comment.
Thanks.
Comment at: lib/Driver/ToolChains.cpp:322
@@ -321,1 +321,3 @@
+StringRef Darwin::getOSLibraryNameSuffix() const {
+ if (isTargetMacOS())
Fun fact: if TargetPlatform is `TvOSSimulator`, this function will return
`iossim` beca
y. Maybe, we can add a compiler
flag to force Clang emit Dwarf data on Windows in our compiler-rt test
suites?
>
>
> Repository:
> rL LLVM
>
> http://reviews.llvm.org/D15363
>
>
>
>
--
Alexey Samsonov
vonos...@gmail.com
___
samsonov added a comment.
Sorry for delay.
Comment at: lib/CodeGen/CGExpr.cpp:2543
@@ +2542,3 @@
+ // RE: Bug: 25682
+ if(!CGM.getCodeGenOpts().MergeTraps ||
!CGM.getCodeGenOpts().OptimizationLevel || !TrapBB) {
+// If we aren't merging traps, set the function to not be o
samsonov added a comment.
Sorry, lost track of this.
Comment at: lib/Driver/ToolChains.cpp:368
@@ +367,3 @@
+ StringRef OS = "";
+ if (isTargetMacOS())
+OS = "osx";
zaks.anna wrote:
> samsonov wrote:
> > Wait, this looks horrible. Can we teach toolchain to
, so does """c:\foo""".
> \"c:\foo\" confuses lit enough that it tries to call lit.util.warning()
> which doesn't exist.
>
> I've XFAIL'd the test on win32 in 256307 for now. Please take a look when
> you're back. Maybe teaching
On Fri, Dec 18, 2015 at 3:20 PM, Rafael Espíndola <
rafael.espind...@gmail.com> wrote:
> On 18 December 2015 at 18:13, Alexey Samsonov wrote:
> > samsonov added a comment.
> >
> > In http://reviews.llvm.org/D15598#314127, @rafael wrote:
> >
> >>
samsonov added a comment.
In http://reviews.llvm.org/D15598#314127, @rafael wrote:
> I am not sure what is "expected" is here:
Interesting.
I was assuming that Clang tends to understand "-lstdc++" as a special argument
that says "link against C++ standard library", not "link against
libstdc++
This revision was automatically updated to reflect the committed changes.
Closed by commit rL256018: [UBSan] Implement runtime suppressions (PR25066).
(authored by samsonov).
Changed prior to commit:
http://reviews.llvm.org/D15363?vs=42250&id=43254#toc
Repository:
rL LLVM
http://reviews.llv
samsonov added a subscriber: samsonov.
Comment at: lib/Driver/ToolChains.cpp:368
@@ +367,3 @@
+ StringRef OS = "";
+ if (isTargetMacOS())
+OS = "osx";
Wait, this looks horrible. Can we teach toolchain to give us OS name?
http://reviews.llvm.org/D15624
_
samsonov created this revision.
samsonov added reviewers: rafael, compnerd.
samsonov added a subscriber: cfe-commits.
After this change, AddCXXStdlibLibArgs will check the presence of
-static-libstdc++ flag and, if necessary, wrap -lc++/-lstdc++ in
-Bstatic/-Bdynamic to force static linking of C++
samsonov added a comment.
Kostya, PTAL. IIRC it was your feature request :)
http://reviews.llvm.org/D15363
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
samsonov added a comment.
Richard, could you take a look at this?
http://reviews.llvm.org/D15363
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
samsonov added inline comments.
Comment at: test/Driver/fsanitize.c:221
@@ +220,3 @@
+// RUN: %clang -target x86_64-apple-darwin10
-resource-dir=%S/Inputs/resource_dir -fsanitize=memory -fsanitize=thread,memory
%s -### 2>&1 | FileCheck %s --check-prefix=CHECK-MSAN-TSAN-MSAN-DARW
samsonov added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:2543
@@ +2542,3 @@
+ // RE: Bug: 25682
+ if(!getLangOpts().mergeTraps) {
+ llvm::InlineAsm *EmptyAsm =
llvm::InlineAsm::get(llvm::FunctionType::get(CGM.VoidTy, false),
danielaustin wrote:
samsonov added a comment.
Please consider adding a test case.
Comment at: include/clang/Basic/LangOptions.h:95
@@ -94,1 +94,3 @@
+ /// \brief Flag controlling whether or not trap calls are merged
+ /// at the end of each function.
Why is it a language, not c
samsonov created this revision.
samsonov added reviewers: rsmith, kcc.
samsonov added a subscriber: cfe-commits.
Add the ability to suppress UBSan reports for files/functions/modules
at runtime. The user can now pass UBSAN_OPTIONS=suppressions=supp.txt
with the contents of the form:
signed-intege
samsonov added a comment.
That is, I presume it's highly unlikely user will need to have fine-grained
setup for deciding which UBSan checks should be merged, and which should not.
So, probably having a single `-fsanitize-merge-traps` /
`-fno-sanitize-merge-traps` option would be enough. I'd li
samsonov added a comment.
That is, I presume it's highly unlikely user will need to have fine-grained
setup for deciding which UBSan checks should be merged, and which should not.
So, probably having a single `-fsanitize-merge-traps` /
`-fno-sanitize-merge-traps` option would be enough. I'd li
samsonov added a comment.
Sorry for the late response. Ugh, flag naming is hard, and it's far too
complicated for sanitizers already.
However, I'm opposed to passing this down as `-fsanitize=` option =/. So far
we're trying to make values of `-fsanitize=` correspond *only* to different
kinds o
(TypeLoc Other, unsigned Size) {
> assert(getType() == Other.getType());
> assert(getFullDataSize() == Size);
> -memcpy(getOpaqueData(), Other.getOpaqueData(), Size);
> +copy(Other);
>}
>
>/// Copies the other type loc into this one.
>
>
>
Author: samsonov
Date: Mon Dec 7 16:45:36 2015
New Revision: 254961
URL: http://llvm.org/viewvc/llvm-project?rev=254961&view=rev
Log:
Add llvm-objdump to compiler-rt test deps.
Modified:
cfe/trunk/runtime/CMakeLists.txt
Modified: cfe/trunk/runtime/CMakeLists.txt
URL:
http://llvm.org/viewvc
samsonov added inline comments.
Comment at: include/clang/Driver/ToolChain.h:410
@@ -407,1 +409,3 @@
+ /// (don't require runtime library).
+ virtual SanitizerMask getSanitizersRequiringTrap() const;
};
I don't think this is relevant to ToolChain at all. `Sanit
Author: samsonov
Date: Fri Dec 4 17:13:14 2015
New Revision: 254798
URL: http://llvm.org/viewvc/llvm-project?rev=254798&view=rev
Log:
[Docs] One more cleanup of -fsanitize= section.
Describe -fsanitize-blacklist flags in separate paragraphs, move
notes about importance of clang++ for vptr down t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL254788: [Docs] Update MSan docs (authored by samsonov).
Changed prior to commit:
http://reviews.llvm.org/D15246?vs=41941&id=41946#toc
Repository:
rL LLVM
http://reviews.llvm.org/D15246
Files:
cfe/
Author: samsonov
Date: Fri Dec 4 16:50:44 2015
New Revision: 254788
URL: http://llvm.org/viewvc/llvm-project?rev=254788&view=rev
Log:
[Docs] Update MSan docs
Summary:
1. Move MSan-specific flags and features from user manual to MSan page.
2. Update current status / list of supported platforms.
samsonov marked 2 inline comments as done.
samsonov added a comment.
Addressed, thanks!
http://reviews.llvm.org/D15246
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
samsonov created this revision.
samsonov added reviewers: eugenis, kcc.
samsonov added a subscriber: cfe-commits.
1. Move MSan-specific flags and features from user manual to MSan page.
2. Update current status / list of supported platforms.
http://reviews.llvm.org/D15246
Files:
docs/MemorySan
This revision was automatically updated to reflect the committed changes.
Closed by commit rL254771: [Docs] Move the list of CFI schemes down to CFI doc,
and update it. (authored by samsonov).
Changed prior to commit:
http://reviews.llvm.org/D15237?vs=41905&id=41933#toc
Repository:
rL LLVM
Author: samsonov
Date: Fri Dec 4 15:30:58 2015
New Revision: 254771
URL: http://llvm.org/viewvc/llvm-project?rev=254771&view=rev
Log:
[Docs] Move the list of CFI schemes down to CFI doc, and update it.
Use proper headling levels in CFI doc. Before that, all sections
were considered a subsection
samsonov added inline comments.
Comment at: docs/ControlFlowIntegrity.rst:23
@@ -22,6 +22,3 @@
To enable Clang's available CFI schemes, use the flag ``-fsanitize=cfi``.
-As currently implemented, all of Clang's CFI schemes (``cfi-vcall``,
-``cfi-derived-cast``, ``cfi-unrelated-ca
samsonov updated this revision to Diff 41905.
samsonov marked 3 inline comments as done.
samsonov added a comment.
- Address pcc's comments.
http://reviews.llvm.org/D15237
Files:
docs/ControlFlowIntegrity.rst
docs/UsersManual.rst
Index: docs/UsersManual.rst
samsonov created this revision.
samsonov added reviewers: pcc, kcc.
samsonov added a subscriber: cfe-commits.
Before that, all sections were considered a subsection of
"Introduction".
[Docs] Move the list of CFI schemes down to CFI doc, and update it.
http://reviews.llvm.org/D15237
Files:
doc
Author: samsonov
Date: Fri Dec 4 11:35:47 2015
New Revision: 254734
URL: http://llvm.org/viewvc/llvm-project?rev=254734&view=rev
Log:
[Docs] Remove false claim: UBSan can also be combined with TSan/MSan.
Modified:
cfe/trunk/docs/UsersManual.rst
Modified: cfe/trunk/docs/UsersManual.rst
URL:
samsonov added a comment.
Thanks! Addressed the comments.
Repository:
rL LLVM
http://reviews.llvm.org/D15217
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
samsonov marked 5 inline comments as done.
Closed by commit rL254733: Clang documentation for UBSan. (authored by
samsonov).
Changed prior to commit:
http://reviews.llvm.org/D15217?vs=41823&id=41891#toc
Repository:
rL
Author: samsonov
Date: Fri Dec 4 11:30:29 2015
New Revision: 254733
URL: http://llvm.org/viewvc/llvm-project?rev=254733&view=rev
Log:
Clang documentation for UBSan.
Summary:
Create a separate page describing UBSan tool, move the description of
fine-grained checks there, provide extra information
Author: samsonov
Date: Thu Dec 3 18:38:13 2015
New Revision: 254672
URL: http://llvm.org/viewvc/llvm-project?rev=254672&view=rev
Log:
[Docs] Sanitizer docs migrated from code.google.com to github.com.
Modified:
cfe/trunk/docs/AddressSanitizer.rst
cfe/trunk/docs/LeakSanitizer.rst
cfe/
samsonov added a comment.
I agree with Richard here.
Repository:
rL LLVM
http://reviews.llvm.org/D15208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rug*. =)
> Hopefully fixed in r254053.
>
>
> On Tue, Nov 24, 2015 at 5:14 PM, Alexey Samsonov
> wrote:
>
>> Hm, looks like we can't compile Clang itself after this change (with GCC):
>>
>>
>> http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-autoco
IndexBody.cpp Tue Nov 24 17:50:47 2015
> @@ -125,10 +125,11 @@ public:
> return true;
>}
>
> - bool TraverseCXXOperatorCallExpr(CXXOperatorCallExpr *E) {
> + bool TraverseCXXOperatorCallExpr(CXXOperatorCallExpr *E,
> + DataRecursionQueu
Unfortunately, that change breaks the Clang compilation, see r254041 review
thread.
On Tue, Nov 24, 2015 at 3:54 PM, Richard Smith
wrote:
> On Tue, Nov 24, 2015 at 1:16 PM, Alexey Samsonov
> wrote:
>
>> Looks like Clang::Index/index-many-call-ops.cpp still uses too much stack
Queue.empty()) {
> +Stmt *CurrS = LocalQueue.pop_back_val();
> +
> +size_t N = LocalQueue.size();
> +TRY_TO(dataTraverseNode(CurrS, &LocalQueue));
> +// Process new children in the order they were added.
> +std::reverse(LocalQueue.begin() + N, LocalQueue.end());
meLibrary.darwin.Configs += cc_kext_tvos.a
> +endif
> +
> +ifneq ($(WATCHOS_SDK)$(WATCHOSSIM_SDK),)
> +RuntimeLibrary.darwin.Configs += watchos.a profile_watchos.a
> +endif
> +
> +ifneq ($(WATCHOS_SDK),)
> +RuntimeLibrary.darwin.Configs +=
Seems to work now, thanks for the quick fix!
On Thu, Oct 22, 2015 at 1:57 PM, Eric Fiselier wrote:
> Hi Alexey,
>
> Please confirm that this works for you now after r251063. Sorry for the
> breakage.
>
> /Eric
>
> On Thu, Oct 22, 2015 at 9:23 AM, Alexey Samsonov
> wr
endif()
>> > endif()
>>
>> Generator expressions in install(FILES) are only allowed since CMake 3.0
>> (https://cmake.org/cmake/help/v3.0/release/3.0.0.html#commands).
>> The current minimum for libcxx is 2.8, so this should either be raised or
>> we
>> h
samsonov accepted this revision.
samsonov added a comment.
This revision is now accepted and ready to land.
Looks pretty good. I'm still not convinced with your -Werror arguments, and
will be unavailable during the next week, so feel free to land it, provided
we'll return to the discussion later
samsonov added inline comments.
Comment at: runtime/CMakeLists.txt:41
@@ +40,3 @@
+
+ add_custom_target(compiler-rt-clear
+DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/compiler-rt-cleared
So, that's the target that you can invoke manually to clean compiler-rt build?
samsonov added inline comments.
Comment at: runtime/CMakeLists.txt:33
@@ -32,1 +32,3 @@
+ )
+set(cmake_3_4_USES_TERMINAL USES_TERMINAL 1)
endif()
Should this also be named cmake_3_4_USES_TERMINAL_OPTIONS?
Comment at: runtime/CMakeList
samsonov accepted this revision.
samsonov added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
http://reviews.llvm.org/D13122
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
samsonov added a subscriber: samsonov.
samsonov accepted this revision.
samsonov added a reviewer: samsonov.
samsonov added a comment.
This revision is now accepted and ready to land.
OK to submit after compiler-rt support is submitted.
http://reviews.llvm.org/D13109
_
samsonov added a subscriber: samsonov.
samsonov accepted this revision.
samsonov added a reviewer: samsonov.
samsonov added a comment.
LGTM
http://reviews.llvm.org/D12840
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
gt;> CHECK-NEXT:
>>>>>>>>>> ext_excess_initializers_in_char_array_initializer
>>>>>>>>>> CHECK-NEXT: ext_expected_semi_decl_list
>>>>>>>>>> @@ -44,10 +44,8 @@ C
Author: samsonov
Date: Thu Sep 3 15:53:14 2015
New Revision: 246804
URL: http://llvm.org/viewvc/llvm-project?rev=246804&view=rev
Log:
Add target flag to clang-cl invocation in this test.
Modified:
cfe/trunk/test/Driver/fsanitize-coverage.c
Modified: cfe/trunk/test/Driver/fsanitize-coverage.
Author: samsonov
Date: Thu Sep 3 14:11:42 2015
New Revision: 246795
URL: http://llvm.org/viewvc/llvm-project?rev=246795&view=rev
Log:
Add -target flag to Clang invocations in this test.
ASan may not be supported for the default target triple.
Modified:
cfe/trunk/test/Driver/fsanitize-blackl
samsonov added a comment.
See my comment in a different CL - I would strongly prefer to not touch
autoconf build system unless absolutely necessary.
Repository:
rL LLVM
http://reviews.llvm.org/D12401
___
cfe-commits mailing list
cfe-commits@list
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245897: [UBSan] Add the ability to print more precise error
kind in summary line. (authored by samsonov).
Changed prior to commit:
http://reviews.llvm.org/D12215?vs=32753&id=33019#toc
Repository:
rL
samsonov added inline comments.
Comment at: lib/ubsan/ubsan_handlers.cc:57-58
@@ -57,2 +56,4 @@
+ if (!Pointer) {
+R.setErrorType(ErrorType::NullPointerUse);
Diag(Loc, DL_Error, "%0 null pointer of type %1")
<< TypeCheckKinds[Data->TypeCheckKind] << Data->Type;
--
samsonov added inline comments.
Comment at: lib/ubsan/ubsan_handlers.cc:57-58
@@ -57,2 +56,4 @@
+ if (!Pointer) {
+R.setErrorType(ErrorType::NullPointerUse);
Diag(Loc, DL_Error, "%0 null pointer of type %1")
<< TypeCheckKinds[Data->TypeCheckKind] << Data->Type;
--
samsonov added inline comments.
Comment at: lib/ubsan/ubsan_flags.inc:26
@@ +25,2 @@
+UBSAN_FLAG(bool, report_error_type, false,
+"Print specific error type instead of 'undefined-behavior' in
summary.")
filcab wrote:
> Do we care that much about keeping t
samsonov added a comment.
Overall, this looks reasonable to me, but I'd like Richard to confirm he's fine
with this change as well.
Comment at: docs/UsersManual.rst:1121
@@ +1120,3 @@
+ Instruct code generator to emit a function call to the specified
+ function name instead
samsonov added a comment.
See https://llvm.org/bugs/show_bug.cgi?id=24443 (it's worth including this
reference to change description).
http://reviews.llvm.org/D12181
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
samsonov created this revision.
samsonov added reviewers: rsmith, pcc.
samsonov added a subscriber: cfe-commits.
http://reviews.llvm.org/D12215
Files:
lib/ubsan/ubsan_checks.inc
lib/ubsan/ubsan_diag.cc
lib/ubsan/ubsan_diag.h
lib/ubsan/ubsan_flags.inc
lib/ubsan/ubsan_handlers.cc
lib/ub
samsonov added a comment.
Please upload the patch with more context (see
http://llvm.org/docs/Phabricator.html).
Comment at: tools/clang/include/clang/Driver/Options.td:610
@@ -608,1 +609,3 @@
+ Flags<[CC1Option, CoreOption]>,
+
Author: samsonov
Date: Wed Aug 19 12:28:01 2015
New Revision: 245467
URL: http://llvm.org/viewvc/llvm-project?rev=245467&view=rev
Log:
Replace __asan_set_error_exit_code() with __sanitizer_set_death_callback()
Summary: We are going to remove the former soon.
Reviewers: EricWF
Subscribers: cfe-c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245467: Replace __asan_set_error_exit_code() with
__sanitizer_set_death_callback() (authored by samsonov).
Changed prior to commit:
http://reviews.llvm.org/D12117?vs=32456&id=32572#toc
Repository:
rL
samsonov added a comment.
Yes. Is this is an issue?
http://reviews.llvm.org/D12117
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
samsonov created this revision.
samsonov added a reviewer: EricWF.
samsonov added a subscriber: cfe-commits.
We are going to remove the former soon.
http://reviews.llvm.org/D12117
Files:
test/libcxx/containers/sequences/vector/asan.pass.cpp
Index: test/libcxx/containers/sequences/vector/asan.
samsonov added a comment.
Driver changes look good.
http://reviews.llvm.org/D11857
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
samsonov added a comment.
Thank you for working on this! This change looks good to me, but I'll let
Richard say a final word.
Note that you would need to make a corresponding change in UBSan compiler-rt
runtime. Also, this is an ABI-breaking change - e.g. shared objects built with
older Clang
93 matches
Mail list logo
