Re: [PATCH] D17741: adds __FILE_BASENAME__ builtin macro

2016-04-08 Thread Alex Rosenberg via cfe-commits
alexr added a subscriber: alexr. alexr added a comment. There are multiple features in this patch that should be considered separately. Please split the patch. That said, I don't think we want to add a fundamental new preprocessor feature like __FILE_BASENAME__ without at least getting some ear

Re: [libcxx] r249738 - Split out of .

2015-10-15 Thread Alex Rosenberg via cfe-commits
On Oct 15, 2015, at 2:20 PM, Adrian Prantl via cfe-commits wrote: >> >> On Oct 15, 2015, at 2:09 PM, Adrian Prantl via cfe-commits >> wrote: >> >>> >>> On Oct 15, 2015, at 1:42 PM, Richard Smith wrote: >>> >>> On Thu, Oct 15, 2015 at 11:14 AM, Adrian Prantl wrote: >>> On Oct 14, 20

Re: [PATCH] D11908: Clang support for -fthinlto.

2015-10-01 Thread Alex Rosenberg via cfe-commits
alexr added a subscriber: alexr. alexr added a comment. I realize that we've all been referring to this as ThinLTO, but is that necessarily descriptive for users? What about inlineonly or something similar? http://reviews.llvm.org/D11908 ___ cfe-co

Re: [PATCH] D13351: [Power PC] add soft float support for ppc32

2015-10-01 Thread Alex Rosenberg via cfe-commits
alexr added a subscriber: alexr. alexr added a comment. PowerPC has floating point hardware by definition. Is this some new variant? http://reviews.llvm.org/D13351 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

Re: [PATCH] D11944: Nativize filename in FileManager::getFile().

2015-08-17 Thread Alex Rosenberg via cfe-commits
alexr added a subscriber: alexr. alexr added a comment. Just to remind everybody, different OSes handle Unicode differently as well. Think of it as case insensitivity for the different Unicode ways of encoding the same glyph. For example U+00DC (LATIN CAPITAL LETTER U WITH DIAERESIS) vs U+0055