alexreinking updated this revision to Diff 333690.
alexreinking retitled this revision from "Add ConfigVersion.cmake
files" to "[CMake] Add ConfigVersion.cmake files".
alexreinking added a comment.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
As requested, move instances
alexreinking updated this revision to Diff 333688.
alexreinking added a comment.
Update & wrap commit message
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97513/new/
https://reviews.llvm.org/D97513
Files:
clang/cmake/modules/CMakeLists.txt
flang/cmake/modules/CMakeLists.txt
lld/
alexreinking updated this revision to Diff 333687.
alexreinking added a comment.
Remove unused version variables (that were used in a previous revision)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97513/new/
https://reviews.llvm.org/D97513
Files:
clang/cmake/modules/CMakeLists.txt
alexreinking updated this revision to Diff 333683.
alexreinking added a comment.
Drop *ConfigVersion.cmake files from `CMakeFiles` tree
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97513/new/
https://reviews.llvm.org/D97513
Files:
clang/cmake/modules/CMakeLists.txt
flang/cmake/mod
alexreinking updated this revision to Diff 333677.
alexreinking added a comment.
Use PACKAGE_VERSION instead
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97513/new/
https://reviews.llvm.org/D97513
Files:
clang/cmake/modules/CMakeLists.txt
flang/cmake/modules/CMakeLists.txt
lld/C
alexreinking updated this revision to Diff 333657.
alexreinking added a comment.
Uses write_basic_package_version_file
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97513/new/
https://reviews.llvm.org/D97513
Files:
clang/cmake/modules/CMakeLists.txt
flang/cmake/modules/CMakeLists.t
alexreinking added a comment.
So with this patch, I tried to imitate the existing code as much as possible.
However, I think it would be quite a bit better to use the
`write_basic_package_version_file` command from `CMakePackageConfigHelpers`. It
gained support for major + minor version compati
alexreinking created this revision.
alexreinking added reviewers: chandlerc, gottesmm, pmccormick.
Herald added subscribers: cota, teijeong, rdzhabarov, tatianashp, msifontes,
jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester,
arpith-jacob, antiagainst, shauheen, rriddle,