pilki added a comment.
Sorry, both my 'diff' and my 'svn' command added some magical coloring... It
should be good now.
http://reviews.llvm.org/D18961
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
pilki updated this revision to Diff 53533.
http://reviews.llvm.org/D18961
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/DeletedDefaultCheck.cpp
clang-tidy/readability/DeletedDefaultCheck.h
clang-tidy/readability/ReadabilityTidyModule.cpp
docs/ReleaseNotes.rst
doc
pilki updated this revision to Diff 53532.
http://reviews.llvm.org/D18961
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/DeletedDefaultCheck.cpp
clang-tidy/readability/DeletedDefaultCheck.h
clang-tidy/readability/ReadabilityTidyModule.cpp
docs/ReleaseNotes.rst
pilki added a comment.
I did svn up and reuploaded the diff. I did not see any changes on files I
touched, so I'm not sure it worked.
http://reviews.llvm.org/D18961
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
pilki updated this revision to Diff 53529.
http://reviews.llvm.org/D18961
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/DeletedDefaultCheck.cpp
clang-tidy/readability/DeletedDefaultCheck.h
clang-tidy/readability/ReadabilityTidyModule.cpp
docs/ReleaseNotes.rst
pilki updated this revision to Diff 53525.
pilki marked 2 inline comments as done.
http://reviews.llvm.org/D18961
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/DeletedDefaultCheck.cpp
clang-tidy/readability/DeletedDefaultCheck.h
clang-tidy/readability/Readability
pilki added inline comments.
Comment at: clang-tidy/readability/DeletedDefaultCheck.cpp:37
@@ +36,3 @@
+
+void DeletedDefaultCheck::check(const MatchFinder::MatchResult &Result) {
+ const StringRef Message = "%0 is explicitly defaulted but implicitly "
alexfh wr
pilki updated this revision to Diff 53404.
pilki marked 3 inline comments as done.
http://reviews.llvm.org/D18961
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/DeletedDefaultCheck.cpp
clang-tidy/readability/DeletedDefaultCheck.h
clang-tidy/readability/Readability
pilki added a comment.
Fixed all the comment but the one about merging the two matchers.
http://reviews.llvm.org/D18961
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pilki added inline comments.
Comment at: clang-tidy/readability/DeletedDefaultCheck.cpp:36
@@ +35,3 @@
+}
+
+void DeletedDefaultCheck::check(const MatchFinder::MatchResult &Result) {
alexfh wrote:
> I would at least join matchers, since, I believe, it might be mo
pilki updated this revision to Diff 53381.
pilki marked an inline comment as done.
http://reviews.llvm.org/D18961
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/DeletedDefaultCheck.cpp
clang-tidy/readability/DeletedDefaultCheck.h
clang-tidy/readability/Readability
pilki updated this revision to Diff 53371.
pilki marked an inline comment as done.
http://reviews.llvm.org/D18961
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/DeletedDefaultCheck.cpp
clang-tidy/readability/DeletedDefaultCheck.h
clang-tidy/readability/Readability
pilki added inline comments.
Comment at: clang-tidy/readability/DeletedDefaultCheck.cpp:35
@@ +34,3 @@
+ this);
+ Finder->addMatcher(cxxMethodDecl(anyOf(isCopyAssignmentOperator(),
+ isMoveAssignmentOperator()),
---
pilki added a comment.
I hope I answered all comments (sorry if I missed some, I'm not yet used to
this UI).
I have an open question about isInTemplateInstantiation, and added a test
(since I missed templated function)
Comment at: clang-tidy/readability/DeletedDefaultCheck.c
pilki updated this revision to Diff 53289.
pilki marked 5 inline comments as done.
http://reviews.llvm.org/D18961
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/DeletedDefaultCheck.cpp
clang-tidy/readability/DeletedDefaultCheck.h
clang-tidy/readability/Readability
pilki added a comment.
In http://reviews.llvm.org/D18961#397163, @dblaikie wrote:
> I'd consider just making this a compiler warning, perhaps?
I honestly don't feel competent right now to write compiler warnings:
clang-tidy has a nice, well defined interface. A compiler warning would force
me
pilki updated this revision to Diff 53257.
pilki marked 3 inline comments as done.
http://reviews.llvm.org/D18961
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/DeletedDefaultCheck.cpp
clang-tidy/readability/DeletedDefaultCheck.h
clang-tidy/readability/Readability
pilki marked an inline comment as done.
pilki added a comment.
http://reviews.llvm.org/D18961
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pilki added inline comments.
Comment at: clang-tidy/readability/DeletedDefaultCheck.cpp:30
@@ +29,3 @@
+ // We should actually use isExplicitlyDefaulted, but it does not exist.
+ Finder->addMatcher(
+ cxxConstructorDecl(isDefaultConstructor(), isExplicitlyDefaulted(),
pilki created this revision.
pilki added a reviewer: alexfh.
pilki added a subscriber: cfe-commits.
Checks if constructors and assignment operators that are marked '= default' are
actually deleted by the compiler.
http://reviews.llvm.org/D18961
Files:
clang-tidy/readability/CMakeLists.txt
20 matches
Mail list logo
