https://github.com/bulbazord approved this pull request.
The LLDB changes look good to me. I can't speak for the clang portions but fwiw
I think they look ok too.
https://github.com/llvm/llvm-project/pull/103388
___
cfe-commits mailing list
cfe-commit
https://github.com/bulbazord approved this pull request.
LGTM, thanks!
https://github.com/llvm/llvm-project/pull/97824
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -47,13 +47,12 @@ namespace sys {
/// The particular format of the names are target dependent, and suitable for
/// passing as -mattr to the target which matches the host.
///
- /// \param Features - A string mapping feature names to either
- /// true (if enabled) or
https://github.com/bulbazord commented:
>From an API standpoint, there doesn't actually seem to be a huge difference
>between an empty StringMap and an optional with an empty string map in it
>right? Why not return a map every time?
https://github.com/llvm/llvm-project/pull/97824
_
https://github.com/bulbazord requested changes to this pull request.
Hmm, actually, I'm not so sure about this change anymore. I went through PEP8
again and saw this:
```
Don’t compare boolean values to True or False using ==:
# Correct:
if greeting:
# Wrong:
if greeting == True:
Worse:
# Wron
https://github.com/bulbazord approved this pull request.
LGTM
The PR summary is empty, but it looks like the commit message has an
explanation for this change, so that's fine.
https://github.com/llvm/llvm-project/pull/91858
___
cfe-commits mailing li
bulbazord wrote:
LLDB changes look fine.
https://github.com/llvm/llvm-project/pull/90391
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bulbazord wrote:
> > Please update the PR subject as its a lot more than just X86AsmParser.cpp
>
> Hi @RKSimon
>
> All the issues mentioned are fixed. The title of the PR is misleading. The
> title is the same as the issue (#85868) it corresponds to. Got a look to
> other PR's and I thought t
Author: Alex Langford
Date: 2022-10-04T11:25:43-07:00
New Revision: 266ec801fb23f9f5f1d61ca9466e0805fbdb78a7
URL:
https://github.com/llvm/llvm-project/commit/266ec801fb23f9f5f1d61ca9466e0805fbdb78a7
DIFF:
https://github.com/llvm/llvm-project/commit/266ec801fb23f9f5f1d61ca9466e0805fbdb78a7.diff
Author: Alex Langford
Date: 2022-04-19T12:57:14-07:00
New Revision: c57f03415f9668f942802ff7108410d57c2b10da
URL:
https://github.com/llvm/llvm-project/commit/c57f03415f9668f942802ff7108410d57c2b10da
DIFF:
https://github.com/llvm/llvm-project/commit/c57f03415f9668f942802ff7108410d57c2b10da.diff
Author: Xin-Xin Wang
Date: 2019-12-17T12:12:21-08:00
New Revision: b3f789e037cbfdb1439c01a4eefc9ab9bb0d2c64
URL:
https://github.com/llvm/llvm-project/commit/b3f789e037cbfdb1439c01a4eefc9ab9bb0d2c64
DIFF:
https://github.com/llvm/llvm-project/commit/b3f789e037cbfdb1439c01a4eefc9ab9bb0d2c64.diff
Author: xiaobai
Date: Mon Sep 23 15:24:47 2019
New Revision: 372668
URL: http://llvm.org/viewvc/llvm-project?rev=372668&view=rev
Log:
[NFCI] Return PathSensitiveBugReport where appropriate
Some compilers have trouble converting unique_ptr to
unique_ptr causing some functions to fail to compile.
C
Author: xiaobai
Date: Thu Sep 19 17:16:32 2019
New Revision: 372363
URL: http://llvm.org/viewvc/llvm-project?rev=372363&view=rev
Log:
[NFCI] Always initialize const members of AttributeCommonInfo
Some compilers require that const fields of an object must be explicitly
initialized by the construct
Author: xiaobai
Date: Wed Aug 14 17:58:51 2019
New Revision: 368950
URL: http://llvm.org/viewvc/llvm-project?rev=368950&view=rev
Log:
[NFCI] Always initialize BugReport const fields
Summary:
Some compilers require that const fields of an object must be explicitly
initialized by the constructor. I
Author: xiaobai
Date: Tue Aug 13 18:09:07 2019
New Revision: 368779
URL: http://llvm.org/viewvc/llvm-project?rev=368779&view=rev
Log:
[analyzer] Don't delete TaintConfig copy constructor
Summary:
Explicitly deleting the copy constructor makes compiling the function
`ento::registerGenericTaintChec
15 matches
Mail list logo
