[clang] [Sema][ObjC] Add warning options to detect bad name prefixes. (PR #97597)

al45tair wrote: Converting back to draft as I'm still tinkering slightly with the warning rules. https://github.com/llvm/llvm-project/pull/97597 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[clang] [Sema][ObjC] Add warning options to detect bad name prefixes. (PR #97597)

https://github.com/al45tair converted_to_draft https://github.com/llvm/llvm-project/pull/97597 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema][ObjC] Add warning options to detect bad name prefixes. (PR #97597)

al45tair wrote: Failure doesn't look like anything to do with this PR. https://github.com/llvm/llvm-project/pull/97597 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Parser][ObjC] Add -Wobjc-prefix-length warning option. (PR #97597)

https://github.com/al45tair edited https://github.com/llvm/llvm-project/pull/97597 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema][ObjC] Add warning options to detect bad name prefixes. (PR #97597)

https://github.com/al45tair edited https://github.com/llvm/llvm-project/pull/97597 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Parser][ObjC] Add -Wobjc-prefix-length warning option. (PR #97597)

https://github.com/al45tair updated https://github.com/llvm/llvm-project/pull/97597 >From 6dfbc7b61b137fdfd9d39b23bce62e451dca3e1c Mon Sep 17 00:00:00 2001 From: Alastair Houghton Date: Wed, 3 Jul 2024 17:00:51 +0100 Subject: [PATCH] [Sema][ObjC] Add warning options to detect bad name prefixes.

[clang] [Parser][ObjC] Add -Wobjc-prefix-length warning option. (PR #97597)

https://github.com/al45tair updated https://github.com/llvm/llvm-project/pull/97597 >From c11624370bf5615c7902993052435b92ae50b41b Mon Sep 17 00:00:00 2001 From: Alastair Houghton Date: Wed, 3 Jul 2024 17:00:51 +0100 Subject: [PATCH 1/8] [Parser][ObjC] Add -Wobjc-prefix-length warning option.

[clang] [Parser][ObjC] Add -Wobjc-prefix-length warning option. (PR #97597)

https://github.com/al45tair updated https://github.com/llvm/llvm-project/pull/97597 >From c11624370bf5615c7902993052435b92ae50b41b Mon Sep 17 00:00:00 2001 From: Alastair Houghton Date: Wed, 3 Jul 2024 17:00:51 +0100 Subject: [PATCH 1/8] [Parser][ObjC] Add -Wobjc-prefix-length warning option.

[clang] [Parser][ObjC] Add -Wobjc-prefix-length warning option. (PR #97597)

https://github.com/al45tair updated https://github.com/llvm/llvm-project/pull/97597 >From c11624370bf5615c7902993052435b92ae50b41b Mon Sep 17 00:00:00 2001 From: Alastair Houghton Date: Wed, 3 Jul 2024 17:00:51 +0100 Subject: [PATCH 1/7] [Parser][ObjC] Add -Wobjc-prefix-length warning option.

[clang] [Parser][ObjC] Add -Wobjc-prefix-length warning option. (PR #97597)

https://github.com/al45tair updated https://github.com/llvm/llvm-project/pull/97597 >From 02f7c5ef71b382866e02037ce82c85fa6fcbb394 Mon Sep 17 00:00:00 2001 From: Alastair Houghton Date: Wed, 3 Jul 2024 17:00:51 +0100 Subject: [PATCH 1/6] [Parser][ObjC] Add -Wobjc-prefix-length warning option.

[clang] [Parser][ObjC] Add -Wobjc-prefix-length warning option. (PR #97597)

https://github.com/al45tair updated https://github.com/llvm/llvm-project/pull/97597 >From 02f7c5ef71b382866e02037ce82c85fa6fcbb394 Mon Sep 17 00:00:00 2001 From: Alastair Houghton Date: Wed, 3 Jul 2024 17:00:51 +0100 Subject: [PATCH 1/5] [Parser][ObjC] Add -Wobjc-prefix-length warning option.

[clang] [Parser][ObjC] Add -Wobjc-prefix-length warning option. (PR #97597)

https://github.com/al45tair updated https://github.com/llvm/llvm-project/pull/97597 >From 02f7c5ef71b382866e02037ce82c85fa6fcbb394 Mon Sep 17 00:00:00 2001 From: Alastair Houghton Date: Wed, 3 Jul 2024 17:00:51 +0100 Subject: [PATCH 1/4] [Parser][ObjC] Add -Wobjc-prefix-length warning option.

[clang] [Parser][ObjC] Add -Wobjc-prefix-length warning option. (PR #97597)

https://github.com/al45tair updated https://github.com/llvm/llvm-project/pull/97597 >From 02f7c5ef71b382866e02037ce82c85fa6fcbb394 Mon Sep 17 00:00:00 2001 From: Alastair Houghton Date: Wed, 3 Jul 2024 17:00:51 +0100 Subject: [PATCH 1/3] [Parser][ObjC] Add -Wobjc-prefix-length warning option.

[clang] [Parser][ObjC] Add -Wobjc-prefix-length warning option. (PR #97597)

@@ -0,0 +1,18 @@ +// RUN: %clang_cc1 %s -Wobjc-prefixes=NS,NSCF,NSURL -fsyntax-only -verify al45tair wrote: Hmmm, maybe, yes. Not hard to add. https://github.com/llvm/llvm-project/pull/97597 ___ cfe-commits mailing lis

[clang] [Parser][ObjC] Add -Wobjc-prefix-length warning option. (PR #97597)

https://github.com/al45tair updated https://github.com/llvm/llvm-project/pull/97597 >From 02f7c5ef71b382866e02037ce82c85fa6fcbb394 Mon Sep 17 00:00:00 2001 From: Alastair Houghton Date: Wed, 3 Jul 2024 17:00:51 +0100 Subject: [PATCH 1/2] [Parser][ObjC] Add -Wobjc-prefix-length warning option.

[clang] [Parser][ObjC] Add -Wobjc-prefix-length warning option. (PR #97597)

https://github.com/al45tair updated https://github.com/llvm/llvm-project/pull/97597 >From 02f7c5ef71b382866e02037ce82c85fa6fcbb394 Mon Sep 17 00:00:00 2001 From: Alastair Houghton Date: Wed, 3 Jul 2024 17:00:51 +0100 Subject: [PATCH 1/2] [Parser][ObjC] Add -Wobjc-prefix-length warning option.

[clang] [Parser][ObjC] Add -Wobjc-prefix-length warning option. (PR #97597)

https://github.com/al45tair created https://github.com/llvm/llvm-project/pull/97597 This lets clang generate warnings automatically if it sees Objective-C names that don't have the correct prefix length. rdar://131055157 >From 02f7c5ef71b382866e02037ce82c85fa6fcbb394 Mon Sep 17 00:00:00 2001

[libunwind] [libunwind] Tweak tests for musl support. (PR #85097)

al45tair wrote: I don't have merge rights here, so someone else will need to hit the Merge button. https://github.com/llvm/llvm-project/pull/85097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[libunwind] [libunwind] Tweak tests for musl support. (PR #85097)

https://github.com/al45tair updated https://github.com/llvm/llvm-project/pull/85097 >From 6808d20b198bba4f2e062094b89cfc13eac49f85 Mon Sep 17 00:00:00 2001 From: Alastair Houghton Date: Thu, 22 Feb 2024 11:59:24 + Subject: [PATCH 1/3] [libunwind] Tweak tests for musl support. We can't use

[libunwind] [libunwind] Tweak tests for musl support. (PR #85097)

@@ -24,16 +23,30 @@ #include #include +// Note: this test fails on musl because: +// +// (a) musl disables emission of unwind information for its build, and +// (b) musl's signal trampolines don't include unwind information +// al45tair wrote: We'll use `

[libunwind] [libunwind] Tweak tests for musl support. (PR #85097)

@@ -24,16 +23,30 @@ #include #include +// Note: this test fails on musl because: +// +// (a) musl disables emission of unwind information for its build, and +// (b) musl's signal trampolines don't include unwind information +// al45tair wrote: Let's rearr

[libunwind] [libunwind] Tweak tests for musl support. (PR #85097)

@@ -11,20 +11,27 @@ // Basic test for float registers number are accepted. -#include #include #include #include +// Using __attribute__((section("main_func"))) is Linux specific, but then al45tair wrote: Fair point. https://github.com/llvm/llvm-pro

[clang] [Clang] Prioritise built-in headers, even on musl. (PR #85092)

https://github.com/al45tair updated https://github.com/llvm/llvm-project/pull/85092 >From 527aa4616dc53f8f7ca212472fa40c23f40b6dc1 Mon Sep 17 00:00:00 2001 From: Alastair Houghton Date: Thu, 22 Feb 2024 11:33:32 + Subject: [PATCH 1/2] [Clang] Prioritise built-in headers, even on musl. Clan

[clang] [Clang] Don't use crtbegin/crtend when building for musl. (PR #85089)

al45tair wrote: Regardless of who provides them, if someone is relying on this then this is the wrong change. Closing. https://github.com/llvm/llvm-project/pull/85089 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[clang] [Clang] Don't use crtbegin/crtend when building for musl. (PR #85089)

https://github.com/al45tair closed https://github.com/llvm/llvm-project/pull/85089 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Don't use crtbegin/crtend when building for musl. (PR #85089)

al45tair wrote: (I had assumed that they came from the C library, since that's where `crt1.o` comes from, but if they don't then it sounds like I just need to build them.) https://github.com/llvm/llvm-project/pull/85089 ___ cfe-commits mailing list cf

[clang] [Clang] Don't use crtbegin/crtend when building for musl. (PR #85089)

al45tair wrote: > The compiler provides crtbegin/crtend files, not musl. Interesting. Looking at the LLVM repo, it seems compiler-rt might provide them, but I don't believe I have them in spite of building compiler-rt. I'll look at this again and see if maybe I need to tweak my compiler-rt bui

[libunwind] [libunwind] Tweak tests for musl support. (PR #85097)

https://github.com/al45tair updated https://github.com/llvm/llvm-project/pull/85097 >From 6808d20b198bba4f2e062094b89cfc13eac49f85 Mon Sep 17 00:00:00 2001 From: Alastair Houghton Date: Thu, 22 Feb 2024 11:59:24 + Subject: [PATCH 1/2] [libunwind] Tweak tests for musl support. We can't use

[clang] [Clang] Don't use crtbegin/crtend when building for musl. (PR #85089)

https://github.com/al45tair updated https://github.com/llvm/llvm-project/pull/85089 >From 8bdd6627e21eaddedfff208eebaa46f1eeb81674 Mon Sep 17 00:00:00 2001 From: Alastair Houghton Date: Thu, 22 Feb 2024 11:36:57 + Subject: [PATCH 1/2] [Clang] Don't use crtbegin/crtend when building for musl

[libunwind] [libunwind] Tweak tests for musl support. (PR #85097)

al45tair wrote: This is a cherry pick of https://github.com/apple/llvm-project/pull/8260. https://github.com/llvm/llvm-project/pull/85097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[libunwind] [libunwind] Tweak tests for musl support. (PR #85097)

https://github.com/al45tair created https://github.com/llvm/llvm-project/pull/85097 We can't use `dladdr()` in the tests, because when we're statically linking with musl that function is a no-op. Additionally, because musl disables emission of unwind information in its build, and because its

[clang] [Clang] Prioritise built-in headers, even on musl. (PR #85092)

https://github.com/al45tair created https://github.com/llvm/llvm-project/pull/85092 Clang was putting its built-in headers at the end of the search path if running on musl; this was a mistake, because it breaks libc++, as the latter tries to include the built-in header and then the `#include_n

[clang] [Clang] Don't use crtbegin/crtend when building for musl. (PR #85089)

https://github.com/al45tair created https://github.com/llvm/llvm-project/pull/85089 musl doesn't supply crtbegin/crtend objects, so we don't want to try to link them there. rdar://123436174 >From 8bdd6627e21eaddedfff208eebaa46f1eeb81674 Mon Sep 17 00:00:00 2001 From: Alastair Houghton Date:

[clang] [Clang][ObjC] Add optionality to property attribute strings. (PR #66507)

https://github.com/al45tair edited https://github.com/llvm/llvm-project/pull/66507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][ObjC] Add optionality to property attribute strings. (PR #66507)

https://github.com/al45tair created https://github.com/llvm/llvm-project/pull/66507 Add a new attribute, "?", to the property attribute string for properties of protocols that are declared @optional. (Previously https://reviews.llvm.org/D135273) rdar://100463524 >From 3514013089dcf9fa798e9ba