abhina.sreeskantharajan created this revision.
abhina.sreeskantharajan added reviewers: thakis, hubert.reinterpretcast,
uweigand, yusra.syeda, Kai, zibi, MaskRay, anirudhp.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
abhina.sreeskantharajan requested review of this revis
abhina.sreeskantharajan updated this revision to Diff 283942.
abhina.sreeskantharajan marked 2 inline comments as done.
abhina.sreeskantharajan added a comment.
Thanks Hubert for reviewing. I updated the patch to fix the wchar_t comment and
the if guards for the macros. I also updated the lit tes
abhina.sreeskantharajan marked 2 inline comments as done.
abhina.sreeskantharajan added inline comments.
Comment at: clang/lib/Basic/Targets/OSTargets.h:732
+Builder.defineMacro("_OPEN_DEFAULT");
+Builder.defineMacro("_UNIX03_WITHDRAWN");
+Builder.defineMacro("__370__
abhina.sreeskantharajan added inline comments.
Comment at: clang/lib/Basic/Targets/OSTargets.h:780
+public:
+ ZOSTargetInfo(const llvm::Triple &Triple, const TargetOptions &Opts)
+ : OSTargetInfo(Triple, Opts) {}
tatyana-krasnukha wrote:
> It is possible to
abhina.sreeskantharajan updated this revision to Diff 283290.
abhina.sreeskantharajan added a reviewer: MaskRay.
abhina.sreeskantharajan added a comment.
Thanks MaskRay, I removed the extra braces.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85324
abhina.sreeskantharajan added inline comments.
Comment at: clang/lib/Basic/Targets/OSTargets.h:745
+if (this->PointerWidth == 64) {
+ Builder.defineMacro("__64BIT__");
+}
anirudhp wrote:
> What about the `__LP64__` and the `_LP64` macros?
These two a
abhina.sreeskantharajan created this revision.
abhina.sreeskantharajan added reviewers: uweigand, Kai, hubert.reinterpretcast,
yusra.syeda, SeanP.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
abhina.sreeskantharajan requested review of this revision.
This patch adds the
