[PATCH] D24954: [ToolChains] Disable OpenSUSE rules for SLES10

2016-10-05 Thread İsmail Dönmez via cfe-commits
ismail added a comment. That looks good to me but I am not a reviewer. Someone else must approve. https://reviews.llvm.org/D24954 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24954: [ToolChains] Do not assume OpenSUSE for other SUSE variants

2016-09-27 Thread İsmail Dönmez via cfe-commits
ismail added a comment. This will break SLES11 and later so it's not OK. Also note that SLES10 is not supported anymore. https://reviews.llvm.org/D24954 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

Re: [PATCH] D20672: Don't pass -fms-compatibility-version flag during build

2016-05-26 Thread İsmail Dönmez via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL270860: Since some time clang itself figures out the default for ms-compatibility… (authored by ismail). Changed prior to commit: http://reviews.llvm.org/D20672?vs=58586&id=58623#toc Repository: rL L

[PATCH] D20672: Don't pass -fms-compatibility-version flag during build

2016-05-26 Thread İsmail Dönmez via cfe-commits
ismail created this revision. ismail added reviewers: hans, rnk. ismail added a subscriber: cfe-commits. ismail set the repository for this revision to rL LLVM. Since some time clang itself figures out the default for ms-compatibility-version and uses it. Trying to figure it out during build is

Re: [PATCH] D18035: [GCC] PR23529 Mangler part of attrbute abi_tag support

2016-05-26 Thread İsmail Dönmez via cfe-commits
ismail added a subscriber: ismail. ismail added a comment. Richard, Does this mean this feature will never be accepted? It would help to make a clear statement on this issue. I am not happy how this feature is introduced but it's too late now that every big Linux distro out there switched to th

Re: [PATCH] D15006: Driver: Better detection of mingw-gcc

2016-01-12 Thread İsmail Dönmez via cfe-commits
ismail added a comment. Reverted in r257468. http://reviews.llvm.org/D15006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15006: Driver: Better detection of mingw-gcc

2015-12-09 Thread İsmail Dönmez via cfe-commits
ismail added a comment. Martell, any update on this? http://reviews.llvm.org/D15006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15006: Driver: Better detection of mingw-gcc

2015-11-26 Thread İsmail Dönmez via cfe-commits
ismail added a comment. Tested on openSUSE and it works. Thanks! http://reviews.llvm.org/D15006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12695: [Driver] Use UniversalCRT on Windows if available

2015-09-11 Thread İsmail Dönmez via cfe-commits
Hi, On Fri, Sep 11, 2015 at 5:03 PM, Igor Kudrin wrote: > Hi İsmail, > > Clang tries to detect pathes automatically only if corresponding environment > variables are not set. In your case, you have these variables set, so clang > honors them. In the original case no variable was set, I thought y

Re: [PATCH] D12695: [Driver] Use UniversalCRT on Windows if available

2015-09-11 Thread İsmail Dönmez via cfe-commits
Hi, C:\Users\ismail\Desktop>set include INCLUDE=C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE;C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\ATLMFC\INCLUDE;C:\Program Files (x86)\Windows Kits\10\include\10.0.10240.0\ucrt;C:\Program Files (x86)\Windows Kits\NETFXSDK\4.6\inc

Re: [PATCH] D12695: [Driver] Use UniversalCRT on Windows if available

2015-09-11 Thread İsmail Dönmez via cfe-commits
This doesn't seem to work here, VS 2015 on Win 10 x64: C:\Users\ismail\Desktop>clang-cl.exe -fms-compatibility-version=19 foo.cpp LINK : fatal error LNK1104: cannot open file 'kernel32.lib' clang-cl.exe: error: linker command failed with exit code 1104 (use -v to see invocation) Works fine after

Re: r246497 - [modules] Rework serialized DeclContext lookup table management. Instead of

2015-09-01 Thread İsmail Dönmez via cfe-commits
Hi, On Tue, Sep 1, 2015 at 1:17 AM, Richard Smith via cfe-commits wrote: > Author: rsmith > Date: Mon Aug 31 17:17:11 2015 > New Revision: 246497 > > URL: http://llvm.org/viewvc/llvm-project?rev=246497&view=rev > Log: > [modules] Rework serialized DeclContext lookup table management. Instead of >

Re: r245923 - [X86] Expose the various _rot intrinsics on non-MS platforms

2015-08-25 Thread İsmail Dönmez via cfe-commits
Hi, On Tue, Aug 25, 2015 at 10:21 AM, Michael Kuperstein via cfe-commits wrote: > Author: mkuper > Date: Tue Aug 25 02:21:33 2015 > New Revision: 245923 > > URL: http://llvm.org/viewvc/llvm-project?rev=245923&view=rev > Log: > [X86] Expose the various _rot intrinsics on non-MS platforms > > _rotl

Re: [PATCH] D11932: [OPENMP] Link libomp.lib on Windows

2015-08-17 Thread İsmail Dönmez via cfe-commits
ismail accepted this revision. ismail added a reviewer: ismail. ismail added a comment. This revision is now accepted and ready to land. Great work. Tested fine on Windows. Next step would be mapping /openmp flag to -fopenmp but I guess thats for another bug. http://reviews.llvm.org/D11932 _

Re: [PATCH] D11932: [OPENMP] Link libomp.lib on Windows

2015-08-15 Thread İsmail Dönmez via cfe-commits
ismail added a comment. In http://reviews.llvm.org/D11932#225158, @hfinkel wrote: > What library path should be passed (where did you build the OpenMP runtime > library)? This is a default installation so the lib path is $PATH_TO_CLANG_EXE/../lib which in my case is C:\Program Files\LLVM\lib

Re: [clang-tools-extra] r245052 - [clang-tidy] Move IncludeSorter.* and IncludeInserter.* to clang-tidy/utils/

2015-08-15 Thread İsmail Dönmez via cfe-commits
Looks fixed now, thanks! On Sat, Aug 15, 2015 at 8:41 AM, Alexander Kornienko wrote: > ... or this may have been fixed by r245144. In any case, please check again > and report if anything is still broken. > > > On Sat, Aug 15, 2015 at 7:39 AM, Alexander Kornienko > wrote: >> >> Sorry for not pos

Re: [clang-tools-extra] r245052 - [clang-tidy] Move IncludeSorter.* and IncludeInserter.* to clang-tidy/utils/

2015-08-14 Thread İsmail Dönmez via cfe-commits
Hi, On Fri, Aug 14, 2015 at 5:31 PM, Alexander Kornienko via cfe-commits wrote: > Author: alexfh > Date: Fri Aug 14 09:31:31 2015 > New Revision: 245052 > > URL: http://llvm.org/viewvc/llvm-project?rev=245052&view=rev > Log: > [clang-tidy] Move IncludeSorter.* and IncludeInserter.* to clang-tidy/

Re: [PATCH] D11932: [OPENMP] Link libomp.lib on Windows

2015-08-12 Thread İsmail Dönmez via cfe-commits
ismail added a comment. Tests pass but, now when I tried to compile a file with -fopenmp I get: LINK: fatal error LNK1104: cannot open file 'libomp.lib' libomp.lib does exist in "C:\Program Files\LLVM\lib" but I guess we need to pass the library path down to linker. http://reviews.llvm.org/D1

Re: [PATCH] D11932: [OPENMP] Link libomp.lib on Windows

2015-08-11 Thread İsmail Dönmez via cfe-commits
ismail added a comment. OpenMP/linking.c fails here with VS2015 (building with -DCLANG_DEFAULT_OPENMP_RUNTIME=libomp) Command 21 Stderr: C:\cygwin64\home\ismail\src\llvm\tools\clang\test\OpenMP\linking.c:75:24: error: expected string not found in input // CHECK-MSVC-LINK-64: "link.exe" ^ :1