[clang] [llvm] workflows/release-binaries: Enable Windows x86 builds (PR #128274)

2025-07-26 Thread Tom Stellard via cfe-commits
https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/128274 >From 2110f92892dd72dfbe1a7d87116faa3693c7c586 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Sat, 22 Feb 2025 03:08:24 + Subject: [PATCH 1/7] workflows/release-binaries: Enable Windows x86 builds ---

[clang] [llvm] workflows/release-binaries: Enable Windows x86 builds (PR #128274)

2025-07-26 Thread Tom Stellard via cfe-commits
https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/128274 >From 2110f92892dd72dfbe1a7d87116faa3693c7c586 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Sat, 22 Feb 2025 03:08:24 + Subject: [PATCH 1/6] workflows/release-binaries: Enable Windows x86 builds ---

[clang-tools-extra] [clang-tidy] Add `-std` argument in `check_clang_tidy.py` for C files (PR #150791)

2025-07-26 Thread Nicolas van Kempen via cfe-commits
@@ -374,15 +373,25 @@ def parse_arguments() -> Tuple[argparse.Namespace, List[str]]: parser.add_argument( "-std", type=csv, -default=["c++11-or-later"], +default=None, help="Passed to clang. Special -or-later values are expanded.",

[clang-tools-extra] [clang-tidy] Add `-std` argument in `check_clang_tidy.py` for C files (PR #150791)

2025-07-26 Thread Victor Chernyakin via cfe-commits
https://github.com/localspook edited https://github.com/llvm/llvm-project/pull/150791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Stop ignoring `-std` argument in `check_clang_tidy.py` for C files (PR #150791)

2025-07-26 Thread Victor Chernyakin via cfe-commits
https://github.com/localspook edited https://github.com/llvm/llvm-project/pull/150791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Stop ignoring `-std` argument in `check_clang_tidy.py` for C files (PR #150791)

2025-07-26 Thread Victor Chernyakin via cfe-commits
@@ -1,4 +1,4 @@ -// RUN: %check_clang_tidy %s readability-non-const-parameter %t +// RUN: %check_clang_tidy -std=c99,c11,c17 %s readability-non-const-parameter %t localspook wrote: The single test case in this file is a K&R-style function, so I don't think ther

[clang-tools-extra] [clang-tidy] Stop ignoring `-std` argument in `check_clang_tidy.py` for C files (PR #150791)

2025-07-26 Thread Victor Chernyakin via cfe-commits
@@ -19,13 +18,16 @@ void notRelated(int A, int B) {} int addedTogether(int A, int B) { return add(A, B); } // NO-WARN: Passed to same function. +// FIXME: This triggers a false positive: the "passed to same function" heuristic +// can't map the parameter index 1 to A and B

[clang-tools-extra] [clang-tidy] Stop ignoring `-std` argument in `check_clang_tidy.py` for C files (PR #150791)

2025-07-26 Thread Victor Chernyakin via cfe-commits
@@ -5,14 +5,14 @@ // parsing and preprocessor state will not have that case. // UNSUPPORTED: target={{.*-(ps4|ps5)}} // -// RUN: %check_clang_tidy -check-suffix=WITH-ANNEX-K%s bugprone-unsafe-functions %t -- -- -D__STDC_LIB_EXT1__=1 -D__STDC_WANT_LIB_EXT1__=1 -//

[clang-tools-extra] [clang-tidy] Stop ignoring `-std` argument in `check_clang_tidy.py` for C files (PR #150791)

2025-07-26 Thread Victor Chernyakin via cfe-commits
@@ -374,15 +373,25 @@ def parse_arguments() -> Tuple[argparse.Namespace, List[str]]: parser.add_argument( "-std", type=csv, -default=["c++11-or-later"], +default=None, help="Passed to clang. Special -or-later values are expanded.",

[clang-tools-extra] [clang-tidy] Stop ignoring `-std` argument in `check_clang_tidy.py` for C files (PR #150791)

2025-07-26 Thread Victor Chernyakin via cfe-commits
https://github.com/localspook updated https://github.com/llvm/llvm-project/pull/150791 >From 20eb165f1abd9bf7976a2c401579a1284258e13e Mon Sep 17 00:00:00 2001 From: Victor Chernyakin Date: Sat, 26 Jul 2025 11:52:19 -0700 Subject: [PATCH 1/3] [clang-tidy] Stop ignoring `-std` argument in `check

[clang] [llvm] Conditionalize use of POSIX features missing on WASI/WebAssembly (PR #92677)

2025-07-26 Thread via cfe-commits
whitequark wrote: Now that WASI SDK has `` support in `wasm32-wasip1` (the single-threaded target) it is time to revisit the PR, as I believe all other changes do not require upstream WASI SDK work. https://github.com/llvm/llvm-project/pull/92677 ___

[clang] [Clang][Sema] Expression in assumption attribute should be full expression (PR #150814)

2025-07-26 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 approved this pull request. https://github.com/llvm/llvm-project/pull/150814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Expression in assumption attribute should be full expression (PR #150814)

2025-07-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Yanzuo Liu (zwuis) Changes Add missing `ActOnFinishFullExpr` to `BuildCXXAssumeExpr`. We did it during template instantiation but forgot non-template case. --- Full diff: https://github.com/llvm/llvm-project/pull/150814.diff 5 Files Aff

[clang] [Clang][Sema] Expression in assumption attribute should be full expression (PR #150814)

2025-07-26 Thread Yanzuo Liu via cfe-commits
https://github.com/zwuis created https://github.com/llvm/llvm-project/pull/150814 Add missing `ActOnFinishFullExpr` to `BuildCXXAssumeExpr`. We did it during template instantiation but forgot non-template case. >From 28d6be07b613662c5a0d9491c67cf880eb42eadc Mon Sep 17 00:00:00 2001 From: Yanzu

[clang] [llvm] Conditionalize use of POSIX features missing on WASI/WebAssembly (PR #92677)

2025-07-26 Thread via cfe-commits
https://github.com/whitequark updated https://github.com/llvm/llvm-project/pull/92677 >From 44c7dadc811107e59e1e47c270230354c4fe7db6 Mon Sep 17 00:00:00 2001 From: Catherine Date: Sun, 19 May 2024 04:41:27 + Subject: [PATCH] Conditionalize use of POSIX features missing on WASI/WebAssembly.

[clang-tools-extra] 59fdd97 - [clang-tidy][NFC] typo in UseUsingCheck

2025-07-26 Thread Congcong Cai via cfe-commits
Author: Congcong Cai Date: 2025-07-27T10:11:06+08:00 New Revision: 59fdd97fe6d4e84d653cd005cddb50c1f2eedcb7 URL: https://github.com/llvm/llvm-project/commit/59fdd97fe6d4e84d653cd005cddb50c1f2eedcb7 DIFF: https://github.com/llvm/llvm-project/commit/59fdd97fe6d4e84d653cd005cddb50c1f2eedcb7.diff

[clang] [llvm] [MemCpyOpt] add memcpy removal for write-once dest (PR #150808)

2025-07-26 Thread Jameson Nash via cfe-commits
https://github.com/vtjnash edited https://github.com/llvm/llvm-project/pull/150808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [MemCpyOpt] add memcpy removal for write-once dest (PR #150808)

2025-07-26 Thread Jameson Nash via cfe-commits
https://github.com/vtjnash created https://github.com/llvm/llvm-project/pull/150808 When code has the pattern of an alloca written only by memcpy followed by just reads of that result, we can remove the memcpy if we can show it legal to just forward the users to the source directly. This is a

[clang] [flang] [mlir] [mlir][core] Move `InitAll***` implementation into static library. (PR #150805)

2025-07-26 Thread Ivan Butygin via cfe-commits
https://github.com/Hardcode84 created https://github.com/llvm/llvm-project/pull/150805 `InitAll***` functions are used by `opt`-style tools to init all MLIR dialects/passes/extensions. Currently they are implemeted as inline functions and include essentially the entire MLIR header tree. Each f

[clang-tools-extra] [clang-tidy] Stop ignoring `-std` argument in `check_clang_tidy.py` for C files (PR #150791)

2025-07-26 Thread Baranov Victor via cfe-commits
@@ -5,14 +5,14 @@ // parsing and preprocessor state will not have that case. // UNSUPPORTED: target={{.*-(ps4|ps5)}} // -// RUN: %check_clang_tidy -check-suffix=WITH-ANNEX-K%s bugprone-unsafe-functions %t -- -- -D__STDC_LIB_EXT1__=1 -D__STDC_WANT_LIB_EXT1__=1 -//

[clang-tools-extra] [clang-tidy] Stop ignoring `-std` argument in `check_clang_tidy.py` for C files (PR #150791)

2025-07-26 Thread Baranov Victor via cfe-commits
@@ -19,13 +18,16 @@ void notRelated(int A, int B) {} int addedTogether(int A, int B) { return add(A, B); } // NO-WARN: Passed to same function. +// FIXME: This triggers a false positive: the "passed to same function" heuristic +// can't map the parameter index 1 to A and B

[clang-tools-extra] [clang-tidy] Stop ignoring `-std` argument in `check_clang_tidy.py` for C files (PR #150791)

2025-07-26 Thread Baranov Victor via cfe-commits
@@ -374,15 +373,25 @@ def parse_arguments() -> Tuple[argparse.Namespace, List[str]]: parser.add_argument( "-std", type=csv, -default=["c++11-or-later"], +default=None, help="Passed to clang. Special -or-later values are expanded.",

[clang-tools-extra] [clang-tidy] Stop ignoring `-std` argument in `check_clang_tidy.py` for C files (PR #150791)

2025-07-26 Thread Baranov Victor via cfe-commits
@@ -1,4 +1,4 @@ -// RUN: %check_clang_tidy %s readability-non-const-parameter %t +// RUN: %check_clang_tidy -std=c99,c11,c17 %s readability-non-const-parameter %t vbvictor wrote: It didn't work with c23? Please leave a fixme. https://github.com/llvm/llvm-projec

[clang-tools-extra] [clang-tidy] Stop ignoring `-std` argument in `check_clang_tidy.py` for C files (PR #150791)

2025-07-26 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/150791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Stop ignoring `-std` argument in `check_clang_tidy.py` for C files (PR #150791)

2025-07-26 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor commented: Thank you for working on this. This change is worth ReleaseNotes IMO, you could add them, we had [release notes ](https://github.com/llvm/llvm-project/blob/release/21.x/clang-tools-extra/docs/ReleaseNotes.rst#improvements-to-clang-tidy)for change in `chec

[clang-tools-extra] [clang-tidy] Stop ignoring `-std` argument in `check_clang_tidy.py` for C files (PR #150791)

2025-07-26 Thread Victor Chernyakin via cfe-commits
https://github.com/localspook updated https://github.com/llvm/llvm-project/pull/150791 >From 20eb165f1abd9bf7976a2c401579a1284258e13e Mon Sep 17 00:00:00 2001 From: Victor Chernyakin Date: Sat, 26 Jul 2025 11:52:19 -0700 Subject: [PATCH 1/2] [clang-tidy] Stop ignoring `-std` argument in `check

[clang-tools-extra] [clang-tidy] Teach `readability-uppercase-literal-suffix` about C++23 and C23 suffixes (PR #148275)

2025-07-26 Thread Baranov Victor via cfe-commits
@@ -0,0 +1,162 @@ +// TODO: When Clang adds support for decimal floating point types, enable these tests by: +//1. Removing all the #if 0 + #endif guards. +//2. Removing all occurrences of the string "DISABLED-" in this file. +//3. Deleting this message. + +// RUN: %c

[clang-tools-extra] [clang-tidy] Teach `readability-uppercase-literal-suffix` about C++23 and C23 suffixes (PR #148275)

2025-07-26 Thread Baranov Victor via cfe-commits
@@ -0,0 +1,162 @@ +// TODO: When Clang adds support for decimal floating point types, enable these tests by: +//1. Removing all the #if 0 + #endif guards. +//2. Removing all occurrences of the string "DISABLED-" in this file. +//3. Deleting this message. + +// RUN: %c

[clang-tools-extra] [clang-tidy] Stop ignoring `-std` argument in `check_clang_tidy.py` for C files (PR #150791)

2025-07-26 Thread Victor Chernyakin via cfe-commits
https://github.com/localspook edited https://github.com/llvm/llvm-project/pull/150791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Stop ignoring `-std` argument in `check_clang_tidy.py` for C files (PR #150791)

2025-07-26 Thread Victor Chernyakin via cfe-commits
https://github.com/localspook updated https://github.com/llvm/llvm-project/pull/150791 >From 20eb165f1abd9bf7976a2c401579a1284258e13e Mon Sep 17 00:00:00 2001 From: Victor Chernyakin Date: Sat, 26 Jul 2025 11:52:19 -0700 Subject: [PATCH] [clang-tidy] Stop ignoring `-std` argument in `check_cla

[clang-tools-extra] [clang-tidy] Teach `readability-uppercase-literal-suffix` about C++23 and C23 suffixes (PR #148275)

2025-07-26 Thread Victor Chernyakin via cfe-commits
@@ -0,0 +1,162 @@ +// TODO: When Clang adds support for decimal floating point types, enable these tests by: +//1. Removing all the #if 0 + #endif guards. +//2. Removing all occurrences of the string "DISABLED-" in this file. +//3. Deleting this message. + +// RUN: %c

[clang-tools-extra] [clang-tidy] Stop ignoring `-std` argument in `check_clang_tidy.py` for C files (PR #150791)

2025-07-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Victor Chernyakin (localspook) Changes Before, the tests were run with whatever Clang defaults to when you don't specify a standard. The tests are adapted to account for various things: - `typeof` is changed to `__typeof__`; the non

[clang-tools-extra] [clang-tidy] Stop ignoring `-std` argument in `check_clang_tidy.py` for C files (PR #150791)

2025-07-26 Thread Victor Chernyakin via cfe-commits
https://github.com/localspook created https://github.com/llvm/llvm-project/pull/150791 Before, the tests were run with whatever Clang defaults to when you don't specify a standard. The tests are adapted to account for various things: - `typeof` is changed to `__typeof__`; the non-`__ugly__` s

[clang] [CMake][Release] Build with -ffat-lto-objects (PR #140381)

2025-07-26 Thread Nikita Popov via cfe-commits
https://github.com/nikic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/140381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] [clangd] introduce doxygen parser (PR #150790)

2025-07-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (tcottin) Changes Followup work of #140498 to continue the work on clangd/clangd#529 Introduce the use of the Clang doxygen parser to parse the documentation of hovered code. - ASTContext independent doxygen parsing - Parsing doxyge

[clang] [clang-tools-extra] [llvm] [clangd] introduce doxygen parser (PR #150790)

2025-07-26 Thread via cfe-commits
https://github.com/tcottin created https://github.com/llvm/llvm-project/pull/150790 Followup work of #140498 to continue the work on clangd/clangd#529 Introduce the use of the Clang doxygen parser to parse the documentation of hovered code. - ASTContext independent doxygen parsing - Parsing d

[clang] [llvm] [Clang][CUDA] Add support for __managed__ variables in non-RDC and default RDC mode (PR #149716)

2025-07-26 Thread via cfe-commits
https://github.com/Acthinks updated https://github.com/llvm/llvm-project/pull/149716 >From 1c7384eef864830fd5d4d4a7e4cf5455bda8d623 Mon Sep 17 00:00:00 2001 From: actink Date: Fri, 11 Jul 2025 15:58:09 +0800 Subject: [PATCH] [Clang][CUDA] Add support for __managed__ variables in non-RDC and de

[clang] [CIR][NFC] Fix an unused variable warning (PR #150758)

2025-07-26 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko approved this pull request. lgtm https://github.com/llvm/llvm-project/pull/150758 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR][NFC] Fix an unused variable warning (PR #150758)

2025-07-26 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko edited https://github.com/llvm/llvm-project/pull/150758 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CMake][Release] Build with -ffat-lto-objects (PR #140381)

2025-07-26 Thread Tom Stellard via cfe-commits
@@ -0,0 +1,5 @@ +file(GLOB files ${CPACK_TEMPORARY_INSTALL_DIRECTORY}/lib/*.a ${CPACK_TEMPORARY_INSTALL_DIRECTORY}/lib/*.so*) tstellar wrote: I checked and they don't, so I've dropped this part. https://github.com/llvm/llvm-project/pull/140381 _

[clang] [CIR] Add poison attribute (PR #150760)

2025-07-26 Thread Henrich Lauko via cfe-commits
@@ -629,6 +629,11 @@ static Value tryFoldCastChain(cir::CastOp op) { } OpFoldResult cir::CastOp::fold(FoldAdaptor adaptor) { + if (mlir::isa_and_present(adaptor.getSrc())) { +// Propagate poison value +return PoisonAttr::get(getContext(), getType());

[clang] [CIR] Add poison attribute (PR #150760)

2025-07-26 Thread Henrich Lauko via cfe-commits
@@ -2239,16 +2249,18 @@ static OpFoldResult foldUnaryBitOp(mlir::Attribute inputAttr, llvm::function_ref func, bool poisonZero = false) { + if (mlir::isa_and_present(inputAttr)) { +// Propagate poison value +return inputAttr; + } + aut

[clang] [CIR] Add poison attribute (PR #150760)

2025-07-26 Thread Henrich Lauko via cfe-commits
@@ -1783,6 +1788,11 @@ static bool isBoolNot(cir::UnaryOp op) { // // and the argument of the first one (%0) will be used instead. OpFoldResult cir::UnaryOp::fold(FoldAdaptor adaptor) { + if (auto poison = mlir::dyn_cast_if_present(adaptor.getInput())) { xlau

[clang] [CIR] Add poison attribute (PR #150760)

2025-07-26 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko approved this pull request. lgtm, with minot nits https://github.com/llvm/llvm-project/pull/150760 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Add poison attribute (PR #150760)

2025-07-26 Thread Henrich Lauko via cfe-commits
@@ -127,7 +127,7 @@ def CIR_BoolAttr : CIR_Attr<"Bool", "bool", [TypedAttrInterface]> { // ZeroAttr //===--===// -def ZeroAttr : CIR_TypedAttr<"Zero", "zero"> { +def CIR_ZeroAttr : CIR_TypedAttr<"Zero", "zer

[clang] [CIR] Add poison attribute (PR #150760)

2025-07-26 Thread Henrich Lauko via cfe-commits
@@ -138,14 +138,26 @@ def ZeroAttr : CIR_TypedAttr<"Zero", "zero"> { // UndefAttr //===--===// -def UndefAttr : CIR_TypedAttr<"Undef", "undef"> { +def CIR_UndefAttr : CIR_TypedAttr<"Undef", "undef"> { ---

[clang] [CIR] Add poison attribute (PR #150760)

2025-07-26 Thread Henrich Lauko via cfe-commits
@@ -2307,6 +2319,12 @@ OpFoldResult ByteSwapOp::fold(FoldAdaptor adaptor) { } OpFoldResult RotateOp::fold(FoldAdaptor adaptor) { + if (mlir::isa_and_present(adaptor.getInput()) || + mlir::isa_and_present(adaptor.getAmount())) { +// Propagate poison values +return

[clang] [CMake][Release] Build with -ffat-lto-objects (PR #140381)

2025-07-26 Thread Tom Stellard via cfe-commits
https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/140381 >From 24975b0426a779c6ee109f90e8b4cb09b826a18c Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Sat, 17 May 2025 16:40:51 + Subject: [PATCH 1/2] [CMake][Release] Build with -ffat-lto-objects Fixes #133580

[clang] [CIR] Add poison attribute (PR #150760)

2025-07-26 Thread Henrich Lauko via cfe-commits
@@ -2239,16 +2249,18 @@ static OpFoldResult foldUnaryBitOp(mlir::Attribute inputAttr, llvm::function_ref func, bool poisonZero = false) { + if (mlir::isa_and_present(inputAttr)) { xlauko wrote: ```suggestion if (mlir::isa_and_p

[clang] [CIR] Add poison attribute (PR #150760)

2025-07-26 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko edited https://github.com/llvm/llvm-project/pull/150760 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Reland "[clangd] Add tweak to override pure virtuals" (PR #150788)

2025-07-26 Thread Marco Maia via cfe-commits
marcogmaia wrote: FYI @kadircet @qinkunbao, thank you both for your time. https://github.com/llvm/llvm-project/pull/150788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Reland "[clangd] Add tweak to override pure virtuals" (PR #150788)

2025-07-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangd Author: Marco Maia (marcogmaia) Changes This relands commit https://github.com/llvm/llvm-project/commit/7355ea3f6b214d1569da43d02f9a166ff15012e6. The original commit was reverted in https://github.com/llvm/llvm-project/commit/bfd73a5161608e6355

[clang-tools-extra] Reland "[clangd] Add tweak to override pure virtuals" (PR #150788)

2025-07-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Marco Maia (marcogmaia) Changes This relands commit https://github.com/llvm/llvm-project/commit/7355ea3f6b214d1569da43d02f9a166ff15012e6. The original commit was reverted in https://github.com/llvm/llvm-project/commit/bfd73a5

[clang-tools-extra] Reland "[clangd] Add tweak to override pure virtuals" (PR #150788)

2025-07-26 Thread Marco Maia via cfe-commits
https://github.com/marcogmaia created https://github.com/llvm/llvm-project/pull/150788 This relands commit https://github.com/llvm/llvm-project/commit/7355ea3f6b214d1569da43d02f9a166ff15012e6. The original commit was reverted in https://github.com/llvm/llvm-project/commit/bfd73a5161608e6355f7

[clang] [clang-repl] adding documentation and information for %commands (PR #150348)

2025-07-26 Thread Aaron Danen via cfe-commits
aadanen wrote: @DavidSpickett I've added %undo to the documentation and implemented %help. Would it be good to also add %help to the documentation? To print stuff, I am just using printf(). Is this fine? It would be easy to switch to std::cout or it looks like there are some llvm print functio

[clang] [clang-repl] adding documentation and information for %commands (PR #150348)

2025-07-26 Thread Aaron Danen via cfe-commits
https://github.com/aadanen updated https://github.com/llvm/llvm-project/pull/150348 >From 4e24cb20efa22e364d41026ae40aec470ff786aa Mon Sep 17 00:00:00 2001 From: Aaron Danen Date: Wed, 23 Jul 2025 18:01:14 -0700 Subject: [PATCH 1/4] added undo to docs in same format as %quit --- clang/docs/Cl

[clang] [clang-repl] adding documentation and information for %commands (PR #150348)

2025-07-26 Thread Aaron Danen via cfe-commits
https://github.com/aadanen updated https://github.com/llvm/llvm-project/pull/150348 >From 4e24cb20efa22e364d41026ae40aec470ff786aa Mon Sep 17 00:00:00 2001 From: Aaron Danen Date: Wed, 23 Jul 2025 18:01:14 -0700 Subject: [PATCH 1/3] added undo to docs in same format as %quit --- clang/docs/Cl

[clang] [clang][SYCL] Add sycl_external attribute and restrict emitting device code (PR #140282)

2025-07-26 Thread via cfe-commits
@@ -1641,6 +1641,13 @@ def DeviceKernel : DeclOrTypeAttr { }]; } +def SYCLExternal : InheritableAttr { + let Spellings = [Clang<"sycl_external">]; schittir wrote: This change fails two tests; will fix. Clang :: CodeGenSPIRV/Builtins/generic_cast_to_ptr_ex

[clang] [clang][NFC] Add header comment for OSLog.cpp (PR #148537)

2025-07-26 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-aarch64-sve-vla` running on `linaro-g3-04` while building `clang` at step 7 "ninja check 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/17/builds/9809 Here is the relevant piece of the buil

[clang] [Clang][CodeGen] Emit “trap reasons” on UBSan traps (PR #145967)

2025-07-26 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-arm-ubuntu` running on `linaro-lldb-arm-ubuntu` while building `clang` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/19589 Here is the relevant piece of the build lo

[clang] [Clang][CodeGen] Emit “trap reasons” on UBSan traps (PR #145967)

2025-07-26 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-aarch64-quick` running on `linaro-clang-aarch64-quick` while building `clang` at step 5 "ninja check 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/65/builds/20240 Here is the relevant pie

[clang] [Clang][CodeGen] Emit “trap reasons” on UBSan traps (PR #145967)

2025-07-26 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `fuchsia-x86_64-linux` running on `fuchsia-debian-64-us-central1-a-1` while building `clang` at step 4 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/11/builds/20443 Here is the relevant

[clang] [Clang][CodeGen] Emit “trap reasons” on UBSan traps (PR #145967)

2025-07-26 Thread via cfe-commits
github-actions[bot] wrote: @anthonyhatran Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a

[clang] [Clang][CodeGen] Emit “trap reasons” on UBSan traps (PR #145967)

2025-07-26 Thread Dan Liew via cfe-commits
https://github.com/delcypher closed https://github.com/llvm/llvm-project/pull/145967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 29992cf - [Clang][CodeGen] Emit “trap reasons” on UBSan traps (#145967)

2025-07-26 Thread via cfe-commits
Author: Anthony Tran Date: 2025-07-26T08:50:25-07:00 New Revision: 29992cfd628ed5b968ccb73b17ed0521382ba317 URL: https://github.com/llvm/llvm-project/commit/29992cfd628ed5b968ccb73b17ed0521382ba317 DIFF: https://github.com/llvm/llvm-project/commit/29992cfd628ed5b968ccb73b17ed0521382ba317.diff

[clang-tools-extra] [clang-tidy] Fix linking regression in clangTidyLLVMModule (PR #150769)

2025-07-26 Thread Michał Górny via cfe-commits
https://github.com/mgorny closed https://github.com/llvm/llvm-project/pull/150769 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CMake][Release] Build with -ffat-lto-objects (PR #140381)

2025-07-26 Thread Tobias Hieta via cfe-commits
tru wrote: > > How much slower is this? Last time I tested fatlto in our toolchain it took > > a VERY long time to link. > > > > You're probably thinking about "full" LTO, this is fat thin LTO. Our naming > is truly amazing. See https://llvm.org/docs/FatLTO.html. > > > > It should add abo

[clang-tools-extra] fa79c23 - [clang-tidy] Fix linking regression in clangTidyLLVMModule (#150769)

2025-07-26 Thread via cfe-commits
Author: Michał Górny Date: 2025-07-26T17:22:18+02:00 New Revision: fa79c23ecc23d6e8a6956d9caedd0443ecdb5853 URL: https://github.com/llvm/llvm-project/commit/fa79c23ecc23d6e8a6956d9caedd0443ecdb5853 DIFF: https://github.com/llvm/llvm-project/commit/fa79c23ecc23d6e8a6956d9caedd0443ecdb5853.diff

[clang] [llvm] [ObjCARC] Completely remove ObjCARCAPElimPass (PR #150717)

2025-07-26 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `fuchsia-x86_64-linux` running on `fuchsia-debian-64-us-central1-b-1` while building `clang,llvm` at step 4 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/11/builds/20441 Here is the rele

[clang-tools-extra] [clang-tidy] Fix linking regression in clangTidyLLVMModule (PR #150769)

2025-07-26 Thread Michał Górny via cfe-commits
mgorny wrote: Thanks! https://github.com/llvm/llvm-project/pull/150769 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CMake][Release] Build with -ffat-lto-objects (PR #140381)

2025-07-26 Thread Nikita Popov via cfe-commits
nikic wrote: > How much slower is this? Last time I tested fatlto in our toolchain it took a > VERY long time to link. You're probably thinking about "full" LTO, this is fat thin LTO. Our naming is truly amazing. See https://llvm.org/docs/FatLTO.html. It should add about 10% overhead. https:

[clang-tools-extra] [clang-tidy] Add MLIR check for old op builder usage. (PR #149148)

2025-07-26 Thread Michał Górny via cfe-commits
mgorny wrote: Yeah, I can. https://github.com/llvm/llvm-project/pull/149148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ObjCARC] Completely remove ObjCARCAPElimPass (PR #150717)

2025-07-26 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs closed https://github.com/llvm/llvm-project/pull/150717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f2fe471 - [ObjCARC] Completely remove ObjCARCAPElimPass (#150717)

2025-07-26 Thread via cfe-commits
Author: AZero13 Date: 2025-07-26T08:07:27-07:00 New Revision: f2fe4718aa162f05adf9ef09fce86fd076cf2706 URL: https://github.com/llvm/llvm-project/commit/f2fe4718aa162f05adf9ef09fce86fd076cf2706 DIFF: https://github.com/llvm/llvm-project/commit/f2fe4718aa162f05adf9ef09fce86fd076cf2706.diff LOG:

[clang] [llvm] [ObjCARC] Completely remove ObjCARCAPElimPass (PR #150717)

2025-07-26 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs approved this pull request. https://github.com/llvm/llvm-project/pull/150717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add MLIR check for old op builder usage. (PR #149148)

2025-07-26 Thread Jacques Pienaar via cfe-commits
jpienaar wrote: Thanks! Done, I assume you can submit once it passes? Else, let me know. https://github.com/llvm/llvm-project/pull/149148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang-tools-extra] [clang-tidy] Fix linking regression in clangTidyLLVMModule (PR #150769)

2025-07-26 Thread Jacques Pienaar via cfe-commits
https://github.com/jpienaar approved this pull request. https://github.com/llvm/llvm-project/pull/150769 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add MLIR check for old op builder usage. (PR #149148)

2025-07-26 Thread Michał Górny via cfe-commits
mgorny wrote: Confirmed that #150769 fixes the issue. I'd appreciate if you could review it promptly, so I could do a fresh clean build and check for more issues today. https://github.com/llvm/llvm-project/pull/149148 ___ cfe-commits mailing list cfe-

[clang-tools-extra] [clang-tidy] Fix linking regression in clangTidyLLVMModule (PR #150769)

2025-07-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Michał Górny (mgorny) Changes Fix the regression introduced in #149148 that incorrectly explicitly linked `clangTransformer` when dylib was used. As a result, the executables linking to `clangTidyLLVMModule` would end up linking bot

[clang-tools-extra] [clang-tidy] Fix linking regression in clangTidyLLVMModule (PR #150769)

2025-07-26 Thread Michał Górny via cfe-commits
https://github.com/mgorny created https://github.com/llvm/llvm-project/pull/150769 Fix the regression introduced in #149148 that incorrectly explicitly linked `clangTransformer` when dylib was used. As a result, the executables linking to `clangTidyLLVMModule` would end up linking both the dy

[clang] [CMake][Release] Build with -ffat-lto-objects (PR #140381)

2025-07-26 Thread Tobias Hieta via cfe-commits
tru wrote: How much slower is this? Last time I tested fatlto in our toolchain it took a VERY long time to link. https://github.com/llvm/llvm-project/pull/140381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang] [CMake][Release] Build with -ffat-lto-objects (PR #140381)

2025-07-26 Thread Nikita Popov via cfe-commits
@@ -0,0 +1,5 @@ +file(GLOB files ${CPACK_TEMPORARY_INSTALL_DIRECTORY}/lib/*.a ${CPACK_TEMPORARY_INSTALL_DIRECTORY}/lib/*.so*) nikic wrote: I don't think we need `*.so` here? Those shouldn't contain LTO bitcode, right? https://github.com/llvm/llvm-project/pull/1

[clang-tools-extra] [clang-tidy] Add MLIR check for old op builder usage. (PR #149148)

2025-07-26 Thread Jacques Pienaar via cfe-commits
jpienaar wrote: Yeah I was wondering if linkage related as that's only way with the code not running that it could have impact. Definitely not intentionally skipping it ... Well and it also explains why I couldn't see anything different while trying different sanitizers, as I wasn't doing any

[clang-tools-extra] [clang-tidy] Add MLIR check for old op builder usage. (PR #149148)

2025-07-26 Thread Michał Górny via cfe-commits
mgorny wrote: (I'm trying a patch, will send a PR in a minute if it works) https://github.com/llvm/llvm-project/pull/149148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add MLIR check for old op builder usage. (PR #149148)

2025-07-26 Thread Michał Górny via cfe-commits
mgorny wrote: Oh, I think I know what's wrong here. ```diff diff --git a/clang-tools-extra/clang-tidy/llvm/CMakeLists.txt b/clang-tools-extra/clang-tidy/llvm/CMakeLists.txt index 3232f6e2cafe..4f1da43d3f1b 100644 --- a/clang-tools-extra/clang-tidy/llvm/CMakeLists.txt +++ b/clang-tools-extra/cla

[clang] [CMake][Release] Build with -ffat-lto-objects (PR #140381)

2025-07-26 Thread Tom Stellard via cfe-commits
tstellar wrote: I figured out how to strip the binaries, so I've updated the patch. Though, you could argue that people should only be using these libraries with the compiler that comes with the release package, and in that case the LTO bitcode would be useful. However, the release package is

[clang] [CMake][Release] Build with -ffat-lto-objects (PR #140381)

2025-07-26 Thread Tom Stellard via cfe-commits
https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/140381 >From 24975b0426a779c6ee109f90e8b4cb09b826a18c Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Sat, 17 May 2025 16:40:51 + Subject: [PATCH] [CMake][Release] Build with -ffat-lto-objects Fixes #133580 ---

[clang] [Clang] Add __has_target_builtin macro (PR #126324)

2025-07-26 Thread Joseph Huber via cfe-commits
jhuber6 wrote: Are there any blockers for this left? https://github.com/llvm/llvm-project/pull/126324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in `DerivePointerAlignment: true` (PR #150744)

2025-07-26 Thread Björn Schäpers via cfe-commits
@@ -2641,28 +2641,19 @@ class Formatter : public TokenAnalyzer { int AlignmentDiff = 0; for (const AnnotatedLine *Line : Lines) { AlignmentDiff += countVariableAlignments(Line->Children); - for (FormatToken *Tok = Line->First; Tok && Tok->Next; Tok = Tok->Nex

[clang] [clang-format] Fix a bug in `DerivePointerAlignment: true` (PR #150744)

2025-07-26 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks approved this pull request. https://github.com/llvm/llvm-project/pull/150744 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] add comments for canBeJoined function (PR #150766)

2025-07-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jongmyeong Choi (jongmyeong-choi) Changes - Convert simple comment to detailed Doxygen-style documentation - Add comprehensive examples of token concatenation cases - Include examples of safe adjacency cases - Clarify the function's purpose

[clang] [clang][NFC] add comments for canBeJoined function (PR #150766)

2025-07-26 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [clang][NFC] add comments for canBeJoined function (PR #150766)

2025-07-26 Thread Jongmyeong Choi via cfe-commits
https://github.com/jongmyeong-choi created https://github.com/llvm/llvm-project/pull/150766 - Convert simple comment to detailed Doxygen-style documentation - Add comprehensive examples of token concatenation cases - Include examples of safe adjacency cases - Clarify the function's purpose and r

[clang-tools-extra] [clang-tidy] Add MLIR check for old op builder usage. (PR #149148)

2025-07-26 Thread Michał Górny via cfe-commits
mgorny wrote: Well, that's what bisect said for me. 889faabe78d2cb182414430601d6da2ed6619be3 passed, 3feb6f971577701713034d3404b6737fe6462d43 failed. llvm: [llvm-core:llvm-22.0.0.:20250726-132422.log.gz](https://github.com/user-attachments/files/21444961/llvm-core

[clang] [clang][NFC] Add header comment for OSLog.cpp (PR #148537)

2025-07-26 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/148537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 652048a - [clang][NFC] Add header comment for OSLog.cpp (#148537)

2025-07-26 Thread via cfe-commits
Author: Bogdan Vetrenko Date: 2025-07-26T15:46:06+02:00 New Revision: 652048ad2578c715d8d65d90fd3fe5d5d2bd42e7 URL: https://github.com/llvm/llvm-project/commit/652048ad2578c715d8d65d90fd3fe5d5d2bd42e7 DIFF: https://github.com/llvm/llvm-project/commit/652048ad2578c715d8d65d90fd3fe5d5d2bd42e7.dif

[clang-tools-extra] [clang-tidy] Add MLIR check for old op builder usage. (PR #149148)

2025-07-26 Thread Jacques Pienaar via cfe-commits
jpienaar wrote: Those failures don't seem related (no StringSet used here, not activated for abseil checks) https://github.com/llvm/llvm-project/pull/149148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[clang-tools-extra] [clang-tidy] Add MLIR check for old op builder usage. (PR #149148)

2025-07-26 Thread Michał Górny via cfe-commits
mgorny wrote: Tons of failures on Gentoo as well: ``` Total Discovered Tests: 1352 Unsupported : 8 (0.59%) Passed : 399 (29.51%) Expectedly Failed: 1 (0.07%) Failed : 944 (69.82%) ``` At a quick glance, they look like something's segfaulting on exit: ``` FA

[clang-tools-extra] [clang-tidy][mlir] Make rewrite more conservative. (PR #150757)

2025-07-26 Thread Jacques Pienaar via cfe-commits
https://github.com/jpienaar updated https://github.com/llvm/llvm-project/pull/150757 >From 8d1b6ac9820dc17b365546883d18bf852300048e Mon Sep 17 00:00:00 2001 From: Jacques Pienaar Date: Sat, 26 Jul 2025 12:24:14 + Subject: [PATCH 1/2] [clang-tidy][mlir] Make rewrite more conservative. Don't

[clang-tools-extra] [clang-tidy][mlir] Make rewrite more conservative. (PR #150757)

2025-07-26 Thread Jacques Pienaar via cfe-commits
@@ -111,17 +111,24 @@ EditGenerator rewrite(RangeSelector Call, RangeSelector Builder, } RewriteRuleWith useNewMlirOpBuilderCheckRule() { - return makeRule( + Stencil message = cat("use 'OpType::create(builder, ...)' instead of " +"'builder.create(..

  1   2   >