https://github.com/rjmccall requested changes to this pull request.
This all looks good to me. Please add a release note saying that we fixed an
issue where the implementation was stricter than the ARC specification said.
Also, I know that you had some questions around `const` and other qualifi
ChuanqiXu9 wrote:
The direction meets my expectation. I think you already have an existing test
for swift. Maybe you can try to reduce a lit test from it.
https://github.com/llvm/llvm-project/pull/143739
___
cfe-commits mailing list
cfe-commits@lists.
https://github.com/vitor1001 updated
https://github.com/llvm/llvm-project/pull/143664
>From 539e69459aaf59785e9e835aec4fb0c45bbe6afc Mon Sep 17 00:00:00 2001
From: Vitor Sessak
Date: Wed, 11 Jun 2025 08:21:48 +
Subject: [PATCH] Add missing intrinsics to cuda headers.
LLVM prevents the sm_3
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
@@ -17,63 +17,80 @@
#include "clang/AST/APValue.h"
#include "llvm/ADT/APFloat.h"
+// XXX This is just a debugging help. Setting this to 1 will heap-allocate ALL
+// floating values.
+#define ALLOCATE_A
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
https://github.com/tbaederr updated
https://github.com/llvm/llvm-project/pull/144246
>From 9801280bab3f751995c6bc7838ccbadb09d8d208 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?=
Date: Tue, 10 Jun 2025 14:
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Shunsuke Watanabe (s-watanabe314)
Changes
This patch adds a warning for incompatible complex number behavior compared to
GCC due to Clang's "last-flag-wins" rule.
Incompatibilities with GCC occur in the following seven cases. Clang
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Shunsuke Watanabe (s-watanabe314)
Changes
This patch adds a warning for incompatible complex number behavior compared to
GCC due to Clang's "last-flag-wins" rule.
Incompatibilities with GCC occur in the following seven cases. Clang uses t
https://github.com/s-watanabe314 created
https://github.com/llvm/llvm-project/pull/144468
This patch adds a warning for incompatible complex number behavior compared to
GCC due to Clang's "last-flag-wins" rule.
Incompatibilities with GCC occur in the following seven cases. Clang uses the
last
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`openmp-offload-amdgpu-runtime-2` running on `rocm-worker-hw-02` while building
`clang` at step 7 "Add check check-clang".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/10/builds/7482
Here is the re
Author: no92
Date: 2025-06-17T01:51:46-04:00
New Revision: e86740e6003739a41139d94e1643a3207f8fd8f8
URL:
https://github.com/llvm/llvm-project/commit/e86740e6003739a41139d94e1643a3207f8fd8f8
DIFF:
https://github.com/llvm/llvm-project/commit/e86740e6003739a41139d94e1643a3207f8fd8f8.diff
LOG: [cl
https://github.com/brad0 closed https://github.com/llvm/llvm-project/pull/139271
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/svs-quic approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/137854
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
boomanaiden154 wrote:
https://github.com/llvm/llvm-project/blob/b5dbf8210a57b986b9802304745f4c5c108cf37b/libcxx/test/libcxx/language.support/support.c.headers/support.c.headers.other/math.lerp.verify.cpp#L9
Looks like this has occurred before and is just handled by disabling the test
on the lib
https://github.com/ahatanak updated
https://github.com/llvm/llvm-project/pull/144458
>From 180213a360c7b25784f84ada7112b30ee0bd1212 Mon Sep 17 00:00:00 2001
From: Akira Hatanaka
Date: Fri, 13 Jun 2025 15:01:26 -0700
Subject: [PATCH 1/3] [Sema][ObjC] Loosen restrictions on reinterpret_cast
invo
https://github.com/svs-quic approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/144398
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
el-ev wrote:
> Next time please add more details in the summary, this is key for reviewers
> so that they can digest the PR without leaving for more context. Even in very
> simple PRs it is good to do.
>
> For this one something along the lines of `Parser::ParseUsingDeclaration was
> not that
https://github.com/andrurogerz ready_for_review
https://github.com/llvm/llvm-project/pull/144386
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ahatanak updated
https://github.com/llvm/llvm-project/pull/144458
>From 180213a360c7b25784f84ada7112b30ee0bd1212 Mon Sep 17 00:00:00 2001
From: Akira Hatanaka
Date: Fri, 13 Jun 2025 15:01:26 -0700
Subject: [PATCH] [Sema][ObjC] Loosen restrictions on reinterpret_cast
involvin
@@ -0,0 +1,137 @@
+//===--- MoveSharedPointerContentsCheck.cpp - clang-tidy
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
Author: Finn Plummer
Date: 2025-06-16T14:52:59-07:00
New Revision: a383b1a95b63cf120b3dea554c2d66ccfaee066b
URL:
https://github.com/llvm/llvm-project/commit/a383b1a95b63cf120b3dea554c2d66ccfaee066b
DIFF:
https://github.com/llvm/llvm-project/commit/a383b1a95b63cf120b3dea554c2d66ccfaee066b.diff
https://github.com/NewSigma edited
https://github.com/llvm/llvm-project/pull/144319
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ahatanak edited
https://github.com/llvm/llvm-project/pull/144458
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ahatanak updated
https://github.com/llvm/llvm-project/pull/144458
>From 180213a360c7b25784f84ada7112b30ee0bd1212 Mon Sep 17 00:00:00 2001
From: Akira Hatanaka
Date: Fri, 13 Jun 2025 15:01:26 -0700
Subject: [PATCH 1/2] [Sema][ObjC] Loosen restrictions on reinterpret_cast
invo
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Akira Hatanaka (ahatanak)
Changes
Allow using reinterpret_cast for conversions between indirect ARC pointers and
other pointer types.
rdar://153049268
---
Full diff: https://github.com/llvm/llvm-project/pull/144458.diff
4 Files Affecte
https://github.com/ahatanak created
https://github.com/llvm/llvm-project/pull/144458
Allow using reinterpret_cast for conversions between indirect ARC pointers and
other pointer types.
rdar://153049268
>From 7a042947bbedce4e9bbb31b599f8132013bf8f3b Mon Sep 17 00:00:00 2001
From: Akira Hatanak
https://github.com/Ritanya-B-Bharadwaj updated
https://github.com/llvm/llvm-project/pull/135807
>From 9c56e59ba9984c14c15a8d5a95a02e7192a64e8f Mon Sep 17 00:00:00 2001
From: Ritanya B Bharadwaj
Date: Sun, 6 Apr 2025 09:33:06 -0500
Subject: [PATCH 1/5] [OpenMP] Parsing Support of ThreadSets in T
https://github.com/tclin914 edited
https://github.com/llvm/llvm-project/pull/144320
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bryanpkc closed
https://github.com/llvm/llvm-project/pull/143915
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -8243,8 +8259,7 @@ class Sema final : public SemaBase {
/// List of SourceLocations where 'self' is implicitly retained inside a
/// block.
- llvm::SmallVector, 1>
- ImplicitlyRetainedSelfLocs;
+ llvm::SmallVector DiagnosableBlockCaptures;
rjmcca
Author: Bryan Chan
Date: 2025-06-16T20:59:18-04:00
New Revision: d4e2c0b359ea90236fd1b62791a04fb845f5d9f3
URL:
https://github.com/llvm/llvm-project/commit/d4e2c0b359ea90236fd1b62791a04fb845f5d9f3
DIFF:
https://github.com/llvm/llvm-project/commit/d4e2c0b359ea90236fd1b62791a04fb845f5d9f3.diff
LO
@@ -16149,7 +16149,7 @@ class ExitFunctionBodyRAII {
bool IsLambda = false;
};
-static void diagnoseImplicitlyRetainedSelf(Sema &S) {
+static void diagnoseBlockCaptures(Sema &S) {
rjmccall wrote:
Maybe `diagnoseEscapingBlockCaptures`?
https://github.com/ll
@@ -1641,6 +1641,17 @@ def warn_implicitly_retains_self : Warning <
"block implicitly retains 'self'; explicitly mention 'self' to indicate "
"this is intended behavior">,
InGroup>, DefaultIgnore;
+def warn_blocks_capturing_this : Warning<"block implicitly captures 'this'
@@ -1641,6 +1641,17 @@ def warn_implicitly_retains_self : Warning <
"block implicitly retains 'self'; explicitly mention 'self' to indicate "
"this is intended behavior">,
InGroup>, DefaultIgnore;
+def warn_blocks_capturing_this : Warning<"block implicitly captures 'this'
@@ -0,0 +1,60 @@
+#ifndef LLVM_CLANG_SUMMARY_SUMMARYCONTEXT_H
+#define LLVM_CLANG_SUMMARY_SUMMARYCONTEXT_H
+
+#include "clang/Summary/SummaryAttribute.h"
+#include "clang/Summary/SummaryConsumer.h"
+#include
+
+namespace clang {
+class FunctionSummary {
+ SmallVector ID;
---
@@ -611,6 +623,29 @@ class CompilerInstance : public ModuleLoader {
/// the compiler instance takes ownership of \p Value.
void setCodeCompletionConsumer(CodeCompleteConsumer *Value);
+ /// @}
+ /// @name Summary
+ /// @{
+
+ bool hasSummaryContext() { return (bool)Sum
@@ -411,7 +412,48 @@ static void emitAtomicCmpXchg(CodeGenFunction &CGF,
AtomicExpr *E, bool IsWeak,
CGF.Builder.SetInsertPoint(StoreExpectedBB);
// Update the memory at Expected with Old's value.
- CGF.Builder.CreateStore(Old, Val1);
+llvm::Type *ExpectedType = Expected
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `ppc64le-flang-rhel-clang`
running on `ppc64le-flang-rhel-test` while building `clang,llvm` at step 6
"test-build-unified-tree-check-flang".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/157/builds/30
https://github.com/yxsamliu approved this pull request.
LGTM. Thanks
https://github.com/llvm/llvm-project/pull/134016
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AlexVlx wrote:
Gentle ping.
https://github.com/llvm/llvm-project/pull/134016
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Serge Pavlov (spavloff)
Changes
Compiler sometimes issues warnings on exit from 'noreturn' functions, in the
code like:
[[noreturn]] extern void nonreturnable();
void (*func_ptr)();
[[noreturn]] void foo() {
func_ptr = n
https://github.com/Ritanya-B-Bharadwaj updated
https://github.com/llvm/llvm-project/pull/135807
>From 9c56e59ba9984c14c15a8d5a95a02e7192a64e8f Mon Sep 17 00:00:00 2001
From: Ritanya B Bharadwaj
Date: Sun, 6 Apr 2025 09:33:06 -0500
Subject: [PATCH 1/5] [OpenMP] Parsing Support of ThreadSets in T
https://github.com/rnk approved this pull request.
https://github.com/llvm/llvm-project/pull/144407
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1371,6 +1371,19 @@ void MallocChecker::checkIfFreeNameIndex(ProgramStateRef
State,
C.addTransition(State);
}
+const Expr *getPlacementNewBufferArg(const CallExpr *CE,
+ const FunctionDecl *FD) {
+ // Checking for signature:
+ // voi
https://github.com/inbelic closed
https://github.com/llvm/llvm-project/pull/143019
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1661,6 +1661,11 @@ void
CodeGenModule::setGlobalVisibility(llvm::GlobalValue *GV,
return;
}
+ if (Context.getLangOpts().HLSL && !D->isInExportDeclContext()) {
+GV->setVisibility(llvm::GlobalValue::HiddenVisibility);
s-perron wrote:
I'll look i
https://github.com/vbvictor updated
https://github.com/llvm/llvm-project/pull/144274
>From 98fc81696400be2ea990d867375530ef3f544b82 Mon Sep 17 00:00:00 2001
From: Victor Baranov
Date: Sun, 15 Jun 2025 22:20:54 +0300
Subject: [PATCH 1/2] [Clang] Fix '-Wformat-overflow' FP when floats had
field-
https://github.com/llvm-beanz commented:
This looks good to me, but it would be good to get @AaronBallman's eyes on it
too.
https://github.com/llvm/llvm-project/pull/143184
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org
https://github.com/MatzeB closed
https://github.com/llvm/llvm-project/pull/142236
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Matthias Braun
Date: 2025-06-16T12:55:12-07:00
New Revision: b0378e7ca953c2390168f352c5a88fd325cde894
URL:
https://github.com/llvm/llvm-project/commit/b0378e7ca953c2390168f352c5a88fd325cde894
DIFF:
https://github.com/llvm/llvm-project/commit/b0378e7ca953c2390168f352c5a88fd325cde894.diff
https://github.com/ojhunt updated
https://github.com/llvm/llvm-project/pull/144420
>From b43a7e9295dfdbe0a11fb7dff669b82d8ed0630c Mon Sep 17 00:00:00 2001
From: Oliver Hunt
Date: Mon, 16 Jun 2025 20:48:57 +0300
Subject: [PATCH 1/2] [clang][PAC] Support trivially_relocating polymorphic
objects
@@ -420,6 +420,222 @@ void
CodeGenFunction::EmitPointerAuthCopy(PointerAuthQualifier Qual, QualType T,
Builder.CreateStore(Value, DestAddress);
}
+static const ConstantArrayType *tryGetTypeAsConstantArrayType(QualType T) {
+ if (!T->isConstantArrayType())
+return nullp
@@ -1727,6 +1727,11 @@ ASTContext::PointerAuthContent
ASTContext::findPointerAuthContent(QualType T) {
T = T.getCanonicalType();
if (T.hasAddressDiscriminatedPointerAuth())
return PointerAuthContent::AddressDiscriminatedData;
+
+ T = getBaseElementType(T).getCanonical
https://github.com/andykaylor closed
https://github.com/llvm/llvm-project/pull/144165
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Oliver Hunt (ojhunt)
Changes
Adds support for trivial relocation of polymorphic objects with address
discriminated vtable pointers.
This is implemented as a post-memmove fixup pass over the impacted objects. We
do this by traversing the
https://github.com/ojhunt created
https://github.com/llvm/llvm-project/pull/144420
Adds support for trivial relocation of polymorphic objects with address
discriminated vtable pointers.
This is implemented as a post-memmove fixup pass over the impacted objects. We
do this by traversing the ob
@@ -1442,6 +1442,10 @@ class ASTReader
const StringRef &operator*() && = delete;
};
+ /// VarDecls with initializers containing side effects must be emitted,
+ /// but DeclMustBeEmitted is not allowed to deserialize the intializer.
+ llvm::SmallPtrSet InitSideEffectVa
https://github.com/spavloff created
https://github.com/llvm/llvm-project/pull/144408
Compiler sometimes issues warnings on exit from 'noreturn' functions, in the
code like:
[[noreturn]] extern void nonreturnable();
void (*func_ptr)();
[[noreturn]] void foo() {
func_ptr = nonr
higher-performance wrote:
Are folks still on the fence after the latest discussion? If anyone still has
objections I can try to suggest some path forward, but I'm not sure what
everyone is thinking right now (or what this is pending on in general), and it
would be lovely to move forward someho
https://github.com/maryammo updated
https://github.com/llvm/llvm-project/pull/142480
>From 5ef7a4ca7c2a838a6b2100968d5023e0797b2848 Mon Sep 17 00:00:00 2001
From: Maryam Moghadas
Date: Mon, 2 Jun 2025 19:54:57 +
Subject: [PATCH 1/3] [Clang][PowerPC] Add __dmr type and DMF integer
calculati
https://github.com/AmrDeveloper closed
https://github.com/llvm/llvm-project/pull/144223
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
efriedma-quic wrote:
That pattern look like basically the same thing as the neg_one_constexpr
testcase I added. The diagnostic is expected.
Posted #144407 to add a relnote.
https://github.com/llvm/llvm-project/pull/143034
___
cfe-commits mailing lis
llvmbot wrote:
@llvm/pr-subscribers-clang-static-analyzer-1
@llvm/pr-subscribers-clang
Author: Andrew Rogers (andrurogerz)
Changes
## Purpose
This patch makes a minor changes to LLVM and Clang so that LLVM can be built as
a Windows DLL with `clang-cl`. These changes were not required for
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Eli Friedman (efriedma-quic)
Changes
This seems to be having some practical impact, so we should let people know.
---
Full diff: https://github.com/llvm/llvm-project/pull/144407.diff
1 Files Affected:
- (modified) clang/docs/ReleaseNote
https://github.com/efriedma-quic created
https://github.com/llvm/llvm-project/pull/144407
This seems to be having some practical impact, so we should let people know.
>From 72b5793a6b0df71ec78e691aaa1b0729273263e0 Mon Sep 17 00:00:00 2001
From: Eli Friedman
Date: Mon, 16 Jun 2025 11:04:04 -070
AmrDeveloper wrote:
> I have concerns about the CIR representation here. I think we should be
> aligning our representation of complex operations with the MLIR complex
> dialect. As such, we want `__real__` to be lowerable to `complex.re` but the
> explicit representation of intermediate point
@@ -0,0 +1,107 @@
+// RUN: %clang_cc1 -fsyntax-only %s -verify
+
+[[noreturn]] extern void noret();
+[[noreturn]] extern void noret2();
+extern void ordinary();
+
+typedef void (*func_type)(void);
+
+// Constant initialization.
+
+void (* const const_fptr)() = noret;
+[[noreturn]]
@@ -0,0 +1,107 @@
+// RUN: %clang_cc1 -fsyntax-only %s -verify
+
+[[noreturn]] extern void noret();
+[[noreturn]] extern void noret2();
+extern void ordinary();
+
+typedef void (*func_type)(void);
+
+// Constant initialization.
+
+void (* const const_fptr)() = noret;
+[[noreturn]]
https://github.com/AaronBallman commented:
This is an interesting proposed change, thank you for working on it! Please be
sure to add a release note to `clang/docs/ReleaseNotes.rst` about the
functionality.
https://github.com/llvm/llvm-project/pull/144408
__
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/144408
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,107 @@
+// RUN: %clang_cc1 -fsyntax-only %s -verify
+
+[[noreturn]] extern void noret();
+[[noreturn]] extern void noret2();
+extern void ordinary();
+
+typedef void (*func_type)(void);
+
AaronBallman wrote:
Another test case that would be good to add:
@@ -2385,4 +2385,33 @@ def ComplexCreateOp : CIR_Op<"complex.create", [Pure,
SameTypeOperands]> {
let hasFolder = 1;
}
+//===--===//
+// ComplexRealPtrOp
+//===--
@@ -834,8 +834,8 @@ llvm::DIType *CGDebugInfo::CreateType(const BuiltinType
*BT) {
auto *ISATy = DBuilder.createPointerType(ClassTy, Size);
ObjTy = DBuilder.createStructType(TheCU, "objc_object", TheCU->getFile(),
0,
- 0, 0, llvm:
https://github.com/AmrDeveloper updated
https://github.com/llvm/llvm-project/pull/144225
>From d3e1d50ead7822771eb265293f9d0c42e5a74529 Mon Sep 17 00:00:00 2001
From: AmrDeveloper
Date: Sat, 14 Jun 2025 16:21:20 +0200
Subject: [PATCH 1/2] [CIR] Upstream ComplexType builtin_complex
---
clang/l
@@ -834,8 +834,8 @@ llvm::DIType *CGDebugInfo::CreateType(const BuiltinType
*BT) {
auto *ISATy = DBuilder.createPointerType(ClassTy, Size);
ObjTy = DBuilder.createStructType(TheCU, "objc_object", TheCU->getFile(),
0,
- 0, 0, llvm:
Ritanya-B-Bharadwaj wrote:
> 1. Need to rebase.
> 2. I'd suggest to split the patch and land the runtime part separately
Done!
https://github.com/llvm/llvm-project/pull/135807
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.
https://github.com/andykaylor commented:
I have concerns about the CIR representation here. I think we should be
aligning our representation of complex operations with the MLIR complex
dialect. As such, we want `__real__` to be lowerable to `complex.re` but the
explicit representation of inter
https://github.com/andykaylor edited
https://github.com/llvm/llvm-project/pull/144235
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/schittir edited
https://github.com/llvm/llvm-project/pull/140282
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bdunkin wrote:
I will gladly add a new option, if that is deemed necessary. I just want to
make sure that's the direction I should go. My experience has been it is very
hard to take back an option once it has been released, so they should be added
deliberately, and with careful consideration.
@@ -364,7 +364,7 @@ implementation.
+=+===+===+==+
| free-agent threads
https://github.com/pizzud updated
https://github.com/llvm/llvm-project/pull/67467
>From 04a3e8d8cbd6943f44a81fddb0524902202a1a78 Mon Sep 17 00:00:00 2001
From: David Pizzuto
Date: Tue, 26 Sep 2023 10:45:42 -0700
Subject: [PATCH 01/19] [clang-tidy] Add bugprone-move-shared-pointer-contents
chec
Author: Aaron Ballman
Date: 2025-06-16T14:53:15-04:00
New Revision: f83d09a1f60aee28a8ed9020cd72971ec2885f24
URL:
https://github.com/llvm/llvm-project/commit/f83d09a1f60aee28a8ed9020cd72971ec2885f24
DIFF:
https://github.com/llvm/llvm-project/commit/f83d09a1f60aee28a8ed9020cd72971ec2885f24.diff
https://github.com/AaronBallman closed
https://github.com/llvm/llvm-project/pull/144402
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sivadeilra updated
https://github.com/llvm/llvm-project/pull/138972
>From a971e0f2df99bd701b4b2f73ee28ee9b36f8a73f Mon Sep 17 00:00:00 2001
From: Arlie Davis
Date: Thu, 3 Apr 2025 16:10:50 -0700
Subject: [PATCH] Windows hotpatching support
---
clang/include/clang/Basic/Code
https://github.com/pizzud updated
https://github.com/llvm/llvm-project/pull/67467
>From 04a3e8d8cbd6943f44a81fddb0524902202a1a78 Mon Sep 17 00:00:00 2001
From: David Pizzuto
Date: Tue, 26 Sep 2023 10:45:42 -0700
Subject: [PATCH 01/18] [clang-tidy] Add bugprone-move-shared-pointer-contents
chec
@@ -176,3 +176,27 @@ void foo7() {
// OGCG: store float %[[TMP_A]], ptr %[[C_REAL_PTR]], align 4
// OGCG: store float 2.00e+00, ptr %[[C_IMAG_PTR]], align 4
+void foo9(double r, double i) {
+ double _Complex c = __builtin_complex(r, i);
AmrDeveloper wrote
@@ -0,0 +1,137 @@
+//===--- MoveSharedPointerContentsCheck.cpp - clang-tidy
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -148,6 +148,12 @@ New checks
Finds potentially erroneous calls to ``reset`` method on smart pointers when
the pointee type also has a ``reset`` method.
+- New :doc:`bugprone-move-shared-pointer-contents
pizzud wrote:
Done.
https://github.com/llvm/llvm
Ritanya-B-Bharadwaj wrote:
Runtime PR - https://github.com/llvm/llvm-project/pull/144409
https://github.com/llvm/llvm-project/pull/135807
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
https://github.com/benlangmuir commented:
I think this new function should be called from
`ASTContext::DeclMustBeEmitted`, no?
https://github.com/llvm/llvm-project/pull/143739
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.
@@ -1632,6 +1632,10 @@ RedeclarableResult
ASTDeclReader::VisitVarDeclImpl(VarDecl *VD) {
VD->NonParmVarDeclBits.PreviousDeclInSameBlockScope =
VarDeclBits.getNextBit();
+bool hasInitWithSideEffect = VarDeclBits.getNextBit();
benlangmuir wrote:
https://github.com/pizzud updated
https://github.com/llvm/llvm-project/pull/67467
>From 04a3e8d8cbd6943f44a81fddb0524902202a1a78 Mon Sep 17 00:00:00 2001
From: David Pizzuto
Date: Tue, 26 Sep 2023 10:45:42 -0700
Subject: [PATCH 01/18] [clang-tidy] Add bugprone-move-shared-pointer-contents
chec
https://github.com/pizzud updated
https://github.com/llvm/llvm-project/pull/67467
>From 04a3e8d8cbd6943f44a81fddb0524902202a1a78 Mon Sep 17 00:00:00 2001
From: David Pizzuto
Date: Tue, 26 Sep 2023 10:45:42 -0700
Subject: [PATCH 01/17] [clang-tidy] Add bugprone-move-shared-pointer-contents
chec
Author: Andy Kaylor
Date: 2025-06-16T11:26:23-07:00
New Revision: b5c6245cb46354923940b95a89213fa0924e5c5f
URL:
https://github.com/llvm/llvm-project/commit/b5c6245cb46354923940b95a89213fa0924e5c5f
DIFF:
https://github.com/llvm/llvm-project/commit/b5c6245cb46354923940b95a89213fa0924e5c5f.diff
L
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
@@ -17,63 +17,80 @@
#include "clang/AST/APValue.h"
#include "llvm/ADT/APFloat.h"
+// XXX This is just a debugging help. Setting this to 1 will heap-allocate ALL
+// floating values.
+#define ALLOCATE_ALL 0
+
namespace clang {
@@ -8310,8 +8310,6 @@ Stmt *ASTReader::GetExternalDeclStmt(uint64_t Offset) {
Error(std::move(Err));
return nullptr;
}
- assert(NumCurrentElementsDeserializing == 0 &&
benlangmuir wrote:
Can this assert come back now?
https://github.com/llvm/llvm-p
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
@@ -4674,10 +4677,7 @@ VarCreationState Compiler::visitVarDecl(const
VarDecl *VD,
if (!visitInitializer(Init))
return false;
- if (!this->emitFinishInit(Init))
-return false;
-
- return this->e
@@ -2434,6 +2434,22 @@ VarDecl *VarDecl::getInitializingDeclaration() {
return Def;
}
+bool VarDecl::hasInitWithSideEffects() const {
+ if (!hasInit())
+return false;
+
+ if (auto *S = dyn_cast(Init)) {
benlangmuir wrote:
The original code in `getInit
https://github.com/benlangmuir edited
https://github.com/llvm/llvm-project/pull/143739
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
HazardyKnusperkeks wrote:
> > You can't change existing tests, you need an option if you want to pad with
> > spaces
>
> It is unclear to me if this should be considered a bug fix, or a new feature.
> Surely requiring new options are not required for every bug fix.
>
It boils down to the que
1 - 100 of 430 matches
Mail list logo
