[clang] [Clang][NFC] Use `llvm::sort()` (PR #140337)

2025-05-16 Thread Iris Shi via cfe-commits
https://github.com/el-ev updated https://github.com/llvm/llvm-project/pull/140337 >From 935633e4e6b290bbf7f83a559a3cd36c049186c7 Mon Sep 17 00:00:00 2001 From: Iris Shi <0...@owo.li> Date: Sat, 17 May 2025 10:46:46 +0800 Subject: [PATCH] [Clang][NFC] Use `llvm::sort()` --- clang/lib/APINotes/A

[clang] [clang] Remove redundant control flow statements (NFC) (PR #140359)

2025-05-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/140359.diff 9 Files Affected: - (modified) clang/lib/AST/DeclTemplate.cpp (-1) - (modified) clang/lib/CodeGen/CGExprAgg.cpp (-1) - (modifie

[clang] [clang] Remove redundant control flow statements (NFC) (PR #140359)

2025-05-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/140359.diff 9 Files Affected: - (modified) clang/lib/AST/DeclTemplate.cpp (-1) - (modified) clang/lib/CodeGen/CGExprAgg.cpp (-1) - (

[clang] [clang] Remove redundant control flow statements (NFC) (PR #140359)

2025-05-16 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/140359 None >From cc0cb618aae18b3f448cb5504de68cadeb0a4516 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Fri, 16 May 2025 23:46:59 -0700 Subject: [PATCH] [clang] Remove redundant control flow statements (NFC

[clang-tools-extra] [clang-doc] Add helpers for Template config (PR #138062)

2025-05-16 Thread Erick Velez via cfe-commits
https://github.com/evelez7 approved this pull request. https://github.com/llvm/llvm-project/pull/138062 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] libcxx: std::ostream::sentry should be exported (PR #140169)

2025-05-16 Thread via cfe-commits
https://github.com/jeremyd2019 reopened https://github.com/llvm/llvm-project/pull/140169 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] libcxx: std::ostream::sentry should be exported (PR #140169)

2025-05-16 Thread via cfe-commits
https://github.com/jeremyd2019 closed https://github.com/llvm/llvm-project/pull/140169 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-cl] Accept `cl`-style output arguments (`/Fo`, `-Fo`) for `--precompile` (PR #121046)

2025-05-16 Thread Sharadh Rajaraman via cfe-commits
sharadhr wrote: I believe the issue can be distilled further. On the `main` branch, this command outputs `Hello.bmi`, assuming `Hello.cppm` exists and has `export module Hello;`: ``` clang.exe --precompile -x c++-module -o Hello.bmi -c Hello.cppm ``` This command does not: ``` clang-cl.exe --p

[clang] [libcxx] libcxx: std::ostream::sentry should be exported (PR #140169)

2025-05-16 Thread via cfe-commits
https://github.com/jeremyd2019 reopened https://github.com/llvm/llvm-project/pull/140169 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] libcxx: std::ostream::sentry should be exported (PR #140169)

2025-05-16 Thread via cfe-commits
https://github.com/jeremyd2019 closed https://github.com/llvm/llvm-project/pull/140169 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Add helpers for Template config (PR #138062)

2025-05-16 Thread Erick Velez via cfe-commits
@@ -6,4 +6,6 @@ set(LLVM_LINK_COMPONENTS add_clang_library(clangDocSupport STATIC File.cpp - ) \ No newline at end of file + Utils.cpp + ) + evelez7 wrote: nit: extra newline https://github.com/llvm/llvm-project/pull/138062 _

[clang-tools-extra] [clang-doc] Add helpers for Template config (PR #138062)

2025-05-16 Thread Erick Velez via cfe-commits
@@ -0,0 +1,61 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang-tools-extra] [clang-doc] Add helpers for Template config (PR #138062)

2025-05-16 Thread Erick Velez via cfe-commits
@@ -74,7 +75,51 @@ static std::unique_ptr NamespaceTemplate = nullptr; static std::unique_ptr RecordTemplate = nullptr; +static Error +setupTemplate(std::unique_ptr &Template, + StringRef TemplatePath, + std::vector> Partials) { + auto T = Mustache

[clang-tools-extra] [clang-doc] Add helpers for Template config (PR #138062)

2025-05-16 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/138062 >From 3d870717fdc1a35f3fc28e7fa74b763362f98c19 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Wed, 30 Apr 2025 08:10:20 -0700 Subject: [PATCH] [clang-doc] Add helpers for Template config This patch adds or fil

[clang] [clang-tools-extra] [clangd] Collect references in array designators (PR #140356)

2025-05-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangd Author: Aleksandr Platonov (ArcsinX) Changes Without this patch clangd doesn't collect references in array designators. E.g. Find All References for symbol `Foo` in the following code gives only 1 result (in definition): ```c const int Foo = 0

[clang] [clang-tools-extra] [clangd] Collect references in array designators (PR #140356)

2025-05-16 Thread Aleksandr Platonov via cfe-commits
https://github.com/ArcsinX created https://github.com/llvm/llvm-project/pull/140356 Without this patch clangd doesn't collect references in array designators. E.g. Find All References for symbol `Foo` in the following code gives only 1 result (in definition): ```c const int Foo = 0; int Ba

[clang] [libcxx] [Cygwin][MinGW] Internal class in explicitly-instantiation-declarated template should be instantiated (PR #140145)

2025-05-16 Thread via cfe-commits
jeremyd2019 wrote: > They've failed linking things due to missing `std::istream::sentry` - I've > started a new run > https://github.com/jeremyd2019/llvm-mingw/actions/runs/15078849158 with > > ```c++ > #if defined(__MINGW32__) || defined(__CYGWIN__) > extern template class _LIBCPP_EXTERN_

[clang-tools-extra] [clang-include-fixer] Remove an unused "using" decl (NFC) (PR #140354)

2025-05-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Kazu Hirata (kazutakahirata) Changes We do use MappingTraits in this file, but all uses are inside the llvm::yaml namespace, so we don't rely on the "using" decl. --- Full diff: https://github.com/llvm/llvm-project/pull/140354

[clang-tools-extra] [clang-include-fixer] Remove an unused "using" decl (NFC) (PR #140354)

2025-05-16 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/140354 We do use MappingTraits in this file, but all uses are inside the llvm::yaml namespace, so we don't rely on the "using" decl. >From 217f8042a785d0c1f452e62bc00b84c1fb8caebf Mon Sep 17 00:00:00 2001 From:

[clang] [clang][NFC] Clean up Expr::isTemporaryObject() (PR #140229)

2025-05-16 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `fuchsia-x86_64-linux` running on `fuchsia-debian-64-us-central1-a-1` while building `clang` at step 4 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/11/builds/15333 Here is the relevant

[clang] [libcxx] libcxx: std::ostream::sentry should be exported (PR #140169)

2025-05-16 Thread via cfe-commits
https://github.com/jeremyd2019 updated https://github.com/llvm/llvm-project/pull/140169 >From 47f81a804a36a5b685f130f22d2ab5d330170861 Mon Sep 17 00:00:00 2001 From: kikairoya Date: Mon, 21 Apr 2025 23:30:13 +0900 Subject: [PATCH 1/3] [Cygwin][MinGW] Internal class in explicitly-instantiation-

[clang] [clang][NFC] Clean up Expr::isTemporaryObject() (PR #140229)

2025-05-16 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/140229 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e66cecd - [clang][NFC] Clean up Expr::isTemporaryObject() (#140229)

2025-05-16 Thread via cfe-commits
Author: Timm Baeder Date: 2025-05-17T06:28:30+02:00 New Revision: e66cecd8d56f4bb62e01e47830327f28dcd7ac66 URL: https://github.com/llvm/llvm-project/commit/e66cecd8d56f4bb62e01e47830327f28dcd7ac66 DIFF: https://github.com/llvm/llvm-project/commit/e66cecd8d56f4bb62e01e47830327f28dcd7ac66.diff L

[clang] [Driver] Use llvm::is_contained (NFC) (PR #140310)

2025-05-16 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-aarch64-sve-vls-2stage` running on `linaro-g3-03` while building `clang` at step 12 "ninja check 2". Full details are available at: https://lab.llvm.org/buildbot/#/builders/4/builds/6836 Here is the relevant piece of

[clang] Add sycl_external attribute (PR #140282)

2025-05-16 Thread Tom Honermann via cfe-commits
@@ -12926,6 +12929,10 @@ bool ASTContext::DeclMustBeEmitted(const Decl *D) { // FIXME: Functions declared with SYCL_EXTERNAL are required during // device compilation. tahonermann wrote: ```suggestion ``` https://github.com/llvm/llvm-project/pull/140

[clang] Add sycl_external attribute (PR #140282)

2025-05-16 Thread Tom Honermann via cfe-commits
@@ -1545,6 +1550,18 @@ def SYCLKernel : InheritableAttr { let Documentation = [SYCLKernelDocs]; } +def GlobalStorageNonLocalVar : SubsetSubjecthasGlobalStorage() && + !S->isLocalVarDeclOrParm()}], +

[clang] Add sycl_external attribute (PR #140282)

2025-05-16 Thread Tom Honermann via cfe-commits
@@ -1545,6 +1550,18 @@ def SYCLKernel : InheritableAttr { let Documentation = [SYCLKernelDocs]; } +def GlobalStorageNonLocalVar : SubsetSubjecthasGlobalStorage() && + !S->isLocalVarDeclOrParm()}], +

[clang] Add sycl_external attribute (PR #140282)

2025-05-16 Thread Tom Honermann via cfe-commits
@@ -408,10 +408,14 @@ class SubjectList subjects, SubjectDiag diag = WarnDiag, string CustomDiag = customDiag; } -class LangOpt { +class LangOpt { // The language option to test; ignored when custom code is supplied. string Name = name; + // If set to 1, the attrib

[clang] Add sycl_external attribute (PR #140282)

2025-05-16 Thread Tom Honermann via cfe-commits
@@ -0,0 +1,52 @@ +// RUN: %clang_cc1 -fsycl-is-device -fsyntax-only -verify -DSYCL %s +// RUN: %clang_cc1 -fsycl-is-host -fsyntax-only -verify -DHOST %s tahonermann wrote: Since SYCL applies to both host and device, let's differentiate by "host" and "device" (wi

[clang] Add sycl_external attribute (PR #140282)

2025-05-16 Thread Tom Honermann via cfe-commits
@@ -12909,6 +12909,9 @@ bool ASTContext::DeclMustBeEmitted(const Decl *D) { if (D->hasAttr()) return false; + if (LangOpts.SYCLIsDevice && !D->hasAttr()) +return false; tahonermann wrote: This will also need to check for the new `SYCLExternalAttr`

[clang] Add sycl_external attribute (PR #140282)

2025-05-16 Thread Tom Honermann via cfe-commits
@@ -0,0 +1,52 @@ +// RUN: %clang_cc1 -fsycl-is-device -fsyntax-only -verify -DSYCL %s +// RUN: %clang_cc1 -fsycl-is-host -fsyntax-only -verify -DHOST %s +// RUN: %clang_cc1 -verify %s + +// Semantic tests for sycl_external attribute + +#ifdef SYCL + +__attribute__((sycl_external(3

[clang] Add sycl_external attribute (PR #140282)

2025-05-16 Thread Tom Honermann via cfe-commits
https://github.com/tahonermann requested changes to this pull request. Thanks for working on this @schittir! I completed an initial pass of all of the code, but still need to look more closely at the documentation updates. https://github.com/llvm/llvm-project/pull/140282 ___

[clang] Add sycl_external attribute (PR #140282)

2025-05-16 Thread Tom Honermann via cfe-commits
@@ -100,11 +100,10 @@ int main() { // Verify that SYCL kernel caller functions are emitted for each device target. // -// FIXME: The following set of matches are used to skip over the declaration of -// main(). main() shouldn't be emitted in device code, but that pruning isn't

[clang] Add sycl_external attribute (PR #140282)

2025-05-16 Thread Tom Honermann via cfe-commits
@@ -12926,6 +12929,10 @@ bool ASTContext::DeclMustBeEmitted(const Decl *D) { // FIXME: Functions declared with SYCL_EXTERNAL are required during // device compilation. +// Functions definitions with sycl_external attribute are required during +// device compila

[clang] Add sycl_external attribute (PR #140282)

2025-05-16 Thread Tom Honermann via cfe-commits
@@ -12746,6 +12746,11 @@ def err_sycl_special_type_num_init_method : Error< "types with 'sycl_special_class' attribute must have one and only one '__init' " "method defined">; +//SYCL external attribute diagnostics +def err_sycl_attribute_internal_decl +: Error<"%0 at

[clang] Add sycl_external attribute (PR #140282)

2025-05-16 Thread Tom Honermann via cfe-commits
@@ -62,6 +62,7 @@ class SemaSYCL : public SemaBase { ParsedType ParsedTy); void handleKernelAttr(Decl *D, const ParsedAttr &AL); + void handleSYCLExternalAttr(Decl *D, const ParsedAttr &AL); tahonermann wrote: Since t

[clang] Add sycl_external attribute (PR #140282)

2025-05-16 Thread Tom Honermann via cfe-commits
https://github.com/tahonermann edited https://github.com/llvm/llvm-project/pull/140282 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Use llvm::is_contained (NFC) (PR #140310)

2025-05-16 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `premerge-monolithic-windows` running on `premerge-windows-1` while building `clang` at step 5 "clean-build-dir". Full details are available at: https://lab.llvm.org/buildbot/#/builders/35/builds/10150 Here is the relevant p

[clang] [Frontend] Avoid creating a temporary instance of std::string (NFC) (PR #140326)

2025-05-16 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `fuchsia-x86_64-linux` running on `fuchsia-debian-64-us-central1-b-1` while building `clang` at step 4 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/11/builds/15331 Here is the relevant

[clang] [Frontend] Avoid creating a temporary instance of std::string (NFC) (PR #140326)

2025-05-16 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-aarch64-darwin` running on `doug-worker-4` while building `clang` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/190/builds/20134 Here is th

[clang] [Frontend] Avoid creating a temporary instance of std::string (NFC) (PR #140326)

2025-05-16 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/140326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Use llvm::is_contained (NFC) (PR #140310)

2025-05-16 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-gcc-ubuntu` running on `sie-linux-worker3` while building `clang` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/174/builds/17905 Her

[clang] 6963309 - [Frontend] Avoid creating a temporary instance of std::string (NFC) (#140326)

2025-05-16 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-05-16T20:02:50-07:00 New Revision: 6963309af12f8d1a688fa2c42019d83e78a0024c URL: https://github.com/llvm/llvm-project/commit/6963309af12f8d1a688fa2c42019d83e78a0024c DIFF: https://github.com/llvm/llvm-project/commit/6963309af12f8d1a688fa2c42019d83e78a0024c.diff L

[clang] [Driver] Use llvm::is_contained (NFC) (PR #140310)

2025-05-16 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/140310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] bda8c50 - [Driver] Use llvm::is_contained (NFC) (#140310)

2025-05-16 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-05-16T20:01:31-07:00 New Revision: bda8c502bffa4f526bc3a7d22179ebfe398351c7 URL: https://github.com/llvm/llvm-project/commit/bda8c502bffa4f526bc3a7d22179ebfe398351c7 DIFF: https://github.com/llvm/llvm-project/commit/bda8c502bffa4f526bc3a7d22179ebfe398351c7.diff L

[clang] [flang] [flang] add -floop-interchange and enable it with opt levels (PR #140182)

2025-05-16 Thread Sebastian Pop via cfe-commits
https://github.com/sebpop updated https://github.com/llvm/llvm-project/pull/140182 >From b0a6935e8439bc5b4f742f55eb3bb090790a8f95 Mon Sep 17 00:00:00 2001 From: Sebastian Pop Date: Wed, 7 May 2025 01:14:49 + Subject: [PATCH 1/4] [flang] fix Werror=dangling-reference MIME-Version: 1.0 Conten

[clang] [Clang][NFC] Use `llvm::sort()` (PR #140337)

2025-05-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Iris Shi (el-ev) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/140337.diff 6 Files Affected: - (modified) clang/lib/APINotes/APINotesWriter.cpp (+7-7) - (modified) clang/lib/Analysis/FlowSensitive/SimplifyCon

[clang] [Clang][NFC] Use `llvm::sort()` (PR #140337)

2025-05-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-hlsl Author: Iris Shi (el-ev) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/140337.diff 6 Files Affected: - (modified) clang/lib/APINotes/APINotesWriter.cpp (+7-7) - (modified) clang/lib/Analysis/FlowSensitive/SimplifyConstraints

[clang] [Clang][NFC] Use `llvm::sort()` (PR #140337)

2025-05-16 Thread Iris Shi via cfe-commits
https://github.com/el-ev created https://github.com/llvm/llvm-project/pull/140337 None >From 935633e4e6b290bbf7f83a559a3cd36c049186c7 Mon Sep 17 00:00:00 2001 From: Iris Shi <0...@owo.li> Date: Sat, 17 May 2025 10:46:46 +0800 Subject: [PATCH] [Clang][NFC] Use `llvm::sort()` --- clang/lib/APIN

[clang] [Frontend] Avoid creating a temporary instance of std::string (NFC) (PR #140326)

2025-05-16 Thread Shilei Tian via cfe-commits
https://github.com/shiltian approved this pull request. https://github.com/llvm/llvm-project/pull/140326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] libcxx: std::ostream::sentry should be exported (PR #140169)

2025-05-16 Thread via cfe-commits
https://github.com/jeremyd2019 updated https://github.com/llvm/llvm-project/pull/140169 >From 47f81a804a36a5b685f130f22d2ab5d330170861 Mon Sep 17 00:00:00 2001 From: kikairoya Date: Mon, 21 Apr 2025 23:30:13 +0900 Subject: [PATCH 1/3] [Cygwin][MinGW] Internal class in explicitly-instantiation-

[clang] [-Wunsafe-buffer-usage] Fix false warnings when const sized array is safely accessed (array [idx %const]) (PR #140113)

2025-05-16 Thread Malavika Samak via cfe-commits
https://github.com/malavikasamak closed https://github.com/llvm/llvm-project/pull/140113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 3931566 - [-Wunsafe-buffer-usage] Fix false warnings when const sized array is safely accessed (array [idx %const]) (#140113)

2025-05-16 Thread via cfe-commits
Author: Malavika Samak Date: 2025-05-16T18:33:51-07:00 New Revision: 39315663a40a261772df94218fd33e205e888e54 URL: https://github.com/llvm/llvm-project/commit/39315663a40a261772df94218fd33e205e888e54 DIFF: https://github.com/llvm/llvm-project/commit/39315663a40a261772df94218fd33e205e888e54.diff

[clang] [Frontend] Avoid creating a temporary instance of std::string (NFC) (PR #140326)

2025-05-16 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/140326 Since getLastArgValue returns StringRef, and the constructor of SmallString accepts StringRef, we do not need to go through a temporary instance of std::string. >From 0f87807ef3159de0350dd85b4f5f8dd289c7

[clang] [Frontend] Avoid creating a temporary instance of std::string (NFC) (PR #140326)

2025-05-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes Since getLastArgValue returns StringRef, and the constructor of SmallString accepts StringRef, we do not need to go through a temporary instance of std::string. --- Full diff: https://github.com/llvm/l

[clang] [Driver] Use llvm::is_contained (NFC) (PR #140310)

2025-05-16 Thread Tim Gymnich via cfe-commits
https://github.com/tgymnich approved this pull request. https://github.com/llvm/llvm-project/pull/140310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Fix problem with phantom function arguments (PR #140322)

2025-05-16 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor closed https://github.com/llvm/llvm-project/pull/140322 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f7ef8dc - [CIR] Fix problem with phantom function arguments (#140322)

2025-05-16 Thread via cfe-commits
Author: Andy Kaylor Date: 2025-05-16T18:01:12-07:00 New Revision: f7ef8dcbad9d5ac6cf2a8917d5ce03564fdfd0d8 URL: https://github.com/llvm/llvm-project/commit/f7ef8dcbad9d5ac6cf2a8917d5ce03564fdfd0d8 DIFF: https://github.com/llvm/llvm-project/commit/f7ef8dcbad9d5ac6cf2a8917d5ce03564fdfd0d8.diff L

[clang] [libcxx] [Cygwin][MinGW] Internal class in explicitly-instantiation-declarated template should be instantiated (PR #140145)

2025-05-16 Thread via cfe-commits
jeremyd2019 wrote: trying to use this libc++ ci is less than helpful: the jobs keep failing for no apparent reason (cancelled? docker not running?), and whatever seems to be supposed to rerun the failed jobs is not all that reliable about doing so. Hopefully my llvm-mingw fork will show this

[clang] [CIR] Fix problem with phantom function arguments (PR #140322)

2025-05-16 Thread Andy Kaylor via cfe-commits
andykaylor wrote: > LGTM. Is there an easy to add a test for this? I understand sometimes it's > hard, but just double checking. The only thing I can think of would be a unit test that calculates folding set IDs for a bunch of similar, but slightly different, function signatures to verify tha

[clang] [CIR] Fix problem with phantom function arguments (PR #140322)

2025-05-16 Thread Bruno Cardoso Lopes via cfe-commits
@@ -112,8 +112,16 @@ class CIRGenFunctionInfo final // NOLINTNEXTLINE(readability-identifier-naming) void Profile(llvm::FoldingSetNodeID &id) { -id.AddBoolean(required.getOpaqueData()); -getReturnType().Profile(id); +// It's unfortunate that we are looping over

[clang-tools-extra] [clang-doc] Add helpers for Template config (PR #138062)

2025-05-16 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/138062 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Fix problem with phantom function arguments (PR #140322)

2025-05-16 Thread Iris Shi via cfe-commits
https://github.com/el-ev approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/140322 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Add helpers for Template config (PR #138062)

2025-05-16 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/138062 >From 442fe2fd1353c540bc0ec39ec913e7e414def6bc Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Wed, 30 Apr 2025 08:10:20 -0700 Subject: [PATCH] [clang-doc] Add helpers for Template config This patch adds or fil

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator methods (PR #138061)

2025-05-16 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/138061 >From 187b130d43c4470768b3885cb9c333b9edfb3897 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Wed, 30 Apr 2025 08:09:41 -0700 Subject: [PATCH] [clang-doc] Add HTMLMustacheGenerator methods Split from #133161.

[clang-tools-extra] 6a0e626 - [clang-doc] Add HTMLMustacheGenerator methods (#138061)

2025-05-16 Thread via cfe-commits
Author: Paul Kirth Date: 2025-05-16T17:30:45-07:00 New Revision: 6a0e626af58bdf8ae8c07cfe8aec94f4565734a3 URL: https://github.com/llvm/llvm-project/commit/6a0e626af58bdf8ae8c07cfe8aec94f4565734a3 DIFF: https://github.com/llvm/llvm-project/commit/6a0e626af58bdf8ae8c07cfe8aec94f4565734a3.diff LO

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator methods (PR #138061)

2025-05-16 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi closed https://github.com/llvm/llvm-project/pull/138061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator methods (PR #138061)

2025-05-16 Thread Paul Kirth via cfe-commits
ilovepi wrote: ### Merge activity * **May 16, 8:28 PM EDT**: A user started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/138061). https://github.com/llvm/llvm-project/pull/138061

[clang] [CIR] Fix problem with phantom function arguments (PR #140322)

2025-05-16 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes approved this pull request. LGTM. Is there an easy to add a test for this? I understand sometimes it's hard, but just double checking. https://github.com/llvm/llvm-project/pull/140322 ___ cfe-commits mailing list cfe-c

[clang] [CIR] Fix problem with phantom function arguments (PR #140322)

2025-05-16 Thread Andy Kaylor via cfe-commits
@@ -112,8 +112,16 @@ class CIRGenFunctionInfo final // NOLINTNEXTLINE(readability-identifier-naming) void Profile(llvm::FoldingSetNodeID &id) { -id.AddBoolean(required.getOpaqueData()); -getReturnType().Profile(id); +// It's unfortunate that we are looping over

[clang] [CIR] Fix problem with phantom function arguments (PR #140322)

2025-05-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangir Author: Andy Kaylor (andykaylor) Changes There was a problem introduced today where sometimes the CIR for functions with no arguments would be generated with phantom arguments. This was causing intermittent test failures. The problem appears t

[clang] [CIR] Fix problem with phantom function arguments (PR #140322)

2025-05-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Andy Kaylor (andykaylor) Changes There was a problem introduced today where sometimes the CIR for functions with no arguments would be generated with phantom arguments. This was causing intermittent test failures. The problem appears to

[clang] [CIR] Fix problem with phantom function arguments (PR #140322)

2025-05-16 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor created https://github.com/llvm/llvm-project/pull/140322 There was a problem introduced today where sometimes the CIR for functions with no arguments would be generated with phantom arguments. This was causing intermittent test failures. The problem appears to ha

[clang] [llvm] [DirectX][SPIRV] Fix the lowering of dot4add (PR #140315)

2025-05-16 Thread Justin Bogner via cfe-commits
@@ -1,17 +1,19 @@ -// RUN: %clang_cc1 -finclude-default-header -triple \ -// RUN: dxil-pc-shadermodel6.3-compute %s -emit-llvm -disable-llvm-passes -o - | \ -// RUN: FileCheck %s -DTARGET=dx -// RUN: %clang_cc1 -finclude-default-header -triple \ -// RUN: spirv-pc-vulkan-com

[clang] [llvm] [SPIRV] Add PreLegalizer pattern matching for `faceforward` (PR #139959)

2025-05-16 Thread Kaitlin Peng via cfe-commits
@@ -98,21 +110,98 @@ void applySPIRVDistance(MachineInstr &MI, MachineRegisterInfo &MRI, SPIRVGlobalRegistry *GR = MI.getMF()->getSubtarget().getSPIRVGlobalRegistry(); - auto RemoveAllUses = [&](Register Reg) { -SmallVector UsesToErase( -llvm::make_pointe

[clang] [llvm] [SPIRV] Add PreLegalizer pattern matching for `faceforward` (PR #139959)

2025-05-16 Thread Kaitlin Peng via cfe-commits
https://github.com/kmpeng edited https://github.com/llvm/llvm-project/pull/139959 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SPIRV] Add PreLegalizer pattern matching for `faceforward` (PR #139959)

2025-05-16 Thread Kaitlin Peng via cfe-commits
https://github.com/kmpeng edited https://github.com/llvm/llvm-project/pull/139959 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SPIRV] Add PreLegalizer pattern matching for `faceforward` (PR #139959)

2025-05-16 Thread Kaitlin Peng via cfe-commits
@@ -98,21 +110,98 @@ void applySPIRVDistance(MachineInstr &MI, MachineRegisterInfo &MRI, SPIRVGlobalRegistry *GR = MI.getMF()->getSubtarget().getSPIRVGlobalRegistry(); - auto RemoveAllUses = [&](Register Reg) { -SmallVector UsesToErase( -llvm::make_pointe

[clang] [libcxx] libcxx: std::ostream::sentry should be exported (PR #140169)

2025-05-16 Thread via cfe-commits
https://github.com/jeremyd2019 reopened https://github.com/llvm/llvm-project/pull/140169 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] libcxx: std::ostream::sentry should be exported (PR #140169)

2025-05-16 Thread via cfe-commits
https://github.com/jeremyd2019 closed https://github.com/llvm/llvm-project/pull/140169 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SPIRV] Add PreLegalizer pattern matching for `faceforward` (PR #139959)

2025-05-16 Thread Kaitlin Peng via cfe-commits
https://github.com/kmpeng updated https://github.com/llvm/llvm-project/pull/139959 >From be7df595c1df0f310a1941da3d3ac3529270241e Mon Sep 17 00:00:00 2001 From: kmpeng Date: Tue, 29 Apr 2025 16:46:08 -0700 Subject: [PATCH 1/5] WIP - debug `matchSelectToFaceForward` --- .../lib/Headers/hlsl/hl

[clang] [clang][ExprConst] allow single element access of vector object to be constant expression (PR #101126)

2025-05-16 Thread Ziqing Luo via cfe-commits
ziqingluo-90 wrote: ``` typedef __attribute__((__ext_vector_type__(2))) float float2; struct vec2 { float2 _v; public: constexpr vec2(float x, float y) { _v.x = x; _v.y = y; } }; constexpr struct vec2 f() { return vec2(1.0, 1.0); } int main() { vec2 S = f(); } `

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator methods (PR #138061)

2025-05-16 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/138061 >From de0222f0459bb6c5832ccdbe70b19f5ea8b0cd98 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Wed, 30 Apr 2025 08:09:41 -0700 Subject: [PATCH] [clang-doc] Add HTMLMustacheGenerator methods Split from #133161.

[clang] [Clang] suggest headers on undeclared errors (PR #140247)

2025-05-16 Thread Jongmyeong Choi via cfe-commits
https://github.com/jongmyeong-choi edited https://github.com/llvm/llvm-project/pull/140247 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Add tweak to override pure virtuals (PR #139348)

2025-05-16 Thread Marco Maia via cfe-commits
https://github.com/marcogmaia edited https://github.com/llvm/llvm-project/pull/139348 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [Cygwin][MinGW] Internal class in explicitly-instantiation-declarated template should be instantiated (PR #140145)

2025-05-16 Thread via cfe-commits
jeremyd2019 wrote: They've failed linking things due to missing `std::istream::sentry` - I've started a new run https://github.com/jeremyd2019/llvm-mingw/actions/runs/15078849158 with ``` #if defined(__MINGW32__) || defined(__CYGWIN__) extern template class _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator methods (PR #138061)

2025-05-16 Thread Paul Kirth via cfe-commits
@@ -70,18 +70,116 @@ class MustacheTemplateFile : public Template { MustacheTemplateFile(StringRef TemplateStr) : Template(TemplateStr) {} }; +static std::unique_ptr NamespaceTemplate = nullptr; + +static std::unique_ptr RecordTemplate = nullptr; + +static Error setupTemplat

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator methods (PR #138061)

2025-05-16 Thread Paul Kirth via cfe-commits
@@ -70,18 +70,116 @@ class MustacheTemplateFile : public Template { MustacheTemplateFile(StringRef TemplateStr) : Template(TemplateStr) {} }; +static std::unique_ptr NamespaceTemplate = nullptr; + +static std::unique_ptr RecordTemplate = nullptr; + +static Error setupTemplat

[clang] [OpenACC][CIR] Implement beginning of 'copy' lowering for compute con… (PR #140304)

2025-05-16 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes commented: A question in the comments but otherwise PR looks good: adds boilerplate and initial cases, deferring more work for incremental PRs, way to go. https://github.com/llvm/llvm-project/pull/140304 ___ cfe-commit

[clang] [llvm] [DirectX][SPIRV] Fix the lowering of dot4add (PR #140315)

2025-05-16 Thread Finn Plummer via cfe-commits
@@ -1,17 +1,19 @@ -// RUN: %clang_cc1 -finclude-default-header -triple \ -// RUN: dxil-pc-shadermodel6.3-compute %s -emit-llvm -disable-llvm-passes -o - | \ -// RUN: FileCheck %s -DTARGET=dx -// RUN: %clang_cc1 -finclude-default-header -triple \ -// RUN: spirv-pc-vulkan-com

[clang] [llvm] [DirectX][SPIRV] Fix the lowering of dot4add (PR #140315)

2025-05-16 Thread Finn Plummer via cfe-commits
https://github.com/inbelic approved this pull request. https://github.com/llvm/llvm-project/pull/140315 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NFC] Run code formatter on Diagnostic.h/cpp ProfileList.cpp SpecialCaseList.cpp (PR #140316)

2025-05-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-support Author: Qinkun Bao (qinkunbao) Changes --- Patch is 24.81 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/140316.diff 4 Files Affected: - (modified) clang/include/clang/Basic/Diagnostic.h (+2

[clang] [llvm] [NFC] Run code formatter on Diagnostic.h/cpp ProfileList.cpp SpecialCaseList.cpp (PR #140316)

2025-05-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Qinkun Bao (qinkunbao) Changes --- Patch is 24.81 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/140316.diff 4 Files Affected: - (modified) clang/include/clang/Basic/Diagnostic.h (+29-37)

[clang] [llvm] [NFC] Run code formatter on Diagnostic.h/cpp ProfileList.cpp SpecialCaseList.cpp (PR #140316)

2025-05-16 Thread Qinkun Bao via cfe-commits
https://github.com/qinkunbao created https://github.com/llvm/llvm-project/pull/140316 None >From 1a7036aa08fc1842cf953a18b29f4c44e136c808 Mon Sep 17 00:00:00 2001 From: Qinkun Bao Date: Fri, 16 May 2025 23:01:54 + Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?=

[clang] [OpenACC][CIR] Implement beginning of 'copy' lowering for compute con… (PR #140304)

2025-05-16 Thread Andy Kaylor via cfe-commits
@@ -36,6 +37,76 @@ template constexpr bool isCombinedType = false; template constexpr bool isCombinedType> = true; +namespace { +struct DataOperandInfo { + mlir::Location beginLoc; + mlir::Value varValue; + llvm::StringRef name; + mlir::ValueRange bounds; + + DataOpera

[clang] [OpenACC][CIR] Implement beginning of 'copy' lowering for compute con… (PR #140304)

2025-05-16 Thread Bruno Cardoso Lopes via cfe-commits
@@ -36,6 +37,76 @@ template constexpr bool isCombinedType = false; template constexpr bool isCombinedType> = true; +namespace { +struct DataOperandInfo { + mlir::Location beginLoc; + mlir::Value varValue; + llvm::StringRef name; + mlir::ValueRange bounds; + + DataOpera

[clang] [OpenACC][CIR] Implement beginning of 'copy' lowering for compute con… (PR #140304)

2025-05-16 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes edited https://github.com/llvm/llvm-project/pull/140304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC][CIR] Implement beginning of 'copy' lowering for compute con… (PR #140304)

2025-05-16 Thread Andy Kaylor via cfe-commits
@@ -527,6 +709,20 @@ class OpenACCClauseCIREmitter final llvm_unreachable("Unknown construct kind in VisitGangClause"); } } + + void VisitCopyClause(const OpenACCCopyClause &clause) { +if constexpr (isOneOfTypes) { + for (auto Var : clause.getVarList()) --

[clang] [llvm] [SPIRV] Add PreLegalizer pattern matching for `faceforward` (PR #139959)

2025-05-16 Thread Kaitlin Peng via cfe-commits
@@ -0,0 +1,63 @@ +# RUN: llc -verify-machineinstrs -O0 -mtriple spirv-unknown-unknown -run-pass=spirv-prelegalizer-combiner %s -o - | FileCheck %s +# REQUIRES: asserts +--- +name:faceforward_instcombine_float +tracksRegLiveness: true +legalized: true +body:

[clang] [CIR] Upstream support for C++ member function calls (PR #140290)

2025-05-16 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes approved this pull request. Some nits / comments, but this LGTM to me: skeleton for member function calls added, errorNYI used for untested paths and some initial support for the more simple cases. https://github.com/llvm/llvm-project/pull/140290 __

  1   2   3   4   5   >