[clang] [OpenACC] Implement better dupe catching for device_type clauses (PR #138196)

2025-05-01 Thread via cfe-commits
@@ -539,4 +539,25 @@ void no_dupes_since_last_device_type() { #pragma acc loop collapse(1) device_type(*) collapse(1) device_type(nvidia) collapse(2) for(unsigned i = 0; i < 5; ++i) for(unsigned j = 0; j < 5; ++j); + + // This one is ok, despite * being the 'all' value.

[clang] [OpenACC] Implement better dupe catching for device_type clauses (PR #138196)

2025-05-01 Thread via cfe-commits
@@ -539,4 +539,25 @@ void no_dupes_since_last_device_type() { #pragma acc loop collapse(1) device_type(*) collapse(1) device_type(nvidia) collapse(2) for(unsigned i = 0; i < 5; ++i) for(unsigned j = 0; j < 5; ++j); + + // This one is ok, despite * being the 'all' value.

[clang] [Clang] incorrect assertion when checking template template parameter of a lambda (PR #138121)

2025-05-01 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/138121 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] aea2f6f - [Clang] incorrect assertion when checking template template parameter of a lambda (#138121)

2025-05-01 Thread via cfe-commits
Author: cor3ntin Date: 2025-05-02T08:42:29+02:00 New Revision: aea2f6f69cd256d85a0d3986c0e72181bb5247ab URL: https://github.com/llvm/llvm-project/commit/aea2f6f69cd256d85a0d3986c0e72181bb5247ab DIFF: https://github.com/llvm/llvm-project/commit/aea2f6f69cd256d85a0d3986c0e72181bb5247ab.diff LOG:

[clang] 048befe - Revert "[clang][NFC] Convert `Sema::TryCaptureKind` to scoped enum"

2025-05-01 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2025-05-02T09:29:35+03:00 New Revision: 048befe9ef7edab3580a922d69664b21e2a532fa URL: https://github.com/llvm/llvm-project/commit/048befe9ef7edab3580a922d69664b21e2a532fa DIFF: https://github.com/llvm/llvm-project/commit/048befe9ef7edab3580a922d69664b21e2a532fa.

[clang] be6497f - [clang][NFC] Convert `Sema::TryCaptureKind` to scoped enum

2025-05-01 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2025-05-02T09:25:58+03:00 New Revision: be6497ff7583248d76a6710dd48cfeb63dd68f27 URL: https://github.com/llvm/llvm-project/commit/be6497ff7583248d76a6710dd48cfeb63dd68f27 DIFF: https://github.com/llvm/llvm-project/commit/be6497ff7583248d76a6710dd48cfeb63dd68f27.

[clang] 630a0ff - [clang][NFC] Convert `Sema::TrivialABIHandling` to scoped enum

2025-05-01 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2025-05-02T09:12:52+03:00 New Revision: 630a0ff2c25c4ced739b1c07633097ccbf182cd6 URL: https://github.com/llvm/llvm-project/commit/630a0ff2c25c4ced739b1c07633097ccbf182cd6 DIFF: https://github.com/llvm/llvm-project/commit/630a0ff2c25c4ced739b1c07633097ccbf182cd6.

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #138234)

2025-05-01 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/138234 >From 6c5593932af9a1d99bec0cbba018aacad104faf4 Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Thu, 1 May 2025 22:44:52 -0700 Subject: [PATCH] [clang][Darwin] Remove legacy framework search path logi

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #138234)

2025-05-01 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/138234 >From 59f8d68c6ebb1f16facb99c03376beef85b06fc0 Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Thu, 1 May 2025 22:44:52 -0700 Subject: [PATCH] [clang][Darwin] Remove legacy framework search path logi

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

2025-05-01 Thread Ian Anderson via cfe-commits
ian-twilightcoder wrote: > Unfortunately I don't have bandwidth to take this through the finish line. I > just spoke with @ian-twilightcoder who said he'd try to pick it up soon > (thanks a lot!). I'm not a maintainer so I can't update this PR. I ended up needing to tweak most of it, especial

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #138234)

2025-05-01 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions c,h,cpp -- clang/test/Driver/darwin-framework-search-paths.c

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #138234)

2025-05-01 Thread Ian Anderson via cfe-commits
ian-twilightcoder wrote: This is a takeover of https://github.com/llvm/llvm-project/pull/120149 because Louis is out, I'm not a maintainer so I can't push to his fork, and I redid most of it anyway. https://github.com/llvm/llvm-project/pull/138234 __

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #138234)

2025-05-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Ian Anderson (ian-twilightcoder) Changes Move the Darwin framework search path logic from InitHeaderSearch::AddDefaultIncludePaths to DarwinClang::AddClangSystemIncludeArgs. Add a new -internal-iframework cc1 argument to support the tool

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #138234)

2025-05-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Ian Anderson (ian-twilightcoder) Changes Move the Darwin framework search path logic from InitHeaderSearch::AddDefaultIncludePaths to DarwinClang::AddClangSystemIncludeArgs. Add a new -internal-iframework cc1 argument to support t

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #138234)

2025-05-01 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder created https://github.com/llvm/llvm-project/pull/138234 Move the Darwin framework search path logic from InitHeaderSearch::AddDefaultIncludePaths to DarwinClang::AddClangSystemIncludeArgs. Add a new -internal-iframework cc1 argument to support the tool ch

[clang] [Clang][NFC] Capture by ref to avoid copying std::string (PR #138231)

2025-05-01 Thread Balazs Benics via cfe-commits
https://github.com/steakhal approved this pull request. Makes sense, thanks. I just wonder why is BName an owning string? To me it would make a lot more sense if it was a StringRef owned by the ASTContext. WDYT? https://github.com/llvm/llvm-project/pull/138231 __

[clang] [Clang][NFC] Capture by ref to avoid copying std::string (PR #138231)

2025-05-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Shafik Yaghmour (shafik) Changes Static analysis flagged capturing BName by value as opposed to by reference. Updated capture to be by reference. --- Full diff: https://github.com/llvm/llvm-project/pull/138231.diff 1 Files Affected: -

[clang] [Clang][NFC] Capture by ref to avoid copying std::string (PR #138231)

2025-05-01 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik created https://github.com/llvm/llvm-project/pull/138231 Static analysis flagged capturing BName by value as opposed to by reference. Updated capture to be by reference. >From dc52a86f175be704bb571ce160b597a2f4011cac Mon Sep 17 00:00:00 2001 From: Shafik Yaghmour Dat

[clang] default clause replaced by otherwise clause for metadirective in OpenMP 5.2 (PR #128640)

2025-05-01 Thread CHANDRA GHALE via cfe-commits
https://github.com/chandraghale closed https://github.com/llvm/llvm-project/pull/128640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] default clause replaced by otherwise clause for metadirective in OpenMP 5.2 (PR #128640)

2025-05-01 Thread CHANDRA GHALE via cfe-commits
chandraghale wrote: Committing to main, as already PR is approved. https://github.com/llvm/llvm-project/pull/128640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 35e743d - default clause replaced by otherwise clause for metadirective in OpenMP 5.2 (#128640)

2025-05-01 Thread via cfe-commits
Author: Urvi Rav Date: 2025-05-02T10:29:57+05:30 New Revision: 35e743d4bf1960a9ea982227a6159325784c56b9 URL: https://github.com/llvm/llvm-project/commit/35e743d4bf1960a9ea982227a6159325784c56b9 DIFF: https://github.com/llvm/llvm-project/commit/35e743d4bf1960a9ea982227a6159325784c56b9.diff LOG:

[clang] 7e71db8 - [clang][NFC] Convert `Sema::AvailabilityMergeKind` to scoped enum

2025-05-01 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2025-05-02T07:56:57+03:00 New Revision: 7e71db8463adfbaadbd28a6c0e8b807ff7075c3c URL: https://github.com/llvm/llvm-project/commit/7e71db8463adfbaadbd28a6c0e8b807ff7075c3c DIFF: https://github.com/llvm/llvm-project/commit/7e71db8463adfbaadbd28a6c0e8b807ff7075c3c.

[clang] ed673aa - [clang][NFC] Convert `Sema::OffsetOfKind` to scoped enum

2025-05-01 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2025-05-02T07:49:47+03:00 New Revision: ed673aac7aa78896ec55aa615e37432006c2830a URL: https://github.com/llvm/llvm-project/commit/ed673aac7aa78896ec55aa615e37432006c2830a DIFF: https://github.com/llvm/llvm-project/commit/ed673aac7aa78896ec55aa615e37432006c2830a.

[clang] 8089c3d - [clang][NFC] Convert `Sema::NonTagKind` to scoped enum

2025-05-01 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2025-05-02T07:45:22+03:00 New Revision: 8089c3d1edf0f880415bfbc155571f4a43fcdf17 URL: https://github.com/llvm/llvm-project/commit/8089c3d1edf0f880415bfbc155571f4a43fcdf17 DIFF: https://github.com/llvm/llvm-project/commit/8089c3d1edf0f880415bfbc155571f4a43fcdf17.

[clang] 09fb9ad - [clang][NFC] Convert `Sema::NonTrivialCUnionContext` to scoped enum

2025-05-01 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2025-05-02T07:39:54+03:00 New Revision: 09fb9adbd2a432a83e451ee9156faceb9d76e9aa URL: https://github.com/llvm/llvm-project/commit/09fb9adbd2a432a83e451ee9156faceb9d76e9aa DIFF: https://github.com/llvm/llvm-project/commit/09fb9adbd2a432a83e451ee9156faceb9d76e9aa.

[clang] 68fd69a - [clang][NFC] Convert `Sema::PointerAuthDiscArgKind` to scoped enum

2025-05-01 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2025-05-02T07:33:52+03:00 New Revision: 68fd69aca6c9d8129cd5dc27829a8abebea4cefc URL: https://github.com/llvm/llvm-project/commit/68fd69aca6c9d8129cd5dc27829a8abebea4cefc DIFF: https://github.com/llvm/llvm-project/commit/68fd69aca6c9d8129cd5dc27829a8abebea4cefc.

[clang] [libclang/python] Add tests for equality operators. (PR #138132)

2025-05-01 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum closed https://github.com/llvm/llvm-project/pull/138132 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ade1203 - [libclang/python] Add tests for equality operators. (#138132)

2025-05-01 Thread via cfe-commits
Author: Jannick Kremer Date: 2025-05-02T06:24:18+02:00 New Revision: ade1203337d7453a51edc549e6dba61f1c5e54e3 URL: https://github.com/llvm/llvm-project/commit/ade1203337d7453a51edc549e6dba61f1c5e54e3 DIFF: https://github.com/llvm/llvm-project/commit/ade1203337d7453a51edc549e6dba61f1c5e54e3.diff

[clang] [clang-format] Fix a crash on formatting missing r_paren/r_brace (PR #138230)

2025-05-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes Fix #138097 --- Full diff: https://github.com/llvm/llvm-project/pull/138230.diff 2 Files Affected: - (modified) clang/lib/Format/UnwrappedLineParser.cpp (+2-2) - (modified) clang/unittests/Format/Format

[clang] [clang-format] Fix a crash on formatting missing r_paren/r_brace (PR #138230)

2025-05-01 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/138230 Fix #138097 >From 3c10436ed455de5c2046b259c0c75744a75e1e4a Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Thu, 1 May 2025 21:20:34 -0700 Subject: [PATCH] [clang-format] Fix a crash on formatting missing r_paren/

[clang] [clang-format] RemoveParentheses shouldn't remove empty parentheses (PR #138229)

2025-05-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes Fix #138124 --- Full diff: https://github.com/llvm/llvm-project/pull/138229.diff 2 Files Affected: - (modified) clang/lib/Format/UnwrappedLineParser.cpp (+2-1) - (modified) clang/unittests/Format/Format

[clang] [libclang/python] Add tests for equality operators. (PR #138132)

2025-05-01 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll approved this pull request. https://github.com/llvm/llvm-project/pull/138132 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] RemoveParentheses shouldn't remove empty parentheses (PR #138229)

2025-05-01 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/138229 Fix #138124 >From 9ba504b25f9afa79a155004c635d618a141c8c39 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Thu, 1 May 2025 21:07:39 -0700 Subject: [PATCH] [clang-format] RemoveParentheses shouldn't remove empty p

[clang] [Modules] Don't fail when an unused textual header is missing. (PR #138227)

2025-05-01 Thread Volodymyr Sapsai via cfe-commits
vsapsai wrote: The change for `exclude` headers was done in 040e12662a674e2ebfc93f86a70eddb7d6fc76da. https://github.com/llvm/llvm-project/pull/138227 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[clang] [Modules] Don't fail when an unused textual header is missing. (PR #138227)

2025-05-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Volodymyr Sapsai (vsapsai) Changes According to the documentation > A header declaration that does not contain `exclude` nor `textual` specifies a header that contributes to the enclosing module. Which means that `exclude` and `te

[clang] [Modules] Don't fail when an unused textual header is missing. (PR #138227)

2025-05-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Volodymyr Sapsai (vsapsai) Changes According to the documentation > A header declaration that does not contain `exclude` nor `textual` specifies a header that contributes to the enclosing module. Which means that `exclude` and `textual` h

[clang] [Modules] Don't fail when an unused textual header is missing. (PR #138227)

2025-05-01 Thread Volodymyr Sapsai via cfe-commits
https://github.com/vsapsai created https://github.com/llvm/llvm-project/pull/138227 According to the documentation > A header declaration that does not contain `exclude` nor `textual` specifies > a header that contributes to the enclosing module. Which means that `exclude` and `textual` header

[clang] [CIR] Upstream enum support (PR #136807)

2025-05-01 Thread Ankur Ahir via cfe-commits
https://github.com/Ankur-0429 updated https://github.com/llvm/llvm-project/pull/136807 >From 44a384b8ad774939c7664c8a476e852f1d4a7341 Mon Sep 17 00:00:00 2001 From: Ankur Ahir Date: Tue, 22 Apr 2025 20:04:34 -0700 Subject: [PATCH 01/12] Upstream enum support --- clang/lib/CIR/CodeGen/CIRGenMo

[clang] [CIR] Upstream enum support (PR #136807)

2025-05-01 Thread Ankur Ahir via cfe-commits
https://github.com/Ankur-0429 updated https://github.com/llvm/llvm-project/pull/136807 >From 44a384b8ad774939c7664c8a476e852f1d4a7341 Mon Sep 17 00:00:00 2001 From: Ankur Ahir Date: Tue, 22 Apr 2025 20:04:34 -0700 Subject: [PATCH 01/12] Upstream enum support --- clang/lib/CIR/CodeGen/CIRGenMo

[clang] Remove duplicate API (PR #132776)

2025-05-01 Thread Jannick Kremer via cfe-commits
DeinAlptraum wrote: @Jugst3r are you still looking at this? Otherwise, I would still suggest merging this. https://github.com/llvm/llvm-project/pull/132776 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang] [CIR] Refactor global variable emission and initialization (PR #138222)

2025-05-01 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/138222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Refactor global variable emission and initialization (PR #138222)

2025-05-01 Thread Erich Keane via cfe-commits
https://github.com/erichkeane commented: Just 2 small comments, though I'd rather we get @bcardosolopes to take a lookhere. https://github.com/llvm/llvm-project/pull/138222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang] [CIR] Refactor global variable emission and initialization (PR #138222)

2025-05-01 Thread Erich Keane via cfe-commits
@@ -324,8 +358,16 @@ CIRGenModule::getOrCreateCIRGlobal(StringRef mangledName, mlir::Type ty, return entry; } - errorNYI(d->getSourceRange(), "reference of undeclared global"); - return {}; + mlir::Location loc = getLoc(d->getSourceRange()); + + // mlir::SymbolTab

[clang] [CIR] Refactor global variable emission and initialization (PR #138222)

2025-05-01 Thread Erich Keane via cfe-commits
@@ -269,6 +269,40 @@ mlir::Operation *CIRGenModule::getGlobalValue(StringRef name) { return mlir::SymbolTable::lookupSymbolIn(theModule, name); } +cir::GlobalOp CIRGenModule::createGlobalOp(CIRGenModule &cgm, + mlir::Location loc, S

[clang] [CIR] Upstream cir.call with scalar arguments (PR #136810)

2025-05-01 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-aarch64-darwin` running on `doug-worker-4` while building `clang` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/190/builds/19343 Here is th

[clang] [CIR] Upstream cir.call with scalar arguments (PR #136810)

2025-05-01 Thread Sirui Mu via cfe-commits
https://github.com/Lancern closed https://github.com/llvm/llvm-project/pull/136810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 44c4b4c - [CIR] Upstream cir.call with scalar arguments (#136810)

2025-05-01 Thread via cfe-commits
Author: Sirui Mu Date: 2025-05-02T10:04:48+08:00 New Revision: 44c4b4cef9d13ef91a771c45664dde643009f996 URL: https://github.com/llvm/llvm-project/commit/44c4b4cef9d13ef91a771c45664dde643009f996 DIFF: https://github.com/llvm/llvm-project/commit/44c4b4cef9d13ef91a771c45664dde643009f996.diff LOG:

[clang] [libclang/python] Add tests for equality operators. (PR #138132)

2025-05-01 Thread Jannick Kremer via cfe-commits
@@ -16,6 +16,8 @@ from .util import get_cursor, get_tu +INPUTS_DIR = os.path.join(os.path.dirname(__file__), "INPUTS") DeinAlptraum wrote: Yes, I changed these to use `pathlib.Path` instead https://github.com/llvm/llvm-project/pull/138132 __

[clang] [libclang/python] Add tests for equality operators. (PR #138132)

2025-05-01 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum updated https://github.com/llvm/llvm-project/pull/138132 >From 74cf17d76918c465aa24e391e15546ab030483f2 Mon Sep 17 00:00:00 2001 From: Jannick Kremer Date: Thu, 1 May 2025 22:42:56 +0900 Subject: [PATCH 1/2] [libclang/python] Add tests for equality operators. Ad

[clang] [clang][lex] Fix lexing malformed pragma within include directive (PR #138165)

2025-05-01 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik commented: Thank you for the fix, this needs a test and release note. Release notes for clang are in `clang/docs/ReleaseNotes.rst`. I am not sure what the right file for testing is though @AaronBallman https://github.com/llvm/llvm-project/pull/138165 ___

[clang] [clang][lex] Fix lexing malformed pragma within include directive (PR #138165)

2025-05-01 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp -- clang/lib/Lex/Pragma.cpp `` View the diff

[clang] [C] Add -Wjump-bypasses-init (PR #138009)

2025-05-01 Thread Shafik Yaghmour via cfe-commits
@@ -6561,18 +6561,28 @@ def ext_goto_into_protected_scope : ExtWarn< def warn_cxx98_compat_goto_into_protected_scope : Warning< "jump from this goto statement to its label is incompatible with C++98">, InGroup, DefaultIgnore; +def warn_cpp_compat_goto_into_protected_scope :

[clang] [libclang/python] Remove compatibility workaround for briefComment (PR #138135)

2025-05-01 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu` running on `linaro-lldb-aarch64-ubuntu` while building `clang` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/17007 Here is the relevant piece of the

[clang] [libclang/python] Remove compatibility workaround for briefComment (PR #138135)

2025-05-01 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum closed https://github.com/llvm/llvm-project/pull/138135 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] feda31e - [libclang/python] Remove compatibility workaround for briefComment (#138135)

2025-05-01 Thread via cfe-commits
Author: Jannick Kremer Date: 2025-05-02T03:23:04+02:00 New Revision: feda31e0483c47cbef549c068aab1c60e7d10572 URL: https://github.com/llvm/llvm-project/commit/feda31e0483c47cbef549c068aab1c60e7d10572 DIFF: https://github.com/llvm/llvm-project/commit/feda31e0483c47cbef549c068aab1c60e7d10572.diff

[clang] [HLSL] Implement the `ldexp` intrinsic (PR #138182)

2025-05-01 Thread Deric C. via cfe-commits
https://github.com/Icohedron requested changes to this pull request. @spall pointed out some good changes that should be made https://github.com/llvm/llvm-project/pull/138182 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[clang] [HLSL] Implement the `ldexp` intrinsic (PR #138182)

2025-05-01 Thread Deric C. via cfe-commits
@@ -0,0 +1,49 @@ +// RUN: %clang_cc1 -finclude-default-header -x hlsl -triple dxil-pc-shadermodel6.3-library %s -fnative-half-type -emit-llvm -disable-llvm-passes -o - | FileCheck %s Icohedron wrote: Yea, to be consistent if nothing else. https://github.com/ll

[clang] [HLSL] Implement the `ldexp` intrinsic (PR #138182)

2025-05-01 Thread Deric C. via cfe-commits
@@ -0,0 +1,39 @@ +// RUN: %clang_cc1 -finclude-default-header -triple dxil-pc-shadermodel6.6-library %s -fnative-half-type -emit-llvm-only -disable-llvm-passes -verify + +float test_double_inputs(double p0, double p1) { + return ldexp(p0, p1); + // expected-error@-1 {{no matc

[clang] [CIR] Upstream lowering of conditional operators to TernaryOp (PR #138156)

2025-05-01 Thread Andy Kaylor via cfe-commits
@@ -642,12 +798,97 @@ class CIRGenFunction : public CIRGenTypeCache { void emitNullabilityCheck(LValue lhs, mlir::Value rhs, clang::SourceLocation loc); + /// An object to manage conditionally-evaluated expressions. + class ConditionalEvaluation

[clang] [CIR] Upstream lowering of conditional operators to TernaryOp (PR #138156)

2025-05-01 Thread Andy Kaylor via cfe-commits
@@ -948,6 +950,165 @@ void CIRGenFunction::emitIgnoredExpr(const Expr *e) { emitLValue(e); } +// Handle the case where the condition is a constant evaluatable simple integer, +// which means we don't have to separately handle the true/false blocks. +static std::optional han

[clang] [CIR] Refactor global variable emission and initialization (PR #138222)

2025-05-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Andy Kaylor (andykaylor) Changes When global variable support was initially upstreamed, we took some shortcuts and only implemented the minimum support for simple variables and constant initializers. This change refactors the code that c

[clang] [CIR] Refactor global variable emission and initialization (PR #138222)

2025-05-01 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor created https://github.com/llvm/llvm-project/pull/138222 When global variable support was initially upstreamed, we took some shortcuts and only implemented the minimum support for simple variables and constant initializers. This change refactors the code that cre

[clang] [HLSL] Implement the `ldexp` intrinsic (PR #138182)

2025-05-01 Thread Sarah Spall via cfe-commits
@@ -0,0 +1,49 @@ +// RUN: %clang_cc1 -finclude-default-header -x hlsl -triple dxil-pc-shadermodel6.3-library %s -fnative-half-type -emit-llvm -disable-llvm-passes -o - | FileCheck %s spall wrote: A lot of the builtins that support half and float have tests with

[clang] [HLSL] Implement the `ldexp` intrinsic (PR #138182)

2025-05-01 Thread Sarah Spall via cfe-commits
@@ -0,0 +1,39 @@ +// RUN: %clang_cc1 -finclude-default-header -triple dxil-pc-shadermodel6.6-library %s -fnative-half-type -emit-llvm-only -disable-llvm-passes -verify + +float test_double_inputs(double p0, double p1) { + return ldexp(p0, p1); + // expected-error@-1 {{no matc

[clang] [HLSL] Implement the `ldexp` intrinsic (PR #138182)

2025-05-01 Thread Sarah Spall via cfe-commits
@@ -303,6 +303,48 @@ fmod(__detail::HLSL_FIXED_VECTOR X, return __detail::fmod_vec_impl(X, Y); } +//===--===// +// ldexp builtins +//===--=

[clang] [C] Add -Wjump-bypasses-init (PR #138009)

2025-05-01 Thread Shafik Yaghmour via cfe-commits
@@ -0,0 +1,31 @@ +// RUN: %clang_cc1 -fsyntax-only -verify=c,both -Wjump-bypasses-init %s +// RUN: %clang_cc1 -fsyntax-only -verify=c,both -Wc++-compat %s +// RUN: %clang_cc1 -fsyntax-only -verify=good %s +// RUN: %clang_cc1 -fsyntax-only -verify=cxx,both -x c++ %s +// good-no-dia

[clang] [C] Add -Wjump-bypasses-init (PR #138009)

2025-05-01 Thread Shafik Yaghmour via cfe-commits
@@ -0,0 +1,31 @@ +// RUN: %clang_cc1 -fsyntax-only -verify=c,both -Wjump-bypasses-init %s +// RUN: %clang_cc1 -fsyntax-only -verify=c,both -Wc++-compat %s +// RUN: %clang_cc1 -fsyntax-only -verify=good %s +// RUN: %clang_cc1 -fsyntax-only -verify=cxx,both -x c++ %s +// good-no-dia

[clang] [llvm] [HLSL][DXIL] Implement `refract` intrinsic (PR #136026)

2025-05-01 Thread via cfe-commits
https://github.com/raoanag updated https://github.com/llvm/llvm-project/pull/136026 >From 6ce233acf415d2d48eca8f75d69b678c8877aa84 Mon Sep 17 00:00:00 2001 From: Anagha Rajendra Rao Date: Wed, 16 Apr 2025 11:47:27 -0700 Subject: [PATCH 1/6] Refract implementation --- clang/test/CodeGenHLSL/bu

[clang] [C] Add -Wduplicate-decl-specifier to -Wc++-compat (PR #138012)

2025-05-01 Thread Shafik Yaghmour via cfe-commits
@@ -0,0 +1,17 @@ +// RUN: %clang_cc1 -fsyntax-only -verify -Wduplicate-decl-specifier %s +// RUN: %clang_cc1 -fsyntax-only -verify -Wc++-compat %s +// RUN: %clang_cc1 -fsyntax-only -verify -Wno-duplicate-decl-specifier -Wc++-compat %s +// RUN: %clang_cc1 -fsyntax-only -verify=goo

[clang] [llvm] [HLSL][DXIL] Implement `refract` intrinsic (PR #136026)

2025-05-01 Thread via cfe-commits
@@ -69,6 +69,49 @@ bool SemaSPIRV::CheckSPIRVBuiltinFunctionCall(unsigned BuiltinID, TheCall->setType(RetTy); break; } + case SPIRV::BI__builtin_spirv_refract: { +if (SemaRef.checkArgCount(TheCall, 3)) + return true; + +ExprResult A = TheCall->getArg(0)

[clang] [lldb] [llvm] [mlir] [NFC][Support] Add llvm::uninitialized_copy (PR #138174)

2025-05-01 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/138174 >From fbe3ca0c2e4d195149f5e3e6b8d32797cf47b9df Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Wed, 30 Apr 2025 23:47:37 -0700 Subject: [PATCH] [NFC][Support] Add llvm::uninitialized_copy Add `llvm::uninitiali

[clang] [clang] Merge gtest binaries into AllClangUnitTests (PR #134196)

2025-05-01 Thread Owen Pan via cfe-commits
owenca wrote: @rnk see https://github.com/llvm/llvm-project/pull/137577#issuecomment-2843963228 for some of the bots that got the assertion failure. > Update: Back to normal after > [afd738c](https://github.com/llvm/llvm-project/commit/afd738cd9016ddef4e26b309770ba35fd017a178). I meant the

[clang] [Clang][Cygwin] don't use -Bsymbolic-functions (PR #138217)

2025-05-01 Thread via cfe-commits
jeremyd2019 wrote: @mstorsjo I was going through my patches and found a couple tiny ones that I hadn't submitted yet https://github.com/llvm/llvm-project/pull/138217 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[clang] [Clang][Cygwin] don't use -Bsymbolic-functions (PR #138217)

2025-05-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (jeremyd2019) Changes GNU ld seems to ignore this option, but LLD treats the presence of this unknown option as an error. --- Full diff: https://github.com/llvm/llvm-project/pull/138217.diff 1 Files Affected: - (modified) clang/to

[clang] [Clang][Cygwin] don't use -Bsymbolic-functions (PR #138217)

2025-05-01 Thread via cfe-commits
https://github.com/jeremyd2019 created https://github.com/llvm/llvm-project/pull/138217 GNU ld seems to ignore this option, but LLD treats the presence of this unknown option as an error. >From bc019f85e4e8d2e1e65879d1f8adaf92e2581a01 Mon Sep 17 00:00:00 2001 From: Jeremy Drake Date: Sun, 13

[clang] [CIR] Upstream lowering of conditional operators to TernaryOp (PR #138156)

2025-05-01 Thread Andy Kaylor via cfe-commits
@@ -875,6 +877,174 @@ class ScalarExprEmitter : public StmtVisitor { // NOTE: We don't need to EnsureInsertPoint() like LLVM codegen. return Visit(e->getRHS()); } + + mlir::Value VisitBinLAnd(const clang::BinaryOperator *e) { +if (e->getType()->isVectorType()) {

[clang] [CIR] Upstream lowering of conditional operators to TernaryOp (PR #138156)

2025-05-01 Thread Andy Kaylor via cfe-commits
@@ -875,6 +877,174 @@ class ScalarExprEmitter : public StmtVisitor { // NOTE: We don't need to EnsureInsertPoint() like LLVM codegen. return Visit(e->getRHS()); } + + mlir::Value VisitBinLAnd(const clang::BinaryOperator *e) { +if (e->getType()->isVectorType()) {

[clang] [CIR] Upstream lowering of conditional operators to TernaryOp (PR #138156)

2025-05-01 Thread Andy Kaylor via cfe-commits
@@ -875,6 +877,174 @@ class ScalarExprEmitter : public StmtVisitor { // NOTE: We don't need to EnsureInsertPoint() like LLVM codegen. return Visit(e->getRHS()); } + + mlir::Value VisitBinLAnd(const clang::BinaryOperator *e) { +if (e->getType()->isVectorType()) {

[clang] [HLSL] Implement the `ldexp` intrinsic (PR #138182)

2025-05-01 Thread Deric C. via cfe-commits
https://github.com/Icohedron approved this pull request. https://github.com/llvm/llvm-project/pull/138182 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Implement the `ldexp` intrinsic (PR #138182)

2025-05-01 Thread Kaitlin Peng via cfe-commits
https://github.com/kmpeng updated https://github.com/llvm/llvm-project/pull/138182 >From d5187a940fc0a16325eedb0c67bcf647deb95d8f Mon Sep 17 00:00:00 2001 From: kmpeng Date: Thu, 1 May 2025 11:48:47 -0700 Subject: [PATCH 1/3] ldexp implementation and tests --- .../lib/Headers/hlsl/hlsl_intrin

[clang] [NFC][clang] No sharedlibs for UEFI (PR #137872)

2025-05-01 Thread Prabhu Rajasekaran via cfe-commits
https://github.com/Prabhuk closed https://github.com/llvm/llvm-project/pull/137872 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 1b1e360 - [NFC][clang] No sharedlibs for UEFI (#137872)

2025-05-01 Thread via cfe-commits
Author: Prabhu Rajasekaran Date: 2025-05-01T15:49:32-07:00 New Revision: 1b1e360b76d31fcd09b93b8c05be8a93dfea432b URL: https://github.com/llvm/llvm-project/commit/1b1e360b76d31fcd09b93b8c05be8a93dfea432b DIFF: https://github.com/llvm/llvm-project/commit/1b1e360b76d31fcd09b93b8c05be8a93dfea432b.

[clang] [clang-format] Add AlignAfterOpenBracketOptions (PR #108332)

2025-05-01 Thread Gedare Bloom via cfe-commits
gedare wrote: > Why would `AlignAfterControlStatement` have anything to do with > `AlignAfterOpenBracket`, which is for arguments of function/macro calls? > Unfortunately, `AlignAfterOpenBracket` is not just for arguments of function/macro calls. It affects parentheses of control statements a

[clang] [CIR] Upstream lowering of conditional operators to TernaryOp (PR #138156)

2025-05-01 Thread Andy Kaylor via cfe-commits
@@ -948,6 +950,165 @@ void CIRGenFunction::emitIgnoredExpr(const Expr *e) { emitLValue(e); } +// Handle the case where the condition is a constant evaluatable simple integer, +// which means we don't have to separately handle the true/false blocks. +static std::optional han

[clang] [CIR] Upstream lowering of conditional operators to TernaryOp (PR #138156)

2025-05-01 Thread Andy Kaylor via cfe-commits
@@ -875,6 +877,174 @@ class ScalarExprEmitter : public StmtVisitor { // NOTE: We don't need to EnsureInsertPoint() like LLVM codegen. return Visit(e->getRHS()); } + + mlir::Value VisitBinLAnd(const clang::BinaryOperator *e) { +if (e->getType()->isVectorType()) {

[clang] [CIR] Upstream lowering of conditional operators to TernaryOp (PR #138156)

2025-05-01 Thread Andy Kaylor via cfe-commits
@@ -1658,6 +1828,170 @@ mlir::Value ScalarExprEmitter::VisitUnaryExprOrTypeTraitExpr( cgf.cgm.UInt64Ty, e->EvaluateKnownConstInt(cgf.getContext(; } +/// Return true if the specified expression is cheap enough and side-effect-free +/// enough to evaluate un

[clang] [CIR] Upstream lowering of conditional operators to TernaryOp (PR #138156)

2025-05-01 Thread Andy Kaylor via cfe-commits
@@ -948,6 +950,165 @@ void CIRGenFunction::emitIgnoredExpr(const Expr *e) { emitLValue(e); } +// Handle the case where the condition is a constant evaluatable simple integer, +// which means we don't have to separately handle the true/false blocks. +static std::optional han

[clang] [CIR] Upstream lowering of conditional operators to TernaryOp (PR #138156)

2025-05-01 Thread Andy Kaylor via cfe-commits
@@ -272,6 +272,22 @@ class CIRBaseBuilderTy : public mlir::OpBuilder { return createCast(loc, cir::CastKind::bitcast, src, newTy); } + // TODO(cir): the following function was introduced to keep in sync with LLVM andykaylor wrote: This probably made se

[clang] [CIR] Upstream lowering of conditional operators to TernaryOp (PR #138156)

2025-05-01 Thread Andy Kaylor via cfe-commits
@@ -948,6 +950,165 @@ void CIRGenFunction::emitIgnoredExpr(const Expr *e) { emitLValue(e); } +// Handle the case where the condition is a constant evaluatable simple integer, +// which means we don't have to separately handle the true/false blocks. +static std::optional han

[clang] [CIR] Upstream lowering of conditional operators to TernaryOp (PR #138156)

2025-05-01 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor edited https://github.com/llvm/llvm-project/pull/138156 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream lowering of conditional operators to TernaryOp (PR #138156)

2025-05-01 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor commented: Could you break this up a bit more? Maybe cut it back to just the code needed for the logical operators? https://github.com/llvm/llvm-project/pull/138156 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [CIR] Upstream lowering of conditional operators to TernaryOp (PR #138156)

2025-05-01 Thread Andy Kaylor via cfe-commits
@@ -948,6 +950,165 @@ void CIRGenFunction::emitIgnoredExpr(const Expr *e) { emitLValue(e); } +// Handle the case where the condition is a constant evaluatable simple integer, +// which means we don't have to separately handle the true/false blocks. +static std::optional han

[clang] [clang] Merge gtest binaries into AllClangUnitTests (PR #134196)

2025-05-01 Thread Reid Kleckner via cfe-commits
rnk wrote: Are the `CodeGenTest.TestNonAlterTest` failures still an issue? I don't see that failure on any bots. I haven't gotten any reports. https://github.com/llvm/llvm-project/pull/134196 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[clang] [C] Diagnose use of C++ keywords in C (PR #137234)

2025-05-01 Thread John McCall via cfe-commits
rjmccall wrote: > For what it's worth, the existing "keyword from language you're not using" > warnings [already fire for analogous Objective-C++ > cases](https://godbolt.org/z/3K6835PPK)... which in those cases is correct, > since Clang does _not_ accept C++11-onwards keywords as selector nam

[clang] [Clang][SYCL] Add initial set of Intel OffloadArch values (PR #138158)

2025-05-01 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `fuchsia-x86_64-linux` running on `fuchsia-debian-64-us-central1-a-1` while building `clang` at step 4 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/11/builds/14237 Here is the relevant

[clang-tools-extra] [clang-tidy] Return error code on config parse error (PR #136167)

2025-05-01 Thread Galen Elias via cfe-commits
https://github.com/galenelias updated https://github.com/llvm/llvm-project/pull/136167 >From b8faa7bb02fb4aa0504978dad1a28493fc745786 Mon Sep 17 00:00:00 2001 From: Galen Elias Date: Wed, 16 Apr 2025 12:48:18 -0700 Subject: [PATCH 1/6] [clang-tidy] Return error code on config parse error This

[clang] [HLSL][SPIRV] Add CLI option `-fspv-extension` (PR #137985)

2025-05-01 Thread Cassandra Beckley via cfe-commits
@@ -9213,6 +9213,11 @@ def metal : DXCFlag<"metal">, HelpText<"Generate Metal library">; def fspv_target_env_EQ : Joined<["-"], "fspv-target-env=">, Group, HelpText<"Specify the target environment">, Values<"vulkan1.2, vulkan1.3">; +def fspv_extension_EQ +: Joined<["-"

[clang] [HLSL][SPIRV] Add CLI option `-fspv-extension` (PR #137985)

2025-05-01 Thread Cassandra Beckley via cfe-commits
https://github.com/cassiebeckley approved this pull request. https://github.com/llvm/llvm-project/pull/137985 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Don't warn for implicit uses of builtins in system headers (PR #138205)

2025-05-01 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex created https://github.com/llvm/llvm-project/pull/138205 Running CI >From c66ec11d8170a0e4c0b2fc50bdae039fd9c208fb Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Thu, 1 May 2025 14:47:45 -0700 Subject: [PATCH] [clang][Sema] Don't warn for implicit uses of builtin

[clang] [CIR] Upstream support for range-based for loops (PR #138176)

2025-05-01 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor closed https://github.com/llvm/llvm-project/pull/138176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   5   6   >