llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Timm Baeder (tbaederr)
Changes
We have `discard()` these days.
---
Full diff: https://github.com/llvm/llvm-project/pull/123024.diff
1 Files Affected:
- (modified) clang/lib/AST/ByteCode/Compiler.cpp (+1-6)
``diff
diff --git a
https://github.com/tbaederr created
https://github.com/llvm/llvm-project/pull/123024
We have `discard()` these days.
>From b6da1ccfe8f0ff9ff25e226dc01b781291892c65 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?=
Date: Wed, 15 Jan 2025 08:50:52 +0100
Subject: [PATCH] [clang][byteco
kadircet wrote:
can you update `clang-tools-extra/clangd/TidyFastChecks.inc` in a follow up
change, after this check lands in its final shape?
https://github.com/llvm/llvm-project/pull/122940
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
@@ -1205,6 +1205,23 @@ class ASTReader
/// been completed.
std::deque PendingDeclContextInfos;
+ /// Deserialization of some attributes must be deferred since they refer
+ /// to themselves in their type (e.g., preferred_name attribute refers to the
+ /// typedef that r
https://github.com/ChuanqiXu9 commented:
Thanks.
(1) Hardcoding is generally not good. And even if we have to, e.g., (we don't
have an automatic mechanism to check if we need to defer an attribute), let's
avoid hardcoding in both reader side and writer side. We can make this by
adding a new b
@@ -1205,6 +1205,23 @@ class ASTReader
/// been completed.
std::deque PendingDeclContextInfos;
+ /// Deserialization of some attributes must be deferred since they refer
+ /// to themselves in their type (e.g., preferred_name attribute refers to the
+ /// typedef that r
https://github.com/ChuanqiXu9 edited
https://github.com/llvm/llvm-project/pull/122726
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tbaederr closed
https://github.com/llvm/llvm-project/pull/122941
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Timm Baeder
Date: 2025-01-15T08:41:20+01:00
New Revision: d1d25641f4cb87ab2c07a4136ba1cec4fb6cf578
URL:
https://github.com/llvm/llvm-project/commit/d1d25641f4cb87ab2c07a4136ba1cec4fb6cf578
DIFF:
https://github.com/llvm/llvm-project/commit/d1d25641f4cb87ab2c07a4136ba1cec4fb6cf578.diff
L
https://github.com/zyn0217 created
https://github.com/llvm/llvm-project/pull/123022
We missed a case of type constraints referencing deduced template parameters
when constructing a deduction guide for the type alias. This patch fixes the
issue by swapping the order of constructing 'template ar
bevin-hansson wrote:
Thanks for merging!
https://github.com/llvm/llvm-project/pull/120099
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Ritanya-B-Bharadwaj wrote:
ping
https://github.com/llvm/llvm-project/pull/118471
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca edited
https://github.com/llvm/llvm-project/pull/122282
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -66,6 +66,12 @@ bool IntrinsicInst::mayLowerToFunctionCall(Intrinsic::ID
IID) {
}
}
+bool IntrinsicInst::canAccessFPEnvironment(LLVMContext &C, Intrinsic::ID IID) {
+ AttributeList Attrs = Intrinsic::getAttributes(C, IID);
+ MemoryEffects ME = Attrs.getMemoryEffects();
Author: Chuanqi Xu
Date: 2025-01-15T15:15:35+08:00
New Revision: 7201cae106260aeb3e97d5291ff30f05076a
URL:
https://github.com/llvm/llvm-project/commit/7201cae106260aeb3e97d5291ff30f05076a
DIFF:
https://github.com/llvm/llvm-project/commit/7201cae106260aeb3e97d5291ff30f05076a.diff
LO
https://github.com/ChuanqiXu9 closed
https://github.com/llvm/llvm-project/pull/122887
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ChuanqiXu9 wrote:
Now CI passes. I want to land this in 20.x and give it some baking times so
that we can find issues in it if any. Post commit review comments are welcomed
as always.
https://github.com/llvm/llvm-project/pull/122887
___
cfe-commits
@@ -28188,6 +28188,16 @@ TEST_F(FormatTest, BreakBinaryOperations) {
" | byte_buffer[2] << 16\n"
" | byte_buffer[3] << 24;",
Style);
+
+ Style.BreakBinaryOperations = FormatStyle::BBO_OnePerLine;
+
@@ -28188,6 +28188,17 @@ TEST_F(FormatTest, BreakBinaryOperations) {
" | byte_buffer[2] << 16\n"
" | byte_buffer[3] << 24;",
Style);
owenca wrote:
```suggestion
Style
alokkrsharma wrote:
> The fix doesn't look right to me...
Thanks for your comment [shiltian](https://github.com/shiltian). I would love
to address your concern and improve the patch. Please help me with the example.
https://github.com/llvm/llvm-project/pull/122047
_
alokkrsharma wrote:
> Maybe it fixes debug info, but definitely breaks some of the OpenMP support
Thanks for your comment. Though I intend to delete only unused instructions but
it is possible that I have overlooked something. Would you please help me with
some example, I will improve the fix
HighCommander4 wrote:
> Seems to be template-related.
>
> test.hpp:
>
> ```c++
> template
> struct templated {
> // comment
> void foo();
> };
> struct nontemplated {
> // comment
> void foo();
> };
> ```
>
> test.cpp:
>
> ```c++
> #include "main.hpp"
> void foo() {
> nontemplated
Author: Bevin Hansson
Date: 2025-01-15T01:14:20-05:00
New Revision: 030d48b7db9845f42bf3ef365193bfdbb23f5440
URL:
https://github.com/llvm/llvm-project/commit/030d48b7db9845f42bf3ef365193bfdbb23f5440
DIFF:
https://github.com/llvm/llvm-project/commit/030d48b7db9845f42bf3ef365193bfdbb23f5440.diff
https://github.com/HighCommander4 closed
https://github.com/llvm/llvm-project/pull/120099
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HighCommander4 approved this pull request.
Thanks for the update! This looks good, I'll go ahead and merge it.
https://github.com/llvm/llvm-project/pull/120099
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llv
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Kazu Hirata (kazutakahirata)
Changes
Note that PointerUnion::dyn_cast has been soft deprecated in
PointerUnion.h:
// FIXME: Replace the uses of is(), get() and dyn_cast() with
//isa, cast and the llvm::dyn_cast
Litera
https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/123014
Note that PointerUnion::dyn_cast has been soft deprecated in
PointerUnion.h:
// FIXME: Replace the uses of is(), get() and dyn_cast() with
//isa, cast and the llvm::dyn_cast
Literal migration
https://github.com/Sharjeel-Khan updated
https://github.com/llvm/llvm-project/pull/122969
>From ebbb016b161165fff8335213e89dbbf8135a5329 Mon Sep 17 00:00:00 2001
From: Sharjeel Khan
Date: Tue, 14 Jan 2025 19:02:31 +
Subject: [PATCH] Fix hardcoding of NEON FPU for armv8
Android hardcoded NE
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Kazu Hirata (kazutakahirata)
Changes
Note that PointerUnion::dyn_cast has been soft deprecated in
PointerUnion.h:
// FIXME: Replace the uses of is(), get() and dyn_cast() with
//isa, cast and the llvm::dyn_cast
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Kazu Hirata (kazutakahirata)
Changes
Note that PointerUnion::dyn_cast has been soft deprecated in
PointerUnion.h:
// FIXME: Replace the uses of is(), get() and dyn_cast() with
//isa, cast and the llvm::dyn_cast
Litera
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Kazu Hirata (kazutakahirata)
Changes
Note that PointerUnion::dyn_cast has been soft deprecated in
PointerUnion.h:
// FIXME: Replace the uses of is(), get() and dyn_cast() with
//isa, cast and the llvm::dyn_cast
Litera
https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/123013
Note that PointerUnion::dyn_cast has been soft deprecated in
PointerUnion.h:
// FIXME: Replace the uses of is(), get() and dyn_cast() with
//isa, cast and the llvm::dyn_cast
Literal migration
https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/123012
Note that PointerUnion::dyn_cast has been soft deprecated in
PointerUnion.h:
// FIXME: Replace the uses of is(), get() and dyn_cast() with
//isa, cast and the llvm::dyn_cast
Literal migration
https://github.com/ChuanqiXu9 updated
https://github.com/llvm/llvm-project/pull/122887
>From a259ccafe9b6f7efc740cd7203d44fd4170a25dc Mon Sep 17 00:00:00 2001
From: Chuanqi Xu
Date: Thu, 26 Dec 2024 16:00:51 +0800
Subject: [PATCH] [C++20] [Modules] Support module level lookup
Close https://git
@@ -196,3 +196,13 @@ Options
// The following pointer may not become a 'int *const'.
int *changing_pointee = &value;
changing_pointee = &result;
+
+.. option:: AllowedTypes (default = '')
+
+ A semicolon-separated list of names of types that
+ will be excluded fro
https://github.com/Sharjeel-Khan edited
https://github.com/llvm/llvm-project/pull/122969
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -196,3 +196,13 @@ Options
// The following pointer may not become a 'int *const'.
int *changing_pointee = &value;
changing_pointee = &result;
+
+.. option:: AllowedTypes (default = '')
+
+ A semicolon-separated list of names of types that
+ will be excluded fro
@@ -196,3 +196,13 @@ Options
// The following pointer may not become a 'int *const'.
int *changing_pointee = &value;
changing_pointee = &result;
+
+.. option:: AllowedTypes (default = '')
+
+ A semicolon-separated list of names of types that
+ will be excluded fro
@@ -57,6 +61,9 @@ void
ConstCorrectnessCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) {
Options.store(Opts, "TransformValues", TransformValues);
Options.store(Opts, "TransformReferences", TransformReferences);
Options.store(Opts, "TransformPointersAsValues", Tran
@@ -45,6 +45,8 @@ class ConstCorrectnessCheck : public ClangTidyCheck {
const bool TransformValues;
const bool TransformReferences;
const bool TransformPointersAsValues;
+
vbvictor wrote:
Done
https://github.com/llvm/llvm-project/pull/122951
___
@@ -196,3 +196,13 @@ Options
// The following pointer may not become a 'int *const'.
int *changing_pointee = &value;
changing_pointee = &result;
+
+.. option:: AllowedTypes (default = '')
+
+ A semicolon-separated list of names of types that
+ will be excluded fro
https://github.com/vbvictor updated
https://github.com/llvm/llvm-project/pull/122951
>From 841cfec5a0ab4ce5ce64e71facfb7becaf4340e8 Mon Sep 17 00:00:00 2001
From: Victor Baranov
Date: Tue, 14 Jan 2025 22:05:43 +0300
Subject: [PATCH 1/2] [clang-tidy] add AllowedTypes to misc-const-correctness
-
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Galen Elias (galenelias)
Changes
AllowShortNamespacesOnASingleLine assumes that there is no newline before the
namespace brace, however, there is no actual reason this shouldn't be
compatible with BraceWrapping.AfterNamespace = tru
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Brian Cain (androm3da)
Changes
Since this cache value overrides the defaults, we end up with `clang` linked to
`clang-20`, and some `${triple}-clang*` links, but we're missing `clang++`.
This makes for a toolchain with inconsistent behav
https://github.com/androm3da created
https://github.com/llvm/llvm-project/pull/123011
Since this cache value overrides the defaults, we end up with `clang` linked to
`clang-20`, and some `${triple}-clang*` links, but we're missing `clang++`.
This makes for a toolchain with inconsistent behavi
https://github.com/galenelias created
https://github.com/llvm/llvm-project/pull/123010
AllowShortNamespacesOnASingleLine assumes that there is no newline before the
namespace brace, however, there is no actual reason this shouldn't be
compatible with BraceWrapping.AfterNamespace = true.
This
https://github.com/alexander-shaposhnikov approved this pull request.
LG
https://github.com/llvm/llvm-project/pull/122877
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HighCommander4 closed
https://github.com/llvm/llvm-project/pull/122418
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Nathan Ridge
Date: 2025-01-14T23:06:51-05:00
New Revision: 9ac6a55ec54fe4cd4a99c69ef1a4ddaea49e6688
URL:
https://github.com/llvm/llvm-project/commit/9ac6a55ec54fe4cd4a99c69ef1a4ddaea49e6688
DIFF:
https://github.com/llvm/llvm-project/commit/9ac6a55ec54fe4cd4a99c69ef1a4ddaea49e6688.diff
https://github.com/a-tarasyuk updated
https://github.com/llvm/llvm-project/pull/121419
>From 3f6b1d68978857035a972f49b1cfd9d9d0151be9 Mon Sep 17 00:00:00 2001
From: Oleksandr T
Date: Wed, 1 Jan 2025 01:47:17 +0200
Subject: [PATCH 1/6] [Clang] emit -Wignored-qualifiers diagnostic for
cv-qualifi
https://github.com/alexander-shaposhnikov approved this pull request.
LG
https://github.com/llvm/llvm-project/pull/122918
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -116,26 +118,78 @@ findMembersUsedInInitExpr(const CXXCtorInitializer
*Initializer,
return Results;
}
-/// Returns the full source range for the field declaration up to (not
-/// including) the trailing semicolumn, including potential macro invocations,
-/// e.g. `int a
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Michael Flanders (Flandini)
Changes
This trait associates MemSpaceRegions with MemRegions to allow refining or
changing information known about memory regions after they are created, since
they are immutable. This commit is an intermediat
https://github.com/Flandini created
https://github.com/llvm/llvm-project/pull/123003
This trait associates MemSpaceRegions with MemRegions to allow refining or
changing information known about memory regions after they are created, since
they are immutable. This commit is an intermediate step
@@ -145,12 +146,18 @@ class ExternalASTSource : public
RefCountedBase {
/// Find all declarations with the given name in the given context,
/// and add them to the context by calling SetExternalVisibleDeclsForName
/// or SetNoExternalVisibleDeclsForName.
- /// \return \
@@ -145,12 +146,18 @@ class ExternalASTSource : public
RefCountedBase {
/// Find all declarations with the given name in the given context,
/// and add them to the context by calling SetExternalVisibleDeclsForName
/// or SetNoExternalVisibleDeclsForName.
- /// \return \
https://github.com/ChuanqiXu9 updated
https://github.com/llvm/llvm-project/pull/122887
>From 0e49792900783f442da68b89fc3b4b3e013d18d3 Mon Sep 17 00:00:00 2001
From: Chuanqi Xu
Date: Thu, 26 Dec 2024 16:00:51 +0800
Subject: [PATCH] [C++20] [Modules] Support module level lookup
Close https://git
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 657fb4433e027722e8c9a5002d0c194ecd3f2956
5c89b9dbf97b57d232817a4716433239e84365a1 --e
https://github.com/ChuanqiXu9 approved this pull request.
Thanks. This looks good to me. And please give @kadircet some time to give it a
look. I'll try to land this in the next week if no more comments came in.
https://github.com/llvm/llvm-project/pull/122606
__
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Thurston Dang (thurstond)
Changes
This reverts commit 1515caf7a59dc20cb932b724b2ef5c1d1a593427
(https://github.com/llvm/llvm-project/pull/122833) i.e., relands
7d8b4eb0ead277f41ff69525ed807f9f6e227f37
(https://github.com/llvm/llvm-project
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 6e14f9b40e15600ae7832826b47a7f0c0503a1d7
02c3d9ef1eb15b0d7ebe7511f200b7c00d52d6c9 --e
ilovepi wrote:
Hmm, the failing bot seems to be some kind of configuration error on the bot
(or issue w/ the docker daemon?)
https://github.com/llvm/llvm-project/actions/runs/12775719644/job/35614829092
https://github.com/llvm/llvm-project/pull/121819
__
@@ -1060,238 +1061,348 @@
CodeGenFunction::evaluateOrEmitBuiltinObjectSize(const Expr *E, unsigned Type,
return ConstantInt::get(ResType, ObjectSize, /*isSigned=*/true);
}
-const FieldDecl *CodeGenFunction::FindFlexibleArrayMemberFieldAndOffset(
-ASTContext &Ctx, const
https://github.com/thurstond created
https://github.com/llvm/llvm-project/pull/122994
This reverts commit 1515caf7a59dc20cb932b724b2ef5c1d1a593427
(https://github.com/llvm/llvm-project/pull/122833) i.e., relands
7d8b4eb0ead277f41ff69525ed807f9f6e227f37
(https://github.com/llvm/llvm-project/pul
https://github.com/farzonl ready_for_review
https://github.com/llvm/llvm-project/pull/122839
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/farzonl updated
https://github.com/llvm/llvm-project/pull/122839
>From ae1a274f856518d710cffba324c603d9e95adf54 Mon Sep 17 00:00:00 2001
From: Farzon Lotfi
Date: Thu, 9 Jan 2025 19:19:27 -0500
Subject: [PATCH] [SPIRV] add pre legalization instruction combine - Add the
boiler
https://github.com/Icohedron edited
https://github.com/llvm/llvm-project/pull/122992
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Icohedron edited
https://github.com/llvm/llvm-project/pull/122992
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-hlsl
Author: Deric Cheung (Icohedron)
Changes
Fixes #99152
Tasks completed:
- Implement `reflect` in `clang/lib/Headers/hlsl/hlsl_intrinsics.h`
- Implement the `reflect` SPIR-V target built-in in
`clang/include/clang/Basic/BuiltinsSPIRV.td`
- Add a SP
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Deric Cheung (Icohedron)
Changes
Fixes #99152
Tasks completed:
- Implement `reflect` in `clang/lib/Headers/hlsl/hlsl_intrinsics.h`
- Implement the `reflect` SPIR-V target built-in in
`clang/include/clang/Basic/BuiltinsSPIRV.td`
- Add a S
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Deric Cheung (Icohedron)
Changes
Fixes #99152
Tasks completed:
- Implement `reflect` in `clang/lib/Headers/hlsl/hlsl_intrinsics.h`
- Implement the `reflect` SPIR-V target built-in in
`clang/include/clang/Basic/BuiltinsSPIRV.td`
-
https://github.com/Icohedron created
https://github.com/llvm/llvm-project/pull/122992
Fixes #99152
Tasks completed:
- Implement `reflect` in `clang/lib/Headers/hlsl/hlsl_intrinsics.h`
- Implement the `reflect` SPIR-V target built-in in
`clang/include/clang/Basic/BuiltinsSPIRV.td`
- Add a SPIR
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/120348
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: zotnhucucbot
Date: 2025-01-15T07:59:03+08:00
New Revision: bc74625f50e216edd16f436c4fc81ff585b6c4c7
URL:
https://github.com/llvm/llvm-project/commit/bc74625f50e216edd16f436c4fc81ff585b6c4c7
DIFF:
https://github.com/llvm/llvm-project/commit/bc74625f50e216edd16f436c4fc81ff585b6c4c7.diff
efriedma-quic wrote:
The 32-bit Arm failures are fixed by 7aec7caca30f800811b76ba94291645494788a4f .
The other failures appear to be unrelated.
https://github.com/llvm/llvm-project/pull/120300
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
https://github.com/HerrCai0907 approved this pull request.
https://github.com/llvm/llvm-project/pull/122957
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `llvm-clang-win-x-armv7l`
running on `as-builder-1` while building `clang` at step 15
"test-check-cxx-armv7-unknown-linux-gnueabihf".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/38/builds/1830
Her
https://github.com/inbelic ready_for_review
https://github.com/llvm/llvm-project/pull/122982
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/inbelic ready_for_review
https://github.com/llvm/llvm-project/pull/122981
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,152 @@
+#include "clang/Parse/ParseHLSLRootSignature.h"
+
+namespace llvm {
+namespace hlsl {
+namespace root_signature {
+
+// Lexer Definitions
+
+static bool IsPreprocessorNumberChar(char C) {
+ // TODO: extend for float support with or without hexadecimal/exponent
@@ -0,0 +1,96 @@
+//===--- ParseHLSLRootSignature.h ---*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/inbelic updated
https://github.com/llvm/llvm-project/pull/122981
>From c1fc823abf07dfb8326b6190672d9881890bbb15 Mon Sep 17 00:00:00 2001
From: Finn Plummer
Date: Tue, 14 Jan 2025 22:22:45 +
Subject: [PATCH 1/2] [HLSL][RootSignature] Implement Lexing of
DescriptorTables
@@ -0,0 +1,151 @@
+#include "clang/Parse/ParseHLSLRootSignature.h"
+
+namespace llvm {
+namespace hlsl {
+namespace root_signature {
+
+// Lexer Definitions
+
+static bool IsPreprocessorNumberChar(char C) {
+ // TODO: extend for float support with or without hexadecimal/exponent
https://github.com/V-FEXrt approved this pull request.
https://github.com/llvm/llvm-project/pull/122977
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
inbelic wrote:
Please ignore the first commit. It is a duplicate of
https://github.com/llvm/llvm-project/pull/122981
https://github.com/llvm/llvm-project/pull/122982
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bi
https://github.com/inbelic created
https://github.com/llvm/llvm-project/pull/122982
- Defines the in-memory data layout for the Descriptor Table Clauses, its
dependent flags/enums and parent RootElement in HLSLRootSignature.h
- Implements a Parser and its required Parsing methods in ParseHLSLRo
https://github.com/inbelic created
https://github.com/llvm/llvm-project/pull/122981
- Define required tokens to parse a Descriptor Table in TokenKinds.def
- Implements a Lexer to handle all of the defined tokens in
ParseHLSLRootSignature
This is an initial part of #120472
>From c1fc823abf07df
Author: Eli Friedman
Date: 2025-01-14T14:49:45-08:00
New Revision: 7aec7caca30f800811b76ba94291645494788a4f
URL:
https://github.com/llvm/llvm-project/commit/7aec7caca30f800811b76ba94291645494788a4f
DIFF:
https://github.com/llvm/llvm-project/commit/7aec7caca30f800811b76ba94291645494788a4f.diff
Un1q32 wrote:
> Can you add a test?
Is the CHECK line enough or do you want something more? My understanding is
that the CHECK lines are tests, but I'm not sure since this was sent after the
request for the CHECK line.
https://github.com/llvm/llvm-project/pull/122965
a-tarasyuk wrote:
@AaronBallman @erichkeane I’ve switched back to the version without the std
check. should the diagnostic group be changed?
https://github.com/llvm/llvm-project/pull/106036
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https
a-tarasyuk wrote:
@AaronBallman @erichkeane I’ve switched back to the version without the std
check. should the diagnostic group be changed?
https://github.com/llvm/llvm-project/pull/106036
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
https://github.com/a-tarasyuk ready_for_review
https://github.com/llvm/llvm-project/pull/106036
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ricejasonf wrote:
@erichkeane, thanks for the approval. Does that mean I should stop making
changes to this PR? I was messing with a more rangey interface for
`flat_bindings`, but for some reason the `llvm::concat` range was referring to
uninitialized memory when used as a temporary in a for l
yxsamliu wrote:
> Can we get a new test showing CUDA? CUDA uses the new driver by default so
> cuid stuff will be missing there.
Added.
https://github.com/llvm/llvm-project/pull/122859
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://l
https://github.com/yxsamliu updated
https://github.com/llvm/llvm-project/pull/122859
>From 38939c7ecd5b29d92cffcb4fa3911159bd37d0e5 Mon Sep 17 00:00:00 2001
From: "Yaxun (Sam) Liu"
Date: Mon, 13 Jan 2025 14:12:52 -0500
Subject: [PATCH] [CUDA][HIP] Support CUID in new driver
CUID is needed by C
@@ -2412,6 +2412,102 @@ bool SemaHLSL::CheckCompatibleParameterABI(FunctionDecl
*New,
return HadError;
}
+// Generally follows PerformScalarCast, with cases reordered for
+// clarity of what types are supported
+bool SemaHLSL::CanPerformScalarCast(QualType SrcTy, QualType D
@@ -491,6 +491,81 @@ static bool isTrivialFiller(Expr *E) {
return false;
}
+// emit a flat cast where the RHS is a scalar, including vector
+static void EmitHLSLScalarFlatCast(CodeGenFunction &CGF, Address DestVal,
+ QualType DestTy, llvm::
@@ -2752,7 +2787,17 @@ Value *ScalarExprEmitter::VisitCastExpr(CastExpr *CE) {
llvm::Value *Zero = llvm::Constant::getNullValue(CGF.SizeTy);
return Builder.CreateExtractElement(Vec, Zero, "cast.vtrunc");
}
+ case CK_HLSLAggregateCast: {
+RValue RV = CGF.EmitAnyEx
@@ -6358,3 +6359,89 @@ RValue CodeGenFunction::EmitPseudoObjectRValue(const
PseudoObjectExpr *E,
LValue CodeGenFunction::EmitPseudoObjectLValue(const PseudoObjectExpr *E) {
return emitPseudoObjectExpr(*this, E, true, AggValueSlot::ignored()).LV;
}
+
+void CodeGenFunction::Fl
https://github.com/llvm-beanz commented:
I want to spend a little more time going over the tests, but I had a few small
comments. This seems to be mostly right from my initial review.
https://github.com/llvm/llvm-project/pull/118842
___
cfe-commits ma
1 - 100 of 544 matches
Mail list logo
