[clang] [clang][Sema] Fixes for %b printf extension handling (PR #120689)

2025-01-13 Thread Brad Smith via cfe-commits
https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/120689 >From 5f01b45635d4fe6bb22161d2312dca0c0df86827 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Thu, 19 Dec 2024 21:35:57 -0500 Subject: [PATCH] [clang][Sema] Fixes for %b printf extension handling The %b printf e

[clang-tools-extra] [clang-tidy] Add readability-string-view-substr check (PR #120055)

2025-01-13 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL requested changes to this pull request. Should be readability-stringview-substr There are already 2 other checks that use "stringview" instead of "string-view". https://github.com/llvm/llvm-project/pull/120055 ___ cfe-commit

[clang] [NFC]Update -fsplit-machine-functions now aarch64 function splitting is supported (PR #122860)

2025-01-13 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building `clang` at step 7 "Add check check-offload". Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/11653 Here is the r

[clang] [Driver] Teach Barmetal toolchain about GCC installation(1/3) (PR #121829)

2025-01-13 Thread Fangrui Song via cfe-commits
@@ -110,20 +111,93 @@ static std::string computeBaseSysRoot(const Driver &D, bool IncludeTriple) { return std::string(SysRootDir); } +// GCC sysroot here means form sysroot from either --gcc-install-dir, or from +// --gcc-toolchain or if the toolchain is installed alongside

[clang] [NFC]Update -fsplit-machine-functions now aarch64 function splitting is supported (PR #122860)

2025-01-13 Thread Mingming Liu via cfe-commits
mingmingl-llvm wrote: thanks for taking a look! https://github.com/llvm/llvm-project/pull/122860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 1ac52ec - [NFC]Update -fsplit-machine-functions now aarch64 function splitting is supported (#122860)

2025-01-13 Thread via cfe-commits
Author: Mingming Liu Date: 2025-01-13T21:35:52-08:00 New Revision: 1ac52ec40acfcc039ab830404e7f7ac72dfe8480 URL: https://github.com/llvm/llvm-project/commit/1ac52ec40acfcc039ab830404e7f7ac72dfe8480 DIFF: https://github.com/llvm/llvm-project/commit/1ac52ec40acfcc039ab830404e7f7ac72dfe8480.diff

[clang] [NFC]Update -fsplit-machine-functions now aarch64 function splitting is supported (PR #122860)

2025-01-13 Thread Mingming Liu via cfe-commits
https://github.com/mingmingl-llvm closed https://github.com/llvm/llvm-project/pull/122860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC]Update -fsplit-machine-functions now aarch64 function splitting is supported (PR #122860)

2025-01-13 Thread Mingming Liu via cfe-commits
https://github.com/mingmingl-llvm edited https://github.com/llvm/llvm-project/pull/122860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC]Update -fsplit-machine-functions now aarch64 function splitting is supported (PR #122860)

2025-01-13 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/122860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC]Update -fsplit-machine-functions now aarch64 function splitting is supported (PR #122860)

2025-01-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Mingming Liu (mingmingl-llvm) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/122860.diff 1 Files Affected: - (modified) clang/include/clang/Driver/Options.td (+1-1) ``diff diff --git a/clang/include/clang/D

[clang] [NFC]Update -fsplit-machine-functions now aarch64 function splitting is supported (PR #122860)

2025-01-13 Thread Mingming Liu via cfe-commits
https://github.com/mingmingl-llvm created https://github.com/llvm/llvm-project/pull/122860 None >From 4d095938962f078f1b1d6d35c28f5fbae4a1349d Mon Sep 17 00:00:00 2001 From: mingmingl Date: Mon, 13 Jan 2025 21:32:15 -0800 Subject: [PATCH] [NFC]Update -fsplit-machine-functions now aarch64 funct

[libclc] [libclc] Move fp16 pragma guards out of header file (PR #122751)

2025-01-13 Thread Matt Arsenault via cfe-commits
@@ -207,10 +207,6 @@ return BUILTIN(x); \ } -#ifdef cl_khr_fp16 - -#pragma OPENCL EXTENSION cl_khr_fp16 : enable - #define _CLC_DEFINE_UNARY_BUILTIN_FP16(FUNCTION) \ _CLC_DEF _CLC

[clang] [StaticAnalyzer] Migrate away from PointerUnion::dyn_cast (NFC) (PR #122856)

2025-01-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Kazu Hirata (kazutakahirata) Changes Note that PointerUnion::dyn_cast has been soft deprecated in PointerUnion.h: // FIXME: Replace the uses of is(), get() and dyn_cast() with //isa, cast and the llvm::d

[clang] [CUDA][HIP] Support CUID in new driver (PR #122859)

2025-01-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Yaxun (Sam) Liu (yxsamliu) Changes CUID is needed by CUDA/HIP for supporting accessing static device variables in host function. Currently CUID is only supported by the old driver for CUDA/HIP. The new driver does not support it,

[clang] [AST] Avoid repeated map lookups (NFC) (PR #122858)

2025-01-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/122858.diff 1 Files Affected: - (modified) clang/lib/AST/ExternalASTMerger.cpp (+2-2) ``diff diff --git a/clang/lib/AST/ExternalAS

[clang] [CUDA][HIP] Support CUID in new driver (PR #122859)

2025-01-13 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu created https://github.com/llvm/llvm-project/pull/122859 CUID is needed by CUDA/HIP for supporting accessing static device variables in host function. Currently CUID is only supported by the old driver for CUDA/HIP. The new driver does not support it, which causes

[clang] [AST] Avoid repeated map lookups (NFC) (PR #122858)

2025-01-13 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/122858 None >From 227e7f718acbef18a4b5e93cc6ea8cc0b2249062 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Mon, 13 Jan 2025 21:08:39 -0800 Subject: [PATCH] [AST] Avoid repeated map lookups (NFC) --- clang/li

[clang] [StaticAnalyzer] Migrate away from PointerUnion::dyn_cast (NFC) (PR #122856)

2025-01-13 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/122856 Note that PointerUnion::dyn_cast has been soft deprecated in PointerUnion.h: // FIXME: Replace the uses of is(), get() and dyn_cast() with //isa, cast and the llvm::dyn_cast Literal migration

[clang] [Sema] Migrate away from PointerUnion::dyn_cast (NFC) (PR #122855)

2025-01-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes Note that PointerUnion::dyn_cast has been soft deprecated in PointerUnion.h: // FIXME: Replace the uses of is(), get() and dyn_cast() with //isa, cast and the llvm::dyn_cast Litera

[clang] [AST] Migrate away from PointerUnion::dyn_cast (NFC) (PR #122854)

2025-01-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes Note that PointerUnion::dyn_cast has been soft deprecated in PointerUnion.h: // FIXME: Replace the uses of is(), get() and dyn_cast() with //isa, cast and the llvm::dyn_cast Litera

[clang] [Sema] Migrate away from PointerUnion::dyn_cast (NFC) (PR #122855)

2025-01-13 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/122855 Note that PointerUnion::dyn_cast has been soft deprecated in PointerUnion.h: // FIXME: Replace the uses of is(), get() and dyn_cast() with //isa, cast and the llvm::dyn_cast Literal migration

[clang] [AST] Migrate away from PointerUnion::dyn_cast (NFC) (PR #122854)

2025-01-13 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/122854 Note that PointerUnion::dyn_cast has been soft deprecated in PointerUnion.h: // FIXME: Replace the uses of is(), get() and dyn_cast() with //isa, cast and the llvm::dyn_cast Literal migration

[clang] [CodeGen] Migrate away from PointerUnion::dyn_cast (NFC) (PR #122778)

2025-01-13 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/122778 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 35f9d2a - [CodeGen] Migrate away from PointerUnion::dyn_cast (NFC) (#122778)

2025-01-13 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-01-13T20:53:13-08:00 New Revision: 35f9d2ac49eb3344f528c5b0c3b75330ade93982 URL: https://github.com/llvm/llvm-project/commit/35f9d2ac49eb3344f528c5b0c3b75330ade93982 DIFF: https://github.com/llvm/llvm-project/commit/35f9d2ac49eb3344f528c5b0c3b75330ade93982.diff L

[clang] [HLSL] cbuffer: Create host layout struct and add resource handle to AST (PR #122820)

2025-01-13 Thread Helena Kotas via cfe-commits
https://github.com/hekota updated https://github.com/llvm/llvm-project/pull/122820 >From 71ddb5a2b4cc8a9609410b436e896484401f5e90 Mon Sep 17 00:00:00 2001 From: Helena Kotas Date: Mon, 13 Jan 2025 15:03:12 -0800 Subject: [PATCH] [HLSL] cbuffer: Create host layout struct and add resource handle

[clang] [llvm] [sanitizer][NFCI] Add Options parameter to LowerAllowCheckPass (PR #122765)

2025-01-13 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-expensive-checks-debian` running on `gribozavr4` while building `clang,llvm` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/16/builds/1

[clang] clang/limits.h: Avoid including limits.h twice (PR #120526)

2025-01-13 Thread YunQiang Su via cfe-commits
wzssyqa wrote: You are right. My patch only fix the first problem: making a unit test of glibc happy. The failure test case of glibc is: * check-local-headers See: https://github.com/llvm/llvm-project/pull/120673 also. https://github.com/llvm/llvm-project/pull/120526 __

[clang-tools-extra] [clang-tidy][clangd] Fixed removeFunctionArgs don't remove comma for use-ranges check (PR #118568)

2025-01-13 Thread Richard Li via cfe-commits
https://github.com/chomosuke updated https://github.com/llvm/llvm-project/pull/118568 >From b43a2602025bdacea06ced5171904fb5d765de9f Mon Sep 17 00:00:00 2001 From: chomosuke Date: Tue, 3 Dec 2024 07:10:33 + Subject: [PATCH 1/3] fixed removeFunctionArgs don't remove comma --- .../clang-tid

[clang-tools-extra] [clang-tidy][clangd] Fixed removeFunctionArgs don't remove comma for use-ranges check (PR #118568)

2025-01-13 Thread Richard Li via cfe-commits
https://github.com/chomosuke edited https://github.com/llvm/llvm-project/pull/118568 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [NFC] Add implicit cast kinds for function pointer conversions (PR #110048)

2025-01-13 Thread Akira Hatanaka via cfe-commits
https://github.com/ahatanak closed https://github.com/llvm/llvm-project/pull/110048 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PAC] Re-sign a pointer to a noexcept member function when it is converted to a pointer to a member function without noexcept (PR #109056)

2025-01-13 Thread Akira Hatanaka via cfe-commits
https://github.com/ahatanak closed https://github.com/llvm/llvm-project/pull/109056 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add readability-string-view-substr check (PR #120055)

2025-01-13 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 approved this pull request. LGTM, please update release note https://github.com/llvm/llvm-project/pull/120055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang] [PAC] Re-sign a pointer to a noexcept member function when it is converted to a pointer to a member function without noexcept (PR #109056)

2025-01-13 Thread Akira Hatanaka via cfe-commits
https://github.com/ahatanak reopened https://github.com/llvm/llvm-project/pull/109056 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PAC] Re-sign a pointer to a noexcept member function when it is converted to a pointer to a member function without noexcept (PR #109056)

2025-01-13 Thread Akira Hatanaka via cfe-commits
ahatanak wrote: I meant to close https://github.com/llvm/llvm-project/pull/110048. https://github.com/llvm/llvm-project/pull/109056 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [NFC] Add implicit cast kinds for function pointer conversions (PR #110048)

2025-01-13 Thread Akira Hatanaka via cfe-commits
ahatanak wrote: This change isn't needed anymore as it was decided that noexcept shouldn't be used to compute discriminators of function and member function pointers (see https://github.com/llvm/llvm-project/issues/106487#issuecomment-2440364300). https://github.com/llvm/llvm-project/pull/1100

[clang] [PAC] Re-sign a pointer to a noexcept member function when it is converted to a pointer to a member function without noexcept (PR #109056)

2025-01-13 Thread Akira Hatanaka via cfe-commits
ahatanak wrote: This change isn't needed anymore as it was decided that `noexcept` shouldn't be used to compute discriminators of function and member function pointers (see https://github.com/llvm/llvm-project/issues/106487#issuecomment-2440364300). https://github.com/llvm/llvm-project/pull/10

[clang] [llvm] [HLSL][SPIRV][DXIL] Implement `WaveActiveSum` intrinsic (PR #118580)

2025-01-13 Thread Steven Perron via cfe-commits
https://github.com/s-perron approved this pull request. https://github.com/llvm/llvm-project/pull/118580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix print module manifest file for macos (PR #122370)

2025-01-13 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 milestoned https://github.com/llvm/llvm-project/pull/122370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix print module manifest file for macos (PR #122370)

2025-01-13 Thread via cfe-commits
llvmbot wrote: /pull-request llvm/llvm-project#122844 https://github.com/llvm/llvm-project/pull/122370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix print module manifest file for macos (PR #122370)

2025-01-13 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: > Should this be backported to older supported releases as well? (FWIW, I think > so.) But I am not sure if there is still release there. https://github.com/llvm/llvm-project/pull/122370 ___ cfe-commits mailing list cfe-commits@list

[clang] Fix print module manifest file for macos (PR #122370)

2025-01-13 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: /cherry-pick https://github.com/llvm/llvm-project/commit/acbd822879f7727127926c25e1b47f5017f962c5 https://github.com/llvm/llvm-project/pull/122370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[clang] [llvm] [Clang] restrict use of attribute names reserved by the C++ standard (PR #106036)

2025-01-13 Thread Erich Keane via cfe-commits
erichkeane wrote: > Oh, I see, you're suggesting we remove the `getStdNamespace` check from this > PR. Yeah, I think that's reasonable. Yep, that is my suggestion, sorry I was insufficiently clear. > But I'd somewhat question whether this PR and warning really has anything to > do with the at

[clang] [llvm] [SPIRV] add pre legalization instruction combine (PR #122839)

2025-01-13 Thread Farzon Lotfi via cfe-commits
@@ -1,33 +1,44 @@ -; RUN: llc -O0 -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s farzonl wrote: changed line endings from crlf to lf. https://github.com/llvm/llvm-project/pull/122839 ___ cfe-commits mailing list

[clang] [llvm] [Clang] restrict use of attribute names reserved by the C++ standard (PR #106036)

2025-01-13 Thread Richard Smith via cfe-commits
zygoloid wrote: Oh, I see, you're suggesting we remove the `getStdNamespace` check from this PR. Yeah, I think that's reasonable. But I'd somewhat question whether this PR and warning really has anything to do with the attribute names being "reserved" at that point -- we're not checking wheth

[clang] [clang] Implement gcc_struct attribute on Itanium targets (PR #71148)

2025-01-13 Thread Eli Friedman via cfe-commits
@@ -997,6 +997,9 @@ def warn_npot_ms_struct : Warning< "data types with sizes that aren't a power of two">, DefaultError, InGroup; +def err_itanium_layout_unimplemented : Error< + "Itanium-compatible layout for the Microsoft C++ ABI is not yet supported">; ---

[clang] [clang] Implement gcc_struct attribute on Itanium targets (PR #71148)

2025-01-13 Thread Eli Friedman via cfe-commits
@@ -0,0 +1,18 @@ +// RUN: %clang_cc1 -emit-llvm-only -triple x86_64-pc-linux-gnu %s +// RUN: %clang_cc1 -emit-llvm-only -triple x86_64-pc-linux-gnu -fms-layout-compatibility=microsoft %s +// RUN: %clang_cc1 -emit-llvm-only -triple x86_64-pc-windows-gnu %s +// RUN: %clang_cc1 -emi

[clang-tools-extra] [clang-tidy] Add readability-string-view-substr check (PR #120055)

2025-01-13 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/120055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add readability-string-view-substr check (PR #120055)

2025-01-13 Thread Julian Schmidt via cfe-commits
@@ -0,0 +1,217 @@ +//===--- StringViewSubstrCheck.cpp - clang-tidy--*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clang-tidy] Add readability-string-view-substr check (PR #120055)

2025-01-13 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti commented: You can move even more into the matchers. Here is a mock-up of what I mean (untested): ``` m cxxMemberCallExpr( anyOf( cxxMemberCallExpr( argumentCountIs(1) # is substr, and bind arg 1 ), cxxMemberCallExpr( argumentCoun

[clang-tools-extra] [clang-tidy] Add readability-string-view-substr check (PR #120055)

2025-01-13 Thread Julian Schmidt via cfe-commits
@@ -0,0 +1,217 @@ +//===--- StringViewSubstrCheck.cpp - clang-tidy--*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [Clang][counted_by] Refactor __builtin_dynamic_object_size on FAMs (PR #122198)

2025-01-13 Thread Yeoul Na via cfe-commits
https://github.com/rapidsna commented: Thanks for addressing comments! LGTM. You may still need to wait on Clang code owners review though. https://github.com/llvm/llvm-project/pull/122198 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[clang] [Clang] disallow the use of asterisks preceding constructor and destructor names (PR #122621)

2025-01-13 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/122621 >From b2c656afdf99eff52d019b68fcbbc6ce4bbdd7d3 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sun, 12 Jan 2025 00:51:47 +0200 Subject: [PATCH 1/8] [Clang] disallow the use of asterisks preceding constructo

[clang] [clang] Do not allow unorderable features in [[gnu::target{,_clones}]] (PR #98426)

2025-01-13 Thread Dan Klishch via cfe-commits
https://github.com/DanShaders updated https://github.com/llvm/llvm-project/pull/98426 >From 723205411efe18dbe8bb154839525b59963b1638 Mon Sep 17 00:00:00 2001 From: Dan Klishch Date: Wed, 10 Jul 2024 23:39:42 -0400 Subject: [PATCH 1/2] [clang] Do not allow unorderable features in [[gnu::target{

[clang] [llvm] [X86] Extend kCFI with a 3-bit arity indicator (PR #121070)

2025-01-13 Thread Scott Constable via cfe-commits
scottconstable wrote: > > maurer: I think their point is that even if you are not changing the hash > > scheme, you are proposing breaking compatibility of the identifier with > > existing code. Since we don't want to do this many times, if we are > > breaking compatibility with existing code,

[clang] [llvm] [sanitizer][NFCI] Add Options parameter to LowerAllowCheckPass (PR #122765)

2025-01-13 Thread Thurston Dang via cfe-commits
@@ -20,13 +20,22 @@ namespace llvm { +struct LowerAllowCheckOptions { thurstond wrote: Done https://github.com/llvm/llvm-project/pull/122765 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[clang] [llvm] [sanitizer][NFCI] Add Options parameter to LowerAllowCheckPass (PR #122765)

2025-01-13 Thread Thurston Dang via cfe-commits
@@ -20,13 +20,22 @@ namespace llvm { +struct LowerAllowCheckOptions { + std::vector placeholder; // TODO: cutoffs thurstond wrote: Done https://github.com/llvm/llvm-project/pull/122765 ___ cfe-commits mailing lis

[clang] [llvm] [sanitizer][NFCI] Add Options parameter to LowerAllowCheckPass (PR #122765)

2025-01-13 Thread Thurston Dang via cfe-commits
https://github.com/thurstond updated https://github.com/llvm/llvm-project/pull/122765 >From 6c244a083b458637f35149547270ba25675ca417 Mon Sep 17 00:00:00 2001 From: Thurston Dang Date: Mon, 13 Jan 2025 18:38:14 + Subject: [PATCH 1/3] [sanitizer][NFCI] Add Options to LowerAllowCheckPass This

[clang] [Sema] Note member decl when initializer list default constructs member (PR #121854)

2025-01-13 Thread Brian Foley via cfe-commits
https://github.com/bpfoley updated https://github.com/llvm/llvm-project/pull/121854 >From 10acf5fd8346d872e5f3110c03cea944f9062375 Mon Sep 17 00:00:00 2001 From: Brian Foley Date: Thu, 5 Dec 2024 14:35:25 -0800 Subject: [PATCH] [Sema] Note member decl when initializer list default constructs m

[clang] [Sema] Note member decl when initializer list default constructs member (PR #121854)

2025-01-13 Thread Brian Foley via cfe-commits
https://github.com/bpfoley updated https://github.com/llvm/llvm-project/pull/121854 >From 72ffbe4ef6b4f8fe6fa31fef7fd3f5c961495c9f Mon Sep 17 00:00:00 2001 From: Brian Foley Date: Thu, 5 Dec 2024 14:35:25 -0800 Subject: [PATCH] [Sema] Note member decl when initializer list default constructs m

[clang] Fix print module manifest file for macos (PR #122370)

2025-01-13 Thread Ben Boeckel via cfe-commits
mathstuf wrote: Should this be backported to older supported releases as well? (FWIW, I think so.) https://github.com/llvm/llvm-project/pull/122370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[clang] [Clang] FunctionEffects: Correctly navigate through array types in FunctionEffectsRef::get(). (PR #121525)

2025-01-13 Thread via cfe-commits
@@ -8836,13 +8836,22 @@ void FixedPointValueToString(SmallVectorImpl &Str, llvm::APSInt Val, unsigned Scale); inline FunctionEffectsRef FunctionEffectsRef::get(QualType QT) { + const Type *TypePtr = QT.getTypePtr(); while (true) { -QualTyp

[clang] [llvm] [LLVM][Clang][AArch64] Implement AArch64 build attributes (PR #118771)

2025-01-13 Thread via cfe-commits
@@ -7806,6 +7815,261 @@ bool AArch64AsmParser::parseDirectiveSEHSaveAnyReg(SMLoc L, bool Paired, return false; } +bool AArch64AsmParser::parseDirectiveAeabiSubSectionHeader(SMLoc L) { + // Expecting 3 AsmToken::Identifier after '.aeabi_subsection', a name and 2 + // param

[clang] [clang-tools-extra] Remove `StringLiteral` in favor of `StringRef` (PR #122366)

2025-01-13 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > > > Just that the last bit of performance > > > > > > Maybe we're talking about different situations; I may have missed some > > context in the discussion of this PR. I didn't see this as being about the > > last bit of performance. It sounded like this was going to know

[clang-tools-extra] [clang-tidy] Add a release note about unchecked-optional-access smart pointer caching (PR #122290)

2025-01-13 Thread Jan Voung via cfe-commits
@@ -81,10 +81,12 @@ Exception: accessor methods The check assumes *accessor* methods of a class are stable, with a heuristic to determine which methods are accessors. Specifically, parameter-free ``const`` -methods are treated as accessors. Note that this is not guaranteed to

[clang-tools-extra] [clang-tidy] Add a release note about unchecked-optional-access smart pointer caching (PR #122290)

2025-01-13 Thread Jan Voung via cfe-commits
https://github.com/jvoung updated https://github.com/llvm/llvm-project/pull/122290 >From 342ff1a05caa6943fe8a86415f30b433ac30106f Mon Sep 17 00:00:00 2001 From: Jan Voung Date: Thu, 9 Jan 2025 14:10:30 + Subject: [PATCH 1/4] [clang-tidy] Add a release note about unchecked-optional-access s

[clang] [llvm] [Clang] restrict use of attribute names reserved by the C++ standard (PR #106036)

2025-01-13 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > I saw this got updates over break. Did LWG make its decision already? Are you > expecting re-review? I didn't see anything go across my emails about LWG, but > I could definitely have missed it. The LWG issue is still open: https://cplusplus.github.io/LWG/issue4149 but d

[clang] [Clang] disallow the use of asterisks preceding constructor and destructor names (PR #122621)

2025-01-13 Thread via cfe-commits
@@ -96,3 +96,49 @@ namespace PR38286 { template struct C; // expected-note {{non-type declaration found}} template C::~C() {} // expected-error {{identifier 'C' after '~' in destructor name does not name a type}} } + +namespace GH121706 { cor3ntin wrote:

[clang-tools-extra] Add bugprone-sprintf-argument-overlap (PR #114244)

2025-01-13 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,106 @@ +//===--- SprintfArgumentOverlapCheck.cpp - clang-tidy ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang-tools-extra] Add bugprone-sprintf-argument-overlap (PR #114244)

2025-01-13 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,40 @@ +//===--- SprintfArgumentOverlapCheck.h - clang-tidy -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] Add bugprone-sprintf-argument-overlap (PR #114244)

2025-01-13 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/114244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Add bugprone-sprintf-argument-overlap (PR #114244)

2025-01-13 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL edited https://github.com/llvm/llvm-project/pull/114244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] disallow the use of asterisks preceding constructor and destructor names (PR #122621)

2025-01-13 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/122621 >From b2c656afdf99eff52d019b68fcbbc6ce4bbdd7d3 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sun, 12 Jan 2025 00:51:47 +0200 Subject: [PATCH 1/7] [Clang] disallow the use of asterisks preceding constructo

[clang] [llvm] [AArch64] Change feature dependencies of fp8 features (PR #122280)

2025-01-13 Thread Carlos Seo via cfe-commits
ceseo wrote: This is breaking the AArch64 2-stage buildbot: https://lab.llvm.org/buildbot/#/builders/84/builds/1005 https://github.com/llvm/llvm-project/pull/122280 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang-tools-extra] [clang-tidy][clangd] Fixed removeFunctionArgs don't remove comma for use-ranges check (PR #118568)

2025-01-13 Thread Piotr Zegar via cfe-commits
@@ -164,6 +164,33 @@ void UseRangesCheck::registerMatchers(MatchFinder *Finder) { static void removeFunctionArgs(DiagnosticBuilder &Diag, const CallExpr &Call, ArrayRef Indexes, const ASTContext &Ctx) { + auto GetC

[clang-tools-extra] [clang-tidy][clangd] Fixed removeFunctionArgs don't remove comma for use-ranges check (PR #118568)

2025-01-13 Thread Piotr Zegar via cfe-commits
@@ -173,22 +200,27 @@ static void removeFunctionArgs(DiagnosticBuilder &Diag, const CallExpr &Call, for (unsigned Index : Sorted) { const Expr *Arg = Call.getArg(Index); if (Commas[Index]) { - if (Index >= Commas.size()) { -Diag << FixItHint::CreateRemov

[clang] [clang-tools-extra] Remove `StringLiteral` in favor of `StringRef` (PR #122366)

2025-01-13 Thread David Blaikie via cfe-commits
dwblaikie wrote: > > Just that the last bit of performance > > Maybe we're talking about different situations; I may have missed some > context in the discussion of this PR. I didn't see this as being about the > last bit of performance. It sounded like this was going to knowingly > introduce

[clang-tools-extra] [clang-tidy][clangd] Fixed removeFunctionArgs don't remove comma for use-ranges check (PR #118568)

2025-01-13 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL approved this pull request. https://github.com/llvm/llvm-project/pull/118568 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][clangd] Fixed removeFunctionArgs don't remove comma for use-ranges check (PR #118568)

2025-01-13 Thread Piotr Zegar via cfe-commits
@@ -164,6 +164,33 @@ void UseRangesCheck::registerMatchers(MatchFinder *Finder) { static void removeFunctionArgs(DiagnosticBuilder &Diag, const CallExpr &Call, ArrayRef Indexes, const ASTContext &Ctx) { + auto GetC

[clang-tools-extra] [clang-tidy][clangd] Fixed removeFunctionArgs don't remove comma for use-ranges check (PR #118568)

2025-01-13 Thread Piotr Zegar via cfe-commits
@@ -164,6 +164,33 @@ void UseRangesCheck::registerMatchers(MatchFinder *Finder) { static void removeFunctionArgs(DiagnosticBuilder &Diag, const CallExpr &Call, ArrayRef Indexes, const ASTContext &Ctx) { + auto GetC

[clang-tools-extra] [clang-tidy][clangd] Fixed removeFunctionArgs don't remove comma for use-ranges check (PR #118568)

2025-01-13 Thread Piotr Zegar via cfe-commits
@@ -164,6 +164,33 @@ void UseRangesCheck::registerMatchers(MatchFinder *Finder) { static void removeFunctionArgs(DiagnosticBuilder &Diag, const CallExpr &Call, ArrayRef Indexes, const ASTContext &Ctx) { + auto GetC

[clang-tools-extra] [clang-tidy][clangd] Fixed removeFunctionArgs don't remove comma for use-ranges check (PR #118568)

2025-01-13 Thread Piotr Zegar via cfe-commits
@@ -356,6 +356,11 @@ Changes in existing checks ` check to validate ``namespace`` aliases. +- Improved :doc:`modernize-use-ranges PiotrZSL wrote: move to line 307, and best would be to split it into 2 entry, one for boost, and other for modernize https:

[clang-tools-extra] [clang-tidy][clangd] Fixed removeFunctionArgs don't remove comma for use-ranges check (PR #118568)

2025-01-13 Thread Piotr Zegar via cfe-commits
@@ -164,6 +164,33 @@ void UseRangesCheck::registerMatchers(MatchFinder *Finder) { static void removeFunctionArgs(DiagnosticBuilder &Diag, const CallExpr &Call, ArrayRef Indexes, const ASTContext &Ctx) { + auto GetC

[clang] [CodeGen] Migrate away from PointerUnion::dyn_cast (NFC) (PR #122778)

2025-01-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes Note that PointerUnion::dyn_cast has been soft deprecated in PointerUnion.h: // FIXME: Replace the uses of is(), get() and dyn_cast() with //isa, cast and the llvm::dyn_cast Litera

[clang] Add Clang attribute to ensure that fields are initialized explicitly (PR #102040)

2025-01-13 Thread via cfe-commits
higher-performance wrote: Hi @AaronBallman~ would you have a chance to do a final review? :) https://github.com/llvm/llvm-project/pull/102040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[clang] [CodeGen] Migrate away from PointerUnion::dyn_cast (NFC) (PR #122778)

2025-01-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Kazu Hirata (kazutakahirata) Changes Note that PointerUnion::dyn_cast has been soft deprecated in PointerUnion.h: // FIXME: Replace the uses of is(), get() and dyn_cast() with //isa, cast and the llvm::dyn_cast

[clang] [CodeGen] Migrate away from PointerUnion::dyn_cast (NFC) (PR #122778)

2025-01-13 Thread Nikita Popov via cfe-commits
https://github.com/nikic approved this pull request. https://github.com/llvm/llvm-project/pull/122778 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] Migrate away from PointerUnion::dyn_cast (NFC) (PR #122778)

2025-01-13 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/122778 Note that PointerUnion::dyn_cast has been soft deprecated in PointerUnion.h: // FIXME: Replace the uses of is(), get() and dyn_cast() with //isa, cast and the llvm::dyn_cast Literal migration

[clang] [Clang] __has_builtin should return false for aux triple builtins (PR #121839)

2025-01-13 Thread Nick Sarnie via cfe-commits
sarnex wrote: > I believe the conclusion was that we should emit the builtin functions, but > `__has_builtin` should return false for builtins only present in the aux > triple. For the one test that complicates this behavior, I don't think the > use-case is completely well-formed but was hopin

[clang] [Clang] __has_builtin should return false for aux triple builtins (PR #121839)

2025-01-13 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > Sorry, I kind of got lost in the above discussion. Are additional changes > required in Clang to parse builtins unsupported on the current target to make > sure we don't break anything or is only changing the result of > `__has_builtin` acceptable? I believe the conclusion wa

[clang] [Analysis] Migrate away from PointerUnion::dyn_cast (NFC) (PR #122652)

2025-01-13 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/122652 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Migrate away from PointerUnion::dyn_cast (NFC) (PR #122651)

2025-01-13 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/122651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 19c0a6b - [Analysis] Migrate away from PointerUnion::dyn_cast (NFC) (#122652)

2025-01-13 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-01-13T11:38:20-08:00 New Revision: 19c0a6b5eb3a0c0619fccc140740500737fdcd47 URL: https://github.com/llvm/llvm-project/commit/19c0a6b5eb3a0c0619fccc140740500737fdcd47 DIFF: https://github.com/llvm/llvm-project/commit/19c0a6b5eb3a0c0619fccc140740500737fdcd47.diff L

[clang] 8ed9968 - [AST] Migrate away from PointerUnion::dyn_cast (NFC) (#122651)

2025-01-13 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-01-13T11:38:00-08:00 New Revision: 8ed99689038bcc89dca92a4a3a13a4ede166bd7e URL: https://github.com/llvm/llvm-project/commit/8ed99689038bcc89dca92a4a3a13a4ede166bd7e DIFF: https://github.com/llvm/llvm-project/commit/8ed99689038bcc89dca92a4a3a13a4ede166bd7e.diff L

[clang] [Clang] __has_builtin should return false for aux triple builtins (PR #121839)

2025-01-13 Thread Nick Sarnie via cfe-commits
sarnex wrote: Sorry, I kind of got lost in the above discussion. Are additional changes required in Clang to parse builtins unsupported on the current target to make sure we don't break anything or is only changing the result of `__has_builtin` acceptable? https://github.com/llvm/llvm-project

[clang] [llvm] [NFC][BoundsChecking] Address #122576 review comments (PR #122773)

2025-01-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Vitaly Buka (vitalybuka) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/122773.diff 2 Files Affected: - (modified) clang/lib/CodeGen/BackendUtil.cpp (+2-1) - (modified) llvm/lib/Passes/PassBuilder.cpp (+1-1) `

[clang] [llvm] [NFC][BoundsChecking] Address #122576 review comments (PR #122773)

2025-01-13 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka created https://github.com/llvm/llvm-project/pull/122773 None >From b6abdc748225c29544d3c82bfafb5fac3dfd67a7 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Mon, 13 Jan 2025 11:30:49 -0800 Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia

[clang] [NFC] Fixed Diagnostics that assumed only two arguments (PR #122772)

2025-01-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Farzon Lotfi (farzonl) Changes In the below code B varies over the arg list via a loop. However, the diagnostics do not vary with the loop. Fix so that diagnostics can vary with B. --- Full diff: https://github.com/llvm/llvm-project/pull

[clang] [NFC] Fixed Diagnostics that assumed only two arguments (PR #122772)

2025-01-13 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl created https://github.com/llvm/llvm-project/pull/122772 In the below code B varies over the arg list via a loop. However, the diagnostics do not vary with the loop. Fix so that diagnostics can vary with B. >From 9df164c835e7df5bf4ea863bd9735bb0e456cb6c Mon Sep 17 0

[clang] [llvm] [LLVM][Clang][AArch64] Implement AArch64 build attributes (PR #118771)

2025-01-13 Thread via cfe-commits
https://github.com/sivan-shani deleted https://github.com/llvm/llvm-project/pull/118771 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LLVM][Clang][AArch64] Implement AArch64 build attributes (PR #118771)

2025-01-13 Thread via cfe-commits
https://github.com/sivan-shani edited https://github.com/llvm/llvm-project/pull/118771 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   5   >