[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

https://github.com/leijurv edited https://github.com/llvm/llvm-project/pull/118046 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

https://github.com/leijurv edited https://github.com/llvm/llvm-project/pull/118046 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

@@ -2252,6 +2252,25 @@ struct FormatStyle { /// \version 16 BreakBeforeInlineASMColonStyle BreakBeforeInlineASMColon; + /// If ``true``, a line break will be placed before the ``>`` in a multiline + /// template declaration. + /// \code + ///true: + ///templat

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

@@ -2252,6 +2252,25 @@ struct FormatStyle { /// \version 16 BreakBeforeInlineASMColonStyle BreakBeforeInlineASMColon; + /// If ``true``, a line break will be placed before the ``>`` in a multiline + /// template declaration. + /// \code + ///true: + ///templat

[clang] [clang][modules] Separate parsing of modulemaps (PR #119740)

Bigcheese wrote: > I'm happy with the way this split of the code worked out! > > > Currently this has no effect other than slightly changing diagnostics. > > Can you say more about the ordering changes? I understand we can't always > emit diagnostics in source order, but it's helpful for reada

[clang] [clang][modules] Separate parsing of modulemaps (PR #119740)

@@ -3157,25 +2140,18 @@ bool ModuleMap::parseModuleMapFile(FileEntryRef File, bool IsSystem, assert((!Offset || *Offset <= Buffer->getBufferSize()) && "invalid buffer offset"); - // Parse this module map file. - Lexer L(SourceMgr.getLocForStartOfFile(ID), MMapLan

[clang] [clang][modules] Separate parsing of modulemaps (PR #119740)

@@ -0,0 +1,141 @@ +//===- ModuleMapFile.h - Parsing and representation -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang][modules] Separate parsing of modulemaps (PR #119740)

@@ -1575,305 +1494,45 @@ namespace clang { /// 'textual' to match the original intent. llvm::SmallPtrSet UsesRequiresExcludedHack; -/// Consume the current token and return its location. -SourceLocation consumeToken(); - -/// Skip tokens until we reach the

[clang] [clang][modules] Separate parsing of modulemaps (PR #119740)

@@ -0,0 +1,141 @@ +//===- ModuleMapFile.h - Parsing and representation -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

leijurv wrote: I apologize for forgetting `clang-format-check-format` You're right that I had still missed some more cases of `verifyNoChange`. I've changed those now in https://github.com/llvm/llvm-project/pull/118046/commits/130428887e534cc3bfdfeec5846df2fd1e939667. The last two remaining `

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

https://github.com/leijurv updated https://github.com/llvm/llvm-project/pull/118046 >From 1caf823165b16f6701993d586df51d5cdbf0885e Mon Sep 17 00:00:00 2001 From: Leijurv Date: Fri, 29 Nov 2024 21:54:36 -0600 Subject: [PATCH 1/7] [clang-format] Add BreakBeforeTemplateClose option --- clang/doc

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

https://github.com/leijurv updated https://github.com/llvm/llvm-project/pull/118046 >From 1caf823165b16f6701993d586df51d5cdbf0885e Mon Sep 17 00:00:00 2001 From: Leijurv Date: Fri, 29 Nov 2024 21:54:36 -0600 Subject: [PATCH 1/6] [clang-format] Add BreakBeforeTemplateClose option --- clang/doc

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

@@ -2252,6 +2252,25 @@ struct FormatStyle { /// \version 16 BreakBeforeInlineASMColonStyle BreakBeforeInlineASMColon; + /// If ``true``, a line break will be placed before the ``>`` in a multiline + /// template declaration. + /// \code + ///true: + ///templat

[clang] [clang-format] add an option to insert a space only for non-code block empty braces, not for empty parentheses (PR #93634)

https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/93634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fixed a crash when __PRETTY_FUNCTION__ or __FUNCSIG__ (clang-cl) appears in the trailing return type of the lambda (PR #122611)

TilakChad wrote: I've updated the release notes. Thanks for reminding and for the review. :smile: https://github.com/llvm/llvm-project/pull/122611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[clang] [Clang] Fixed a crash when __PRETTY_FUNCTION__ or __FUNCSIG__ (clang-cl) appears in the trailing return type of the lambda (PR #122611)

@@ -774,7 +774,12 @@ std::string PredefinedExpr::ComputeName(PredefinedIdentKind IK, const FunctionDecl *Decl = FD; if (const FunctionDecl* Pattern = FD->getTemplateInstantiationPattern()) Decl = Pattern; -const FunctionType *AFT = Decl->getType()->getAs(); +

[clang] [Clang] Fixed a crash when __PRETTY_FUNCTION__ or __FUNCSIG__ (clang-cl) appears in the trailing return type of the lambda (PR #122611)

https://github.com/TilakChad updated https://github.com/llvm/llvm-project/pull/122611 >From 4e5935f6631f0f0cd828559ec29ed931bc0333d3 Mon Sep 17 00:00:00 2001 From: Tilak Chad Date: Sun, 12 Jan 2025 00:03:32 +0545 Subject: [PATCH 1/2] [Clang] Fixed a crash when __PRETTY_FUNCTION__ or __FUNCSIG_

[clang] [clang-format] add an option to insert a space only for non-code block empty braces, not for empty parentheses (PR #93634)

owenca wrote: > rebased but still required to be tested and fix again See https://github.com/llvm/llvm-project/pull/93634#discussion_r1912374181. https://github.com/llvm/llvm-project/pull/93634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[clang] [clang-format] add an option to insert a space only for non-code block empty braces, not for empty parentheses (PR #93634)

https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/93634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] add an option to insert a space only for non-code block empty braces, not for empty parentheses (PR #93634)

@@ -4493,13 +4493,11 @@ struct FormatStyle { bool SpaceBeforeRangeBasedForLoopColon; /// If ``true``, spaces will be inserted into ``{}``. - /// \code - ///true:false: - ///void f() { } vs. void f() {} - ///

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/118046 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

@@ -6,6 +6,275 @@ TEST_F(FormatTest, WrapsTemplateDeclarationsWithComments) { Style); } +TEST_F(FormatTest, BreakBeforeTemplateClose) { + FormatStyle Style = getGoogleStyle(FormatStyle::LK_Cpp); + // Begin with tests covering the case where there is no constra

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

@@ -2252,6 +2252,25 @@ struct FormatStyle { /// \version 16 BreakBeforeInlineASMColonStyle BreakBeforeInlineASMColon; + /// If ``true``, a line break will be placed before the ``>`` in a multiline + /// template declaration. + /// \code + ///true: + ///templat

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

@@ -2252,6 +2252,25 @@ struct FormatStyle { /// \version 16 BreakBeforeInlineASMColonStyle BreakBeforeInlineASMColon; + /// If ``true``, a line break will be placed before the ``>`` in a multiline + /// template declaration. + /// \code + ///true: + ///templat

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

https://github.com/owenca commented: You can run `ninja clang-format-check-format` to make sure your patch is correctly formatted before pushing. https://github.com/llvm/llvm-project/pull/118046 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [Driver] Avoid repeated map lookups (NFC) (PR #122625)

llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-darwin` running on `doug-worker-3` while building `clang` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/23/builds/6556 Here is the r

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

owenca wrote: > > I think this should be covered by BlockIndent > > My understanding from looking at past PRs to clang-format was that backwards > compatibility was a top requirement. If I changed the behavior of BlockIndent > to put the `>` on the next line, that would change a lot of existin

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff db88071a8b24ad9302659ee88383eea69a732f11 19bc40e7d824804ebcd9839cb2155a704d368e36 --e

[clang] 4f6fabd - [Driver] Avoid repeated map lookups (NFC) (#122625)

Author: Kazu Hirata Date: 2025-01-11T19:49:59-08:00 New Revision: 4f6fabd11ad1a5de8e066adad28c8da4a615f8bb URL: https://github.com/llvm/llvm-project/commit/4f6fabd11ad1a5de8e066adad28c8da4a615f8bb DIFF: https://github.com/llvm/llvm-project/commit/4f6fabd11ad1a5de8e066adad28c8da4a615f8bb.diff L

[clang] [Driver] Avoid repeated map lookups (NFC) (PR #122625)

https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/122625 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Avoid repeated map lookups (NFC) (PR #122625)

https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/122625 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add an option to exclude files not present in the compile database (PR #120348)

wonbinbk wrote: > feel free to ping me when you want to merge it. Thank you! I just reformatted the change to make darker happy. Should be all good to merge now if you don't see anything else need to be changed. https://github.com/llvm/llvm-project/pull/120348 _

[clang-tools-extra] [clang-tidy] Add an option to exclude files not present in the compile database (PR #120348)

https://github.com/wonbinbk updated https://github.com/llvm/llvm-project/pull/120348 >From edcf75fcf810ff08c47b93a0de420a4640e5a6b0 Mon Sep 17 00:00:00 2001 From: wonbinbk Date: Tue, 24 Dec 2024 09:54:05 +1300 Subject: [PATCH 1/2] [clang-tidy] Use raw string for regex pattern --- clang-tools-

[clang] [Clang] Use `-targets=host-x86_64-unknown-linux-gnu` as bundler target (PR #122627)

https://github.com/jhuber6 approved this pull request. Maybe one day we'll be able to get rid of the bundler. https://github.com/llvm/llvm-project/pull/122627 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[clang] [Clang] Use `-targets=host-x86_64-unknown-linux-gnu` as bundler target (PR #122627)

llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Shilei Tian (shiltian) Changes This a prime patch to support generic target when using `--offload-compress`. --- Full diff: https://github.com/llvm/llvm-project/pull/122627.diff 7 Files Affected: - (modified) clang/lib/Driver/Too

[clang] [Clang] Use `-targets=host-x86_64-unknown-linux-gnu` as bundler target (PR #122627)

shiltian wrote: * **#122627** https://app.graphite.dev/github/pr/llvm/llvm-project/122627?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/122

[clang] [Clang] Use `-targets=host-x86_64-unknown-linux-gnu` as bundler target (PR #122627)

https://github.com/shiltian created https://github.com/llvm/llvm-project/pull/122627 This a prime patch to support generic target when using `--offload-compress`. >From 95332e05f381f7e80cd1c57420db0c56cf8aedcf Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Sat, 11 Jan 2025 21:24:53 -0500 Sub

[clang] [Driver] Avoid repeated map lookups (NFC) (PR #122625)

llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-driver Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/122625.diff 1 Files Affected: - (modified) clang/lib/Driver/Driver.cpp (+2-2) ``diff diff --git

[clang] [Driver] Avoid repeated map lookups (NFC) (PR #122625)

https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/122625 None >From b9a6a99e421170fbc1fb8c6641a83d21dfa0076c Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sat, 11 Jan 2025 17:53:36 -0800 Subject: [PATCH] [Driver] Avoid repeated map lookups (NFC) --- clang

[clang-tools-extra] [clang-tidy] Add `performance-explicit-move-constructor` check (PR #122599)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff ac604b2fa6ff0344a555954069721c0db7b874f9 828461273ea7ac1d38a4d3fe1ff8b810f80472e9 --e

[clang] [Driver] Warn when using msan on Android (PR #122540)

https://github.com/thurstond approved this pull request. https://github.com/llvm/llvm-project/pull/122540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Reapply CWG2369 "Ordering between constraints and substitution" (PR #122423)

zyn0217 wrote: @mysterymath @zmodem Can you both test this patch on Windows to confirm if it resolves issues you've reported? We'd greatly appreciate it! https://github.com/llvm/llvm-project/pull/122423 ___ cfe-commits mailing list cfe-commits@lists.

[clang] [Clang] disallow the use of asterisks preceding constructor and destructor names (PR #122621)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Oleksandr T. (a-tarasyuk) Changes Fixes #121706 --- Full diff: https://github.com/llvm/llvm-project/pull/122621.diff 5 Files Affected: - (modified) clang/docs/ReleaseNotes.rst (+1) - (modified) clang/include/clang/Basic/DiagnosticSemaK

[clang] [Clang] disallow the use of asterisks preceding constructor and destructor names (PR #122621)

https://github.com/a-tarasyuk created https://github.com/llvm/llvm-project/pull/122621 Fixes #121706 >From b2c656afdf99eff52d019b68fcbbc6ce4bbdd7d3 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sun, 12 Jan 2025 00:51:47 +0200 Subject: [PATCH] [Clang] disallow the use of asterisks preceding

[clang-tools-extra] [clang-tidy][doc] combine the clang-tidy itself's change together in release note (PR #122594)

llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-aarch64-linux-bootstrap-asan` running on `sanitizer-buildbot7` while building `clang-tools-extra` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/24/builds/4104 Here i

[clang-tools-extra] [clang-tidy][doc] combine the clang-tidy itself's change together in release note (PR #122594)

llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-aarch64-sve-vls` running on `linaro-g3-04` while building `clang-tools-extra` at step 6 "build stage 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/143/builds/4696 Here is the relevant pie

[clang-tools-extra] 2c7829e - [clang-tidy][doc] combine the clang-tidy itself's change together in release note (#122594)

Author: Congcong Cai Date: 2025-01-12T06:48:46+08:00 New Revision: 2c7829e676dfd6a33f7c9955ea930f51aca37e20 URL: https://github.com/llvm/llvm-project/commit/2c7829e676dfd6a33f7c9955ea930f51aca37e20 DIFF: https://github.com/llvm/llvm-project/commit/2c7829e676dfd6a33f7c9955ea930f51aca37e20.diff

[clang-tools-extra] [clang-tidy][doc] combine the clang-tidy itself's change together in release note (PR #122594)

https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/122594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Warn when using msan on Android (PR #122540)

https://github.com/Sharjeel-Khan updated https://github.com/llvm/llvm-project/pull/122540 >From c8d2c210a98fe0c96d758d538d50fcc0ca61a9ff Mon Sep 17 00:00:00 2001 From: Sharjeel Khan Date: Fri, 10 Jan 2025 20:07:52 + Subject: [PATCH 1/3] Warn when using msan on Android Msan is not supported

[clang-tools-extra] [clang-tidy][doc] combine the clang-tidy itself's change together in release note (PR #122594)

https://github.com/PiotrZSL approved this pull request. https://github.com/llvm/llvm-project/pull/122594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Avoid repeated hash lookups (NFC) (PR #122588)

https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/122588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a56eb7c - [Sema] Avoid repeated hash lookups (NFC) (#122588)

Author: Kazu Hirata Date: 2025-01-11T13:15:50-08:00 New Revision: a56eb7c9986456ae4b492fff79c3cf18d0ef8ad3 URL: https://github.com/llvm/llvm-project/commit/a56eb7c9986456ae4b492fff79c3cf18d0ef8ad3 DIFF: https://github.com/llvm/llvm-project/commit/a56eb7c9986456ae4b492fff79c3cf18d0ef8ad3.diff L

[clang] [lldb] [clang][DebugInfo] Expand detection of structured bindings to account for std::get free function (PR #122265)

cor3ntin wrote: > > Did you try to modify `IgnoreUnlessSpelledInSource` to support CallExpr? > > Yea I was thinking about it initially. But I wasn't sure what that would look > like tbh. IIUC `IgnoreImplicitMemberCallSingleStep` will unwrap > `CXXMemberCallExpr` into the underlying `MemberExpr

[clang-tools-extra] [clang-tidy] Add `performance-explicit-move-constructor` check (PR #122599)

carlosgalvezp wrote: This check sounds a bit strange. Is this issue common in real-world projects, do we have some data? It's the first time I've heard of it. Why would people deviate from the standard signature for move constructors? We could perhaps consider making this check a bit more gene

[clang] Added .cpp extension to some test files in SemaCXX (PR #122613)

https://github.com/2LoS closed https://github.com/llvm/llvm-project/pull/122613 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Warn when using msan on Android (PR #122540)

thurstond wrote: > these checks into Toolchains/Linux.cpp so it triggers that code: IMO adding the Android msan check into Toolchains/Linux.cpp would be cleaner because it's: 1) only a 1 or 2 line change (compared with the current ~10 lines) 2) this file handles all the broad compatibility chec

[clang] Added .cpp extension to some test files in SemaCXX (PR #122613)

llvmbot wrote: @llvm/pr-subscribers-clang Author: LoS (2LoS) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/122613.diff 3 Files Affected: - (renamed) clang/test/SemaCXX/warn-inconsistent-missing-destructor-override.cpp () - (renamed) clang/test/SemaCXX/warn-suggest

[clang] Added .cpp extension to some test files in SemaCXX (PR #122613)

https://github.com/2LoS created https://github.com/llvm/llvm-project/pull/122613 None >From 81daf0e300e66a36df321c215019805f0617d09b Mon Sep 17 00:00:00 2001 From: LoS Date: Sat, 11 Jan 2025 21:07:17 +0100 Subject: [PATCH] Added .cpp extension to some test files in SemaCXX --- ...ride => warn

[clang] [Clang] Fixed a crash when __PRETTY_FUNCTION__ or __FUNCSIG__ (clang-cl) appears in the trailing return type of the lambda (PR #122611)

https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/122611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fixed a crash when __PRETTY_FUNCTION__ or __FUNCSIG__ (clang-cl) appears in the trailing return type of the lambda (PR #122611)

@@ -774,7 +774,12 @@ std::string PredefinedExpr::ComputeName(PredefinedIdentKind IK, const FunctionDecl *Decl = FD; if (const FunctionDecl* Pattern = FD->getTemplateInstantiationPattern()) Decl = Pattern; -const FunctionType *AFT = Decl->getType()->getAs(); +

[clang] [Clang] Fixed a crash when __PRETTY_FUNCTION__ or __FUNCSIG__ (clang-cl) appears in the trailing return type of the lambda (PR #122611)

https://github.com/cor3ntin commented: Thanks for this PR. The approach looks sensible to me Can you add a release note in `clang/docs/ReleaseNotes.rst` ? Thanks https://github.com/llvm/llvm-project/pull/122611 ___ cfe-commits mailing list cfe-commits

[clang] [Clang] Fixed a crash when __PRETTY_FUNCTION__ or __FUNCSIG__ (clang-cl) appears in the trailing return type of the lambda (PR #122611)

https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/122611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Reapply CWG2369 "Ordering between constraints and substitution" (PR #122423)

cor3ntin wrote: I've confirmed with @zyn0217 that this iteration of the patch fixes the bug encountered by the chromium team wherein we tried to mangle lambdas with a deduced return type during constraint satisfaction - which caused failure on windows as mangling of lambda requires the enclosi

[clang] [Clang] Fixed a crash when __PRETTY_FUNCTION__ or __FUNCSIG__ (clang-cl) appears in the trailing return type of the lambda (PR #122611)

llvmbot wrote: @llvm/pr-subscribers-clang Author: TilakChad (TilakChad) Changes The (function) type of the lambda function is null while parsing trailing return type. The type is filled-in when the lambda body is entered. So, resolving `__PRETTY_FUNCTION__` before the lambda body is ente

[clang] [Clang] Fixed a crash when __PRETTY_FUNCTION__ or __FUNCSIG__ (clang-cl) appears in the trailing return type of the lambda (PR #122611)

https://github.com/TilakChad created https://github.com/llvm/llvm-project/pull/122611 The (function) type of the lambda function is null while parsing trailing return type. The type is filled-in when the lambda body is entered. So, resolving `__PRETTY_FUNCTION__` before the lambda body is ente

[clang] [Clang] Reapply CWG2369 "Ordering between constraints and substitution" (PR #122423)

@@ -5284,8 +5284,22 @@ void Sema::InstantiateFunctionDefinition(SourceLocation PointOfInstantiation, savedContext.pop(); } - DeclGroupRef DG(Function); - Consumer.HandleTopLevelDecl(DG); + // With CWG2369, we substitute constraints before instantiating the associate

[clang] [Driver] Warn when using msan on Android (PR #122540)

Sharjeel-Khan wrote: I can do it by moving these checks into Toolchains/Linux.cpp so it triggers that code: https://github.com/llvm/llvm-project/blob/2914ba1c01fdc496082197abf7cd35e2af526634/clang/lib/Driver/ToolChains/Linux.cpp#L809-L865. Is this a good solution? https://github.com/llvm/llvm-

[clang] [libcxx] Fixed test file extensions (PR #122609)

https://github.com/2LoS closed https://github.com/llvm/llvm-project/pull/122609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] Fixed test file extensions (PR #122609)

llvmbot wrote: @llvm/pr-subscribers-clang Author: LoS (2LoS) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/122609.diff 3 Files Affected: - (renamed) clang/test/SemaCXX/warn-inconsistent-missing-destructor-override.cpp () - (renamed) clang/test/SemaCXX/warn-suggest

[clang] [libcxx] Fixed test file extensions (PR #122609)

https://github.com/2LoS created https://github.com/llvm/llvm-project/pull/122609 None >From ff12d49f0633678633d9e239db7424c60e94cb5d Mon Sep 17 00:00:00 2001 From: LoS Date: Thu, 9 Jan 2025 18:46:36 +0100 Subject: [PATCH 1/3] Removed duplicated _LIBCPP_HIDE_FROM_ABI in libcxx --- .../include/

[clang-tools-extra] [clang-tidy] Add `performance-explicit-move-constructor` check (PR #122599)

llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: dodicidodici (dodicidodici) Changes This patch adds a check that reports classes that define an explicit move constructor and a copy constructor. Closes #121707 --- Full diff: https://github.com/llvm/llvm-project/pull/122599.diff

[clang-tools-extra] [clang-tidy] Add `performance-explicit-move-constructor` check (PR #122599)

llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: dodicidodici (dodicidodici) Changes This patch adds a check that reports classes that define an explicit move constructor and a copy constructor. Closes #121707 --- Full diff: https://github.com/llvm/llvm-project/pull/122599.

[clang-tools-extra] [clang-tidy] Add `performance-explicit-move-constructor` check (PR #122599)

https://github.com/dodicidodici ready_for_review https://github.com/llvm/llvm-project/pull/122599 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Support .clangd command line modifications for C++ modules (PR #122606)

llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Petr Polezhaev (petr-polezhaev) Changes Tunnels `Manger` object into the `ScanningAllProjectModules` so it can be used to perform necessary command-line modifications (which also adds `--resources` path previously added there

[clang-tools-extra] [clangd] Support .clangd command line modifications for C++ modules (PR #122606)

github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang-tools-extra] [clangd] Support .clangd command line modifications for C++ modules (PR #122606)

https://github.com/petr-polezhaev created https://github.com/llvm/llvm-project/pull/122606 Tunnels `Manger` object into the `ScanningAllProjectModules` so it can be used to perform necessary command-line modifications (which also adds `--resources` path previously added there explicitly). This

[clang] [Clang] Add release note for pointer overflow optimization change (PR #122462)

https://github.com/zmodem approved this pull request. The current version lgtm by the way Maybe we should also put a blurb in the main llvm release notes and link to this one. https://github.com/llvm/llvm-project/pull/122462 ___ cfe-commits mailing l

[clang-tools-extra] [clang-tidy] Add an option to exclude files not present in the compile database (PR #120348)

github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 212cba0ef37dd3b2a253c063240370de42fc67c1...834789678bf967e79c29041452bc96832592de36 clang

[clang-tools-extra] [clang-tidy] Add an option to exclude files not present in the compile database (PR #120348)

HerrCai0907 wrote: feel free to ping me when you want to merge it. https://github.com/llvm/llvm-project/pull/120348 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [libcxx] [llvm] [libc++][ranges] P2542R8: Implement `views::concat` (PR #120920)

https://github.com/frederick-vs-ja edited https://github.com/llvm/llvm-project/pull/120920 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add `performance-explicit-move-constructor` check (PR #122599)

https://github.com/dodicidodici updated https://github.com/llvm/llvm-project/pull/122599 >From 2f1627ee62c041d98cbc51b08aebf2dd2dbe5455 Mon Sep 17 00:00:00 2001 From: dodicidodici Date: Fri, 10 Jan 2025 19:05:09 +0100 Subject: [PATCH 1/6] add `performance-explicit-move-constructor` check ---

[clang-tools-extra] [clang-tidy] Add `performance-explicit-move-constructor` check (PR #122599)

github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang-tools-extra] [clang-tidy] Add `performance-explicit-move-constructor` check (PR #122599)

https://github.com/dodicidodici created https://github.com/llvm/llvm-project/pull/122599 This patch adds a check that reports classes that define an explicit move constructor and a copy constructor. Closes #121707 >From 2f1627ee62c041d98cbc51b08aebf2dd2dbe5455 Mon Sep 17 00:00:00 2001 From: d

[clang-tools-extra] [clang-tidy][doc] fix incorrectly code snippet in release note (PR #122595)

llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Congcong Cai (HerrCai0907) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/122595.diff 1 Files Affected: - (modified) clang-tools-extra/docs/ReleaseNotes.rst (+3-3) ``diff diff --git a/clang-tool

[clang-tools-extra] [clang-tidy][doc] fix incorrectly code snippet in release note (PR #122595)

https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/122595 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 32351b5 - [clang-tidy][doc] fix incorrectly code snippet in release note (#122595)

Author: Congcong Cai Date: 2025-01-11T23:26:34+08:00 New Revision: 32351b5450119799ef33da92e87149467c64 URL: https://github.com/llvm/llvm-project/commit/32351b5450119799ef33da92e87149467c64 DIFF: https://github.com/llvm/llvm-project/commit/32351b5450119799ef33da92e87149467c64.diff

[clang-tools-extra] [clang-tidy][doc] fix incorrectly code snippet in release note (PR #122595)

https://github.com/HerrCai0907 created https://github.com/llvm/llvm-project/pull/122595 None >From 37b633e8eb393fac5d02e3dd551e2801d5b8d337 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Sat, 11 Jan 2025 23:25:47 +0800 Subject: [PATCH] [clang-tidy][doc] fix incorrectly code snippet in relea

[clang-tools-extra] [clang-tidy][doc] combine the clang-tidy itself's change together in release note (PR #122594)

llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Congcong Cai (HerrCai0907) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/122594.diff

[clang-tools-extra] [clang-tidy] fix incorrect configuration file path resolving when file paths contain `..` (PR #121323)

@@ -117,6 +117,9 @@ Improvements to clang-tidy - Improved :program:`clang-tidy` by accepting parameters file in command line. +- Improved :program:`clang-tidy` by fixing incorrect configuration file path HerrCai0907 wrote: #122594 https://github.com/llvm/ll

[clang-tools-extra] [clang-tidy][doc] combine the clang-tidy itself's change together in release note (PR #122594)

https://github.com/HerrCai0907 created https://github.com/llvm/llvm-project/pull/122594 https://github.com/user-attachments/assets/25433743-2c19-422a-93c5-3edfc1bb7a3f"; /> >From 3f9b3ccf94deb98cdedc9928d409a102f5b0e435 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Sat, 11 Jan 2025 23:21

[clang] [clang-format] add an option to insert a space only for non-code block empty braces, not for empty parentheses (PR #93634)

khei4 wrote: rebased but still required to be tested and fix again https://github.com/llvm/llvm-project/pull/93634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] add an option to insert a space only for non-code block empty braces, not for empty parentheses (PR #93634)

https://github.com/khei4 converted_to_draft https://github.com/llvm/llvm-project/pull/93634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] add an option to insert a space only for non-code block empty braces, not for empty parentheses (PR #93634)

https://github.com/khei4 updated https://github.com/llvm/llvm-project/pull/93634 >From 079f6d29c1091b89e949d674b1983bb6e08155df Mon Sep 17 00:00:00 2001 From: Kohei Asano Date: Mon, 3 Jun 2024 09:15:44 +0900 Subject: [PATCH] [clang-format] add an option to insert a space only for empty braces

[clang] [Clang] Reapply CWG2369 "Ordering between constraints and substitution" (PR #122423)

https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/122423 >From d40a80859eafe96bdc99957db2aebb70db407e67 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Fri, 10 Jan 2025 09:46:24 +0800 Subject: [PATCH 1/7] Reapply "[Clang] Implement CWG2369 "Ordering between constra

[clang] [Clang] Reapply CWG2369 "Ordering between constraints and substitution" (PR #122423)

https://github.com/zyn0217 ready_for_review https://github.com/llvm/llvm-project/pull/122423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 0249554 - [clang-tidy] fix incorrect configuration file path resolving when file paths contain `..` (#121323)

Author: Congcong Cai Date: 2025-01-11T22:51:47+08:00 New Revision: 0249554ee1ac49e6f1d93fa78a55971fc706f635 URL: https://github.com/llvm/llvm-project/commit/0249554ee1ac49e6f1d93fa78a55971fc706f635 DIFF: https://github.com/llvm/llvm-project/commit/0249554ee1ac49e6f1d93fa78a55971fc706f635.diff

[clang-tools-extra] [clang-tidy] fix incorrect configuration file path resolving when file paths contain `..` (PR #121323)

https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/121323 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] fix incorrect configuration file path resolving when file paths contain `..` (PR #121323)

https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/121323 >From 896db4495ff2c29c2e623d92e004ef64f49c8dd0 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Mon, 30 Dec 2024 16:38:29 +0800 Subject: [PATCH 1/2] [clang-tidy] fix incorrect configuration file path resol

[clang-tools-extra] [clang-tidy] fix incorrect configuration file path resolving when file paths contain `..` (PR #121323)

@@ -117,6 +117,11 @@ Improvements to clang-tidy - Improved :program:`run-clang-tidy.py` script. Fixed minor shutdown noise happening on certain platforms when interrupting the script. +- Improved :program:`clang-tidy` by accepting parameters file in command line. + -

[clang-tools-extra] [clang-tidy] fix incorrect configuration file path resolving when file paths contain `..` (PR #121323)

https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/121323 >From 896db4495ff2c29c2e623d92e004ef64f49c8dd0 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Mon, 30 Dec 2024 16:38:29 +0800 Subject: [PATCH] [clang-tidy] fix incorrect configuration file path resolving

  1   2   >