[clang] [Clang] Don't form a type constraint if the concept is invalid (PR #122065)

2025-01-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules @llvm/pr-subscribers-clang Author: Younan Zhang (zyn0217) Changes After 0dedd6fe1 and 03229e7c0, invalid concept declarations might lack expressions for evaluation and normalization. This could make it crash in certain scenarios, apart fr

[clang] [Clang] Don't form a type constraint if the concept is invalid (PR #122065)

2025-01-07 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 created https://github.com/llvm/llvm-project/pull/122065 After 0dedd6fe1 and 03229e7c0, invalid concept declarations might lack expressions for evaluation and normalization. This could make it crash in certain scenarios, apart from the one of evaluation concepts show

[clang] [Clang][ASTMatcher] Extend `hasDependentName` to match DependentNameType name (PR #121975)

2025-01-07 Thread Nathan Ridge via cfe-commits
@@ -2251,6 +2251,14 @@ TEST_P(ASTMatchersTest, HasDependentName_DependentScopeDeclRefExpr) { EXPECT_TRUE(matches("template struct S { static T foo(); };" "template void x() { S::foo(); }", dependentScopeDeclRefExpr(hasDependentNa

[clang] [Clang][ASTMatcher] Extend `hasDependentName` to match DependentNameType name (PR #121975)

2025-01-07 Thread Nathan Ridge via cfe-commits
@@ -2251,6 +2251,14 @@ TEST_P(ASTMatchersTest, HasDependentName_DependentScopeDeclRefExpr) { EXPECT_TRUE(matches("template struct S { static T foo(); };" "template void x() { S::foo(); }", dependentScopeDeclRefExpr(hasDependentNa

[clang] [Clang][ASTMatcher] Extend `hasDependentName` to match DependentNameType name (PR #121975)

2025-01-07 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 commented: Thanks! Nice to see we have a `POLYMORPHIC_MATCHER` utility that makes this straightforward to implement. https://github.com/llvm/llvm-project/pull/121975 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang] [Clang][ASTMatcher] Extend `hasDependentName` to match DependentNameType name (PR #121975)

2025-01-07 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 edited https://github.com/llvm/llvm-project/pull/121975 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [libcxx] [llvm] [libc++][ranges] P2542R8: Implement `views::concat` (PR #120920)

2025-01-07 Thread Nhat Nguyen via cfe-commits
https://github.com/changkhothuychung edited https://github.com/llvm/llvm-project/pull/120920 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Coverage] Introduce `getBranchCounterPair()`. NFC. (PR #112702)

2025-01-07 Thread NAKAMURA Takumi via cfe-commits
@@ -939,8 +939,17 @@ struct CounterCoverageMappingBuilder Counter Skipped; }; - BranchCounterPair getBranchCounterPair(const Stmt *S, Counter ParentCnt) { + BranchCounterPair + getBranchCounterPair(const Stmt *S, Counter ParentCnt, + std::optiona

[clang] [sanitizer] Parse weighted sanitizer args and -fno-sanitize-top-hot (PR #121619)

2025-01-07 Thread Thurston Dang via cfe-commits
@@ -1154,3 +1154,58 @@ // RUN: not %clang --target=x86_64-linux-gnu -fsanitize=realtime,undefined %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-REALTIME-UBSAN // CHECK-REALTIME-UBSAN: error: invalid argument '-fsanitize=realtime' not allowed with '-fsanitize=undefined' +

[clang] Fix extra parenthesis in diagnostic (PR #122055)

2025-01-07 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 approved this pull request. Good catch, thanks! https://github.com/llvm/llvm-project/pull/122055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Coverage] Introduce `getBranchCounterPair()`. NFC. (PR #112702)

2025-01-07 Thread NAKAMURA Takumi via cfe-commits
@@ -938,6 +938,37 @@ struct CounterCoverageMappingBuilder return Counter::getCounter(CounterMap[S]); } + struct BranchCounterPair { +Counter Executed; +Counter Skipped; + }; + + BranchCounterPair getBranchCounterPair(const Stmt *S, Counter ParentCnt) { +Co

[clang] [Coverage] Introduce `getBranchCounterPair()`. NFC. (PR #112702)

2025-01-07 Thread NAKAMURA Takumi via cfe-commits
@@ -1592,6 +1605,13 @@ struct CounterCoverageMappingBuilder llvm::EnableSingleByteCoverage ? getRegionCounter(S->getCond()) : addCounters(ParentCount, BackedgeCount, BC.ContinueCount); +auto [ExecCount, ExitCount] = +(llvm::EnableSing

[clang] [Coverage] Introduce `getBranchCounterPair()`. NFC. (PR #112702)

2025-01-07 Thread Jessica Paquette via cfe-commits
@@ -939,8 +939,17 @@ struct CounterCoverageMappingBuilder Counter Skipped; }; - BranchCounterPair getBranchCounterPair(const Stmt *S, Counter ParentCnt) { + BranchCounterPair + getBranchCounterPair(const Stmt *S, Counter ParentCnt, + std::optiona

[clang] [Coverage] Introduce `getBranchCounterPair()`. NFC. (PR #112702)

2025-01-07 Thread NAKAMURA Takumi via cfe-commits
@@ -939,8 +939,17 @@ struct CounterCoverageMappingBuilder Counter Skipped; }; - BranchCounterPair getBranchCounterPair(const Stmt *S, Counter ParentCnt) { + BranchCounterPair + getBranchCounterPair(const Stmt *S, Counter ParentCnt, + std::optiona

[clang] [Coverage] Introduce `getBranchCounterPair()`. NFC. (PR #112702)

2025-01-07 Thread NAKAMURA Takumi via cfe-commits
@@ -938,6 +938,37 @@ struct CounterCoverageMappingBuilder return Counter::getCounter(CounterMap[S]); } + struct BranchCounterPair { chapuni wrote: I wrote similar comments (from codegen side) in #112724 and I wanted to leave this side self-descriptive

[clang] [Coverage] Introduce `getBranchCounterPair()`. NFC. (PR #112702)

2025-01-07 Thread NAKAMURA Takumi via cfe-commits
@@ -939,8 +939,17 @@ struct CounterCoverageMappingBuilder Counter Skipped; }; - BranchCounterPair getBranchCounterPair(const Stmt *S, Counter ParentCnt) { + BranchCounterPair + getBranchCounterPair(const Stmt *S, Counter ParentCnt, + std::optiona

[clang] [Coverage] Introduce `getBranchCounterPair()`. NFC. (PR #112702)

2025-01-07 Thread NAKAMURA Takumi via cfe-commits
@@ -938,6 +938,37 @@ struct CounterCoverageMappingBuilder return Counter::getCounter(CounterMap[S]); } + struct BranchCounterPair { +Counter Executed; chapuni wrote: I still wonder which pair of names would fit best. I adopted "Exec" from `BinOp`

[clang] [clang-tools-extra] [libcxx] [llvm] [libc++] implement views::concat (PR #120920)

2025-01-07 Thread A. Jiang via cfe-commits
@@ -0,0 +1,637 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License

[clang] [clang-tools-extra] [libcxx] [llvm] [libc++] implement views::concat (PR #120920)

2025-01-07 Thread A. Jiang via cfe-commits
@@ -0,0 +1,637 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License

[clang] [clang-tools-extra] [libcxx] [llvm] [libc++] implement views::concat (PR #120920)

2025-01-07 Thread A. Jiang via cfe-commits
@@ -0,0 +1,71 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang] [clang-tools-extra] [libcxx] [llvm] [libc++] implement views::concat (PR #120920)

2025-01-07 Thread A. Jiang via cfe-commits
@@ -0,0 +1,38 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang] [clang-tools-extra] [libcxx] [llvm] [libc++] implement views::concat (PR #120920)

2025-01-07 Thread A. Jiang via cfe-commits
@@ -0,0 +1,637 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License

[clang] [clang-tools-extra] [libcxx] [llvm] [libc++] implement views::concat (PR #120920)

2025-01-07 Thread A. Jiang via cfe-commits
@@ -0,0 +1,637 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License

[clang] [clang-tools-extra] [libcxx] [llvm] [libc++] implement views::concat (PR #120920)

2025-01-07 Thread A. Jiang via cfe-commits
@@ -0,0 +1,79 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang] [clang-tools-extra] [libcxx] [llvm] [libc++] implement views::concat (PR #120920)

2025-01-07 Thread A. Jiang via cfe-commits
https://github.com/frederick-vs-ja requested changes to this pull request. https://github.com/llvm/llvm-project/pull/120920 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [libcxx] [llvm] [libc++] implement views::concat (PR #120920)

2025-01-07 Thread A. Jiang via cfe-commits
@@ -0,0 +1,637 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License

[clang] [clang-tools-extra] [libcxx] [llvm] [libc++] implement views::concat (PR #120920)

2025-01-07 Thread Nhat Nguyen via cfe-commits
https://github.com/changkhothuychung updated https://github.com/llvm/llvm-project/pull/120920 error: too big or took too long to generate ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang] Fix extra parenthesis in diagnostic (PR #122055)

2025-01-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Hubert Tong (hubert-reinterpretcast) Changes Following https://github.com/llvm/llvm-project/pull/120380, `err_pack_expansion_length_conflict` has one close paren too many. Remove the extra parenthesis. --- Full diff: https://github.com/ll

[clang] Fix extra parenthesis in diagnostic (PR #122055)

2025-01-07 Thread Hubert Tong via cfe-commits
https://github.com/hubert-reinterpretcast created https://github.com/llvm/llvm-project/pull/122055 Following https://github.com/llvm/llvm-project/pull/120380, `err_pack_expansion_length_conflict` has one close paren too many. Remove the extra parenthesis. >From ecff595a1e753a1c897a0f48e306bfe3

[clang] [clang] Emit @llvm.assume when we know the streaming mode of the function (PR #121917)

2025-01-07 Thread Nicholas Guy via cfe-commits
https://github.com/NickGuy-Arm edited https://github.com/llvm/llvm-project/pull/121917 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #122035)

2025-01-07 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-s390x-linux` running on `systemz-1` while building `clang,llvm` at step 6 "test-openmp". Full details are available at: https://lab.llvm.org/buildbot/#/builders/88/builds/6515 Here is the relevant piece of the build l

[clang] [sanitizer] Parse weighted sanitizer args and -fno-sanitize-top-hot (PR #121619)

2025-01-07 Thread Fangrui Song via cfe-commits
@@ -1154,3 +1154,58 @@ // RUN: not %clang --target=x86_64-linux-gnu -fsanitize=realtime,undefined %s -### 2>&1 | FileCheck %s --check-prefix=CHECK-REALTIME-UBSAN // CHECK-REALTIME-UBSAN: error: invalid argument '-fsanitize=realtime' not allowed with '-fsanitize=undefined' +

[clang] 61b806f - [clang] assign the correct parent in update to ParentMap

2025-01-07 Thread Sameer Sahasrabuddhe via cfe-commits
Author: Sameer Sahasrabuddhe Date: 2025-01-08T12:03:25+05:30 New Revision: 61b806f43b2d6b3673a8f91393a28c98521472a8 URL: https://github.com/llvm/llvm-project/commit/61b806f43b2d6b3673a8f91393a28c98521472a8 DIFF: https://github.com/llvm/llvm-project/commit/61b806f43b2d6b3673a8f91393a28c98521472a

[clang] [clang] [NFC] explicitly check if ParentMap contains key (PR #121736)

2025-01-07 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux-bootstrap-asan` running on `sanitizer-buildbot1` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/52/builds/5076 Here is the relevan

[clang] [clang] Emit @llvm.assume before streaming_compatible functions when the streaming mode is known (PR #121917)

2025-01-07 Thread Nicholas Guy via cfe-commits
https://github.com/NickGuy-Arm edited https://github.com/llvm/llvm-project/pull/121917 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Emit @llvm.assume before streaming_compatible functions when the streaming mode is known (PR #121917)

2025-01-07 Thread Nicholas Guy via cfe-commits
https://github.com/NickGuy-Arm edited https://github.com/llvm/llvm-project/pull/121917 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #122035)

2025-01-07 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-remote-linux-ubuntu` running on `as-builder-9` while building `clang,llvm` at step 16 "test-check-lldb-api". Full details are available at: https://lab.llvm.org/buildbot/#/builders/195/builds/3169 Here is the relevant

[clang] Reapply "[Clang] Improve diagnostics for expansion length mismatch" (PR #121044)

2025-01-07 Thread Younan Zhang via cfe-commits
zyn0217 wrote: (I plan to merge this after the branch 20 cut to avoid any potential revert churn. So it will stay in draft for now) https://github.com/llvm/llvm-project/pull/121044 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[clang] [clang] Emit @llvm.assume when we know the streaming mode of the function (PR #121917)

2025-01-07 Thread Nicholas Guy via cfe-commits
https://github.com/NickGuy-Arm edited https://github.com/llvm/llvm-project/pull/121917 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Coverage] Introduce `getBranchCounterPair()`. NFC. (PR #112702)

2025-01-07 Thread Jessica Paquette via cfe-commits
@@ -939,8 +939,17 @@ struct CounterCoverageMappingBuilder Counter Skipped; }; - BranchCounterPair getBranchCounterPair(const Stmt *S, Counter ParentCnt) { + BranchCounterPair + getBranchCounterPair(const Stmt *S, Counter ParentCnt, + std::optiona

[clang] [Coverage] Introduce `getBranchCounterPair()`. NFC. (PR #112702)

2025-01-07 Thread Jessica Paquette via cfe-commits
@@ -939,8 +939,17 @@ struct CounterCoverageMappingBuilder Counter Skipped; }; - BranchCounterPair getBranchCounterPair(const Stmt *S, Counter ParentCnt) { + BranchCounterPair + getBranchCounterPair(const Stmt *S, Counter ParentCnt, + std::optiona

[clang] [clang] Emit @llvm.assume when we know the streaming mode of the function (PR #121917)

2025-01-07 Thread Nicholas Guy via cfe-commits
NickGuy-Arm wrote: > I really don't see why we'd want to implement the optimization this way; > can't we just add an instcombine for calls to > `llvm.aarch64.sme.in.streaming.mode`? If what this patch initially did was our actual goal, then that would be an option. However what we want to ach

[clang] [clang] Emit @llvm.assume when we know the streaming mode of the function (PR #121917)

2025-01-07 Thread Nicholas Guy via cfe-commits
https://github.com/NickGuy-Arm updated https://github.com/llvm/llvm-project/pull/121917 >From 27e9773135d1171c931aaa6b3f8c5f954b658969 Mon Sep 17 00:00:00 2001 From: Nick Guy Date: Tue, 7 Jan 2025 11:09:18 + Subject: [PATCH 1/3] [clang] Emit @llvm.assume when we know the streaming mode of

[clang] [clang-cl] [Sema] Support MSVC non-const lvalue to user-defined temporary reference (PR #99833)

2025-01-07 Thread Max Winkler via cfe-commits
https://github.com/MaxEW707 updated https://github.com/llvm/llvm-project/pull/99833 >From 0a705b1a8e9673cd5e803ffe392dacfa0f06c40f Mon Sep 17 00:00:00 2001 From: MaxEW707 Date: Fri, 21 Jun 2024 20:37:40 -0700 Subject: [PATCH 01/27] Support MSVC lvalue to temporary reference binding --- clang/

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #122035)

2025-01-07 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `fuchsia-x86_64-linux` running on `fuchsia-debian-64-us-central1-a-1` while building `clang,llvm` at step 4 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/11/builds/10651 Here is the rele

[clang] [RISCV] Teach Barmetal toolchain about GCC installation(1/3) (PR #121829)

2025-01-07 Thread Garvit Gupta via cfe-commits
https://github.com/quic-garvgupt updated https://github.com/llvm/llvm-project/pull/121829 >From 03b91a8d408bacec17391b995611dbbb0ea62edd Mon Sep 17 00:00:00 2001 From: Garvit Gupta Date: Fri, 13 Dec 2024 05:31:56 -0800 Subject: [PATCH] [RISCV] Teach Barmetal toolchain about GCC installation(1/3

[clang] [OpenMP] [Debug] Debug support for work sharing iterator variable (PR #122047)

2025-01-07 Thread Shilei Tian via cfe-commits
shiltian wrote: The fix doesn't look right to me... https://github.com/llvm/llvm-project/pull/122047 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Re-write codegen for atomic_test_and_set and atomic_clear (PR #121943)

2025-01-07 Thread Shafik Yaghmour via cfe-commits
@@ -284,11 +284,26 @@ void f(_Atomic(int) *i, const _Atomic(int) *ci, const volatile int flag_k = 0; volatile int flag = 0; - (void)(int)__atomic_test_and_set(&flag_k, memory_order_seq_cst); // expected-warning {{passing 'const volatile int *' to parameter of type 'vola

[clang] [clang] Evaluate constant initializers in C as well (PR #121950)

2025-01-07 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik commented: I would love to see tests that highlight any differences between C and C++ in this area. https://github.com/llvm/llvm-project/pull/121950 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #122035)

2025-01-07 Thread Ian Anderson via cfe-commits
ian-twilightcoder wrote: tools/llvm-gsymutil/ARM_AArch64/macho-merged-funcs-dwarf.yaml shouldn't be related, it didn't fail in the original patch and the only difference in this one is https://github.com/llvm/llvm-project/pull/122035/files#diff-59f998dac7c93956bd206a4998cdc2180c26e9b8116af4e45

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #122035)

2025-01-07 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder closed https://github.com/llvm/llvm-project/pull/122035 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d6bfe10 - [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (#122035)

2025-01-07 Thread via cfe-commits
Author: Ian Anderson Date: 2025-01-07T21:13:49-08:00 New Revision: d6bfe10ac9963eb63e141d6c50e9a183c08d35da URL: https://github.com/llvm/llvm-project/commit/d6bfe10ac9963eb63e141d6c50e9a183c08d35da DIFF: https://github.com/llvm/llvm-project/commit/d6bfe10ac9963eb63e141d6c50e9a183c08d35da.diff

[clang] [llvm] [RISCV] Add riscv_atomic.h and Zawrs builtins (PR #96283)

2025-01-07 Thread Pengcheng Wang via cfe-commits
https://github.com/wangpc-pp edited https://github.com/llvm/llvm-project/pull/96283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] [Debug] Debug support for work sharing iterator variable (PR #122047)

2025-01-07 Thread Alok Kumar Sharma via cfe-commits
https://github.com/alokkrsharma edited https://github.com/llvm/llvm-project/pull/122047 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] [Debug] Debug support for work sharing iterator variable (PR #122047)

2025-01-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-amdgpu @llvm/pr-subscribers-clang-codegen Author: Alok Kumar Sharma (alokkrsharma) Changes This fixes https://github.com/llvm/llvm-project/issues/110700 Work-sharing loop iterator variable had incorrect debug info attached to it. It was due to

[clang] [OpenMP] [Debug] Debug support for work sharing iterator variable (PR #122047)

2025-01-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Alok Kumar Sharma (alokkrsharma) Changes This fixes https://github.com/llvm/llvm-project/issues/110700 Work-sharing loop iterator variable had incorrect debug info attached to it. It was due to redundant/incorrect debug info overwrites th

[clang] b4ae419 - [clang] [NFC] explicitly check if ParentMap contains key (#121736)

2025-01-07 Thread via cfe-commits
Author: Sameer Sahasrabuddhe Date: 2025-01-08T10:04:44+05:30 New Revision: b4ae4192989f97503626748421f32745897941ba URL: https://github.com/llvm/llvm-project/commit/b4ae4192989f97503626748421f32745897941ba DIFF: https://github.com/llvm/llvm-project/commit/b4ae4192989f97503626748421f32745897941b

[clang] [clang] [NFC] explicitly check if ParentMap contains key (PR #121736)

2025-01-07 Thread Sameer Sahasrabuddhe via cfe-commits
https://github.com/ssahasra closed https://github.com/llvm/llvm-project/pull/121736 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] codegen support for masked combined construct parallel masked taskloop (PR #121741)

2025-01-07 Thread CHANDRA GHALE via cfe-commits
https://github.com/chandraghale updated https://github.com/llvm/llvm-project/pull/121741 >From 0c790fc2768d58634e0455adf9f797a2456a7335 Mon Sep 17 00:00:00 2001 From: Chandra Ghale Date: Mon, 6 Jan 2025 03:35:46 -0600 Subject: [PATCH 1/3] codegen support for masked combined construct parallel

[clang] [clang-tools-extra] [libcxx] [llvm] [libc++] implement views::concat (PR #120920)

2025-01-07 Thread Nhat Nguyen via cfe-commits
https://github.com/changkhothuychung updated https://github.com/llvm/llvm-project/pull/120920 error: too big or took too long to generate ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang] [sanitizer] Parse weighted sanitizer args and -fno-sanitize-top-hot (PR #121619)

2025-01-07 Thread Thurston Dang via cfe-commits
https://github.com/thurstond edited https://github.com/llvm/llvm-project/pull/121619 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Add riscv_atomic.h and Zawrs builtins (PR #96283)

2025-01-07 Thread Craig Topper via cfe-commits
https://github.com/topperc approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/96283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Add riscv_atomic.h and Zawrs builtins (PR #96283)

2025-01-07 Thread Craig Topper via cfe-commits
topperc wrote: suppoprt -> support https://github.com/llvm/llvm-project/pull/96283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [sanitizer] Parse weighted sanitizer args and -fno-sanitize-top-hot (PR #121619)

2025-01-07 Thread Thurston Dang via cfe-commits
@@ -2649,6 +2649,14 @@ def fsanitize_undefined_strip_path_components_EQ : Joined<["-"], "fsanitize-unde HelpText<"Strip (or keep only, if negative) a given number of path components " "when emitting check metadata.">, MarshallingInfoInt, "0", "int">; +def fno_

[clang] [sanitizer] Parse weighted sanitizer args and -fno-sanitize-top-hot (PR #121619)

2025-01-07 Thread Thurston Dang via cfe-commits
@@ -44,6 +92,19 @@ void clang::serializeSanitizerSet(SanitizerSet Set, #include "clang/Basic/Sanitizers.def" } +void clang::serializeSanitizerMaskCutoffs( +const SanitizerMaskCutoffs &Cutoffs, SmallVectorImpl &Values) { +#define SANITIZER(NAME, ID)

[clang] [llvm] [RISCV] Add riscv_atomic.h and Zawrs builtins (PR #96283)

2025-01-07 Thread Pengcheng Wang via cfe-commits
https://github.com/wangpc-pp updated https://github.com/llvm/llvm-project/pull/96283 >From 4b597ebf69de59d62e5587a27cedf2b12e831763 Mon Sep 17 00:00:00 2001 From: Wang Pengcheng Date: Fri, 21 Jun 2024 16:09:13 +0800 Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =

[clang] [sanitizer] Parse weighted sanitizer args and -fno-sanitize-top-hot (PR #121619)

2025-01-07 Thread Fangrui Song via cfe-commits
@@ -2649,6 +2649,14 @@ def fsanitize_undefined_strip_path_components_EQ : Joined<["-"], "fsanitize-unde HelpText<"Strip (or keep only, if negative) a given number of path components " "when emitting check metadata.">, MarshallingInfoInt, "0", "int">; +def fno_

[clang] Use range-based for to iterate over fields in record layout, NFC (PR #122029)

2025-01-07 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik commented: nitpick, I don't think this is an NFC change. It would require some thought to really convince myself this did not have subtle behavior changes even if unintended. https://github.com/llvm/llvm-project/pull/122029 ___

[clang] [clang] fix uefi target for aarch64 & x86_64 (PR #120632)

2025-01-07 Thread Roland McGrath via cfe-commits
@@ -820,43 +820,6 @@ class LLVM_LIBRARY_VISIBILITY X86_64TargetInfo : public X86TargetInfo { } }; -// x86-64 UEFI target -class LLVM_LIBRARY_VISIBILITY UEFIX86_64TargetInfo -: public UEFITargetInfo { -public: - UEFIX86_64TargetInfo(const llvm::Triple &Triple, const Tar

[clang] [clang-tools-extra] [libcxx] [llvm] [libc++] implement views::concat (PR #120920)

2025-01-07 Thread Nhat Nguyen via cfe-commits
https://github.com/changkhothuychung updated https://github.com/llvm/llvm-project/pull/120920 error: too big or took too long to generate ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang] [clang-tools-extra] [libcxx] [llvm] [libc++] implement views::concat (PR #120920)

2025-01-07 Thread Nhat Nguyen via cfe-commits
https://github.com/changkhothuychung updated https://github.com/llvm/llvm-project/pull/120920 error: too big or took too long to generate ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang] [sanitizer] Parse weighted sanitizer args and -fno-sanitize-top-hot (PR #121619)

2025-01-07 Thread Vitaly Buka via cfe-commits
@@ -44,6 +92,19 @@ void clang::serializeSanitizerSet(SanitizerSet Set, #include "clang/Basic/Sanitizers.def" } +void clang::serializeSanitizerMaskCutoffs( +const SanitizerMaskCutoffs &Cutoffs, SmallVectorImpl &Values) { +#define SANITIZER(NAME, ID)

[clang] [sanitizer] Parse weighted sanitizer args and -fno-sanitize-top-hot (PR #121619)

2025-01-07 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka approved this pull request. https://github.com/llvm/llvm-project/pull/121619 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [sanitizer] Parse weighted sanitizer args and -fno-sanitize-top-hot (PR #121619)

2025-01-07 Thread Vitaly Buka via cfe-commits
@@ -46,26 +47,20 @@ bool clang::parseSanitizerWeightedValue(StringRef Value, bool AllowGroups, #include "clang/Basic/Sanitizers.def" .Default(SanitizerMask()); - if (ParsedKind) { -size_t equalsIndex = Value.find_first_of('='); -if (e

[clang] [clang] fix uefi target for aarch64 & x86_64 (PR #120632)

2025-01-07 Thread Tristan Ross via cfe-commits
https://github.com/RossComputerGuy updated https://github.com/llvm/llvm-project/pull/120632 >From 1a76395c0dbe55146d1dd1ff943909f34c19a90a Mon Sep 17 00:00:00 2001 From: Tristan Ross Date: Thu, 19 Dec 2024 10:54:58 -0800 Subject: [PATCH 1/5] [clang] fix uefi data layout on x86 & aarch64 --- c

[clang] [clang] fix uefi target for aarch64 & x86_64 (PR #120632)

2025-01-07 Thread Tristan Ross via cfe-commits
@@ -820,43 +820,6 @@ class LLVM_LIBRARY_VISIBILITY X86_64TargetInfo : public X86TargetInfo { } }; -// x86-64 UEFI target -class LLVM_LIBRARY_VISIBILITY UEFIX86_64TargetInfo -: public UEFITargetInfo { -public: - UEFIX86_64TargetInfo(const llvm::Triple &Triple, const Tar

[clang] [C++20] [Modules] [Serialization] Delay marking pending incomplete decl chains until the end of `finishPendingActions`. (PR #121245)

2025-01-07 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: > Can you reduce your modules test case into a self contained project with > build system? > > If so, you can use [cvise](https://github.com/marxin/cvise) for reducing a > whole project directory recursively in one invocation. I didn't know this before. It sounds great. If y

[clang] [llvm] [mlir] [NVPTX] Switch front-ends and tests to ptx_kernel cc (PR #120806)

2025-01-07 Thread Alex MacLean via cfe-commits
https://github.com/AlexMaclean closed https://github.com/llvm/llvm-project/pull/120806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Modules] Fix modular build. (PR #122034)

2025-01-07 Thread Volodymyr Sapsai via cfe-commits
https://github.com/vsapsai closed https://github.com/llvm/llvm-project/pull/122034 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] db408ac - [Modules] Fix modular build. (#122034)

2025-01-07 Thread via cfe-commits
Author: Volodymyr Sapsai Date: 2025-01-07T18:02:10-08:00 New Revision: db408acc0498a8e5ece91b8d745e3cc412542398 URL: https://github.com/llvm/llvm-project/commit/db408acc0498a8e5ece91b8d745e3cc412542398 DIFF: https://github.com/llvm/llvm-project/commit/db408acc0498a8e5ece91b8d745e3cc412542398.di

[clang] [llvm] [Modules] Fix modular build. (PR #122034)

2025-01-07 Thread Volodymyr Sapsai via cfe-commits
vsapsai wrote: Test failure "LLVM.tools/llvm-gsymutil/ARM_AArch64/macho-merged-funcs-dwarf.yaml" is unrelated to this change. https://github.com/llvm/llvm-project/pull/122034 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[clang-tools-extra] [clangd] Add a unit test suite for HeuristicResolver (PR #121313)

2025-01-07 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 closed https://github.com/llvm/llvm-project/pull/121313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang][Sema] Upstream HeuristicResolver from clangd (PR #121314)

2025-01-07 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 edited https://github.com/llvm/llvm-project/pull/121314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 30ba8be - [clangd] Add a unit test suite for HeuristicResolver (#121313)

2025-01-07 Thread via cfe-commits
Author: Nathan Ridge Date: 2025-01-07T20:52:06-05:00 New Revision: 30ba8be22eb0e3f771624f6f47229129cf74e976 URL: https://github.com/llvm/llvm-project/commit/30ba8be22eb0e3f771624f6f47229129cf74e976 DIFF: https://github.com/llvm/llvm-project/commit/30ba8be22eb0e3f771624f6f47229129cf74e976.diff

[clang] [CUDA][HIP] Fix overriding of constexpr virtual function (PR #121986)

2025-01-07 Thread Yaxun Liu via cfe-commits
@@ -1595,8 +1606,21 @@ static bool IsOverloadOrOverrideImpl(Sema &SemaRef, FunctionDecl *New, // Allow overloading of functions with same signature and different CUDA // target attributes. -if (NewTarget != OldTarget) +if (NewTarget != OldTarg

[clang] clang/limits.h: Avoid including limits.h twice (PR #120526)

2025-01-07 Thread YunQiang Su via cfe-commits
wzssyqa wrote: > I'm confused why this is necessary, we already work around glibc's quirk here: > > https://github.com/llvm/llvm-project/blob/a15fedc399d5d1aa07c14531e5cd8d3efc583600/clang/lib/Headers/limits.h#L18 > > > which should then hit glibc's header guard here: > https://sourceware.org/

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #122035)

2025-01-07 Thread Carlo Cabrera via cfe-commits
https://github.com/carlocab approved this pull request. https://github.com/llvm/llvm-project/pull/122035 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver][UEFI] Enable Microsoft extensions (PR #121875)

2025-01-07 Thread Roland McGrath via cfe-commits
https://github.com/frobtech approved this pull request. LGTM given a driver test as Petr mentioned. https://github.com/llvm/llvm-project/pull/121875 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #122035)

2025-01-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Ian Anderson (ian-twilightcoder) Changes Embedded development often needs to use a different C standard library, replacing the existing one normally passed as -internal-externc-isystem. This works fine for an apple-macos target, bu

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #122035)

2025-01-07 Thread Ian Anderson via cfe-commits
ian-twilightcoder wrote: Same thing as https://github.com/llvm/llvm-project/pull/120507, but with the added unit test fixed to accept libc++ being in the SDK or in the build directory. https://github.com/llvm/llvm-project/pull/122035 ___ cfe-commits

[clang] [llvm] [Darwin][Driver][clang] apple-none-macho orders the resource directory after internal-externc-isystem when nostdlibinc is used (PR #122035)

2025-01-07 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder created https://github.com/llvm/llvm-project/pull/122035 Embedded development often needs to use a different C standard library, replacing the existing one normally passed as -internal-externc-isystem. This works fine for an apple-macos target, but apple-no

[clang] [llvm] [Modules] Fix modular build. (PR #122034)

2025-01-07 Thread Volodymyr Sapsai via cfe-commits
https://github.com/vsapsai created https://github.com/llvm/llvm-project/pull/122034 Add a new file to the module map and remove 2 missing files (migrated from .def to .td). >From cc9d4ebe3880810c8325f1fd6c7b9e2a49f2fe74 Mon Sep 17 00:00:00 2001 From: Volodymyr Sapsai Date: Tue, 7 Jan 2025 17:

[clang] [Clang][Parser] Don't evaluate concept when its definition is invalid (PR #111179)

2025-01-07 Thread Shafik Yaghmour via cfe-commits
shafik wrote: This crash looks linked to this change: https://github.com/llvm/llvm-project/issues/121980 https://github.com/llvm/llvm-project/pull/79 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] [llvm] [Modules] Fix modular build. (PR #122034)

2025-01-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Volodymyr Sapsai (vsapsai) Changes Add a new file to the module map and remove 2 missing files (migrated from .def to .td). --- Full diff: https://github.com/llvm/llvm-project/pull/122034.diff 2 Files Affected: - (modified) clang/inclu

[clang] [llvm] [tysan] Convert TySan from function+module pass to just module pass (PR #120667)

2025-01-07 Thread Mingjie Xu via cfe-commits
https://github.com/Enna1 updated https://github.com/llvm/llvm-project/pull/120667 >From 7cef5a275b176b8cf8703ae3b372637a1dded326 Mon Sep 17 00:00:00 2001 From: "xumingjie.enna1" Date: Thu, 19 Dec 2024 20:38:09 +0800 Subject: [PATCH 1/2] [tysan] Convert TySan from function+module pass to just m

[clang] [llvm] [Driver][SYCL] Add initial SYCL offload compilation support (PR #117268)

2025-01-07 Thread Jon Roelofs via cfe-commits
jroelofs wrote: also: ``` clang/lib/Driver/ToolChains/SYCL.h:27:17: warning: private field 'D' is not used [-Wunused-private-field] ``` https://github.com/llvm/llvm-project/pull/117268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[clang] [llvm] [Driver][SYCL] Add initial SYCL offload compilation support (PR #117268)

2025-01-07 Thread Jon Roelofs via cfe-commits
jroelofs wrote: I see a new warning from this patch: ``` clang/lib/Driver/ToolChains/SYCL.cpp:35:10: warning: returning address of local temporary object [-Wreturn-stack-address] ``` https://github.com/llvm/llvm-project/pull/117268 ___ cfe-commits mai

[clang] Use range-based for to iterate over fields in record layout, NFC (PR #122029)

2025-01-07 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 1855333e3a843174c0d7421d4c5e404649f6b75a 1824674744d6fba1dd74c74d54aae9b603d8b854 --e

[clang] [HLSL][NFC] Move packoffset validation to separate function and calculate offsets in bytes (PR #121989)

2025-01-07 Thread Helena Kotas via cfe-commits
@@ -194,17 +196,19 @@ static unsigned calculateLegacyCbufferSize(const ASTContext &Context, calculateLegacyCbufferSize(Context, VT->getElementType()); Size = ElementSize * ElementCount; } else { -Size = Context.getTypeSize(T); +Size = Context.getTypeSize(

[clang] [HLSL][NFC] Move packoffset validation to separate function and calculate offsets in bytes (PR #121989)

2025-01-07 Thread Helena Kotas via cfe-commits
https://github.com/hekota updated https://github.com/llvm/llvm-project/pull/121989 >From f68ea5a099636f840561335dcf2daaed82c7405c Mon Sep 17 00:00:00 2001 From: Helena Kotas Date: Tue, 7 Jan 2025 12:07:28 -0800 Subject: [PATCH 1/2] [HLSL][NFC] Move packoffset validation to separate function an

  1   2   3   4   5   >