[clang-tools-extra] [clangd] Augment code completion results with documentation from the index. (PR #120099)

2024-12-16 Thread Bevin Hansson via cfe-commits
bevin-hansson wrote: > > I'm not entirely sure how to add to the tests for clangd. Any advice? > > We have GTest unit tests for code completion in `CodeCompleteTests.cpp`. > [This > test](https://searchfox.org/llvm/rev/2df48fa78b496a2d276aa848598634bb2aad6857/clang-tools-extra/clangd/unittests

[clang-tools-extra] [clangd] Augment code completion results with documentation from the index. (PR #120099)

2024-12-16 Thread Bevin Hansson via cfe-commits
https://github.com/bevin-hansson updated https://github.com/llvm/llvm-project/pull/120099 >From 16bd4a00feec97ae65a14600caf6921045d54833 Mon Sep 17 00:00:00 2001 From: Bevin Hansson Date: Mon, 16 Dec 2024 16:40:06 +0100 Subject: [PATCH 1/2] [clangd] Augment code completion results with documen

[clang] [Static analysis] Encodes a filename before inserting it into a URL. (PR #120123)

2024-12-16 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-aarch64-linux-bootstrap-hwasan` running on `sanitizer-buildbot11` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/55/builds/4421 Here is the rel

[clang-tools-extra] [clangd] Augment code completion results with documentation from the index. (PR #120099)

2024-12-16 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: > I'm not entirely sure how to add to the tests for clangd. Any advice? We have GTest unit tests for code completion in `CodeCompleteTests.cpp`. [This test](https://searchfox.org/llvm/rev/2df48fa78b496a2d276aa848598634bb2aad6857/clang-tools-extra/clangd/unittests/CodeCompl

[clang] [llvm] [LLVM][MC][AArch64] Assembler support for Armv9.6-A memory systems extensions (PR #112341)

2024-12-16 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,324 @@ +# NOTE: Assertions have been autogenerated by utils/update_mca_test_checks.py MaskRay wrote: update_mca_test_checks.py is only for llvm-mca. Seems wrong usage? There is now update_mc_test_checks.py . You can also do `%extract-encodings` like

[clang] [llvm] [LLVM][MC][AArch64] Assembler support for Armv9.6-A memory systems extensions (PR #112341)

2024-12-16 Thread Fangrui Song via cfe-commits
@@ -53,3 +53,16 @@ // RUN: %clang -target aarch64 -march=armv9.6a+sve-f16f32mm -### -c %s 2>&1 | FileCheck -check-prefix=V96A-SVE-F16F32MM %s // RUN: %clang -target aarch64 -march=armv9.6-a+sve-f16f32mm -### -c %s 2>&1 | FileCheck -check-prefix=V96A-SVE-F16F32MM %s // V96A-SV

[clang-tools-extra] [clang-tidy] performance-unnecessary-copy-initialization: Consider static functions (PR #119974)

2024-12-16 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/119974 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Offload] Add support for loongarch64 to host plugin (PR #120173)

2024-12-16 Thread Jan Patrick Lehr via cfe-commits
jplehr wrote: Is there the possibility to set up a buildbot for this architecture? https://github.com/llvm/llvm-project/pull/120173 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[Static analysis] Encodes a filename before inserting it into a URL." (PR #120195)

2024-12-16 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/120195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6db1b20 - Revert "[Static analysis] Encodes a filename before inserting it into a URL." (#120195)

2024-12-16 Thread via cfe-commits
Author: Ryosuke Niwa Date: 2024-12-16T23:36:26-08:00 New Revision: 6db1b2035bbef5ec477a1e645e249ebf7b29688c URL: https://github.com/llvm/llvm-project/commit/6db1b2035bbef5ec477a1e645e249ebf7b29688c DIFF: https://github.com/llvm/llvm-project/commit/6db1b2035bbef5ec477a1e645e249ebf7b29688c.diff

[clang] [Static analysis] Encodes a filename before inserting it into a URL. (PR #120123)

2024-12-16 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-debian-cpp20` running on `clang-debian-cpp20` while building `clang` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/108/builds/7214 Here is the r

[clang] Revert "[Static analysis] Encodes a filename before inserting it into a URL." (PR #120195)

2024-12-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Ryosuke Niwa (rniwa) Changes Reverts llvm/llvm-project#120123 Broke some tests. --- Full diff: https://github.com/llvm/llvm-project/pull/120195.diff 1 Files Affected: - (modified) clang/tools/scan-build/bin/scan-build (+1-3)

[clang] Revert "[Static analysis] Encodes a filename before inserting it into a URL." (PR #120195)

2024-12-16 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/120195 Reverts llvm/llvm-project#120123 Broke some tests. >From b2b261c406108390117e1b6c3fdbe5e9d53a7111 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Mon, 16 Dec 2024 23:35:54 -0800 Subject: [PATCH] =?UTF-8?q?Rever

[clang] [Static analysis] Encodes a filename before inserting it into a URL. (PR #120123)

2024-12-16 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-gcc-ubuntu` running on `sie-linux-worker3` while building `clang` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/174/builds/10204 Her

[clang] [Static analysis] Encodes a filename before inserting it into a URL. (PR #120123)

2024-12-16 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `premerge-monolithic-linux` running on `premerge-linux-1` while building `clang` at step 7 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/153/builds/17770 Here is

[clang] [Static analysis] Encodes a filename before inserting it into a URL. (PR #120123)

2024-12-16 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-x86_64-debian-fast` running on `gribozavr4` while building `clang` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/56/builds/14671 Here is the rel

[libunwind] [Libunwind] Try to fix msan failures (PR #120013)

2024-12-16 Thread Dmitry Chestnykh via cfe-commits
https://github.com/chestnykh updated https://github.com/llvm/llvm-project/pull/120013 >From 9422b097ff80f5501dcf4fa3d41176b9439ab3f6 Mon Sep 17 00:00:00 2001 From: Dmitry Chestnykh Date: Sun, 15 Dec 2024 21:18:23 +0300 Subject: [PATCH 1/3] [Libunwind] Don't XFAIL tests with msan --- libunwind

[clang] [Static analysis] Encodes a filename before inserting it into a URL. (PR #120123)

2024-12-16 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-x86_64-debian-dylib` running on `gribozavr4` while building `clang` at step 6 "test-build-unified-tree-check-clang". Full details are available at: https://lab.llvm.org/buildbot/#/builders/60/builds/15369 Here is the r

[clang] [Static analysis] Encodes a filename before inserting it into a URL. (PR #120123)

2024-12-16 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-sie-ubuntu-fast` running on `sie-linux-worker` while building `clang` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/144/builds/14100

[clang] [Static analysis] Encodes a filename before inserting it into a URL. (PR #120123)

2024-12-16 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `cross-project-tests-sie-ubuntu` running on `doug-worker-1a` while building `clang` at step 2 "checkout". Full details are available at: https://lab.llvm.org/buildbot/#/builders/181/builds/10473 Here is the relevant piece of

[clang] f515d7a - [Static analysis] Encodes a filename before inserting it into a URL. (#120123)

2024-12-16 Thread via cfe-commits
Author: Ryosuke Niwa Date: 2024-12-16T23:15:32-08:00 New Revision: f515d7aa720142dfbb72f52e9d0106ba33e1fe69 URL: https://github.com/llvm/llvm-project/commit/f515d7aa720142dfbb72f52e9d0106ba33e1fe69 DIFF: https://github.com/llvm/llvm-project/commit/f515d7aa720142dfbb72f52e9d0106ba33e1fe69.diff

[clang] [Static analysis] Encodes a filename before inserting it into a URL. (PR #120123)

2024-12-16 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/120123 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Static analysis] Encodes a filename before inserting it into a URL. (PR #120123)

2024-12-16 Thread Ryosuke Niwa via cfe-commits
rniwa wrote: Thanks for the review! https://github.com/llvm/llvm-project/pull/120123 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Static analysis] Encodes a filename before inserting it into a URL. (PR #120123)

2024-12-16 Thread Rashmi Mudduluru via cfe-commits
https://github.com/t-rasmud approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/120123 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-cl] [Sema] Support MSVC non-const lvalue to user-defined temporary reference (PR #99833)

2024-12-16 Thread Max Winkler via cfe-commits
https://github.com/MaxEW707 updated https://github.com/llvm/llvm-project/pull/99833 >From 0a705b1a8e9673cd5e803ffe392dacfa0f06c40f Mon Sep 17 00:00:00 2001 From: MaxEW707 Date: Fri, 21 Jun 2024 20:37:40 -0700 Subject: [PATCH 01/25] Support MSVC lvalue to temporary reference binding --- clang/

[clang] [clang][bytecode] Remove a bitcast nullptr_t special case (PR #120188)

2024-12-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes We still need to check the input pointer, so let this go through BitCastPrim. --- Full diff: https://github.com/llvm/llvm-project/pull/120188.diff 4 Files Affected: - (modified) clang/lib/AST/ByteCode/Comp

[clang] [clang][bytecode] Remove a bitcast nullptr_t special case (PR #120188)

2024-12-16 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/120188 We still need to check the input pointer, so let this go through BitCastPrim. >From 98b30005491d5082e035bdf966e12ae7f2f205f4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Tue, 17 Dec 2024

[clang] [clang] Fix ASTWriter crash after merging named enums (PR #114240)

2024-12-16 Thread Michael Jabbour via cfe-commits
michael-jabbour-sonarsource wrote: Thanks for the update @vsapsai. Sounds good. Let me know if there are any changes that can make reviewing the PR easier! https://github.com/llvm/llvm-project/pull/114240 ___ cfe-commits mailing list cfe-commits@lists

[clang] [Clang] [Sema] Support matrix types in pseudo-destructor expressions (PR #117483)

2024-12-16 Thread via cfe-commits
https://github.com/Sirraide closed https://github.com/llvm/llvm-project/pull/117483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] eb5c211 - [Clang] [Sema] Support matrix types in pseudo-destructor expressions (#117483)

2024-12-16 Thread via cfe-commits
Author: Sirraide Date: 2024-12-17T06:49:31+01:00 New Revision: eb5c21108fca4c871987faef581158811954c916 URL: https://github.com/llvm/llvm-project/commit/eb5c21108fca4c871987faef581158811954c916 DIFF: https://github.com/llvm/llvm-project/commit/eb5c21108fca4c871987faef581158811954c916.diff LOG:

[clang] [NFC] Updating Debug Info generation for 'this' (PR #119445)

2024-12-16 Thread via cfe-commits
joaosaffran wrote: @llvm-beanz @dwblaikie I've built a bootstrap version of clang with and without this change, the binary output was identical for both builds (check them with `diff`), please let me know if there is something else you might need me testing https://github.com/llvm/llvm-project

[clang] [clang][bytecode] Don't check returned pointers for liveness (PR #120107)

2024-12-16 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/120107 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 056cd12 - [clang][bytecode] Don't check returned pointers for liveness (#120107)

2024-12-16 Thread via cfe-commits
Author: Timm Baeder Date: 2024-12-17T06:20:14+01:00 New Revision: 056cd12284f72105a3e2338f901882e43a90c8b2 URL: https://github.com/llvm/llvm-project/commit/056cd12284f72105a3e2338f901882e43a90c8b2 DIFF: https://github.com/llvm/llvm-project/commit/056cd12284f72105a3e2338f901882e43a90c8b2.diff L

[clang] [clang] Fix crashes when passing VLA to va_arg (PR #119563)

2024-12-16 Thread via cfe-commits
https://github.com/amane-ame updated https://github.com/llvm/llvm-project/pull/119563 From 659eda3ec76b63418f8b621b004728d9d7bf26ad Mon Sep 17 00:00:00 2001 From: amane-ame Date: Wed, 11 Dec 2024 22:17:51 +0800 Subject: [PATCH 1/9] [clang] Fix crashes when passing VLA to va_arg --- clang/lib/

[clang] [clang] Fix ASTWriter crash after merging named enums (PR #114240)

2024-12-16 Thread Volodymyr Sapsai via cfe-commits
vsapsai wrote: Sorry for the delay. Will need to look at the change in a debugger. https://github.com/llvm/llvm-project/pull/114240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ObjectiveC] Fix Parsing Method Parameter Types with the `::` Prefix (PR #119908)

2024-12-16 Thread Volodymyr Sapsai via cfe-commits
vsapsai wrote: How does it work in Objective-C++? I don't know even if we have a test but hope we do. https://github.com/llvm/llvm-project/pull/119908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[clang] [llvm] [Offload] Add support for loongarch64 to host plugin (PR #120173)

2024-12-16 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. Thanks, I don't have any way to test this but it's pretty straightforward. https://github.com/llvm/llvm-project/pull/120173 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[clang] [llvm] [Offload] Add support for loongarch64 to host plugin (PR #120173)

2024-12-16 Thread via cfe-commits
wangleiat wrote: > Does this actually work? I executed the `ninja check-offload` command on `LoongArch64`, and the results are as follows: Befor [commit](https://github.com/llvm/llvm-project/pull/120173/commits/7edfb3eb052643ebe2f4bc750cd96d980f782a84): ``` Total Discovered Tests:

[clang] [llvm] [Offload] Add support for loongarch64 to host plugin (PR #120173)

2024-12-16 Thread via cfe-commits
https://github.com/wangleiat edited https://github.com/llvm/llvm-project/pull/120173 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Offload] Add support for loongarch64 to host plugin (PR #120173)

2024-12-16 Thread via cfe-commits
https://github.com/wangleiat updated https://github.com/llvm/llvm-project/pull/120173 >From 94fd3789cc55c3f482884a06a7ad9e83964d35e2 Mon Sep 17 00:00:00 2001 From: wanglei Date: Tue, 17 Dec 2024 10:35:01 +0800 Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?UTF-8

[clang] [Clang] Remove 3-element vector load and store special handling (PR #104661)

2024-12-16 Thread Shilei Tian via cfe-commits
https://github.com/shiltian updated https://github.com/llvm/llvm-project/pull/104661 >From f01858b4850cef77794959a36ec704e125838b73 Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Mon, 16 Dec 2024 21:51:53 -0500 Subject: [PATCH] [Clang] Remove 3-element vector load and store special handling

[clang] [Clang] Remove 3-element vector load and store special handling (PR #104661)

2024-12-16 Thread Matt Arsenault via cfe-commits
@@ -1846,6 +1846,16 @@ class TargetInfo : public TransferrableTargetInfo, return std::make_pair(64, 64); } + /// Returns the optimal vector type elements based on the provided vector + /// type. For example, on some targets, a vector with 3 elements may be + /// treat

[clang] [Clang] Remove 3-element vector load and store special handling (PR #104661)

2024-12-16 Thread Shilei Tian via cfe-commits
@@ -1846,6 +1846,16 @@ class TargetInfo : public TransferrableTargetInfo, return std::make_pair(64, 64); } + /// Returns the optimal vector type elements based on the provided vector + /// type. For example, on some targets, a vector with 3 elements may be + /// treat

[clang] [Clang] Remove 3-element vector load and store special handling (PR #104661)

2024-12-16 Thread Shilei Tian via cfe-commits
https://github.com/shiltian updated https://github.com/llvm/llvm-project/pull/104661 >From 9e23538a7cac72fe456fb039b5e0f321a0f3e142 Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Mon, 16 Dec 2024 21:51:53 -0500 Subject: [PATCH] [Clang] Remove 3-element vector load and store special handling

[clang] [clang-cl] [Sema] Support MSVC non-const lvalue to user-defined temporary reference (PR #99833)

2024-12-16 Thread Max Winkler via cfe-commits
https://github.com/MaxEW707 updated https://github.com/llvm/llvm-project/pull/99833 >From 0a705b1a8e9673cd5e803ffe392dacfa0f06c40f Mon Sep 17 00:00:00 2001 From: MaxEW707 Date: Fri, 21 Jun 2024 20:37:40 -0700 Subject: [PATCH 01/24] Support MSVC lvalue to temporary reference binding --- clang/

[clang] [Clang][AMDGPU] Stop defaulting to `one-as` for all atomic scopes (PR #120095)

2024-12-16 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/120095 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AMDGPU] Stop defaulting to `one-as` for all atomic scopes (PR #120095)

2024-12-16 Thread via cfe-commits
b-sumner wrote: OpenCL should only be using the amdgcn fence builtin. See, e.g. https://github.com/ROCm/llvm-project/blob/amd-staging/amd/device-libs/opencl/src/misc/awif.cl#L73 https://github.com/llvm/llvm-project/pull/120095 ___ cfe-commits maili

[clang] [Clang][AMDGPU] Stop defaulting to `one-as` for all atomic scopes (PR #120095)

2024-12-16 Thread Dhruva Chakrabarti via cfe-commits
@@ -537,7 +537,11 @@ AMDGPUTargetCodeGenInfo::getLLVMSyncScopeID(const LangOptions &LangOpts, break; } - if (Ordering != llvm::AtomicOrdering::SequentiallyConsistent) { + // OpenCL assumes by default that atomic scopes are per-address space for + // non-sequentially

[clang] [Clang][AMDGPU] Stop defaulting to `one-as` for all atomic scopes (PR #120095)

2024-12-16 Thread Joseph Huber via cfe-commits
@@ -537,7 +537,11 @@ AMDGPUTargetCodeGenInfo::getLLVMSyncScopeID(const LangOptions &LangOpts, break; } - if (Ordering != llvm::AtomicOrdering::SequentiallyConsistent) { + // OpenCL assumes by default that atomic scopes are per-address space for + // non-sequentially

[clang] [Clang][AMDGPU] Stop defaulting to `one-as` for all atomic scopes (PR #120095)

2024-12-16 Thread Dhruva Chakrabarti via cfe-commits
https://github.com/dhruvachak edited https://github.com/llvm/llvm-project/pull/120095 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AMDGPU] Stop defaulting to `one-as` for all atomic scopes (PR #120095)

2024-12-16 Thread Joseph Huber via cfe-commits
@@ -537,7 +537,11 @@ AMDGPUTargetCodeGenInfo::getLLVMSyncScopeID(const LangOptions &LangOpts, break; } - if (Ordering != llvm::AtomicOrdering::SequentiallyConsistent) { + // OpenCL assumes by default that atomic scopes are per-address space for + // non-sequentially

[clang] [Clang][AMDGPU] Stop defaulting to `one-as` for all atomic scopes (PR #120095)

2024-12-16 Thread Dhruva Chakrabarti via cfe-commits
@@ -537,7 +537,11 @@ AMDGPUTargetCodeGenInfo::getLLVMSyncScopeID(const LangOptions &LangOpts, break; } - if (Ordering != llvm::AtomicOrdering::SequentiallyConsistent) { + // OpenCL assumes by default that atomic scopes are per-address space for + // non-sequentially

[clang] [clang] Recover necessary AddrSpaceCast (PR #119246)

2024-12-16 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/119246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Recover necessary AddrSpaceCast (PR #119246)

2024-12-16 Thread Matt Arsenault via cfe-commits
@@ -0,0 +1,16 @@ +// RUN: %clang_cc1 -triple amdgcn-amd-amdhsa -aux-triple x86_64-unknown-linux-gnu -target-cpu gfx906 -fopenmp -nogpulib -fopenmp-is-target-device -emit-llvm %s -o - | FileCheck %s + +// Don't crash with assertions build. + +// CHECK: @MyGlobVar = external

[clang] [Clang][AMDGPU] Stop defaulting to `one-as` for all atomic scopes (PR #120095)

2024-12-16 Thread Joseph Huber via cfe-commits
@@ -537,7 +537,11 @@ AMDGPUTargetCodeGenInfo::getLLVMSyncScopeID(const LangOptions &LangOpts, break; } - if (Ordering != llvm::AtomicOrdering::SequentiallyConsistent) { + // OpenCL assumes by default that atomic scopes are per-address space for + // non-sequentially

[clang] [llvm] [HLSL] Implement `WaveActiveAllTrue` Intrinsic (PR #117245)

2024-12-16 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-aarch64-sve-vla-2stage` running on `linaro-g3-02` while building `clang,llvm` at step 12 "ninja check 2". Full details are available at: https://lab.llvm.org/buildbot/#/builders/41/builds/4142 Here is the relevant pie

[clang] [Clang][AMDGPU] Stop defaulting to `one-as` for all atomic scopes (PR #120095)

2024-12-16 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/120095 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AMDGPU] Stop defaulting to `one-as` for all atomic scopes (PR #120095)

2024-12-16 Thread Dhruva Chakrabarti via cfe-commits
@@ -537,7 +537,11 @@ AMDGPUTargetCodeGenInfo::getLLVMSyncScopeID(const LangOptions &LangOpts, break; } - if (Ordering != llvm::AtomicOrdering::SequentiallyConsistent) { + // OpenCL assumes by default that atomic scopes are per-address space for + // non-sequentially

[clang] [Clang] [Sema] Support matrix types in pseudo-destructor expressions (PR #117483)

2024-12-16 Thread via cfe-commits
@@ -0,0 +1,31 @@ +// RUN: %clang_cc1 -fsyntax-only -fenable-matrix -std=c++11 -verify %s +// expected-no-diagnostics + +template +void f() { + T().~T(); +} + +template +void f1(T *f) { Sirraide wrote: #120167 https://github.com/llvm/llvm-project/pull/117483 _

[clang] [Clang][AMDGPU] Stop defaulting to `one-as` for all atomic scopes (PR #120095)

2024-12-16 Thread Joseph Huber via cfe-commits
@@ -537,7 +537,8 @@ AMDGPUTargetCodeGenInfo::getLLVMSyncScopeID(const LangOptions &LangOpts, break; } - if (Ordering != llvm::AtomicOrdering::SequentiallyConsistent) { + if (LangOpts.OpenCL && jhuber6 wrote: I'm sure it's using it somewhere since it'

[clang] [Clang] [Sema] Support matrix types in pseudo-destructor expressions (PR #117483)

2024-12-16 Thread via cfe-commits
https://github.com/Sirraide updated https://github.com/llvm/llvm-project/pull/117483 >From 4eff78b4f8404217cecf254227bc79dcc11d2f36 Mon Sep 17 00:00:00 2001 From: Sirraide Date: Sun, 24 Nov 2024 13:43:02 +0100 Subject: [PATCH 1/4] [Clang] [Sema] Support matrix types in pseudo-destructor expres

[clang] [Clang] [Sema] Support matrix types in pseudo-destructor expressions (PR #117483)

2024-12-16 Thread via cfe-commits
@@ -0,0 +1,31 @@ +// RUN: %clang_cc1 -fsyntax-only -fenable-matrix -std=c++11 -verify %s +// expected-no-diagnostics + +template +void f() { + T().~T(); +} + +template +void f1(T *f) { Sirraide wrote: Well, it turns out we currently don’t support matrix types

[clang] [Clang][AMDGPU] Stop defaulting to `one-as` for all atomic scopes (PR #120095)

2024-12-16 Thread Joseph Huber via cfe-commits
@@ -537,7 +537,8 @@ AMDGPUTargetCodeGenInfo::getLLVMSyncScopeID(const LangOptions &LangOpts, break; } - if (Ordering != llvm::AtomicOrdering::SequentiallyConsistent) { + if (LangOpts.OpenCL && jhuber6 wrote: That's the current behavior now that I upd

[clang] [Clang][AMDGPU] Stop defaulting to `one-as` for all atomic scopes (PR #120095)

2024-12-16 Thread Matt Arsenault via cfe-commits
@@ -537,7 +537,8 @@ AMDGPUTargetCodeGenInfo::getLLVMSyncScopeID(const LangOptions &LangOpts, break; } - if (Ordering != llvm::AtomicOrdering::SequentiallyConsistent) { + if (LangOpts.OpenCL && arsenm wrote: The amdgcn fence builtin also looks like it

[clang] [Clang][AMDGPU] Stop defaulting to `one-as` for all atomic scopes (PR #120095)

2024-12-16 Thread Matt Arsenault via cfe-commits
@@ -537,7 +537,8 @@ AMDGPUTargetCodeGenInfo::getLLVMSyncScopeID(const LangOptions &LangOpts, break; } - if (Ordering != llvm::AtomicOrdering::SequentiallyConsistent) { + if (LangOpts.OpenCL && arsenm wrote: My point is 1 builtin : 1 behavior, univers

[clang] [Clang][AMDGPU] Stop defaulting to `one-as` for all atomic scopes (PR #120095)

2024-12-16 Thread Joseph Huber via cfe-commits
@@ -537,7 +537,8 @@ AMDGPUTargetCodeGenInfo::getLLVMSyncScopeID(const LangOptions &LangOpts, break; } - if (Ordering != llvm::AtomicOrdering::SequentiallyConsistent) { + if (LangOpts.OpenCL && jhuber6 wrote: This is not an AMDGPU builitin, the AMDGPU

[clang] a176669 - [clang] Fix -Wunused-variable in CGBuiltin.cpp (NFC)

2024-12-16 Thread Jie Fu via cfe-commits
Author: Jie Fu Date: 2024-12-17T09:07:44+08:00 New Revision: a1766699c66e7b9f8094256f98de57ba79099e94 URL: https://github.com/llvm/llvm-project/commit/a1766699c66e7b9f8094256f98de57ba79099e94 DIFF: https://github.com/llvm/llvm-project/commit/a1766699c66e7b9f8094256f98de57ba79099e94.diff LOG: [

[clang] [Clang] [Sema] Reject non-power-of-2 `_BitInt` matrix element types (PR #117487)

2024-12-16 Thread via cfe-commits
https://github.com/Sirraide closed https://github.com/llvm/llvm-project/pull/117487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6e58e99 - [Clang] [Sema] Reject non-power-of-2 `_BitInt` matrix element types (#117487)

2024-12-16 Thread via cfe-commits
Author: Sirraide Date: 2024-12-17T02:07:29+01:00 New Revision: 6e58e99a07facd73547f7fa1a6f8c0719d8af30d URL: https://github.com/llvm/llvm-project/commit/6e58e99a07facd73547f7fa1a6f8c0719d8af30d DIFF: https://github.com/llvm/llvm-project/commit/6e58e99a07facd73547f7fa1a6f8c0719d8af30d.diff LOG:

[clang] [Clang][AMDGPU] Stop defaulting to `one-as` for all atomic scopes (PR #120095)

2024-12-16 Thread Matt Arsenault via cfe-commits
@@ -537,7 +537,8 @@ AMDGPUTargetCodeGenInfo::getLLVMSyncScopeID(const LangOptions &LangOpts, break; } - if (Ordering != llvm::AtomicOrdering::SequentiallyConsistent) { + if (LangOpts.OpenCL && arsenm wrote: If OpenCL wants this funny behavior, they s

[clang] [Clang][AMDGPU] Stop defaulting to `one-as` for all atomic scopes (PR #120095)

2024-12-16 Thread Matt Arsenault via cfe-commits
@@ -537,7 +537,8 @@ AMDGPUTargetCodeGenInfo::getLLVMSyncScopeID(const LangOptions &LangOpts, break; } - if (Ordering != llvm::AtomicOrdering::SequentiallyConsistent) { + if (LangOpts.OpenCL && arsenm wrote: I am deeply opposed to making any __builtin

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

2024-12-16 Thread Ian Anderson via cfe-commits
@@ -0,0 +1,26 @@ +// UNSUPPORTED: system-windows +// Windows is unsupported because we use the Unix path separator `/` in the test. + +// Add default directories before running clang to check default +// search paths. +// RUN: rm -rf %t && mkdir -p %t +// RUN: cp -R %S/Inputs/M

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

2024-12-16 Thread Ian Anderson via cfe-commits
@@ -0,0 +1,26 @@ +// UNSUPPORTED: system-windows +// Windows is unsupported because we use the Unix path separator `/` in the test. + +// Add default directories before running clang to check default +// search paths. +// RUN: rm -rf %t && mkdir -p %t +// RUN: cp -R %S/Inputs/M

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #120149)

2024-12-16 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder approved this pull request. https://github.com/llvm/llvm-project/pull/120149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Implement elementwise firstbitlow builtin (PR #116858)

2024-12-16 Thread Ashley Coleman via cfe-commits
@@ -3166,109 +3171,228 @@ bool SPIRVInstructionSelector::selectFirstBitHigh32(Register ResVReg, .constrainAllUses(TII, TRI, RBI); } -bool SPIRVInstructionSelector::selectFirstBitHigh64(Register ResVReg, -const SPIRVTyp

[clang] [clang][ObjectiveC] Fix Parsing Method Parameter Types with the `::` Prefix (PR #119908)

2024-12-16 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik commented: This should have a release note. https://github.com/llvm/llvm-project/pull/119908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Driver][clang-linker-wrapper] Add initial support for OpenMP offloading to generic SPIR-V (PR #120145)

2024-12-16 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex updated https://github.com/llvm/llvm-project/pull/120145 >From e1b9b503b1e9b8ebf5a9c94dcefd0c47ab009019 Mon Sep 17 00:00:00 2001 From: "Sarnie, Nick" Date: Mon, 16 Dec 2024 09:25:44 -0800 Subject: [PATCH 1/3] [Driver][clang-linker-wrapper] Add initial support for Open

[clang] [flang] [flang] Support -f[no-]realloc-lhs. (PR #120165)

2024-12-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-flang-fir-hlfir Author: Slava Zakharin (vzakhari) Changes -frealloc-lhs is the default. If -fno-realloc-lhs is specified, then an allocatable on the left side of an intrinsic assignment is not implicitly (re)allocated to conform with the right hand side.

[clang] [flang] [flang] Support -f[no-]realloc-lhs. (PR #120165)

2024-12-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Slava Zakharin (vzakhari) Changes -frealloc-lhs is the default. If -fno-realloc-lhs is specified, then an allocatable on the left side of an intrinsic assignment is not implicitly (re)allocated to conform with the right hand side. Fortran r

[clang] [flang] [flang] Support -f[no-]realloc-lhs. (PR #120165)

2024-12-16 Thread Slava Zakharin via cfe-commits
https://github.com/vzakhari created https://github.com/llvm/llvm-project/pull/120165 -frealloc-lhs is the default. If -fno-realloc-lhs is specified, then an allocatable on the left side of an intrinsic assignment is not implicitly (re)allocated to conform with the right hand side. Fortran runtim

[clang] [llvm] [HLSL] Implement `WaveActiveAllTrue` Intrinsic (PR #117245)

2024-12-16 Thread Sarah Spall via cfe-commits
https://github.com/spall closed https://github.com/llvm/llvm-project/pull/117245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 41a6e9c - [HLSL] Implement `WaveActiveAllTrue` Intrinsic (#117245)

2024-12-16 Thread via cfe-commits
Author: Ashley Coleman Date: 2024-12-16T16:13:35-08:00 New Revision: 41a6e9cfd693c8570d48e73c5649d83ee6376b6d URL: https://github.com/llvm/llvm-project/commit/41a6e9cfd693c8570d48e73c5649d83ee6376b6d DIFF: https://github.com/llvm/llvm-project/commit/41a6e9cfd693c8570d48e73c5649d83ee6376b6d.diff

[clang] [Clang] Fix crash in __builtin_assume_aligned (PR #114217)

2024-12-16 Thread Eli Friedman via cfe-commits
@@ -5272,8 +5272,11 @@ bool Sema::BuiltinAssumeAligned(CallExpr *TheCall) { { ExprResult FirstArgResult = DefaultFunctionArrayLvalueConversion(FirstArg); -if (checkBuiltinArgument(*this, TheCall, 0)) efriedma-quic wrote: Took another look at

[clang] [llvm] [HLSL] Implement elementwise firstbitlow builtin (PR #116858)

2024-12-16 Thread Sarah Spall via cfe-commits
@@ -3166,109 +3171,228 @@ bool SPIRVInstructionSelector::selectFirstBitHigh32(Register ResVReg, .constrainAllUses(TII, TRI, RBI); } -bool SPIRVInstructionSelector::selectFirstBitHigh64(Register ResVReg, -const SPIRVTyp

[clang] [llvm] [HLSL] Implement elementwise firstbitlow builtin (PR #116858)

2024-12-16 Thread Sarah Spall via cfe-commits
https://github.com/spall edited https://github.com/llvm/llvm-project/pull/116858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64] Implement intrinsics for FMLAL/FMLALL (single) (PR #119568)

2024-12-16 Thread via cfe-commits
https://github.com/SpencerAbson updated https://github.com/llvm/llvm-project/pull/119568 >From 99f84f987992dcfa4bd32891b7fd5152ba92eca3 Mon Sep 17 00:00:00 2001 From: Spencer Abson Date: Wed, 11 Dec 2024 14:01:06 + Subject: [PATCH 1/2] [AArch64] Implement intrinsics for FMLAL/FMLALL (single

[clang] [llvm] [AArch64] Implement intrinsics for FMLAL/FMLALL (single) (PR #119568)

2024-12-16 Thread via cfe-commits
https://github.com/SpencerAbson updated https://github.com/llvm/llvm-project/pull/119568 >From 99f84f987992dcfa4bd32891b7fd5152ba92eca3 Mon Sep 17 00:00:00 2001 From: Spencer Abson Date: Wed, 11 Dec 2024 14:01:06 + Subject: [PATCH] [AArch64] Implement intrinsics for FMLAL/FMLALL (single) -

[clang] Fix lld link issue for OHOS (PR #118192)

2024-12-16 Thread Peng Huang via cfe-commits
phuang wrote: I still cannot repro the problem locally, but base on th log in http://45.33.8.238/linux/155432/step_6.txt . Looks like clang tries to search runtime library at "/usr/local/google/home/thakis/src/llvm-project/out/gn/lib/clang/20/lib/linux/libclang_rt.builtins-x86_64.a" (It is th

[clang] Reapply "[Driver][OHOS] Fix lld link issue for OHOS (#118192)" (PR #120159)

2024-12-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Peng Huang (phuang) Changes The problem in original change is because OHOS::getCompilerRT() pickes a wrong builtin runtime (./lib/clang/20/lib/linux/libclang_rt.builtins-x86_64.a), if ./lib/clang/20/lib/linux/libclang_rt.builtins-x8

[clang] Reapply "[Driver][OHOS] Fix lld link issue for OHOS (#118192)" (PR #120159)

2024-12-16 Thread Peng Huang via cfe-commits
https://github.com/phuang created https://github.com/llvm/llvm-project/pull/120159 The problem in original change is because OHOS::getCompilerRT() pickes a wrong builtin runtime (./lib/clang/20/lib/linux/libclang_rt.builtins-x86_64.a), if ./lib/clang/20/lib/linux/libclang_rt.builtins-x86_64.a d

[clang] Reland [Clang] skip default argument instantiation for non-defining friend declarations to meet [dcl.fct.default] p4 (PR #115487)

2024-12-16 Thread Matheus Izvekov via cfe-commits
@@ -4692,6 +4692,17 @@ bool Sema::InstantiateDefaultArgument(SourceLocation CallLoc, FunctionDecl *FD, ParmVarDecl *Param) { assert(Param->hasUninstantiatedDefaultArg()); + // FIXME: We don't track member specialization info for non-de

[clang] [lldb] [clang][DebugInfo][gmodules] Set runtimeLang on ObjC forward declarations (PR #120154)

2024-12-16 Thread Michael Buch via cfe-commits
@@ -2995,20 +2995,21 @@ llvm::DIType *CGDebugInfo::CreateType(const ObjCInterfaceType *Ty, if (!ID) return nullptr; + auto RuntimeLang = + static_cast(TheCU->getSourceLanguage()); + // Return a forward declaration if this type was imported from a clang module,

[clang] [lldb] [clang][DebugInfo][gmodules] Set runtimeLang on ObjC forward declarations (PR #120154)

2024-12-16 Thread Adrian Prantl via cfe-commits
@@ -2995,20 +2995,21 @@ llvm::DIType *CGDebugInfo::CreateType(const ObjCInterfaceType *Ty, if (!ID) return nullptr; + auto RuntimeLang = + static_cast(TheCU->getSourceLanguage()); + // Return a forward declaration if this type was imported from a clang module,

[clang] [lldb] [clang][DebugInfo][gmodules] Set runtimeLang on ObjC forward declarations (PR #120154)

2024-12-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Michael Buch (Michael137) Changes In Objective-C, forward declarations are currently represented as: ``` DW_TAG_structure_type DW_AT_name("Foo") DW_AT_declaration (true) DW_AT_APPLE_runtime_class (DW_LA

[clang] [lldb] [clang][DebugInfo][gmodules] Set runtimeLang on ObjC forward declarations (PR #120154)

2024-12-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Michael Buch (Michael137) Changes In Objective-C, forward declarations are currently represented as: ``` DW_TAG_structure_type DW_AT_name("Foo") DW_AT_declaration (true) DW_AT_APPLE_runtime_class (DW_LA

[clang] [lldb] [clang][DebugInfo][gmodules] Set runtimeLang on ObjC forward declarations (PR #120154)

2024-12-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-lldb @llvm/pr-subscribers-clang Author: Michael Buch (Michael137) Changes In Objective-C, forward declarations are currently represented as: ``` DW_TAG_structure_type DW_AT_name("Foo") DW_AT_declaration (true) DW_AT_APPLE_ru

[clang] [lldb] [clang][DebugInfo][gmodules] Set runtimeLang on ObjC forward declarations (PR #120154)

2024-12-16 Thread Michael Buch via cfe-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/120154 In Objective-C, forward declarations are currently represented as: ``` DW_TAG_structure_type DW_AT_name("Foo") DW_AT_declaration (true) DW_AT_APPLE_runtime_class (DW_LANG_ObjC) ``

[clang] 8c16323 - [OpenACC/NFC] Make 'trailing objects' use private inheritence.

2024-12-16 Thread via cfe-commits
Author: erichkeane Date: 2024-12-16T14:31:03-08:00 New Revision: 8c163237573df097a99b65a83280757d1b39062c URL: https://github.com/llvm/llvm-project/commit/8c163237573df097a99b65a83280757d1b39062c DIFF: https://github.com/llvm/llvm-project/commit/8c163237573df097a99b65a83280757d1b39062c.diff LO

[clang] Reland [Clang] skip default argument instantiation for non-defining friend declarations to meet [dcl.fct.default] p4 (PR #115487)

2024-12-16 Thread Erich Keane via cfe-commits
@@ -4692,6 +4692,17 @@ bool Sema::InstantiateDefaultArgument(SourceLocation CallLoc, FunctionDecl *FD, ParmVarDecl *Param) { assert(Param->hasUninstantiatedDefaultArg()); + // FIXME: We don't track member specialization info for non-de

[clang] [Clang] Fix crash in __builtin_assume_aligned (PR #114217)

2024-12-16 Thread Shafik Yaghmour via cfe-commits
shafik wrote: ping on this we have another regression linked to the original change: https://github.com/llvm/llvm-project/issues/120086 We really should land a fix ASAP, this is now three regression linked to the same change. https://github.com/llvm/llvm-project/pull/114217 _

  1   2   3   4   >