[clang] Revert "Switch builtin strings to use string tables" (PR #119638)

2024-12-13 Thread Chandler Carruth via cfe-commits
https://github.com/chandlerc edited https://github.com/llvm/llvm-project/pull/119638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "Switch builtin strings to use string tables" (PR #119638)

2024-12-13 Thread Chandler Carruth via cfe-commits
https://github.com/chandlerc closed https://github.com/llvm/llvm-project/pull/119638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ca79ff0 - Revert "Switch builtin strings to use string tables" (#119638)

2024-12-13 Thread via cfe-commits
Author: Chandler Carruth Date: 2024-12-13T23:58:48-08:00 New Revision: ca79ff07d8ae7a0c2531bfdb1cb623e25e5bd486 URL: https://github.com/llvm/llvm-project/commit/ca79ff07d8ae7a0c2531bfdb1cb623e25e5bd486 DIFF: https://github.com/llvm/llvm-project/commit/ca79ff07d8ae7a0c2531bfdb1cb623e25e5bd486.di

[clang] Revert "Switch builtin strings to use string tables" (PR #119638)

2024-12-13 Thread Chandler Carruth via cfe-commits
chandlerc wrote: Build bot with the issue is now online and failing as expected, merging this revert to get in green (we hope). https://github.com/llvm/llvm-project/pull/119638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[clang] Switch builtin strings to use string tables (PR #118734)

2024-12-13 Thread Chandler Carruth via cfe-commits
chandlerc wrote: I see the build bot up and with the original failure, going to merge the revert to hopefully make sure it goes green after that. https://github.com/llvm/llvm-project/pull/118734 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [clang-tidy][doc] align the title style in clang-tidy/index.rst (PR #119938)

2024-12-13 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-sie-win` running on `sie-win-worker` while building `clang-tools-extra` at step 7 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/46/builds/9200

[clang] [Clang-REPL] Fix crash during `__run_exit_handlers` with dynamic libraries. (PR #117475)

2024-12-13 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: @SahilPatidar, could you help us with this? https://github.com/llvm/llvm-project/pull/117475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang-REPL] Fix crash during `__run_exit_handlers` with dynamic libraries. (PR #117475)

2024-12-13 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev edited https://github.com/llvm/llvm-project/pull/117475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang-REPL] Fix crash during `__run_exit_handlers` with dynamic libraries. (PR #117475)

2024-12-13 Thread Vassil Vassilev via cfe-commits
@@ -0,0 +1,20 @@ +// REQUIRES: host-supports-jit, x86_64-linux + +// RUN: rm -rf %t +// RUN: mkdir -p %t +// +// RUN: split-file %s %t +// +// RUN: %clang++ -std=c++20 -fPIC -c %t/vec.cpp -o %t/vec.o +// RUN: %clang++ -shared %t/vec.o -o %t/vec.so vgvassilev wrote

[clang] Switch builtin strings to use string tables (PR #118734)

2024-12-13 Thread Chandler Carruth via cfe-commits
chandlerc wrote: > That was a mistake. I originally was going to update the build bot to a later > version of Visual Studio as while it wouldn't match our internal > configuration, it was still useful to have some Windows coverage of the > components we build/test. I then changed my mind and w

[clang] [clang][bytecode] Fix some shift edge cases (PR #119895)

2024-12-13 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-aarch64-linux-bootstrap-msan` running on `sanitizer-buildbot10` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/94/builds/2858 Here is the relev

[clang] [AST] Migrate away from PointerUnion::get (NFC) (PR #119949)

2024-12-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes Note that PointerUnion::get has been soft deprecated in PointerUnion.h: // FIXME: Replace the uses of is(), get() and dyn_cast() with //isa, cast and the llvm::dyn_cast --- Full d

[clang] [AST] Migrate away from PointerUnion::get (NFC) (PR #119949)

2024-12-13 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/119949 Note that PointerUnion::get has been soft deprecated in PointerUnion.h: // FIXME: Replace the uses of is(), get() and dyn_cast() with //isa, cast and the llvm::dyn_cast >From 07399e5edcbd8ac

[clang] [clang][bytecode] Fix some shift edge cases (PR #119895)

2024-12-13 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-aarch64-linux-bootstrap-ubsan` running on `sanitizer-buildbot10` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/85/builds/3323 Here is the rele

[clang] [clang][bytecode] Fix some shift edge cases (PR #119895)

2024-12-13 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-aarch64-linux-bootstrap-asan` running on `sanitizer-buildbot8` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/24/builds/3225 Here is the releva

[clang] [clang][bytecode] Fix some shift edge cases (PR #119895)

2024-12-13 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-armv7-global-isel` running on `linaro-clang-armv7-global-isel` while building `clang` at step 7 "ninja check 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/39/builds/3378 Here is the relev

[clang-tools-extra] [clang-tidy] remove misuse of `getLocalOrGlobal` for non common used options (PR #119948)

2024-12-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Congcong Cai (HerrCai0907) Changes [RFC](https://discourse.llvm.org/t/rfc-global-option-rules-for-clang-tidy/83647) --- Full diff: https://github.com/llvm/llvm-project/pull/119948.diff 7 Files Affected: - (modified) clang-

[clang-tools-extra] [clang-tidy] remove misuse of `getLocalOrGlobal` for non common used options (PR #119948)

2024-12-13 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 created https://github.com/llvm/llvm-project/pull/119948 [RFC](https://discourse.llvm.org/t/rfc-global-option-rules-for-clang-tidy/83647) >From ee7b013a736d775ee1ea12eccce3224e23b743af Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Sat, 14 Dec 2024 14:19:04 +

[clang] Switch builtin strings to use string tables (PR #118734)

2024-12-13 Thread via cfe-commits
dyung wrote: > So, the builder came back up, and is now passing without this landing... > > Here is the first build after it came back up: > https://lab.llvm.org/buildbot/#/builders/46/builds/9173 > > And I went through the output and found a specific test that was failing, and > it seems to

[clang] [clang][bytecode] Fix some shift edge cases (PR #119895)

2024-12-13 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-aarch64-linux-bootstrap-hwasan` running on `sanitizer-buildbot12` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/55/builds/4295 Here is the rel

[clang-tools-extra] [clang-tidy][doc] align the title style in clang-tidy/index.rst (PR #119938)

2024-12-13 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/119938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 2291e5a - [clang-tidy][doc] align the title style in clang-tidy/index.rst (#119938)

2024-12-13 Thread via cfe-commits
Author: Congcong Cai Date: 2024-12-14T14:00:44+08:00 New Revision: 2291e5aa45dc135a5f908032eb31d19ef3570114 URL: https://github.com/llvm/llvm-project/commit/2291e5aa45dc135a5f908032eb31d19ef3570114 DIFF: https://github.com/llvm/llvm-project/commit/2291e5aa45dc135a5f908032eb31d19ef3570114.diff

[clang] [clang][bytecode] Fix some shift edge cases (PR #119895)

2024-12-13 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-aarch64-global-isel` running on `linaro-clang-aarch64-global-isel` while building `clang` at step 7 "ninja check 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/125/builds/4202 Here is the

[clang-tools-extra] [clang-tidy][doc] align the title style in clang-tidy/index.rst (PR #119938)

2024-12-13 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/119938 >From 16ad345cbb84f4d58a0d2c64734d92de9e4efb56 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Sat, 14 Dec 2024 08:09:40 +0800 Subject: [PATCH 1/2] [clang-tidy][doc] align the title style in clang-tidy/in

[clang] [clang][bytecode] Fix some shift edge cases (PR #119895)

2024-12-13 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-win-x-aarch64` running on `as-builder-2` while building `clang` at step 10 "test-check-clang". Full details are available at: https://lab.llvm.org/buildbot/#/builders/193/builds/3970 Here is the relevant piece of

[clang] [clang] Fix crashes when passing VLA to va_arg (PR #119563)

2024-12-13 Thread via cfe-commits
https://github.com/amane-ame updated https://github.com/llvm/llvm-project/pull/119563 From 659eda3ec76b63418f8b621b004728d9d7bf26ad Mon Sep 17 00:00:00 2001 From: amane-ame Date: Wed, 11 Dec 2024 22:17:51 +0800 Subject: [PATCH 1/7] [clang] Fix crashes when passing VLA to va_arg --- clang/lib/

[clang] [clang] Fix crashes when passing VLA to va_arg (PR #119563)

2024-12-13 Thread via cfe-commits
https://github.com/amane-ame updated https://github.com/llvm/llvm-project/pull/119563 From 659eda3ec76b63418f8b621b004728d9d7bf26ad Mon Sep 17 00:00:00 2001 From: amane-ame Date: Wed, 11 Dec 2024 22:17:51 +0800 Subject: [PATCH 1/7] [clang] Fix crashes when passing VLA to va_arg --- clang/lib/

[clang] a6636ce - Revert "[clang][bytecode] Fix some shift edge cases (#119895)"

2024-12-13 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-12-14T06:28:12+01:00 New Revision: a6636ce4d124176856c3913d4bf6c3ceff1f5a1f URL: https://github.com/llvm/llvm-project/commit/a6636ce4d124176856c3913d4bf6c3ceff1f5a1f DIFF: https://github.com/llvm/llvm-project/commit/a6636ce4d124176856c3913d4bf6c3ceff1f5a1f.diff LO

[clang] [clang][bytecode] Fix some shift edge cases (PR #119895)

2024-12-13 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-armv8-quick` running on `linaro-clang-armv8-quick` while building `clang` at step 5 "ninja check 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/154/builds/9018 Here is the relevant piece of

[clang] [clang][bytecode] Fix some shift edge cases (PR #119895)

2024-12-13 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-aarch64-quick` running on `linaro-clang-aarch64-quick` while building `clang` at step 5 "ninja check 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/65/builds/9344 Here is the relevant piec

[clang] [clang][bytecode] Fix some shift edge cases (PR #119895)

2024-12-13 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/119895 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 49c2207 - [clang][bytecode] Fix some shift edge cases (#119895)

2024-12-13 Thread via cfe-commits
Author: Timm Baeder Date: 2024-12-14T06:15:56+01:00 New Revision: 49c2207f21c0922aedb6c70471f8ea068977eb30 URL: https://github.com/llvm/llvm-project/commit/49c2207f21c0922aedb6c70471f8ea068977eb30 DIFF: https://github.com/llvm/llvm-project/commit/49c2207f21c0922aedb6c70471f8ea068977eb30.diff L

[clang] Fix double-quotes in diagnostic when attempting to access a ext_vector of bools (PR #118186)

2024-12-13 Thread William Tran-Viet via cfe-commits
https://github.com/smallp-o-p updated https://github.com/llvm/llvm-project/pull/118186 >From 3b7cf6e65bdfedf8d15e393c9c2f819c4ed70386 Mon Sep 17 00:00:00 2001 From: William Tran-Viet Date: Sat, 30 Nov 2024 15:53:32 -0500 Subject: [PATCH 1/3] Fix double-quotes in diagnostic when attempting to ac

[clang] Fix double-quotes in diagnostic when attempting to access a ext_vector of bools (PR #118186)

2024-12-13 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 9edbe566bfaff6af03c309ebbb229e6e9a717de3 805195ccece41dfa2591e7652879b0ded0acc3e9 --e

[clang] Fix double-quotes in diagnostic when attempting to access a ext_vector of bools (PR #118186)

2024-12-13 Thread William Tran-Viet via cfe-commits
https://github.com/smallp-o-p edited https://github.com/llvm/llvm-project/pull/118186 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix double-quotes in diagnostic when attempting to access a ext_vector of bools (PR #118186)

2024-12-13 Thread William Tran-Viet via cfe-commits
https://github.com/smallp-o-p updated https://github.com/llvm/llvm-project/pull/118186 >From 3b7cf6e65bdfedf8d15e393c9c2f819c4ed70386 Mon Sep 17 00:00:00 2001 From: William Tran-Viet Date: Sat, 30 Nov 2024 15:53:32 -0500 Subject: [PATCH 1/3] Fix double-quotes in diagnostic when attempting to ac

[clang] Fix double-quotes in diagnostic when attempting to access a ext_vector of bools (PR #118186)

2024-12-13 Thread William Tran-Viet via cfe-commits
https://github.com/smallp-o-p updated https://github.com/llvm/llvm-project/pull/118186 >From 3b7cf6e65bdfedf8d15e393c9c2f819c4ed70386 Mon Sep 17 00:00:00 2001 From: William Tran-Viet Date: Sat, 30 Nov 2024 15:53:32 -0500 Subject: [PATCH 1/3] Fix double-quotes in diagnostic when attempting to ac

[clang] [webkit.UncountedLambdaCapturesChecker] Detect protectedThis pattern. (PR #119932)

2024-12-13 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/119932 >From 5c032267f263fb6b7f10d25745d14e63b2f7af59 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Fri, 13 Dec 2024 14:34:39 -0800 Subject: [PATCH 1/3] [webkit.UncountedLambdaCapturesChecker] Detect protectedThis p

[clang-tools-extra] [clang-tidy][doc] align the title style in clang-tidy/index.rst (PR #119938)

2024-12-13 Thread Nicolas van Kempen via cfe-commits
@@ -9,7 +9,7 @@ See also: .. toctree:: :maxdepth: 1 - The list of clang-tidy checks + The List of Clang-Tidy Checks nicovank wrote: Maybe? ```suggestion List of Clang-Tidy Checks ``` https://github.com/llvm/llvm-project/pull/119938

[clang-tools-extra] [clang-tidy][doc] align the title style in clang-tidy/index.rst (PR #119938)

2024-12-13 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank approved this pull request. Ctrl+F -ing for lowercase `clang-tidy` reveals a couple more places where it should maybe be updated: lines 331, 350 and 352 (`` :program:`clang-tidy` ``?). It's very minor anyway. https://github.com/llvm/llvm-project/pull/119938

[clang-tools-extra] [clang-tidy][doc] align the title style in clang-tidy/index.rst (PR #119938)

2024-12-13 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank edited https://github.com/llvm/llvm-project/pull/119938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [webkit.UncountedLambdaCapturesChecker] Detect protectedThis pattern. (PR #119932)

2024-12-13 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/119932 >From 5c032267f263fb6b7f10d25745d14e63b2f7af59 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Fri, 13 Dec 2024 14:34:39 -0800 Subject: [PATCH 1/2] [webkit.UncountedLambdaCapturesChecker] Detect protectedThis p

[clang] [Clang] Fix crash for incompatible types in inline assembly (PR #119098)

2024-12-13 Thread via cfe-commits
https://github.com/AdUhTkJm updated https://github.com/llvm/llvm-project/pull/119098 >From 37b8121ea94fa5fd6ec275caf5984f18f25ba081 Mon Sep 17 00:00:00 2001 From: AdUhTkJm <2292398...@qq.com> Date: Sun, 8 Dec 2024 08:07:59 +0800 Subject: [PATCH] [Clang] Fix crash for incompatible types in inline

[clang] [clang][Driver][Darwin] Optionally use xcselect to find macOS SDK (PR #119670)

2024-12-13 Thread Carlo Cabrera via cfe-commits
https://github.com/carlocab edited https://github.com/llvm/llvm-project/pull/119670 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Driver][Darwin] Optionally use xcselect to find macOS SDK (PR #119670)

2024-12-13 Thread Carlo Cabrera via cfe-commits
@@ -43,8 +43,8 @@ // RUN: %clang -target x86_64-apple-macos10.13 -mlinker-version=520 \ // RUN: -### %t.o 2>&1 \ -// RUN: | FileCheck --check-prefix=NOSDK %s +// RUN: | FileCheck --check-prefix=INFERRED-SDK %s carlocab wrote: I think it does provide som

[clang] Propagate lifetimebound from formal parameters to those in the canonical declaration and use that for analysis (PR #107627)

2024-12-13 Thread via cfe-commits
@@ -3227,6 +3227,41 @@ void Sema::mergeDeclAttributes(NamedDecl *New, Decl *Old, if (!foundAny) New->dropAttrs(); } +template +static unsigned propagateAttribute(ParmVarDecl *toDecl, higher-performance wrote: Done. https://github.com/llvm/llvm-project/pul

[clang] [clang-format] add BinPackLongBracedLists style option (PR #112482)

2024-12-13 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks edited https://github.com/llvm/llvm-project/pull/112482 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] add BinPackLongBracedLists style option (PR #112482)

2024-12-13 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks commented: I think it should be merges with `BinPackArguments` to get an enum * Never * TwentyOrAbove (name is debatable) * Always * (Leave?) https://github.com/llvm/llvm-project/pull/112482 ___ cfe-commits mailing

[clang] [clang-format] add BinPackLongBracedLists style option (PR #112482)

2024-12-13 Thread Björn Schäpers via cfe-commits
@@ -1208,6 +1208,21 @@ struct FormatStyle { /// \version 3.7 bool BinPackArguments; + /// If ``BinPackArguments`` is ``false`` this option can override it if + /// ``true`` when 20 or more items are in a braced initializer list. HazardyKnusperkeks wrote:

[clang] Propagate lifetimebound from formal parameters to those in the canonical declaration and use that for analysis (PR #107627)

2024-12-13 Thread via cfe-commits
@@ -499,6 +499,7 @@ static bool isNormalAssignmentOperator(const FunctionDecl *FD) { } bool implicitObjectParamIsLifetimeBound(const FunctionDecl *FD) { + FD = FD->getMostRecentDecl(); higher-performance wrote: Done. https://github.com/llvm/llvm-project/pu

[clang] Propagate lifetimebound from formal parameters to those in the canonical declaration and use that for analysis (PR #107627)

2024-12-13 Thread via cfe-commits
@@ -3227,6 +3227,41 @@ void Sema::mergeDeclAttributes(NamedDecl *New, Decl *Old, if (!foundAny) New->dropAttrs(); } +template +static unsigned propagateAttribute(ParmVarDecl *toDecl, higher-performance wrote: Done. https://github.com/llvm/llvm-project/pul

[clang] Propagate lifetimebound from formal parameters to those in the canonical declaration and use that for analysis (PR #107627)

2024-12-13 Thread via cfe-commits
https://github.com/higher-performance updated https://github.com/llvm/llvm-project/pull/107627 >From 3764d3e1062c6b748cea1faa9e4bd9628a1a5dea Mon Sep 17 00:00:00 2001 From: higher-performance Date: Fri, 6 Sep 2024 14:16:15 -0400 Subject: [PATCH 1/3] Propagate lifetimebound from formal parameter

[clang] [llvm] UEFI backend for x86_64 (PR #109320)

2024-12-13 Thread yu shan wei via cfe-commits
yushanwei wrote: It's just a format conversion issue,not up to the level of backend. https://github.com/llvm/llvm-project/pull/109320 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Propagate lifetimebound from formal parameters to those in the canonical declaration and use that for analysis (PR #107627)

2024-12-13 Thread via cfe-commits
@@ -3250,26 +3285,17 @@ static void mergeParamDeclAttributes(ParmVarDecl *newDecl, diag::note_carries_dependency_missing_first_decl) << 1/*Param*/; } - if (!oldDecl->hasAttrs()) -return; - - bool foundAny = newDecl->hasAttrs(); - - // Ensure that any movin

[clang] [clang-format] Add AlignAfterOpenBracketOptions (PR #108332)

2024-12-13 Thread Björn Schäpers via cfe-commits
@@ -811,10 +816,11 @@ void ContinuationIndenter::addTokenOnCurrentLine(LineState &State, bool DryRun, if (!Tok.Previous) return true; if (Tok.Previous->isIf()) - return Style.AlignAfterOpenBracket == FormatStyle::BAS_AlwaysBreak; -return !Tok.Previous->i

[clang] [clang-format] Add AlignAfterOpenBracketOptions (PR #108332)

2024-12-13 Thread Björn Schäpers via cfe-commits
@@ -1169,6 +1181,18 @@ template <> struct MappingTraits { IO.mapOptional("WhitespaceSensitiveMacros", Style.WhitespaceSensitiveMacros); +// If AlignAfterOpenBracket was specified but AlignAfterOpenBracketBreak +// was not, initialize the latter f

[clang] [clang-format] Add AlignAfterOpenBracketOptions (PR #108332)

2024-12-13 Thread Björn Schäpers via cfe-commits
@@ -1169,6 +1181,18 @@ template <> struct MappingTraits { IO.mapOptional("WhitespaceSensitiveMacros", Style.WhitespaceSensitiveMacros); +// If AlignAfterOpenBracket was specified but AlignAfterOpenBracketBreak +// was not, initialize the latter f

[clang] [clang-format] Add AlignAfterOpenBracketOptions (PR #108332)

2024-12-13 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks edited https://github.com/llvm/llvm-project/pull/108332 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add AlignAfterOpenBracketOptions (PR #108332)

2024-12-13 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks commented: I don't think this is the way to go, or at least not with this name. How about going the `Custom` way? https://github.com/llvm/llvm-project/pull/108332 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang] [clang-format] Add AlignAfterOpenBracketOptions (PR #108332)

2024-12-13 Thread Björn Schäpers via cfe-commits
@@ -1452,6 +1476,7 @@ FormatStyle getLLVMStyle(FormatStyle::LanguageKind Language) { FormatStyle LLVMStyle; LLVMStyle.AccessModifierOffset = -2; LLVMStyle.AlignAfterOpenBracket = FormatStyle::BAS_Align; + LLVMStyle.AlignAfterOpenBracketBreak = {}; Hazar

[clang-tools-extra] [clang-tidy][doc] align the title style in clang-tidy/index.rst (PR #119938)

2024-12-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Congcong Cai (HerrCai0907) Changes Uppercase each word in title and toctree _Originally posted by @nicovank in https://github.com/llvm/llvm-project/pull/119842#discussion_r1884559775_. --- Full diff: https://github.com/llvm/

[clang] Fix lld link issue for OHOS (PR #118192)

2024-12-13 Thread Nico Weber via cfe-commits
nico wrote: If all other bots are happy, then I'm doing something wrong probably. If you don't mind reverting, it'd be nice since then I can catch other, actual problems, with the bot, but it's not a requirement. https://github.com/llvm/llvm-project/pull/118192

[clang-tools-extra] [clang-tidy][doc] align the title style in clang-tidy/index.rst (PR #119938)

2024-12-13 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 created https://github.com/llvm/llvm-project/pull/119938 Uppercase each word in title and toctree _Originally posted by @nicovank in https://github.com/llvm/llvm-project/pull/119842#discussion_r1884559775_. >From 16ad345cbb84f4d58a0d2c64734d92de9e4efb56 Mon Sep

[clang-tools-extra] [clang-tidy][doc][NFC] extract common global options in doc (PR #119842)

2024-12-13 Thread Congcong Cai via cfe-commits
@@ -10,6 +10,7 @@ See also: :maxdepth: 1 The list of clang-tidy checks + The list of clang-tidy global options Clang-tidy IDE/Editor Integrations Getting Involved External Clang-Tidy Examples HerrCai0907 wrote: I think the root cause

[clang-tools-extra] [clang-tidy][doc][NFC] extract common global options in doc (PR #119842)

2024-12-13 Thread Congcong Cai via cfe-commits
HerrCai0907 wrote: This PR is not in the correct way. see https://discourse.llvm.org/t/rfc-global-option-rules-for-clang-tidy/83647 https://github.com/llvm/llvm-project/pull/119842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[clang-tools-extra] [clang-tidy][doc][NFC] extract common global options in doc (PR #119842)

2024-12-13 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/119842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Propagate lifetimebound from formal parameters to those in the canonical declaration and use that for analysis (PR #107627)

2024-12-13 Thread via cfe-commits
@@ -238,18 +239,13 @@ void Sema::inferLifetimeBoundAttribute(FunctionDecl *FD) { default: break; } -return; higher-performance wrote: Done. https://github.com/llvm/llvm-project/pull/107627 ___ cfe-

[clang] Propagate lifetimebound from formal parameters to those in the canonical declaration and use that for analysis (PR #107627)

2024-12-13 Thread via cfe-commits
@@ -3250,26 +3285,17 @@ static void mergeParamDeclAttributes(ParmVarDecl *newDecl, diag::note_carries_dependency_missing_first_decl) << 1/*Param*/; } - if (!oldDecl->hasAttrs()) -return; - - bool foundAny = newDecl->hasAttrs(); - - // Ensure that any movin

[clang] [llvm] [HLSL] Adding Flatten and Branch if attributes (PR #116331)

2024-12-13 Thread via cfe-commits
https://github.com/joaosaffran updated https://github.com/llvm/llvm-project/pull/116331 >From ae719102cdafe101b3d718a144ed2f3488ecd44f Mon Sep 17 00:00:00 2001 From: Joao Saffran Date: Fri, 25 Oct 2024 17:48:41 + Subject: [PATCH 01/17] adding comments --- clang/include/clang/Basic/Attr.td

[clang] [Clang-REPL] Fix crash during `__run_exit_handlers` with dynamic libraries. (PR #117475)

2024-12-13 Thread Yuxuan Chen via cfe-commits
@@ -0,0 +1,20 @@ +// REQUIRES: host-supports-jit, x86_64-linux + +// RUN: rm -rf %t +// RUN: mkdir -p %t +// +// RUN: split-file %s %t +// +// RUN: %clang++ -std=c++20 -fPIC -c %t/vec.cpp -o %t/vec.o +// RUN: %clang++ -shared %t/vec.o -o %t/vec.so yuxuanchen1997 w

[clang] Add concepts for raw buffers (PR #119643)

2024-12-13 Thread Joshua Batista via cfe-commits
https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/119643 >From cbcdcd37ec82e7bbb5fdd1cf83b093778d4fcf9f Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Wed, 11 Dec 2024 17:02:02 -0800 Subject: [PATCH 1/5] add concepts for raw buffers --- clang/lib/Sema/HLSLExte

[clang] Add concepts for raw buffers (PR #119643)

2024-12-13 Thread Helena Kotas via cfe-commits
@@ -868,8 +868,54 @@ static Expr *constructTypedBufferConstraintExpr(Sema &S, SourceLocation NameLoc, return TypedResExpr; } -static ConceptDecl *constructTypedBufferConceptDecl(Sema &S, -NamespaceDecl *NSD) { +static Expr

[clang] [webkit.UncountedLambdaCapturesChecker] Detect protectedThis pattern. (PR #119932)

2024-12-13 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff dd8d85dba6e8f74a55fb5053107797e21894a0c6 5c032267f263fb6b7f10d25745d14e63b2f7af59 --e

[clang] [webkit.UncountedLambdaCapturesChecker] Detect protectedThis pattern. (PR #119932)

2024-12-13 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Ryosuke Niwa (rniwa) Changes In WebKit, we often capture this as Ref or RefPtr in addition to this itself so that the object lives as long as a capturing lambda stays alive. Detect this pattern and treat it as safe. This PR also makes the

[clang] [webkit.UncountedLambdaCapturesChecker] Detect protectedThis pattern. (PR #119932)

2024-12-13 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/119932 In WebKit, we often capture this as Ref or RefPtr in addition to this itself so that the object lives as long as a capturing lambda stays alive. Detect this pattern and treat it as safe. This PR also makes the ch

[clang] [clang] Fix crashes when passing VLA to va_arg (PR #119563)

2024-12-13 Thread Eli Friedman via cfe-commits
@@ -20,4 +20,7 @@ void vla(int n, ...) __builtin_va_list ap; void *p; p = __builtin_va_arg(ap, typeof (int (*)[++n])); // CHECK: add nsw i32 {{.*}}, 1 + // Don't crash on some undefined behaviors. + p = __builtin_va_arg(ap, typeof (int [++n])); // expected-warning{{sec

[clang] [clang] Fix crashes when passing VLA to va_arg (PR #119563)

2024-12-13 Thread Eli Friedman via cfe-commits
@@ -16538,6 +16538,13 @@ ExprResult Sema::BuildVAArgExpr(SourceLocation BuiltinLoc, << TInfo->getTypeLoc().getSourceRange(); } +if (TInfo->getType()->isVariableArrayType()) { efriedma-quic wrote: This should check for any array type; the issu

[clang] [clang] Fix crashes when passing VLA to va_arg (PR #119563)

2024-12-13 Thread Eli Friedman via cfe-commits
@@ -6121,6 +6121,8 @@ RValue CodeGenFunction::EmitVAArg(VAArgExpr *VE, Address &VAListAddr, VAListAddr = VE->isMicrosoftABI() ? EmitMSVAListRef(VE->getSubExpr()) : EmitVAListRef(VE->getSubExpr()); QualType Ty = VE->getType(); + if (Ty->

[clang] [llvm] [NVPTX] Auto-Upgrade some nvvm.annotations to attributes (PR #119261)

2024-12-13 Thread Shilei Tian via cfe-commits
https://github.com/shiltian edited https://github.com/llvm/llvm-project/pull/119261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Xtensa] Add Xtensa target. (PR #118008)

2024-12-13 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic edited https://github.com/llvm/llvm-project/pull/118008 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Xtensa] Add Xtensa target. (PR #118008)

2024-12-13 Thread Eli Friedman via cfe-commits
@@ -0,0 +1,112 @@ +//===--- Xtensa.h - Declare Xtensa target feature support ---*- C++ -*-===// +// +// The LLVM Compiler Infrastructure +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE

[clang] [Clang][Xtensa] Add Xtensa target. (PR #118008)

2024-12-13 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic approved this pull request. LGTM with one very minor comment https://github.com/llvm/llvm-project/pull/118008 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[clang] [clang] Fix sub-integer __builtin_elementwise_(add|sub)_sat (PR #119423)

2024-12-13 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: If people aren't using the edge cases, they won't notice if we start error'ing out. If they are, it's pretty easy to adapt the code to build with both old and new compilers. A quick GitHub search shows exactly one user of the builtins outside of clang itself, and that co

[clang] [llvm] [NVPTX] Auto-Upgrade some nvvm.annotations to attributes (PR #119261)

2024-12-13 Thread Shilei Tian via cfe-commits
https://github.com/shiltian edited https://github.com/llvm/llvm-project/pull/119261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NVPTX] Auto-Upgrade some nvvm.annotations to attributes (PR #119261)

2024-12-13 Thread Shilei Tian via cfe-commits
@@ -1270,77 +1270,21 @@ exit: ; MODULE: attributes #[[ATTR1:[0-9]+]] = { convergent nocallback nounwind } ; MODULE: attributes #[[ATTR2:[0-9]+]] = { convergent nocallback nofree nounwind willreturn } ; MODULE: attributes #[[ATTR3:[0-9]+]] = { nocallback nofree nosync nounwind

[clang] [HLSL] Codegen for `cbuffer` declarations without embedded arrays or structs (PR #119755)

2024-12-13 Thread Helena Kotas via cfe-commits
https://github.com/hekota edited https://github.com/llvm/llvm-project/pull/119755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NVPTX] Auto-Upgrade some nvvm.annotations to attributes (PR #119261)

2024-12-13 Thread Joseph Huber via cfe-commits
@@ -1270,77 +1270,21 @@ exit: ; MODULE: attributes #[[ATTR1:[0-9]+]] = { convergent nocallback nounwind } ; MODULE: attributes #[[ATTR2:[0-9]+]] = { convergent nocallback nofree nounwind willreturn } ; MODULE: attributes #[[ATTR3:[0-9]+]] = { nocallback nofree nosync nounwind

[clang] [llvm] [NVPTX] Auto-Upgrade some nvvm.annotations to attributes (PR #119261)

2024-12-13 Thread Alex MacLean via cfe-commits
@@ -1270,77 +1270,21 @@ exit: ; MODULE: attributes #[[ATTR1:[0-9]+]] = { convergent nocallback nounwind } ; MODULE: attributes #[[ATTR2:[0-9]+]] = { convergent nocallback nofree nounwind willreturn } ; MODULE: attributes #[[ATTR3:[0-9]+]] = { nocallback nofree nosync nounwind

[clang] [webkit.UncountedLambdaCapturesChecker] Add a fallback for checking lambda captures (PR #119800)

2024-12-13 Thread Ryosuke Niwa via cfe-commits
@@ -61,6 +62,24 @@ class UncountedLambdaCapturesChecker return result && *result; } + bool VisitLambdaExpr(LambdaExpr *L) override { +if (LambdasToIgnore.contains(L)) + return true; +Checker->visitLambdaExpr(L, shouldCheckThis()); +

[clang] [llvm] [NVPTX] Auto-Upgrade some nvvm.annotations to attributes (PR #119261)

2024-12-13 Thread Shilei Tian via cfe-commits
@@ -1270,77 +1270,21 @@ exit: ; MODULE: attributes #[[ATTR1:[0-9]+]] = { convergent nocallback nounwind } ; MODULE: attributes #[[ATTR2:[0-9]+]] = { convergent nocallback nofree nounwind willreturn } ; MODULE: attributes #[[ATTR3:[0-9]+]] = { nocallback nofree nosync nounwind

[clang] [llvm] [NVPTX] Auto-Upgrade some nvvm.annotations to attributes (PR #119261)

2024-12-13 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/119261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NVPTX] Auto-Upgrade some nvvm.annotations to attributes (PR #119261)

2024-12-13 Thread Joseph Huber via cfe-commits
@@ -1270,77 +1270,21 @@ exit: ; MODULE: attributes #[[ATTR1:[0-9]+]] = { convergent nocallback nounwind } ; MODULE: attributes #[[ATTR2:[0-9]+]] = { convergent nocallback nofree nounwind willreturn } ; MODULE: attributes #[[ATTR3:[0-9]+]] = { nocallback nofree nosync nounwind

[clang] 3351b3b - [OpenACC] implement 'detach' clause sema

2024-12-13 Thread via cfe-commits
Author: erichkeane Date: 2024-12-13T13:51:41-08:00 New Revision: 3351b3bf8dcb9aebfa6f491fcbe5a00acbcc3291 URL: https://github.com/llvm/llvm-project/commit/3351b3bf8dcb9aebfa6f491fcbe5a00acbcc3291 DIFF: https://github.com/llvm/llvm-project/commit/3351b3bf8dcb9aebfa6f491fcbe5a00acbcc3291.diff LO

[clang] [Clang-REPL] Fix crash during `__run_exit_handlers` with dynamic libraries. (PR #117475)

2024-12-13 Thread Yuxuan Chen via cfe-commits
@@ -0,0 +1,20 @@ +// REQUIRES: host-supports-jit, x86_64-linux + +// RUN: rm -rf %t +// RUN: mkdir -p %t +// +// RUN: split-file %s %t +// +// RUN: %clang++ -std=c++20 -fPIC -c %t/vec.cpp -o %t/vec.o +// RUN: %clang++ -shared %t/vec.o -o %t/vec.so yuxuanchen1997 w

[clang] [HLSL] Codegen for `cbuffer` declarations without embedded arrays or structs (PR #119755)

2024-12-13 Thread Helena Kotas via cfe-commits
@@ -164,18 +164,18 @@ Decl *SemaHLSL::ActOnStartBuffer(Scope *BufferScope, bool CBuffer, return Result; } -// Calculate the size of a legacy cbuffer type based on +// Calculate the size of a legacy cbuffer type in bytes based on // https://learn.microsoft.com/en-us/window

[clang] [ExtractAPI] reorder the module names in extension symbol graph file names (PR #119925)

2024-12-13 Thread Zixu Wang via cfe-commits
https://github.com/zixu-w approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/119925 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NVPTX] Auto-Upgrade some nvvm.annotations to attributes (PR #119261)

2024-12-13 Thread Alex MacLean via cfe-commits
@@ -1270,77 +1270,21 @@ exit: ; MODULE: attributes #[[ATTR1:[0-9]+]] = { convergent nocallback nounwind } ; MODULE: attributes #[[ATTR2:[0-9]+]] = { convergent nocallback nofree nounwind willreturn } ; MODULE: attributes #[[ATTR3:[0-9]+]] = { nocallback nofree nosync nounwind

[clang] [clang] Generate appropriate assume in presence of libc's memcpy (PR #119704)

2024-12-13 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: On the clang side, we've intentionally ignored the nonnull marking on memcpy and friends for a long time; we made a decision a few years back the optimization wasn't worthwhile compared to the security risk. The updated patch doesn't do anything useful; we can prove the po

[clang] [llvm] Reimplement constrained 'trunc' using operand bundles (PR #118253)

2024-12-13 Thread Kevin P. Neal via cfe-commits
@@ -86,6 +86,43 @@ IRBuilderBase::createCallHelper(Function *Callee, ArrayRef Ops, return CI; } +CallInst *IRBuilderBase::CreateCall(FunctionType *FTy, Value *Callee, +ArrayRef Args, +ArrayRef OpBundles

[clang] [clang][Driver][Darwin] Optionally use xcselect to find macOS SDK (PR #119670)

2024-12-13 Thread Steven Wu via cfe-commits
@@ -43,8 +43,8 @@ // RUN: %clang -target x86_64-apple-macos10.13 -mlinker-version=520 \ // RUN: -### %t.o 2>&1 \ -// RUN: | FileCheck --check-prefix=NOSDK %s +// RUN: | FileCheck --check-prefix=INFERRED-SDK %s cachemeifyoucan wrote: I see. The value of

  1   2   3   4   5   >