[clang] [clang][bytecode] Pass (float) BitWidth to DoBitCast (PR #119119)

2024-12-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes In certain cases (i.e. long double on x86), the bit with we get from the floating point semantics is different than the type size we compute for the BitCast instruction. Pass this along to DoBitCast, so in t

[clang] [clang][bytecode] Pass (float) BitWidth to DoBitCast (PR #119119)

2024-12-07 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/119119 In certain cases (i.e. long double on x86), the bit with we get from the floating point semantics is different than the type size we compute for the BitCast instruction. Pass this along to DoBitCast, so in the

[clang] [clang-format] Reorder TokenAnnotator::canBreakBefore (PR #119044)

2024-12-07 Thread Owen Pan via cfe-commits
@@ -6105,6 +6105,33 @@ bool TokenAnnotator::canBreakBefore(const AnnotatedLine &Line, return false; } + // We only break before r_brace if there was a corresponding break before + // the l_brace, which is tracked by BreakBeforeClosingBrace. + if (Right.is(tok::r_br

[clang] [clang-tools-extra] [clang] Compute accurate begin location for CallExpr with explicit object parameter (PR #117841)

2024-12-07 Thread Timm Baeder via cfe-commits
tbaederr wrote: I didn't check if any tests fail but here's a version where `CallExpr` saves its `BeginLoc` explicitly: http://llvm-compile-time-tracker.com/compare.php?from=416e4cd332c7421b187844ac9aaf6fe28b575a7d&to=0b6e36fe460409aa59958b79766b4f64a31c97e6&stat=instructions:u https://github.

[clang] [clang-format] Reorder TokenAnnotator::canBreakBefore (PR #119044)

2024-12-07 Thread Owen Pan via cfe-commits
@@ -9383,6 +9383,13 @@ TEST_F(FormatTest, AlignsAfterOpenBracket) { "(a, )) &&\n" ");", Style); + verifyFormat("void foo(\n" + "void (*foobarpntr)(\n" +

[clang] [clang-format] Reorder TokenAnnotator::canBreakBefore (PR #119044)

2024-12-07 Thread Owen Pan via cfe-commits
@@ -6105,6 +6105,33 @@ bool TokenAnnotator::canBreakBefore(const AnnotatedLine &Line, return false; } + // We only break before r_brace if there was a corresponding break before + // the l_brace, which is tracked by BreakBeforeClosingBrace. owenca w

[clang] 6b1c357 - [clang-format] Add cmake target clang-format-help to update ClangFormat.rst

2024-12-07 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2024-12-07T22:41:50-08:00 New Revision: 6b1c357acc312961743bef05f99120e7c68b2e25 URL: https://github.com/llvm/llvm-project/commit/6b1c357acc312961743bef05f99120e7c68b2e25 DIFF: https://github.com/llvm/llvm-project/commit/6b1c357acc312961743bef05f99120e7c68b2e25.diff LOG:

[clang-tools-extra] fix parse windows driver and wsl path (PR #119085)

2024-12-07 Thread via cfe-commits
https://github.com/95833 updated https://github.com/llvm/llvm-project/pull/119085 >From 1a37796fbb624a54b00cfff42674fbfa79616f61 Mon Sep 17 00:00:00 2001 From: root <987004...@qq.com> Date: Sun, 8 Dec 2024 01:19:59 +0800 Subject: [PATCH] fix parse windows driver and wsl path --- clang-tools-ex

[clang] [clang][perf-training] Fix profiling with -DCLANG_BOLT=perf (PR #119117)

2024-12-07 Thread Tom Stellard via cfe-commits
https://github.com/tstellar updated https://github.com/llvm/llvm-project/pull/119117 >From 5d13b69039fab7c5960288cead18dc76f5d01f4f Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Thu, 5 Dec 2024 15:01:27 + Subject: [PATCH] [clang][perf-training] Fix profiling with -DCLANG_BOLT=perf This

[clang] [clang][perf-training] Fix profiling with -DCLANG_BOLT=perf (PR #119117)

2024-12-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Tom Stellard (tstellar) Changes This fixes the llvm-support build that generates the profile data. However, I'm wondering if maybe we should disable llvm-suppot and only run hello-world with -DCLANG_BOLT=perf. The bolt optimizations with

[clang] [clang][perf-training] Fix profiling with -DCLANG_BOLT=perf (PR #119117)

2024-12-07 Thread Tom Stellard via cfe-commits
https://github.com/tstellar created https://github.com/llvm/llvm-project/pull/119117 This fixes the llvm-support build that generates the profile data. However, I'm wondering if maybe we should disable llvm-suppot and only run hello-world with -DCLANG_BOLT=perf. The bolt optimizations with pe

[clang] [Clang] Fix crash for incompatible types in inline assembly (PR #119098)

2024-12-07 Thread Yanzuo Liu via cfe-commits
@@ -365,3 +365,9 @@ void test19(long long x) // FIXME: This case should be supported by codegen, but it fails now. asm ("" : "=rm" (x): "0" (e)); // expected-error {{unsupported inline asm: input with type 'st_size128' (aka 'struct _st_size128') matching output with type '

[clang] [Clang] Fix crash for incompatible types in inline assembly (PR #119098)

2024-12-07 Thread Yanzuo Liu via cfe-commits
@@ -365,3 +365,9 @@ void test19(long long x) // FIXME: This case should be supported by codegen, but it fails now. asm ("" : "=rm" (x): "0" (e)); // expected-error {{unsupported inline asm: input with type 'st_size128' (aka 'struct _st_size128') matching output with type '

[clang] FunctionDecl::getFunctionTypeLoc: ignore function type attributes (PR #118420)

2024-12-07 Thread Robert Dazi via cfe-commits
https://github.com/v01dXYZ updated https://github.com/llvm/llvm-project/pull/118420 >From b6f013097c0003e37800ad13b420e50e3c84511b Mon Sep 17 00:00:00 2001 From: v01dxyz Date: Tue, 3 Dec 2024 04:52:33 +0100 Subject: [PATCH 1/4] FunctionDecl::getFunctionTypeLoc: ignore function type attributes

[clang-tools-extra] [clangd] Handle DeducedTemplateSpecializationType in HeuristicResolver (PR #119107)

2024-12-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangd Author: Nathan Ridge (HighCommander4) Changes Fixes https://github.com/clangd/clangd/issues/2227 --- Full diff: https://github.com/llvm/llvm-project/pull/119107.diff 2 Files Affected: - (modified) clang-tools-extra/clangd/HeuristicResolver.cpp

[clang-tools-extra] [clangd] Handle DeducedTemplateSpecializationType in HeuristicResolver (PR #119107)

2024-12-07 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 created https://github.com/llvm/llvm-project/pull/119107 Fixes https://github.com/clangd/clangd/issues/2227 >From 85307a28e99c596afb47059ddea6f1e574ca55bf Mon Sep 17 00:00:00 2001 From: Nathan Ridge Date: Sat, 7 Dec 2024 22:03:02 -0500 Subject: [PATCH] [clangd

[clang] Fix lld link issue for OHOS (PR #118192)

2024-12-07 Thread Peng Huang via cfe-commits
https://github.com/phuang updated https://github.com/llvm/llvm-project/pull/118192 >From 206f8f800df7e51648ec00b110f2437dca5a3ff6 Mon Sep 17 00:00:00 2001 From: Peng Huang Date: Tue, 15 Oct 2024 13:39:03 -0400 Subject: [PATCH 1/2] Fix build error for OHOS For ohos targets, libclang_rt.builtins

[clang-tools-extra] [clangd] Add clarifying comment about when Dex::IdxContents is populated (PR #118906)

2024-12-07 Thread Nathan Ridge via cfe-commits
@@ -121,6 +121,8 @@ class Dex : public SymbolIndex { llvm::DenseMap, std::vector> Relations; std::shared_ptr KeepAlive; // poor man's move-only std::any // Set of files which were used during this index build. + // Files and IdxContents are only populated for dynamic an

[clang-tools-extra] [clangd] Add clarifying comment about when Dex::IdxContents is populated (PR #118906)

2024-12-07 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 edited https://github.com/llvm/llvm-project/pull/118906 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Document the cases in which Dex::Files and IdxContents are populated (PR #118906)

2024-12-07 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 updated https://github.com/llvm/llvm-project/pull/118906 >From 45311dbceed8d438f2ac0db5019719a7fa32c0bf Mon Sep 17 00:00:00 2001 From: Nathan Ridge Date: Thu, 5 Dec 2024 19:45:25 -0500 Subject: [PATCH] [clangd] Add clarifying comment about when Dex::IdxContents

[clang] [clang-tools-extra] [clang] [Sema] Preserve nested name specifier prefix in MemberPointerType (PR #118236)

2024-12-07 Thread Nathan Ridge via cfe-commits
@@ -5347,13 +5347,16 @@ static TypeSourceInfo *GetFullTypeForDeclarator(TypeProcessingState &state, case NestedNameSpecifier::TypeSpec: case NestedNameSpecifier::TypeSpecWithTemplate: - ClsType = QualType(NNS->getAsType(), 0); + const Type *N

[clang] [Clang] Fix crash for incompatible types in inline assembly (PR #119098)

2024-12-07 Thread via cfe-commits
https://github.com/AdUhTkJm updated https://github.com/llvm/llvm-project/pull/119098 >From 9780af34b63423344783ece5e8ec89de5b815c7f Mon Sep 17 00:00:00 2001 From: AdUhTkJm <2292398...@qq.com> Date: Sun, 8 Dec 2024 08:07:59 +0800 Subject: [PATCH] [Clang] Fix crash for incompatible types in inline

[clang] [clang] [Sema] Add assertion about expected type classes when building MemberPointerType (PR #119105)

2024-12-07 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 created https://github.com/llvm/llvm-project/pull/119105 None >From 6c900d6cc82aab791504a0b96e1e72310d2ec24d Mon Sep 17 00:00:00 2001 From: Nathan Ridge Date: Sat, 7 Dec 2024 20:20:52 -0500 Subject: [PATCH] [clang] [Sema] Add assertion about expected type clas

[clang] [clang-tools-extra] [clang] [Sema] Preserve nested name specifier prefix in MemberPointerType (PR #118236)

2024-12-07 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 closed https://github.com/llvm/llvm-project/pull/118236 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 70c1764 - [clang] [Sema] Preserve nested name specifier prefix in MemberPointerType (#118236)

2024-12-07 Thread via cfe-commits
Author: Nathan Ridge Date: 2024-12-07T20:17:07-05:00 New Revision: 70c1764d7a223b14b38bb394e5020e753be9c869 URL: https://github.com/llvm/llvm-project/commit/70c1764d7a223b14b38bb394e5020e753be9c869 DIFF: https://github.com/llvm/llvm-project/commit/70c1764d7a223b14b38bb394e5020e753be9c869.diff

[clang] [clang-tools-extra] [clang] Compute accurate begin location for CallExpr with explicit object parameter (PR #117841)

2024-12-07 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: > The branch is **not** taken most of the time (it's only taken for calls to > functions with an explicit object argument, which is a C++23 feature), so > perhaps annotating the branch as "unlikely" is sufficient to avoid the > performance regression? Ah, no, that's not

[clang] [Clang] Fix crash for incompatible types in inline assembly (PR #119098)

2024-12-07 Thread via cfe-commits
https://github.com/AdUhTkJm updated https://github.com/llvm/llvm-project/pull/119098 >From 8269073360f882daba9d9334ea8f2b6436fe9253 Mon Sep 17 00:00:00 2001 From: AdUhTkJm <2292398...@qq.com> Date: Sun, 8 Dec 2024 08:07:59 +0800 Subject: [PATCH] [Clang] Fix crash for incompatible types in inline

[clang] cb61a5e - [clang-format] Fix an assertion failure in RemoveSemicolon (#117472)

2024-12-07 Thread via cfe-commits
Author: Owen Pan Date: 2024-12-07T16:47:35-08:00 New Revision: cb61a5e4209beef64b0a3b621c16010c53ed323a URL: https://github.com/llvm/llvm-project/commit/cb61a5e4209beef64b0a3b621c16010c53ed323a DIFF: https://github.com/llvm/llvm-project/commit/cb61a5e4209beef64b0a3b621c16010c53ed323a.diff LOG:

[clang] [clang-format] Fix an assertion failure in RemoveSemicolon (PR #117472)

2024-12-07 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/117472 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang] Compute accurate begin location for CallExpr with explicit object parameter (PR #117841)

2024-12-07 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: > It looks like this causes a significant compile-time regression: > https://llvm-compile-time-tracker.com/compare.php?from=2b855dd97092e2178ac5c470a804a17ec440d7e5&to=9ccde12f5eeb91152900082a2ae839e2a9702b31&stat=instructions:u > (Maybe most clearly seen during clang boot

[clang] Switch builtin strings to use string tables (PR #118734)

2024-12-07 Thread Chandler Carruth via cfe-commits
@@ -68,23 +69,156 @@ enum ID { FirstTSBuiltin }; +// The info used to represent each builtin. struct Info { - llvm::StringLiteral Name; - const char *Type, *Attributes; - const char *Features; + // Rather than store pointers to the string literals describing these four

[clang] Switch builtin strings to use string tables (PR #118734)

2024-12-07 Thread Chandler Carruth via cfe-commits
https://github.com/chandlerc commented: > Fails to build with GCC: Doh, I had hoped GCC would support this. Anyways, fixed back to just suppress the diagnostic with Clang. Did some builds with GCC and everything seems fine, and it doesn't seem like we're GCC warning clean these days anyways.

[clang] Switch builtin strings to use string tables (PR #118734)

2024-12-07 Thread Chandler Carruth via cfe-commits
https://github.com/chandlerc edited https://github.com/llvm/llvm-project/pull/118734 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix crash for incompatible types in inline assembly (PR #119098)

2024-12-07 Thread via cfe-commits
https://github.com/AdUhTkJm updated https://github.com/llvm/llvm-project/pull/119098 >From 9f5c3334a580243f2812824dab4ab15aa80ddfec Mon Sep 17 00:00:00 2001 From: AdUhTkJm <2292398...@qq.com> Date: Sun, 8 Dec 2024 08:07:59 +0800 Subject: [PATCH] [Clang] Fix crash for incompatible types in inline

[clang-tools-extra] [clangd] Re-land "support outgoing calls in call hierarchy" (PR #117673)

2024-12-07 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: > I would appreciate confirmation that this will indeed be possible with the > upcoming **clangd** changes. Yes, the returned data is sufficient for clients to implement either of the above presentations. https://github.com/llvm/llvm-project/pull/117673 _

[clang] [docs] Add a more detailed description in CXString.h. (PR #119090)

2024-12-07 Thread via cfe-commits
@@ -46,6 +46,9 @@ typedef struct { /** * Retrieve the character data associated with the given string. + * + * The caller shouldn't free the returned string data, and the returned string + * data shouldn't be accessed after the \c CXString disposed. iseki0 wr

[clang] [Clang] Fix crash for incompatible types in inline assembly (PR #119098)

2024-12-07 Thread via cfe-commits
https://github.com/AdUhTkJm updated https://github.com/llvm/llvm-project/pull/119098 >From 26bb776fcd750df11a4940899869f59035f78a79 Mon Sep 17 00:00:00 2001 From: AdUhTkJm <2292398...@qq.com> Date: Sun, 8 Dec 2024 08:07:59 +0800 Subject: [PATCH] [Clang] Fix crash for incompatible types in inline

[clang] [Clang] Fix crash for incompatible types in inline assembly (PR #119098)

2024-12-07 Thread via cfe-commits
https://github.com/AdUhTkJm updated https://github.com/llvm/llvm-project/pull/119098 >From 84cd85c3c09482276cbe971f9e11b65673d55db4 Mon Sep 17 00:00:00 2001 From: AdUhTkJm <2292398...@qq.com> Date: Sun, 8 Dec 2024 08:07:59 +0800 Subject: [PATCH] [Clang] Fix crash for incompatible types in inline

[clang] [ubsan] Improve lowering of @llvm.allow.ubsan.check (PR #119013)

2024-12-07 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/119013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 7787328 - [ubsan] Improve lowering of @llvm.allow.ubsan.check (#119013)

2024-12-07 Thread via cfe-commits
Author: Vitaly Buka Date: 2024-12-07T16:12:58-08:00 New Revision: 7787328dd64c750c7acf30b86b31f0d7166c8f27 URL: https://github.com/llvm/llvm-project/commit/7787328dd64c750c7acf30b86b31f0d7166c8f27 DIFF: https://github.com/llvm/llvm-project/commit/7787328dd64c750c7acf30b86b31f0d7166c8f27.diff L

[clang] [Clang] Fix crash for incompatible types in inline assembly (PR #119098)

2024-12-07 Thread via cfe-commits
https://github.com/AdUhTkJm updated https://github.com/llvm/llvm-project/pull/119098 >From 367261c3b9d8bf80ba39ae296d30f53bff2a2d4b Mon Sep 17 00:00:00 2001 From: AdUhTkJm <2292398...@qq.com> Date: Sun, 8 Dec 2024 07:04:11 +0800 Subject: [PATCH] [Clang] Fix crash for incompatible types in inline

[clang] Switch builtin strings to use string tables (PR #118734)

2024-12-07 Thread Chandler Carruth via cfe-commits
https://github.com/chandlerc updated https://github.com/llvm/llvm-project/pull/118734 >From 73a0b5c796881d1e52f8336eb69f678fd4c9f4c4 Mon Sep 17 00:00:00 2001 From: Chandler Carruth Date: Thu, 28 Nov 2024 09:56:40 + Subject: [PATCH 1/5] Switch builtin strings to use string tables MIME-Versio

[clang] [docs] Add a more detailed description in CXString.h. (PR #119090)

2024-12-07 Thread Saleem Abdulrasool via cfe-commits
@@ -46,6 +46,9 @@ typedef struct { /** * Retrieve the character data associated with the given string. + * + * The caller shouldn't free the returned string data, and the returned string + * data shouldn't be accessed after the \c CXString disposed. compnerd

[clang] [Clang] Fix crash for incompatible types in inline assembly (PR #119098)

2024-12-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (AdUhTkJm) Changes Fixed issue #118892. --- Full diff: https://github.com/llvm/llvm-project/pull/119098.diff 2 Files Affected: - (modified) clang/lib/Sema/SemaStmtAsm.cpp (+1) - (added) clang/test/Sema/inline-asm-incompatible-type

[clang] [Clang] Fix crash for incompatible types in inline assembly (PR #119098)

2024-12-07 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [Clang] Fix crash for incompatible types in inline assembly (PR #119098)

2024-12-07 Thread via cfe-commits
https://github.com/AdUhTkJm created https://github.com/llvm/llvm-project/pull/119098 Fixed issue #118892. >From 367261c3b9d8bf80ba39ae296d30f53bff2a2d4b Mon Sep 17 00:00:00 2001 From: AdUhTkJm <2292398...@qq.com> Date: Sun, 8 Dec 2024 07:04:11 +0800 Subject: [PATCH] [Clang] Fix crash for incomp

[clang] [NFC][ubsan] Pre-commit test with missed optimization (PR #119012)

2024-12-07 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/119012 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ubsan] Improve lowering of @llvm.allow.ubsan.check (PR #119013)

2024-12-07 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/119013 >From d66671a29061f80df52e4d4b7a2b6ce1de5cae27 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Fri, 6 Dec 2024 11:18:20 -0800 Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20change?= =?U

[clang] [ubsan] Improve lowering of @llvm.allow.ubsan.check (PR #119013)

2024-12-07 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/119013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 66f9448 - [NFC][ubsan] Pre-commit test with missed optimization (#119012)

2024-12-07 Thread via cfe-commits
Author: Vitaly Buka Date: 2024-12-07T14:50:19-08:00 New Revision: 66f9448b4b14a117141a3efd014e1240b30b741f URL: https://github.com/llvm/llvm-project/commit/66f9448b4b14a117141a3efd014e1240b30b741f DIFF: https://github.com/llvm/llvm-project/commit/66f9448b4b14a117141a3efd014e1240b30b741f.diff L

[clang] [clang][transformer] Allow usage of applyFirst with rewriteDescendants (PR #117658)

2024-12-07 Thread via cfe-commits
SherAndrei wrote: @5chmidti, @carlosgalvezp, @PiotrZSL, can anyone please review suggested changes or maybe help find who can additionally review them? The author of the code under question -- @ymand, is absent for over a week https://github.com/llvm/llvm-project/pull/117658 __

[clang] [llvm] [openmp] [OpenMP] Use generic IR for the OpenMP DeviceRTL (PR #119091)

2024-12-07 Thread via cfe-commits
ronlieb wrote: > @ronlieb This will probably conflict a lot with downstream, should probably > wait until I've talked it over with others before trying to merge it in AOMP. yes please , lets wait until internal monday mtg to discuss. also i would like to help with some precommit performance te

[clang] [llvm] [openmp] [OpenMP] Use generic IR for the OpenMP DeviceRTL (PR #119091)

2024-12-07 Thread Joseph Huber via cfe-commits
jhuber6 wrote: @ronlieb This will probably conflict a lot with downstream, should probably wait until I've talked it over with others before trying to merge it in AOMP. https://github.com/llvm/llvm-project/pull/119091 ___ cfe-commits mailing list cfe-

[clang] [llvm] [openmp] [OpenMP] Use generic IR for the OpenMP DeviceRTL (PR #119091)

2024-12-07 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/119091 >From 4c710e49eea97e542b97e0b5e78b7915acd32383 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Sat, 7 Dec 2024 13:47:23 -0600 Subject: [PATCH 1/4] [OpenMP] Use generic IR for the OpenMP DeviceRTL Summary: We

[clang] [clang-format] add BinPackLongBracedLists style option (PR #112482)

2024-12-07 Thread Gedare Bloom via cfe-commits
https://github.com/gedare updated https://github.com/llvm/llvm-project/pull/112482 >From b61cb81d93e6fb137af282a4f2f0ebf151c2543c Mon Sep 17 00:00:00 2001 From: Gedare Bloom Date: Tue, 15 Oct 2024 23:55:49 -0600 Subject: [PATCH 1/3] [clang-format] add BinPackLongBracedLists style option The us

[clang] [llvm] [openmp] [OpenMP] Use generic IR for the OpenMP DeviceRTL (PR #119091)

2024-12-07 Thread Shilei Tian via cfe-commits
https://github.com/shiltian approved this pull request. it seems like there are some test failures but I think the PR looks good https://github.com/llvm/llvm-project/pull/119091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[clang] [clang-format] add BinPackLongBracedLists style option (PR #112482)

2024-12-07 Thread Gedare Bloom via cfe-commits
https://github.com/gedare updated https://github.com/llvm/llvm-project/pull/112482 >From 59770d0e915b2cb50b89c2c98ed20f7d9170d744 Mon Sep 17 00:00:00 2001 From: Gedare Bloom Date: Tue, 15 Oct 2024 23:55:49 -0600 Subject: [PATCH 1/3] [clang-format] add BinPackLongBracedLists style option The us

[clang] [clang-format] add BinPackLongBracedLists style option (PR #112482)

2024-12-07 Thread Gedare Bloom via cfe-commits
https://github.com/gedare updated https://github.com/llvm/llvm-project/pull/112482 >From 9fb82b16dfea2115431219bd9915d18eff081805 Mon Sep 17 00:00:00 2001 From: Gedare Bloom Date: Tue, 15 Oct 2024 23:55:49 -0600 Subject: [PATCH 1/3] [clang-format] add BinPackLongBracedLists style option The us

[clang] [clang-format] add BinPackLongBracedLists style option (PR #112482)

2024-12-07 Thread Gedare Bloom via cfe-commits
@@ -3398,6 +3401,21 @@ struct FormatStyle { /// \version 3.7 unsigned MaxEmptyLinesToKeep; + /// If ``BinPackArguments`` is ``false`` this option can override it if + /// ``true`` when 20 or more items are in a braced initializer list. + /// \code + ///BinPackLongB

[clang] [PAC][clang] Add new features to pauthtest ABI (PR #113150)

2024-12-07 Thread Daniil Kovalev via cfe-commits
https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/113150 >From 74814fd9424853399196b7d1e73f6171b0f1980b Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Mon, 21 Oct 2024 10:58:04 +0300 Subject: [PATCH] [PAC][clang] Add new features to pauthtest ABI Enable init/fi

[clang] Fix lld link issue for OHOS (PR #118192)

2024-12-07 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 6568ceb9fa1c49383b2fa102a04fd8fd3af01491 206f8f800df7e51648ec00b110f2437dca5a3ff6 --e

[clang] [rtsan] Add `verify_interceptors` flag to docs (PR #119074)

2024-12-07 Thread via cfe-commits
https://github.com/davidtrevelyan approved this pull request. https://github.com/llvm/llvm-project/pull/119074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] add BinPackLongBracedLists style option (PR #112482)

2024-12-07 Thread Björn Schäpers via cfe-commits
@@ -3398,6 +3401,21 @@ struct FormatStyle { /// \version 3.7 unsigned MaxEmptyLinesToKeep; + /// If ``BinPackArguments`` is ``false`` this option can override it if + /// ``true`` when 20 or more items are in a braced initializer list. + /// \code + ///BinPackLongB

[clang] [llvm] [openmp] [OpenMP] Use generic IR for the OpenMP DeviceRTL (PR #119091)

2024-12-07 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/119091 >From 4c710e49eea97e542b97e0b5e78b7915acd32383 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Sat, 7 Dec 2024 13:47:23 -0600 Subject: [PATCH 1/3] [OpenMP] Use generic IR for the OpenMP DeviceRTL Summary: We

[clang] [llvm] [openmp] [OpenMP] Use generic IR for the OpenMP DeviceRTL (PR #119091)

2024-12-07 Thread Joseph Huber via cfe-commits
jhuber6 wrote: @hidekisaito Might be relevant to your patch. https://github.com/llvm/llvm-project/pull/119091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

2024-12-07 Thread Björn Schäpers via cfe-commits
@@ -11077,6 +11077,157 @@ TEST_F(FormatTest, WrapsTemplateDeclarationsWithComments) { Style); } +TEST_F(FormatTest, BreakBeforeTemplateClose) { HazardyKnusperkeks wrote: I want to see some lambdas and template usages (not declarations). https://github

[clang] [llvm] [OpenMP] Use generic IR for the OpenMP DeviceRTL (PR #119091)

2024-12-07 Thread Shilei Tian via cfe-commits
shiltian wrote: Worth a bullet point in release note, both clang and openmp/offload. https://github.com/llvm/llvm-project/pull/119091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [OpenMP] Use generic IR for the OpenMP DeviceRTL (PR #119091)

2024-12-07 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 3f458cd9abbf99cddcded076b5e7b4049607b7b4 0df55740f2010c531ee4f96cc0f34aa1b8cea749 --e

[clang] [llvm] [openmp] [OpenMP] Use generic IR for the OpenMP DeviceRTL (PR #119091)

2024-12-07 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/119091 >From 4c710e49eea97e542b97e0b5e78b7915acd32383 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Sat, 7 Dec 2024 13:47:23 -0600 Subject: [PATCH 1/3] [OpenMP] Use generic IR for the OpenMP DeviceRTL Summary: We

[clang] [llvm] [OpenMP] Use generic IR for the OpenMP DeviceRTL (PR #119091)

2024-12-07 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > I like this method, but just out of curiosity, did we use anything in AMDGPU > implementation that has target dependent lowering in the front end? If not, > this is totally fine I'd say. We used to use the `__AMDGCN_WAVEFRONT_SIZE` but that was removed for unrelated reasons.

[clang] [clang-format] Fix an assertion failure in RemoveSemicolon (PR #117472)

2024-12-07 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks approved this pull request. https://github.com/llvm/llvm-project/pull/117472 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [OpenMP] Use generic IR for the OpenMP DeviceRTL (PR #119091)

2024-12-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-offload @llvm/pr-subscribers-clang Author: Joseph Huber (jhuber6) Changes Summary: We previously built this for every single architecture to deal with incompatibility. This patch updates it to use the 'generic' IR that `libc` and other projects use. Who

[clang] [llvm] [OpenMP] Use generic IR for the OpenMP DeviceRTL (PR #119091)

2024-12-07 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/119091 >From 4c710e49eea97e542b97e0b5e78b7915acd32383 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Sat, 7 Dec 2024 13:47:23 -0600 Subject: [PATCH 1/2] [OpenMP] Use generic IR for the OpenMP DeviceRTL Summary: We

[clang] [llvm] [OpenMP] Use generic IR for the OpenMP DeviceRTL (PR #119091)

2024-12-07 Thread Shilei Tian via cfe-commits
shiltian wrote: > > I like this method, but just out of curiosity, did we use anything in > > AMDGPU implementation that has target dependent lowering in the front end? > > If not, this is totally fine I'd say. > > We used to use the `__AMDGCN_WAVEFRONT_SIZE` but that was removed for > unrela

[clang] [llvm] [OpenMP] Use generic IR for the OpenMP DeviceRTL (PR #119091)

2024-12-07 Thread Joseph Huber via cfe-commits
@@ -74,49 +72,53 @@ static int32_t nvptx_parallel_reduce_nowait(void *reduce_data, uint32_t NumThreads = omp_get_num_threads(); if (NumThreads == 1) return 1; -/* - * This reduce function handles reduction within a team. It handles - * parallel regions in b

[clang] [llvm] [OpenMP] Use generic IR for the OpenMP DeviceRTL (PR #119091)

2024-12-07 Thread Shilei Tian via cfe-commits
@@ -74,49 +72,53 @@ static int32_t nvptx_parallel_reduce_nowait(void *reduce_data, uint32_t NumThreads = omp_get_num_threads(); if (NumThreads == 1) return 1; -/* - * This reduce function handles reduction within a team. It handles - * parallel regions in b

[clang] [llvm] [OpenMP] Use generic IR for the OpenMP DeviceRTL (PR #119091)

2024-12-07 Thread Shilei Tian via cfe-commits
https://github.com/shiltian commented: I like this method, but just out of curiosity, did we use anything in AMDGPU implementation that has target dependent lowering in the front end? If not, this is totally fine I'd say. https://github.com/llvm/llvm-project/pull/119091 ___

[clang] [llvm] [OpenMP] Use generic IR for the OpenMP DeviceRTL (PR #119091)

2024-12-07 Thread Shilei Tian via cfe-commits
@@ -141,20 +109,21 @@ set(bc_flags -c -foffload-lto -std=c++17 -fvisibility=hidden # first create an object target add_library(omptarget.devicertl.all_objs OBJECT IMPORTED) -function(compileDeviceRTLLibrary target_cpu target_name target_triple) +function(compileDeviceRTLLibra

[clang] [llvm] [OpenMP] Use generic IR for the OpenMP DeviceRTL (PR #119091)

2024-12-07 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/119091 >From 4c710e49eea97e542b97e0b5e78b7915acd32383 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Sat, 7 Dec 2024 13:47:23 -0600 Subject: [PATCH 1/2] [OpenMP] Use generic IR for the OpenMP DeviceRTL Summary: We

[clang] [llvm] [OpenMP] Use generic IR for the OpenMP DeviceRTL (PR #119091)

2024-12-07 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/119091 >From 4c710e49eea97e542b97e0b5e78b7915acd32383 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Sat, 7 Dec 2024 13:47:23 -0600 Subject: [PATCH] [OpenMP] Use generic IR for the OpenMP DeviceRTL Summary: We prev

[clang] [llvm] [OpenMP] Use generic IR for the OpenMP DeviceRTL (PR #119091)

2024-12-07 Thread Joseph Huber via cfe-commits
@@ -141,20 +109,21 @@ set(bc_flags -c -foffload-lto -std=c++17 -fvisibility=hidden # first create an object target add_library(omptarget.devicertl.all_objs OBJECT IMPORTED) -function(compileDeviceRTLLibrary target_cpu target_name target_triple) +function(compileDeviceRTLLibra

[clang] [llvm] [OpenMP] Use generic IR for the OpenMP DeviceRTL (PR #119091)

2024-12-07 Thread Shilei Tian via cfe-commits
@@ -141,20 +109,21 @@ set(bc_flags -c -foffload-lto -std=c++17 -fvisibility=hidden # first create an object target add_library(omptarget.devicertl.all_objs OBJECT IMPORTED) -function(compileDeviceRTLLibrary target_cpu target_name target_triple) +function(compileDeviceRTLLibra

[clang] [llvm] [OpenMP] Use generic IR for the OpenMP DeviceRTL (PR #119091)

2024-12-07 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/119091 Summary: We previously built this for every single architecture to deal with incompatibility. This patch updates it to use the 'generic' IR that `libc` and other projects use. Who knows if this will have any side

[clang] [docs] Add a more detailed description in CXString.h. (PR #119090)

2024-12-07 Thread via cfe-commits
https://github.com/iseki0 created https://github.com/llvm/llvm-project/pull/119090 Emmm... Maybe I'm splitting hairs. But I really think the paragraph should be more detailed. The orginal document makes me confused. Do I take the ownership of the string data? Here I don't refer the `clang_dis

[clang] [docs] Add a more detailed description in CXString.h. (PR #119090)

2024-12-07 Thread via cfe-commits
iseki0 wrote: @egorzhdan @compnerd Thank you. https://github.com/llvm/llvm-project/pull/119090 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [docs] Add a more detailed description in CXString.h. (PR #119090)

2024-12-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: iseki (iseki0) Changes Emmm... Maybe I'm splitting hairs. But I really think the paragraph should be more detailed. The orginal document makes me confused. Do I take the ownership of the string data? Here I don't refer the `clang_dispose

[clang] [docs] Add a more detailed description in CXString.h. (PR #119090)

2024-12-07 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] clang/AMDGPU: Set amdgpu-max-num-workgroups to disable Y/Z by default (PR #119009)

2024-12-07 Thread Shilei Tian via cfe-commits
shiltian wrote: > So this is wrong. It was correct for openmp. Even OpenMP is discussing to introduce multi-dim support, though in LLVM I already implemented it as an extension. :-) https://github.com/llvm/llvm-project/pull/119009 ___ cfe-commits mai

[clang-tools-extra] fix parse windows driver and wsl path (PR #119085)

2024-12-07 Thread via cfe-commits
https://github.com/95833 updated https://github.com/llvm/llvm-project/pull/119085 >From 1a37796fbb624a54b00cfff42674fbfa79616f61 Mon Sep 17 00:00:00 2001 From: root <987004...@qq.com> Date: Sun, 8 Dec 2024 01:19:59 +0800 Subject: [PATCH] fix parse windows driver and wsl path --- clang-tools-ex

[clang-tools-extra] fix parse windows driver and wsl path (PR #119085)

2024-12-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangd Author: None (95833) Changes path::is_absolute(Path, path::Style::windows) will return false leading to an error when the path appears in the root driver form, for example: path-mappings=E:=/mnt/e This modification also potentially provides su

[clang-tools-extra] fix parse windows driver and wsl path (PR #119085)

2024-12-07 Thread via cfe-commits
https://github.com/95833 edited https://github.com/llvm/llvm-project/pull/119085 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] fix parse windows driver and wsl path (PR #119085)

2024-12-07 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang-tools-extra] fix parse windows driver and wsl path (PR #119085)

2024-12-07 Thread via cfe-commits
https://github.com/95833 created https://github.com/llvm/llvm-project/pull/119085 path::is_absolute(Path, path::Style::windows) will return false leading to an error when the path appears in the root driver form, for example: path-mappings=E:=/mnt/e This modification also potentially provide

[clang] [clang-tools-extra] [Clang] Warning as error Array Comparisons from C++26 (PR #118872)

2024-12-07 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper closed https://github.com/llvm/llvm-project/pull/118872 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] constexpr built-in elementwise add_sat function. (PR #119082)

2024-12-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (c8ef) Changes Part of #51787. This patch adds constexpr support for the built-in elementwise add_sat function. --- Full diff: https://github.com/llvm/llvm-project/pull/119082.diff 6 Files Affected: - (modified) clang/docs/Languag

[clang] [clang] constexpr built-in elementwise add_sat function. (PR #119082)

2024-12-07 Thread via cfe-commits
https://github.com/c8ef ready_for_review https://github.com/llvm/llvm-project/pull/119082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] constexpr built-in elementwise add_sat function. (PR #119082)

2024-12-07 Thread via cfe-commits
https://github.com/c8ef edited https://github.com/llvm/llvm-project/pull/119082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] constexpr built-in elementwise add_sat function. (PR #119082)

2024-12-07 Thread via cfe-commits
https://github.com/c8ef edited https://github.com/llvm/llvm-project/pull/119082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 3f458cd - [Clang] Warning as error Array Comparisons from C++26 (#118872)

2024-12-07 Thread via cfe-commits
Author: Amr Hesham Date: 2024-12-07T18:28:09+01:00 New Revision: 3f458cd9abbf99cddcded076b5e7b4049607b7b4 URL: https://github.com/llvm/llvm-project/commit/3f458cd9abbf99cddcded076b5e7b4049607b7b4 DIFF: https://github.com/llvm/llvm-project/commit/3f458cd9abbf99cddcded076b5e7b4049607b7b4.diff LO

[clang] Draft (PR #119082)

2024-12-07 Thread via cfe-commits
https://github.com/c8ef created https://github.com/llvm/llvm-project/pull/119082 None >From 2af0eb663a106b712a3c9eb2028dc35014884708 Mon Sep 17 00:00:00 2001 From: c8ef Date: Sun, 8 Dec 2024 01:11:51 +0800 Subject: [PATCH] constexpr elementwise add_sat --- clang/docs/LanguageExtensions.rst

  1   2   >