[clang] [llvm] [RISCV][VCIX] Add vcix_state to GNU inline assembly register set (PR #106914)

2024-09-29 Thread Michal Terepeta via cfe-commits
michalt wrote: Thanks everyone! 😄 Is there anything still blocking us from merging this? https://github.com/llvm/llvm-project/pull/106914 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[clang] [Clang][Sema] Refactor collection of multi-level template argument lists (PR #106585)

2024-09-29 Thread Younan Zhang via cfe-commits
zyn0217 wrote: @sdkrystian do you plan to reland this patch in some other form these days? I'm going to restart my cwg 2369 work on top of it. https://github.com/llvm/llvm-project/pull/106585 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[clang] [clang] Fix the local parameter of void type inside the `Requires` expression. (PR #109831)

2024-09-29 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 approved this pull request. Makes sense to me. Thanks Please wait for other folks a day or two in case they have different opinions. https://github.com/llvm/llvm-project/pull/109831 ___ cfe-commits mailing list cfe-commits@l

[clang] [clang] Fix the local parameter of void type inside the `Requires` expression. (PR #109831)

2024-09-29 Thread via cfe-commits
https://github.com/c8ef updated https://github.com/llvm/llvm-project/pull/109831 >From 9c112e7f88be2fc71f33ce4332d2ea500e479963 Mon Sep 17 00:00:00 2001 From: c8ef Date: Tue, 24 Sep 2024 16:48:39 + Subject: [PATCH 1/6] require void --- clang/lib/Sema/SemaExprCXX.cpp| 11

[clang] [clang] Fix the local parameter of void type inside the `Requires` expression. (PR #109831)

2024-09-29 Thread via cfe-commits
c8ef wrote: > There should be a release note :) Done. https://github.com/llvm/llvm-project/pull/109831 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix the local parameter of void type inside the `Requires` expression. (PR #109831)

2024-09-29 Thread via cfe-commits
@@ -0,0 +1,15 @@ +// RUN: %clang -fsyntax-only -std=c++2a -Xclang -verify %s c8ef wrote: Done. https://github.com/llvm/llvm-project/pull/109831 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[clang] [clang] Fix the local parameter of void type inside the `Requires` expression. (PR #109831)

2024-09-29 Thread via cfe-commits
@@ -9509,6 +9509,19 @@ Sema::ActOnStartRequiresExpr(SourceLocation RequiresKWLoc, PushDeclContext(BodyScope, Body); for (ParmVarDecl *Param : LocalParameters) { +if (Param->getType()->isVoidType()) { + if (LocalParameters.size() > 1) { +Diag(Param->getBeg

[clang] [clang] Redeclare function templates instances per primary template (PR #110387)

2024-09-29 Thread Younan Zhang via cfe-commits
@@ -0,0 +1,84 @@ +// RUN: %clang_cc1 -fsyntax-only -verify -std=c++26 %s zyn0217 wrote: nit: we might want to move it to an existing file (so we don't have tests scattered around), but it's up to you if you feel the test is long enough to have a new file. http

[clang] [clang] Redeclare function templates instances per primary template (PR #110387)

2024-09-29 Thread Younan Zhang via cfe-commits
@@ -2146,9 +2147,15 @@ Decl *TemplateDeclInstantiator::VisitFunctionDecl( FunctionDecl *SpecFunc = FunctionTemplate->findSpecialization(Innermost, InsertPos); -// If we already have a function template specialization, return it. zyn0217 wrote: n

[clang] [clang] Redeclare function templates instances per primary template (PR #110387)

2024-09-29 Thread Younan Zhang via cfe-commits
@@ -2146,9 +2147,15 @@ Decl *TemplateDeclInstantiator::VisitFunctionDecl( FunctionDecl *SpecFunc = FunctionTemplate->findSpecialization(Innermost, InsertPos); -// If we already have a function template specialization, return it. -if (SpecFunc) - return S

[clang] [clang] Redeclare function templates instances per primary template (PR #110387)

2024-09-29 Thread Younan Zhang via cfe-commits
@@ -3949,28 +3949,15 @@ TemplateDeductionResult Sema::FinishTemplateArgumentDeduction( TemplateArgumentList::CreateCopy(Context, CanonicalBuilder); Info.reset(SugaredDeducedArgumentList, CanonicalDeducedArgumentList); + FunctionTemplate = FunctionTemplate->getMostRec

[clang] [clang] Redeclare function templates instances per primary template (PR #110387)

2024-09-29 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/110387 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Redeclare function templates instances per primary template (PR #110387)

2024-09-29 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 commented: Thanks! https://github.com/llvm/llvm-project/pull/110387 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix the local parameter of void type inside the `Requires` expression. (PR #109831)

2024-09-29 Thread via cfe-commits
https://github.com/c8ef updated https://github.com/llvm/llvm-project/pull/109831 >From 9c112e7f88be2fc71f33ce4332d2ea500e479963 Mon Sep 17 00:00:00 2001 From: c8ef Date: Tue, 24 Sep 2024 16:48:39 + Subject: [PATCH 1/6] require void --- clang/lib/Sema/SemaExprCXX.cpp| 11

[clang] [clang] Fix the local parameter of void type inside the `Requires` expression. (PR #109831)

2024-09-29 Thread via cfe-commits
https://github.com/c8ef updated https://github.com/llvm/llvm-project/pull/109831 >From 9c112e7f88be2fc71f33ce4332d2ea500e479963 Mon Sep 17 00:00:00 2001 From: c8ef Date: Tue, 24 Sep 2024 16:48:39 + Subject: [PATCH 1/5] require void --- clang/lib/Sema/SemaExprCXX.cpp| 11

[clang] [llvm] [InstrPGO] Instrument sampling profile based cold function (PR #109837)

2024-09-29 Thread Lei Wang via cfe-commits
https://github.com/wlei-llvm edited https://github.com/llvm/llvm-project/pull/109837 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [PAC] Fix address discrimination for type info vtable pointers (PR #102199)

2024-09-29 Thread Daniil Kovalev via cfe-commits
kovdan01 wrote: @efriedma-quic I've switched to `replaceInitializer`, thanks for suggestion! Now we construct `GV` with `nullptr` as initializer and `llvm::ConstantStruct::getTypeForElements(Fields)` as type, and then replace the initializer with `llvm::ConstantStruct::getAnon(Fields)`. See 5

[clang] [clang-format] Fix a bug in annotating angles containing FatArrow (PR #108671)

2024-09-29 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet edited https://github.com/llvm/llvm-project/pull/108671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [PAC] Fix address discrimination for type info vtable pointers (PR #102199)

2024-09-29 Thread Daniil Kovalev via cfe-commits
https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/102199 >From 0c20bcdf35f3c15024986da50cafb2a8c155e3cf Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Tue, 6 Aug 2024 20:48:02 +0300 Subject: [PATCH 1/3] [PAC] Fix address discrimination for type info vtable poin

[clang] [Clang] Instantiate the correct lambda call operator (PR #110446)

2024-09-29 Thread Chuanqi Xu via cfe-commits
@@ -1631,9 +1631,32 @@ static bool allLookupResultsAreTheSame(const DeclContext::lookup_result &R) { static NamedDecl* getLambdaCallOperatorHelper(const CXXRecordDecl &RD) { if (!RD.isLambda()) return nullptr; DeclarationName Name = -RD.getASTContext().DeclarationNames

[clang] [Clang] Instantiate the correct lambda call operator (PR #110446)

2024-09-29 Thread via cfe-commits
@@ -1631,9 +1631,32 @@ static bool allLookupResultsAreTheSame(const DeclContext::lookup_result &R) { static NamedDecl* getLambdaCallOperatorHelper(const CXXRecordDecl &RD) { if (!RD.isLambda()) return nullptr; DeclarationName Name = -RD.getASTContext().DeclarationNames

[clang-tools-extra] [clangd] [C++20] [Modules] Support code complete for C++20 modules (PR #110083)

2024-09-29 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 closed https://github.com/llvm/llvm-project/pull/110083 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] af47038 - [clangd] [C++20] [Modules] Support code complete for C++20 modules (#110083)

2024-09-29 Thread via cfe-commits
Author: Chuanqi Xu Date: 2024-09-30T13:07:41+08:00 New Revision: af47038fb1385435eb315cc1962464f19ea9e186 URL: https://github.com/llvm/llvm-project/commit/af47038fb1385435eb315cc1962464f19ea9e186 DIFF: https://github.com/llvm/llvm-project/commit/af47038fb1385435eb315cc1962464f19ea9e186.diff LO

[clang-tools-extra] [clangd] [C++20] [Modules] Support code complete for C++20 modules (PR #110083)

2024-09-29 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 updated https://github.com/llvm/llvm-project/pull/110083 >From e35e600159c99736de7d2bc735c738002f592988 Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Thu, 26 Sep 2024 13:43:51 +0800 Subject: [PATCH 1/6] [clangd] [C++20] [Modules] Support code complete for C++20

[clang] [HLSL][SPIRV] Fix calling convention for call in entry function. (PR #110275)

2024-09-29 Thread Michal Paszkowski via cfe-commits
michalpaszkowski wrote: LGTM! I think changing the mangling for Vulkan is the best solution here. One small comment, later on if/when you decide to use SPIRVBuiltins.cpp/.td for lowering builtins, there might be additional changes needed. The lookup function expects Itanium demangled strings.

[clang] [HLSL][SPIRV] Fix calling convention for call in entry function. (PR #110275)

2024-09-29 Thread Michal Paszkowski via cfe-commits
@@ -316,6 +316,11 @@ class LLVM_LIBRARY_VISIBILITY SPIRVTargetInfo : public BaseSPIRVTargetInfo { SizeType = TargetInfo::UnsignedInt; resetDataLayout("e-i64:64-v16:16-v24:32-v32:32-v48:64-" "v96:128-v192:256-v256:256-v512:512-v1024:1024-G1"); + +

[clang] [clang-format] Handle template closer followed by empty paretheses (PR #110408)

2024-09-29 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/110408 >From 27135c008868cc4f17b7ca5ff9c2af9c2fc02135 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Sat, 28 Sep 2024 22:42:56 -0700 Subject: [PATCH 1/2] [clang-format] Handle template closer followed by empty parethese

[clang-tools-extra] [clangd] [C++20] [Modules] Support code complete for C++20 modules (PR #110083)

2024-09-29 Thread kadir çetinkaya via cfe-commits
@@ -52,6 +52,11 @@ struct CodeCompleteOptions { /// For example, private members are usually inaccessible. bool IncludeIneligibleResults = false; + /// Force sema to load decls from preamble even if an index is provided. + /// This is helpful for cases the index can't pr

[clang-tools-extra] [clangd] [C++20] [Modules] Support code complete for C++20 modules (PR #110083)

2024-09-29 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet approved this pull request. thanks! https://github.com/llvm/llvm-project/pull/110083 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] [C++20] [Modules] Support code complete for C++20 modules (PR #110083)

2024-09-29 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet edited https://github.com/llvm/llvm-project/pull/110083 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in annotating angles containing FatArrow (PR #108671)

2024-09-29 Thread kadir çetinkaya via cfe-commits
@@ -243,14 +244,16 @@ class AnnotatingParser { // operator that was misinterpreted because we are parsing template // parameters. // FIXME: This is getting out of hand, write a decent parser. - if (InExpr && !Line.startsWith(tok::kw_template) && + if

[clang-tools-extra] [clang-tidy][modernize-use-starts-ends-with] Add support for two ends_with patterns (PR #105366)

2024-09-29 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank closed https://github.com/llvm/llvm-project/pull/105366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][modernize-use-starts-ends-with] Add support for two ends_with patterns (PR #110448)

2024-09-29 Thread Nicolas van Kempen via cfe-commits
nicovank wrote: Oops, for this reason my software duplicated #105366 when I meant to just rebase and ping. Sorry. Closing the old one. https://github.com/llvm/llvm-project/pull/110448 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[clang-tools-extra] [clang-tidy][modernize-use-starts-ends-with] Add support for two ends_with patterns (PR #110448)

2024-09-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Nicolas van Kempen (nicovank) Changes Add support for the following two patterns: ``` haystack.compare(haystack.length() - needle.length(), needle.length(), needle) == 0; haystack.rfind(needle) == (haystack.size() - needle.size()); `

[clang-tools-extra] [clang-tidy][modernize-use-starts-ends-with] Add support for two ends_with patterns (PR #110448)

2024-09-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Nicolas van Kempen (nicovank) Changes Add support for the following two patterns: ``` haystack.compare(haystack.length() - needle.length(), needle.length(), needle) == 0; haystack.rfind(needle) == (haystack.size() - needle.siz

[clang-tools-extra] [clang-tidy][modernize-use-starts-ends-with] Add support for two ends_with patterns (PR #110448)

2024-09-29 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank created https://github.com/llvm/llvm-project/pull/110448 Add support for the following two patterns: ``` haystack.compare(haystack.length() - needle.length(), needle.length(), needle) == 0; haystack.rfind(needle) == (haystack.size() - needle.size()); ``` >From 7f0

[clang] [llvm] [HLSL] Replace `element_type*` handles in HLSLExternalSemaSource with `__hlsl_resource_t` builtin type (PR #110079)

2024-09-29 Thread Helena Kotas via cfe-commits
https://github.com/hekota closed https://github.com/llvm/llvm-project/pull/110079 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e20bf28 - [HLSL] Replace `element_type*` handles in HLSLExternalSemaSource with `__hlsl_resource_t` builtin type (#110079)

2024-09-29 Thread via cfe-commits
Author: Helena Kotas Date: 2024-09-29T20:41:54-07:00 New Revision: e20bf28987b74ed4f4b48f49f4506d0659c09bed URL: https://github.com/llvm/llvm-project/commit/e20bf28987b74ed4f4b48f49f4506d0659c09bed DIFF: https://github.com/llvm/llvm-project/commit/e20bf28987b74ed4f4b48f49f4506d0659c09bed.diff

[clang-tools-extra] [clangd] [C++20] [Modules] Support code complete for C++20 modules (PR #110083)

2024-09-29 Thread Chuanqi Xu via cfe-commits
@@ -2122,7 +2125,10 @@ clang::CodeCompleteOptions CodeCompleteOptions::getClangCompleteOpts() const { // When an is used, Sema is responsible for completing the main file, // the index can provide results from the preamble. // Tell Sema not to deserialize the preamble to

[clang-tools-extra] [clangd] [C++20] [Modules] Support code complete for C++20 modules (PR #110083)

2024-09-29 Thread Chuanqi Xu via cfe-commits
@@ -52,6 +52,9 @@ struct CodeCompleteOptions { /// For example, private members are usually inaccessible. bool IncludeIneligibleResults = false; + /// Whether the experimental modules support are enabled. + bool ExperimentalModulesSupport = false; Chuanq

[clang-tools-extra] [clangd] [C++20] [Modules] Support code complete for C++20 modules (PR #110083)

2024-09-29 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 updated https://github.com/llvm/llvm-project/pull/110083 >From e35e600159c99736de7d2bc735c738002f592988 Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Thu, 26 Sep 2024 13:43:51 +0800 Subject: [PATCH 1/5] [clangd] [C++20] [Modules] Support code complete for C++20

[clang-tools-extra] [clangd] [C++20] [Modules] Support code complete for C++20 modules (PR #110083)

2024-09-29 Thread kadir çetinkaya via cfe-commits
@@ -52,6 +52,9 @@ struct CodeCompleteOptions { /// For example, private members are usually inaccessible. bool IncludeIneligibleResults = false; + /// Whether the experimental modules support are enabled. + bool ExperimentalModulesSupport = false; kadirc

[clang-tools-extra] [clangd] [C++20] [Modules] Support code complete for C++20 modules (PR #110083)

2024-09-29 Thread kadir çetinkaya via cfe-commits
@@ -2122,7 +2125,10 @@ clang::CodeCompleteOptions CodeCompleteOptions::getClangCompleteOpts() const { // When an is used, Sema is responsible for completing the main file, // the index can provide results from the preamble. // Tell Sema not to deserialize the preamble to

[clang-tools-extra] [clangd] [C++20] [Modules] Support code complete for C++20 modules (PR #110083)

2024-09-29 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet edited https://github.com/llvm/llvm-project/pull/110083 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] [C++20] [Modules] Support code complete for C++20 modules (PR #110083)

2024-09-29 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet commented: thanks! https://github.com/llvm/llvm-project/pull/110083 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [include-cleaner] Attach Header to AnalysisResults for misisng headers (PR #110272)

2024-09-29 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet closed https://github.com/llvm/llvm-project/pull/110272 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 4ef77d6 - [include-cleaner] Attach Header to AnalysisResults for misisng headers (#110272)

2024-09-29 Thread via cfe-commits
Author: kadir çetinkaya Date: 2024-09-30T04:57:19+02:00 New Revision: 4ef77d61b2ee3054344b50d5f4e3111ce69fffcf URL: https://github.com/llvm/llvm-project/commit/4ef77d61b2ee3054344b50d5f4e3111ce69fffcf DIFF: https://github.com/llvm/llvm-project/commit/4ef77d61b2ee3054344b50d5f4e3111ce69fffcf.dif

[clang-tools-extra] [clang-tidy][NFC] optimize unused using decls performance (PR #110200)

2024-09-29 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank approved this pull request. https://github.com/llvm/llvm-project/pull/110200 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC] optimize unused using decls performance (PR #110200)

2024-09-29 Thread Nicolas van Kempen via cfe-commits
@@ -25,6 +25,13 @@ AST_MATCHER_P(DeducedTemplateSpecializationType, refsToTemplatedDecl, return false; } +AST_MATCHER_P(Type, getTagDecl, clang::ast_matchers::internal::Matcher, nicovank wrote: `asTagDecl` maybe? https://github.com/llvm/llvm-project/pull

[clang] [flang] [llvm] [mlir] Make Ownership of MachineModuleInfo in Its Wrapper Pass External (PR #110443)

2024-09-29 Thread Matin Raayai via cfe-commits
https://github.com/matinraayai updated https://github.com/llvm/llvm-project/pull/110443 >From 6a78a683f4834049c07f9672c358dcbb44ac14e7 Mon Sep 17 00:00:00 2001 From: matinraayai <30674652+matinraa...@users.noreply.github.com> Date: Sun, 29 Sep 2024 16:54:50 -0400 Subject: [PATCH 01/17] Made MMIW

[clang] [Clang][Sema] Retain the expanding index for unevaluated type constraints (PR #109518)

2024-09-29 Thread Younan Zhang via cfe-commits
zyn0217 wrote: Slightly ping https://github.com/llvm/llvm-project/pull/109518 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add code completion for C++20 keywords. (PR #107982)

2024-09-29 Thread Younan Zhang via cfe-commits
zyn0217 wrote: > I am not sure which section I should add in clang/docs/ReleaseNotes.rst? > There isn't a section related to code completion. @16bit-ykiko There is an individual file for clang-tools-extras `clang-tools-extra/docs/ReleaseNotes.rst` which covers changes in clangd. See also http

[clang] [llvm] [HLSL] Replace `element_type*` handles in HLSLExternalSemaSource with `__hlsl_resource_t` builtin type (PR #110079)

2024-09-29 Thread Helena Kotas via cfe-commits
https://github.com/hekota updated https://github.com/llvm/llvm-project/pull/110079 >From 970aab0a930e38dfd266c01065112602bb274a5e Mon Sep 17 00:00:00 2001 From: Helena Kotas Date: Wed, 25 Sep 2024 15:48:18 -0700 Subject: [PATCH 1/5] [HLSL] Allow resource type attributes only on __hlsl_resource

[clang] [clang][HIP] Don't use the OpenCLKernel CC when targeting AMDGCNSPIRV (PR #110447)

2024-09-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Alex Voicu (AlexVlx) Changes When compiling HIP source for AMDGCN flavoured SPIR-V that is expected to be consumed by the ROCm HIP RT, it's not desirable to set the OpenCL Kernel CC on `__global__` functions. On one hand, this is not an O

[clang] [clang][HIP] Don't use the OpenCLKernel CC when targeting AMDGCNSPIRV (PR #110447)

2024-09-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Alex Voicu (AlexVlx) Changes When compiling HIP source for AMDGCN flavoured SPIR-V that is expected to be consumed by the ROCm HIP RT, it's not desirable to set the OpenCL Kernel CC on `__global__` functions. On one hand, this is

[clang] [clang][HIP] Don't use the OpenCLKernel CC when targeting AMDGCNSPIRV (PR #110447)

2024-09-29 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx created https://github.com/llvm/llvm-project/pull/110447 When compiling HIP source for AMDGCN flavoured SPIR-V that is expected to be consumed by the ROCm HIP RT, it's not desirable to set the OpenCL Kernel CC on `__global__` functions. On one hand, this is not an Op

[clang] [llvm] [SPARC] Align i128 to 16 bytes in SPARC datalayouts (PR #106951)

2024-09-29 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-solaris11-sparcv9` running on `solaris11-sparcv9` while building `clang,llvm` at step 5 "ninja check 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/13/builds/2592 Here is the relevant piec

[clang] [llvm] [SPARC] Align i128 to 16 bytes in SPARC datalayouts (PR #106951)

2024-09-29 Thread via cfe-commits
https://github.com/koachan closed https://github.com/llvm/llvm-project/pull/106951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] dbad963 - [SPARC] Align i128 to 16 bytes in SPARC datalayouts (#106951)

2024-09-29 Thread via cfe-commits
Author: Koakuma Date: 2024-09-30T08:32:33+07:00 New Revision: dbad963a69fd7b16c6838f81b61167fbf00a413c URL: https://github.com/llvm/llvm-project/commit/dbad963a69fd7b16c6838f81b61167fbf00a413c DIFF: https://github.com/llvm/llvm-project/commit/dbad963a69fd7b16c6838f81b61167fbf00a413c.diff LOG:

[clang] [Clang] Instantiate the correct lambda call operator (PR #110446)

2024-09-29 Thread Chuanqi Xu via cfe-commits
@@ -1631,9 +1631,32 @@ static bool allLookupResultsAreTheSame(const DeclContext::lookup_result &R) { static NamedDecl* getLambdaCallOperatorHelper(const CXXRecordDecl &RD) { if (!RD.isLambda()) return nullptr; DeclarationName Name = -RD.getASTContext().DeclarationNames

[clang] [Clang] Instantiate the correct lambda call operator (PR #110446)

2024-09-29 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/110446 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Instantiate the correct lambda call operator (PR #110446)

2024-09-29 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 commented: Thanks for the analysis! Further more, if we want to fix such issue better, may be we need to refactor the current `lookup` method into a version that understands modules, then we can do better lookup with modules. This is helpful for https://github.co

[clang] [Clang] Instantiate the correct lambda call operator (PR #110446)

2024-09-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: None (Sirraide) Changes See issue #110401. This is a very tentative fix for the following issue: when a lambda’s class type is merged across modules (e.g. because it is defined in a template in the GMF of some module `A`, and som

[clang] [Clang] Instantiate the correct lambda call operator (PR #110446)

2024-09-29 Thread via cfe-commits
https://github.com/Sirraide created https://github.com/llvm/llvm-project/pull/110446 See issue #110401. This is a very tentative fix for the following issue: when a lambda’s class type is merged across modules (e.g. because it is defined in a template in the GMF of some module `A`, and some o

[clang] [flang] [llvm] [mlir] Make Ownership of MachineModuleInfo in Its Wrapper Pass External (PR #110443)

2024-09-29 Thread Matin Raayai via cfe-commits
https://github.com/matinraayai updated https://github.com/llvm/llvm-project/pull/110443 >From 6a78a683f4834049c07f9672c358dcbb44ac14e7 Mon Sep 17 00:00:00 2001 From: matinraayai <30674652+matinraa...@users.noreply.github.com> Date: Sun, 29 Sep 2024 16:54:50 -0400 Subject: [PATCH 01/16] Made MMIW

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-09-29 Thread via cfe-commits
https://github.com/joaosaffran edited https://github.com/llvm/llvm-project/pull/109331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-09-29 Thread via cfe-commits
https://github.com/joaosaffran edited https://github.com/llvm/llvm-project/pull/109331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Thin6 (PR #110431)

2024-09-29 Thread Kyungwoo Lee via cfe-commits
https://github.com/kyulee-com updated https://github.com/llvm/llvm-project/pull/110431 >From c1a0219457a3c162d7fa6b9d70750ba7a040d9f2 Mon Sep 17 00:00:00 2001 From: Kyungwoo Lee Date: Fri, 26 Apr 2024 20:02:52 -0700 Subject: [PATCH 1/5] [ThinLTO][NFC] Prep for two-codegen rounds --- clang/lib

[clang] [flang] [llvm] Make Ownership of MachineModuleInfo in Its Wrapper Pass External (PR #110443)

2024-09-29 Thread Matin Raayai via cfe-commits
https://github.com/matinraayai updated https://github.com/llvm/llvm-project/pull/110443 >From 6a78a683f4834049c07f9672c358dcbb44ac14e7 Mon Sep 17 00:00:00 2001 From: matinraayai <30674652+matinraa...@users.noreply.github.com> Date: Sun, 29 Sep 2024 16:54:50 -0400 Subject: [PATCH 01/15] Made MMIW

[clang] [flang] [llvm] Make Ownership of MachineModuleInfo in Its Wrapper Pass External (PR #110443)

2024-09-29 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 76f2fa8163e406914996b7c3bce127ee585fd3f7 737685e4e09c3be8a56566e436a7ae28771e2dcc --e

[clang] [llvm] Thin6 (PR #110431)

2024-09-29 Thread Kyungwoo Lee via cfe-commits
https://github.com/kyulee-com updated https://github.com/llvm/llvm-project/pull/110431 >From c1a0219457a3c162d7fa6b9d70750ba7a040d9f2 Mon Sep 17 00:00:00 2001 From: Kyungwoo Lee Date: Fri, 26 Apr 2024 20:02:52 -0700 Subject: [PATCH 1/5] [ThinLTO][NFC] Prep for two-codegen rounds --- clang/lib

[clang] [flang] [llvm] Make Ownership of MachineModuleInfo in Its Wrapper Pass External (PR #110443)

2024-09-29 Thread via cfe-commits
github-actions[bot] wrote: ⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo. Please turn off [Keep my email addresses private](https://github.com/settings/emails) setting in your account. See [LLVM Discourse](https://discourse.llvm.org/t/hidden-email

[clang] [flang] [llvm] Make Ownership of MachineModuleInfo in Its Wrapper Pass External (PR #110443)

2024-09-29 Thread Matin Raayai via cfe-commits
https://github.com/matinraayai created https://github.com/llvm/llvm-project/pull/110443 Following up on discussions in #105541, this PR is the first part of #105541, which removes ownership of the `llvm::MachineModuleInfoWrapperPass` over its encapsulated `llvm::MachineModuleInfo`, allowing be

[clang] [llvm] Thin6 (PR #110431)

2024-09-29 Thread Kyungwoo Lee via cfe-commits
https://github.com/kyulee-com updated https://github.com/llvm/llvm-project/pull/110431 >From c1a0219457a3c162d7fa6b9d70750ba7a040d9f2 Mon Sep 17 00:00:00 2001 From: Kyungwoo Lee Date: Fri, 26 Apr 2024 20:02:52 -0700 Subject: [PATCH 1/5] [ThinLTO][NFC] Prep for two-codegen rounds --- clang/lib

[clang] [llvm] Thin6 (PR #110431)

2024-09-29 Thread Kyungwoo Lee via cfe-commits
https://github.com/kyulee-com updated https://github.com/llvm/llvm-project/pull/110431 >From c1a0219457a3c162d7fa6b9d70750ba7a040d9f2 Mon Sep 17 00:00:00 2001 From: Kyungwoo Lee Date: Fri, 26 Apr 2024 20:02:52 -0700 Subject: [PATCH 1/5] [ThinLTO][NFC] Prep for two-codegen rounds --- clang/lib

[clang] [Clang] Fix 'counted_by' for nested struct pointers (PR #110437)

2024-09-29 Thread Jan Hendrik Farr via cfe-commits
https://github.com/Cydox updated https://github.com/llvm/llvm-project/pull/110437 >From e1ef2156ed4a0f3ccd1d6dca97faa014284e4605 Mon Sep 17 00:00:00 2001 From: Jan Hendrik Farr Date: Sun, 29 Sep 2024 21:38:13 +0200 Subject: [PATCH] [Clang] Fix 'counted_by' for nested struct pointers Fixes #110

[clang] [Clang] Fix 'counted_by' for nested struct pointers (PR #110437)

2024-09-29 Thread Jan Hendrik Farr via cfe-commits
Cydox wrote: @bwendling please review https://github.com/llvm/llvm-project/pull/110437 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix 'counted_by' for nested struct pointers (PR #110437)

2024-09-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Jan Hendrik Farr (Cydox) Changes Fixes #110385 Fix counted_by attribute for cases where the flexible array member is accessed through struct pointer inside another struct: struct variable { int a; int b; i

[clang] [Clang] Fix 'counted_by' for nested struct pointers (PR #110437)

2024-09-29 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [Clang] Fix 'counted_by' for nested struct pointers (PR #110437)

2024-09-29 Thread Jan Hendrik Farr via cfe-commits
https://github.com/Cydox created https://github.com/llvm/llvm-project/pull/110437 Fixes #110385 Fix counted_by attribute for cases where the flexible array member is accessed through struct pointer inside another struct: struct variable { int a; int b; int length;

[clang] [llvm] workflows/release-binaries: Use static ZSTD on macOS (PR #109909)

2024-09-29 Thread Keith Smiley via cfe-commits
https://github.com/keith updated https://github.com/llvm/llvm-project/pull/109909 >From 4676d022d971ef1623b83a2731ce94572905d6ad Mon Sep 17 00:00:00 2001 From: Keith Smiley Date: Wed, 25 Sep 2024 05:38:04 + Subject: [PATCH 1/4] workflows/release-binaries: Use static ZSTD on macOS On macOS

[clang-tools-extra] [clang-tidy] Create bugprone-bit-cast-pointers check (PR #108083)

2024-09-29 Thread Carlos Galvez via cfe-commits
carlosgalvezp wrote: What about `bugprone-bitwise-pointer-copy`? https://github.com/llvm/llvm-project/pull/108083 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] workflows/release-binaries: Use static ZSTD on macOS (PR #109909)

2024-09-29 Thread Keith Smiley via cfe-commits
keith wrote: I downloaded the binaries from this stage again: https://github.com/user-attachments/assets/bb37ccaa-5f5f-4c99-8491-0ec570cb0a69";> and it looks like this change didn't apply to either of these binaries `build/bin/clang build/tools/clang/stage2-bins/bin/clang`. If it had passed w

[clang] [llvm] workflows/release-binaries: Use static ZSTD on macOS (PR #109909)

2024-09-29 Thread Keith Smiley via cfe-commits
https://github.com/keith updated https://github.com/llvm/llvm-project/pull/109909 >From 8c6c06d0df5a17fd2ff4915c3de63695c18cd8dc Mon Sep 17 00:00:00 2001 From: Keith Smiley Date: Wed, 25 Sep 2024 05:38:04 + Subject: [PATCH 1/4] workflows/release-binaries: Use static ZSTD on macOS On macOS

[clang] [Clang] prevent recovery call expression from proceeding with explicit attributes and undeclared templates (PR #107786)

2024-09-29 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/107786 >From e9948a1004cc2b486a0422d83e88392754e9f7e9 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Mon, 23 Sep 2024 17:17:30 +0300 Subject: [PATCH 1/2] [Clang] prevent recovery call expression from proceeding w

[clang] [Clang] fix overload resolution for object parameters with top-level cv-qualifiers in member functions (PR #110435)

2024-09-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Oleksandr T. (a-tarasyuk) Changes Fixes #100394 --- Full diff: https://github.com/llvm/llvm-project/pull/110435.diff 3 Files Affected: - (modified) clang/docs/ReleaseNotes.rst (+1) - (modified) clang/lib/Sema/SemaOverload.cpp (+3) - (

[clang] [Clang] fix overload resolution for object parameters with top-level cv-qualifiers in member functions (PR #110435)

2024-09-29 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk created https://github.com/llvm/llvm-project/pull/110435 Fixes #100394 >From c52634882631a71fad956a70179b480abf13006a Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sun, 29 Sep 2024 22:01:38 +0300 Subject: [PATCH] [Clang] fix overload resolution for object param

[clang] 6f04e65 - [clang][bytecode] Implement fixed-point shifts (#110429)

2024-09-29 Thread via cfe-commits
Author: Timm Baeder Date: 2024-09-29T20:56:17+02:00 New Revision: 6f04e65c3c62060de18a47ec351d1eedd703126d URL: https://github.com/llvm/llvm-project/commit/6f04e65c3c62060de18a47ec351d1eedd703126d DIFF: https://github.com/llvm/llvm-project/commit/6f04e65c3c62060de18a47ec351d1eedd703126d.diff L

[clang] [clang][bytecode] Implement fixed-point shifts (PR #110429)

2024-09-29 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/110429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Thin6 (PR #110431)

2024-09-29 Thread Kyungwoo Lee via cfe-commits
https://github.com/kyulee-com updated https://github.com/llvm/llvm-project/pull/110431 >From c1a0219457a3c162d7fa6b9d70750ba7a040d9f2 Mon Sep 17 00:00:00 2001 From: Kyungwoo Lee Date: Fri, 26 Apr 2024 20:02:52 -0700 Subject: [PATCH 1/5] [ThinLTO][NFC] Prep for two-codegen rounds --- clang/lib

[clang] [llvm] [SPARC] Align i128 to 16 bytes in SPARC datalayouts (PR #106951)

2024-09-29 Thread Sergei Barannikov via cfe-commits
https://github.com/s-barannikov approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/106951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][readability-container-contains] Fix matching of non-binaryOperator cases (PR #110386)

2024-09-29 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank updated https://github.com/llvm/llvm-project/pull/110386 >From e08eed95020b705f040ba55b70cf8d660b817618 Mon Sep 17 00:00:00 2001 From: Nicolas van Kempen Date: Sun, 29 Sep 2024 14:05:33 -0400 Subject: [PATCH] [clang-tidy][readability-container-contains] Fix matching

[clang-tools-extra] [clang-tidy][readability-container-contains] Fix matching of non-binaryOperator cases (PR #110386)

2024-09-29 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank updated https://github.com/llvm/llvm-project/pull/110386 >From e08eed95020b705f040ba55b70cf8d660b817618 Mon Sep 17 00:00:00 2001 From: Nicolas van Kempen Date: Sun, 29 Sep 2024 14:05:33 -0400 Subject: [PATCH] [clang-tidy][readability-container-contains] Fix matching

[clang] [llvm] Thin6 (PR #110431)

2024-09-29 Thread Kyungwoo Lee via cfe-commits
https://github.com/kyulee-com updated https://github.com/llvm/llvm-project/pull/110431 >From c1a0219457a3c162d7fa6b9d70750ba7a040d9f2 Mon Sep 17 00:00:00 2001 From: Kyungwoo Lee Date: Fri, 26 Apr 2024 20:02:52 -0700 Subject: [PATCH 1/5] [ThinLTO][NFC] Prep for two-codegen rounds --- clang/lib

[clang] [llvm] Thin6 (PR #110431)

2024-09-29 Thread Kyungwoo Lee via cfe-commits
https://github.com/kyulee-com created https://github.com/llvm/llvm-project/pull/110431 None >From c1a0219457a3c162d7fa6b9d70750ba7a040d9f2 Mon Sep 17 00:00:00 2001 From: Kyungwoo Lee Date: Fri, 26 Apr 2024 20:02:52 -0700 Subject: [PATCH 1/5] [ThinLTO][NFC] Prep for two-codegen rounds --- cla

[clang] [clang][bytecode] Implement fixed-point shifts (PR #110429)

2024-09-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/110429.diff 5 Files Affected: - (modified) clang/lib/AST/ByteCode/Compiler.cpp (+4) - (modified) clang/lib/AST/ByteCode/FixedPoint.h (+17) - (mod

[clang] [clang][bytecode] Implement fixed-point shifts (PR #110429)

2024-09-29 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/110429 None >From c3ae3ce5d129f9c2655ea291c57cc3009ed31b01 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sun, 29 Sep 2024 18:38:52 +0200 Subject: [PATCH] [clang][bytecode] Implement fixed-point s

[clang-tools-extra] [clang-tidy] Fix check alphabetical ordering in release notes (PR #110428)

2024-09-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Mike Crowe (mikecrowe) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/110428.diff 1 Files Affected: - (modified) clang-tools-extra/docs/ReleaseNotes.rst (+13-13) ``diff diff --git a/clang-tools-

[clang-tools-extra] [clang-tidy] Fix check alphabetical ordering in release notes (PR #110428)

2024-09-29 Thread Mike Crowe via cfe-commits
https://github.com/mikecrowe created https://github.com/llvm/llvm-project/pull/110428 None >From b1a53281aeed1163233cf4839036bb708d4060c2 Mon Sep 17 00:00:00 2001 From: Mike Crowe Date: Sun, 29 Sep 2024 16:53:27 +0100 Subject: [PATCH] [clang-tidy] Fix check alphabetical ordering in release not

[clang] [Clang] Extend lifetime of temporaries in mem-default-init for P2718R0 (PR #86960)

2024-09-29 Thread via cfe-commits
https://github.com/yronglin edited https://github.com/llvm/llvm-project/pull/86960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >