[clang] [clang-format[NFC] Clean up FormatTestBase and Proto/TextProto tests (PR #108334)

2024-09-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/108334.diff 3 Files Affected: - (modified) clang/unittests/Format/FormatTestBase.h (+7-7) - (modified) clang/unittests/Format/FormatTestProto.cp

[clang] [clang-format[NFC] Clean up FormatTestBase and Proto/TextProto tests (PR #108334)

2024-09-11 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/108334 None >From 556db4b4c5b727cd44aec39d16178720edf77942 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Wed, 11 Sep 2024 23:07:37 -0700 Subject: [PATCH] [clang-format[NFC] Clean up FormatTestBase and Proto/TextProto

[clang-tools-extra] [clang-tidy][readability-container-contains] Extend to any class with contains (PR #107521)

2024-09-11 Thread Nicolas van Kempen via cfe-commits
nicovank wrote: Update, now getting the same hits on llvm-project with/without type checking (553/553), a good indication no true positives are missed. https://github.com/llvm/llvm-project/pull/107521 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang-tools-extra] [clang-tidy][readability-container-contains] Extend to any class with contains (PR #107521)

2024-09-11 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank updated https://github.com/llvm/llvm-project/pull/107521 >From 6fae5b43f1e9227ccd41f67dde66233de1b0ed7b Mon Sep 17 00:00:00 2001 From: Nicolas van Kempen Date: Thu, 12 Sep 2024 01:48:02 -0400 Subject: [PATCH] [clang-tidy][readability-container-contains] Extend to any

[clang-tools-extra] [clang-tidy][readability-container-contains] Extend to any class with contains (PR #107521)

2024-09-11 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank updated https://github.com/llvm/llvm-project/pull/107521 >From 6fae5b43f1e9227ccd41f67dde66233de1b0ed7b Mon Sep 17 00:00:00 2001 From: Nicolas van Kempen Date: Thu, 12 Sep 2024 01:48:02 -0400 Subject: [PATCH] [clang-tidy][readability-container-contains] Extend to any

[clang] [clang-format] Add AlignAfterOpenBracketOptions (PR #108332)

2024-09-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Gedare Bloom (gedare) Changes Introduce sub-options for `AlignAfterOpenBracketBreak` to allow for control of `AlignAfterOpenBracket` with `AlwaysBreak` and `BlockIndent` selectively for `if` conditional statements (as currently supported)

[clang] [clang-format] Add AlignAfterOpenBracketOptions (PR #108332)

2024-09-11 Thread Gedare Bloom via cfe-commits
https://github.com/gedare created https://github.com/llvm/llvm-project/pull/108332 Introduce sub-options for `AlignAfterOpenBracketBreak` to allow for control of `AlignAfterOpenBracket` with `AlwaysBreak` and `BlockIndent` selectively for `if` conditional statements (as currently supported), o

[clang] [clang-tools-extra] [clangd] Collect comments from function definitions into the index (PR #67802)

2024-09-11 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 edited https://github.com/llvm/llvm-project/pull/67802 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clangd] Collect comments from function definitions into the index (PR #67802)

2024-09-11 Thread Nathan Ridge via cfe-commits
@@ -1477,6 +1477,26 @@ TEST_F(SymbolCollectorTest, Documentation) { forCodeCompletion(false; } +TEST_F(SymbolCollectorTest, DocumentationInMain) { HighCommander4 wrote: I'm thinking of it less as "specification", and more as a way

[clang-tools-extra] [clang-tidy][readability-container-contains] Extend to any class with contains (PR #107521)

2024-09-11 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank updated https://github.com/llvm/llvm-project/pull/107521 >From 6d49d5696f22642beecf3d95effbbba79c143306 Mon Sep 17 00:00:00 2001 From: Nicolas van Kempen Date: Thu, 12 Sep 2024 01:07:24 -0400 Subject: [PATCH] [clang-tidy][readability-container-contains] Extend to any

[clang-tools-extra] [clang-tidy][readability-container-contains] Extend to any class with contains (PR #107521)

2024-09-11 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank updated https://github.com/llvm/llvm-project/pull/107521 >From 6d49d5696f22642beecf3d95effbbba79c143306 Mon Sep 17 00:00:00 2001 From: Nicolas van Kempen Date: Thu, 12 Sep 2024 01:07:24 -0400 Subject: [PATCH] [clang-tidy][readability-container-contains] Extend to any

[clang-tools-extra] [clang-tidy][readability-container-contains] Extend to any class with contains (PR #107521)

2024-09-11 Thread Nicolas van Kempen via cfe-commits
nicovank wrote: > ... and is sufficiently visible. I added `isPublic`, I think the false negatives where we are in another private method would be exceedingly rare so I don't think handling that case is necessary. > check if the type of the parameter from the called method and that of the >

[clang-tools-extra] [clang-tidy][readability-container-contains] Extend to any class with contains (PR #107521)

2024-09-11 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank updated https://github.com/llvm/llvm-project/pull/107521 >From 2033e5b44787b89244ccd76ac9422162bcfe8680 Mon Sep 17 00:00:00 2001 From: Nicolas van Kempen Date: Thu, 12 Sep 2024 00:54:39 -0400 Subject: [PATCH] [clang-tidy][readability-container-contains] Extend to any

[clang-tools-extra] [clang-tidy][readability-container-contains] Extend to any class with contains (PR #107521)

2024-09-11 Thread Nicolas van Kempen via cfe-commits
https://github.com/nicovank updated https://github.com/llvm/llvm-project/pull/107521 >From 2033e5b44787b89244ccd76ac9422162bcfe8680 Mon Sep 17 00:00:00 2001 From: Nicolas van Kempen Date: Thu, 12 Sep 2024 00:54:39 -0400 Subject: [PATCH] [clang-tidy][readability-container-contains] Extend to any

[clang] [compiler-rt] Reland [asan][windows] Eliminate the static asan runtime on windows (PR #107899)

2024-09-11 Thread Charlie Barto via cfe-commits
@@ -136,7 +160,7 @@ append_list_if(MINGW "${MINGW_LIBRARIES}" ASAN_DYNAMIC_LIBS) add_compiler_rt_object_libraries(RTAsan_dynamic OS ${SANITIZER_COMMON_SUPPORTED_OS} ARCHS ${ASAN_SUPPORTED_ARCH} - SOURCES ${ASAN_SOURCES} ${ASAN_CXX_SOURCES} + SOURCES ${ASAN_SOURCES} --

[clang-tools-extra] [clang-tidy] add default error message for performance-avoid-endl (PR #107867)

2024-09-11 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/107867 >From 31b01c0cd3fc809e5451853b820d021dd43d16c7 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Mon, 9 Sep 2024 22:32:48 +0800 Subject: [PATCH 1/4] [clang-tidy] add default error message for performance-av

[clang] [llvm] [SanitizerCoverage] Add an option to gate the invocation of the tracing callbacks (PR #108328)

2024-09-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-compiler-rt-sanitizer Author: None (thetruestblue) Changes Implement -sanitizer-coverage-gated-trace-callbacks to gate the invocation of the tracing callbacks based on the value of a global variable, which is stored in a specific section. When this opt

[clang] [llvm] [SanitizerCoverage] Add an option to gate the invocation of the tracing callbacks (PR #108328)

2024-09-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (thetruestblue) Changes Implement -sanitizer-coverage-gated-trace-callbacks to gate the invocation of the tracing callbacks based on the value of a global variable, which is stored in a specific section. When this option is enabled,

[clang] [llvm] [SanitizerCoverage] Add an option to gate the invocation of the tracing callbacks (PR #108328)

2024-09-11 Thread via cfe-commits
https://github.com/thetruestblue created https://github.com/llvm/llvm-project/pull/108328 Implement -sanitizer-coverage-gated-trace-callbacks to gate the invocation of the tracing callbacks based on the value of a global variable, which is stored in a specific section. When this option is enab

[clang] [compiler-rt] Reland [asan][windows] Eliminate the static asan runtime on windows (PR #107899)

2024-09-11 Thread Charlie Barto via cfe-commits
barcharcraz wrote: > This PR seems to have broken ASAN in mingw configurations. The symptoms seem > to be that the ASAN DLL just locks up, hard, when the process is loaded. (Or > more precisely, has entered some infinite loop.) > > I tried attaching to such a hung process with windbg, and it's

[clang] [clang] Don't emit bogus dangling diagnostics when `[[gsl::Owner]]` and `[[clang::lifetimebound]]` are used together. (PR #108280)

2024-09-11 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik commented: Can you add some more details to the summary e.g. "The fix adds an additional check in isGSLOwner() for Owner attribute" or something along those lines. https://github.com/llvm/llvm-project/pull/108280 ___ cfe-comm

[clang] 9469836 - [clang-format][NFC] Minor clean of TokenAnnotatorTest

2024-09-11 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2024-09-11T20:35:13-07:00 New Revision: 94698369e9cc211b4d1e666b82dc5848c40ab5ce URL: https://github.com/llvm/llvm-project/commit/94698369e9cc211b4d1e666b82dc5848c40ab5ce DIFF: https://github.com/llvm/llvm-project/commit/94698369e9cc211b4d1e666b82dc5848c40ab5ce.diff LOG:

[clang-tools-extra] [clang-tidy] Improve documentation of bugprone-pointer-arithmetic-on-polymorphic-object (PR #108324)

2024-09-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra @llvm/pr-subscribers-clang-tidy Author: Mainak Sil (MainakSil) Changes This pull request addresses issue #107831 by improving the documentation for the `bugprone-pointer-arithmetic-on-polymorphic-object` Clang-Tidy check. ### Changes

[clang-tools-extra] [clang-tidy] Improve documentation of bugprone-pointer-arithmetic-on-polymorphic-object (PR #108324)

2024-09-11 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang-tools-extra] [clang-tidy] Improve documentation of bugprone-pointer-arithmetic-on-polymorphic-object (PR #108324)

2024-09-11 Thread Mainak Sil via cfe-commits
https://github.com/MainakSil created https://github.com/llvm/llvm-project/pull/108324 This pull request addresses issue #107831 by improving the documentation for the `bugprone-pointer-arithmetic-on-polymorphic-object` Clang-Tidy check. ### Changes Made: 1. **Fixed Syntax Error**: Corrected th

[clang] [clang][TableGen] Change AttrEmitter to use const RecordKeeper (PR #108269)

2024-09-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Rahul Joshi (jurahul) Changes Change AttrEmitter to use const RecordKeeper. This is a part of effort to have better const correctness in TableGen backends: https://discourse.llvm.org/t/psa-planned-changes-to-tablegen-getallderiveddefiniti

[clang] [clang][TableGen] Change AttrEmitter to use const RecordKeeper (PR #108269)

2024-09-11 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul ready_for_review https://github.com/llvm/llvm-project/pull/108269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Add clang-tidy external examples (PR #106675)

2024-09-11 Thread via cfe-commits
https://github.com/MichelleCDjunaidi updated https://github.com/llvm/llvm-project/pull/106675 >From 08324e3586acb16cbf010fd6013c21f2b5faa64e Mon Sep 17 00:00:00 2001 From: MichelleCDjunaidi <87893361+michellecdjuna...@users.noreply.github.com> Date: Fri, 30 Aug 2024 14:55:16 +0800 Subject: [PATC

[clang-tools-extra] Add clang-tidy external examples (PR #106675)

2024-09-11 Thread via cfe-commits
@@ -0,0 +1,32 @@ + +External Clang-Tidy Examples + + +Introduction + + +This page provides examples of what people have done with :program:`clang-tidy` that +might serve as useful guides (or starting points) to

[clang-tools-extra] [clang-tidy] Create bugprone-incorrect-enable-shared-from-this check (PR #102299)

2024-09-11 Thread via cfe-commits
@@ -0,0 +1,105 @@ +//===--- IncorrectEnableSharedFromThisCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] Thread Safety Analysis: Differentiate between lock sets at real join points and expected/actual sets at function end (PR #105526)

2024-09-11 Thread Mike Hommey via cfe-commits
glandium wrote: Before this change the following (reduced) code didn't emit a warning, but now does: ``` class __attribute__((capability("mutex"))) StaticMutex { public: void Lock() __attribute__((exclusive_lock_function())) { /* unimplemented */ } void Unlock() __attribute__((unlock_fun

[clang] clang-format: Add AlignFunctionDeclarations attribute to AlignConsecutiveDeclarations (PR #108241)

2024-09-11 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff ba4bcce5f5ffa9e7d4af72c20fe4f1baf97075fc e2091a7c50301c4a1e5c2eacb65a23bc0175e81a --e

[clang] [clang-format] Fix regressions in BAS_AlwaysBreak (PR #107506)

2024-09-11 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/107506 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 8168088 - [clang-format] Fix regressions in BAS_AlwaysBreak (#107506)

2024-09-11 Thread via cfe-commits
Author: Owen Pan Date: 2024-09-11T19:34:54-07:00 New Revision: 8168088f0a9015bc6d930e8bc1c639dee06ca82c URL: https://github.com/llvm/llvm-project/commit/8168088f0a9015bc6d930e8bc1c639dee06ca82c DIFF: https://github.com/llvm/llvm-project/commit/8168088f0a9015bc6d930e8bc1c639dee06ca82c.diff LOG:

[clang] [HLSL] Add StructuredBuffer to external sema source (PR #106316)

2024-09-11 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-x86_64-debian-fast` running on `gribozavr4` while building `clang` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/56/builds/7111 Here is the rele

[clang] [HLSL] Add StructuredBuffer to external sema source (PR #106316)

2024-09-11 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-x86_64-debian-dylib` running on `gribozavr4` while building `clang` at step 6 "test-build-unified-tree-check-clang". Full details are available at: https://lab.llvm.org/buildbot/#/builders/60/builds/7321 Here is the re

[clang] [HLSL] Add StructuredBuffer to external sema source (PR #106316)

2024-09-11 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `premerge-monolithic-linux` running on `premerge-linux-1` while building `clang` at step 7 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/153/builds/8587 Here is

[clang] [clang-scan-deps] Infer the target from the executable name (PR #108189)

2024-09-11 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 commented: LGTM but I'll leave this to @jansvoboda11 and @Bigcheese https://github.com/llvm/llvm-project/pull/108189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang-tools-extra] [clang-tidy][NFC] fix add_new_check python3.8 incompatibility (PR #107871)

2024-09-11 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/107871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 39751e7 - [clang-tidy][NFC] fix add_new_check python3.8 incompatibility (#107871)

2024-09-11 Thread via cfe-commits
Author: Congcong Cai Date: 2024-09-12T09:51:38+08:00 New Revision: 39751e7ff998266bdefeaaf3b3bf3cdba26b0322 URL: https://github.com/llvm/llvm-project/commit/39751e7ff998266bdefeaaf3b3bf3cdba26b0322 DIFF: https://github.com/llvm/llvm-project/commit/39751e7ff998266bdefeaaf3b3bf3cdba26b0322.diff

[clang] [RFC][C++20][Modules] Fix crash when function and lambda inside loaded from different modules (PR #104512)

2024-09-11 Thread Chuanqi Xu via cfe-commits
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Kyungwoo Lee ,Dmitry Polukhin ,Dmitry Polukhin Message-ID: In-Reply-To: @@ -1155,6 +1155,16 @@ void ASTDeclReader::VisitFunctionDecl(FunctionDecl *FD) { for (unsigned I = 0; I != NumParams; ++I) Params.push_back(readDeclAs

[clang] [clang-tools-extra] [clangd] show lambda name instead of operator() in signature help (PR #101857)

2024-09-11 Thread Timothy Akintilo via cfe-commits
https://github.com/tilobyte updated https://github.com/llvm/llvm-project/pull/101857 >From c1afe853ccacae1605fecfe552bb9a263c6b8c1d Mon Sep 17 00:00:00 2001 From: Timothy Akintilo Date: Sat, 27 Jul 2024 16:17:46 -0500 Subject: [PATCH 1/9] use lambda name instead of operator() --- clang-tools-

[clang] [RISCV] Emit predefined macro __riscv_cmodel_large for large code model (PR #108131)

2024-09-11 Thread Jim Lin via cfe-commits
https://github.com/tclin914 updated https://github.com/llvm/llvm-project/pull/108131 >From 5874d7163114eda6e3c5b0fa50839af0eec4e48b Mon Sep 17 00:00:00 2001 From: patrick Date: Fri, 26 Nov 2021 15:09:08 +0800 Subject: [PATCH] [RISCV] Emit predefined macro __riscv_cmodel_large for large code mo

[clang] [RISCV] Allow -mcmodel= to accept large for RV64 (PR #107817)

2024-09-11 Thread Jim Lin via cfe-commits
https://github.com/tclin914 closed https://github.com/llvm/llvm-project/pull/107817 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 757d8b3 - [RISCV] Allow -mcmodel= to accept large for RV64 (#107817)

2024-09-11 Thread via cfe-commits
Author: Jim Lin Date: 2024-09-12T09:11:12+08:00 New Revision: 757d8b3efdd82a02973d0ab4ebaa2e05e9ab7ae0 URL: https://github.com/llvm/llvm-project/commit/757d8b3efdd82a02973d0ab4ebaa2e05e9ab7ae0 DIFF: https://github.com/llvm/llvm-project/commit/757d8b3efdd82a02973d0ab4ebaa2e05e9ab7ae0.diff LOG:

[clang] [clang] Diagnose dangling issues for the "Container" case. (PR #107213)

2024-09-11 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: this looks like it has false positives: https://crbug.com/366074092 can we revert in the meantime? https://github.com/llvm/llvm-project/pull/107213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[clang] Revert "[RFC][C++20][Modules] Fix crash when function and lambda insi… (PR #108311)

2024-09-11 Thread Pranav Kant via cfe-commits
https://github.com/pranavk closed https://github.com/llvm/llvm-project/pull/108311 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 3cd0137 - Revert "[RFC][C++20][Modules] Fix crash when function and lambda insi… (#108311)

2024-09-11 Thread via cfe-commits
Author: Pranav Kant Date: 2024-09-11T17:21:42-07:00 New Revision: 3cd01371e007b2a8fe32e5d8ce1154057e5e1c2e URL: https://github.com/llvm/llvm-project/commit/3cd01371e007b2a8fe32e5d8ce1154057e5e1c2e DIFF: https://github.com/llvm/llvm-project/commit/3cd01371e007b2a8fe32e5d8ce1154057e5e1c2e.diff L

[clang] [llvm] Add step builtins and step HLSL function to DirectX and SPIR-V backend (PR #106471)

2024-09-11 Thread Joshua Batista via cfe-commits
https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/106471 >From 7dfcf804ffcb850c7e3620866bc76f0971d82aaf Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Wed, 28 Aug 2024 16:35:36 -0700 Subject: [PATCH 1/3] add step --- clang/include/clang/Basic/Builtins.td

[clang] Revert "[RFC][C++20][Modules] Fix crash when function and lambda insi… (PR #108311)

2024-09-11 Thread Pranav Kant via cfe-commits
pranavk wrote: Breaks multiple of our internal workloads and chromium open-source project (https://issues.chromium.org/issues/366045258) https://github.com/llvm/llvm-project/pull/108311 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[clang] Revert "[RFC][C++20][Modules] Fix crash when function and lambda insi… (PR #108311)

2024-09-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Pranav Kant (pranavk) Changes …de loaded from different modules (#104512)" This reverts commit d778689fdc812033e7142ed87e4ee13c4997b3f9. --- Full diff: https://github.com/llvm/llvm-project/pull/108311.diff 6 Files Affected: - (

[clang] Revert "[RFC][C++20][Modules] Fix crash when function and lambda insi… (PR #108311)

2024-09-11 Thread Pranav Kant via cfe-commits
https://github.com/pranavk created https://github.com/llvm/llvm-project/pull/108311 …de loaded from different modules (#104512)" This reverts commit d778689fdc812033e7142ed87e4ee13c4997b3f9. >From 2bce8ffa0ede2e21c590768f0b533c7e793b Mon Sep 17 00:00:00 2001 From: Pranav Kant Date: Thu, 1

[clang] [RFC][C++20][Modules] Fix crash when function and lambda inside loaded from different modules (PR #104512)

2024-09-11 Thread Pranav Kant via cfe-commits
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Kyungwoo Lee ,Dmitry Polukhin ,Dmitry Polukhin Message-ID: In-Reply-To: pranavk wrote: I am seeing internal crashes due to this as well. I am reverting this as it's causing issues in chromium open-source project as well as @aeubanks mentioned a

[clang] [llvm] [NVPTX] Remove nvvm.bitcast.* intrinsics (PR #107936)

2024-09-11 Thread Alex MacLean via cfe-commits
https://github.com/AlexMaclean updated https://github.com/llvm/llvm-project/pull/107936 >From ff978f81e0eedbc5e7547acabe414f2f1b0fd31a Mon Sep 17 00:00:00 2001 From: Alex MacLean Date: Fri, 6 Sep 2024 18:35:20 + Subject: [PATCH 1/2] [NVPTX] Remove nvvm.bitcast.* intrinsics --- clang/inclu

[clang] [llvm] [NVPTX] Remove nvvm.bitcast.* intrinsics (PR #107936)

2024-09-11 Thread Alex MacLean via cfe-commits
https://github.com/AlexMaclean updated https://github.com/llvm/llvm-project/pull/107936 >From ff978f81e0eedbc5e7547acabe414f2f1b0fd31a Mon Sep 17 00:00:00 2001 From: Alex MacLean Date: Fri, 6 Sep 2024 18:35:20 + Subject: [PATCH 1/2] [NVPTX] Remove nvvm.bitcast.* intrinsics --- clang/inclu

[clang] [Utils] add update-verify-tests.py (PR #97369)

2024-09-11 Thread Henrik G. Olsson via cfe-commits
https://github.com/hnrklssn edited https://github.com/llvm/llvm-project/pull/97369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Utils] add --update-tests flag to llvm-lit (PR #97369)

2024-09-11 Thread Henrik G. Olsson via cfe-commits
https://github.com/hnrklssn updated https://github.com/llvm/llvm-project/pull/97369 >From d93d77e193f235d12d4de4a4b184c458508fa8df Mon Sep 17 00:00:00 2001 From: "Henrik G. Olsson" Date: Mon, 1 Jul 2024 18:19:09 -0700 Subject: [PATCH 1/4] [Utils] add update-verify-tests.py Adds a python script

[clang] [llvm] Add step builtins and step HLSL function to DirectX and SPIR-V backend (PR #106471)

2024-09-11 Thread Joshua Batista via cfe-commits
https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/106471 >From 7dfcf804ffcb850c7e3620866bc76f0971d82aaf Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Wed, 28 Aug 2024 16:35:36 -0700 Subject: [PATCH 1/2] add step --- clang/include/clang/Basic/Builtins.td

[clang] [-Wunsafe-buffer-usage] Reduce false positives with constant arrays in libc warnings (PR #108308)

2024-09-11 Thread Ziqing Luo via cfe-commits
https://github.com/ziqingluo-90 updated https://github.com/llvm/llvm-project/pull/108308 >From 3c8830a0e69922faf4fad190ba0b2e01a3392e62 Mon Sep 17 00:00:00 2001 From: Ziqing Luo Date: Tue, 6 Aug 2024 17:54:23 -0700 Subject: [PATCH 1/2] [-Wunsafe-buffer-usage] Reduce false positives with consta

[clang] [compiler-rt] Reland [asan][windows] Eliminate the static asan runtime on windows (PR #107899)

2024-09-11 Thread Arthur Eubanks via cfe-commits
@@ -136,7 +160,7 @@ append_list_if(MINGW "${MINGW_LIBRARIES}" ASAN_DYNAMIC_LIBS) add_compiler_rt_object_libraries(RTAsan_dynamic OS ${SANITIZER_COMMON_SUPPORTED_OS} ARCHS ${ASAN_SUPPORTED_ARCH} - SOURCES ${ASAN_SOURCES} ${ASAN_CXX_SOURCES} + SOURCES ${ASAN_SOURCES} --

[clang] [compiler-rt] Reland [asan][windows] Eliminate the static asan runtime on windows (PR #107899)

2024-09-11 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: previous passing output ``` 2: = 3: ==7382==ERROR: AddressSanitizer: requested allocation size 0x101 (0x1001008 after adjustments for alignment, red zones etc.) exceeds maximum supported size o

[clang] [-Wunsafe-buffer-usage] Reduce false positives with constant arrays in libc warnings (PR #108308)

2024-09-11 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 4618b67b48447ed924bc195cfe735a73841e312c 3c8830a0e69922faf4fad190ba0b2e01a3392e62 --e

[clang] [-Wunsafe-buffer-usage] Reduce false positives with constant arrays in libc warnings (PR #108308)

2024-09-11 Thread Ziqing Luo via cfe-commits
https://github.com/ziqingluo-90 edited https://github.com/llvm/llvm-project/pull/108308 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [-Wunsafe-buffer-usage] Reduce false positives with constant arrays in libc warnings (PR #108308)

2024-09-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Ziqing Luo (ziqingluo-90) Changes For `snprintf(a, sizeof a, ...)`, the first two arguments form a safe pattern if `a` is a constant array. In such a case, this commit will suppress the warning. (rdar://117182250) This pattern will eff

[clang] [-Wunsafe-buffer-usage] Reduce false positives with constant arrays in libc warnings (PR #108308)

2024-09-11 Thread Ziqing Luo via cfe-commits
https://github.com/ziqingluo-90 created https://github.com/llvm/llvm-project/pull/108308 For `snprintf(a, sizeof a, ...)`, the first two arguments form a safe pattern if `a` is a constant array. In such a case, this commit will suppress the warning. (rdar://117182250) This pattern will effe

[clang] [CGData] Clang Options (PR #90304)

2024-09-11 Thread Kyungwoo Lee via cfe-commits
https://github.com/kyulee-com updated https://github.com/llvm/llvm-project/pull/90304 >From 966922b9921669d48eb750c36ce3c9b792ba8161 Mon Sep 17 00:00:00 2001 From: Kyungwoo Lee Date: Fri, 26 Apr 2024 12:58:54 -0700 Subject: [PATCH 1/2] [CGData] Clang Optinos --- clang/include/clang/Driver/Opt

[clang] [compiler-rt] Reland [asan][windows] Eliminate the static asan runtime on windows (PR #107899)

2024-09-11 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: I think this is also somehow affecting asan tests on macos: https://green.lab.llvm.org/job/llvm.org/job/clang-stage1-RA/2034/ was able to reproduce locally `build/cmake/runtimes/runtimes-bins/compiler-rt/test/sanitizer_common/asan-arm64-Darwin/allocator_returns_null.cpp` faili

[clang] [WIP][-Wunsafe-buffer-usage] Add a new option for unsafe buffer warnings on libc functions (PR #105383)

2024-09-11 Thread Ziqing Luo via cfe-commits
https://github.com/ziqingluo-90 closed https://github.com/llvm/llvm-project/pull/105383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [llvm] [BOLT] Drop blocks without profile in BAT YAML (PR #107970)

2024-09-11 Thread Amir Ayupov via cfe-commits
https://github.com/aaupov closed https://github.com/llvm/llvm-project/pull/107970 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [llvm] [BOLT] Drop blocks without profile in BAT YAML (PR #107970)

2024-09-11 Thread Amir Ayupov via cfe-commits
https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/107970 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [llvm] [BOLT] Drop blocks without profile in BAT YAML (PR #107970)

2024-09-11 Thread Amir Ayupov via cfe-commits
https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/107970 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Add step builtins and step HLSL function to DirectX and SPIR-V backend (PR #106471)

2024-09-11 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 93e45a69dde16e6a3ac0ddbcc596ac3843d59c43 7924bab45ce0436eb71a8548fe35f4d79594d00f --e

[clang] [llvm] Add step builtins and step HLSL function to DirectX and SPIR-V backend (PR #106471)

2024-09-11 Thread Joshua Batista via cfe-commits
https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/106471 >From 7dfcf804ffcb850c7e3620866bc76f0971d82aaf Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Wed, 28 Aug 2024 16:35:36 -0700 Subject: [PATCH] add step --- clang/include/clang/Basic/Builtins.td |

[clang] [CGData] Clang Options (PR #90304)

2024-09-11 Thread Kyungwoo Lee via cfe-commits
https://github.com/kyulee-com updated https://github.com/llvm/llvm-project/pull/90304 >From 966922b9921669d48eb750c36ce3c9b792ba8161 Mon Sep 17 00:00:00 2001 From: Kyungwoo Lee Date: Fri, 26 Apr 2024 12:58:54 -0700 Subject: [PATCH 1/3] [CGData] Clang Optinos --- clang/include/clang/Driver/Opt

[clang] Update StructuredBuffer-AST test after removal of HLSLResourceClassAttr (PR #108292)

2024-09-11 Thread Justin Bogner via cfe-commits
https://github.com/bogner closed https://github.com/llvm/llvm-project/pull/108292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b690cae - Update StructuredBuffer-AST test after removal of HLSLResourceClassAttr (#108292)

2024-09-11 Thread via cfe-commits
Author: Joshua Batista Date: 2024-09-11T16:08:01-07:00 New Revision: b690cae01af03237f6b5304e00d529227137b53d URL: https://github.com/llvm/llvm-project/commit/b690cae01af03237f6b5304e00d529227137b53d DIFF: https://github.com/llvm/llvm-project/commit/b690cae01af03237f6b5304e00d529227137b53d.diff

[clang] [clang][deps] Print tracing VFS data (PR #108056)

2024-09-11 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 closed https://github.com/llvm/llvm-project/pull/108056 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6e4dcbb - [clang][deps] Print tracing VFS data (#108056)

2024-09-11 Thread via cfe-commits
Author: Jan Svoboda Date: 2024-09-11T16:04:56-07:00 New Revision: 6e4dcbb21dab47e520f2cd19e7017af27328669e URL: https://github.com/llvm/llvm-project/commit/6e4dcbb21dab47e520f2cd19e7017af27328669e DIFF: https://github.com/llvm/llvm-project/commit/6e4dcbb21dab47e520f2cd19e7017af27328669e.diff L

[clang] [HLSL] fix elementwise bitreverse test (PR #108128)

2024-09-11 Thread Justin Bogner via cfe-commits
https://github.com/bogner closed https://github.com/llvm/llvm-project/pull/108128 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d32982b - [HLSL] fix elementwise bitreverse test (#108128)

2024-09-11 Thread via cfe-commits
Author: Sarah Spall Date: 2024-09-11T16:04:44-07:00 New Revision: d32982b6b3753091a532530c7a66f9686deb5233 URL: https://github.com/llvm/llvm-project/commit/d32982b6b3753091a532530c7a66f9686deb5233 DIFF: https://github.com/llvm/llvm-project/commit/d32982b6b3753091a532530c7a66f9686deb5233.diff L

[clang] [HLSL] fix elementwise bitreverse test (PR #108128)

2024-09-11 Thread Justin Bogner via cfe-commits
https://github.com/bogner approved this pull request. https://github.com/llvm/llvm-project/pull/108128 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][deps] Print tracing VFS data (PR #108056)

2024-09-11 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/108056 >From 9b9d8f02e26839758c51c7e48c1ba43dc3c24146 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Tue, 10 Sep 2024 09:55:07 -0700 Subject: [PATCH 1/2] [clang][deps] Print tracing VFS data --- .../Dependency

[clang] Update StructuredBuffer-AST test after removal of HLSLResourceClassAttr (PR #108292)

2024-09-11 Thread Justin Bogner via cfe-commits
https://github.com/bogner approved this pull request. https://github.com/llvm/llvm-project/pull/108292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Add step builtins and step HLSL function to DirectX and SPIR-V backend (PR #106471)

2024-09-11 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl approved this pull request. https://github.com/llvm/llvm-project/pull/106471 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RFC][C++20][Modules] Fix crash when function and lambda inside loaded from different modules (PR #104512)

2024-09-11 Thread Arthur Eubanks via cfe-commits
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Kyungwoo Lee ,Dmitry Polukhin ,Dmitry Polukhin Message-ID: In-Reply-To: aeubanks wrote: this is causing a crash with precompiled headers. I can try to reduce, but hopefully the problem is obvious from this assert/stack trace? ``` clang++: ../..

[clang] [llvm] Add step builtins and step HLSL function to DirectX and SPIR-V backend (PR #106471)

2024-09-11 Thread Farzon Lotfi via cfe-commits
@@ -0,0 +1,31 @@ +// RUN: %clang_cc1 -finclude-default-header -triple dxil-pc-shadermodel6.6-library %s -fnative-half-type -disable-llvm-passes -verify -verify-ignore-unexpected + +void test_too_few_arg() +{ + return __builtin_hlsl_step(); + // expected-error@-1 {{too few argu

[clang] [HIP][Clang][CodeGen] Handle hip bin symbols properly. (PR #107458)

2024-09-11 Thread via cfe-commits
https://github.com/jofrn closed https://github.com/llvm/llvm-project/pull/107458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b5fd946 - [HIP][Clang][CodeGen] Handle hip bin symbols properly. (#107458)

2024-09-11 Thread via cfe-commits
Author: jofrn Date: 2024-09-11T18:46:46-04:00 New Revision: b5fd9463a3b9aecfc132828510f7e2a47b581b14 URL: https://github.com/llvm/llvm-project/commit/b5fd9463a3b9aecfc132828510f7e2a47b581b14 DIFF: https://github.com/llvm/llvm-project/commit/b5fd9463a3b9aecfc132828510f7e2a47b581b14.diff LOG: [H

[clang] [llvm] Add step builtins and step HLSL function to DirectX and SPIR-V backend (PR #106471)

2024-09-11 Thread Farzon Lotfi via cfe-commits
@@ -1490,6 +1490,18 @@ bool SemaHLSL::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { TheCall->setType(ArgTyA); break; } + case Builtin::BI__builtin_hlsl_step: { +if (CheckFloatOrHalfRepresentations(&SemaRef, TheCall)) + return true; +

[clang] [llvm] [HLSL] Implement elementwise popcount (PR #108121)

2024-09-11 Thread Farzon Lotfi via cfe-commits
farzonl wrote: Code looks fine, I need to see more tests before I can sign off. https://github.com/llvm/llvm-project/pull/108121 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][TableGen] Change AttrEmitter to use const RecordKeeper (PR #108269)

2024-09-11 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/108269 >From 0360eda45d51e2892f804b2bbe5789a6b90f55a1 Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Wed, 11 Sep 2024 11:32:36 -0700 Subject: [PATCH] [clang][TableGen] Change AttrEmitter to use const RecordKeeper -

[clang] [clang-tools-extra] [libc] [libc][c11] implement ctime (PR #107285)

2024-09-11 Thread Зишан Мирза via cfe-commits
zimirza wrote: That would be great, since I cannot merge in LLVM. https://github.com/llvm/llvm-project/pull/107285 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [WebAssembly] Change F16x8 extract lane to require constant integer. (PR #108116)

2024-09-11 Thread Brendan Dahl via cfe-commits
https://github.com/brendandahl closed https://github.com/llvm/llvm-project/pull/108116 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 2a9208b - [WebAssembly] Change F16x8 extract lane to require constant integer. (#108116)

2024-09-11 Thread via cfe-commits
Author: Brendan Dahl Date: 2024-09-11T15:39:56-07:00 New Revision: 2a9208b0c9ddec4d321bf3af1d06a60210c89da3 URL: https://github.com/llvm/llvm-project/commit/2a9208b0c9ddec4d321bf3af1d06a60210c89da3 DIFF: https://github.com/llvm/llvm-project/commit/2a9208b0c9ddec4d321bf3af1d06a60210c89da3.diff

[clang] [llvm] [HLSL] Implement elementwise popcount (PR #108121)

2024-09-11 Thread Farzon Lotfi via cfe-commits
farzonl wrote: Also we probably still want a `clang/test/SemaHLSL/BuiltIns/countbits-errors.hlsl` to check the errors for float representations. https://github.com/llvm/llvm-project/pull/108121 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [llvm] [HLSL] Implement elementwise popcount (PR #108121)

2024-09-11 Thread Farzon Lotfi via cfe-commits
farzonl wrote: I don't see a `clang/test/CodeGenHLSL/builtins/countbits.hlsl` https://github.com/llvm/llvm-project/pull/108121 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][TableGen] Change ASTProperties Emitter to use const RecordKeeper (PR #108274)

2024-09-11 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/108274 >From 6454a52add345be58efcac015d61ec7983badf08 Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Wed, 11 Sep 2024 11:51:51 -0700 Subject: [PATCH] [clang][TableGen] Change ASTProperties Emitter to use const Recor

[clang] [llvm] [HLSL] Implement elementwise popcount (PR #108121)

2024-09-11 Thread Farzon Lotfi via cfe-commits
@@ -1522,6 +1522,14 @@ bool CheckUnsignedIntRepresentation(Sema *S, CallExpr *TheCall) { checkAllUnsignedTypes); } +bool CheckIntRepresentation(Sema *S, CallExpr *TheCall) { farzonl wrote: It doesn't seem like this function

[clang] [WebAssembly] Change F16x8 extract lane to require constant integer. (PR #108116)

2024-09-11 Thread Brendan Dahl via cfe-commits
https://github.com/brendandahl updated https://github.com/llvm/llvm-project/pull/108116 >From 3b813cd5b0555e6b654f575140e4db9a57ed699a Mon Sep 17 00:00:00 2001 From: Brendan Dahl Date: Tue, 10 Sep 2024 21:52:55 + Subject: [PATCH 1/2] [WebAssembly] Change F16x8 extract lane to require const

[clang] [clang-tools-extra] [libc] [libc][c11] implement ctime (PR #107285)

2024-09-11 Thread Michael Jones via cfe-commits
=?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0JfQuNGI0LDQvSDQnNC40YDQtw=?=, =?utf-8?b?0J

  1   2   3   4   5   6   >