[clang] [clang-format] Allow ternary in all templates (PR #96801)

2024-06-28 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/96801 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] add async loading (PR #93276)

2024-06-28 Thread Paul Kirth via cfe-commits
@@ -80,8 +80,8 @@ function createIndex(Index) { // Runs after DOM loads document.addEventListener("DOMContentLoaded", function() { - // JsonIndex is a variable from another file that contains the index - // in JSON format - var Index = JSON.parse(JsonIndex); - createIndex(

[clang-tools-extra] [clang-doc] add async loading (PR #93276)

2024-06-28 Thread via cfe-commits
https://github.com/PeterChou1 updated https://github.com/llvm/llvm-project/pull/93276 >From 0b6d536133f63e078fbde491a8c92c7ec916cb47 Mon Sep 17 00:00:00 2001 From: PeterChou1 Date: Fri, 24 May 2024 05:18:05 -0400 Subject: [PATCH 1/7] [clang-doc] make loading of json side bar async --- clang-t

[clang] Implement resource binding type prefix mismatch flag setting logic (PR #97103)

2024-06-28 Thread Joshua Batista via cfe-commits
@@ -21,6 +21,7 @@ #include "clang/Basic/IdentifierTable.h" #include "clang/Basic/SourceLocation.h" #include "clang/Sema/Scope.h" +#include "clang/Sema/Sema.h" bob80905 wrote: Sema.h is needed because it defines `RequireCompleteType` `RequireCompleteType` is re

[clang] Implement resource binding type prefix mismatch flag setting logic (PR #97103)

2024-06-28 Thread Joshua Batista via cfe-commits
@@ -437,7 +460,206 @@ void SemaHLSL::handleShaderAttr(Decl *D, const ParsedAttr &AL) { D->addAttr(NewAttr); } +struct register_binding_flags { + bool resource = false; + bool udt = false; + bool other = false; + bool basic = false; + + bool srv = false; + bool uav =

[clang-tools-extra] [clang-doc] add async loading (PR #93276)

2024-06-28 Thread via cfe-commits
https://github.com/PeterChou1 updated https://github.com/llvm/llvm-project/pull/93276 >From 0b6d536133f63e078fbde491a8c92c7ec916cb47 Mon Sep 17 00:00:00 2001 From: PeterChou1 Date: Fri, 24 May 2024 05:18:05 -0400 Subject: [PATCH 1/7] [clang-doc] make loading of json side bar async --- clang-t

[clang] [clang-tools-extra] [clang-format] Aggregate options regarding empty lines (PR #96770)

2024-06-28 Thread Owen Pan via cfe-commits
owenca wrote: > This patch was initially part of > [9267f8f](https://github.com/llvm/llvm-project/commit/9267f8f19a2e502ef5a216c0d52b352b3699d399). > I neglected to check the server builds before I added it. It broke clangd. > Jie Fu fixed the problem in > [4c91b49](https://github.com/llvm/ll

[clang] [llvm] [clang][CodeGen][AMDGPU] Enable AMDGPU `printf` for `spirv64-amd-amdhsa` (PR #97132)

2024-06-28 Thread Matt Arsenault via cfe-commits
@@ -5888,12 +5888,16 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID, case Builtin::BI__builtin_printf: case Builtin::BIprintf: if (getTarget().getTriple().isNVPTX() || -getTarget().getTriple().isAMDGCN()) { +getTarget

[clang-tools-extra] [clang-doc] add async loading (PR #93276)

2024-06-28 Thread via cfe-commits
https://github.com/PeterChou1 edited https://github.com/llvm/llvm-project/pull/93276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] add async loading (PR #93276)

2024-06-28 Thread via cfe-commits
https://github.com/PeterChou1 edited https://github.com/llvm/llvm-project/pull/93276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] b15fcda - [JSON] Export sortedElements and fix CLANGD_TRACE non-determinism

2024-06-28 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2024-06-28T22:10:15-07:00 New Revision: b15fcdaf79e9b5931e8a7f9e09f8e3842d262dd7 URL: https://github.com/llvm/llvm-project/commit/b15fcdaf79e9b5931e8a7f9e09f8e3842d262dd7 DIFF: https://github.com/llvm/llvm-project/commit/b15fcdaf79e9b5931e8a7f9e09f8e3842d262dd7.diff

[clang] [llvm] [Coverage][MC/DC] Show uncoverable and unreachable conditions (PR #94137)

2024-06-28 Thread via cfe-commits
https://github.com/Lambdaris updated https://github.com/llvm/llvm-project/pull/94137 >From 31ec5173f15d0b51ae919d508339340279d9d0b4 Mon Sep 17 00:00:00 2001 From: Lambdaris Date: Sun, 2 Jun 2024 10:19:31 +0800 Subject: [PATCH 1/2] [coverage] Mark branches with either counter is zero as folded

[clang-tools-extra] [clang-doc] switched from using relative to absolute paths (PR #93281)

2024-06-28 Thread Paul Kirth via cfe-commits
@@ -1,48 +1,22 @@ -// Append using posix-style a file name or directory to Base -function append(Base, New) { - if (!New) -return Base; - if (Base) -Base += "/"; - Base += New; - return Base; -} - -// Get relative path to access FilePath from CurrentDirectory -function

[clang-tools-extra] [clang-doc] switched from using relative to absolute paths (PR #93281)

2024-06-28 Thread Paul Kirth via cfe-commits
@@ -1,48 +1,22 @@ -// Append using posix-style a file name or directory to Base -function append(Base, New) { - if (!New) -return Base; - if (Base) -Base += "/"; - Base += New; - return Base; -} - -// Get relative path to access FilePath from CurrentDirectory -function

[clang] [llvm] [mlir] Add f8E4M3 IEEE 754 type (PR #97118)

2024-06-28 Thread Alexander Pivovarov via cfe-commits
https://github.com/apivovarov updated https://github.com/llvm/llvm-project/pull/97118 >From e5fb4d85889472fd9880e5262d3a9cf00e1b1f89 Mon Sep 17 00:00:00 2001 From: Alexander Pivovarov Date: Fri, 28 Jun 2024 19:33:21 + Subject: [PATCH 1/2] Rename f8E4M3 to f8E4M3FN in mlir.extras.types py pa

[clang-tools-extra] [clang-doc] add async loading (PR #93276)

2024-06-28 Thread Paul Kirth via cfe-commits
@@ -80,8 +80,6 @@ function createIndex(Index) { // Runs after DOM loads document.addEventListener("DOMContentLoaded", function() { - // JsonIndex is a variable from another file that contains the index - // in JSON format - var Index = JSON.parse(JsonIndex); - createIndex(

[clang-tools-extra] [clang-doc] add async loading (PR #93276)

2024-06-28 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi approved this pull request. LGTM modulo some minor nits, but please revise the commit message. The end is not clear, and looks like it may be a copy paste error. If you know how much this improves the performance/responsiveness of the generated documentation, that wo

[clang-tools-extra] [clang-doc] add async loading (PR #93276)

2024-06-28 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/93276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Implement function pointer type discrimination (PR #96992)

2024-06-28 Thread Timm Baeder via cfe-commits
@@ -2220,6 +2220,11 @@ llvm::Constant *ConstantLValueEmitter::emitPointerAuthPointer(const Expr *E) { // The assertions here are all checked by Sema. assert(Result.Val.isLValue()); + const auto *Base = Result.Val.getLValueBase().get(); + if (const auto *Decl = dyn_cast_

[clang] [llvm] [mlir] Add f8E4M3 IEEE 754 type (PR #97118)

2024-06-28 Thread Alexander Pivovarov via cfe-commits
https://github.com/apivovarov updated https://github.com/llvm/llvm-project/pull/97118 >From 0b76af07d0dc567cbbcceeca2bc3858837875498 Mon Sep 17 00:00:00 2001 From: Alexander Pivovarov Date: Fri, 28 Jun 2024 19:33:21 + Subject: [PATCH 1/2] Rename f8E4M3 to f8E4M3FN in mlir.extras.types py pa

[clang] [clang] Implement function pointer type discrimination (PR #96992)

2024-06-28 Thread Akira Hatanaka via cfe-commits
@@ -2220,6 +2220,11 @@ llvm::Constant *ConstantLValueEmitter::emitPointerAuthPointer(const Expr *E) { // The assertions here are all checked by Sema. assert(Result.Val.isLValue()); + auto *Base = Result.Val.getLValueBase().get(); + if (auto *Decl = dyn_cast_or_null(Base

[clang] [llvm] [clang][CodeGen][AMDGPU] Enable AMDGPU `printf` for `spirv64-amd-amdhsa` (PR #97132)

2024-06-28 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 0991bd7887a313d4d6bb66ca44d11939ad71b660 ba61ed9f26bc0e88d27dc95b4b999324b1fa2e43 --

[clang] [llvm] [clang][CodeGen][AMDGPU] Enable AMDGPU `printf` for `spirv64-amd-amdhsa` (PR #97132)

2024-06-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-amdgpu @llvm/pr-subscribers-clang-codegen Author: Alex Voicu (AlexVlx) Changes This enables the AMDGPU specific implementation of `printf` when compiling for AMDGCN flavoured SPIR-V, the consequence being that the expansion into ROCDL calls & f

[clang] [llvm] [polly] Revert "[IR] Don't include Module.h in Analysis.h (NFC) (#97023)" (PR #97129)

2024-06-28 Thread via cfe-commits
hiraditya wrote: Please share the cmake config and build command for repro. https://github.com/llvm/llvm-project/pull/97129 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Zero init unspecified fields in initializers in C (#78034) (PR #97121)

2024-06-28 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: The only place the standard requires padding to be zero-initialized is in "default initialization", which only applies to members which don't have an initializer. So, for example, if you have `struct X { int x; char y; } z = {1};`, none of the padding is required to be in

[clang-tools-extra] [clang-doc] switched from using relative to absolute paths (PR #93281)

2024-06-28 Thread via cfe-commits
https://github.com/PeterChou1 edited https://github.com/llvm/llvm-project/pull/93281 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] Add f8E4M3 IEEE 754 type (PR #97118)

2024-06-28 Thread Alexander Pivovarov via cfe-commits
https://github.com/apivovarov edited https://github.com/llvm/llvm-project/pull/97118 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [polly] Revert "[IR] Don't include Module.h in Analysis.h (NFC) (#97023)" (PR #97129)

2024-06-28 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: In what configuration are you seeing these errors? I believe most of the issues got resolved by this morning (PST) for the buildbots. https://github.com/llvm/llvm-project/pull/97129 ___ cfe-commits mailing list cfe-commits@lists

[clang] [llvm] [WebAssembly] support getVT from `externref` and `funcref` (PR #97080)

2024-06-28 Thread Heejin Ahn via cfe-commits
https://github.com/aheejin edited https://github.com/llvm/llvm-project/pull/97080 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [WebAssembly] support getVT from `externref` and `funcref` (PR #97080)

2024-06-28 Thread Heejin Ahn via cfe-commits
@@ -0,0 +1,18 @@ +// RUN: %clang_cc1 -O2 -triple wasm32-unknown-unknown-wasm -target-feature +reference-types -emit-llvm -o - %s | FileCheck %s aheejin wrote: ```suggestion // RUN: %clang_cc1 -O2 -triple wasm32-unknown-unknown -target-feature +reference-types -

[clang] [llvm] [WebAssembly] support getVT from `externref` and `funcref` (PR #97080)

2024-06-28 Thread Heejin Ahn via cfe-commits
@@ -0,0 +1,18 @@ +// RUN: %clang_cc1 -O2 -triple wasm32-unknown-unknown-wasm -target-feature +reference-types -emit-llvm -o - %s | FileCheck %s aheejin wrote: By the way, this command succeeds even without this patch. The test should be something that fails now

[clang] [llvm] [WebAssembly] support getVT from `externref` and `funcref` (PR #97080)

2024-06-28 Thread Heejin Ahn via cfe-commits
@@ -0,0 +1,18 @@ +// RUN: %clang_cc1 -O2 -triple wasm32-unknown-unknown-wasm -target-feature +reference-types -emit-llvm -o - %s | FileCheck %s + +// From issue 69894. Reftypes need to be marked as not valid as vector elements. aheejin wrote: If you would like

[clang] [llvm] [WebAssembly] support getVT from `externref` and `funcref` (PR #97080)

2024-06-28 Thread Heejin Ahn via cfe-commits
https://github.com/aheejin commented: What happens if you compile a file that really vectorizes reference types? The attached test doesn't seem to actually end up getting vectorized after all. Can you add a test that get vectorized? https://github.com/llvm/llvm-project/pull/97080 _

[clang-tools-extra] [clang-doc] add async loading (PR #93276)

2024-06-28 Thread via cfe-commits
https://github.com/PeterChou1 updated https://github.com/llvm/llvm-project/pull/93276 >From 0b6d536133f63e078fbde491a8c92c7ec916cb47 Mon Sep 17 00:00:00 2001 From: PeterChou1 Date: Fri, 24 May 2024 05:18:05 -0400 Subject: [PATCH 1/6] [clang-doc] make loading of json side bar async --- clang-t

[clang-tools-extra] [clang-doc] add async loading (PR #93276)

2024-06-28 Thread via cfe-commits
https://github.com/PeterChou1 edited https://github.com/llvm/llvm-project/pull/93276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] add async loading (PR #93276)

2024-06-28 Thread via cfe-commits
https://github.com/PeterChou1 edited https://github.com/llvm/llvm-project/pull/93276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [polly] Revert "[IR] Don't include Module.h in Analysis.h (NFC) (#97023)" (PR #97129)

2024-06-28 Thread via cfe-commits
https://github.com/ZijunZhaoCCK edited https://github.com/llvm/llvm-project/pull/97129 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] add async loading (PR #93276)

2024-06-28 Thread via cfe-commits
https://github.com/PeterChou1 updated https://github.com/llvm/llvm-project/pull/93276 >From 0b6d536133f63e078fbde491a8c92c7ec916cb47 Mon Sep 17 00:00:00 2001 From: PeterChou1 Date: Fri, 24 May 2024 05:18:05 -0400 Subject: [PATCH 1/5] [clang-doc] make loading of json side bar async --- clang-t

[clang-tools-extra] [clang-doc] add async loading (PR #93276)

2024-06-28 Thread via cfe-commits
https://github.com/PeterChou1 updated https://github.com/llvm/llvm-project/pull/93276 >From 0b6d536133f63e078fbde491a8c92c7ec916cb47 Mon Sep 17 00:00:00 2001 From: PeterChou1 Date: Fri, 24 May 2024 05:18:05 -0400 Subject: [PATCH 1/4] [clang-doc] make loading of json side bar async --- clang-t

[clang] [llvm] [polly] Revert "[IR] Don't include Module.h in Analysis.h (NFC) (#97023)" (PR #97129)

2024-06-28 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 0991bd7887a313d4d6bb66ca44d11939ad71b660 e277504246c0f077fec20e917c29ac8e5c193325 --

[clang] [llvm] [polly] Revert "[IR] Don't include Module.h in Analysis.h (NFC) (#97023)" (PR #97129)

2024-06-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-mlgo @llvm/pr-subscribers-backend-amdgpu Author: None (ZijunZhaoCCK) Changes This reverts commit 4169338e75cdce73d34063532db598c95ee82ae4. This will causes incomplete type errors. ```/[tmpfs/src/git/out/llvm-project/llvm/lib/Target/WebAssembly/WebAssem

[clang] [llvm] [polly] Revert "[IR] Don't include Module.h in Analysis.h (NFC) (#97023)" (PR #97129)

2024-06-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-powerpc Author: None (ZijunZhaoCCK) Changes This reverts commit 4169338e75cdce73d34063532db598c95ee82ae4. This will causes incomplete type errors. ```/[tmpfs/src/git/out/llvm-project/llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:1022]

[clang] [llvm] [polly] Revert "[IR] Don't include Module.h in Analysis.h (NFC) (#97023)" (PR #97129)

2024-06-28 Thread via cfe-commits
https://github.com/ZijunZhaoCCK created https://github.com/llvm/llvm-project/pull/97129 This reverts commit 4169338e75cdce73d34063532db598c95ee82ae4. This will causes incomplete type errors. ```/[tmpfs/src/git/out/llvm-project/llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:1022](https

[clang] Fix compatibility version in test (PR #97128)

2024-06-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Richard Smith (zygoloid) Changes The mangling compatibility being tested here changed between Clang 17 and 18, not between 16 and 17, so change the "old" version to 17. As requested by @ahatanak in [post-commit review](https://github.com

[clang] Fix compatibility version in test (PR #97128)

2024-06-28 Thread Richard Smith via cfe-commits
https://github.com/zygoloid created https://github.com/llvm/llvm-project/pull/97128 The mangling compatibility being tested here changed between Clang 17 and 18, not between 16 and 17, so change the "old" version to 17. As requested by @ahatanak in [post-commit review](https://github.com/llvm

[clang] [llvm] [WebAssembly] support getVT from `externref` and `funcref` (PR #97080)

2024-06-28 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/97080 >From b49737505ad3ad84e977787daf141b98fe3e6607 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Sat, 29 Jun 2024 00:24:30 +0800 Subject: [PATCH] [WebAssembly] support getVT from wasm externref and funcref -

[clang] [llvm] [mlir] Add f8E4M3 IEEE 754 type (PR #97118)

2024-06-28 Thread Alexander Pivovarov via cfe-commits
https://github.com/apivovarov updated https://github.com/llvm/llvm-project/pull/97118 >From 8b0671585864e13d26596b9e8ada39364c542517 Mon Sep 17 00:00:00 2001 From: Alexander Pivovarov Date: Fri, 28 Jun 2024 19:33:21 + Subject: [PATCH 1/2] Rename f8E4M3 to f8E4M3FN in mlir.extras.types py pa

[clang] [Clang] Fix __is_trivially_equality_comparable returning true with ineligebile defaulted overloads (PR #93113)

2024-06-28 Thread Nikolas Klauser via cfe-commits
philnik777 wrote: @ZequanWu I can't successfully build your reproducer with clang trunk. Would it be possible to provide the full test case or a fully reduced one? https://github.com/llvm/llvm-project/pull/93113 ___ cfe-commits mailing list cfe-commit

[clang] [llvm] [mlir] Add f8E4M3 IEEE 754 type (PR #97118)

2024-06-28 Thread Maksim Levental via cfe-commits
makslevental wrote: Ah so this is the reason for the previous PR :) https://github.com/llvm/llvm-project/pull/97118 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement resource binding type prefix mismatch flag setting logic (PR #97103)

2024-06-28 Thread Xiang Li via cfe-commits
@@ -21,6 +21,7 @@ #include "clang/Basic/IdentifierTable.h" #include "clang/Basic/SourceLocation.h" #include "clang/Sema/Scope.h" +#include "clang/Sema/Sema.h" python3kgae wrote: What led us to include Sema.h? https://github.com/llvm/llvm-project/pull/97103 __

[clang] [llvm] [openmp] [OpenMP][offload] Fix dynamic schedule tracking (PR #97065)

2024-06-28 Thread Gheorghe-Teodor Bercea via cfe-commits
doru1004 wrote: > The code changes look good now, but I'd prefer to have a non-SPMD mode test > case. Done https://github.com/llvm/llvm-project/pull/97065 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[clang] Implement resource binding type prefix mismatch flag setting logic (PR #97103)

2024-06-28 Thread Xiang Li via cfe-commits
@@ -437,7 +460,206 @@ void SemaHLSL::handleShaderAttr(Decl *D, const ParsedAttr &AL) { D->addAttr(NewAttr); } +struct register_binding_flags { + bool resource = false; + bool udt = false; + bool other = false; + bool basic = false; + + bool srv = false; + bool uav =

[clang-tools-extra] [clang-doc] add async loading (PR #93276)

2024-06-28 Thread via cfe-commits
https://github.com/PeterChou1 edited https://github.com/llvm/llvm-project/pull/93276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] add async loading (PR #93276)

2024-06-28 Thread via cfe-commits
https://github.com/PeterChou1 updated https://github.com/llvm/llvm-project/pull/93276 >From 0b6d536133f63e078fbde491a8c92c7ec916cb47 Mon Sep 17 00:00:00 2001 From: PeterChou1 Date: Fri, 24 May 2024 05:18:05 -0400 Subject: [PATCH 1/3] [clang-doc] make loading of json side bar async --- clang-t

[clang-tools-extra] [clang-doc] add async loading (PR #93276)

2024-06-28 Thread via cfe-commits
https://github.com/PeterChou1 updated https://github.com/llvm/llvm-project/pull/93276 >From 0b6d536133f63e078fbde491a8c92c7ec916cb47 Mon Sep 17 00:00:00 2001 From: PeterChou1 Date: Fri, 24 May 2024 05:18:05 -0400 Subject: [PATCH 1/2] [clang-doc] make loading of json side bar async --- clang-t

[clang] Implement resource binding type prefix mismatch flag setting logic (PR #97103)

2024-06-28 Thread Joshua Batista via cfe-commits
https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/97103 >From c784272b3f66ca06be4ab8e72a0963e5ebb6a869 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Fri, 28 Jun 2024 12:40:56 -0700 Subject: [PATCH 1/3] update tests, update code --- clang/include/clang/Basic/A

[clang] [llvm] [openmp] [OpenMP][offload] Fix dynamic schedule tracking (PR #97065)

2024-06-28 Thread Shilei Tian via cfe-commits
https://github.com/shiltian commented: The code changes look good now, but I'd prefer to have a non-SPMD mode test case. https://github.com/llvm/llvm-project/pull/97065 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang] Implement resource binding type prefix mismatch flag setting logic (PR #97103)

2024-06-28 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 319e11daee807981db61dad3da90d9bf36317e03 8e20fce2dbb0e88bc6c286815d36339f37d34d80 --

[clang-tools-extra] [clang-doc][nfc] Avoid constructing SmallString in ToString method (PR #96921)

2024-06-28 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/96921 >From f2251efabbc1a59e87b25285f7173161e6f63d22 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Thu, 27 Jun 2024 09:13:01 -0700 Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?UTF-8

[clang] [clang][CodeGen] Remove unnecessary ShouldLinkFiles conditional (PR #96951)

2024-06-28 Thread Jacob Lambert via cfe-commits
lamb-j wrote: Should be fixed with https://github.com/llvm/llvm-project/commit/982c54719289c1d85d03be3ad9e95bbfd2862aee https://github.com/llvm/llvm-project/pull/96951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[clang-tools-extra] [clang-doc][nfc] Avoid constructing SmallString in ToString method (PR #96921)

2024-06-28 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff e55aa027f813679ca63c9b803690ce792a3d7b28 f48c15c8a6e8fb992a2089fcd95e51dc32a76375 --

[clang] Implement resource binding type prefix mismatch flag setting logic (PR #97103)

2024-06-28 Thread Joshua Batista via cfe-commits
https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/97103 >From c784272b3f66ca06be4ab8e72a0963e5ebb6a869 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Fri, 28 Jun 2024 12:40:56 -0700 Subject: [PATCH 1/2] update tests, update code --- clang/include/clang/Basic/A

[clang-tools-extra] [clang-doc][nfc] Avoid constructing SmallString in ToString method (PR #96921)

2024-06-28 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/96921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc][nfc] Avoid constructing SmallString in ToString method (PR #96921)

2024-06-28 Thread Paul Kirth via cfe-commits
@@ -56,7 +56,7 @@ class HTMLTag { operator bool() = delete; bool IsSelfClosing() const; - llvm::SmallString<16> ToString() const; + const char* toString() const; ilovepi wrote: done https://github.com/llvm/llvm-project/pull/96921 __

[clang-tools-extra] [clang-doc][nfc] Avoid constructing SmallString in ToString method (PR #96921)

2024-06-28 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/96921 >From f2251efabbc1a59e87b25285f7173161e6f63d22 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Thu, 27 Jun 2024 09:13:01 -0700 Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?= =?UTF-8

[clang] [llvm] [mlir] Add f8E4M3 IEEE 754 type (PR #97118)

2024-06-28 Thread Alexander Pivovarov via cfe-commits
apivovarov wrote: Reed, Benjamin, Can you look at this PR too? @reedwm @d0k https://github.com/llvm/llvm-project/pull/97118 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Prevent null pointer dereference in template deduction guide creation (PR #97097)

2024-06-28 Thread via cfe-commits
https://github.com/antangelo approved this pull request. https://github.com/llvm/llvm-project/pull/97097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] add async loading (PR #93276)

2024-06-28 Thread via cfe-commits
https://github.com/PeterChou1 edited https://github.com/llvm/llvm-project/pull/93276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] Add f8E4M3 IEEE 754 type (PR #97118)

2024-06-28 Thread Alexander Pivovarov via cfe-commits
https://github.com/apivovarov updated https://github.com/llvm/llvm-project/pull/97118 >From 8b0671585864e13d26596b9e8ada39364c542517 Mon Sep 17 00:00:00 2001 From: Alexander Pivovarov Date: Fri, 28 Jun 2024 19:33:21 + Subject: [PATCH 1/2] Rename f8E4M3 to f8E4M3FN in mlir.extras.types py pa

[clang] [llvm] [mlir] Add f8E4M3 IEEE 754 type (PR #97118)

2024-06-28 Thread Alexander Pivovarov via cfe-commits
https://github.com/apivovarov updated https://github.com/llvm/llvm-project/pull/97118 >From f6d1c7120bbb382a5b38bd2172e743e7808e304c Mon Sep 17 00:00:00 2001 From: Alexander Pivovarov Date: Fri, 28 Jun 2024 19:33:21 + Subject: [PATCH 1/2] Rename f8E4M3 to f8E4M3FN in mlir.extras.types py pa

[clang] [clang][CodeGen] Zero init unspecified fields in initializers in C (#78034) (PR #97121)

2024-06-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: None (yabinc) Changes When an initializer is provided to a variable, the Linux kernel relies on clang to zero-initialize unspecified fields. But clang doesn't guarantee this: 1. For a union type, if an empty initializer is given, c

[clang] [clang][CodeGen] Zero init unspecified fields in initializers in C (#78034) (PR #97121)

2024-06-28 Thread via cfe-commits
https://github.com/yabinc created https://github.com/llvm/llvm-project/pull/97121 When an initializer is provided to a variable, the Linux kernel relies on clang to zero-initialize unspecified fields. But clang doesn't guarantee this: 1. For a union type, if an empty initializer is given, clang

[clang] [llvm] [MC,llvm-readobj,yaml2obj] Support CREL relocation format (PR #91280)

2024-06-28 Thread Fangrui Song via cfe-commits
MaskRay wrote: > Just noting that I've taken another look through the whole thing and I have > no new comments. Thanks for the review! @dwblaikie @jh7370 @smithp35 If the current version looks good to you, may I get explicit approval? https://github.com/llvm/llvm-project/pull/91280 __

[clang] [llvm] [MC,llvm-readobj,yaml2obj] Support CREL relocation format (PR #91280)

2024-06-28 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay updated https://github.com/llvm/llvm-project/pull/91280 >From a0cfafb82db825512b0ca44778fa9d4bb435563d Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Mon, 6 May 2024 15:37:50 -0700 Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?= =?UTF-

[clang] [llvm] [MC,llvm-readobj,yaml2obj] Support CREL relocation format (PR #91280)

2024-06-28 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/91280 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Improve performance by adding a short circuit (PR #96809)

2024-06-28 Thread via cfe-commits
PeterChou1 wrote: Here's the diff for the doc output for the different branches https://drive.google.com/file/d/1QS0YgNaB5gkJqM1HPqm2RziGXA88nqMM/view?usp=sharing https://github.com/llvm/llvm-project/pull/96809 ___ cfe-commits mailing list cfe-commits

[clang] [llvm] [MC,llvm-readobj,yaml2obj] Support CREL relocation format (PR #91280)

2024-06-28 Thread Fangrui Song via cfe-commits
@@ -86,6 +86,8 @@ DYNAMIC_TAG(RELRSZ, 35) // Size of Relr relocation table. DYNAMIC_TAG(RELR, 36)// Address of relocation table (Relr entries). DYNAMIC_TAG(RELRENT, 37) // Size of a Relr relocation entry. +DYNAMIC_TAG(CREL, 38) // CREL relocation table + --

[clang] [clang][CodeGen] Remove unnecessary ShouldLinkFiles conditional (PR #96951)

2024-06-28 Thread Lei Huang via cfe-commits
lei137 wrote: I'm getting a build failure with `-Werror` on powerpc from this: ``` ~llvm-project/clang/lib/CodeGen/LinkInModulesPass.cpp:24:19: error: field 'ShouldLinkFiles' is uninitialized when used here [-Werror,-Wuninitialized] 407324 | ShouldLinkFiles(ShouldLinkFiles) {} 4074 |

[clang] [llvm] [openmp] [OpenMP][offload] Fix dynamic schedule tracking (PR #97065)

2024-06-28 Thread Johannes Doerfert via cfe-commits
https://github.com/jdoerfert approved this pull request. LG, @shiltian, OK? https://github.com/llvm/llvm-project/pull/97065 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Hashing] Use a non-deterministic seed if LLVM_ENABLE_ABI_BREAKING_CHECKS (PR #96282)

2024-06-28 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay closed https://github.com/llvm/llvm-project/pull/96282 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Hashing] Use a non-deterministic seed if LLVM_ENABLE_ABI_BREAKING_CHECKS (PR #96282)

2024-06-28 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/96282 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Cleanup missed ShouldLinkFiles definitions (PR #97115)

2024-06-28 Thread Jacob Lambert via cfe-commits
https://github.com/lamb-j closed https://github.com/llvm/llvm-project/pull/97115 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 982c547 - [clang][CodeGen] Cleanup missed ShouldLinkFiles definitions (#97115)

2024-06-28 Thread via cfe-commits
Author: Jacob Lambert Date: 2024-06-28T15:22:42-07:00 New Revision: 982c54719289c1d85d03be3ad9e95bbfd2862aee URL: https://github.com/llvm/llvm-project/commit/982c54719289c1d85d03be3ad9e95bbfd2862aee DIFF: https://github.com/llvm/llvm-project/commit/982c54719289c1d85d03be3ad9e95bbfd2862aee.diff

[clang] [llvm] [NVPTX] Support inline asm with 128-bit operand in NVPTX backend (PR #97113)

2024-06-28 Thread Justin Lebar via cfe-commits
https://github.com/jlebar approved this pull request. https://github.com/llvm/llvm-project/pull/97113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6644975 - [CodeGen] Use MapVector to stabilize iteration order

2024-06-28 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2024-06-28T15:10:53-07:00 New Revision: 664497557ae7e726b424d325533cdce8104b3337 URL: https://github.com/llvm/llvm-project/commit/664497557ae7e726b424d325533cdce8104b3337 DIFF: https://github.com/llvm/llvm-project/commit/664497557ae7e726b424d325533cdce8104b3337.diff

[clang] [llvm] [mlir] Add f8E4M3 IEEE 754 type (PR #97118)

2024-06-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Alexander Pivovarov (apivovarov) Changes This PR adds `f8E4M3` type which follows IEEE 754 convention ```c f8E4M3 (IEEE 754) - Exponent: 4 - Mantissa: 3 - Exponent bias: 7 - Follows IEEE 754 conventions for representation of special values

[clang] [llvm] [mlir] Add f8E4M3 IEEE 754 type (PR #97118)

2024-06-28 Thread Alexander Pivovarov via cfe-commits
https://github.com/apivovarov created https://github.com/llvm/llvm-project/pull/97118 This PR adds `f8E4M3` type which follows IEEE 754 convention ```c f8E4M3 (IEEE 754) - Exponent: 4 - Mantissa: 3 - Exponent bias: 7 - Follows IEEE 754 conventions for representation of special values - Has Posi

[clang] [llvm] [NVPTX] Support inline asm with 128-bit operand in NVPTX backend (PR #97113)

2024-06-28 Thread Justin Lebar via cfe-commits
jlebar wrote: > Which file should I modify? Use `git grep` to find where the text from that section of the langref lives? https://github.com/llvm/llvm-project/pull/97113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang] [clang][CodeGen] Cleanup missed ShouldLinkFiles definitions (PR #97115)

2024-06-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jacob Lambert (lamb-j) Changes Follow up to https://github.com/llvm/llvm-project/commit/2264544e2d13957f36fd19864d9633a3278a9d74 --- Full diff: https://github.com/llvm/llvm-project/pull/97115.diff 2 Files Affected: - (modified) clang/l

[clang] [clang][CodeGen] Cleanup missed ShouldLinkFiles definitions (PR #97115)

2024-06-28 Thread Jacob Lambert via cfe-commits
https://github.com/lamb-j created https://github.com/llvm/llvm-project/pull/97115 Follow up to https://github.com/llvm/llvm-project/commit/2264544e2d13957f36fd19864d9633a3278a9d74 >From 6131f15194e0f97fea381d896f5f9847ad4ba786 Mon Sep 17 00:00:00 2001 From: Jacob Lambert Date: Fri, 28 Jun 202

[clang] [llvm] [NVPTX] Support inline asm with 128-bit operand in NVPTX backend (PR #97113)

2024-06-28 Thread via cfe-commits
Chengjunp wrote: > This needs to be documented in the langref in this section, right? > https://llvm.org/docs/LangRef.html#supported-constraint-code-list Oh, you are right. Thank you for pointing this out. Which file should I modify? Is it `llvm/docs/LangRef.rst`? Thanks! https://github.com/l

[clang] [llvm] [NVPTX] Support inline asm with 128-bit operand in NVPTX backend (PR #97113)

2024-06-28 Thread Justin Lebar via cfe-commits
https://github.com/jlebar commented: LGTM other than the previous comment. https://github.com/llvm/llvm-project/pull/97113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NVPTX] Support inline asm with 128-bit operand in NVPTX backend (PR #97113)

2024-06-28 Thread Justin Lebar via cfe-commits
https://github.com/jlebar requested changes to this pull request. This needs to be documented in the langref in this section, right? https://llvm.org/docs/LangRef.html#supported-constraint-code-list https://github.com/llvm/llvm-project/pull/97113 ___

[clang] [clang][CodeGen] Remove unnecessary ShouldLinkFiles conditional (PR #96951)

2024-06-28 Thread Jacob Lambert via cfe-commits
https://github.com/lamb-j closed https://github.com/llvm/llvm-project/pull/96951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 2264544 - [clang][CodeGen] Remove unnecessary ShouldLinkFiles conditional (#96951)

2024-06-28 Thread via cfe-commits
Author: Jacob Lambert Date: 2024-06-28T14:35:29-07:00 New Revision: 2264544e2d13957f36fd19864d9633a3278a9d74 URL: https://github.com/llvm/llvm-project/commit/2264544e2d13957f36fd19864d9633a3278a9d74 DIFF: https://github.com/llvm/llvm-project/commit/2264544e2d13957f36fd19864d9633a3278a9d74.diff

[clang] [Clang] Fix potential null pointer dereferences in Sema::AddInitializerToDecl (PR #94368)

2024-06-28 Thread via cfe-commits
https://github.com/smanna12 updated https://github.com/llvm/llvm-project/pull/94368 >From b6d45ded3d0d1ad6a50a1292d4f8275081089150 Mon Sep 17 00:00:00 2001 From: "Manna, Soumi" Date: Tue, 4 Jun 2024 08:33:51 -0700 Subject: [PATCH 1/5] [Clang] Fix potential null pointer dereferences in Sema::Ad

[clang] [NFC] [clang][SPIR-V] Use AMDGPU prefix to avoid confusion (PR #96962)

2024-06-28 Thread Jinsong Ji via cfe-commits
jsji wrote: > LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux` > running on `sanitizer-buildbot1` while building `clang` at step 2 "annotate". Flaky failure. https://github.com/llvm/llvm-project/pull/96962 ___ cfe-commits

[clang] [llvm] [NVPTX] Support inline asm with 128-bit operand in NVPTX backend (PR #97113)

2024-06-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (Chengjunp) Changes This change supports the 128-bit operands for inline ptx asm, both input and output.\ \ The major changes are: - Tablegen:\     Define Int128Regs in NVPTXRegisterInfo.td. But this register does not set as gener

[clang] [llvm] [NVPTX] Support inline asm with 128-bit operand in NVPTX backend (PR #97113)

2024-06-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-nvptx Author: None (Chengjunp) Changes This change supports the 128-bit operands for inline ptx asm, both input and output.\ \ The major changes are: - Tablegen:\     Define Int128Regs in NVPTXRegisterInfo.td. But this register does not set

[clang] [clang] Improve diagnostics for constraints of inline asm (NFC) (PR #96363)

2024-06-28 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: If there's some subset of cases that's easy to diagnose, like SSE registers without SSE, maybe we can do that. I mostly care that we don't write a bunch of code to check complicated edge cases, like trying to diagnose if you're using too many registers. https://github.com

  1   2   3   4   5   >