[clang] [llvm] Add option to generate additional debug info for expression dereferencing pointer to pointers. (PR #94100)

2024-05-31 Thread David Blaikie via cfe-commits
https://github.com/dwblaikie approved this pull request. Looks worth a shot. Please commit this at a time where you can respond to bot fail-mail for a while after the commit. And ensure the commit message has most/all of the details of the original commit, plus the original commit and revert h

[clang] [llvm] Add option to generate additional debug info for expression dereferencing pointer to pointers. (PR #94100)

2024-05-31 Thread William Junda Huang via cfe-commits
https://github.com/huangjd created https://github.com/llvm/llvm-project/pull/94100 This is another attempt to land #81545, which was reverted. Fixed test case so that it is consistent on all platforms. >From f2c82758e1cba7773e41d941d2812c829c339675 Mon Sep 17 00:00:00 2001 From: William Huan

[compiler-rt] [libcxx] [libcxxabi] [libunwind] [libunwind][libcxx][libcxxabi][compiler-rt-builtins] Fix Exception Handling build for wasm (PR #79667)

2024-05-31 Thread via cfe-commits
https://github.com/trcrsired updated https://github.com/llvm/llvm-project/pull/79667 >From d73a87b47a549aeac7f4ea519037107a8f798df6 Mon Sep 17 00:00:00 2001 From: trcrsired Date: Fri, 26 Jan 2024 18:44:41 -0500 Subject: [PATCH] [libunwind][libcxx][libcxxabi] Fix Exception Handling build for wa

[clang] [amdgpu] Pass variadic arguments without splitting (PR #94083)

2024-05-31 Thread Matt Arsenault via cfe-commits
@@ -197,12 +202,20 @@ ABIArgInfo AMDGPUABIInfo::classifyKernelArgumentType(QualType Ty) const { return ABIArgInfo::getDirect(LTy, 0, nullptr, false); } -ABIArgInfo AMDGPUABIInfo::classifyArgumentType(QualType Ty, +ABIArgInfo AMDGPUABIInfo::classifyArgumentType(QualType Ty,

[clang] [amdgpu] Pass variadic arguments without splitting (PR #94083)

2024-05-31 Thread Matt Arsenault via cfe-commits
@@ -0,0 +1,293 @@ +// REQUIRES: amdgpu-registered-target +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --function-signature +// RUN: %clang_cc1 -cc1 -std=c23 -triple amdgcn-amd-amdhsa -emit-llvm -O1 %s -o - | FileCheck %s + +void sink_0

[clang] [amdgpu] Pass variadic arguments without splitting (PR #94083)

2024-05-31 Thread Matt Arsenault via cfe-commits
@@ -197,12 +202,20 @@ ABIArgInfo AMDGPUABIInfo::classifyKernelArgumentType(QualType Ty) const { return ABIArgInfo::getDirect(LTy, 0, nullptr, false); } -ABIArgInfo AMDGPUABIInfo::classifyArgumentType(QualType Ty, +ABIArgInfo AMDGPUABIInfo::classifyArgumentType(QualType Ty,

[compiler-rt] [libcxx] [libcxxabi] [libunwind] [libunwind][libcxx][libcxxabi][compiler-rt-builtins] Fix Exception Handling build for wasm (PR #79667)

2024-05-31 Thread via cfe-commits
https://github.com/trcrsired updated https://github.com/llvm/llvm-project/pull/79667 >From d73a87b47a549aeac7f4ea519037107a8f798df6 Mon Sep 17 00:00:00 2001 From: trcrsired Date: Fri, 26 Jan 2024 18:44:41 -0500 Subject: [PATCH] [libunwind][libcxx][libcxxabi] Fix Exception Handling build for wa

[compiler-rt] [libcxx] [libcxxabi] [libunwind] [libunwind][libcxx][libcxxabi][compiler-rt-builtins] Fix Exception Handling build for wasm (PR #79667)

2024-05-31 Thread via cfe-commits
https://github.com/trcrsired updated https://github.com/llvm/llvm-project/pull/79667 >From d73a87b47a549aeac7f4ea519037107a8f798df6 Mon Sep 17 00:00:00 2001 From: trcrsired Date: Fri, 26 Jan 2024 18:44:41 -0500 Subject: [PATCH] [libunwind][libcxx][libcxxabi] Fix Exception Handling build for wa

[clang] [clang] Fix a typo: ExplicitObje[C]tArgument. NFC (PR #94094)

2024-05-31 Thread Pavel Samolysov via cfe-commits
https://github.com/samolisov closed https://github.com/llvm/llvm-project/pull/94094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 26814bb - [clang] Fix a typo: ExplicitObje[C]tArgument. NFC (#94094)

2024-05-31 Thread via cfe-commits
Author: Pavel Samolysov Date: 2024-06-01T08:43:59+03:00 New Revision: 26814bbd4f65934d4e231ce407ec1b62c9d81df7 URL: https://github.com/llvm/llvm-project/commit/26814bbd4f65934d4e231ce407ec1b62c9d81df7 DIFF: https://github.com/llvm/llvm-project/commit/26814bbd4f65934d4e231ce407ec1b62c9d81df7.dif

[clang] [clang] Fix a typo: ExplicitObje[C]tArgument. NFC (PR #94094)

2024-05-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Pavel Samolysov (samolisov) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/94094.diff 1 Files Affected: - (modified) clang/lib/Sema/SemaTemplateDeduction.cpp (+8-7) ``diff diff --git a/clang/lib/Sema/SemaTe

[clang] [clang] Fix a typo: ExplicitObje[C]tArgument. NFC (PR #94094)

2024-05-31 Thread Pavel Samolysov via cfe-commits
https://github.com/samolisov created https://github.com/llvm/llvm-project/pull/94094 None >From 3ad23f75eff822360f349f5101d832fb769fe11d Mon Sep 17 00:00:00 2001 From: Pavel Samolysov Date: Sat, 1 Jun 2024 07:56:23 +0300 Subject: [PATCH] [clang] Fix a typo: ExplicitObje[C]tArgument. NFC ---

[clang] [clang][analyzer] Move unix.BlockInCriticalSection out of alpha (PR #93815)

2024-05-31 Thread Endre Fülöp via cfe-commits
gamesh411 wrote: Rebased and squashed noisy small commits. https://github.com/llvm/llvm-project/pull/93815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Move unix.BlockInCriticalSection out of alpha (PR #93815)

2024-05-31 Thread Endre Fülöp via cfe-commits
https://github.com/gamesh411 updated https://github.com/llvm/llvm-project/pull/93815 From 1da3d4dc3c74f1240e7d921c97b0c7eea2a53e33 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Endre=20F=C3=BCl=C3=B6p?= Date: Wed, 29 May 2024 00:38:07 +0200 Subject: [PATCH] [clang][analyzer] Move unix.BlockInCritica

[clang] [llvm] [clang][analyzer] Move unix.BlockInCriticalSection out of alpha (PR #93815)

2024-05-31 Thread Endre Fülöp via cfe-commits
https://github.com/gamesh411 updated https://github.com/llvm/llvm-project/pull/93815 From 429cbcfb14295aaf07997082fed0820b6f79f4f2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Endre=20F=C3=BCl=C3=B6p?= Date: Thu, 30 May 2024 11:28:12 +0200 Subject: [PATCH 1/2] [workflow] Add AI review for PRs ---

[clang] [lldb] [llvm] Remove some `try_compile` CMake checks for compiler flags (PR #92953)

2024-05-31 Thread Vladimir Vereschaka via cfe-commits
vvereschaka wrote: Hi @Endilll , these changes break MSVC build of the projects including LLDB. The `cl` compiler gets unsupported gcc/clang options, such as `-Wno-deprecated-declarations`, `-Wno-unknown-pragmas` and `-Wno-strict-aliasing`, and gets failed because of it. Here is the command

[clang] [clang-format] Don't always break before << between string literals (PR #92214)

2024-05-31 Thread Owen Pan via cfe-commits
owenca wrote: We should backport it to 18.1.7 IMO. See #93034 and #93958. WDYT @mydeveloperday @HazardyKnusperkeks? https://github.com/llvm/llvm-project/pull/92214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang] [compiler-rt] [llvm] [openmp] [PGO][Offload] Profile profraw generation for GPU instrumentation #76587 (PR #93365)

2024-05-31 Thread Ethan Luis McDonough via cfe-commits
https://github.com/EthanLuisMcDonough updated https://github.com/llvm/llvm-project/pull/93365 >From 530eb982b9770190377bb0bd09c5cb715f34d484 Mon Sep 17 00:00:00 2001 From: Ethan Luis McDonough Date: Fri, 15 Dec 2023 20:38:38 -0600 Subject: [PATCH 01/30] Add profiling functions to libomptarget

[clang] [llvm] [openmp] [PGO][OpenMP] Instrumentation for GPU devices (PR #76587)

2024-05-31 Thread Ethan Luis McDonough via cfe-commits
https://github.com/EthanLuisMcDonough updated https://github.com/llvm/llvm-project/pull/76587 >From 530eb982b9770190377bb0bd09c5cb715f34d484 Mon Sep 17 00:00:00 2001 From: Ethan Luis McDonough Date: Fri, 15 Dec 2023 20:38:38 -0600 Subject: [PATCH 01/21] Add profiling functions to libomptarget

[clang] [z/OS] Set the default arch for z/OS to be arch10 (PR #89854)

2024-05-31 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/89854 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [z/OS] Set the default arch for z/OS to be arch10 (PR #89854)

2024-05-31 Thread Fangrui Song via cfe-commits
@@ -4141,6 +4141,20 @@ // Begin SystemZ/GCC/Linux tests +// RUN: %clang -E -dM %s -o - 2>&1 \ +// RUN: -target s390x-ibm-zos \ MaskRay wrote: `--target=` for new driver tests. However, this does not test clangDriver and therefore `%clan

[clang] [z/OS] Set the default arch for z/OS to be arch10 (PR #89854)

2024-05-31 Thread Fangrui Song via cfe-commits
MaskRay wrote: > @FHe > > > > > @MaskRay Got it. > > > > The problem with that solution is that if you use --target you won't > > > > get the correct arch. This would be a problem for any cross > > > > compilation. For example, say you cross compile from zLinux (which > > > > wouldn't have th

[clang] [Driver] Remove a bunch of unnecessary REQUIRES constraints (PR #94055)

2024-05-31 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/94055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [llvm] [openmp] [PGO][Offload] Profile profraw generation for GPU instrumentation #76587 (PR #93365)

2024-05-31 Thread Ethan Luis McDonough via cfe-commits
https://github.com/EthanLuisMcDonough updated https://github.com/llvm/llvm-project/pull/93365 >From 530eb982b9770190377bb0bd09c5cb715f34d484 Mon Sep 17 00:00:00 2001 From: Ethan Luis McDonough Date: Fri, 15 Dec 2023 20:38:38 -0600 Subject: [PATCH 01/29] Add profiling functions to libomptarget

[clang] [llvm] [openmp] [PGO][OpenMP] Instrumentation for GPU devices (PR #76587)

2024-05-31 Thread Ethan Luis McDonough via cfe-commits
https://github.com/EthanLuisMcDonough updated https://github.com/llvm/llvm-project/pull/76587 >From 530eb982b9770190377bb0bd09c5cb715f34d484 Mon Sep 17 00:00:00 2001 From: Ethan Luis McDonough Date: Fri, 15 Dec 2023 20:38:38 -0600 Subject: [PATCH 01/20] Add profiling functions to libomptarget

[clang] Guard against nullptr (PR #94084)

2024-05-31 Thread via cfe-commits
https://github.com/Sterling-Augustine closed https://github.com/llvm/llvm-project/pull/94084 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 16832eb - Guard against nullptr (#94084)

2024-05-31 Thread via cfe-commits
Author: Sterling-Augustine Date: 2024-06-01T00:54:24Z New Revision: 16832eb58563f77d917198ad9f86db1c2ee162c9 URL: https://github.com/llvm/llvm-project/commit/16832eb58563f77d917198ad9f86db1c2ee162c9 DIFF: https://github.com/llvm/llvm-project/commit/16832eb58563f77d917198ad9f86db1c2ee162c9.diff

[clang] Guard against nullptr (PR #94084)

2024-05-31 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff bba5ee47e63298d61f6ea441a140144ce370ba92 169e09f2aa403676873a440d8496356cefe69b9e --

[clang] Guard against nullptr (PR #94084)

2024-05-31 Thread via cfe-commits
https://github.com/Sterling-Augustine edited https://github.com/llvm/llvm-project/pull/94084 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Guard against nullptr (PR #94084)

2024-05-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (Sterling-Augustine) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/94084.diff 1 Files Affected: - (modified) clang/lib/AST/QualTypeNames.cpp (+3-2) ``diff diff --git a/clang/lib/AST/QualTypeNames.cpp

[clang] Guard against nullptr (PR #94084)

2024-05-31 Thread via cfe-commits
https://github.com/Sterling-Augustine created https://github.com/llvm/llvm-project/pull/94084 None >From 169e09f2aa403676873a440d8496356cefe69b9e Mon Sep 17 00:00:00 2001 From: Sterling Augustine Date: Fri, 31 May 2024 23:18:32 + Subject: [PATCH] Guard against nullptr --- clang/lib/AST/Q

[clang] [compiler-rt] [ubsan] Display correct runtime messages for negative _BitInt (PR #93612)

2024-05-31 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,188 @@ +// RUN: %clang -Wno-constant-conversion -Wno-array-bounds -Wno-division-by-zero -Wno-shift-negative-value -Wno-shift-count-negative -Wno-int-to-pointer-cast -O0 -fsanitize=alignment,array-bounds,bool,float-cast-overflow,implicit-integer-sign-change,implicit-s

[clang] [compiler-rt] [ubsan] Display correct runtime messages for negative _BitInt (PR #93612)

2024-05-31 Thread via cfe-commits
https://github.com/earnol updated https://github.com/llvm/llvm-project/pull/93612 >From 5e2f1afedba7d9e65b7dbbbfa5697f9cd686d193 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?E=C3=A4nolituri=20L=C3=B3mitaur=C3=AB?= Date: Fri, 24 May 2024 11:39:35 -0400 Subject: [PATCH] [ubsan] Display correct runti

[clang] [compiler-rt] [ubsan] Display correct runtime messages for negative _BitInt (PR #93612)

2024-05-31 Thread via cfe-commits
https://github.com/earnol updated https://github.com/llvm/llvm-project/pull/93612 >From 3713f9acf5968d7e1f8b3800f36ead1f6ea341ec Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?E=C3=A4nolituri=20L=C3=B3mitaur=C3=AB?= Date: Fri, 24 May 2024 11:39:35 -0400 Subject: [PATCH] [ubsan] Display correct runti

[clang] [clang] Fix self-capturing `__block` variables (PR #89475)

2024-05-31 Thread via cfe-commits
@@ -2120,27 +2066,33 @@ void CodeGenFunction::EmitAutoVarCleanups(const AutoVarEmission &emission) { // us from jumping into any of these scopes anyway. if (!HaveInsertPoint()) return; - const VarDecl &D = *emission.Variable; + // If we're initializing directly on the h

[clang] [llvm] [AMDGPU] Implement variadic functions by IR lowering (PR #93362)

2024-05-31 Thread Jon Chesterfield via cfe-commits
@@ -103,19 +104,27 @@ void AMDGPUABIInfo::computeInfo(CGFunctionInfo &FI) const { if (!getCXXABI().classifyReturnType(FI)) FI.getReturnInfo() = classifyReturnType(FI.getReturnType()); + unsigned ArgumentIndex = 0; + const unsigned numFixedArguments = FI.getNumRequired

[clang] [amdgpu] Pass variadic arguments without splitting (PR #94083)

2024-05-31 Thread Jon Chesterfield via cfe-commits
https://github.com/JonChesterfield edited https://github.com/llvm/llvm-project/pull/94083 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix self-capturing `__block` variables (PR #89475)

2024-05-31 Thread via cfe-commits
@@ -2653,11 +2655,39 @@ const BlockByrefInfo &CodeGenFunction::getBlockByrefInfo(const VarDecl *D) { info.FieldOffset = varOffset; info.ByrefAlignment = std::max(varAlign, getPointerAlign()); + // If we're initializing directly on the heap, then we should emit a + // no

[clang] [WIP][Safe Buffers] Serialize unsafe_buffer_usage pragmas (PR #92031)

2024-05-31 Thread Ziqing Luo via cfe-commits
ziqingluo-90 wrote: Just realized how stupid I am (O_o)---the current implementation only compares source locations with opt-out regions that are in the same source file, for all source locations from loaded files. This is not going to work for cases like below. ``` // in a pch header: #prag

[clang] [WIP][Safe Buffers] Serialize unsafe_buffer_usage pragmas (PR #92031)

2024-05-31 Thread Ziqing Luo via cfe-commits
https://github.com/ziqingluo-90 edited https://github.com/llvm/llvm-project/pull/92031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix self-capturing `__block` variables (PR #89475)

2024-05-31 Thread via cfe-commits
@@ -2653,11 +2655,39 @@ const BlockByrefInfo &CodeGenFunction::getBlockByrefInfo(const VarDecl *D) { info.FieldOffset = varOffset; info.ByrefAlignment = std::max(varAlign, getPointerAlign()); + // If we're initializing directly on the heap, then we should emit a + // no

[clang-tools-extra] [llvm] [clang][clang-doc] Add basic e2e test to clang-doc (PR #93928)

2024-05-31 Thread via cfe-commits
https://github.com/PeterChou1 edited https://github.com/llvm/llvm-project/pull/93928 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Improve BlockIndent at ColumnLimit (PR #93140)

2024-05-31 Thread Gedare Bloom via cfe-commits
@@ -803,6 +803,46 @@ void ContinuationIndenter::addTokenOnCurrentLine(LineState &State, bool DryRun, return !Tok.Previous->isOneOf(TT_CastRParen, tok::kw_for, tok::kw_while, tok::kw_switch); }; + // Detecting functions is brittle. It wo

[clang] [clang-format] Improve BlockIndent at ColumnLimit (PR #93140)

2024-05-31 Thread Gedare Bloom via cfe-commits
@@ -803,6 +803,46 @@ void ContinuationIndenter::addTokenOnCurrentLine(LineState &State, bool DryRun, return !Tok.Previous->isOneOf(TT_CastRParen, tok::kw_for, tok::kw_while, tok::kw_switch); }; + // Detecting functions is brittle. It wo

[clang] [clang-format] Improve BlockIndent at ColumnLimit (PR #93140)

2024-05-31 Thread Gedare Bloom via cfe-commits
https://github.com/gedare updated https://github.com/llvm/llvm-project/pull/93140 >From 27a2da876926d2157ea9f18c5fd71a2e81e097fc Mon Sep 17 00:00:00 2001 From: Gedare Bloom Date: Tue, 21 May 2024 22:21:59 -0600 Subject: [PATCH 1/3] [clang-format] Improve BlockIndent at ColumnLimit Fixes #55731

[clang] [clang] Fix self-capturing `__block` variables (PR #89475)

2024-05-31 Thread via cfe-commits
@@ -2499,21 +2501,21 @@ CodeGenFunction::buildByrefHelpers(llvm::StructType &byrefType, // byref routines. case Qualifiers::OCL_Weak: return ::buildByrefHelpers(CGM, byrefInfo, - ARCWeakByrefHelpers(valueAlignment)); +

[clang-tools-extra] [llvm] Clang doc test (PR #93928)

2024-05-31 Thread via cfe-commits
https://github.com/PeterChou1 edited https://github.com/llvm/llvm-project/pull/93928 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Remove a bunch of unnecessary REQUIRES constraints (PR #94055)

2024-05-31 Thread Alexander Richardson via cfe-commits
@@ -1,6 +1,4 @@ // REQUIRES: system-linux arichardson wrote: Unrelated, but I don't see why this would fail on e.g. a FreeBSD host. Maybe it should be !WINDOWS? Although that should also be handled by REQUIRES: shell https://github.com/llvm/llvm-project/pull/9

[clang] [Driver] Remove a bunch of unnecessary REQUIRES constraints (PR #94055)

2024-05-31 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson approved this pull request. In the past I've cleaned up some local unnecessary REQUIRES: foo-registered-target in a downstream fork, good to see this being fixed upstream as well. I often build only a subset of targets so it's good to see more test coverage for t

[clang] [Driver] Remove a bunch of unnecessary REQUIRES constraints (PR #94055)

2024-05-31 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson edited https://github.com/llvm/llvm-project/pull/94055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU] Implement variadic functions by IR lowering (PR #93362)

2024-05-31 Thread Jon Chesterfield via cfe-commits
@@ -10,6 +10,50 @@ #include "test/UnitTest/Test.h" +#include "src/__support/OSUtil/io.h" +#include "src/__support/integer_to_string.h" +using namespace LIBC_NAMESPACE; + +namespace { + +void nl() { write_to_stderr("\n"); } +void dump(const char *s) { + write_to_stderr(s); +

[clang] [lldb] [clang][lldb] Don't assert structure layout correctness for layouts provided by LLDB (PR #93809)

2024-05-31 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: > > The correct answer here is probably to fix the sizes in the RecordLayout > > itself; in particular, the DataSize of the members. > > That would be ideal, but also means we'd have to reflect the various C++ > attributes that affect layout in DWARF. Avoiding adding such

[clang] [Clang][objectsize] Generate object size calculation for sub-objects (PR #86858)

2024-05-31 Thread Eli Friedman via cfe-commits
@@ -1062,6 +1063,159 @@ CodeGenFunction::emitFlexibleArrayMemberSize(const Expr *E, unsigned Type, return Builder.CreateSelect(Cmp, Res, ConstantInt::get(ResType, 0, IsSigned)); } +namespace { + +class ObjectSizeVisitor +: public ConstStmtVisitor { + bool SkipASE; + +

[clang] [llvm] [AArch64] set AppleA14 architecture version to v8.4-a (PR #92600)

2024-05-31 Thread Ahmed Bougacha via cfe-commits
ahmedbougacha wrote: > > Correct, apple-m1 does not have BTI, but BTI is required for v8.5. My > > mistake. > > Not sure if you are involved in writing the optimization guide itself at > Apple, but the way the chip is described as having 8.5 minus BTI is a bit > confusing since that would tec

[clang] [llvm] [AArch64] set AppleA14 architecture version to v8.4-a (PR #92600)

2024-05-31 Thread Ahmed Bougacha via cfe-commits
@@ -718,12 +718,16 @@ def ProcessorFeatures { list AppleA13 = [HasV8_4aOps, FeatureCrypto, FeatureFPARMv8, FeatureNEON, FeaturePerfMon, FeatureFullFP16, FeatureFP16FML, FeatureSHA3]; + // Apple A14 a

[clang] [clang] AST Visitor: skip empty qualifiers in QualifiedTemplateName (PR #93926)

2024-05-31 Thread via cfe-commits
Sterling-Augustine wrote: Even with this fix, I'm seeing a segfault in clang/lib/AST/QualTypeNames.cpp at line 216. ``` switch(Scope->getKind()) { ``` Scope is nullptr. The call is from line 70: ``` QualifiedTemplateName *QTName = TName.getAsQualifiedTemplateName(); if (QTName && !QTNa

[clang] [lldb] [clang][lldb] Don't assert structure layout correctness for layouts provided by LLDB (PR #93809)

2024-05-31 Thread Michael Buch via cfe-commits
Michael137 wrote: > The correct answer here is probably to fix the sizes in the RecordLayout > itself; in particular, the DataSize of the members. That would be ideal, but also means we'd have to reflect the various C++ attributes that affect layout in DWARF. Avoiding adding such language-spec

[clang] [Driver] Remove a bunch of unnecessary REQUIRES constraints (PR #94055)

2024-05-31 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 approved this pull request. I've wondered about these as well, there might also be some OpenMP tests that have `requries powerpc-registered-target` or similar that could be removed. I guess we'll see what the CI thinks with this patch. https://github.com/llvm/llvm-

[clang] [Driver] Remove a bunch of unnecessary REQUIRES constraints (PR #94055)

2024-05-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-driver Author: Paul T Robinson (pogo59) Changes Removed foo-registered-target constraints from a bunch of tests, because mostly the driver doesn't need to have a target availabile. I ran check-clang-driver using a build

[clang] [Driver] Remove a bunch of unnecessary REQUIRES constraints (PR #94055)

2024-05-31 Thread Paul T Robinson via cfe-commits
https://github.com/pogo59 created https://github.com/llvm/llvm-project/pull/94055 Removed foo-registered-target constraints from a bunch of tests, because mostly the driver doesn't need to have a target availabile. I ran check-clang-driver using a build with only the XCore target, and these al

[clang] [clang] Split up `SemaDeclAttr.cpp` (PR #93966)

2024-05-31 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: > Would it make sense to add a new header (SemaUtils.h? SemaTargetUtils.h?) to > move most of the exposed templated helpers to instead of Sema.h? That's what `Sema/Attr.h` does, and those helpers for attribute handling went there. https://github.com/llvm/llvm-project/pull/93966

[clang] [compiler-rt] [ubsan] Display correct runtime messages for negative _BitInt (PR #93612)

2024-05-31 Thread via cfe-commits
@@ -3292,22 +3307,39 @@ LValue CodeGenFunction::EmitPredefinedLValue(const PredefinedExpr *E) { /// { i16 TypeKind, i16 TypeInfo } /// \endcode /// -/// followed by an array of i8 containing the type name. TypeKind is 0 for an -/// integer, 1 for a floating point value, and

[clang] [compiler-rt] [ubsan] Display correct runtime messages for negative _BitInt (PR #93612)

2024-05-31 Thread via cfe-commits
@@ -103,6 +103,14 @@ class TypeDescriptor { /// representation is that of bitcasting the floating-point value to an /// integer type. TK_Float = 0x0001, +/// An _BitInt(N) type. Lowest bit is 1 for a signed value, 0 for an +/// unsigned +/// value. Remai

[clang] [compiler-rt] [ubsan] Display correct runtime messages for negative _BitInt (PR #93612)

2024-05-31 Thread via cfe-commits
@@ -0,0 +1,188 @@ +// RUN: %clang -Wno-constant-conversion -Wno-array-bounds -Wno-division-by-zero -Wno-shift-negative-value -Wno-shift-count-negative -Wno-int-to-pointer-cast -O0 -fsanitize=alignment,array-bounds,bool,float-cast-overflow,implicit-integer-sign-change,implicit-s

[clang] [compiler-rt] [ubsan] Display correct runtime messages for negative _BitInt (PR #93612)

2024-05-31 Thread via cfe-commits
@@ -125,6 +138,26 @@ class TypeDescriptor { return 1 << (TypeInfo >> 1); } + const char *getBitIntBitCountPointer() const { +CHECK(isBitIntTy()); +CHECK(isSignedBitIntTy()); +// Scan Name for zero and return the next address +const char *p = getTypeName(

[clang] [Bounds-Safety] Add sized_by, counted_by_or_null & sized_by_or_null (PR #93231)

2024-05-31 Thread Henrik G. Olsson via cfe-commits
hnrklssn wrote: Rebased on main after @delcypher's patch was relanded. Addressing comments now. https://github.com/llvm/llvm-project/pull/93231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[clang] [compiler-rt] [ubsan] Display correct runtime messages for negative _BitInt (PR #93612)

2024-05-31 Thread via cfe-commits
@@ -0,0 +1,188 @@ +// RUN: %clang -Wno-constant-conversion -Wno-array-bounds -Wno-division-by-zero -Wno-shift-negative-value -Wno-shift-count-negative -Wno-int-to-pointer-cast -O0 -fsanitize=alignment,array-bounds,bool,float-cast-overflow,implicit-integer-sign-change,implicit-s

[clang] [clang] Split up `SemaDeclAttr.cpp` (PR #93966)

2024-05-31 Thread Simon Pilgrim via cfe-commits
RKSimon wrote: Would it make sense to add a new header (SemaUtils.h? SemaTargetUtils.h?) to move most of the exposed templated helpers to instead of Sema.h? https://github.com/llvm/llvm-project/pull/93966 ___ cfe-commits mailing list cfe-commits@lists

[clang] [Bounds-Safety] Add sized_by, counted_by_or_null & sized_by_or_null (PR #93231)

2024-05-31 Thread Henrik G. Olsson via cfe-commits
https://github.com/hnrklssn updated https://github.com/llvm/llvm-project/pull/93231 >From 5c5a28415f2cc10525f07784e6896718cc38624f Mon Sep 17 00:00:00 2001 From: "Henrik G. Olsson" Date: Thu, 23 May 2024 11:44:41 -0700 Subject: [PATCH] [Bounds-Safety] Add sized_by, counted_by_or_null & sized_b

[clang] [X86] Add support for MS inp functions. (PR #93804)

2024-05-31 Thread Simon Pilgrim via cfe-commits
https://github.com/RKSimon commented: Maybe add this to ReleaseNotes? https://github.com/llvm/llvm-project/pull/93804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86]Add support for _outp{|w|d} (PR #93774)

2024-05-31 Thread Simon Pilgrim via cfe-commits
https://github.com/RKSimon commented: Maybe add a line to ReleaseNotes? But otherwise SGTM https://github.com/llvm/llvm-project/pull/93774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[clang] [llvm] Intrinsic: introduce minimumnum and maximumnum (PR #93841)

2024-05-31 Thread Matt Arsenault via cfe-commits
@@ -32,27 +32,29 @@ class StoreInst; /// These are the kinds of recurrences that we support. enum class RecurKind { - None, ///< Not a recurrence. - Add, ///< Sum of integers. - Mul, ///< Product of integers. - Or, ///< Bitwise or logical OR of integers

[clang] [llvm] [AMDGPU] Extend readlane, writelane and readfirstlane intrinsic lowering for generic types (PR #89217)

2024-05-31 Thread Matt Arsenault via cfe-commits
arsenm wrote: You should add the mentioned convergence-tokens.ll test function https://github.com/llvm/llvm-project/pull/89217 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Improve BlockIndent at ColumnLimit (PR #93140)

2024-05-31 Thread Gedare Bloom via cfe-commits
@@ -6157,6 +6157,12 @@ bool TokenAnnotator::canBreakBefore(const AnnotatedLine &Line, return !(Previous && (Previous->is(tok::kw_for) || Previous->isIf())); } + if (Left.isOneOf(tok::r_paren, TT_TrailingAnnotation) && gedare wrote: yes, it is part of

[clang] [compiler-rt] [ubsan] Display correct runtime messages for negative _BitInt (PR #93612)

2024-05-31 Thread via cfe-commits
@@ -3318,6 +3350,20 @@ llvm::Constant *CodeGenFunction::EmitCheckTypeDescriptor(QualType T) { DiagnosticsEngine::ak_qualtype, (intptr_t)T.getAsOpaquePtr(), StringRef(), StringRef(), std::nullopt, Buffer, std::nullopt); + if (IsBitInt) { +// The Structure is:

[clang] [compiler-rt] [ubsan] Display correct runtime messages for negative _BitInt (PR #93612)

2024-05-31 Thread via cfe-commits
@@ -64,6 +65,20 @@ static llvm::cl::opt ClSanitizeGuardChecks( "ubsan-guard-checks", llvm::cl::Optional, llvm::cl::desc("Guard UBSAN checks with `llvm.allow.ubsan.check()`.")); +//======// +//

[clang] [Clang][objectsize] Generate object size calculation for sub-objects (PR #86858)

2024-05-31 Thread Bill Wendling via cfe-commits
@@ -1062,6 +1063,159 @@ CodeGenFunction::emitFlexibleArrayMemberSize(const Expr *E, unsigned Type, return Builder.CreateSelect(Cmp, Res, ConstantInt::get(ResType, 0, IsSigned)); } +namespace { + +class ObjectSizeVisitor +: public ConstStmtVisitor { + bool SkipASE; + +

[clang] [Clang][objectsize] Generate object size calculation for sub-objects (PR #86858)

2024-05-31 Thread Bill Wendling via cfe-commits
@@ -1062,6 +1063,160 @@ CodeGenFunction::emitFlexibleArrayMemberSize(const Expr *E, unsigned Type, return Builder.CreateSelect(Cmp, Res, ConstantInt::get(ResType, 0, IsSigned)); } +namespace { + +class ObjectSizeVisitor +: public ConstStmtVisitor { + ASTContext &Ctx;

[clang] [llvm] [Support] Add SipHash-based 16/64-bit ptrauth stable hash. (PR #93902)

2024-05-31 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 8578b60758e6a588ec41a9678829cebec471f8e5 8e9ab9cfe45e6c958046d5a9575aedfc4cb29c0c --

[clang] [lldb] [llvm] [openmp] [polly] fix(python): fix comparison to True/False (PR #91858)

2024-05-31 Thread Eisuke Kawashima via cfe-commits
e-kwsm wrote: Broken into - #94038 - #94039 - #94040 - #94041 - #94042 https://github.com/llvm/llvm-project/pull/91858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [llvm] [openmp] [polly] fix(python): fix comparison to True/False (PR #91858)

2024-05-31 Thread Eisuke Kawashima via cfe-commits
https://github.com/e-kwsm closed https://github.com/llvm/llvm-project/pull/91858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Support] Add SipHash-based 16/64-bit ptrauth stable hash. (PR #93902)

2024-05-31 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha updated https://github.com/llvm/llvm-project/pull/93902 >From fc8f76b404b25951dc10ecaaa760b4b4c3d4f858 Mon Sep 17 00:00:00 2001 From: Ahmed Bougacha Date: Thu, 30 May 2024 17:07:04 -0700 Subject: [PATCH 1/2] [clang] Add arm64e ABI-defined key assignments to ptr

[clang] fix(clang/**.py): fix comparison to True/False (PR #94038)

2024-05-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Eisuke Kawashima (e-kwsm) Changes from PEP8 (https://peps.python.org/pep-0008/#programming-recommendations): > Comparisons to singletons like None should always be done with is or is not, never the equality operators. -

[clang] fix(clang/**.py): fix comparison to True/False (PR #94038)

2024-05-31 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Eisuke Kawashima (e-kwsm) Changes from PEP8 (https://peps.python.org/pep-0008/#programming-recommendations): > Comparisons to singletons like None should always be done with is or is not, never the equality operators. --- Full diff: http

[clang] fix(clang/**.py): fix comparison to True/False (PR #94038)

2024-05-31 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] fix(clang/**.py): fix comparison to True/False (PR #94038)

2024-05-31 Thread Eisuke Kawashima via cfe-commits
https://github.com/e-kwsm created https://github.com/llvm/llvm-project/pull/94038 from PEP8 (https://peps.python.org/pep-0008/#programming-recommendations): > Comparisons to singletons like None should always be done with is or is not, > never the equality operators. >From 33ef0fc3c3434283ca2

[clang] [llvm] [Support] Add SipHash-based 16/64-bit ptrauth stable hash. (PR #93902)

2024-05-31 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha edited https://github.com/llvm/llvm-project/pull/93902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add arm64e ABI-defined key assignments to ptrauth.h. (PR #93901)

2024-05-31 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha closed https://github.com/llvm/llvm-project/pull/93901 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 8578b60 - [clang] Add ABI-defined key assignments to ptrauth.h. (#93901)

2024-05-31 Thread via cfe-commits
Author: Ahmed Bougacha Date: 2024-05-31T13:03:30-07:00 New Revision: 8578b60758e6a588ec41a9678829cebec471f8e5 URL: https://github.com/llvm/llvm-project/commit/8578b60758e6a588ec41a9678829cebec471f8e5 DIFF: https://github.com/llvm/llvm-project/commit/8578b60758e6a588ec41a9678829cebec471f8e5.diff

[clang] [lldb] [llvm] [openmp] [polly] fix(python): fix comparison to True/False (PR #91858)

2024-05-31 Thread Eisuke Kawashima via cfe-commits
https://github.com/e-kwsm updated https://github.com/llvm/llvm-project/pull/91858 >From cdc6e7c4ee2238e82fb9bf1754962d0aff10422b Mon Sep 17 00:00:00 2001 From: Eisuke Kawashima Date: Sun, 12 May 2024 00:06:53 +0900 Subject: [PATCH 1/2] fix(python): fix comparison to True/False from PEP8 (https

[clang] [clang] Add arm64e ABI-defined key assignments to ptrauth.h. (PR #93901)

2024-05-31 Thread Ahmed Bougacha via cfe-commits
@@ -15,6 +15,29 @@ typedef enum { ptrauth_key_asib = 1, ptrauth_key_asda = 2, ptrauth_key_asdb = 3, + +#ifdef __APPLE__ ahmedbougacha wrote: Great, let's do that; I also removed the comments that talk about enablement policy, that seems like a separate

[clang] [clang] Add arm64e ABI-defined key assignments to ptrauth.h. (PR #93901)

2024-05-31 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha updated https://github.com/llvm/llvm-project/pull/93901 >From fc8f76b404b25951dc10ecaaa760b4b4c3d4f858 Mon Sep 17 00:00:00 2001 From: Ahmed Bougacha Date: Thu, 30 May 2024 17:07:04 -0700 Subject: [PATCH 1/2] [clang] Add arm64e ABI-defined key assignments to ptr

[clang] [llvm] [MC] Make UseAssemblerInfoForParsing mostly true (PR #91082)

2024-05-31 Thread via cfe-commits
gulfemsavrun wrote: > > > @gulfemsavrun Commit > > > [245491a](https://github.com/llvm/llvm-project/commit/245491a9f384e4c53421196533c2a2b693efaf8d) > > > (`[MC] Disable MCAssembler based constant folding for DwarfDebug`; > > > independent of this patch) should have fixed the compile time regr

[clang] [llvm] [EntryExitInstrumenter] Move passes out of clang into LLVM default pipelines (PR #92171)

2024-05-31 Thread via cfe-commits
github-actions[bot] wrote: @pasko Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build, y

[clang] [clang-tools-extra] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] [polly] fix(python): fix invalid escape sequences (PR #91856)

2024-05-31 Thread Eisuke Kawashima via cfe-commits
e-kwsm wrote: broken into - #94028 - #94029 - #94030 - #94031 - #94032 - #94033 - #94034 - #94035 - #94036 - #94037 https://github.com/llvm/llvm-project/pull/91856 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang] [clang-tools-extra] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] [polly] fix(python): fix invalid escape sequences (PR #91856)

2024-05-31 Thread Eisuke Kawashima via cfe-commits
https://github.com/e-kwsm closed https://github.com/llvm/llvm-project/pull/91856 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [EntryExitInstrumenter] Move passes out of clang into LLVM default pipelines (PR #92171)

2024-05-31 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks closed https://github.com/llvm/llvm-project/pull/92171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [EntryExitInstrumenter] Move passes out of clang into LLVM default pipelines (PR #92171)

2024-05-31 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: thanks for doing this! https://github.com/llvm/llvm-project/pull/92171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] cab81dd - [EntryExitInstrumenter] Move passes out of clang into LLVM default pipelines (#92171)

2024-05-31 Thread via cfe-commits
Author: Egor Pasko Date: 2024-05-31T12:48:45-07:00 New Revision: cab81dd03813ac6333ad7fc031d72b84341fe2b9 URL: https://github.com/llvm/llvm-project/commit/cab81dd03813ac6333ad7fc031d72b84341fe2b9 DIFF: https://github.com/llvm/llvm-project/commit/cab81dd03813ac6333ad7fc031d72b84341fe2b9.diff LO

[clang] [llvm] [EntryExitInstrumenter] Move passes out of clang into LLVM default pipelines (PR #92171)

2024-05-31 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks approved this pull request. https://github.com/llvm/llvm-project/pull/92171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   5   >